Sorted based on the number of comments given to others' PRs, but also showing comments on own PRs and other comments given.
[This page was last updated on Oct 23 2020]
@dextertanyj (246 comments)1 (commented on others PR)
I think we can remove this test case.
2 (commented on others PR)
// Keywords match phone and email, but does not match name
3 (commented on others PR)
Should remove INVALID_ADDRESS and VALID_ADDRESS from constant declarations above as well.
4 (commented on others PR)
Is there a particular reason as to why this test case was removed? Perhaps we can use a different invalid value instead of removing the entire test case.
5 (commented on others PR)
Should probably remove the above
@FXML
private Label address;
as well.
6 (commented on others PR)
platform for tutors to handle all of their administrative matters.
7 (commented on others PR)
- Tutor's Pet displays your upcoming lessons so that you will never forget about them again.
8 (commented on others PR)
Not sure if this would sound more in line with the other points since the word 'your' was used in both the other.
- Tutor's Pet allows you to mark your students' attendance and participation for each lesson.
9 (commented on others PR)
Nice catch!
10 (commented on others PR)
public static final String MESSAGE_SUCCESS = "Listed all students.";
11 (commented on others PR)
Perhaps we can update the Tag examples to something that's more student-tutor relationship like. Maybe something like how the student is performing in class.
12 (commented on others PR)
This line shouldn't change.
13 (commented on others PR)
Similar here, would be good to update the example tags.
14 (commented on others PR)
Would be good to update this test constant as well.
15 (commented on others PR)
Command word should be in kebab case.
16 (commented on others PR)
Command word should be in kebab case. Perhaps can change the title to "Listing all students within a class".
17 (commented on others PR)
We should retain the generated table of contents instead of using simple bullet points.
18 (commented on others PR)
I think the second add is redundant.
19 (commented on others PR)
Ellipsis should remain outside of the square brackets since users need to repeat the prefix as well.
20 (commented on others PR)
I don't think we are supporting the separation of CLASS_NAME from MODULE_CODE?
21 (commented on others PR)
Need to remove the address field in this section as well and update the tag prefix.
22 (commented on others PR)
Need to update tag prefix here as well.
23 (commented on others PR)
I don't think name, telegram handle and email are optional fields.
24 (commented on others PR)
We need to rethink the command syntax for this operation. The parsing of arguments will be troublesome in this format.
For now maybe we can leave this feature out of the UG.
25 (commented on others PR)
Kind of weird I'm a Project Advisor in the project I'm working on. Maybe Lead Developer would make more sense, but I'll change that in my own AboutUs update later.
26 (commented on others PR)
* **`add`**`n/John Doe t/@johndoe e/johnd@example.com tag/student` : Adds a student named `John Doe` to the application.
27 (commented on others PR)
The second example should include more than one tag to show the possible multiplicities.
e.g. `[tag/TAG]…` can be used as ` ` (i.e. 0 times), `tag/student`, `tag/Average tag/TA Candidate` etc.
28 (commented on others PR)
Format: `add n/NAME t/TELEGRAM_HANDLE e/EMAIL [tag/TAG]…`
29 (commented on others PR)
Format: `edit INDEX [n/NAME] [t/TELEGRAM_HANDLE] [e/EMAIL] [tag/TAG]…`
30 (commented on others PR)
Not sure if this is the best implementation since the /by prefix will have no values associated with it when parsed by the ArgumentTokenizer
* `list-students c/CS2103T Tutorial T10`
31 (commented on others PR)
**Add Student** | `add n/NAME t/TELEGRAM_HANDLE e/EMAIL [tag/TAG]…` <br> e.g., `add n/John Doe t/@johndoe e/johnd@example.com tag/student`
32 (commented on others PR)
**Edit Student** | `edit INDEX [n/NAME] [t/TELEGRAM_HANDLE] [e/EMAIL] [tag/TAG]…`<br> e.g.,`edit 2 n/James Lee e/jameslee@example.com`
33 (commented on others PR)
**List Students in a Class** | `list-students c/CLASS_NAME`<br> e.g., `list-students c/CS2103T Tutorial T10`
34 (commented on others PR)
| `* * *` | Tutor with many students | Store my students' contact info/emails | Contact them easily |
35 (commented on others PR)
Links an existing student to an existing class in the application.
36 (commented on others PR)
* `list` followed by `link s/1 c/2` links the 1st student in the application to the 2nd class in the application.
* `find Betsy` followed by `link s/1 c/2` links the 1st student in the results of the `find` command to the 2nd class in the application.
37 (commented on others PR)
#### Linking a student to a class: `link`
38 (commented on others PR)
Should we update the rest of the use cases to use full stops as well?
39 (commented on others PR)
Hmm, I think summary should remain after the detailed explanation, since it serves so summarise the above mentioned information.
40 (commented on others PR)
In and A shouldn't be capitalised in the title.
41 (commented on others PR)
I think we should retain the present participle form of the verb? The CS2101 set of slides for "Writing User Guide" also seems to favour retaining the present participle form of verbs, although it does not seem explicitly mentioned.
42 (commented on others PR)
* 3a. No students found.
43 (commented on others PR)
Would be good to mention that it is a message, otherwise might be confusing how to show an absence of something.
44 (commented on others PR)
Should we keep it consistent and use delete instead of clear?
45 (commented on others PR)
Technically Tutor's Pet can return more than one student found, so maybe it would be good to mention that it shows all matching students.
46 (commented on others PR)
Applies to finding classes as well.
47 (commented on others PR)
## Command overview
48 (commented on others PR)
#### Clearing all students : `clear-student`
49 (commented on others PR)
#### Clearing all classes : `clear-class`
50 (commented on others PR)
| UC13 | Link a student to a class |
| UC14 | Unlink a student from a class |
51 (commented on others PR)
**Use case: UC14 - Unlink a student from a class**
52 (commented on others PR)
**Use case: UC13 - Link a student to a class**
53 (commented on others PR)
| UC12 | Clear all classes |
| UC13 | Link a student to a class. |
| UC14 | Unlink a student from a class |
54 (commented on others PR)
assertParseFailure(parser, NAME_DESC_BOB + VALID_PHONE_BOB + EMAIL_DESC_BOB,
55 (commented on others PR)
assertParseFailure(parser, VALID_NAME_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB,
56 (commented on others PR)
assertParseFailure(parser, NAME_DESC_BOB + PHONE_DESC_BOB + VALID_EMAIL_BOB,
57 (commented on others PR)
public static final String MESSAGE_SUCCESS = "All students in Tutor's Pet have been cleared!";
58 (commented on others PR)
Perhaps we can rename this to getAddStudentCommand(Student student)
59 (commented on others PR)
public void parseCommand_editStudent() throws Exception {
60 (commented on others PR)
public void parseCommand_deleteStudent() throws Exception {
61 (commented on others PR)
public void parseCommand_addStudent() throws Exception {
62 (commented on others PR)
public void parseCommand_clearStudent() throws Exception {
63 (commented on others PR)
public void parseCommand_findStudent() throws Exception {
64 (commented on others PR)
public void parse_validArgs_returnsFindStudentCommand() {
65 (commented on others PR)
public void parse_validArgs_returnsDeleteStudentCommand() {
66 (commented on others PR)
I don't think we should allow the explicit setting or getting of UUID in EditStudentDescriptor since it would then no longer be editing the same student.
67 (commented on others PR)
The editedUuid should always be that of the studentToEdit.
68 (commented on others PR)
I think it would be good to set a default UUID for each student in the tests and not rely on randomly generated data. This way it would be more predictable and testable.
69 (commented on others PR)
I don't think there is a need for EditStudentDescriptor to have a uuid field.
70 (commented on others PR)
requireAllNonNull(uuid, name, phone, email, tags);
71 (commented on others PR)
It would be good to edit the constructors in the TypicalStudents file as well to ensure the test constants are truly identical.
72 (commented on others PR)
73 (commented on others PR)
private static ModuleClass createEditedModuleClass(ModuleClass moduleClassToEdit,
EditModuleClassDescriptor editModuleClassDescriptor) {
74 (commented on others PR)
* Parses input arguments and create a new EditModuleClassCommand object.
75 (commented on others PR)
* Parses {@code userInput} into a {@code StudentNameContainsKeywordsPredicate}.
76 (commented on others PR)
There's quite a bit of overlap here, would be good to deduplicate into:
public static final Index INDEX_FIRST_ITEM= Index.fromOneBased(1);
public static final Index INDEX_SECOND_ITEM = Index.fromOneBased(2);
public static final Index INDEX_THIRD_ITEM = Index.fromOneBased(3);
77 (commented on others PR)
* A utility class for ModuleClass.
78 (commented on others PR)
Seeing this template always makes me feel like they have already foreshadowed that we should do undo/redo features.
* Contains integration tests (interaction with the Model) and unit tests for
79 (commented on others PR)
* A UI component that displays information of a {@code ModuleClass}.
80 (commented on others PR)
Since we seem to be standardising to capitalise UI.
// Independent UI parts residing in this UI container
81 (commented on others PR)
It should be A UI because in both user interface and UI the word/abbreviation is pronounced as though it starts with the consonant y.
82 (commented on others PR)
* A UI component that displays information of a {@code Student}.
83 (commented on others PR)
-fx-background-color: transparent, #274156, transparent, #274156;
84 (commented on others PR)
I think it would be best to define the return type as Label since we do in fact return a Label.
85 (commented on others PR)
* Converts this Jackson-friendly adapted class object into the model's {@code ModuleClass} object.
86 (commented on others PR)
* Converts a given {@code UUID} into this class for Jackson use.
87 (commented on others PR)
* Converts this Jackson-friendly adapted UUID object into the model's {@code UUID} object.
88 (commented on others PR)
* @throws IllegalValueException if adapted UUID is null.
89 (commented on others PR)
I think it would be a good idea to introduce some checks for invalid UUIDs since the user can go into the json file to edit entries manually.
90 (commented on others PR)
I would agree with @junlong4321 on this, it would be good to isolate any possible failure to just students.
While in invalidClassTutorsPet.json, students would be useful in the future when we implement validation for students who are registered in classes.
91 (commented on others PR)
I agree with @ruixuantan. It would be safer since users can head into the json save file and modify its contents manually.
92 (commented on others PR)
I think if we are fine with breaking the abstraction barrier, in some sense we already have since we are dealing with UUID objects instead of strings, then it is okay to change all references to studentUuids instead, including in the model.
93 (commented on others PR)
Naming here might be a bit confusing since uuid is a object type itself.
private final String uuidString;
94 (commented on others PR)
* Constructs a {@code JsonAdaptedModuleClass} with the given class details.
95 (commented on others PR)
* Converts a given {@code ModuleClass} into a {@code JsonAdaptedModuleClass} for Jackson use.
96 (commented on others PR)
* @throws IllegalValueException if there were any data constraints violated in the adapted class.
97 (commented on others PR)
* Creates a {@code ModuleClassBuilder} with the default {@code Name} and empty {@code studentUuids} list.
98 (commented on others PR)
public static final UUID ALICE_UUID = ALICE.getUuid();
public static final UUID BENSON_UUID = BENSON.getUuid();
99 (commented on others PR)
Can these two methods be made private?
100 (commented on others PR)
I would advise against adding the class names as Tags since it might confuse our first time users into thinking that linking students to classes would automatically add the classes as Tags.
101 (commented on others PR)
Perhaps it would be a better idea to declare the students and classes as static members and then have the two methods return a list of the static members.
Also, I think the two getter methods can be made private.
102 (commented on others PR)
// different keyword -> returns false
103 (commented on others PR)
*
* @throws ParseException if the user input does not conform the expected format.
104 (commented on others PR)
NIT: It might be a good idea to leave a class or two for manual adding when testing.
105 (commented on others PR)
nit
FindModuleClassCommand expectedFindModuleClassCommand =
new FindModuleClassCommand(new NameContainsKeywordsPredicate<>(Arrays.asList("CS1101S", "Tutorial")));
// no leading and trailing whitespaces
assertParseSuccess(parser, "CS1101S Tutorial", expectedFindModuleClassCommand);
106 (commented on others PR)
* Additionally, removes all {@code Student UUID}s in each {@code ModuleClass}.
107 (commented on others PR)
/**
* Removes all {@code Student}s from the student manager.
* Also removes all {@code Student UUID}s from each {@code ModuleClass}.
*/
108 (commented on others PR)
Perhaps it might be a good idea to have the same name for both methods (in Model and in TutorsPet)?
109 (commented on others PR)
Perhaps {@code Student UUID}s would be more accurate since {@code studentUuids} refers to the list itself rather than its contents.
/**
* Removes all {@code Student UUID}s from every {@code ModuleClass} in the class list.
*/
110 (commented on others PR)
Is there any particular reason why we choose ClearModuleClassCommand as the different type as opposed to some other primitive type like an integer?
111 (commented on others PR)
model.deleteAllModuleClasses();
112 (commented on others PR)
private static final int NUMBER_OF_COLOURS = COLOURS.length;
113 (commented on others PR)
Should we be using the American spelling of Colour instead?
114 (commented on others PR)
I think we should retain the name listOfTags or tagList instead? Although the field was declared as static final, it is not exactly a constant in essence since the contents of the list can change.
I think it would be wise to follow the following categorisation of constants as given by the excerpt below from the Google Style Guide.
115 (commented on others PR)
requireNonNull(toCheck);
return internalList.stream().anyMatch(toCheck::hasSameUuid);
116 (commented on others PR)
requireNonNull(student);
return students.containsUuid(student);
117 (commented on others PR)
Instead of reading students once again, perhaps we may want to use the existing information stored within tutorsPet instead?
We can also document this precondition in the JavaDoc to state that the tutorsPet passed in should have its students loaded prior.
118 (commented on others PR)
Just wondering, is this "feature" extended to the native UUID stored in each JsonAdaptedStudent as well?
119 (commented on others PR)
* If Tutor's Pet encounters duplicate {@code Student UUID}s in a class, it will not load
* duplicate {@code UUID}s into the model. Hence, Tutor's Pet should still boot up successfully.
120 (commented on others PR)
* Ensures that Tutor's Pet will not be able to boot up given an incomplete {@code UUID}.
121 (commented on others PR)
* Ensures that Tutor's Pet will not be able to boot up although Java tries
* to pad missing {@code UUID} digits in broken {@code UUID}s with zeros.
122 (commented on others PR)
* Prevents Tutor's Pet from booting up if two or more {@code Student}s are found with the same {@code UUID}.
123 (commented on others PR)
"Invalid student(s) found in class(es).";
124 (commented on others PR)
In view of the change, I would recommend changing the test case to remove a student that was not previously part of any class. This way, we would only be changing the student list and would be a better representation of the test case.
125 (commented on others PR)
I'm slightly intrigued as to why 50?
126 (commented on others PR)
Will we be supporting hyperlinks as venues given the current situation?
127 (commented on others PR)
Perhaps it might better for these methods to take in LocalTime objects instead to remove any chances that a parse error is thrown.
128 (commented on others PR)
Perhaps it would be good to test the equals method as well?
Same for the NumberOfOccurrences class.
129 (commented on others PR)
Perhaps something along the lines of Add an attendance record of a student would be better? Similarly for the rest below?
130 (commented on others PR)
Tutor’s Pet is a desktop application that helps Computer Science teaching assistants reduce the amount of time they spend on administrative tasks.
Or alternatively, perhaps this sentence can be written in a more user centric manner?
131 (commented on others PR)
Perhaps it would be easier to support 24 hour time format (0800, 1000 etc.) first before thinking if we want to support other time formats?
132 (commented on others PR)
command may not be the best word to use here since they do not see all commands executed, i.e. they only see commands that can be undone/redone. I suggest an alternative here, although I think it definitely can be further improved.
### View action history : `view-history`
View a list of actions that can be undone or redone.
133 (commented on others PR)
The week seems to be missing from the description, same for the subsequent attendance record commands.
134 (commented on others PR)
Agreed
135 (commented on others PR)
The phrasing of this sentence is rather weird, especially the add students into those classes part. I have an alternative below, but open to better phrasing as well.
It allows teaching assistants to keep track of the students in their classes, and record their attendance and participation scores.```
</panel>
<panel header="**136 :octicon-git-pull-request::octicon-comment:** (commented on others PR)" popup-url="https://github.com/AY2021S1-CS2103T-T10-4/tp/pull/110#discussion_r504329388" expanded cwf="C:\repos\nus-cs2103\dashboards-base\contents\cs2103\tp-comments-panels.mbdf">
```suggestion
* `edit-attendance c/1 l/1 s/1 w/1 p/10` Edits the 1st week's participation score of the 1st student of the 1st lesson of the 1st class to 10 points.
137 (commented on others PR)
| **View Action History** | `view-history` |
138 (commented on others PR)
I don't think week 0 is officially supported.
* The `WEEK` **must be a positive whole number** 1, 2, 3, …
139 (commented on others PR)
* The `WEEK` **must be a positive whole number** 1, 2, 3, …
140 (commented on others PR)
* The `WEEK` must be a positive whole number** 1, 2, 3, …
* The participation score **must be a non-negative whole number** 0, 1, 2, …
141 (commented on others PR)
* User has to specify at least 1 field (DAY/START_TIME/END_TIME/VENUE) to be changed.
142 (commented on others PR)
Just noticed this, but perhaps this should be use case ends since it has been deemed that the lesson already exists?
Use case ends.
Seems like this was inherited from previous versions.
143 (commented on others PR)
1. User requests to delete a specific attendance record.
144 (commented on others PR)
Since the command expects multiple correct indexes, would it be more appropriate to phrase it as One or more of the given indexes are invalid.?
145 (commented on others PR)
That's true, I think we can keep the current version.
146 (commented on others PR)
I think it would be best for these to be left to be handled by the logic part of the house for consistency with the rest of the model components. It would be sufficient to provide getter methods and a suitable constructor.
147 (commented on others PR)
Similarly, these methods should be reserved for the commands in logic to handle to better decouple the model from the controller/logic.
148 (commented on others PR)
Instead of introducing this method within the model, perhaps it would be better for the methods that require a zero based number to use the currently available Index object and retrieve a getOneBased() value instead?
That is, the method that does the comparison should be the one performing the conversion from a zero based index to a one based index for comparison with the Week value.
149 (commented on others PR)
Perhaps we should take in Index instead of int for week associated values (at least for this class since it sort of acts like an index to a list) so that there is less room for mistakes of getting the base wrong in the future?
Or since the Week class seems to be unused, perhaps the Week class can be used to store a valid (i.e. within 1 and 52 when counted from base 1)Index object. And the Week object can be used as the definitive way to check for validity and retrieve AttendanceRecord objects from the appropriate week/index.
150 (commented on others PR)
* Inserts a new {@code UUID} and {@code Attendance} into the {@code AttendanceRecord} we are building.
151 (commented on others PR)
This class seems unused, but perhaps we can convert it to store an Index while performing validation on the Index value.
This way, we can ensure that there will be no ambiguity when parsing, transferring or retrieving values based on weeks.
152 (commented on others PR)
* Returns true if the given week is an integer between {@link NumberOfOccurrences.LOWER_BOUND}
* and {@link NumberOfOccurrences.UPPER_BOUND}.
153 (commented on others PR)
* Guarantees: immutable.
154 (commented on others PR)
* Returns the {@code Attendance} of the given {@code Student UUID}.
155 (commented on others PR)
* Guarantees: immutable.
156 (commented on others PR)
This shouldn't be necessary anymore right?
157 (commented on others PR)
* Returns the {@code Attendance} of a {@code Student} in a particular {@code Week}.
158 (commented on others PR)
* Returns the {@code AttendanceRecord} of a particular {@code Week}.
159 (commented on others PR)
The changes might cascade into the other tests as well.
public static final int VALID_WEEK_VALUE_5 = 5;
public static final int VALID_PARTICIPATION_SCORE_33 = 33;
public static final int VALID_PARTICIPATION_SCORE_51 = 51;
public static final int VALID_PARTICIPATION_SCORE_80 = 80;
160 (commented on others PR)
// invalid score
assertFalse(Attendance.isValidParticipationScore(Attendance.LOWER_BOUND - 1));
assertFalse(Attendance.isValidParticipationScore(Attendance.UPPER_BOUND + 1));
assertFalse(Attendance.isValidParticipationScore(-1));
// valid score
assertTrue(Attendance.isValidParticipationScore(Attendance.LOWER_BOUND));
assertTrue(Attendance.isValidParticipationScore(Attendance.UPPER_BOUND));
assertTrue(Attendance.isValidParticipationScore(10));
161 (commented on others PR)
Index invalidWeek = Index.fromOneBased(Week.UPPER_BOUND + 1);
162 (commented on others PR)
if (!lesson.equals(lessonToDelete)) {
163 (commented on others PR)
public static final Prefix PREFIX_START_TIME = new Prefix("st/");
164 (commented on others PR)
Perhaps this might allow more versatility for this method? Or alternatively it could be mentioned in the method description that it will always assume a class index of one.
public static String getAddLessonCommand(Index moduleClassIndex, Lesson lesson) {
return AddLessonCommand.COMMAND_WORD + " "
+ PREFIX_CLASS_INDEX + moduleClassIndex.getOneBased() + " "
+ getLessonDetails(lesson);
}
165 (commented on others PR)
Not too sure about this, but "Days" sound slightly better? Or perhaps can consider using "The day...", but it might not sit too well with the other constraint messages.
public static final String MESSAGE_CONSTRAINTS = "Days must be typed out fully in capital letters.\n"
166 (commented on others PR)
* The {@code String} must be capitalized and be spelt exactly as each enum value.
*
* @throws InvalidDayException if the {@code String} does not match any of the enum values.
167 (commented on others PR)
Perhaps we can simplify this method to:
private boolean hasDuplicateLessons(List<Lesson> lessons, Lesson lessonToCheck) {
return lessons.stream().anyMatch(lessonToCheck::isSameLesson);
}
168 (commented on others PR)
* Converts the contained {@code List<JsonAdaptedUuid> studentUuids} to a {@code List<UUID>}.
169 (commented on others PR)
* Converts the contained {@code List<JsonAdaptedLesson> lessons} to a {@code List<Lesson>}.
170 (commented on others PR)
List<UUID> studentUuids = getUuidList();
final Set<UUID> studentUuidSet = new HashSet<>(studentUuids);
171 (commented on others PR)
return new ModuleClass(modelName, studentUuidSet, lessonList);
172 (commented on others PR)
Could we split this into a separate test case since we are testing for a failure here?
173 (commented on others PR)
Would be good to update the JavaDocs with the appropriate details.
174 (commented on others PR)
Could we test for a null lesson as well? Perhaps in another file nullLessonTutorsPet.json and this file can be renamed nullStudentUuidsTutorsPet.json.
175 (commented on others PR)
Could we test both versions of JsonAdaptedLesson creation? That is have another test case that creates the JsonAdaptedLesson solely using the individual details of the Lesson rather than the object itself.
176 (commented on others PR)
Nice thanks!
177 (commented on others PR)
We need to perform some checks to ensure that the student is a member of the moduleClass as well.
178 (commented on others PR)
This seems to appear quite a few times around the code base, could this be placed into another class, perhaps the ParserUtil, or any other suitable class and the rest can reference this public method instead.
179 (commented on others PR)
Could we include a test for a null Week as well?
180 (commented on others PR)
It seems like the expected vs actual fields are swapped? It might be good to also declare the parser version as the command and the AddAttendanceCommand version as expectedCommand?
181 (commented on others PR)
Perhaps we should have a test for the case where the student is not a member of the class?
182 (commented on others PR)
I think typically there are spaces both before and after the : in enhanced for loops?
183 (commented on others PR)
public static final String MESSAGE_MISSING_STUDENT_ATTENDANCE = "Student's attendance does not exist";
184 (commented on others PR)
Nice check
185 (commented on others PR)
Just noticed this, but could have probably used .getOneBased() > lastShownStudentList.size() to drop the equality sign. Not important though.
186 (commented on others PR)
For some of the tests here, it might be good to add simple assert statements to make sure that certain assumptions about the model are true. For example the studentNotInClass, execute_success, noStudentAttendance tests rely on the fact that the TypicalTutorsPet provided meet certain criteria.
187 (commented on others PR)
Should we check if the attendance we want to delete exists in the first place?
It might be a good idea to display an error message instead of showing a success message if the attendance did not exist.
188 (commented on others PR)
In AddAttendanceCommand, parseWeek seems to throw the Week constraint message instead of the usage message when it fails. Perhaps we should keep it consistent.
189 (commented on others PR)
I think this appeared in AddAttendanceCommandTest previously. Instead of duplicating it, perhaps we can make it public in the other class for others to use. It can also be moved to another more suitable location, especially as it seems like these helper methods are becoming more common.
190 (commented on others PR)
+ "Note: All indexes must be positive integers.\n"
191 (commented on others PR)
[Redacted: non-issue]
192 (commented on others PR)
+ PREFIX_WEEK + "WEEK_NUMBER (must be a positive integer)\n"
193 (commented on others PR)
I think it would be good to state the main purpose of the method first before providing additional details.
* Adds {@code attendanceToAdd} to {@code targetLesson}.
* All existing {@code Attendance}s in {@code targetLesson} are copied to the new {@code Lesson}.
194 (commented on others PR)
* @throws CommandException if an {@code Attendance} already exists for the {@code targetStudent} in the {@code targetWeek}.
195 (commented on others PR)
* @throws CommandException if the {@code Attendance} of the {@code targetStudent} in the {@code targetWeek} does not exist.
196 (commented on others PR)
* Removes the {@code Attendance} of the {@code targetStudent} in the {@code targetWeek} from the {@code targetLesson}.
* All other existing {@code Attendance}s in {@code targetLesson} are copied to the new {@code Lesson}.
197 (commented on others PR)
Perhaps we should first check that the student is a member of this class before proceeding further?
198 (commented on others PR)
Nice job extracting these methods to a separate class.
Since they are public methods now, perhaps we should have unit tests for them? It can come in a separate PR subsequently though.
199 (commented on others PR)
// delete week 1 attendance record
Map<UUID, Attendance> record = lesson.getAttendanceRecordList()
.getAttendanceRecord(targetWeek).getAttendanceRecord();
Map<UUID, Attendance> updatedRecord = new HashMap<>(record);
200 (commented on others PR)
Lesson modifiedLesson = new LessonBuilder(lesson)
201 (commented on others PR)
// delete non-existent week 5 attendance record
Map<UUID, Attendance> record = lesson.getAttendanceRecordList()
.getAttendanceRecord(targetWeek).getAttendanceRecord();
Map<UUID, Attendance> updatedRecord = new HashMap<>(record);
202 (commented on others PR)
Lesson modifiedLesson = new LessonBuilder(lesson)
203 (commented on others PR)
* Adds {@code lessonToAdd} to {@code moduleClassToAddTo}.
* All existing {@code Lesson}s in {@code moduleClassToAddTo} are copied to the new {@code ModuleClass}.
Perhaps we should also change moduleClassToAddTo to targetModuleClass for consistency?
204 (commented on others PR)
* Replaces the {@code lessonToEdit} with {@code editedLesson} in {@code targetModuleClass}.
* All other existing {@code Lesson}s in {@code targetModuleClass} are copied to the new {@code ModuleClass}.
205 (commented on others PR)
* Removes the {@code lessonToDelete} from the {@code targetModuleClass}.
* All other existing {@code Lesson}s in the {@code targetModuleClass} are copied to the new {@code ModuleClass}.
206 (commented on others PR)
Can I check how does this defer in purpose from createModifiedModuleClassWithEditedLesson?
207 (commented on others PR)
208 (commented on others PR)
Perhaps we can follow the existing statements and use a single statement that all indexes must be positive integers.
209 (commented on others PR)
boolean isStudentIndexPresent = argMultimap.getValue(PREFIX_STUDENT_INDEX).isPresent();
boolean isWeekPresent = argMultimap.getValue(PREFIX_WEEK).isPresent();
if (!isModuleClassIndexPresent || !isLessonIndexPresent || !isStudentIndexPresent || !isWeekPresent) {
210 (commented on others PR)
boolean isModuleClassIndexPresent = argMultimap.getValue(PREFIX_CLASS_INDEX).isPresent();
boolean isLessonIndexPresent = argMultimap.getValue(PREFIX_LESSON_INDEX).isPresent();
boolean isStudentIndexPresent = argMultimap.getValue(PREFIX_STUDENT_INDEX).isPresent();
boolean isWeekPresent = argMultimap.getValue(PREFIX_WEEK).isPresent();
if (!isModuleClassIndexPresent || !isLessonIndexPresent || !isStudentIndexPresent || !isWeekPresent) {
211 (commented on others PR)
@junlong4321 Actually, for such a case where the Boolean variables are only used in the guard clause, shouldn't they be part of the block for the guard clause?
212 (commented on others PR)
There seems to be one more occurrence at line 37 in this file.
213 (commented on others PR)
Should this and the following points be relocated to the Using Tutor's Pet section?
214 (commented on others PR)
Should this be Classes and Students instead since the application uses those words instead?
215 (commented on others PR)
students in Tutor's Pet, make use of the **`list-student`** command.
216 (commented on others PR)
Gives you an overall summary of a student's attendance and participation scores.
217 (commented on others PR)
Perhaps a more user-centric phrasing can be used here?
218 (commented on others PR)

219 (commented on others PR)
A `UUID` is a unique 128-bit number to identify a unique `Student` within Tutor’s Pet.
220 (commented on others PR)
`Student` `UUID` will help to ensure referential integrity of `Student` data across different models when
`Student` data is modified by the user.
221 (commented on others PR)
Maybe you could mention that another con is the very low, but still present, risk of a collision when generating random UUIDs.
222 (commented on others PR)
* Cons: The `Email` field is editable while the unique identifier of each `Student` should not be editable to prevent the need to cascade a change in the identifier of the `Student`.
223 (commented on others PR)
I think we should include style.puml across all our diagrams to ensure consistency?
224 (commented on others PR)
Based on the textbook, there seems to be a colon before the class name even for calls to static methods.
participant "<<Class>>\n:ModuleClassUtil" as ModuleClassUtil LOGIC_COLOR
participant ":ModuleClass" as ModuleClass LOGIC_COLOR
participant "<<Class>>\n:LessonUtil" as LessonUtil LOGIC_COLOR
participant ":Lesson" as Lesson LOGIC_COLOR
participant "<<Class>>\n:AttendanceRecordListUtil" as AttendanceRecordListUtil LOGIC_COLOR
225 (commented on others PR)
Perhaps this line isn't necessary since the association has been represented as a field already? I'm not too sure on how maps should be represented as well. We should probably check with Prof Damith for clarification.
226 (commented on others PR)
It contains the `Attendance`s of all `Students` who have attended the particular lesson.
Or perhaps we can rephrase the sentence since the above does not get rendered as nicely?
227 (commented on others PR)
Hmm I'm not sure if we should have the colon here?
228 (commented on others PR)
If you would like to add a lesson to a class, you can make use of this command.
229 (commented on others PR)
* You receive news that you will be teaching `CS2103T Tutorial` on `Tuesday 10:00-11:00` at `COM2 #02-02` from week 1 to 13. Hence,
230 (commented on others PR)
* You have one less lesson to teach now.
231 (commented on others PR)
If you would like to delete a specific student's attendance from a lesson, you can make use of this command.
232 (commented on others PR)
* Alice's attendance for week 1 has been deleted.
233 (commented on others PR)
* You would like to delete Alice's attendance for the Thursday 10.00am to 11.00am lesson of CS2103T Tutorial in Week 1.
Hence, you type in the command `delete-attendance c\1 l\1 s\1 w\1` and press <kbd>Enter</kbd>.
234 (commented on others PR)
I think every command should be part of a sub category of features?
#### Display Statistics : `stats`
235 (commented on others PR)
Would it be possible to move private methods to the bottom of the class so that it can be grouped with the rest of the private methods?
/**
* Returns an {@code AttendanceRecord} where the {@code Attendance} of the {@code studentToRemove} has been removed.
* If the {@code studentToRemove} does not exist in the {@code attendanceRecord}, the {@code attendanceRecord} is returned unchanged.
*/
private static AttendanceRecord removeStudentFromAttendanceRecord(
236 (commented on others PR)
/**
* Returns an {@code AttendanceRecordList} where the {@code Attendance}s of the {@code studentToRemove} have been removed.
*/
237 (commented on others PR)
I think this line can be simplified?
tp.addModuleClass(moduleClass);
238 (commented on others PR)
Same as above,
tp.addModuleClass(moduleClass);
239 (commented on others PR)
Perhaps we could shift the responsibility of removing the student from module class to the command instead. Since there is currently no existing dependency from model to logic, it might be best to keep it that way to remove this cyclic dependency between the packages?
One suggestion would be for the delete and clear student commands,we can retrieve the ReadOnlyTutorsPet from the model and perform the mapping function there, and then set the new TutorsPet back into the model.
@ruixuantan do you have any suggestions on how this cyclic dependency can be resolved?
240 (commented on others PR)
/**
* Returns a {@code Lesson} where the {@code Attendance}s of the {@code studentToRemove} has been removed.
*/
241 (commented on others PR)
* Returns an {@code AttendanceRecordList} where the {@code Attendance}s of all {@code Student}s have been removed.
242 (commented on others PR)
* Removes the {@code studentToRemove} and all associated {@code Attendance}s from the {@code targetModuleClass}.
243 (commented on others PR)
* If the {@code studentToRemove} does not exist in the {@code attendanceRecord}, the {@code attendanceRecord}
* remains unchanged.
244 (commented on others PR)
public void removeStudent(Student student) {
245 (commented on others PR)
public void removeAllStudents() {
246 (commented on others PR)
I think I spotted a typo in the other Cards as well, could you help to change them as well?
* Creates a {@code LessonCard} with the given {@code lesson} and index to display.
247 (commented on own PR)
TIL, didn't know that.
Quite interesting explanation here also: English StackExchange
248 (commented on own PR)
The JavaDoc was adapted from an equivalent JavaDoc in UniqueStudentList.
I would be more inclined to retain both in their current expressions.
249 (commented on own PR)
This JavaDoc was directly adapted from a corresponding JavaDoc in the existing UniqueStudentList class as well. As such, I would be more inclined to retain the current expression since it is consistent with existing code.
The backing list refers to the internalList while unmodifiable means that any attempted modifications on the list would result in an UnsupportedOperationException being thrown.
250 (commented on own PR)
// workaround as storage functionality for ModuleClasses has not been implemented
251 (commented on own PR)
// workaround as storage functionality for ModuleClasses has not been implemented
252 (commented on own PR)
Agree with @junlong4321 for consistency.
253 (commented on own PR)
This JavaDoc was directly adapted from a corresponding JavaDoc in the existing UniqueStudentList class, so I would be more inclined to retain the current expression since it is consistent with existing code.
254 (commented on own PR)
255 (commented on own PR)
As these informal list points are not complete sentences and are fragments, I would be more inclined to leave the full stop out?
256 (commented on own PR)
Oops, that slipped through my manual search and replace.
257 (commented on own PR)
I think for this case, it would be okay to not include an empty line above the comment since it is the first line in the method body. It will also be more in line with existing code.
258 (commented on own PR)
Good idea, added in!
259 (commented on own PR)
Resolved instead by changing to lowercase throughout, more in line with comments found above.
260 (commented on own PR)
Because of the need to include the CURRENT_INDICATOR for a particular entry, which is rather specific to ViewHistoryCommand, the method in StringUtil would be oddly specialised for a method in the commons package.
Instead, I think I would abstract out the creation of the message to a helper function that resides within the ViewHistoryCommand class.
261 (commented on own PR)
I've included this spacing to separate code used to set up the environment (above) from the code that is being tested (below).
262 (commented on own PR)
I've included this spacing to separate code used to set up the environment (above) from the code that is being tested (below).
263 (commented on own PR)
The cache is used in the following scenario:
The user has some previous commands already saved in the history.
The user partially types a command string, but decides to refer to a previous command.
The user recalls the previous command for reference but wants to return to the partially typed command.
The user can retrieve his partially typed command string from the cache.
I've also included some logging functionality at the info and fine levels.
264 (commented on own PR)
Hmm I wanted to differentiate this constructor from the previous as this constructor is typically not meant to be used to create new lessons, but rather act as a "copy" constructor with modifications. Would it be better to leave it as is, add the word "new", or "Creates a copy of a lesson with the specified parameters."?
265 (commented on own PR)
I did consider the direct de/serialisation of key-value pairs using the Jackson, however I was rather hesitant to use it as I was unsure how it would play with the current implementation of JsonUtil. Similarly, the StudentAttendance implementation was used to avoid the need to complicate the deserialisation of key-value pairs.
I do agree with you that the direct serialisation would be more intuitive and provide a one to one mapping with the actual classes in the model.
266 (commented on own PR)
I'll be inserting another diagram over there (around line 280) to explain the case when the current value is cached in a subsequent PR. So I think I'll leave the summary at the end for now.
267 (other comment)
Can you rebase and then should be good to go.
268 (other comment)
Not sure if we need to get approval before we merge this in since we are trying to use a new module?
269 (other comment)
This seems to be missing the saving of UUIDs to local storage, is that planned for a separate PR?
270 (other comment)
Closed with #61.
271 (other comment)
Closed with #62.
272 (other comment)
Resolved in #68.
273 (other comment)
Closed with #55.
274 (other comment)
Closed with #55.
275 (other comment)
Closed with #55.
276 (other comment)
Closed with #55.
277 (other comment)
@ruixuantan could I also get your opinion on the test cases written for the new features?
278 (other comment)
Closed in #131
279 (other comment)
@ruixuantan This PR only adds unit tests for LessonUtil since they were updated. I'll leave #158 open until unit tests have been added for ModuleClassUtil.
280 (other comment)
Non-issue since users can use stats to see if a week has an attendance record and use find attendance to view the specifics.
@qwoprocks (183 comments)1 (commented on others PR)
I'm not sure if >ins> is the correct tag to use here? (And the closing tag should be >/ins> right) From what I gathered online >ins> is to underline some text in html to indicate it is an insertion, but there's not >del> tag here, so I think it might be more appropriate to use either the >u> tag for underlining or []() syntax if its supposed to be a link
2 (commented on others PR)
I think we should retain the step of copying our jar file over to the folder the user wants to use as the home folder, as we'll need to do saving in a data folder as well
3 (commented on others PR)
There's inconsistency between this and the description of the help command below. Also, I think the help contents will be opened in a window and not a page?
4 (commented on others PR)
Refer to comment above
5 (commented on others PR)
Maybe we should change PHONE to PHONE_NUMBER, following the original format, for clarity
6 (commented on others PR)
Shows commonly used commands for TBM.
7 (commented on others PR)
* Role: In charge of deliverables and deadlines
8 (commented on others PR)
Following the format for client delete INDEX, maybe add a short one line statement to explain what this command does?
9 (commented on others PR)
Same as prev comment, and there's also an extra newline here that I think would be better to remove
10 (commented on others PR)
The indexing is off here
11 (commented on others PR)
Indexing off here too
12 (commented on others PR)
* 1a. The list of clients is empty.
13 (commented on others PR)
Might want to change this to match the original "Finds clients whose names contain any of the given keywords.", and change n/NAME to KEYWORD [MORE_KEYWORDS] as the format section below mentions keywords
14 (commented on others PR)
* The search is case-insensitive. e.g `hans` will match `Hans`
* The order of the keywords does not matter. e.g. `Hans Bo` will match `Bo Hans`
* Only the name and country are searched.
* Only full words will be matched e.g. `Han` will not match `Hans`
* Persons matching at least one keyword will be returned (i.e. OR search). e.g. `Hans Bo Russia` will return `Hans Gruber`, `Bo Yang`, `Alice Katya`
15 (commented on others PR)
### Listing all clients: `list`
Shows a list of all clients in the address book.
16 (commented on others PR)
Finds clients whose names contain any of the given keywords, or whose country of residence contains any of the given keywords.
17 (commented on others PR)
I think we should just stick to either the abbreviation TBM or the full name in the headers, not both
18 (commented on others PR)
either that or perhaps change both back to the simple "User Guide" and "Developer Guide". I don't really see a need to have TBM in the title, as the whole website is already about TBM, plus we have introductions and our home page.
19 (commented on others PR)
Just to add on, I don't think the >ins> tag should be used here, as markup defines it as inserting something? e.g. here. >u> seems more appropriate if the intention is to underline the text.
20 (commented on others PR)
LGTM
21 (commented on others PR)
this.countryName = new Locale("", countryCode).getDisplayCountry();
I think its more intuitive to call this specific method
22 (commented on others PR)
private final String COUNTRY_NAME;
private final String COUNTRY_CODE;
private final ArrayList<Note> COUNTRY_NOTES;
From the convention guide: Constant names must be all uppercase using underscore to separate words. I'm not sure if countryNotes should be marked final actually, since we are going to modify it in the addCountryNote function.
Also, I feel that the notes should be stored in something like a LinkedHashSet, since we don't really want to add in duplicate notes, and its easier to check if its a HashSet.
23 (commented on others PR)
I feel like we shouldn't initialize countryNotes until it is actually needed. E.g. Only when the user actually adds a country note, or there are notes for this country in the save file. If not its unnecessary overhead, especially if there are many countries.
Not sure how the rest think @tankangliang @rtshkmr @LeeEnHao
24 (commented on others PR)
Constant names must be all uppercase using underscore to separate words.
Is there a need for this Map? From what I see, I think we can just keep the ISOCountry String array, then check if the entered String is inside, before initializing a new Locale with that String. This way, we won't have to keep so many country objects, since most of the countries likely won't be used.
25 (commented on others PR)
Constant names must be all uppercase using underscore to separate words.
26 (commented on others PR)
Constant names must be all uppercase using underscore to separate words.
27 (commented on others PR)
Ah ok nvm I think can just stick with this for now. I was thinking of something else to prevent the unnecessary creation of objects, but this HashMap is still necessary for it, my bad.
Btw can change the HashMap to Map, so that we standardize
28 (commented on others PR)
Hmmmm seems like by constant they mean static final only. Static only or final only aren't counted as constants, even though one of the examples in the website has an example of final only variables being set to all caps + underscores.
No need to change bah
29 (commented on others PR)
Would be better to standardize with the other commands, for example the ClientFindCommand.
30 (commented on others PR)
Btw, ClientFindCommand doesnt have requireNonNull(predicate), I think can just add it in there too
31 (commented on others PR)
There needs to be a javadoc comment here. (All public classes should have javadoc according to the textbook)
32 (commented on others PR)
javadoc comment
33 (commented on others PR)
requireNonNull
34 (commented on others PR)
Might want to standardize with other equals methods. Basically these 3 parts: short circuit if same object, instanceof handles nulls, and state check. Can look at ClientEditCommand for an example
35 (commented on others PR)
Maybe can add extracting out the messages into a static final string into the TODO: better messages, in case we forget
36 (commented on others PR)
javadoc comment
37 (commented on others PR)
javadoc comment
38 (commented on others PR)
Might want to add a TODO here
39 (commented on others PR)
This whitespace is little bit weird lol, but might just be my personal preference
40 (commented on others PR)
here too
41 (commented on others PR)
Might want to change the predicate name to ClientCountryMatchesInputCountryPredicate for clarity?
42 (commented on others PR)
might wanna change this equals to match the 3 step thing
43 (commented on others PR)
Probably should calculate and return the hashcode using noteContents, since I think Note is already being used hashed objects
44 (commented on others PR)
Would suggest changing this to isValidCountryCode, for clarity
45 (commented on others PR)
Hmmm I was thinking that this CountryManager class holds all Country objects, while every other class should be holding references to these objects instead of any new Country() object. That way, the class themselves should be able to check if the Country has any notes, and this method would not be needed.
46 (commented on others PR)
Can help to update the parser names for the delete and find command?
47 (commented on others PR)
Should probably add in a hashCode() function just in case
48 (commented on others PR)
Actually for this toString, should we be returning countryName instead? Maybe can add a comment to address why we're returning countryCode.
49 (commented on others PR)
The whitespace is off
50 (commented on others PR)
Add a comment for standardization
51 (commented on others PR)
// multiple countries - last country accepted
52 (commented on others PR)
not sure about that, but later that guy forget lmao
53 (commented on others PR)
I think we should just do it now man. From java docs: Note that it is generally necessary to override the hashCode method whenever this method is overridden, so as to maintain the general contract for the hashCode method, which states that equal objects must have equal hash codes.
54 (commented on others PR)
Yeah, but usually the purpose of the toString is to return a more "human readable" format of the object, so maybe countryName would be a better choice for the return value.
55 (commented on others PR)
LOL ok then just fix it in that issue bah
56 (commented on others PR)
Would be slightly clearer if you changed the variables names to SMALLEST_NEGATIVE_OFFSET and LARGEST_POSITIVE_OFFSET imo
57 (commented on others PR)
Not sure why this sys print is here
58 (commented on others PR)
Add new tests for timezone pls
59 (commented on others PR)
We should catch NumberFormatException here, in case people enter a number that is longer than what an int can hold
60 (commented on others PR)
Extra new lines, and I think the javadoc can be added already right
61 (commented on others PR)
Would be better if MESSAGE_USAGE is moved upwards for organization purpose, so that public static final is above private static final
62 (commented on others PR)
Also, its hard to read when the lines are separated so much with the random comment also, would suggest this:
(must be a positive integer should also be moved to the description, not inside the parameters)
Rmb to import PREFIX_NOTE
+ "Parameters: INDEX " + PREFIX_NOTE + "NOTE_STRING\n"
+ "Example: " + COMMAND_WORD + " 1 " + "client note content";
63 (commented on others PR)
I think everything has to go through model, as it is being used for UI I think
64 (commented on others PR)
This variable doesn't seem to be used, since you already removed the redundant code
65 (commented on others PR)
agree with rayson
66 (commented on others PR)
Would be good to remove the line break for readability
67 (commented on others PR)
Would be good to move this down, after the if statement
68 (commented on others PR)
Probably would be good to add a javadoc comment for this method as well
69 (commented on others PR)
There is a need to implement the hashCode function, since note is being used in a hashSet.
Could you also change the equals method to match the 3 step thing? (1. short circuit if same object. 2. instanceof handles nulls 3. state check)
70 (commented on others PR)
There's like extra newlines here and above as well
71 (commented on others PR)
Extra newline
72 (commented on others PR)
I would suggest that this is changed to a LinkedHashSet, as we will want the order of the notes to remain the same as the order they were added. HashSet does not guarantee order
I believe the country notes are also using LinkedHashSet
Also, I think it would be better if the clientNotes was initialized only if the client has notes, probably can add a TODO here to optimize this.
73 (commented on others PR)
I think this variable still isn't being used
Other than that, LGTM
74 (commented on others PR)
public String getInputCountryStringRepresentation() {
Better to have descriptive function names without abbreviations imo
75 (commented on others PR)
Probably can be on the same line for clarity
76 (commented on others PR)
Would be better to move this above MESSAGE_DUPLICATE_COUNTRY_NOTE so that the public static final variables are tgt.
77 (commented on others PR)
For this, it would be more concise to just use the overloaded constructor of ArrayList ArrayList(Collection>? extends E> c) to make the copy of the filtered client list
Either that or just initialClientList.addAll()
78 (commented on others PR)
Would it be better to use an assertEquals here?
79 (commented on others PR)
This can be moved out of the loop I think
80 (commented on others PR)
The assertTrues and assertFalses here can probably be changed to assertEquals and assertNotEquals for better clarity
81 (commented on others PR)
The assertTrues and assertFalses here can probably be changed to assertEquals and assertNotEquals for better clarity
82 (commented on others PR)
Ah ok I missed that
83 (commented on others PR)
I think it would be better if clientParser accepts a Client instead of a generic Object, then do the casting here. This way, we wont have to do the casting + assertion inside clientParser.
84 (commented on others PR)
Should these have more descriptive names?
Also, should include param/return tags in javadoc for this method
85 (commented on others PR)
If this is a temporary method, should add in a TODO somewhere here to remove after its not needed. This method looks very un-OOP-like lolol
Should include params and return tags also in this javadoc
86 (commented on others PR)
This method needs more explanation using comments/better descriptive names. For example, what is start to end order? Why is there the Math.min with the magic literal 14?
Would suggest extracting out the 14 as a private final static var
Also, I think it should be String... args and not String ...args? At least that's the format google java format uses
87 (commented on others PR)
Sys.print shld be removed. Also, better explanation should be given in the comments/javadocs, and the variable names should be more descriptive. For example, what happens in the bigger picture if there is no null field that can be set?
88 (commented on others PR)
public class WidgetModelManagerTest {
Also, extra newlines above this can be removed
89 (commented on others PR)
Naming of test functions should follow the format
90 (commented on others PR)
Naming of test functions should follow the format
91 (commented on others PR)
test functions should follow the format: featureUnderTest_testScenario_expectedBehavior()
e.g. sortList_emptyList_exceptionThrown() getMember_memberNotFount_nullReturned
92 (commented on others PR)
test functions should follow the format: featureUnderTest_testScenario_expectedBehavior()
e.g. sortList_emptyList_exceptionThrown() getMember_memberNotFount_nullReturned
93 (commented on others PR)
Also, probably should make all the tests public void to standardize
94 (commented on others PR)
I feel like optional isn't needed in this file? It would be clearer if you do divs[X] == null ? "" : divs[X]
95 (commented on others PR)
Is this sysprint leftover from debugging? Other than this, LGTM
96 (commented on others PR)
This should be an assert / exception instead, since our countryNotesMap already contains all possible countries, and if there is a country not contained in our map, it should not have been created in the first place
97 (commented on others PR)
This should be an assert / exception instead, since our countryNotesMap already contains all possible countries, and if there is a country not contained in our map, it should not have been created in the first place
98 (commented on others PR)
* SUGGESTION_TYPE must be one of the following: `frequency`, `available` or `contract`
99 (commented on others PR)
maybe change to command word suggest instead? Make it seem more like normal english
100 (commented on others PR)
should extract these strings as static final vars
101 (commented on others PR)
Should add a TODO here to do something in the execution
102 (commented on others PR)
I think it's fine to leave it as a class for now, since if we change it to an enum it might be hard to integrate. Maybe can just KIV as a TODO.
103 (commented on others PR)
This needs to be updated to the actual message constraints for note. Commands like "client note add 1 nt/" causes this to appear in the response box, which is a bug.
Would suggest a simple "Note should not be blank"
104 (commented on others PR)
why are these protected? I couldn't find any other classes in the same package using them
105 (commented on others PR)
Should return an unmodifiable set instead.
106 (commented on others PR)
Since the equality checking was updated to include hasSameTags, the hashCode should be updated to ensure the tags are hashed as well, to maintain the contract between the equals and hashCode method.
107 (commented on others PR)
Should return unmodifiable objects. Also, getCountryNote doesn't seem to be used, will it be used in a later commit?
108 (commented on others PR)
This doesn't seem to be called in the program, will it be added in a later commit?
109 (commented on others PR)
I think it would be better if we did a new ClientBuilder(ALICE).build();. The ALICE client itself should not be modified as it may affect other parts of the testing unexpectedly.
110 (commented on others PR)
void initMapFromClients_addClientWithTaggedNotes_success() {
This method doesn't seem to return a boolean, so success should be used instead. Or you could change it to doesNotThrowException. The other 2 methods below also need their method names updated, returnsTrue should be <expected outcome>.
111 (commented on others PR)
Will need to add more tests, but can do in a separate issue probably.
112 (commented on others PR)
Not sure why only this variable is static? Could probably make all of them just final.
113 (commented on others PR)
Should probably test the other methods and constructor as well, but can be done later in a separate PR as its not that important for now.
114 (commented on others PR)
Same comment as in TagNoteMapTest.java
115 (commented on others PR)
Is this needed lol
116 (commented on others PR)
Same issue for this, refer to TagNoteMapTest.java for the comments on test method naming. For stuff that throws exception, the format should be ..._throwsXXXException().
117 (commented on others PR)
Is this needed?
118 (commented on others PR)
Should not have a newline here
119 (commented on others PR)
Should probably change this to tagSet.
120 (commented on others PR)
should probably requireAllNonNull here.
Also, is there a need for this method to be public? It seems to be only used here
121 (commented on others PR)
This doesn't seem to be used, is it in a later commit?
Also, should requireAllNonNull here
122 (commented on others PR)
Should do this todo, if not the method name becomes confusing.
123 (commented on others PR)
* @param countryNotes The set of countries, each containing their notes and associated tags.
124 (commented on others PR)
* @param clients The list of clients, each containing their notes and associated tags.
125 (commented on others PR)
* Initialises the TagNoteMap from a list of clients.
126 (commented on others PR)
* Initialises the TagNoteMap from a list of countries.
127 (commented on others PR)
Should untagged tags be added to the note?
128 (commented on others PR)
agree with rayson, also maybe you can have a static final tag object already created in the Tag class, then your ParserUtil can just find Tag.UNTAGGED
129 (commented on others PR)
+1
130 (commented on others PR)
Change this to a todo pls, if not we'll forget to remove it
131 (commented on others PR)
remnants of debugging?
132 (commented on others PR)
Done
133 (commented on others PR)
Done
134 (commented on others PR)
Done
135 (commented on others PR)
Removed the other duplicate call
136 (commented on others PR)
Would suggest adding a requireNonNull / assert != null here just in case. Also, what happens in execute if list.size() == 0?
137 (commented on others PR)
Actually, looking at this, I would suggest implementing a compound predicate instead of having a list. So maybe something like Predicate>Client> combinedSuggestionTypePredicate = (client) -> suggestionTypeList.stream().map(suggestionType -> suggestionType.getSuggestionPredicate()).reduce(true, (x, y) -> x.test(client) && y.test(client));
^I didn't test this, but I think it should be correct
138 (commented on others PR)
Should have an equals and hashcode method, so as to standardize with other predicates, and also enforce the contract between equals and hashcode. Since this class doesn't have any vars, we can just return a constant int for hashcode, and have equals return true as long as other class is instanceof this one
139 (commented on others PR)
Maybe can just put the assert false and return null in the default block? I think it would make it cleaner
140 (commented on others PR)
Is this method needed? Is it possible to change other parts of the code so we use the withTimezone(String timezone) method instead?
141 (commented on others PR)
shld add new line before this to standardize
142 (commented on others PR)
Too many new lines here
143 (commented on others PR)
Can add one more assert for just "client" without the space? Just in case.
Same for client note test below
144 (commented on others PR)
extra new line here
145 (commented on others PR)
Can rename this to clientCommandType? and the country one to countryCommandType?
146 (commented on others PR)
rename this to clientNoteCommandType?
147 (commented on others PR)
Small issue, but the number of equals on both sides aren't balanced
148 (commented on others PR)
what is this supposed to log? I can't really tell from the code itself, maybe make it explicit with a comment?
149 (commented on others PR)
why got copyright one lmao
also, should add a todo to change this
150 (commented on others PR)
Each note should display on a separate line, if not long/many notes will be hard to read
151 (commented on others PR)
If this path is not supposed to be reached, should just throw an exception here, logging it as info doesn't really make sense. You could probably log the stacktrace though
152 (commented on others PR)
I like the variables at the top, makes it easy to see, should probably standardize for the whole CSS (can do in a separate issue)
For the scrollbar I think we shouldn't hide it actually, and I feel that the border-radius are a bit too much, maybe can reduce, plus one of the boxes (the one that shows the command messages) isn't rounded, while the rest are
153 (commented on others PR)
For all the changes in this file, should probably standardize to no space before />, since thats the format of all the fxml files
154 (commented on others PR)
Also, this help icon should be added to the top context menu (can do in a later issue)
155 (commented on others PR)
??? why is there this assertNotEquals here lolol
156 (commented on others PR)
are hamcrest and assertj used? Also, do we need to define JUnit as testCompile? (since we already defined it in our testImplementation/testRuntimeOnly)If we need to, should probably use the jUnitVersion variable instead of a string
157 (commented on others PR)
fx:id here is empty?
158 (commented on others PR)
The indentation here is a bit confusing, I think this and StackPane above should be indented 2 more spaces?
159 (commented on others PR)
I think the indentation and line breaks in this file are off. Can consider taking out the <children\ cwf="C:\repos\nus-cs2103\dashboards-base\contents\cs2103\tp-comments-panels.mbdf"> tag and leaving it as
>StackPane>
<Label...>
>StackPane>
so that clutter is reduced. </children>
160 (commented on others PR)
this comment seems to be half-written lol
161 (commented on others PR)
This variable doesn't seemed to be used
162 (commented on others PR)
I think a clearer and cleaner implementation of this would be .collect(Collectors.joining()).replace("[", "").replace("]", ""); instead of the reduce
163 (commented on others PR)
"standardise" should be "standardised"
164 (commented on others PR)
Where is this view variable used ah
Cuz right now its just being set to WidgetModelManager but on the next line you return a new WidgetModelManager?
165 (commented on others PR)
Can change this to offset or offsetValue?
166 (commented on others PR)
why was this newline added lmao
167 (commented on others PR)
extra newline
168 (commented on others PR)
Should requireNonNull for country
169 (commented on others PR)
Actually, do we need this ? extends Note? Would using List>Note> be better?
170 (commented on others PR)
probably can remove this newline
171 (commented on others PR)
* A high-level class responsible for mapping ISO3166 countries to their respective country notes.
172 (commented on others PR)
Actually I would suggest we move isValidCountryCode method to Country class, then this class will be solely in charge of the relationship between Country and CountryNote (SRP), and the classname can be changed to CountryNoteManager I guess
173 (commented on others PR)
should we put an assert false here?
174 (commented on others PR)
Should requireNonNull countryNote
175 (commented on others PR)
Should add simple javadoc for getTags()
176 (commented on others PR)
Small issue, this should be changed to getCountryNotes
177 (commented on others PR)
Random "The" here
178 (commented on others PR)
this sentence is half-complete, I think can just remove the "between"
179 (commented on others PR)
This png file doesn't seem to have been generated, not too sure why, can you try editing this a bit and pushing again?
180 (commented on others PR)
extra newline
181 (commented on others PR)
should have a [else]
182 (commented on others PR)
Need to update javadoc for this method to match the method behavior
183 (commented on others PR)
This variable isn't being used
184 (commented on own PR)
Yeah its cuz the parsing of a date string always needs to have exception thrown
185 (commented on own PR)
I'm not sure if and how the LocalDate parser does its parsing though, so I would prefer to be safer by mandating the regex check. For example, it might parse 20/19/020 as a correct date and not throw any errors. Apparently using the ResolverStyle.STRICT is supposed to prevent this kind of mis-parsing, but I think the regex would be more defensive coding-like
186 (commented on own PR)
Done
187 (commented on own PR)
My bad, fixed it
188 (other comment)
LGTM
189 (other comment)
LGTM
190 (other comment)
LGTM
191 (other comment)
LGTM
192 (other comment)
LGTM
193 (other comment)
Fixed by #121 #142 #144
194 (other comment)
Fixed by #120
195 (other comment)
Duplicate of #92
196 (other comment)
Duplicate of #90
197 (other comment)
Removed from plans
198 (other comment)
Quite a few TODOs and stray comments. I think a follow-up issue can be created to cleanup the todos and stray comments.
Just wondering, what is the main purpose of having
TagNoteMapclass? Is it so that it would be easier to query for notes based on a given set of Tags? Because it seems like additional work to "sync" tags with notes and it might be quite error-prone if the syncing is not done right. Any thoughts @qwoprocks ?
@raysonkoh actually the implementation @rtshkmr did was a bit off from what I had in mind, the tagnotemap is actually supposed to be the one being passed down from logic manager to the parser to create the tags, so there would no need to do the syncing stuff. @rtshkmr isit alright if i just push to this PR and implement that?
199 (other comment)
1. Cannot uniquely identify `clients` by their name at the moment.
Possible fix: store the client as a string containing ">client name> >client email>", as we can use isSameClient method of Client to match the clients and notes.
200 (other comment)
Is the testing for
ContractExpiryFieldclass supposed to be done in another PR?
Ah right I forgot lmao I'll add it in now
@aqcd (156 comments)1 (commented on others PR)
Do change the USERGUIDE_URL in HelpWindow.java as well!
2 (commented on others PR)
Switch to use logger
3 (commented on others PR)
Switch to use logger, same for other 2 instances below
4 (commented on others PR)
Switch to use logger
5 (commented on others PR)
Remove
6 (commented on others PR)
"Clears the item list"?
7 (commented on others PR)
Would it be better to default quantity to 0 and description/location to none if user doesn't key them in? Currently they act as compulsory fields.
8 (commented on others PR)
Javadocs
9 (commented on others PR)
Javadocs
10 (commented on others PR)
Javadocs
11 (commented on others PR)
Javadocs
12 (commented on others PR)
Extra lines
13 (commented on others PR)
change address-book
14 (commented on others PR)
Javadocs
15 (commented on others PR)
change comment title
16 (commented on others PR)
change comment title
17 (commented on others PR)
person -> item
18 (commented on others PR)
Should these be locationIds and recipeIds?
19 (commented on others PR)
Should these method names be getLocationIds and getRecipeIds?
20 (commented on others PR)
use this format instead, replace with the fields we have
21 (commented on others PR)
plural forms
22 (commented on others PR)
plural forms
23 (commented on others PR)
extra lines
24 (commented on others PR)
address book -> item list?
25 (commented on others PR)
Javadocs
26 (commented on others PR)
Javadocs
27 (commented on others PR)
Make this comment appropriate pls 😃
28 (commented on others PR)
Javadocs
29 (commented on others PR)
Javadocs
30 (commented on others PR)
Javadocs
31 (commented on others PR)
Javadocs
32 (commented on others PR)
the right side has less equal signs 😦
33 (commented on others PR)
change address book to item list or something similar
34 (commented on others PR)
same for this segment
35 (commented on others PR)
change logger message
36 (commented on others PR)
itemToAdd might be better
37 (commented on others PR)
extra lines
38 (commented on others PR)
item -> item and location
39 (commented on others PR)
item -> item and location
40 (commented on others PR)
person -> item
41 (commented on others PR)
extra lines
42 (commented on others PR)
ItemList->RecipeList
43 (commented on others PR)
item list file path
44 (commented on others PR)
of recipes
45 (commented on others PR)
recipe list file path
46 (commented on others PR)
will fail checkstyle
47 (commented on others PR)
item -> recipe
48 (commented on others PR)
checkstyle
49 (commented on others PR)
can consider shorter prefix
50 (commented on others PR)
for clarity can change to "Recipe ID is out of range"
51 (commented on others PR)
should this be {@code Item}?
52 (commented on others PR)
catch specific exception
53 (commented on others PR)
add comment above this line specifying that this is for the delr command
54 (commented on others PR)
conform -> conform to
55 (commented on others PR)
extra lines
56 (commented on others PR)
this constructor might be misleading, would it be better to modify the existing one?
for instance
if (!isDeleted) {
idCounter++;
}
in the existing constructor might make it usable as an equivalent to this one
57 (commented on others PR)
remove or change to logger statement
58 (commented on others PR)
Name typo (?), img not updated
59 (commented on others PR)
[stephentan]
60 (commented on others PR)
change names in [ ]s to be consistent styling
img not updated
61 (commented on others PR)
img not updated
62 (commented on others PR)
address book -> item/recipe
63 (commented on others PR)
these steps as well
64 (commented on others PR)
persons -> items/recipes
65 (commented on others PR)
actual pictures pls 😃
66 (commented on others PR)
should this be 3a and 4a?
67 (commented on others PR)
recipe
68 (commented on others PR)
standardise with README, use InvInator.jar or change README to inventoryinator.jar
69 (commented on others PR)
add line back
70 (commented on others PR)
add line back
71 (commented on others PR)
add line back
72 (commented on others PR)
add line back
73 (commented on others PR)
add line back
74 (commented on others PR)
via the issue tracker of this repository, with link to it
75 (commented on others PR)
keep names consistent - full name or given name
76 (commented on others PR)
rephrase to "what is going on under the hood"
77 (commented on others PR)
should this be "deli stone" for the moment?
78 (commented on others PR)
delr -n >name> -i >index>?
79 (commented on others PR)
should locations be included as well?
80 (commented on others PR)
del -> deli
81 (commented on others PR)
same for this line
82 (commented on others PR)
delete -> deli/delr
83 (commented on others PR)
mark as TODO for easier search
84 (commented on others PR)
optionally provide a short intro on how we structured our personas (explain that our app will help transition the before scenario to the after scenario, etc.)
85 (commented on others PR)
include option to use
java -jar InvInator.java
86 (commented on others PR)
contacts -> items
87 (commented on others PR)
mark as TODO
88 (commented on others PR)
mark as TODO
89 (commented on others PR)
should we change to deli and delr for now?
90 (commented on others PR)
should we split del -> deli + delr?
91 (commented on others PR)
should we split del -> deli + delr here?
92 (commented on others PR)
i think we should specify that they need to overwrite multiple files, since our storage for each class is in separate files
93 (commented on others PR)
change titles for each of these files
94 (commented on others PR)
Should this use the NOT_FOUND message instead? User does not need to know our implementation
95 (commented on others PR)
itemList.removeIf(x -> !x.getName().equals(productName) || x.isDeleted());
in line 43 looks like it already ensures the item won't be deleted
96 (commented on others PR)
Suggest to change phrasing to something like
"soft deletes recipes that contain deleted item as product or ingredient"
97 (commented on others PR)
DeleteRecipeCommand -> DeleteItemCommand
98 (commented on others PR)
use proper punctuation please
99 (commented on others PR)
use proper punctuation please
100 (commented on others PR)
and all recipes associated with the item
101 (commented on others PR)
please space the methods in this file
102 (commented on others PR)
spacing
103 (commented on others PR)
spacing
104 (commented on others PR)
spacing
105 (commented on others PR)
remove this line
106 (commented on others PR)
@code item
107 (commented on others PR)
spacing
108 (commented on others PR)
proper punctuation please
109 (commented on others PR)
spacing
110 (commented on others PR)
spacing
111 (commented on others PR)
spacing
112 (commented on others PR)
spacing
113 (commented on others PR)
spacing
114 (commented on others PR)
spacing
115 (commented on others PR)
use block comment
116 (commented on others PR)
fix spacing in this file
117 (commented on others PR)
fix spacing in this file
118 (commented on others PR)
fix spacing in this file
119 (commented on others PR)
spacing
120 (commented on others PR)
space out these tests
121 (commented on others PR)
re-add spaces in this file
122 (commented on others PR)
fix spacing
123 (commented on others PR)
fix spacing
124 (commented on others PR)
spacing
125 (commented on others PR)
spacing
126 (commented on others PR)
spacing
127 (commented on others PR)
more clear explanation needed
128 (commented on others PR)
spacing
129 (commented on others PR)
spacing
130 (commented on others PR)
should these be containsMultipleWordsIgnoreCase?
131 (commented on others PR)
remove line
132 (commented on others PR)
remove line
133 (commented on others PR)
is it possible to test results of command? eg. if no such item exists, or check that the item being shown is indeed the right item
134 (commented on others PR)
import from the file with existing modelstub
135 (commented on others PR)
deceptive naming
try to remove if not too necessary, is an unusual class to have
136 (commented on others PR)
use isEmpty
137 (commented on others PR)
Might be better to not have "will you like to add some?" if there's no direct button to do so
138 (commented on others PR)
use isEmpty
139 (commented on others PR)
should this file be added?
140 (commented on others PR)
Just "No items match the search string." should suffice here
141 (commented on others PR)
One or more... will suffice
142 (commented on others PR)
perhaps just "None" is better?
143 (commented on others PR)
change these tests to using wrong prefix
can remove the old tests once replaced
144 (commented on others PR)
remove, same for the rest of the printlns in this file
145 (commented on others PR)
change other list as well
146 (commented on others PR)
should this be unhidden? same for recipe variant as well
147 (commented on others PR)
should recipes be reset as well? or is it automatically reset since all items are removed
148 (commented on others PR)
is now supported as addq, should update this?
149 (commented on others PR)
will this ever be supported?
150 (commented on others PR)
same for this
151 (commented on others PR)
space equally as the above lines
152 (commented on others PR)
spacing after ,
153 (commented on others PR)
remove extra line
154 (commented on others PR)
add test to edit tags
155 (commented on others PR)
add test for this
156 (commented on others PR)
standardise to without the "inator", same for rest of instances
157 (commented on own PR)
Replaced by the ItemParserUtil and RecipeParserUtil
158 (commented on own PR)
Will be added when future tests require it, currently the item list is needed to reset the item's recipelist so some tests don't contaminate it and affect future tests.
159 (commented on own PR)
The constructor takes Set in at the moment, might look into this in future
160 (other comment)
Done in https://github.com/AY2021S1-CS2103T-F13-1/tp/pull/17
161 (other comment)
Done in https://github.com/AY2021S1-CS2103T-F13-1/tp/pull/16
162 (other comment)
Issue #30 opened as per review.
163 (other comment)
resolved by #31
164 (other comment)
Pushed to future PRs:
LocationList current defaults to Optional.empty, to be fixed and tested.
RecipeParserUtilTest incomplete, does not test for ingredient-related parsing.
165 (other comment)
Can now be closed, so closing the tutorial PRs.
166 (other comment)
Can now be closed, so closing the tutorial PRs.
167 (other comment)
Can now be closed, so closing the tutorial PRs.
168 (other comment)
Can now be closed, so closing the tutorial PRs.
169 (other comment)
Opened #73 regarding above comment
170 (other comment)
needs update of developerguide.md as well
@ChooJiaXin (130 comments)1 (commented on others PR)
New feature added does not correspond to the feature you were assigned. Possible typo?
2 (commented on others PR)
Examples provided not changed to match the changed feature.
3 (commented on others PR)
User command should be just "list" instead of "list 2" to fit the explanation fo the command. Possible typo?
4 (commented on others PR)
Maybe changing it to "displays all your assignments and lessons for the next 2 weeks" would be more succinct?
5 (commented on others PR)
How about "displays all your lessons and assignments for the next 2 weeks (including the current week)"?
6 (commented on others PR)
Looks good!
7 (commented on others PR)
@printinghelloworld sounds good 😃
8 (commented on others PR)
Looks good 😃 A minor nitpick is that you may want to consider removing point number 3 ("ASM retrieves lesson data from NUSMods API") as according to the textbook, use cases only describe the externally visible behavior, not internal details, of a system.
9 (commented on others PR)
Similar to the above comment, maybe it would be better to change the phrasing to describe how the ASM displays the lessons from the newly imported timetable
10 (commented on others PR)
Maybe including the time the assignment is due in the deadline would be better?
E.g: n/Lab report 3 d/23/04/2020 1230 mod/CS2100
11 (commented on others PR)
Since we have some optional fields as well, maybe it would be clearer to the user if we changed the description given in AB3 to match our project?
12 (commented on others PR)
I was suggesting to keep the Tip section and change the description to "You can use the remind tag to set reminders for the assignment you want to add instead of using the remind command after adding the assignment" or something along those lines.
13 (commented on others PR)
Currently, module code can accept the same string format address in AB3. Perhaps consider changing it the VALIDATION_REGEX to match the format of module codes as well?
14 (commented on others PR)
Testing of new ModuleCode field may be more accurate if the input was changed to match the module code format.
15 (commented on others PR)
INVALID_ADDRESS_DESC should be INVALID_MODULE_CODE_DESC for consistency 😃
16 (commented on others PR)
Similar to the above comment, VALID_ADDRESS_AMY should be VALID_MODULE_CODE_AMY.
17 (commented on others PR)
Similar to VALID_ADDRESS_AMY comment.
18 (commented on others PR)
Name of method still refers to address instead of moduleCode. Possible typo?
19 (commented on others PR)
Could consider changing the test cases to test for valid module codes 😃
20 (commented on others PR)
According to the 2103T textbook, the suggested guideline for code quality is to break-line after the bracket instead of in the middle of an instantiation.
E.g:
JsonAdaptedPerson person = new JsonAdaptedPerson(
VALID_NAME, VALID_PHONE, VALID_EMAIL, null, VALID_TAGS);
21 (commented on others PR)
The comment describing the test still refers to address field instead of module code field.
22 (commented on others PR)
Similar to other comments, the comment describing the test still contains address.
23 (commented on others PR)
Comments still refer to address. But it is just a minor nitpick 😃
24 (commented on others PR)
Similar to other comments 😃
25 (commented on others PR)
This line can be removed 😃
26 (commented on others PR)
Comment still refers to address instead of module code
27 (commented on others PR)
Maybe could do more testing to ensure that the regex works as it's supposed to? You can consider testing for modules codes with no alphabets at the start ("1010S"), modules with no numbers ("GER"), modules that begin with more than 3 alphabets ("ABCD1000") etc
28 (commented on others PR)
Comment still refers to address field.
29 (commented on others PR)
Similar to other comments relating to address comments 😃
30 (commented on others PR)
Similar to other comments relating to address comments 😃
31 (commented on others PR)
Similar to other comments relating to address comments 😃
32 (commented on others PR)
Similar to other comments relating to address comments 😃
33 (commented on others PR)
The comment describing the email test is not deleted.
34 (commented on others PR)
The comment for this test still contains 'email'
35 (commented on others PR)
yup
36 (commented on others PR)
This test case seems to still have references to email.
37 (commented on others PR)
Comment still references email.
38 (commented on others PR)
Comments for this field use 'persons' instead of 'assignments'. Be sure to check the comments as well 😃
39 (commented on others PR)
Similar to the other comment, the comments for the field use 'persons' instead of 'assignments'
40 (commented on others PR)
Similar to the other comment, the comments for the method use 'persons' instead of 'assignments'. Same for the equals method below this method 😃
41 (commented on others PR)
Similar to the other comments, the comments use 'persons' instead of 'assignments'
42 (commented on others PR)
Similar to the other comment, the comments for the method and the string parameter at line 9 use 'persons' instead of 'assignments'.
43 (commented on others PR)
Similar to the other comments, the comments use 'persons' instead of 'assignments'.
44 (commented on others PR)
Similar to the other comments, the comments use 'persons' instead of 'assignments'
45 (commented on others PR)
Nice test cases 😃 You may want to consider leaving a space between some parts of the code to make it more readable (e.g leaving a space between lines 79 and 80 and leaving another space between lines 81 and 82)
46 (commented on others PR)
Similar to the previous comment on improving readability 😃
47 (commented on others PR)
Similar to the other comments, the comments use 'persons' instead of 'assignments'
48 (commented on others PR)
According to the CS2103T textbook, the convention for the indentation for wrapped lines should be 8 spaces.
Following the CS2103T convention, you may want to consider changing the indentation to match the one in red 😃
49 (commented on others PR)
You may want to consider leaving a blank line between some lines to improve readability and code quality (E.g leaving a space between lines 82-83 and lines 84-84). You can refer to the screenshot of the CS2103T coding conventions below 😃
50 (commented on others PR)
Similar to the comment above on readability 😃 You may want to consider applying the same thing to the other test cases in this class
51 (commented on others PR)
JavaDocs should be @moduleCode instead of @address 😃
52 (commented on others PR)
JavaDocs should be @ModuleCode instead of @Address
53 (commented on others PR)
Since assignment starts with a vowel, it should be "an assignment" instead of "a assignment" 😃 The same typo can be found throughout the project. You can consider using the "find in path" feature in IntelliJ to help you find them (Edit -> Find -> Find in Path)
54 (commented on others PR)
This test case should be removed 😃
55 (commented on others PR)
May want to consider adding a link back to the main point which is that ProductiveNUS is supposed to help NUS Computing students resolve the problem so that it is clear what the aim is 😃
I also think it may be better to use more passive language? So instead of 'You often...' it may be better to use 'You may often...'. What do you think?
56 (commented on others PR)
Looks good! A suggestion could be to bold/box certain words to make the aim more obvious.
57 (commented on others PR)
The test cases look good! Minor nitpick, the comments next to the valid test cases do not match what is being tested. Also, if the lesson names do not accept numerals in the name, you may want to consider changing the validation regex to only accept alphabets 😃
58 (commented on others PR)
Nice test case 😃
59 (commented on others PR)
okie
60 (commented on others PR)
Naming the deadline field time may be more appropriate for the Lesson class as it doesn't really make sense for a Lesson to have a deadline.
61 (commented on others PR)
Personally, I feel that using 'schedule' is a little vague. Maybe you could consider changing it to 'schedule manager' or 'schedule book'? What do you think?
62 (commented on others PR)
Message for duplicate assignment still refers to address book.
63 (commented on others PR)
According to the CS2103T code convention, boolean variables should be named to sound like booleans (e.g isRemindTypo/containsTypo instead of remindTypo).
64 (commented on others PR)
I think can just use the hashcode method you created in Lesson.java as given the way you implemented it seems similar to how AB3 implemented it for Person, I think lessons.hashCode() should be fine.
65 (commented on others PR)
According to the CS2103T coding standards/conventions, we should try to avoid deeply nested methods. Maybe you could consider removing the else block and extracting the "happy path" to prevent the method from becoming too deeply nested. Another suggestion is adding an empty line in between lines of code to improve readability. You could consider applying the SLAP framework as well 😃
66 (commented on others PR)
I'm not very sure what "Lists the tasks within the next index number of weeks" means. Maybe consider changing the explanation to what is stated in the User Guide?
67 (commented on others PR)
Nice! You could consider abstracting out the implementation as a private method as the execute(Model model) method is a little long now and according to the CS2103T conventions on code quality, we should try to avoid too long methods 😃
68 (commented on others PR)
According to the CS2103T textbook, under code quality, we should strive to extract the "happy path" out. You could consider changing the code to extract the "happy path" 😄
e.g:
if (!isNotListAll) {
return new ListCommand(Index,fromZeroBased(0));
}
try {
....
}
69 (commented on others PR)
According to the CS2103T coding conventions, we should delete code that we do not need 😃 Are you planning to use the commented out code at a later date?
70 (commented on others PR)
JavaDocs still refer to assignments instead of lessons
71 (commented on others PR)
Similar to the comment above regarding the JavaDocs 😃
72 (commented on others PR)
Similar to the comment above regarding the JavaDocs
73 (commented on others PR)
String still refers to Assignment instead of task 😃
74 (commented on others PR)
JavaDocs still refer to assignment instead of Task
75 (commented on others PR)
Similar to the above comment regarding the JavaDocs.
76 (commented on others PR)
Similar to the above comment regarding the JavaDocs.
77 (commented on others PR)
JavaDocs still refer to assignments instead of tasks
78 (commented on others PR)
JavaDocs still refer to Assignment instead of Lesson
79 (commented on others PR)
Similar to the comment above regarding JavaDocs
80 (commented on others PR)
JavaDocs still refer to Assignment instead of Task
81 (commented on others PR)
Similar to the above comment regarding JavaDocs
82 (commented on others PR)
Similar to the above comment regarding JavaDocs
83 (commented on others PR)
Similar to the above comment regarding JavaDocs
84 (commented on others PR)
Good job 😃 You may want to consider abstracting lines 125 to 135 into another method as this method is quite deeply nested. Remember to SLAP hard 😄
85 (commented on others PR)
👍
86 (commented on others PR)
Good job 😃 You may want to consider extracting this part into another method as the CS2103T textbook suggests that we should SLAP our code to improve code quality.
87 (commented on others PR)
JavaDocs for ScheduleCommand refers to RemindCommand instead of ScheduleCommand.
88 (commented on others PR)
Good job 😃 A suggestion you may want to consider is to name the boolean variable "can" to something more descriptive and meaningful, as currently "can" doesn't really describe what the boolean is checking for. If you do change the name of the variable, remember to adhere to the CS2103T conventions and ensure that it sounds like a boolean value (i.e isPossibleTime, canSchedule etc)
89 (commented on others PR)
According to CS2103T conventions, boolean methods and variablels should be named to sound like a boolean (i.e haveOverlap, isOverlappingTime etc)
90 (commented on others PR)
JavaDocs refer to AddCommand instead of ScheduleCommand.
91 (commented on others PR)
Is this constructor used for testing?
92 (commented on others PR)
If this constructor is used for testing, it may be better to create a ScheduleStub class in the test package for testing 😃 But this is a minor issue that can be done when you do UnitTesting.
93 (commented on others PR)
The JavaDocs for the constructor should be phrased as "Constructs a ...". But this is a minor detail that can be fixed in v1.4 so don't worry about it for now bah 😃
94 (commented on others PR)
oh okie okie
95 (commented on others PR)
What's this System.out.println used for? Just curious 😄
96 (commented on others PR)
JavaDocs conventions for CS2103T is for JavaDocs to phrase JavaDocs in such a way: "Constructs...", "Retrieves....", as opposed to "Construct..." or "Retrieve..."
97 (commented on others PR)
Since the undo command currently only works with every command except for find and list, you may want to consider adding that information into the message usage and message undo fail so that the user will know exactly why it fails 😃
98 (commented on others PR)
According to the CS2103T code quality conventions, it recommends that we extract the "happy path".
99 (commented on others PR)
Maybe stating the priorities would be clearer for the user to understand?
For example, "Sets, HIGH, MEDIUM or LOW priority for the assignment identified by the index number...."
100 (commented on others PR)
JavaDocs still refers to the remind command for @param
101 (commented on others PR)
Assignment variable still refers to remind command instead of priority command
102 (commented on others PR)
False priority is a little misleading as it makes it sound as if the user used the wrong input format for the Priority command instead of setting no priority to the assignment. You may want to consider changing the phrasing of the JavaDocs for the constructor such that it better reflects what the constructor does 😃
103 (commented on others PR)
Slight nitpick but since you gave the date format before the time format, you could consider using "... finding of assignments by date and time separately", instead of "... finding of assignments by time and date separately". But it is fine if you leave it as it is too 😃
104 (commented on others PR)
You could consider changing the word prefixes, as it may not be very clear to the user exactly what we are referring to when we say prefixes. Maybe something like "Multiple assignment fields detected. Finding is done one field at a time." then provide examples of what a field is?
105 (commented on others PR)
The fetching of keywords for each field appears to have some overlaps. You could consider abstracting the implementation and creating a method called getKeywords(String prefix) to improve the code quality 😃
106 (commented on others PR)
Should be "Tests that an Assignment..." instead of "Tests that a Assignment...". Possible typo?
107 (commented on others PR)
Similar to the above comment on the grammatical error.
108 (commented on others PR)
Likewise 😃
109 (commented on others PR)
According to the CS2103T coding conventions, boolean methods and boolean variables should be named to sound like a boolean. However, it appears that this method is overriding a method from Predicate, so it should be fine 😃
110 (commented on others PR)
Nice test cases 😃 A suggestion is inserting white spaces between each test case to improve readability. You may want to consider testing for incorrect date and time as well (i.e 31-02-2020 or 2500) to ensure that the parser works as intended 😃
111 (commented on others PR)
Similar comment regarding the insertion of white spaces 😃
112 (commented on others PR)
You may want to consider testing for the other fields as well to ensure that they are working as they are supposed to but this is a minor nitpick 😃
113 (commented on others PR)
Similar comment regarding the insertion of white spaces 😃
114 (commented on others PR)
You may consider adding in comments to tell the reader exactly what you are testing for (e.g invalid deadline, invalid date, valid time or invalid module code). Though this is just a minor nitpick 😃
115 (commented on others PR)
Nice use of white spaces 😃
Though you may want to consider using the white spaces to not just improve readability but to group code with similar logic together (i.e grouping all the nameKeywords, deadlineKeywords... List>String> variables together and only inserting the white spaces in between priorityKeywords and findByNames. Likewise for the FindCommand variables and the assertEquals methods).
116 (commented on others PR)
The description and format does not fit the unprioritize command 😃
117 (commented on others PR)
JavaDocs still refer to prioritize command
118 (commented on others PR)
Should be "Creates and returns an Assignment..." instead of "Creates and returns a Assignment.."
119 (commented on others PR)
JavaDocs still refer to RemindCommand
120 (commented on others PR)
JavaDocs refer to Remind instead of Done
121 (commented on others PR)
Commends refer to reminders instead of marking assignments as done
122 (commented on others PR)
Likewise for this comment 😃
123 (commented on others PR)
Oops must have forgotten to delete the empty return tag when I created this method. You can just delete the @return tag since the other methods don't seem to have the @return tag 😃
124 (commented on others PR)
The phrasing sounds a little weird to me, though it could just be me XD The "to import" at the end of the sentence appears a bit redundant as well since at the start of the sentence, you already mentioned that the information will be imported.
Maybe "The user can import information about their lessons into ProductiveNUS using their NUSMods timetable URL" would be more concise?
125 (commented on others PR)
Looks good 😃
126 (commented on others PR)
Maybe using "Unmarks the 3rd assignment as done" would be more appropriate since undone is not exactly proper English XD But I think the way it is now is fine too.
127 (commented on others PR)
Likewise for here 😃
128 (commented on others PR)
Oh when I googled it, Google said unmark is proper English but okie XD
129 (commented on others PR)
I agree with Andrea 😃
130 (commented on others PR)
JavaDocs refer to reminders instead of the suggested schedule 😃
131 (commented on own PR)
address name should change to module code after merging the PR that changed the address field to module code
132 (commented on own PR)
Sounds good!
133 (commented on own PR)
Amended 😃
134 (commented on own PR)
Since we are probably going to be adding an edit feature in the future we can just leave it in first or add it to v1.2 since the implementation is all done for us already 😄
135 (commented on own PR)
What do you mean?
136 (commented on own PR)
At first, I made it a non-abstract class, but then IntelliJ made noise because it extends abstract class Command so i either had to override the execute method in NegataCommand or make NegateCommand abstract. Since I personally felt that overriding the execute method in NegateCommand was a little redundant since the UnremindCommand, UnscheduleCommand and UndoneCommand will override the execute method again, I decided to make the NegateCommand class abstract.
I can change it back to a normal class if you want to though, I shall just override the abstract execute method in NegateCommand if you want to change it to a normal class 😃
137 (commented on own PR)
Oh yup. Must have missed it out. I shall go change it now
138 (commented on own PR)
Amended!
139 (commented on own PR)
Amended!
140 (commented on own PR)
Amended!
141 (other comment)
LGTM.
142 (other comment)
Will description 'Tags your assignment with a reminder which adds it to 'Your reminders' section' be clearer?
Noted! I have edited the phrasing. Is the edited version clearer?
143 (other comment)
I have changed some of these user stories to make it more specific. eg. 'work'
Perhaps refer to DG to see which is better?
Updated accordingly 😄
144 (other comment)
Looks good! Just a small suggestion, maybe we can standardise the use of capital letters under 'I can' and 'so that I can'. we can either capitalise the first word or not capitalise the first word for both scenarios 😃
Sounds good! Which do you suggest is better? I'm fine with either way 😃
145 (other comment)
Looks good! Just a small suggestion, maybe we can standardise the use of capital letters under 'I can' and 'so that I can'. we can either capitalise the first word or not capitalise the first word for both scenarios 😃
Sounds good! Which do you suggest is better? I'm fine with either way 😃
I think for now we can not capitalise for both scenarios !
Amended 😃
@w-yeehong (109 comments)1 (commented on others PR)
Should we standardize comments? One possible style:
Separate-line comment with whitespace, singular verb, and uppercase 1st character.
// Parses user input...
Command command = addressBookParser.parseCommand(commandText);
Same-line comment with whitespace, singular verb, and lowercase 1st character.
Command command = addressBookParser.parseCommand(commandText); // parses user input...
We could follow any other style too. Just thought it might be better for everyone to stick to 1 for consistency.
2 (commented on others PR)
Sure, we can restore this when we complete EditCommand.
3 (commented on others PR)
Really like the regex here. It is simple and effective.
4 (commented on others PR)
I know this is a bit late, but do you think we should change AddPersonCommand to AddPatientCommand?
I think our Person refers specifically to Patient since we have the periodOfStay field. If we are adding a Staff class in the future, it may be a little misleading since Staff is a Person too.
What do you think?
5 (commented on others PR)
Since we are using Patient now, maybe we can rename some of these variables?
Perhaps from MESSAGE_INVALID_PERSON_DISPLAYED_INDEX to MESSAGE_INVALID_PATIENT_DISPLAYED_NAME.
Also, do you think we should change our usage of "person" to "patient"? 🤔
i.e. "The patient name..." instead.
6 (commented on others PR)
I like the use of guard clauses in this method. Makes the code much cleaner 😀
7 (commented on others PR)
Great work on writing the unit tests! For v1.1, we might not need it but getting it done earlier is a nice bonus.
8 (commented on others PR)
Maybe it could be invalidPatientName instead? I know it might be a little troublesome to change all references to Person to Patient. I can help with that if you would like.
9 (commented on others PR)
For separate-line comments, do you think we should keep the first character in uppercase?
The Java coding standard we are using does not explicitly mention it but seems to follow that. I think comments that start with keywords may not need to be capitalized though (e.g. null).
10 (commented on others PR)
I think "list of patient/all patients that match the specified criteria" may be clearer?
11 (commented on others PR)
Great use of Optional here!
12 (commented on others PR)
Do you think an Enum may be preferable here since there are a limited number of possible values?
Using int is not very scalable. If we have 10 different search conditions, we would need 10 int, and it can be hard to keep track of these variables.
Perhaps we can declare a nested Enum:
private enum SearchCondition {
SEARCH_BY_NAME.
SEARCH_BY_TEMPERATURE,
SEARCH_CONDITION_INVALID; // no condition or multiple conditions given
}
If you would like to use int, maybe it would be better to make them static and change the variable names to indicate they are constants. E.g.
private static final int SEARCH_BY_NAME = 1;
Personally, I think Enum might be neater. 😄
13 (commented on others PR)
Maybe we can add a space here? "TEMPERATURE RANGE " instead of "TEMPERATURRANGE".
This text will be displayed to the user, and the former may be easier to read?
14 (commented on others PR)
Maybe one private method for each search condition? That would be great.
15 (commented on others PR)
I'm not too sure but I think the execution will not reach this return statement? If that is the case, I think we can throw a CommandException instead of returning null? Returning null here may cause a NullPointerException somewhere else.
16 (commented on others PR)
Perhaps we can rename this method to confirmSearchConditions or determineSearchCriteria? area may not be very clear that we are referring to the search conditions.
17 (commented on others PR)
JavaDoc comments here are really useful to understand the purpose of the nested class. Great work 👍
18 (commented on others PR)
@itssodium Could you check whether these changes are correct?
If I am not wrong, the Covigent part is the latest edit. It might have been overwritten by accident.
19 (commented on others PR)
Would you be able to undo the deletion of this file? DateTimeUtil.java was recently added to manage dates and times.
20 (commented on others PR)
Perhaps we could name this AddRoomCommand instead?
AddNumberOfRoomsCommand seems a little verbose since the number of rooms is implied, though this is a matter of preference.
If you like AddNumberOfRoomsCommand better, let's keep that.
21 (commented on others PR)
Similarly, perhaps we could rename the command to addroom.
22 (commented on others PR)
I think it's great that you refactored the code used for I/O. I/O should be abstracted if possible (SRP) since this class mainly handles the adding of the room.
23 (commented on others PR)
Maybe we can follow the convention here? For messages, Address Book Level 3 follows this convention: MESSAGE_ERROR or MESSAGE_SUCCESS. We could use MESSAGE_NUMBER_OF_ROOMS_UNDEFINED or something along those lines here for consistency.
24 (commented on others PR)
Would be good to add a comment here if the -1 means something.
25 (commented on others PR)
Similarly, we can follow the conventions for messages here.
26 (commented on others PR)
It is less about whether the user will enter a negative number, and more about how we should secure our application.
Personally, I feel that it is good if we can handle as many exceptional cases (sometimes called edge cases) as possible. Without proper handling, anyone can crash the app simply by entering a negative number. It can be annoying for the user if they accidentally type in a negative number and the app just stops working.
Besides, near the end of the semester, our application will be manually tested for bugs. I am fairly sure the testers will try to use negative numbers as inputs. If they can cause the application to crash, they will flag the problem as a bug and deduct our marks for it. Let's do our best to stop that from happening! 😄
27 (commented on others PR)
May I ask what is the reason for naming the class RoomBook instead of RoomList or RoomQueue? I feel that Book does not explain what the class does.
28 (commented on others PR)
Would it not be possible to use an ArrayList>Room>?
I think it is easier to understand if you iterate through all the Room objects in a loop and call an isEmpty() method to determine which Room is empty.
Performance-wise, I understand PriorityQueue may be better but we are sacrificing code clarity for performance.
29 (commented on others PR)
Shouldn't Room contain an ArrayList>Task>?
30 (commented on others PR)
@itssodium Would you be able to check this?
31 (commented on others PR)
Do you mean it will be used for allocating the Patient to the Room?
32 (commented on others PR)
Okay, leave this part to me. I will add in the TaskList.
33 (commented on others PR)
Would it be possible to use Optional>Patient> here? While it is true that the Room can have no Patient, it is best to avoid null.
34 (commented on others PR)
Great that you have a separate class for storage!
35 (commented on others PR)
I think that is probably the temporary files used for testing? 🤣 Shall we rename the test files?
36 (commented on others PR)
Yup, Address Book Level 3 has a convention for the names of test cases. Maybe we can follow that next time?
37 (commented on others PR)
Ohh okay I follow your train of thoughts now. For adding Patient to Room, I think we should be more explicit? Maybe something like AddPatientToRoom.
I think you can use AddRoom for this.
38 (commented on others PR)
May I check if URI is used here? I think path is a String and URI may not be needed here?
39 (commented on others PR)
I think it would be good if you could leave a comment to explain the use of the nr and ro options!
40 (commented on others PR)
Would it be possible to split this test into smaller units? It is currently longer than 30 lines.
Perhaps this part
rooms = new PriorityQueue<>();
for (int i = 0; i < 10; i++) {
Room room = new Room(i + 1);
if (i % 2 == 0) {
room.setOccupied(true);
}
rooms.add(room);
roomsInArray[i] = room;
}
roomList = new RoomList(rooms, roomsInArray, 10);
numberOfRooms = Paths.get("numberOfRooms");
roomsOccupied = Paths.get("roomsOccupied");
roomOccupancyStorage = new RoomOccupancyStorage(numberOfRooms, roomsOccupied);
roomOccupancyStorage.saveNumberOfRooms(roomList, numberOfRooms);
roomOccupancyStorage.saveOccupiedRooms(roomList, roomsOccupied);
roomList1 = roomOccupancyStorage.readOnlyRoomOccupancy();
assertEquals(roomList, roomList1);
can be in a separate test?
41 (commented on others PR)
I think addRooms here refer to allocating a Patient to a Room? Most likely, this test would be in a separate class so maybe we can remove it first?
42 (commented on others PR)
Don't worry, I can handle this part. 😄 I will have to integrate the TaskList into Room to get my part working anyway.
43 (commented on others PR)
I think it would be good to leave an explanation of why numberOfRooms is initialized to -1.
44 (commented on others PR)
Perhaps the messages here can be moved to another class? Ideally, we can avoid adding constants to this class since the messages are stored in seedu.address.commons.core.Messages instead. Maybe look into putting your messages there too?
45 (commented on others PR)
I think IntelliJ might have changed this to wildcard imports? Maybe we can revert this?
46 (commented on others PR)
Do you think we should keep the indentation consistent? For *.fxml files, maybe we can use 2 or 4 spaces (not sure what the original is).
47 (commented on others PR)
I think it would be patients here. Very minor grammatical issue though 😄
48 (commented on others PR)
I like how there is an order for the different types of entities (patients followed by rooms followed by miscellaneous). Maybe in the future, we can a header to each entity to further organize the content of our user guide? E.g.
3.1 [Command Format](#31-command-format)<br>
3.2 [Patients](<Section explaining what Patients are>)<br>
3.2.1 [Add a patient: `addpatient`](#32-add-a-patient-addpatient)<br>
// ...
49 (commented on others PR)
Do you think we should standardize this? Not sure if it is as important in the JavaDocs because it is understandable, but what about the user guide?
Should we refer to the application as the app, the application, or Covigent?
50 (commented on others PR)
Thank you for noticing and changing this! 😄
51 (commented on others PR)
Because isSamePatient(...) uses name, age, and phone number as criteria to detect duplicate Patient in a list, will this not pose a problem when deleting? It is possible to have more than 1 Patient with the same name after all. In that case, only the first matching Patient is deleted.
I think it may be a little strange that the user cannot select which Patient to delete if they share the same name. I am not sure about the optimal way to solve this problem. Would deleting by index be better?
52 (commented on others PR)
Good job noticing the bug here! 😄
53 (commented on others PR)
Maybe this can be renamed to indicate that an invalid search criterion has been provided. searchPatient does not really explain which aspect is being tested.
Something like execute_searchPatientInvalidSearchCriteria_throwsCommandException() may be good?
54 (commented on others PR)
I think it would be good to mention something along the lines of how the command replaces the current number of rooms with the newly specified value. Also, whether the data in the current rooms will be migrated or reset.
We can always improve on the user guide in the future though, so maybe we can KIV? 😄
55 (commented on others PR)
Since there are multiple files being checked, maybe we can include which data file is not in the correct format in the warning.
The same goes for the other warnings.
56 (commented on others PR)
Maybe we can keep this statement in a single line such that it looks even neater? It has fewer than 110 characters and can fit in one line!
57 (commented on others PR)
Perhaps we can remove code that is commented out. If we merge this, we may forget to remove it in the future. Also, commented out code seems like regular comments and may be difficult to locate in a large codebase.
58 (commented on others PR)
Great work with the hashing!
59 (commented on others PR)
May I ask why the 31 is needed here?
60 (commented on others PR)
I think maybe we can make this more general and apply it all the other *List classes (UniquePatientList, RoomList, TaskList). Otherwise, I think the interface may not be needed?
Possibly ReadOnlyList>T>? We can do either:
Include all methods such as add, delete, etc. (much more work because we have to rename all methods to share a common name).
Include just the method to obtain a read-only list (easier).
61 (commented on others PR)
Maybe we can add a TODO here to indicate that in the future, we should set the application default to having a few rooms with patients and tasks?
62 (commented on others PR)
Although ObservableList and PriorityQueue maintain the same rooms, for safety would it be better to include a comparison for the ObservableList too?
63 (commented on others PR)
The condition for this is rooms != null && roomList.rooms != null but I think neither the PriorityQueue nor ObservableList can be null because of the default value, right?
In that case, can you not just return false if any of the 2 PriorityQueue and 2 ObservableList are null?
64 (commented on others PR)
Instead of tracking numOfRooms in a variable, would it be possible to just make use of the size of the ObservableList? Maybe include a method to get size (similar to the other *List classes).
This would reduce the complexity of the class, especially when writing the equals(...) or hashCode() method since there is one fewer variable to manage.
65 (commented on others PR)
@JsonProperty tells the Jackson ObjectMapper to map the JSON property name to the annotated Java field's name so we end up with this:
"room": {
"roomNumber": value
"isOccupied": value
//...
For consistency with JsonAdaptedPerson, perhaps we can keep it the same as the variable name (i.e. roomNumber and isOccupied)? We would have
public JsonAdaptedRoom(@JsonProperty("roomNumber") int roomNumber,
@JsonProperty("isOccupied") boolean isOccupied) {
//...
66 (commented on others PR)
We can add a TODO here since we are not using the Patient and Task in this class yet.
67 (commented on others PR)
Consistent @JsonProperty here! Variable name should be rooms.
68 (commented on others PR)
Good job with switching to temp folders! 😊
69 (commented on others PR)
Maybe we can import java.util.Optional directly?
70 (commented on others PR)
I think if we are not using this class currently, we can remove it 1st?
71 (commented on others PR)
I will add this when I pull your changes 👍
72 (commented on others PR)
Might be good to declare a constant for "-" to indicate what it is doing more clearly!
73 (commented on others PR)
Might be difficult to switch here since there are multiple conditions.
I think the current structure is not too bad. Maybe we can rename clearRoom to isNewEmptyRoom for clarity? clearRoom sounds like the name of a method hahaha.
Also, I think isCurrentlyOccupied sounds more like a boolean. How about we use that instead of alreadyOccupied?
74 (commented on others PR)
Instead of ...orElse(null) != null, maybe we can use editRoomDescriptor.getIsOccupied().isPresent()?
75 (commented on others PR)
Would it be possible to combine case 1 and case 3 since both return Room(updatedRoomNumber)? 🤔
!hasNewPatient could be the condition.
76 (commented on others PR)
Actually, I'm curious about why clearRoom is needed as a condition.
77 (commented on others PR)
While not entirely linked to this PR, I think we should modify Room to store an Optional>Patient>. Then, we can remove the isOccupied boolean and use Optional>Patient>.isPresent() to find out whether a room is occupied.
78 (commented on others PR)
I understand it may be easier to return an Integer but this method is similar to the parseIndex. We can use the Index class provided in the original codebase and use parseIndex instead.
That was what I did in AddTaskCommandParser 😆
79 (commented on others PR)
Hmm if we modify RoomList directly from EditRoomCommand, we may be breaking a few abstraction barriers since Command will be interacting with RoomList.
To avoid this problem, we can add a setRoom(Room target, Room editedRoom) method to RoomList. Then, add another setRoom(Room target, Room editedRoom) method to Model (the interface). Finally, In ModelManager, call roomList.setRoom(...).
We can then use the setRoom(...) method by calling model.setRoom(...). So we are restricting the interactions between classes such that Command only interacts with RoomList via Model.
80 (commented on others PR)
Does DuplicateRoom apply only to identical RoomNumber?
81 (commented on others PR)
Thanks for adding this TODO! 👍
82 (commented on others PR)
Wait, I see that setRoom has been done. Good job! In that case, why is the modifiable room list still needed?
83 (commented on others PR)
Also, perhaps we can rename these methods to hasRoom(...) and setRoom(...) for consistency with Patient?
84 (commented on others PR)
Okay, I see what you mean. For now, we are treating RoomNumber as an index but in the future we may allow the user to set their own room numbers.
Would it be convenient for you to move the room-related methods to RoomParserUtil?
If not, I could do that later because I intend to make ParserUtil an abstract class.
85 (commented on others PR)
getRoomList() returns the ObservableList though. Wouldn't it be possible to check if the room is present from there?
I think one reason we would not want to return the RoomList is because it is mutable. That means that if we return RoomList from ModelManager, any other class can modify the content through RoomList (e.g. call roomList.addRooms(...)) instead of through the Model (i.e. call model.addRooms(...)).
getRoomList() returns a read-only list so we can prevent the contents of RoomList from being changed directly. In fact, I think that was the original intention behind the asUnmodifiableObservableList() method.
86 (commented on others PR)
I think editroom command does not allow task to be edited right?
In that case, maybe we don't need to use editRoomDescriptor.getTaskList()?
87 (commented on others PR)
Maybe it would be good to remove codes that we commented out? Otherwise, we may completely forget about it.
88 (commented on others PR)
Perhaps the predicate could take on a more meaningful name. What about filterByRoomNumber or something along those lines?
89 (commented on others PR)
Good job on reducing the number of ObservableList we need!
90 (commented on others PR)
If we are changing that, I think we can make the method name clearer too. Maybe getFilterByRoomNumberPredicate()?
91 (commented on others PR)
Let's look into resolving the TODOs in v1.3?
92 (commented on others PR)
Just wanna check if stylesheets need to be set to each of the element? If I am not wrong, as long as you set stylesheets to ScrollPane, the rest of the elements should inherit the CSS accordingly?
93 (commented on others PR)
For multiple non-null args, we can use requireAllNonNull(...) instead to shorten the code!
94 (commented on others PR)
Maybe can explain why this statement is necessary here?
95 (commented on others PR)
Great work using a listener to update the UI for Room!
96 (commented on others PR)
Would it not be possible to use getPatientWithName instead? I feel like that may significantly reduce the amount of code that we need.
97 (commented on others PR)
Might be good to add a comment there to indicate that it refreshes UI.
98 (commented on others PR)
I think the patient name is the identifier for a patient right? In that case, wouldn't it better to avoid using the Index class?
99 (commented on others PR)
Would you like to switch to getRoomList() here? We will eventually remove getModifiableRoomList.
100 (commented on others PR)
If I am not wrong, the two methods getPatientIndex() and getPatientFromIndex() are used in the EditPatientCommand class, right?
Instead of this
Index index = model.getPatientIndex(patientToBeEdited);
if (index.getZeroBased() == 0) {
throw new CommandException(Messages.MESSAGE_INVALID_PATIENT_NAME_INPUT);
}
Patient patientToEdit = model.getPatientFromIndex(Index.fromZeroBased(index.getZeroBased() - 1));
Would it not be cleaner to do this in EditPatientCommand?
Optional<Patient> optionalPatient = model.getPatientWithName(patientToBeEdited);
// Better still, use Patient patientToEdit = optionalPatient.orElseThrow(...). I forgot the syntax hahaha.
if (!optionalPatient.isPresent()) {
throw new CommandException(Messages.MESSAGE_INVALID_PATIENT_NAME_INPUT);
}
Patient patientToEdit = optionalPatient.get();
That way, we avoid using Index altogether.
101 (commented on others PR)
Oh yeah, this wouldn't work if you use the unmodifiable version. Feels like using the modifiable version is a hack though hahaha.
102 (commented on others PR)
Actually, we probably should have another class similar to PatientRecord to interact with RoomList. Add, delete, set are done through PatientRecord right now. I think it's fine for now though. Maybe add a note to move this method to the new class once it is set up.
103 (commented on others PR)
Maybe we can standardize the casing for file names (i.e. logo.png).
104 (commented on others PR)
I would like to check if we are changing the colour scheme of the UI. I think #2b5c7b is the one we are using in our mock-up.
105 (commented on others PR)
Since we are removing the menu, I think you can remove the corresponding CSS too!
106 (commented on others PR)
Maybe keep the format for the comments consistent.
// Set images ...
107 (commented on others PR)
Do you think setAccelerator() can be removed too?
108 (commented on others PR)
If we are removing the menu, I think the exit button will disppear too, right?
109 (commented on others PR)
Similarly, this might not be needed anymore.
110 (commented on own PR)
Okay, noted on this. I will make the change. Thanks!
111 (commented on own PR)
Agreed! Let's remove the additional fields.
112 (commented on own PR)
Yes, right you are! I will change this.
113 (commented on own PR)
Interestingly, yyyyMd does not work.
Consider the date "12 Jan 2020", for instance. With yyyyMd, it would be "2020112". But this string is ambiguous. Are we referring to "2 Nov 2020" or "12 Jan 2020"?
If we want to use yyyyMd, we would need a delimiter (e.g. yyyy-M-d). I decided against using the hyphen because it doesn't read as well when it is a date range.
114 (commented on own PR)
Actually, yeah. It is probably not needed for an MVP.
The rationale behind adding DateTimeCreated is to allow the user to filter tasks with creation date as a criterion. For example, in Slack, users can see when the task is created. It is helpful when the user wants to query what tasks were created yesterday or within the last few days.
Right now, the plan is for the user to click on a Room in order to view all tasks assigned to it. There is no separate tab for the users to manage tasks (we should probably have this to show user which tasks from which rooms are due?). In the future, when we implement reminders or a search for tasks, DateTimeCreated might be more useful.
I think I will remove this from the MVP. Unit testing for this class also requires more work because we would need another layer of abstraction to handle and control the date-time instead of using LocalDateTime.now().
Thoughts on this?
115 (commented on own PR)
Okay!
116 (commented on own PR)
Nope, it is in an entirely different file. That said, I wonder if it will be confusing for the user?
117 (commented on own PR)
No problem!
118 (commented on own PR)
I think p/ is good 😄 We can try to keep it as short and sweet as possible since that's easier to remember.
119 (commented on own PR)
Good point. Will use that instead 👍
120 (commented on own PR)
It is missing the success case actually. Will need to set up a stub to perform the test. Will KIV 1st.
121 (commented on own PR)
Hmm could you clarify on this? I think most of the other Command classes handle add, delete, and update through Model. The Model is the abstraction.
122 (commented on own PR)
Good point. We should change the names of the tests here!
123 (commented on own PR)
Yes, @LeeMingDe mentioned this too!
124 (commented on own PR)
Hmm... Should it be in alphabetical order? I was thinking maybe it should be sorted by the type. We can have Patient, followed by Room, then Task.
3.2 Patient
3.2.1 Add Patient
3.2.2 Delete Patient
...
3.3 Room
3.3.1 Initialize Rooms
...
3.4 Task
3.4.1 Add Task
3.4.2 Delete Task
125 (commented on own PR)
The current arrangement is like this: the methods that are common to Patient, Room, and Task are placed into ParserUtil. Task-specific methods such as parseDescription are in TaskParserUtil.
Good observation!
126 (commented on own PR)
Oh I decided to group the success cases together. Might indeed be neater to space them out.
127 (commented on own PR)
roomNumber cannot actually be null though, because it is a primitive (i.e. int).
128 (commented on own PR)
Yup that's true. Good observation here 😄
That said, assertions may not necessarily be enabled, especially when an application goes into production.
The roomNumber > 0 check is to prevent the application from crashing if this method somehow gets called when assertions are off.
129 (commented on own PR)
Yup, I think the app is meant to crash in that case. model.getTaskFromRoomWithTaskIndex(taskIndex, room) should return either an empty Optional or an Optional-wrapped task. It should never be null here.
The app will crash with a NullPointerException if taskToDelete is null either way.
130 (commented on own PR)
Yup, it will crash the app provided assertions are enabled. If getRoomWithRoomNumber(...) is called with a roomNumber greater than 0, it would be a programming error. Crashing in that case is helpful for debugging.
131 (other comment)
@itssodium would you like to close this PR? I think we could keep the other one instead?
132 (other comment)
Good work! We will have to correct the CheckStyle problems in order to merge. Would you be able to change the order of imports?
133 (other comment)
We have decided to close this issue. Don't worry about creating the pull request from master.
For future pull requests, remember that every new feature should be done in a separate branch!
134 (other comment)
Task models are added 1st. Will be integrated with Room in v1.2.
135 (other comment)
While not ideal, I decided to force push to my own repo in order to squash the commits that contained only minor changes for CheckStyle compliance.
I will be more careful when pushing to my repo in the future.
136 (other comment)
Overall, clean and neat code! Believe you haven't integrated the command into the code yet but seems like good support for your command for now. One thing though, I am not sure why you want to have a DateTimeCreated for task? Anyway, LGTM!
Haha, yeah I set up the PR to update everyone with my progress. The integration is not complete yet. I will request for more reviews when the integration is done.
137 (other comment)
To fix your addressbook and let it show its contacts, follow these steps:
- Go to your data folder
- Open up addressbook.json
- In the second line, change "persons" to "patients"
I recommend deleting data/addressbook.json if you have not added any custom data. Upon restarting the app, the file should be regenerated.
138 (other comment)
Additionally, the logic in readAndSaveRoomList unit tests may be difficult to follow without comments. Do you think it would be possible to add
// Save in new file and read back
RoomOccupancyStorage roomOccupancyStorage = new RoomOccupancyStorage(numberOfRooms, roomsOccupied);
// ...
to indicate that you are saving and loading the file for testing?
There is also some code duplication in the readAndSaveRoomList tests, which we can consider refactoring into private methods.
139 (other comment)
I removed the link to #58 because we haven't actually displayed the Patient and Task details for each room. We can definitely merge 1st though.
140 (other comment)
Rebased to avoid additional merge commit.
141 (other comment)
lgtm, good job! However, the pr is super long, would it be better to like split it up in the future? eg. do the tasklist/task class and merge it first. then the addTask command and then merge it?
Totally agree with this. Ideally, I think a PR should not exceed 500 lines. It is difficult to review the PR when it is that long. I originally wanted to split this as well. Will definitely do so in the future! 👍
142 (other comment)
getRoomWithRoomNumber has been implemented in #115. Can use that for EditRoom too.
@junlong4321 (102 comments)1 (commented on others PR)
I think "the filename of the profile photo should be doc/images/githbub_username_in_lower_case.png" - Week 7 Point 2 in Project
2 (commented on others PR)
Might wanna consider team/samlsm instead
3 (commented on others PR)
Missing space before 4a.
4 (commented on others PR)
Missing space before 4a.
5 (commented on others PR)
Remove extra space
6 (commented on others PR)
Missing "Use case ends."
7 (commented on others PR)
Inconsistent comma, (+ EMAIL_DESC_BOB,)
8 (commented on others PR)
Inconsistent comma, (+ EMAIL_DESC_BOB,)
9 (commented on others PR)
Inconsistent comma, (+ EMAIL_DESC_BOB,)
10 (commented on others PR)
//// student-related tests may work better here instead of Student, since we also have //// moduleClass-related tests
11 (commented on others PR)
Extra space
12 (commented on others PR)
Extra space
13 (commented on others PR)
See if its possible to trim down this part. I took a couple of tries before I understood what was going on
14 (commented on others PR)
The {@code ModuleClass} must not exist in the current list
15 (commented on others PR)
Don't quite understand this. Specifically, don't understand what is a backing list and what is meant by unmodifiable
16 (commented on others PR)
/** Returns an unmodifiable view of the filtered
* {@code ModuleClass} list.
*/
17 (commented on others PR)
// student-related constants
18 (commented on others PR)
// moduleClass-related constants
19 (commented on others PR)
Need full stop for this comment
20 (commented on others PR)
Comments start with lower letter + no full stops
// workaround as storage functionality for ModuleClasses has not been implemented
21 (commented on others PR)
Ok lets retain it in that case
22 (commented on others PR)
Ok lets retain it in that case
23 (commented on others PR)
Ok lets retain it in that case
24 (commented on others PR)
Ok
25 (commented on others PR)
Missing space
+ PREFIX_TELEGRAM + "johnDO3 "
26 (commented on others PR)
Consider keeping the previous tag set? Because its more of an app to track students rather than keep address contacts.
I think the tagset got overwritten. Saw that you merged the master branch into your branch
27 (commented on others PR)
Might be good if we remove the telegram prefix, since user has to type @ for email. So we might want to keep the design consistent by making them type @ for telegram handle
An alternative would be to update both the UG and DG to reflect the telegram handle changes.
I personally would go for the former than latter. How about the rest?
28 (commented on others PR)
Any reasons why "student" was removed?
29 (commented on others PR)
Extra white space
30 (commented on others PR)
Any reasons for removing this white space?
31 (commented on others PR)
Any reasons for removing this white space?
32 (commented on others PR)
Any reasons for removing this white space?
33 (commented on others PR)
Resolved by sticking to using TELEGRAM_PREFIX = "@"
34 (commented on others PR)
Any reasons for removing this white space?
35 (commented on others PR)
Resolved by adding back "student" in command
36 (commented on others PR)
* @param index Index of the class in the filtered class list to edit.
37 (commented on others PR)
* @param editModuleClassDescriptor Details to edit the class with.
38 (commented on others PR)
// short circuit if same object
39 (commented on others PR)
// instanceof handles nulls
40 (commented on others PR)
// state check
41 (commented on others PR)
* @throws ParseException If the user input does not conform the expected format.
42 (commented on others PR)
I think the full stop got removed for some reasons.
My current updated code base has a full stop for this comment
* Parses input arguments and creates a new FindStudentCommand object.
43 (commented on others PR)
@throws ParseException If the user input does not conform the expected format.
44 (commented on others PR)
|| (other instanceof ModuleNameContainsKeywordsPredicate // handles null)
45 (commented on others PR)
start with lower case, e.g
// one keyword
46 (commented on others PR)
* Returns an {@code EditModuleClassDescriptor} with fields containing {@code moduleClass}'s details.
47 (commented on others PR)
Can you help center the fencing for the table?
48 (commented on others PR)
Can you help organise/center the fencing "|" for the userguide table as well? I remembered centering it awhile back during v1.1 but seems like some of the fences got out of position again
49 (commented on others PR)
Shows a list of all students and all classes in the application.
50 (commented on others PR)
Might want to consider putting this after DeleteModuleClassCommand.COMMAND_WORD but before LinkCommand.COMMAND_WORD to maintain a fixed action sequence
51 (commented on others PR)
"3" seems like a magic number across the test script. We might want to consider abstracting it into a variable in a separate PR
52 (commented on others PR)
I think we should use Color since the naming before the change was Color
53 (commented on others PR)
I agree with Dexter on this
54 (commented on others PR)
* Deletes the given {@code Student} and the {@code Student}'s {@code UUID} in all {@code ModuleClass}es.
55 (commented on others PR)
56 (commented on others PR)
57 (commented on others PR)
* Deletes {@code key} from this {@code TutorsPet} and also the {@code UUID} of {@code Student} from all {@code ModuleClass}es.
58 (commented on others PR)
Just to clarify, the reason why you create a new hashset is because the set returned by getStudentUuids() is immutable?
59 (commented on others PR)
// manually remove UUID
60 (commented on others PR)
Is this change because if a student is deleted, then the associated student in ModuleClass is removed as well?
61 (commented on others PR)
Extra space
62 (commented on others PR)
Extra space
63 (commented on others PR)
Can we remove this space? Since line 17 and 19 are both messages
64 (commented on others PR)
Space between line 15 and 16?
65 (commented on others PR)
The words undone and redone are kinda awkward but I think its okay if we express it in that way, since it still gets the message across in a succinct manner
66 (commented on others PR)
* Creates a {@code StateRecords} with the specified {@code currentIndex} and {@code stateRecords}.
67 (commented on others PR)
Extra space
68 (commented on others PR)
I agree with Dexter on this. We can probably extract the CRUD operations to Logic instead of clustering everything in AttendanceRecordListTest.java
69 (commented on others PR)
We can shift the CRUD here out to another class as well
70 (commented on others PR)
Any reasons for this spacing?
71 (commented on others PR)
Any reasons for this spacing?
72 (commented on others PR)
Would recommend putting new back, since we are technically still generating a new Lesson
73 (commented on others PR)
Nice assert
74 (commented on others PR)
Name moduleClassName= targetModuleClass.getName();
75 (commented on others PR)
+ PREFIX_WEEK + "WEEK_NUMBER (must be a positive integer) "
76 (commented on others PR)
+ "Note: All indexes must be positive integers.\n"
77 (commented on others PR)
Swap line 91 and 92 for consistency
78 (commented on others PR)
assert targetWeek != null;
79 (commented on others PR)
Maybe keep the original?
80 (commented on others PR)
+ "by the index number used in the displayed class list "
81 (commented on others PR)
* Adds all edited lessons in the target module class to the new module class.
82 (commented on others PR)
We can consider adding this for AddLessonCommand and DeleteLessonCommand as well
83 (commented on others PR)
👍🏻
84 (commented on others PR)
Then we might have to do a full refactor for all occurrences and stick with it? Because from what i remember, many of the shorthand for loops do not have spaces
85 (commented on others PR)
+ "Existing values will be overwritten by the input values.\n"
"Note: All indexes must be positive integers.\n"
86 (commented on others PR)
We can remove "must be a positive integer" from these 3 indexes to keep the formatting consistent with AddAttendanceCommand and DeleteAttendanceCommand
87 (commented on others PR)
Can we separate the else if to another if guard clause to keep the format consistent?
88 (commented on others PR)
String message =
89 (commented on others PR)
Separate guard clause
if (!isModuleClassIndexPresent || !isLessonIndexPresent || !isStudentPresent || !isWeekPresent) {
90 (commented on others PR)
if (argMultimap.getValue(PREFIX_PARTICIPATION_SCORE).isPresent()) {
91 (commented on others PR)
Thanks for the catch!
92 (commented on others PR)
Can we abstract out these values like AddAttendanceCommandTest and DeleteAttendanceCommandTest?
E.g
Index moduleClassIndex = INDEX_FIRST_ITEM;
Index lessonIndex = INDEX_FIRST_ITEM;
Index studentIndex = INDEX_FIRST_ITEM;
Week targetWeek = VALID_WEEK_1;
assertThrows(NullPointerException.class, () -> new DeleteAttendanceCommand(
null, lessonIndex, studentIndex, targetWeek));
93 (commented on others PR)
Nice catch!
94 (commented on others PR)
Can i check why is there a change to getOneBased() ?
95 (commented on others PR)
Can update the above /s to \
96 (commented on others PR)
Sry, is there a reason why this is being replaced?
97 (commented on others PR)
I see!
98 (commented on others PR)
Should we add in null tests for the other test cases as well?
99 (commented on others PR)
Would it be good to keep this? Because there might be multiple aspects to a feature
100 (commented on others PR)
Users should not have to type in attendance-related commands when the student is absent from a lesson.
101 (commented on others PR)
I'll send in a separate PR to update my pros and cons section as well. Lets follow your style of having the pros and cons as individual pointers rather than paragraphs
102 (commented on others PR)
+ "Note: All indexes and numbers must be positive integers.\n"
103 (commented on own PR)
Resolved by removing MODULE_CODE
104 (commented on own PR)
Resolved by removing MODULE_CODE
105 (commented on own PR)
Resolved by removing [] for all fields within add apart from [tag/TAG]
106 (commented on own PR)
Resolved by updating line 58 to
e.g. `[tag/TAG]…` can be used as ` ` (i.e. 0 times), `tag/student`, `tag/TA` etc.
107 (commented on own PR)
Resolved by adding in commit suggestion
**List Students in Class** | `list-students /by n/CLASS_NAME`<br> e.g., `list-students /by n/CS2103T Tutorial T10`
108 (commented on own PR)
Resolved by changing clear class to "clear-class"
109 (commented on own PR)
Resolved by changing list students to "list-students", and title to "Listing all students within a class"
110 (commented on own PR)
Resolved by retaining {:toc}
111 (commented on own PR)
Resolved by removing redundant add
112 (commented on own PR)
Resolved by moving ellipsis outside of square brackets
113 (commented on own PR)
Resolved by removing address field and updating tag prefix from /t to /tag
114 (commented on own PR)
Ok i won't be touching it in that case
115 (commented on own PR)
Added the tags, used tag/average and tag/TA candidate to keep formatting consistent
116 (commented on own PR)
I think it'd be better if the summary comes before the detailed explanation. As a user i wouldn't want to scroll downwards if i just want to reference the commands. What do the rest think?
117 (commented on own PR)
I thought of that, but the issue is that the formatting will not be standardized across the table and commands. I feel that perhaps its better to caps everything so that we standardize our documentation
118 (commented on own PR)
Issue is that the formatting will not be standardized across the table and commands. I feel that perhaps its better if we follow the actions used in the command summary?
119 (commented on own PR)
Changed Command summary to Command list
120 (commented on own PR)
Resolved by rewording expression to show that Tutor's Pet can return more than one user found
121 (commented on own PR)
Will keep clear instead of changing to delete
122 (commented on own PR)
Ok lets keep the previous
123 (commented on own PR)
Will be keeping line 155 instead
124 (commented on own PR)
To change to requireAllNonNull(uuid, name, phone, email, tags);
125 (commented on own PR)
Good catch, thxs, no point editing UUID so no point adding UUID into EditStudentDescriptor.
Resolved by removing setUuid() and getUuid()
126 (commented on own PR)
Resolved by changing line 93 to UUID updatedUuid = studentToEdit.getUuid();
127 (commented on own PR)
To add a DEFAULT_UUID in StudentBuilder.java and convert it to a UUID for usage instead of generating a random UUID for testing
128 (commented on own PR)
Resolved by removing UUID field
129 (commented on own PR)
Resolved by specifically adding Uuids into TypicalStudents
130 (commented on own PR)
RIP, forgot to remove sneaky boi
131 (commented on own PR)
Added the following :
JsonAdaptedStudent.java
if (uuid == null) {
throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT, "uuid"));
}
JsonAdaptedStudentTest.java
@Test
public void toModelType_invalidUuid_throwsIllegalValueException() {
JsonAdaptedStudent student =
new JsonAdaptedStudent(null, VALID_NAME, VALID_PHONE, VALID_EMAIL, VALID_TAGS);
String expectedMessage = String.format(MISSING_FIELD_MESSAGE_FORMAT, "uuid");
assertThrows(IllegalValueException.class, expectedMessage, student::toModelType);
}
Since UUID is a built-in java class, instead of doing something like throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT, Name.class.getSimpleName())); , i opted for throw new IllegalValueException(String.format(MISSING_FIELD_MESSAGE_FORMAT, "uuid"));
132 (commented on own PR)
Possible, but the json "studentIds" in the json file will be changed to "studentUuids". Which one do you guys prefer?
133 (commented on own PR)
I initially added a class entry, but then eventually removed them as I wanted to isolate the test cases better (Since this json file is more to test for invalidstudent rather than invalidclass.) Any thoughts?
134 (commented on own PR)
Currently since we are using UUID.randomUUID(), the edge case that could potentially happen is a null UUID rather than that of a UUID that is not specified properly, unless the user decides to edit the uuid in the json file to a smaller uuid string. Hence i decided to only test for toModelType_nullStudentIds_throwsIllegalValueException()
Any thoughts on this?
135 (commented on own PR)
Was thinking that a guard clause would be sufficient (Since its likely the case that a uuid is either well defined (by using Java's UUID.randomUUID(), or null))
Any thoughts on whether a try catch is needed here? Will include one if needed
136 (commented on own PR)
Thats a good idea. I'll pull information from ALICE directly and remove the TODO comment
137 (commented on own PR)
Resolved by keeping status quo for invalidClassTutorsPet.json (ie no changes)
138 (commented on own PR)
Resolved by adopting suggested change
139 (commented on own PR)
Resolved by pulling information from ALICE directly and removing TODO comment
140 (commented on own PR)
Resolved by refactoring all occurrences of studentIds to studentUuids, including the studentIds field in model ModuleClass.java
141 (commented on own PR)
Resolved by abstracting code inside toModelType() into two smaller methods.
142 (commented on own PR)
Resolved by adding try catch block
143 (commented on own PR)
Resolved by introducing checks for invalid UUIDs
144 (commented on own PR)
Yes, it applies across all UUIDs so long they are not invalid
An example of an invalid UUID is "fffa3023-7d89-426b-ba01-" // No uuid values after dash
In contrast, a valid uuid is "fffa3023-7d89-426b-ba01-d45eaa" // Missing values after d45eaa are padded with zeros
145 (commented on own PR)
Resolved by using existing information from ObservableList>Students> in tutorsPet
146 (commented on own PR)
Will change it to One or more of the given indexes are invalid.
147 (commented on own PR)
Could be a typo on the user's part. Would recommend keeping the Use case resumes at step 1.
148 (commented on own PR)
Added moduleClassIndex parameter into getAddLessonCommand
149 (commented on own PR)
Abstracted to ModuleClassUtil
150 (commented on own PR)
Added guard clause to check if attendance exist in the first place, and added negative test case to check for error message throwing for this scenario
151 (commented on own PR)
Changed to following AddAttendanceCommand format and throw MESSAGE_CONSTRAINT instead
152 (commented on own PR)
Added assertion for both DeleteAttendanceCommand and AddAttendanceCommand
153 (commented on own PR)
Inserted assertion
154 (commented on own PR)
Simplified for both AddAttendanceCommand and DeleteAttendanceCommand
155 (commented on own PR)
Created ModuleClassModificationUtil and LessonModificationUtil classes to address this
156 (commented on own PR)
Lets do it in a separate PR.
157 (commented on own PR)
createModifiedModuleClassWithModifiedLesson is used in AttendanceCommands. It is specifically used as a bridge to modify a targeted module class after CRUD has been done on attendance and stored inside a lesson. createModifiedModuleClassWithEditedLesson specifically performs CRUD on the lesson itself
158 (commented on own PR)
We can use manualReplaceLessonToModuleClass from ModuleClassUtil for now since there are no test cases for those methods which you've mentioned yet
159 (commented on own PR)
I'd like to check with you guys on how we should go about handling this block.
Problem : removeAttendance(...) throws CommandException when it is unable to find an attendance to delete. This works for individual attendances, but if we doing a cascading delete (ie removing all occurrences of the student), then we would want to return the attendanceRecord even if no student can be deleted.
Solution 1 (Currently implemented) : Do a try and catch to overwrite the CommandException
Solution 2 : Remove the removeAttendance(...) abstraction and use the underlying code in removeAttendance(...) in this method. But this will violate SRP.
Solution 3 : Propagate the CommandException upwards to LessonUtil and ModuleClassUtil and eventually UniqueModuleClassList. But downside is that you eventually have to handle it with try catch.
160 (commented on own PR)
To go with solution 1
161 (other comment)
Completed
162 (other comment)
This seems to be missing the saving of UUIDs to local storage, is that planned for a separate PR?
To implement saving of UUIDs to local storage
163 (other comment)
Mostly looks good to me, just need some minor changes.
Could you also add a test case to ensure that
EditStudentDescriptordoes not change the UUID of a student?
I think this part of EditStudentDescripterTest.java factors in that UUID isn't changed? Otherwise it will return false if the UUID changes
public class EditStudentDescriptorTest {
@Test
public void equals() {
// same values -> returns true
EditStudentDescriptor descriptorWithSameValues = new EditStudentCommand.EditStudentDescriptor(DESC_AMY);
assertTrue(DESC_AMY.equals(descriptorWithSameValues))
164 (other comment)
Not sure if we need to get approval before we merge this in since we are trying to use a new module?
Module has been removed (Last checked 26/09/2020)
165 (other comment)
Looks great! But like what Dexter said, I am not sure whether we need to get permission first.
Module has been removed
166 (other comment)
@ypinhsuan can yours work? my one works fine
167 (other comment)
Decided not to implement UUID equality check as it may risk introducing a lot of bugs into the code
168 (other comment)
Not required.
169 (other comment)
Use \ , update test cases to use PREFIX variables instead of hardcoding commands (e.g "\c")
@ruixuantan (91 comments)1 (commented on others PR)
I like your specifying: STUDENT_INDEX and CLASS_INDEX
2 (commented on others PR)
Perhaps it is clearer to define 'index' as follows?
*`STUDENT_INDEX` refers to the index number shown in the displayed student list.
*`CLASS_INDEX` refers to the index number shown in the displayed class list.
3 (commented on others PR)
Minor grammar issue, should it be is and not are?
* 5a. At least one of the given indexes is invalid.
4 (commented on others PR)
Same as issue above.
* 5a. At least one of the given indexes is invalid.
5 (commented on others PR)
Should we include test cases for UUID? Such as public void toModelType_nullUuid_throwsIllegalValueException().
6 (commented on others PR)
Apologies, mistake on my part for not typing correctly. Should be
public void toModelType_nullUuid_throwsIllegalValueException() {
Otherwise, looks good to merge.
7 (commented on others PR)
Should the tense follow the DeleteStudentCommand class instead?
public static final String MESSAGE_DELETE_MODULE_CLASS_SUCCESS = "Deleted Class: %1$s";
8 (commented on others PR)
Nice abstraction.
9 (commented on others PR)
Should the filtered list be specified?
* Updates {@code model}'s {@code filteredStudents} list to show only the student at the given {@code targetIndex} in the
10 (commented on others PR)
Same as above.
* Updates {@code model}'s {@code filteredModuleClasses} list to show only the ModuleClass at the given {@code targetIndex} in the
11 (commented on others PR)
Same as above.
* Updates {@code model}'s {@code filteredModuleClasses} list to show no module classes.
12 (commented on others PR)
Perhaps naming studentIds as studentUuids would make the code clearer?
13 (commented on others PR)
Should there be at least one class entry here? We can follow invalidClassTutorsPet.json, which has a valid student entry.
14 (commented on others PR)
Should you insert a INVALID_STUDENT_IDS list (and test case) also? Perhaps you can use a string that has less than 4 hyphens
15 (commented on others PR)
Nice handling of null UUIDs. However, would it be better if a try-catch block is used on UUID.fromString(uuid) instead? Then, any kinds of wrong UUIDs can be handled.
16 (commented on others PR)
I think you missed out on this:
public static final String MESSAGE_DUPLICATE_MODULE_CLASS = "Class list contains duplicate class(es).";
17 (commented on others PR)
I think you missed out on the TODO comment. Perhaps instead of importing these STUDENT_UUID_X in test cases, we can call ALICE.getUuid() from TypicalStudent class instead.
18 (commented on others PR)
Should this for loop be placed in another method for proper SRP? The for loop above that iterates through jsonAdaptedStudent can be similarly placed in another method. Then, this toModelType() method will call these two for loop methods.
19 (commented on others PR)
To add on, according to Java's UUID API, UUID.fromString() throws IllegalArgumentException. Perhaps you can use this alongside with your null guard clause.
20 (commented on others PR)
I notice this try-catch block appearing in other parts of the PR. I think the proper way would be to write our own interface for UUID. But, for now, I think it is not needed.
21 (commented on others PR)
Should you indent this line?
<fx:root minHeight="600" minWidth="740" onCloseRequest="#handleExit" title="Tutor's Pet" type="javafx.stage.Stage"
xmlns="http://javafx.com/javafx/11.0.1" xmlns:fx="http://javafx.com/fxml/1">
22 (commented on others PR)
I noticed that these 3 lines of code are repeated in above test cases. Perhaps can consider abstracting these out into a private method?
23 (commented on others PR)
Should this be:
ModuleClass specifiedClass = showStudentsInModuleClassAtIndex(expectedModel, INDEX_FIRST_ITEM);
24 (commented on others PR)
Should this be in the same 'format' as above?
assertCommandSuccess(new ClearModuleClassCommand(),
model, ClearModuleClassCommand.MESSAGE_SUCCESS, expectedModel);
25 (commented on others PR)
Would it be better to test against the moduleClasses directly? Since we are adding (and removing) them along with their studentUuids.
assertFalse(modelManager.hasModuleClass(CS2103T_TUTORIAL));
assertFalse(modelManager.hasModuleClass(CS2100_LAB));
26 (commented on others PR)
Similar to above.
assertFalse(tutorsPet.hasModuleClass(CS2103T_TUTORIAL));
assertFalse(tutorsPet.hasModuleClass(CS2100_LAB));
27 (commented on others PR)
Perhaps you can convert the for loop in ViewHistoryCommand into a method residing in StringUtil class.
This is to avoid the explicit construction of expectedMessage. For completeness, the new StringUtil method also needs to be unit tested.
28 (commented on others PR)
Should you move the 1 and 50 to static constants?
29 (commented on others PR)
Perhaps naming the variables as they are is good enough?
public static final String VALID_TIME_1400 = "14:00";
public static final String VALID_TIME_1600 = "16:00";
public static final Day VALID_DAY_WED = Day.WEDNESDAY;
public static final int VALID_NUMBER_OF_OCCURRENCES = 7;
public static final String VALID_VENUE = "COM1-B111";
30 (commented on others PR)
Should you also test the edge cases of 0, 50, and 51?
31 (commented on others PR)
Perhaps you can consider renaming WED_2_TO_4 to LESSON_WED_2_TO_4, so as to avoid confusing this constant as a time object.
32 (commented on others PR)
Just noticed, not sure if 'integer' is considered a technical term.
33 (commented on others PR)
Nice check.
34 (commented on others PR)
I don't really quite get the purpose of the cache.
35 (commented on others PR)
Understood the cache. Logger lgtm.
36 (commented on others PR)
I think should be Class'.
public static final String MISSING_FIELD_MESSAGE_FORMAT = "Class' %s field is missing!";
public static final String MESSAGE_INVALID_STUDENTS_IN_LESSON = "Invalid student(s) found in lesson(s).";
public static final String INVALID_FIELD_MESSAGE_FORMAT = "Class' %s field is invalid!";
37 (commented on others PR)
if (!studentUuids.contains(studentUuid)) {
throw new IllegalValueException(MESSAGE_INVALID_STUDENTS_IN_LESSON);
38 (commented on others PR)
Just throwing out this alternative: perhaps placing the Week object here would be better instead of in the JsonAdaptedAttendanceRecord class. So instead of having a List>JsonAdaptedAttendanceRecordList> attribute, there can be a Map>Week, JsonAdaptedAttendanceRecord>. Jackson supports Json serialisation of Maps: https://www.baeldung.com/jackson-map.
Purpose is for symmetry between the Model classes. And I think it may help in reducing lines of code and tests.
I think this current implementation is also suitable for purposes of this project.
39 (commented on others PR)
"_comment" : "StudentAttendance contains an invalid student attendance score",
40 (commented on others PR)
"_comment" : "StudentAttendance contains duplicate student UUID",
41 (commented on others PR)
"_comment" : "Records contains a null student UUID",
42 (commented on others PR)
"_comment" : "Records contains a null entry",
43 (commented on others PR)
"_comment" : "Record list contains duplicate AttendaceRecord",
44 (commented on others PR)
"_comment" : "null recordList",
45 (commented on others PR)
"_comment" : "recordList is empty",
46 (commented on others PR)
Would this be better?
+ "lesson on a specified week.\n"
+ "Note: All indexes and numbers must be positive integers.\n"
+ "Parameters: "
+ PREFIX_CLASS_INDEX + "CLASS_INDEX "
+ PREFIX_LESSON_INDEX + "LESSON_INDEX "
+ PREFIX_STUDENT_INDEX + "STUDENT_INDEX "
+ PREFIX_WEEK + "WEEK_NUMBER";
47 (commented on others PR)
Should this be moduleClassIndex?
48 (commented on others PR)
Perhaps you can consider writing a test case for finding attendance in a filtered list?
49 (commented on others PR)
Should you insert an assertion for lessonToEditIndex?
assert targetModuleClass != null;
assert lessonToEditIndex != null;
assert lessonToUpdate != null;
50 (commented on others PR)
Perhaps an assertion can be included here to check that the size of updatedAttendanceRecord has decreased by 1.
51 (commented on others PR)
I think this can be simplified to
Lesson modifiedLesson = new LessonBuilder(lesson)
.withAttendanceRecordList(new AttendanceRecordList(updatedAttendanceRecords)).build();
52 (commented on others PR)
I am wondering if these lines, along with the private methods declared below, can be abstracted into a class that deals with the manipulation of the Lesson and Attendance related classes. These lines of code are repeated in other commands and in test cases as well.
53 (commented on others PR)
Should this be a requireAllNonNull check, since it is a public method now?
requireAllNonNull(targetLesson, targetStudent, targetWeek, attendanceToAdd);
54 (commented on others PR)
Same as above. I notice that this occurs in the other refactored classes as well.
55 (commented on others PR)
Should you shorten the name of this method as well as the other refactored methods? Perhaps use addAttendanceToLesson?
56 (commented on others PR)
Should the methods from LessonModificationUtil and ModuleClassModificationUtil be used here instead? Perhaps we can do it after unit tests for these 2 classes are completed.
57 (commented on others PR)
* @see tutorspet.model.Model#getTutorsPet()
58 (commented on others PR)
* Represents a storage for {@link tutorspet.model.UserPrefs}.
59 (commented on others PR)
* Saves the given {@link tutorspet.model.ReadOnlyUserPrefs} to the storage.
60 (commented on others PR)
* @see tutorspet.logic.Logic#execute(String)
61 (commented on others PR)
* @see tutorspet.logic.Logic#execute(String)
62 (commented on others PR)
I think it would be great to include a javadoc comment here to summarize the purpose of this class.
63 (commented on others PR)
Same as the above comment on javadocs.
64 (commented on others PR)
Should you put these 2 variables as static constants or under a @BeforeEach method? They are used commonly in the test cases.
65 (commented on others PR)
Same static constant abstraction comment as above.
66 (commented on others PR)
Should you abstract these 2 lines out into a private method? These 2 lines are repeated in the add and edit methods.
67 (commented on others PR)
For statements such as these, would it be better to put the String.format method on the next line?
assertParseFailure(parser, " "
+ PREFIX_LESSON_INDEX + "1" + " "
+ PREFIX_STUDENT_INDEX + "1" + " "
+ PREFIX_WEEK + "1",
String.format(MESSAGE_INVALID_COMMAND_FORMAT, MESSAGE_USAGE));
68 (commented on others PR)
Same as above.
69 (commented on others PR)
Similar to the above comment, would it be better to format the statement as follows?
private static final String INPUT_PREAMBLE = " "
+ PREFIX_CLASS_INDEX + VALID_MODULE_CLASS_INDEX_ONE.getOneBased() + " "
+ PREFIX_LESSON_INDEX + VALID_LESSON_INDEX_TWO.getOneBased();
70 (commented on others PR)
Nice catch!
71 (commented on others PR)
I think it will be good to add a unit test that tests this method directly.
72 (commented on others PR)
Should this be h3 size instead?
### Display Statistics Feature
73 (commented on others PR)
I think this should be labelled 1 throughout?
1. `Logic` uses the `TutorsPetParser` class to parse the user command.
1. A new instance of a `StatisticsCommand` object would be created by the `StatisticsCommandParser` and returns to
`TutorsPetParser`.
1. `TutorsPetParser` encapsulates the `StatisticsCommand` object as a `Command` object which is executed by
the `LogicManager`.
1. The command execution calls static methods from the `ModuleClassUtil` and `LessonUtil` classes.
1. The result of the command execution is encapsulated as a `CommandResult` object which is passed back to the `Ui`.
74 (commented on others PR)
* **Alternative 2 (current choice):** Extract the methods out to another class
75 (commented on others PR)
* Pros: Does not violate the law of demeter. Increases cohesion and thus increases maintainability.
76 (commented on others PR)
The Undo/Redo mechanism is designed around maintaining a history of `TutorsPet` states, and restoring a particular state when the user triggers an undo or redo command.
77 (commented on others PR)
Perhaps consider reordering these statements or shifting the TutorsPetState diagram lower? So as to establish a clearer link to the diagram.
78 (commented on others PR)
Should 'Alternative' be renamed as 'Choices'?
79 (commented on others PR)
* Pros: Will use less memory (e.g. for `delete`, just save the student being deleted).
80 (commented on others PR)
Would it be better to shift this diagram to around line 278? The explanation is rather dense there.
81 (commented on others PR)
Sure!
82 (commented on others PR)
Should this method return a double instead to avoid rounding off errors?
83 (commented on others PR)
totalParticipationScore += getParticipationScoreFromLesson(lesson, targetStudent);
84 (commented on others PR)
Same consideration as above, to change the return type to a double.
85 (commented on others PR)
Would it be better to indicate 'weeks'? So index 4 will be name of the lesson and index 5 will be the string of weeks not attended.
+ "%4$s, Weeks: %5$s";
86 (commented on others PR)
Would it be better to return List>Integer> or int[] here, where each element of the list/array is the week number the student is absent? This will reduce the responsibility of this method and make testing easier. The method to convert this list to a string can be shifted to StatisticsCommand and be made private.
87 (commented on others PR)
Same consideration as above to change the return type to a List or Array.
88 (commented on others PR)
Can!
89 (commented on others PR)
Should you move this into a private method in this class?
90 (commented on others PR)
I think you missed out on the casting. Might have to tweak some of the test cases also.
return (double) totalScore / numOfWeeksParticipated;
91 (commented on others PR)
For example:
92 (commented on own PR)
Yup
93 (commented on own PR)
@junlong4321 yup, that is right.
@dextertanyj agreed, will remove a student not in any classes.
94 (commented on own PR)
Agreed. I was not so sure what exactly is to go into the Logic and Model components. That's why I switched to int.
95 (commented on own PR)
Have included similar tests for JsonAdaptedModuleClassTest and JsonAdaptedStudentTest.
96 (commented on own PR)
I think I will stick with the space, because it follows the comma then space convention.
For example: new A(a, b, c). So it feels more natural to have the space after colon.
97 (commented on own PR)
Agreed. But I cannot do it for AddLessonCommand as there is no list to 'compare' to.
98 (commented on own PR)
Changed to spaces before and after colons
99 (commented on own PR)
I think I will leave it like that for now, because I want to show Attendance. Will clarify with Prof Damith or Clarence.
@LeeMingDe (88 comments)1 (commented on others PR)
Yup, we should standardize comments. I think we can just follow the style you suggested. Everyone okay? @raymondge @itssodium @chiamyunqing
2 (commented on others PR)
is it be better to use comment.trim().isEmpty() instead of comparing it to null?
3 (commented on others PR)
i think you can use the TODO function so its easier to check what you have to do next time
eg.
``
//TODO: your todo item here
``
4 (commented on others PR)
i'm not very sure, does the java doc require the parameter and the return value? eg.
/**
* Returns true if a given string is a valid age.
*
* @param test....
* @return boolean.....
**/
5 (commented on others PR)
same for the java docs here!
6 (commented on others PR)
okay can!
7 (commented on others PR)
is it better if we do addpatient instead of addPatient? just asking out of curiousity, no need to change if you think its fine
8 (commented on others PR)
i think this should be addPatient instead of add?
9 (commented on others PR)
do you think we should add in details like the temp must be 1dp or that the age must be in the range from 0-120?
10 (commented on others PR)
hmm, why do you need this variable? Essentially, the numofRoomsInString is equal to Integer.toString(numOfRooms). so maybe you can just use that instead of declaring another variable?
11 (commented on others PR)
so for this, you can just use Integer.toString(numOfRooms)
12 (commented on others PR)
maybe you want to change the name to SearchPatientDescriptor? can rightclick, refactor -> rename
13 (commented on others PR)
not sure if this will fail the checkstyle because of multiple empty lines
14 (commented on others PR)
i think you can change the Person's to Patient's
15 (commented on others PR)
i think that this method might be a bit long, so maybe you want to extract out some lines of code into a new method? Its just a suggestion, it's fine without it also
16 (commented on others PR)
I think the one that was removed is correct? Might need to check
17 (commented on others PR)
is there a reason behind initializing the numerOfRooms to -1?
18 (commented on others PR)
perhaps it might be good to catch the exception for negative integers inputted by the user?
19 (commented on others PR)
Sorry, I don't really understand the need for a PriorityQueue in this class, can you explain the rationale for ti?
20 (commented on others PR)
can i know whats the purpose of this constructor? because its empty but yet it takes in an integer parameter
21 (commented on others PR)
i think i saw the method below this comment in the RoomBook class, so there might not be a need for this method here?
22 (commented on others PR)
same as the previous comment, this method might be a duplicate?
23 (commented on others PR)
since you are creating a new room every time the user adds a room, i think the previous data in the room might all be wiped?
24 (commented on others PR)
this might be a duplicate method too?
25 (commented on others PR)
it's only null for now right?
26 (commented on others PR)
i think this might override the data of the previous rooms too?
27 (commented on others PR)
i think you might want to change your naming for the priority queue and not use rooms? i got quite confused trying to read it
28 (commented on others PR)
since you are only counting the number of occupied rooms directly, will there be a problem with this? eg.
i have 3 rooms
room 1
room 2
room 3
So lets say room 1 and room 3 are occupied. so numberOfRoomsOccupied = 2 correct? But next time if you load the RoomBook, it will give me room 1 and room 2 occupied since the numberOfRoomsOccupied is 2?
29 (commented on others PR)
is the name of the file lol?
30 (commented on others PR)
this indentation might be abit off?
31 (commented on others PR)
let's work with the naming together for the test cases next time!
32 (commented on others PR)
is there a purpose for this method?
33 (commented on others PR)
i think you can delete this method if it is not in use
34 (commented on others PR)
hmm, i dont really think there is a need to test if the priority queues are equal? or if you want to test, you can just do
int[] array1 = roombook1.toArray();
int[] array2 = roombook2.toArray();
Arrays.equal(array1, array2);
35 (commented on others PR)
i think better naming of the paths would be good? it's a little bit hard to understand/remember what the constructor of RoomOccupancyStorage is supposed to take in
36 (commented on others PR)
by accident? maybe a slip of the finger?
37 (commented on others PR)
hmm, but i think you can just chain the methods together? like .getRoomBook().getRooms() etc
38 (commented on others PR)
hmm, i thought that this field not supposed to be here anymore?
39 (commented on others PR)
Hopefully we won't get merge conflict for this when we merge our UI hahaha
40 (commented on others PR)
thanks for helping me to change what i have missed!
41 (commented on others PR)
same here, thanks for catching this
42 (commented on others PR)
should we make it such that there cannot be patient with the same name?
43 (commented on others PR)
Is there a typo here? don't think we have UndoCommand and RedoCommand right? hahha
44 (commented on others PR)
if this part is not needed, then will it be better to just delete it?
45 (commented on others PR)
i think you can delete this line and subsequently, the convertPriorityQueue method
46 (commented on others PR)
can delete the method below. i dont think it's in use anymore. i only created it to bypass the need for an observablelist
47 (commented on others PR)
i'm not sure why it cannot be yyyyMd, is there a difference?
48 (commented on others PR)
i think he used it because it allows easier tracking of the tasks due date using DateTime instead of a string
49 (commented on others PR)
Very good use of ObservableList, this will help immensely in the integration into the UI!
50 (commented on others PR)
i think this should be null dateTime instead of email?
51 (commented on others PR)
i think this prefix is already used for periodOfStay in PatientCliSyntax.java, will it be affected?
52 (commented on others PR)
thanks for cleaning up my unused method from before! 👍
53 (commented on others PR)
i think its fine. It makes me wonder if I should convert my editroom prefixes to p/ instead of pn/ for patient name. hahahah
54 (commented on others PR)
Yup, adhering to abstraction principle is good, however i feel it might not be worth it to extract only 2 lines of code into a new method. maybe what wl can do is to perhaps give a name to the variable to make it clearer.
eg. String[] stringNames = searchPatientDescriptor.getStringName().split("\\s+"));.
55 (commented on others PR)
same here, abstraction principle is good, however, it might not be worth it to extract them out into a new method
56 (commented on others PR)
yup! is there a reason why you are checking if the search result has only has one value? I'm referencing to the (patientNameList.size() == 1) cuz your getListOutput(list) method will just print out everything
57 (commented on others PR)
hmm, just curious ah, why dont want just String stringName = argMultimap.getPreamble().trim().toLowerCase()? so eg. if you have searchpatient alex n/something, your stringName will be alex.
58 (commented on others PR)
Also, what is the substring(2) for ah? i think for very long but i still cant figure it out
59 (commented on others PR)
can consider Returns instead of Return? also, do we have to leave a line after line 70? i kind of remembered that it is in the coding convention but im not sure.
60 (commented on others PR)
might be good to have a java docs header before this!
61 (commented on others PR)
maybe you can use model.getUnmodifiableRoomList() here? model.getUnmodifidableRoomList() returns an ObservableList>Room> too. i discussed with yh last time about how the command class shouldnt be interacting directly with the room class but rather through the model class
62 (commented on others PR)
i changed the checkIfRoomPresent() method to a static method because of the reason below. ideally, i feel that checkIfRoomPresent() should be in RoomList.java class. what do you think?
63 (commented on others PR)
should there be an empty line before this line of code in the java docs?
64 (commented on others PR)
should there be an empty line before this? also, there are some extra white spaces in line 23
65 (commented on others PR)
same for the empty line before this
66 (commented on others PR)
ah, i see i see, sorry!! hahaha
67 (commented on others PR)
do you want to consider removing this comment? is it needed?
68 (commented on others PR)
would be good to have a class header for java docs!
69 (commented on others PR)
you can consider renaming your test method to toModelType_returnsOccupiedRoom_success() here.
70 (commented on others PR)
same here for the naming
71 (commented on others PR)
i think you can consider looking at the JsonAdaptedPersonTest class for an example of what to test!
72 (commented on others PR)
hmm, why do you need this method? is it to get access to the ObservableList? If you are not planning to modify the elements in the ObservableList but planning to "look at" the elements in it, you can consider the asUnmodifiableObservableList() method in this class at line 84
73 (commented on others PR)
do you want to consider moving these few lines of code into the map function from line 55? you can just write a one liner val = trimmedDueAt and i think it should do the trick?
74 (commented on others PR)
can consider val = trimmedDueAt so that any whitespaces are removed
75 (commented on others PR)
let us know if you need help with writing json test cases! Although Json is unfamiliar to me too, i'm sure we can work something out
76 (commented on others PR)
consider adding a java docs header here
77 (commented on others PR)
consider adding a java docs header here. Looks good to me for the testcases!
78 (commented on others PR)
you might want to standardize the naming of methods, so maybe this method can be toModelType_sameModelType_success(). same for subsequent methods below toModelType_sameModelType_throwsException(), toModelType_sameModelType_failure()
79 (commented on others PR)
remember to remove println statment here. you can consider adding a //TODO before using println statements, so you won't forget to remove them
80 (commented on others PR)
can remove instead of commenting if this is not going to be used in the future
81 (commented on others PR)
hmm for this right, why not just throw an exception in the method? why do you need to have a try-catch block to catch the exception and throw the same exception? eg. public void setTask(Task target, Task editedTask) throws TaskNotFoundException {
Edit: Nevermind, i understood, its because its a void method
82 (commented on others PR)
would it be better to name the test parseCommand_editTask_failure() or parseCommand_editTask_throwExceptions() instead? Same for the tests at the bottom too!
83 (commented on others PR)
actually, do you need to wrap this part in a else statement?
84 (commented on others PR)
need fullstop here for java docs?
85 (commented on others PR)
full stop here too?
86 (commented on others PR)
i think you can unwrap from the else statement here too?
87 (commented on others PR)
i think you should be asserting if the roomNumber is null? Because if the roomNumber is >0 then it should be the user fault and not the system fault no?
88 (commented on others PR)
same here for what yq and i mentioned previously
89 (commented on own PR)
makes sense, let me change it later
90 (commented on own PR)
oh ya, i forgot. ill change it later
91 (commented on own PR)
okay, let me change it now and update the pr
92 (commented on own PR)
yup, i think i missed out on that, thanks!
93 (commented on own PR)
i thought its already editpatient?
94 (commented on own PR)
okay can can
95 (commented on own PR)
whoops, let me rectify that
96 (commented on own PR)
the - means that its deleted
97 (commented on own PR)
all the red lines are deleted lines!
98 (commented on own PR)
okay, will change it, thanks!
99 (commented on own PR)
okay can, I will change it
100 (commented on own PR)
i think instead of arraylist, it might be better to use ObservableList directly. ObservableList is what is passed into ListView (UI component) and allows the UI to be updated whenever there is a change in ObservableList.
101 (commented on own PR)
okayy, ill change that real quick
102 (commented on own PR)
yup, i will change the indentation. good catch
103 (commented on own PR)
alright man, i have reverted all the wildcards imports! thanks for pointing it out
104 (commented on own PR)
the "-" is to remove the patient from the room! so eg. editroom 1 pn/-, it will remove the patient from room 1
105 (commented on own PR)
okayy, i will change it later! thanks for pointing it out
106 (commented on own PR)
yup, good idea
107 (commented on own PR)
i'm not sure how to use a switch here because the if conditions are all different, maybe you want to give me some suggestions?
108 (commented on own PR)
yup sure! i will change it
109 (commented on own PR)
cuz i feel like its not really an index, so grouping it under the index class seems wrong
110 (commented on own PR)
okay, let me try it out
111 (commented on own PR)
yes
112 (commented on own PR)
because i have to check if the room is present in the ObservableList. There is no way to access the RoomList other than through the ModelManager.java. i don't think its suitable to have a method in ModelManager.java to check if the room exists and to return that room
113 (commented on own PR)
sure, i can move the room related methods to RoomParserUtil
114 (commented on own PR)
I'm allowing the users to set the room number already, so index might not be that great...
115 (commented on own PR)
yup, i just changed it!
116 (commented on own PR)
i initially used hasRoom() and setRoom(). i forgot why i didnt use hasRoom() but i didnt use setRoom() because roomList class already has setRooms(), i feel that it will be quite confusing to have 2 methods named so closely to each other but does totally different things
117 (commented on own PR)
Yup, my test cases were failing, so I added a toString() to check. I thought about removing it, but I figured you might need it. Feel free to delete later. Don't think it matters
118 (commented on own PR)
Hmm, now thinking about it, it does seem like bad design. I'll change this later and update this pr. I will probably use the observablelist.stream().anyMatch to replace this (so it will stay in EditRoomCommand.java but won't have a method) . Do you think its a good idea?
119 (commented on own PR)
This is one of the dilemma I'm facing. Whether to have a static method in RoomList.java or have a method in EditRoomCommand.java (that is out of place). I think i will adopt the same method of just using the observablelist.stream.anyMatch() method and not create a new method. How does it sound?
120 (commented on own PR)
Since i have to change other parts, I think i will just update it in case I forget about it in the future
121 (commented on own PR)
thats true, let me shift the code there then
122 (commented on own PR)
i will shift this method to the model manager also
123 (commented on own PR)
okay sure!
124 (commented on own PR)
HAHAHAH, i wrote it that way so the method name not so long. will change it later!
125 (commented on own PR)
good catch on the ambiguity! i will make it clearer!
126 (commented on own PR)
there should only be one patient in a single room though. also, it doesnt move the patient, you have to clear the patient from the room first. maybe for v1.3, i can implement the auto remove and move feature
127 (commented on own PR)
yup, good catch. i removed it
128 (commented on own PR)
because the original css also have scrollPane in it, so i specified the css
129 (commented on own PR)
okay
130 (commented on own PR)
because initially it was just internalList.add(sth) and it wasnt updating the UI unless i change it to setAll
131 (commented on own PR)
not really, kinda forced to do it this way unless i dont use Index class for this method
132 (commented on own PR)
if i dont use Index class right, then i'll be using integer instead. cuz if i use roomlist.getObservableList.indexOf(getPatientWithName("some name here"), it will return -1 if the patient is not found. but Index class doesnt accept negative integer, so it will throw out an exception
133 (commented on own PR)
okay sure
134 (commented on own PR)
so its kinda like a comparison of using int vs using Index, because either way, i need the position of the patient from the list
135 (commented on own PR)
mayeb i will use this.roomList.getRoom..., because getRoomList returns the unmodifiable version
136 (commented on own PR)
yup. i dont really feel its a hack tho, cuz the ModelManager is supposed to interact with the roomlist directly. We should make it so that other classes cannot interact with the roomlist directly and remove the getModifiableRoomList though
137 (commented on own PR)
yup, wasnt really thinking sorz >>
138 (commented on own PR)
that is true, we can look into this for next week
139 (commented on own PR)
oki, i will do that next time HAHHAHA, didnt see
140 (other comment)
You can take a look at the RoomListPanel.java for references. I suspect the problem arose because you are calling patientDetailsPanel = new PatientDetailsPanel(patientToDisplay) and patientDetailsPanelPlaceholder.getChildren().add(patientDetailsPanel.getRoot()) repeatedly. Perhaps you can move both these LOC from the handleMouseClick and updateDetailsIfChanged method into the constructor for PatientListPanel.java
@silvernitro (80 comments)1 (commented on others PR)
Actually does the user need to list all modules first before adding a new one ah?
2 (commented on others PR)
Maybe an empty list shouldn't affect the addition of a new module? If not a user can never add his first mod since the list will be empty then LOL
3 (commented on others PR)
* Duplicates are not allowed (by .isSameModule comparison)
4 (commented on others PR)
Should we update the default pathname to gradpad.json or something along those lines?
5 (commented on others PR)
I think we can update the javadocs for these changed methods 😁
6 (commented on others PR)
* Adds a new {@code Module} to the {@code GradPad} that we are building.
7 (commented on others PR)
This test fails cos 2 Modules shouldn't be equal if they have different module codes. Perhaps we can remove the module code change
Module editedAlice = new ModuleBuilder(ALICE).withTags(VALID_TAG_CORE)
8 (commented on others PR)
I think we need to update TypicalModules.ALICE cos the tests can't build since ALICE is an invalid module. It'll probably be good to rename it too LOL cos alice is still a person's name
9 (commented on others PR)
Maybe we can rename the dummy path since we're no longer building addressbook 😁 Same goes for the change on line 46 below
userPrefs.setGradPadFilePath(Paths.get("gradpad/file/path"));
10 (commented on others PR)
Same as prev comment
11 (commented on others PR)
Maybe we can remove the regex split? It doesn't do anything since module codes never have spaces in them. Maybe we can just create an array with the module code in it as a single string:
String[] keywords = { CS2103T.getModuleCode().moduleCode };
12 (commented on others PR)
This is exactly the same as the CS2103T in the prev line HAHAHA so it'll always return true LOL
In this test, we are seeing if modules with the same module code and MCs, but different tags, will be considered the "same" by GradPad, so maybe we can just change the tag:
Module editedModule = new ModuleBuilder(CS2103T).withTags(VALID_TAG_NON_CORE)
13 (commented on others PR)
Nit: I think we need to update the javadocs for this method
14 (commented on others PR)
Let's change these example tags HAHA altho I wish modules could give me friends and money...
15 (commented on others PR)
public static final String MESSAGE_DUPLICATE_MODULE = "This module already exists in the grad pad";
16 (commented on others PR)
Perhaps we can rename the variable editModuleDescriptor here and also the references in the few lines below it.
EditModuleDescriptor editModuleDescriptor = new EditModuleDescriptor();
17 (commented on others PR)
public static final String MESSAGE_DUPLICATE_MODULE = "This module already exists in the grad pad.";
18 (commented on others PR)
/**
* Stores the details to edit the module with. Each non-empty field value will replace the
* corresponding field value of the module.
*/
19 (commented on others PR)
/**
* Creates and returns a {@code Module} with the details of {@code moduleToEdit}
* edited with {@code editModuleDescriptor}.
*/
20 (commented on others PR)
I think we need to update the javadocs here 😁
21 (commented on others PR)
* Deletes a Module identified using its displayed index from the grad pad.
22 (commented on others PR)
Perhaps we can use camelCase for the property names? JSON properties are basically hashmap keys; so just like how we wouldn't use multiple words (with spaces) in a key or variable name (altho JS/JSON allows), maybe we can use moduleCode or module_code instead?
23 (commented on others PR)
* Constructs a {@code JsonSerializablegradPad} with the given modules.
24 (commented on others PR)
Not a suggestion/request for change, but I was just wondering why the original code does this redundant check here when it could just call gradPad's setModules fxn, which already uses UniqueModuleList to ensure all modules are unique.
I just put this comment here first in case we want to improve code quality next time.
List<Modules> gradPadModules = modules.stream().map(JsonAdaptedModule::toModelType).collect(Collectors.toList());
try {
gradpad.setModules(gradPadModules);
} catch (DuplicateModuleException ex) {
throw new IllegalValueException(MESSAGE_DUPLICATE_MODULE);
}
25 (commented on others PR)
I think we need to rename the file also 😁
26 (commented on others PR)
I think this test assertion is the same as the one a few lines above 😁
Since it's supposed to include other valid values, perhaps we can do:
userInput = targetIndex.getOneBased() + CODE_DESC_CS2103T + INVALID_CREDITS_DESC + CREDITS_DESC_CS3216;
descriptor = new EditModuleDescriptorBuilder().withModuleCode(VALID_CODE_CS2103T).withModularCredits(VALID_CREDITS_CS3216).build();
27 (commented on others PR)
Nit: the test is perfectly fine but maybe we can replace the dummy keywords with module names
28 (commented on others PR)
The lastModule is already CS3216 right HAHA so we don't need to "edit" it with the same code and credits again
Module editedModule = moduleInList
.withTags(VALID_TAG_CORE).build();
29 (commented on others PR)
😁 I think the re-naming of the variable was missed out
30 (commented on others PR)
* A utility class to help with building EditModuleDescriptor objects.
31 (commented on others PR)
* Parses the {@code tags} into a {@code Set<Tag>} and set it to the {@code EditModuleDescriptor}
32 (commented on others PR)
nit: typo
33 (commented on others PR)
This module is valid HAHA
It's why the test for invalid module in JsonSerializableGradPadTest isn't passing
34 (commented on others PR)
Nit: grammar 😆
ease your module planning process. A module searching platform is also included in GradPad, providing easy
35 (commented on others PR)
class to create a corresponding `AddCommand`.
36 (commented on others PR)
I think the method call wasn't specified; is it supposed to be AddCommandParser.parse()?
37 (commented on others PR)
We need to change deletePerson(1) in line 51 😁
38 (commented on others PR)
deactivate GradPadParser
39 (commented on others PR)
typo? hehe
40 (commented on others PR)
Maybe we can rename the return variable as a or smth? I only named it e in my diagram cos it stands for EditCommand 😁
41 (commented on others PR)
Format: `add c/ {module code} cr/ {modular credits}`
42 (commented on others PR)
What does the timestamp in the status bar refer to ah?
43 (commented on others PR)
Grammar nit: Not really sure how to tweak it but "successful find" sounds a bit weeeird? 😁
Maybe one way could be "...in GradPad to successfully show the found module."?
44 (commented on others PR)
Yeah okay that sounds good 👍
45 (commented on others PR)
Let's update the javadocs too 😁
46 (commented on others PR)
Should we add "matches part of any word in ModuleCode" too? Since now we support it
47 (commented on others PR)
Do you think we should remove "multiple words" ah? I feel like it might be an irrelevant equivalence class now that we use a .contains() check
Removing it will also match the new test cases below since we're removing the old tests involving multiple words
48 (commented on others PR)
Is there a typo for help modules? LOL actually can't tell cos this is still a correct invalid command HAHA
49 (commented on others PR)
3. GradPad displays the deleted module onto the `Command Line Display`
50 (commented on others PR)
**Use case: UC05 Edit a Module in `Current Modules`**
51 (commented on others PR)
I think we also need an extension to cover the case when invalid fields are given e.g. credit/5 instead of cr/5
52 (commented on others PR)
Actually it's not just the required module list righttt cos that's only like ~10 mods out of all 150 CS mods that they can search for
1. User requests to search for a module in the CS curriculum.
53 (commented on others PR)
Same comment as previous 😁
54 (commented on others PR)
Perhaps it might be better to list this out separately? Maybe below this sentence we can put:
The following module details will be displayed:
module code
title
etc
55 (commented on others PR)
I think square brackets are only for optional arguments? Actually are we following the original UG syntax format ahhh? I'm not too sure
56 (commented on others PR)
Suggestion: Should we explain that we allow users to edit multiple fields in the same command?
57 (commented on others PR)
Minor minor code nit: perhaps this could be joined into one if statement instead of nesting so readers can easily tell what this block does (i.e. check if user is disconfirming)
boolean isDisconfirmation = stalledCommand instanceof Command && !commandText.equalsIgnoreCase("yes");
if (isDisconfirmation) {
58 (commented on others PR)
You mentioned that you were concerned about messiness earlier but I think this implementation is fine actually! 😀
But if we want to, we can abstract this out into a stallComponent fxn that handles the stalling. It might take in a Command, do the necessary stalling/operations, then return the CommandResult. This will make things more future-proof cos we don't know how many future commands need confirmation, and we don't wanna keep stuffing everything into execute
if (command instanceof ClearCommand || command instanceof DeleteCommand) {
return stallCommand(command); // returns the CommandResult
}
59 (commented on others PR)
These two lines need to be swapped 😁 cos we don't want to stall the command before checking that it's valid, which only happens when we call getModuleToDelete.
Right now if we type in an invalid delete e.g. "delete 100000", the command is still stalled and GradPad will wait for a confirmation. When a user then corrects himself and types "delete 1", GradPad will say "command aborted" instead of executing the corrected command
60 (commented on others PR)
Really really small nit: I think this method can remain as private since only handleStall should use it HAHA Actually how come it's changed from private -> public since the last review ah?
61 (commented on others PR)
Since we have so many messages here, perhaps we can shift this into a class on its own e.g. RequiredCommandMessages to avoid bloating the RequiredCommand class. We can then do static imports as needed
62 (commented on others PR)
This code seems to be repeated in a few compareX fxn so it might be good to abstract it out into a getModulesToAdd(>requiredModuleList>) fxn or something along those lines that takes in a List and returns the string modulesToAdd
63 (commented on others PR)
Maybe we can name this isFoundationCleared to make it more boolean-like? Same applies for the other compareX functions
64 (commented on others PR)
Perhaps we can use a java StringBuilder here since we're iteratively doing string concatenations (line 91). Otherwise we'll be doing O(n) operations per iteration and this fxn will run in O(n^2) 😁
65 (commented on others PR)
Maybe it'll be better if we handle the exceptions in this command instead of propagating it cos that would mean we need to change the execute contract (as has been done). But in doing so, we are breaking the interface segregation principle since ALL other commands are also now bound to a contract that isn't applicable to them.
66 (commented on others PR)
(cont. from prev comment)
So maybe what we can is to wrap these error-throwing calls in a try-catch block and handle exceptions here instead. After all, clients expect this execute method to give them a result (success or failure message), and not an exception.
try {
setFoundationStorage(FOUNDATION_PATH);
setITprofStorage(ITPROF_PATH);
setMathAndScienceStorage(MATHANDSCI_PATH);
setScienceStorage(SCIENCE_PATH);
setInternshipStorage(INTERNSHIP_PATH);
} catch (IOException | DataConversionException e) {
// from the error msg you wrote in MainWindow hehe
return new CommandResult("File not found :(");
}
67 (commented on others PR)
Maybe we can declare the pathstring as a class-level constant instead to make it obvious where the filepath is stored when we need to change it next time 😄
68 (commented on others PR)
Same as RequiredCommand, perhaps we can wrap this in a try-catch and handle the exception here rather than propagating it and binding all other commands to a new contract
69 (commented on others PR)
Same as previous comment in RequiredCommand, we can use a StringBuilder instead so that this fxn can run in O(n) instead of O(n^2)
70 (commented on others PR)
Maybe we can initialize this to an empty Optional instead of leaving it as null? I think it's a bit weird that the field can either be null, empty Optional, or filled Optional when the purpose of Optionals is to abstract away nulls anyway HAHA
But this one is really a minor suggestion 😁
71 (commented on others PR)
Perhaps we can consider using this instead:
assertTrue(actual.isEmpty());
As mentioned in the java API, it's generally not recommended to do equality checks for Optionals cos they produce unpredictable results 😁 Same applies for the other tests below and also ScienceCommandTest
72 (commented on others PR)
Shouldn't areModulesCleared become true when we find out that the user has taken a science module?
73 (commented on others PR)
Likewise if areModulesCleared is true then shouldn't we be showing MESSAGE_SUCCESS_SCIENCE instead since the user has cleared this basket HAHA
74 (commented on others PR)
How come taking a single internship module means that areModulesCleared is false ahh? I tot it should only be false if total MCs > 12 since we need >= 12 in order to clear the internship basket >>
I FEEL LIKE IM MISSING SOMETHING OBVIOUS LOL SO PLS FORGIVE ME IF I AM HAHA IM DAMN CONFUSED
75 (commented on others PR)
Actually how come we need the areModulesClearedflag instead of using an if-else statement ahhh?
Just to clarify, is this code saying: if a module is taken, then add its MCs to modularScore. If it's not, add the module title/mc to the result to display instead.
PAISEH I'm very confused here ><
if (doesModuleAlreadyExist(module, currentModules)) {
int modularCredits = Integer.parseInt(module.getModularCredits().toString());
modularScore += modularCredits;
} else {
String moduleToAdd = module.getModuleCode() + " (" + module.getModularCredits() + " MCs)";
leftOverInternship.append("\n").append(moduleToAdd);
}
76 (commented on others PR)
I think we might not need to catch, reconstruct, and re-throw the same exception? HAHA We can just remove the try-catch block 😁
77 (commented on others PR)
I think there's no IllegalArgumentException to catch here LOL StringUtil.ignoreCase and SearchCommand's constructor both don't throw ittt
78 (commented on others PR)
Just interesting side note (no need to change anything!):
JUnit tests automatically fail if any exception is thrown so we don't need to be concerned with catching exceptions and failing the test ourselves 😄
79 (commented on others PR)
Oooh okay! My bad hehe I didn't realised that checkArgument in StringUtil.ignoreCase() throws an undeclared IllegalArgumentException (since its a runtime error)
80 (commented on others PR)
No need to change, this is great 😄
81 (commented on own PR)
Updated these 2 badges so that when you click on them, they take you to our repo's CI and codecov pages respectively:
82 (commented on own PR)
Let me know if this regex is fine cos I'm not too sure what kind of module codes we support
83 (commented on own PR)
I left the contents unchanged for now as I only needed the tags as defaults
84 (commented on own PR)
I added module field templates here and left the rest of the templates alone. We can remove at the end if nobody else needs them
85 (commented on own PR)
I only added CS2103T and CS3216 as new modules in this class and left everything else alone first. Likewise, if nobody else needs them, we can remove them at the end
86 (commented on own PR)
Oh yeah you're right. In that case, I'll let filterModuleSummaries take in a bunch of keywords to filter against. We can then define the keywords in a hardcoded constant depending on the list of required modules.
87 (other comment)
Ui looks great but I think the website says it has to be the ard the same size as the original. Right now it's too big:
Feel free to resize, update the PR, and merge in your own time! 💯
88 (other comment)
I think this issue is too big and general? Maybe each person can create an issue specific to their work e.g. my issue should be "Add feature list and command summary to user guide" since I'm doing first page of our google docs
89 (other comment)
@yan-soon typos have been fixed; thanks so much for catching them!
90 (other comment)
Update: As per @shaokiat suggestion, tweaked filterModuleSummaries method in DataFetcherManager class to accept multiple keywords to filter against. For now, I put some sample keywords in a constant MODULE_FILTER_KEYWORDS in the same class. We can change it when we work on required modules?
@yongping827 (69 comments)1 (commented on others PR)
Tertiary student instead of Tertiary students
2 (commented on others PR)
expenses/incomes instead of expenses/income
3 (commented on others PR)
Manage instead of manage
4 (commented on others PR)
* Responsibilities: Scheduling and Tracking, User Interface
5 (commented on others PR)
/**
* Parses input arguments and creates a new AddExpenseCommand object.
*/
6 (commented on others PR)
Add the full stop. The corresponding comment in AddIncomeCommandParser should have a full stop as well.
7 (commented on others PR)
assertParseFailure(parser, "1" + INVALID_TITLE_DESC, Title.MESSAGE_CONSTRAINTS); // invalid title
8 (commented on others PR)
* @throws ParseException If the user input does not conform to the expected format.
9 (commented on others PR)
Either
INCOMES,
EXPENSES,
or
INCOME,
EXPENSE,
10 (commented on others PR)
public void parseCommand_unrecognizedInputWhenOverviewTab_throwsParseException() {
Also in other similar places.
11 (commented on others PR)
Is it possible to not hard-code the value 7? Same as in ListIncomeCommandTest and ListTransactionCommandTest
12 (commented on others PR)
assertEquals(model.getFilteredExpenseList().size(), getTypicalExpenses().size());
This together with an additional import statement:
import static ay2021s1_cs2103_w16_3.finesse.testutil.TypicalTransactions.getTypicalExpenses;
13 (commented on others PR)
// ensures that outOfBoundIndex is still within bounds of finance tracker list of expenses
14 (commented on others PR)
// ensures that outOfBoundIndex is still within bounds of finance tracker list of incomes
15 (commented on others PR)
Line 73
// ensures that outOfBoundIndex is still within bounds of finance tracker list of transactions
16 (commented on others PR)
- Add a class to store frequent expenses/incomes (such frequent expenses/incomes will be in a separate list)
17 (commented on others PR)
- In Analytics, make use of `YearMonth` instead of `LocalDate`
18 (commented on others PR)
- Investigate feasibility of UI testing. If not viable, then remove it from the testing suite.
19 (commented on others PR)
Expense editedBubbleTea = new TransactionBuilder(BUBBLE_TEA)
20 (commented on others PR)
public static final Expense TUITION_FEES_2 = new TransactionBuilder().withTitle("Tuition Fees")
21 (commented on others PR)
public static final Income TEACHING_ASSISTANT_2 = new TransactionBuilder().withTitle("Teaching Assistant")
22 (commented on others PR)
public static final Expense BUBBLE_TEA_2 = new TransactionBuilder().withTitle(VALID_TITLE_BUBBLE_TEA)
23 (commented on others PR)
public static final Income INTERNSHIP_2 = new TransactionBuilder().withTitle(VALID_TITLE_INTERNSHIP)
24 (commented on others PR)
assert (transactionToEdit instanceof Income);
return new Income(updatedTitle, updatedAmount, updatedDate, updatedCategories);
Since the previous assertion was removed, maybe an assertion here might be necessary? Same for similar occurrences.
25 (commented on others PR)
assertTrue(transactionToEdit instanceof Income);
editedTransaction = editedTransactionBuilder.buildIncome();
26 (commented on others PR)
assertTrue(lastTransaction instanceof Income);
editedTransaction = editedTransactionBuilder.buildIncome();
27 (commented on others PR)
assertTrue(transactionInFilteredList instanceof Income);
editedTransaction = editedTransactionBuilder.buildIncome();
28 (commented on others PR)
* On app launch: Initializing the components in the correct sequence, and connecting them to each other.
29 (commented on others PR)
public static final String COMMAND_WORD = "convert-frequent-expense";
30 (commented on others PR)
public static final String COMMAND_WORD = "delete-frequent-expense";
31 (commented on others PR)
* Deletes a frequent expense identified using its displayed index from the finance tracker.
32 (commented on others PR)
Remove unnecessary newlines.
33 (commented on others PR)
public static final String COMMAND_WORD = "edit-frequent-expense";
34 (commented on others PR)
Should FrequentExpense be a subtype of Expense? Consider the fact that they appear in different lists, and are treated very differently. Moreover a method to convert a FrequentExpense to an Expense is implemented .Also note that FrequentExpense should not have a Date field, since its date is undefined. Only the Expense that it converts to should have a date.
35 (commented on others PR)
public class FrequentExpenseList implements Iterable<FrequentExpense> {
This follows from the class TransactionList and the deprecated ExpenseList and IncomeList. This will account for the method iterator in line 82.
36 (commented on others PR)
With reference to the comment on line 11 in FrequenceExpense, date should not be present.
37 (commented on others PR)
* Constructs a {@code JsonAdaptedFrequentExpense} with the given frequent expense details.
38 (commented on others PR)
* @throws IllegalValueException if there were any data constraints violated in the adapted frequent expense.
39 (commented on others PR)
These lines are repeated in lines 106-107.
40 (commented on others PR)
Remove extra newline.
41 (commented on others PR)
This class seems debatable. Note that TransactionBuilder was used to cover both Expense and Income. Should the same be done here? i.e. FrequentTransactionBuilder to cover FrequentExpense and the upcoming FrequentIncome.
42 (commented on others PR)
Similar to the issue in FrequentExpenseBuilder, should a class TypicalFrequentTransactions cover for both FrequentExpense and FrequentIncome?
43 (commented on others PR)
* Returns an unmodifiable view of the frequent expense list.
Same with similar Javadocs in this class.
44 (commented on others PR)
This method seems to be taken from getFilteredExpenseList and getFilteredIncomeList, which are found to be buggy. Please modify it to be an ordinary getter.
45 (commented on others PR)
/** Returns an unmodifiable view of the filtered frequent expense list. */
46 (commented on others PR)
"The transaction index provided is invalid.";
47 (commented on others PR)
Is it possible to just have equals since these two methods are exactly the same?
Also, for the sake of consistency, use:
getTitle().equals(otherFrequentExpense.getTitle())
Similar for other places.
48 (commented on others PR)
Unnecessary use of super.
49 (commented on others PR)
This method is repeated in AddExpenseCommandParser and AddIncomeCommandParser. Perhaps in a future PR this method could be placed somewhere else, then imported into classes that require it?
50 (commented on others PR)
Remove unnecessary newlines.
51 (commented on others PR)
These Index objects are repeated from those above. I would suggest reusing those above rather than create multiple repeats of the exact same object. Perhaps maybe rename the three indexes above to something more general, like INDEX_FIRST and so on.
52 (commented on others PR)
A more appropriate name should be used.
53 (commented on others PR)
* Converts this Jackson-friendly adapted frequent expense object into the model's {@code FrequentExpense} object.
54 (commented on others PR)
FrequentExpense validFrequentExpense = new FrequentTransactionBuilder().buildFrequentExpense();
55 (commented on others PR)
Undescriptive variable name
56 (commented on others PR)
Undescriptive variable name
57 (commented on others PR)
Undescriptive variable name
58 (commented on others PR)
There is a similar method in TypicalTransactions. Moreover, the FinanceTracker object returned by this method has no transactions while the other one in TypicalTransactions has no frequent expenses. Consider putting these two classes together so that getTypicalFinanceTracker will return a FinanceTracker object that has at least one item in each of its lists.
59 (commented on others PR)
.iml files should not be committed. Also, there should not be an .iml file here in the first place, unless you did something you were not supposed to do.
60 (commented on others PR)
return internalFrequentIncomeList.iterator();
61 (commented on others PR)
FinanceTracker sampleFt = new FinanceTracker();
62 (commented on others PR)
@JsonProperty("categories") List<JsonAdaptedCategory> categories) {
For some reason checkstyle accepts indentation level 8, though according to the textbook in this case it should be indentation level 12.
63 (commented on others PR)
@JsonProperty("categories") List<JsonAdaptedCategory> categories) {
64 (commented on others PR)
@JsonProperty("incomes") List<JsonAdaptedIncome> incomes,
@JsonProperty("frequentExpenses") List<JsonAdaptedFrequentExpense>
Follow this indentation for the lines below as well.
65 (commented on others PR)
* Returns an unmodifiable view of the list of {@code FrequentExpense} backed by the internal frequent expense list of
66 (commented on others PR)
* Returns an unmodifiable view of the list of {@code FrequentIncome} backed by the internal frequent income list of
67 (commented on others PR)
Remove unused field.
68 (commented on others PR)
Shouldn't this test mirror FrequentExpenseListTest? There are less tests here than in FrequentExpenseListTest.
69 (commented on others PR)
public <T extends Transaction> FrequentTransactionBuilder(FrequentTransaction<T> frequentTransactionToCopy) {
title = frequentTransactionToCopy.getTitle();
amount = frequentTransactionToCopy.getAmount();
categories = new HashSet<>(frequentTransactionToCopy.getCategories());
}
70 (commented on own PR)
Glossary terms shall remain unformatted. Edits will be made.
71 (commented on own PR)
Yes, it will remain unchanged.
72 (commented on own PR)
Agree. This will be handled in a future PR.
73 (other comment)
PR has been recorded by the grading script.
74 (other comment)
ModelManager::filteredTransactions was ideally supposed to contain both expenses and incomes from FinanceTracker::expenses and FinanceTracker::incomes, through the methods FinanceTracker::getExpenseList and FinanceTracker::getExpenseList while completely omitting FinanceTracker::transactions. Thus, ModelManager would have 3 lists while FinanceTracker would have 2.
However, the implementation of the class FilteredList is that one of its fields (source) is an ObservableList object, and constructing a FilteredList as such:
ObservableList<E> observableList = FXCollections.observableArrayList()
FilteredList<E> filteredList = new FilteredList(observableList);
would result in source = observableList.
In essence, a FilteredList object needs to keep track of an ObservableList object.
Thus, filteredTransactions needs to keep track of its own ObservableList object, and cannot track both expenses and incomes together. Therefore, FinanceTracker::transactions cannot be removed, and neither can the class TransactionList.
75 (other comment)
Possible solutions:
Add a switch statement that refreshes the tab after every command.
Modify CommandResult to indicate any changes.
Make use of listener, somehow.
Add additional getters for the lists or for the transactions based on index.
76 (other comment)
FinanceTracker::resetData does not account for frequent incomes. This stems from FrequentIncomeList class missing some methods. Reference FrequentExpenseList for these missing methods. From there, FinanceTracker and ModelManager should have similar methods as well.
@ianyong (66 comments)1 (commented on others PR)
* Tertiary student
2 (commented on others PR)
| `* * *` | user | set a monthly spending limit | track how much I have left to spend for the month |
3 (commented on others PR)
Don't commit .iml files.
4 (commented on others PR)
* **Tools**:
Newline at EOF.
5 (commented on others PR)
parseEmail should be renamed to parseDate with the corresponding parameter renamed. Same for all other instances.
6 (commented on others PR)
parseTag should be renamed to parseCategory with the corresponding parameter renamed. Same for all other instances.
7 (commented on others PR)
parsePhone should be renamed to parseAmount with the corresponding parameter renamed. Same for all other instances.
8 (commented on others PR)
* Parses an {@code String amount} into a {@code Amount}.
9 (commented on others PR)
* @throws ParseException if the given {@code amount} is invalid.
10 (commented on others PR)
* @throws ParseException if the given {@code date} is invalid.
11 (commented on others PR)
* Parses a {@code String category} into a {@code Category}.
12 (commented on others PR)
* @throws ParseException if the given {@code category} is invalid.
13 (commented on others PR)
* Parses {@code Collection<String> categories} into a {@code Set<Category>}.
14 (commented on others PR)
parseTags should be renamed to parseCategories with the corresponding parameter renamed. Same for all other instances.
15 (commented on others PR)
The UI consists of a `MainWindow` that is made up of parts e.g.`CommandBox`, `ResultDisplay`, `TransactionListPanel`, `StatusBarFooter` etc. All these, including the `MainWindow`, inherit from the abstract `UiPart` class.
16 (commented on others PR)
<div markdown="span" class="alert alert-info">:information_source: **Note:** An alternative (arguably, a more OOP) model is given below. It has a `Category` list in the `AddressBook`, which `Transaction` references. This allows `AddressBook` to only require one `Category` object per unique `Category`, instead of each `Transaction` needing their own `Category` object.<br>
17 (commented on others PR)
ecp -> ec ++: index, editPersonDescriptor
Let's update the diagrams at a later stage.
18 (commented on others PR)
Simply add the following to [`seedu.address.ui.PersonCard`](https://github.com/se-edu/addressbook-level3/commit/850b78879582f38accb05dd20c245963c65ea599#diff-0c6b6abcfac8c205e075294f25e851fe).
Let's revert this change since we will most likely be deleting tutorials eventually.
19 (commented on others PR)
Person editedPerson = createEditedPerson(personToEdit, editPersonDescriptor);
20 (commented on others PR)
Could you import EditCommand.EditTransactionDescriptor instead?
21 (commented on others PR)
* Adds an income to the finance tracker.
22 (commented on others PR)
The command result display is not big enough to display everything, nor can it be scrolled. Instead, the words are just cut off.
23 (commented on others PR)
Should something else be used instead of menu? Having to click the Menu, then the MenuItem for tabs is very clunky. An alternative is JavaFX TabPane.
24 (commented on others PR)
I don't think the help menu should be grouped with the other options as the other options are tab headers while the help menu is a menu.
25 (commented on others PR)
This extra line break can be removed.
26 (commented on others PR)
* Opens the analytics window.
Missing full stop.
27 (commented on others PR)
panelLabel does not seem to correctly reflect the chosen tab.
Note how Income is selected, yet the label displays Expense.
28 (commented on others PR)
If the JavaFX TabPane were used, I don't think you need to write such hacky code.
29 (commented on others PR)
* Creates an {@code ExpensePanel} with the given {@code ObservableList}.
30 (commented on others PR)
Should this class be dealing with Expense objects instead of Transaction objects?
31 (commented on others PR)
* Creates an {@code IncomePanel} with the given {@code ObservableList}.
32 (commented on others PR)
Should this class be dealing with Income objects instead of Transaction objects?
33 (commented on others PR)
Any reason why these imports aren't grouped with the others?
34 (commented on others PR)
Move this import up with the other imports, and leave a line after the last import.
35 (commented on others PR)
This might be due to the bug found by @zhaojj2209 whereby switching tabs works only for the first time since the application was started.
36 (commented on others PR)
Unable to reliably replicate this. I'll close this comment for now and keep and eye for this bug occurring in the future.
37 (commented on others PR)
@siddarth2824 will be addressing this in a separate PR.
38 (commented on others PR)
See https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/75#discussion_r501141034.
39 (commented on others PR)
See https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/75#discussion_r501141034.
40 (commented on others PR)
This will be changed in a future PR once the Expense model is more fleshed out.
41 (commented on others PR)
This will be changed in a future PR once the Income model is more fleshed out.
42 (commented on others PR)
Add full stops? Same for the other comments.
43 (commented on others PR)
Possible to add backticks to parts which reference code? i.e. AddCommand
44 (commented on others PR)
+ ": Deletes the expense identified by the index number used in the displayed expense list.\n"
45 (commented on others PR)
+ ": Deletes the income identified by the index number used in the displayed income list.\n"
46 (commented on others PR)
* Deletes an income identified using its displayed index from the finance tracker.
47 (commented on others PR)
* Deletes an expense identified using its displayed index from the finance tracker.
48 (commented on others PR)
Currently, these specific success messages are being shown. Should these be removed?
49 (commented on others PR)
This value depends on the number of entries in our test data though. How do you propose we get around this without hard-coding?
50 (commented on others PR)
public void execute_showsAllExpenses() {
Sounds weird otherwise. 😕
51 (commented on others PR)
public void execute_showAllIncomes() {
52 (commented on others PR)
Is this line break intended?
53 (commented on others PR)
- Edit find commands to be similar to edit commands e.g `find INDEX KEYWORD`
54 (commented on others PR)
Should the date be set in the CNY period?
55 (commented on others PR)
Perhaps bullet points detailing the behaviour of the command on each tab could be moved from the format section to the description section? @yongping827 what do you think?
56 (commented on others PR)
Can getFilteredExpenseList return an ObservableList>Expense> instead?
57 (commented on others PR)
Similarly, can getFilteredIncomeList return an ObservableList>Income> instead?
58 (commented on others PR)
Can we enforce the subtypes within the list itself?
59 (commented on others PR)
Use a more descriptive variable name.
60 (commented on others PR)
Use a more descriptive variable name.
61 (commented on others PR)
Remove extra newline.
62 (commented on others PR)
This is quite bad design. Perhaps we should just throw an error when executing any of the base commands which should never be executed?
63 (commented on others PR)
Refer to issue #125.
64 (commented on others PR)
Is this assertion necessary?
65 (commented on others PR)
Similarly, is this necessary?
66 (commented on others PR)
`JsonAdaptedExpense` and `JsonAdaptedIncome` are JSON-friendly adaptations of `Expense` and `Income` respectively.
67 (commented on own PR)
pitest can be added at a later time when we get around to achieving full coverage.
68 (commented on own PR)
My bad, removed test.
69 (commented on own PR)
I thought that the GITHUB_TOKEN secret was being blocked due to this PR being from a fork. Seems to also happen with branches on this repo. 😕
70 (commented on own PR)
Apparently, GITHUB_TOKEN cannot be used; must be a GitHub user's personal access token.
71 (commented on own PR)
Setting the baseurl to be the repo name is necessary for GitHub Pages to function.
72 (commented on own PR)
CI job is able to run now. Tested on a branch of this repo as PRs from forks are unable to access secrets.
See https://github.com/AY2021S1-CS2103T-W16-3/tp/runs/1160121842.
73 (commented on own PR)
@yongping827 The corresponding comment in AddIncomeCommandParser does not have a full stop, should I still add it?
74 (commented on own PR)
This was left as such to mirror the corresponding change in #56. Can I confirm this is not intended?
Edit: Never mind, just saw https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/63#discussion_r499263026.
75 (commented on own PR)
Full stops to be added separately. This is honestly very low priority.
76 (commented on own PR)
Hmm, I went with ListTransactionCommand as the commands shouldn't have to care about the state of the UI; that's the job of the FinanceTrackerParser.
77 (commented on own PR)
This comment is here because the contents of this file needs to correspond to the transactions created in TypicalTransactions. For the other test JSON files, they have no such dependency.
78 (other comment)
I was wondering why IntelliJ was throwing warnings for the pitest task in build.gradle. See https://github.com/szpak/gradle-pitest-plugin#eliminate-warning-in-idea. For documentation purposes only; I agree that this change feels less readable.
79 (other comment)
Requested for permission to use the external library at nus-cs2103-AY2021S1/forum#253.
80 (other comment)
LGTM!
81 (other comment)
While the current deployment process works with personal access tokens, @wltan brought up the point that we should have it work with the repository token GITHUB_TOKEN instead. This is a more ideal solution, especially if Prof Damith were to adopt the use of jekyll-spaceship.
82 (other comment)
Relative links are currently not working. Trying to find a fix.
83 (other comment)
PR has been picked up by the grading script.
84 (other comment)
Closed with #50.
85 (other comment)
Screenshots
Desktop:
Mobile:
86 (other comment)
Could you rebase to address merge conflicts before we start reviewing?
87 (other comment)
Issue seems to be caused by spaces in the file path.
88 (other comment)
Define the allowed inputs for Title and Category more explicitly in the user guide. The intricacies of the input validation cannot be captured within MESSAGE_CONSTRAINTS without making it unnecessarily verbose which is not user friendly.
See #130.
@chiamyunqing (63 comments)1 (commented on others PR)
Can consider renaming function to execute_invalidPersonName... instead of Index since we are editing by name now.
2 (commented on others PR)
Just a side note, can consider "editPatient" as command word in case we want to have an "editTask" command in future. Up to you! 😃
3 (commented on others PR)
Good use of Optional here!
4 (commented on others PR)
Typo @code instead of @cod
5 (commented on others PR)
I like how you included this test!
6 (commented on others PR)
Your implementation of editpatient supports editing multiple fields in 1 command. Can consider adding an example of this. E.g. editpatient Alex Yeoh c/Add comment d/20200303-20200315
7 (commented on others PR)
In the example, should be editpatient not edit haha >>
8 (commented on others PR)
Perhaps you want to consider changing the message to "Search for patients who fulfill the given criteria in Covigent." since the output may be a list of patients.
9 (commented on others PR)
Personally, I think including an example for search via temperature range may be better since this may be more difficult for users to understand how to use.
10 (commented on others PR)
Actually you can remove the isPersonFound attribute totally. if (personName.equals(nameToSearch) can just return new CommandResult(String.format(MESSAGE_SEARCH_PERSON_SUCCESS, personFound)) directly. If the execution of code proceeds beyond this for loop, can just throw new CommandException outside. Just a suggestion to keep your code shorter 😃
11 (commented on others PR)
Good test coverage!
12 (commented on others PR)
Good to include an attribute string for message usage (similar to the other commands)
13 (commented on others PR)
Will be good to include a MESSAGE_SUCCESS attribute or something similar for the string " rooms are added in a hotel" (can refer to the other command classes to see what I mean).
E.g. in addPatientCommand your have the attribute String MESSAGE_SUCCESS = "New person added: %1$s";
So what you return is return new CommandResult(String.format(MESSAGE_SUCCESS, numPersonToAdd)) instead of the hardcoded string.
14 (commented on others PR)
Just to clarify, this exception is thrown if the user did not call the command addnumberofrooms right?
15 (commented on others PR)
This attribute was what I was referring to for MESSAGE_USAGE earlier. Perhaps you may need to shift this attribute to AddNumberOfRoomsCommand class instead to keep it consistent with the formatting of other command classes.
16 (commented on others PR)
Ok actually I am kind of confused of the flow and purpose of the addNumberOfRooms command. I thought for first time user we will get them to initialise the number of rooms and that will be fixed through out the usage of the app. So addNumberOfRooms in this case should be for initialisation? It doesn't make sense if halfway throughout the usage of the app I suddenly call addNumberOfRooms command again unless I built more rooms for my facility. 😕
17 (commented on others PR)
Actually why do you need to add code for room under AddPatientCommand?
18 (commented on others PR)
Just curious, why did you choose to use PriorityQueue instead of something simpler like ArrayList? 😛
19 (commented on others PR)
Good test coverage for Room!
20 (commented on others PR)
Remember to delete this!
21 (commented on others PR)
This will be handled by allocate person command no worries.
22 (commented on others PR)
Nice!
23 (commented on others PR)
If we have to convert to priority queue, do you guys think if it's better to use array list directly instead of priority queue for room list?
24 (commented on others PR)
Right, that's true!
25 (commented on others PR)
Should be after search patient command but it's okay for now. We will do a massive UG clean up in future as a group 😃
26 (commented on others PR)
Will be starting with an empty "room list" or something instead of AddressBook. Just to clean up traces of address book from the code haha.
27 (commented on others PR)
I agree with this too. There may be errors if we forget to update this variable when needed.
28 (commented on others PR)
Neat class that adheres to format of the existing codebase!
29 (commented on others PR)
I was just wondering why you need to have a date time created attribute for task 😛
30 (commented on others PR)
Neat I like this!
31 (commented on others PR)
Good test coverage.
32 (commented on others PR)
As in I meant the attribute "DateTimeCreated" haha, like why do you need to know when the task was created 😛 . The tracking of tasks due date is by attribute "DateTimeDue".
33 (commented on others PR)
Sounds good!
34 (commented on others PR)
Thanks for spotting this :X
35 (commented on others PR)
Good! We will need to add test codes for patient addition for editRoom command too.
36 (commented on others PR)
Very neat!
37 (commented on others PR)
Do you think it is better to write "Lists all the rooms in the application." instead? I got confused with the word 'available' thinking it meant like empty rooms without patients.
38 (commented on others PR)
Do you want to standardise the MESSAGE_SUCCESS with that of list patient command? Like "Listed all rooms."
39 (commented on others PR)
To add on, can even add a "Please initialise the number of rooms using initRooms command".
40 (commented on others PR)
Allocates*, edits* and existing*. Can change only when we do our massive UG clean up also.
41 (commented on others PR)
Removes*. Comprehensive examples given here!
42 (commented on others PR)
Do you think we should put this function under EditRoomCommand class or should it be the responsibility of RoomList class?
43 (commented on others PR)
Nice check! Thank you for adding this 😃
44 (commented on others PR)
I am not sure if it is a good idea to make this function static and expose it to the outer world, considering how you also need to call the getRoomList() function from the model to get the ObservableList>Room> as your parameter for this method so the roomList will be from your existing RoomList class anyway 😕. Just a thought to consider!
45 (commented on others PR)
Very comprehensive test cases in this class. Well done!
46 (commented on others PR)
Just curious why we need this toString() method. Is it for testing haha? But can keep it anyway.
47 (commented on others PR)
Hmm I was thinking of having the function "isPatientAssignedARoom" in the Model interface instead. Since the Model contains roomList and the patientRecords, Model knowing whether isPatientAssignedARoom kind of makes sense (essentially it will call on another isPatientAssignedARoom method in the roomList class to get the result).
I think the key here is that the command should only know of Model and should not be accessing roomList directly. (like the Law of Demeter that we learn for this week) That's what I intend to improve for my deletePatientCommand because I also accessed the patient list directly from model, but I think it's not very well designed since there's a deletePatient command directly from model (original code from address book).
48 (commented on others PR)
Yep no worries!
49 (commented on others PR)
Typo: "tasks with"
50 (commented on others PR)
Can consider "Searches all tasks before the given date."
51 (commented on others PR)
Searches task(s)* -> I think the output may be more than 1 task right?
52 (commented on others PR)
MESSAGE_SEARCH_TASK_SUCCESS
53 (commented on others PR)
I think you will have to display the output in the "Tasks" tab instead. So you shouldn't be returning the result in the bot's response.
54 (commented on others PR)
Good!
55 (commented on others PR)
Can consider adding some success test cases and check if the output tasks are as intended.
56 (commented on others PR)
Is it better to use the prefix_room_number from RoomCliSyntax instead since room number is an attribute of room?
57 (commented on others PR)
Seems like success cases are covered in equals() method test.
58 (commented on others PR)
Comparing patient to null is not very elegant, maybe check if roomObservableList.get(i).isOccupied() instead? (presumably isOccupied = true means patient != null)
59 (commented on others PR)
Thanks for removing the duplicated messages!
60 (commented on others PR)
Actually now I'm wondering if you do your assertion early on in the constructor, then the app will directly crash and will never reach here :X
61 (commented on others PR)
Same issue, if you assert in constructor, will this Message Invalid room number be received by user?
62 (commented on others PR)
If the task to delete is null, the app will just crash?
63 (commented on others PR)
Will this crash the app?
64 (commented on own PR)
Sounds good. I've changed the names to AddPatient instead of AddPerson for better clarity. However, if we are going to implement Staff, maybe can extend from Human instead of Person because there will be too many changes required to replace Person to Patient.
65 (commented on own PR)
There's a possibility that comment may be a null object (since it's an optional field) and .trim() method exists for String class so it wouldn't work if comment is a null object 😛
66 (commented on own PR)
That's a very good suggestion, will use this function in future! 👍
67 (commented on own PR)
I followed their existing format. 😛 Since checkstyle doesn't give error, I assume it's fine?
68 (commented on own PR)
Yes!
69 (commented on own PR)
Yep I will change to add patient instead!
70 (commented on own PR)
Thanks for pointing out!
71 (commented on own PR)
I think the temp should write but the age probably no need haha.
72 (commented on own PR)
Yes, good suggestion. We definitely should adhere to this in the next UG update!
73 (commented on own PR)
Yep, should take note of the standardisation in UG.
74 (commented on own PR)
I agree with Ming De I think we should stick to making sure patient does not have the same name. If we delete by index, in the case of 1000 entries, the user may have to scroll too much to find the patient (using searchpatient command doesn't show the index also 😕).
If we just ensure patient cannot have the same name, then all we need to change is the isSamePatient(...) function (to guard against duplicate patient being entered). If we need to check for the age and phone number identifiers, then we may need massive changes for deletepatient and editpatient command 😕.
Well, we can justify that the odds of patients having the same name is really very slim haha (https://www.quora.com/What-is-the-probability-of-two-people-having-the-same-name-and-also-living-in-the-same-city)
75 (commented on own PR)
Yep yep the search room command is incomplete as I've mentioned haha. The main thing in this PR is just refactoring.
76 (commented on own PR)
I think we will have to shift checkIfRoomPresent() to Model class also. But I will fix that in my next PR for SearchRoomCommand. The key for this PR is just refactoring.
77 (commented on own PR)
I will change all the empty line thing. Thanks for pointing out!
78 (commented on own PR)
Sure, I will change to "All patients are listed."
79 (commented on own PR)
I realised search room for now is just search by room number. So it only returns 1 room haha.
80 (other comment)
I realised I should be making the pull request from my fork instead of editing directly in this repo for UG.
81 (other comment)
Incorporated with editRoom command.
82 (other comment)
Not sure why Java CI failed even though it passed on my end.
83 (other comment)
Can be closed.
84 (other comment)
Duplicated issue.
85 (other comment)
Bro that was spot on. Error was in the handleMouseClick
@samlsm (61 comments)1 (commented on others PR)
would it be better to remove tutorial slots part cause we don't really have a tutorial?
| `* * *` | Tutor | Delete student entries | Update my list of students if a student were to drop the module |
2 (commented on others PR)
| `*` | Tutor teaching modules that require many written assignments | View my student's written submissions | Mark/review their homework |
3 (commented on others PR)
+ PREFIX_TAG + "CS2103 Tutorial "
+ PREFIX_TAG + "Experienced";
4 (commented on others PR)
**Edit Student** | `edit INDEX [n/NAME] [p/PHONE_NUMBER] [e/EMAIL] [t/TAG]…`<br> e.g.,`edit 2 n/James Lee e/jameslee@example.com`
5 (commented on others PR)
I think someone forgot to change this previously...
* `edit-student 1 t/@johndoe e/johndoe@example.com` Edits the telegram handle and email address of the 1st student to be `@johndoe` and `johndoe@example.com` respectively.
6 (commented on others PR)
Hmm... I think putting it at the top would be more convenient for users to just take a quick look... But the word 'summary' makes it feel like we concluding something so its weird for it to be at the top... Why not change the heading to like 'Command List' or something equivalent?
7 (commented on others PR)
I think keeping the previous would be better also... The previous formatting was based on the original user guide we got for the address book... so i think it is fine that the table and commands not consistent.
8 (commented on others PR)
I think clear is used to clear all students though... delete is meant to delete a specific student...
9 (commented on others PR)
#### Listing all students : `list`
10 (commented on others PR)
#### Clearing all students : `clear-student`
11 (commented on others PR)
#### Editing a student : `edit-student`
12 (commented on others PR)
#### Clearing all classes : `clear-class`
13 (commented on others PR)
Perhaps it might be good to follow the same format as DeleteStudentCommandTest to be consistent?
* Contains integration tests (interaction with the Model, UndoCommand and RedoCommand) and unit tests for
* {@code EditStudentCommand}.
14 (commented on others PR)
I like how you specify that clear removes all students!
15 (commented on others PR)
public void addStudent(Student student) {
students.add(student);
}
16 (commented on others PR)
Would this be a better name?
public void resetData_withDuplicateModuleClasses_throwsDuplicateModuleClassException() {
// Two moduleClasses with the same identity fields
ModuleClass editedCS2103T = new ModuleClassBuilder(CS2103T_TUTORIAL).withStudentIds().build();
List<Student> defaultStudents = TypicalStudent.getTypicalStudents();
List<ModuleClass> newModuleClasses = Arrays.asList(CS2103T_TUTORIAL, editedCS2103T);
TutorsPetStub newData = new TutorsPetStub(defaultStudents, newModuleClasses);
assertThrows(DuplicateModuleClassException.class, () -> tutorsPet.resetData(newData));
}
17 (commented on others PR)
Would this be a better name?
//// Student related tests
18 (commented on others PR)
'''suggestion
/**
Wraps all data at the application level.
Duplicates are not allowed (by .isSameStudent and .isSameModuleClass comparison).
*/
19 (commented on others PR)
Perhaps a line break here will make it look less cramp?
Index outOfBoundIndex = INDEX_SECOND_ITEM;
// ensures that outOfBoundIndex is still in bounds of Tutor's Pet list
assertTrue(outOfBoundIndex.getZeroBased() < model.getTutorsPet().getModuleClassList().size());
20 (commented on others PR)
should this be
// identity fields
21 (commented on others PR)
same for the data fields comment
22 (commented on others PR)
Perhaps this comments and the few below should start with lower caps?
// one keyword
23 (commented on others PR)
would it be better to leave a line here?
// manually link first class to first student
ModuleClass moduleClass = model.getFilteredModuleClassList().get(0);
Student student = model.getFilteredStudentList().get(0);
Set<UUID> studentUuids = new HashSet<>(moduleClass.getStudentUuids());
studentUuids.add(student.getUuid());
ModuleClass modifiedModuleClass = new ModuleClass(moduleClass.getName(), studentUuids);
24 (commented on others PR)
perhaps this comment should start with lowercase?
private TypicalModuleClass() {} // prevents instantiation
25 (commented on others PR)
perhaps this should start with lowercase?
// manually added
26 (commented on others PR)
Perhpas this is missing a full-stop?
// Manually added - Student's details found in {@code CommandTestUtil}.
27 (commented on others PR)
perhaps this should start with a lowercase?
public static final String KEYWORD_MATCHING_MEIER = "Meier"; // a keyword that matches MEIER
28 (commented on others PR)
Perhaps this would be a better naming?
''' suggestion
public void execute_indexSpecifiedListIsNotFiltered_showsStudentsInClass() {
29 (commented on others PR)
public void execute_invalidIndexSpecifiedClassListIsNotFiltered_throwsCommandException() {
30 (commented on others PR)
Would it be good to specify which list?
/**
* Removes all {@code studentUuids} from each and every {@code ModuleClass} in the class list.
*/
31 (commented on others PR)
Perhaps student manager would be a better name?
/**
* Removes all {@code Student}s from the student manager.
* Also removes all {@code UUID}s from each {@code ModuleClass}.
*/
32 (commented on others PR)
I am not sure about this... But should the full-stop be after the example?
/**
* Ensures that Tutor's Pet will not be able to boot up given an incomplete {@code UUID}
* (e.g "0c527a3f-8a6f-4c16-b57d-").
*/
33 (commented on others PR)
Perhaps it will be a good idea to keep the formatting consistent with the subsequent tests?
'''suggestion
/**
* Ensures that Tutor's Pet will not be able to boot up if two or more {@code Student}s are found with the same {@code UUID}.
*/
34 (commented on others PR)
"something is wrong" feels a little generic.. Perhaphs it is good to specify?
// Check that the set of student UUIDs within a class is a subset of that of
// all student UUIDs in uniqueStudentUuids. Otherwise, Tutor's Pet would not
// boot up due to data corruption.
35 (commented on others PR)
would canUndo_noPrevState_returnFalse() be a better name for this test so as to keep it consistent with the other namings?
36 (commented on others PR)
would undo_noPrevState_throwsUndoStateException() be a better name for this test so as to keep it consistent with the other namings?
37 (commented on others PR)
should this use case resume at step 1 instead? since user will need to request to edit a specific lesson again..
38 (commented on others PR)
should this use case resumes at step 1?
39 (commented on others PR)
should this use case resumes at step 1?
40 (commented on others PR)
should this be attendance record?
41 (commented on others PR)
Perhaps to keep it consistent with other constraints message we can use
public static final String MESSAGE_CONSTRAINTS = "Days should only contain capital letters.\n"
42 (commented on others PR)
Perhaps it is a good idea to keep the javadoc comment consistent with JsonAdaptedModuleClass..
'''suggestion
/**
* Converts a given {@code Lesson} into a {@code JsonAdaptedLesson} for Jackson use.
*/
43 (commented on others PR)
Perhaps it is a good idea to keep javadocs consistent?
'''suggestion
/**
* Every field must be present and not null.
* Creates a new lesson with the specified parameters.
*/
44 (commented on others PR)
Perhaps it would be good to use another class index here instead of both 1s so that it is clear the last index is accepted?
45 (commented on others PR)
Is it possible to static import this?
46 (commented on others PR)
as well as the few below...
47 (commented on others PR)
70 feels like a magic number... Do u mind changing it to the constant VALID_PARTICPATION_SCORE_80?
48 (commented on others PR)
same for the ones below... and the 1000 could be change to INVALID_PARTICIPATION_SCORE_101...
49 (commented on others PR)
Not sure if this would sound better...
A `TutorsPetState` object contains a Tutor's Pet state, along with a message that describes the changes relevant to this state.
50 (commented on others PR)
Is there extra spacing here?
51 (commented on others PR)
Not sure if this would be better...
It contains the `Attendance`s of all `Student`s who have attended the particular lesson.
52 (commented on others PR)
not sure if this sounds better...
* After finding the class CS2103T and student Alex, you wish to view all your students and classes.
Hence, you type in the command `list` and and press <kbd>Enter</kbd>.
53 (commented on others PR)
just a suggestion...
* Now you can see all your students and classes.
54 (commented on others PR)
Should we put these few points under a Constraints: section?
55 (commented on others PR)
Would this sound better?
* Alex is a student in your CS2103T class. After your lesson in week 1, you wish to give him a participation score of 45.
56 (commented on others PR)
should we specify that the score is for participation?
* Now you have successfully edited Alex's participation score from 35 to 45 points.
57 (commented on others PR)
Not sure if this would sound better...
* If the {@code studentToRemove} does not exist in the {@code attendanceRecord}, the {@code attendanceRecord}
* remains unchanged.
58 (commented on others PR)
Not sure if this is correct but I referred to ur previous javadoc for inspiration...
/**
* Returns a {@code Lesson} where the {@code Attendance}s of the {@code studentToRemove} have been removed.
*/
``
59 (commented on others PR)
/**
* Returns a {@code Lesson} where all {@code Student}s have been removed.
*/
60 (commented on others PR)
Not sure if invalidStudentToRemove or targetStudentToRemove would sound better...
61 (commented on others PR)
Perhaps this would be better?
'''suggestion
/**
* Creates a {@code Lesson} with the given {@code lesson} and {@code displayedIndex}.
*/
62 (commented on own PR)
I guess the refactor cant detect that... THANKS!
63 (commented on own PR)
HAHA cause dexter added that in his i think
64 (commented on own PR)
That test was missing so i just added it and made it consistent with what was in EditStudentCommandTest
65 (commented on own PR)
Issue #156.
I am going to do another PR to change the rest but since I was in that document I thought maybe could change that first...
66 (commented on own PR)
not sure if thursday 2pm - 4pm: weeks 1 2 3 4 5 would look better?
67 (other comment)
Manually copy from the result display box
@BobbyZhouZijian (61 comments)1 (commented on others PR)
UPPER_CASE shoudnt be in markdown
2 (commented on others PR)
There is no line breaking here.
3 (commented on others PR)
LGTM
4 (commented on others PR)
quick start should start with ##
5 (commented on others PR)
The contents should be hyperlink
6 (commented on others PR)
I will add the hyperlinks
7 (commented on others PR)
the list should have the ``
8 (commented on others PR)
I think there should not be indentation here
9 (commented on others PR)
Should it be "the list of all tasks"?
10 (commented on others PR)
should it be "list all tasks"?
11 (commented on others PR)
Same as above
12 (commented on others PR)
are we going to skip displaying or just display an empty list? If we are just displaying an empty list, is it still considered an extension?
13 (commented on others PR)
list all tasks
14 (commented on others PR)
the list of all tasks
15 (commented on others PR)
same as above. i'll ignore it for the following parts
16 (commented on others PR)
Is 'exit' inside the use cases? should we add it?
17 (commented on others PR)
This is still not changed
18 (commented on others PR)
The class here is still not changed to Task
19 (commented on others PR)
Why extra indent here?
20 (commented on others PR)
Why extra indent?
21 (commented on others PR)
same here
22 (commented on others PR)
^
23 (commented on others PR)
nice!
24 (commented on others PR)
Should we use trimmedTitle instead of trimmedName?
25 (commented on others PR)
Do you wanna change "address book" to "PlaNus" now or do it later?
26 (commented on others PR)
Does the name "fullTitle" make sense?
27 (commented on others PR)
Why extra indent?
28 (commented on others PR)
just to check, the corresponding UI class variable is also changed right?
29 (commented on others PR)
What's the rationale of changing it to Amy?
30 (commented on others PR)
agree. and better put date as yyyy-mm-dd
31 (commented on others PR)
the attribute in the userguide says date: tho
32 (commented on others PR)
Should have clearer documentation here
33 (commented on others PR)
^
34 (commented on others PR)
Clearer documentation pls.
35 (commented on others PR)
Why is this private variable in between to public variables?
36 (commented on others PR)
I think a better documentation is : construct an empty Description when user didn't provide the description field. Caveat: Only called when the user didn't key in this field.
37 (commented on others PR)
Same. private variable in between public variables.
38 (commented on others PR)
Same. I think the documentation can be better.
39 (commented on others PR)
I would recommend making this documentation clearer as well. Add another line to specify that this is only used to construct an empty Phone when the field is not in the task.
40 (commented on others PR)
^
41 (commented on others PR)
Nice that you changed the UML as well.
42 (commented on others PR)
oops, I think this should have been "description". My bad I forgot to change this. Can you change it?
43 (commented on others PR)
Should we really allow type to be any string? Or just one word letters connected by '-'
44 (commented on others PR)
Is there a reason to keep a counter? Don't we just need to traverse through all the types?
45 (commented on others PR)
iirc there's a "requireNonNull" method there? Can we use it?
46 (commented on others PR)
hmmm maybe you can consider using the join method?
47 (commented on others PR)
Maybe you can consider using the "join" method?
48 (commented on others PR)
I think we are changing all these to PlaNus
49 (commented on others PR)
We can. But I don't think its a big issue as long as there is no bug. Stringbuilder looks cleaner tho I would say.
50 (commented on others PR)
Maybe add another extension when the task index supplied is invalid?
51 (commented on others PR)
I think there's an extra '/'
52 (commented on others PR)
Are you throwing any CommandException here?
53 (commented on others PR)
What are the B, C and D for?
54 (commented on others PR)
Will there be any case where a valid user input will make any of these null?
55 (commented on others PR)
Missing period at the end.
56 (commented on others PR)
I think you can use the formatter from the DateTime class if possible
57 (commented on others PR)
No need day of week?
58 (commented on others PR)
should be lesson right
59 (commented on others PR)
Should remove this
60 (commented on others PR)
Actually, I think we can make the Time, Date and DateTime class inherit or implement a common interface. Maybe I'll refactor this later.
61 (commented on others PR)
Why use plural?
62 (commented on own PR)
Should I just delete it or mark it as coming soon?
63 (commented on own PR)
got it
64 (commented on own PR)
nice catch
65 (commented on own PR)
resolved
66 (commented on own PR)
sry this was a mistake. I changed it. the datetime won't be null
67 (other comment)
Just mark it as done when you finish your part
68 (other comment)
What are left to be done for the use cases? Maybe can add inside description?
69 (other comment)
Completed
70 (other comment)
Can you push the branch to the team's repo so that we can pull and test locally?
Also codecov seems to have dropped. Maybe can add some relevant test cases to bring it back?
71 (other comment)
This has been completed in #73
72 (other comment)
The error message doesn't quite match the actual error.
73 (other comment)
I think also need to update the DG
@chan-j-d (58 comments)1 (commented on others PR)
Could you change this instance of 'AddressBook' to 'Athena'?
2 (commented on others PR)
Change this instance of 'AddressBook' to 'Athena' as well
3 (commented on others PR)
Adds >i>an>/i> event instead of >i>a>/i> event
4 (commented on others PR)
Consider adding Javadocs to this method and the newly implemented methods below
5 (commented on others PR)
What exactly is this change?
6 (commented on others PR)
Please commit only relevant changes to the branch in the future. This is probably more relevant when adding the editEvent command
7 (commented on others PR)
Add class-level javadocs for this class
8 (commented on others PR)
Update this javadocs for the context of AddEventCommand
9 (commented on others PR)
Use the >code>// some comment>/code> for this instead of >code>/* some comment */>/code> as that is relevant only to the method/attribute right below it which in this case is >code>PREFIX_DESCRIPTION>/code>
10 (commented on others PR)
Please include class level Javadocs for this
11 (commented on others PR)
Consider placing this into the constructor?
12 (commented on others PR)
Update javadocs to specify calendar
13 (commented on others PR)
Update Javadocs to specify it is about events not persons
14 (commented on others PR)
Add class level javadocs to tell us about the class
15 (commented on others PR)
Add class-level javadocs to tell us about the class
16 (commented on others PR)
Add class-level javadocs to tell us about the class
17 (commented on others PR)
What is the difference between these two methods? Should the >code>setEvent>/code> method check 'equality' between two events and replace the one in the list with the one outside?
18 (commented on others PR)
I believe this replies to the wrong part of the review? Please use this only to reply to the specific comment above
19 (commented on others PR)
Consider adding this method and the test methods below to a separate class called >code>AddEventCommandTest.java>/code> to separate tests for Bangyi's >code>AddCommand>/code> and tests for your >code>AddEventCommand>/code>.
20 (commented on others PR)
Consider adding these messages as constants instead of magic literals
21 (commented on others PR)
Is the prefix necessary at all?
22 (commented on others PR)
Should be able to obtain the index directly similar to the Delete command for example
23 (commented on others PR)
This seems to be outdated compared to what is actually implemented
24 (commented on others PR)
Would be nice to have a brief Javadocs description of the class
25 (commented on others PR)
This Javadocs is outdated
26 (commented on others PR)
Should probably remove this as it is not used at all
27 (commented on others PR)
Should remove this from the interface and the implementing classes
28 (commented on others PR)
Should probably remove this as it is only used by the unused sortPersons method in AddressBook
29 (commented on others PR)
Should probably remove this as it is not used at all
30 (commented on others PR)
This method should probably take in a Comparator instead in line with how the updateFilteredPersonList method works. Model Manager shouldn't need to know exactly which Comparators it needs
31 (commented on others PR)
The three comparators should probably declared as static constants within the SortCommand class itself?
32 (commented on others PR)
This should probably be done in the SortCommand class itself. execute chooses the appropriate Comparator in the execute command to pass to ModelManager.
33 (commented on others PR)
Does each class really need to know the COMMAND_TYPE string? It seems like it would be better to just have the AddressBookParser store the main COMMAND_TYPE string variants. Either that, or these classes should be taking the AddressBookParser's COMMAND_TYPE definition. Because right now, to change the COMMAND_TYPE string, every single file has to be edited
34 (commented on others PR)
And it seems that the COMMAND_TYPE String is largely not used except to reconstruct the equivalent user input
35 (commented on others PR)
I would suggest something like -c and -e instead of /c and /e as I believe we should differentiate field specifiers from object-type specifier. Especially since add /c n/some name looks kind of strange
36 (commented on others PR)
My suggestion was actually to not have this at all. But the enum-type would probably be the second best alternative as both AddressBookParser and the relevant commands will depend on the String specified in the enum-type. Because as is right now, the current implementation is the equivalent of the cyclic dependency you mentioned, just not strictly coded in. If you change AddressBookParser's string to detect Contact-type commands, then you'll still have to change those within each Contact-type command class.
If you're removing references to the Command-type string inside the Command classes themselves, then the reconstruction of user input tests have to be moved to AddressBookParserTest instead. The individual Command-types will handle only their own share of input (everything that is after {command name} {contact/event}
37 (commented on others PR)
I think only one enumeration is sufficient (CommandType). Because 'add' is a unique identifier for the AddContactCommand, or at least it was. But I feel like the reason both AddressBookParser and the individual command classes should not hold the contact identifier's specific implementation within them is that it is a property that they all share and depend on. So a separate enumeration would fit this.
I change my mind regarding holding references within the command classes themselves to their CommandType. It does make recreating the command for testing easier.
i think there is merit in having the test cases remain in their current classes as they are intended to test certain classes.
I don't think this is really relevant to the discussion because the individual command classes don't actually use their own command word and command type for testing. Only AddressBookParserTest uses them to recreate it.
38 (commented on others PR)
specifically, i believe it should be
public static final String COMMAND_WORD = CommandWord.SORT.toString();
public static final String COMMAND_TYPE = CommandType.EVENT.toString();
39 (commented on others PR)
would it be possible to add the 3rd line into a separate branch to continue working on? as you have mentioned that it is not quite implemented yet. So we should merge only things that fully work to master
40 (commented on others PR)
Related to the above comment, to add this to a separate branch and subsequent PR so it is obvious to us what the changes are in the future PR.
41 (commented on others PR)
although i think it would be better to have the detection of invalid inputs handled in SortEventCommandParser.parse.
the SortEventCommandParser.parse is already implemented. But I do agree with the suggestion regarding the default branch. I think it is in-line with defensive programming to reserve the default block to throw an exception instead in order to protect others who might be using the code.
42 (commented on others PR)
This comparator does not seem to match the description specified in the indexMessage(Index) and MESSAGE_USAGE. This seems to compare the number of tags instead of the number of participants.
43 (commented on others PR)
This doesn't seem to have any indication of the actual number of participants though? It seems to mostly just compare the tagName string-wise. To get the actual number of participants from each tag, I believe you need to use the model.getPersonsWithTag(Tag) method to get the actual Set>Person>
44 (commented on others PR)
but tags are not the same thing as participants?
Also the comparison itself seems kind of strange. If o1 has 5 tags and o2 has 10 tags, this falls under the last branch which compares only the first name of the first tag found in the set. Also, I believe this is prone to changing as Sets do not have a well-defined order.
45 (commented on others PR)
I was under the impression Events would hold a Set>Person> (added without any specific tagging) as well as a Set>Tag> (of groups of participants identified by the tags). The total number of participants would then be a conjunction of all the participants found from the Set>Person> and each Set>Person> belonging to each Tag.
46 (commented on others PR)
I believe this is a typo
47 (commented on others PR)
It seems to me that this comparator has some issues. In particular, the tags are actually stored in Java's Set which has no guarantee of order preservation. So this could result in different comparator results on different calls of the compare method.
48 (commented on others PR)
I believe this might be related to the same Comparator in SortContactCommand
49 (commented on others PR)
Additionally, consider creating a PersonsComparator class which stores all these comparators as public static constants so that both sort commands can refer to the same Comparator object.
50 (commented on others PR)
consider using case 1: return NAME_COMPATOR;... and throw a CommandException for the default branch. This can potentially safeguard the code from misuse by other developers.
51 (commented on others PR)
Will this fail if a sort is performed on an empty Athena? Perhaps, it should instead just not do anything if the list size is 0.
52 (commented on others PR)
I believe the name of the method would be more appropriate as something like permSortContacts or permSortPersons as we will eventually need to remove instances of 'addressbook' within the code. Additionally, I believe the argument name would be more appropriate as something like comparator as chooseComparator sounds more like a method name.
53 (commented on others PR)
Would be nice to include test cases that check against the permanently saved file to see if using the command changes it.
54 (commented on others PR)
Is there a guarantee that the first tag being displayed in the GUI is the same as the first tag found in the set.iterator()?
On a related note, I wonder if this comparator is necessary because it seems quite arbitrary. I was going to suggest perhaps some sort of way to request sorting in the reverse order, so the name comparison would put Z at the front etc. In this case, I think a comparator that allows sorting by number of tags might fit this better. Though I am unsure how this might be useful as well.
55 (commented on others PR)
Do reflect these changes within the origin SortContactCommand as well. Thanks!
56 (commented on others PR)
There is an additional '9' here. Also consider leaving a line between the class declaration and the first javadocs
57 (commented on others PR)
Consider changing the description to be something more explicit like: "Permanently sorts and edits the underlying save person-list save file" to clearly say that this changes the save file.
Also consider changing the argument name to just comparator instead of chooseComparator
58 (commented on others PR)
This internalList assertion seems slightly problematic. Given an invalid json save, the json save would be wiped out and replaced with an empty json save. This will create an internalList with size 0 which seems common enough to not warrant an assert. Perhaps a simple assert c != null would suffice.
59 (commented on own PR)
As it turns out, private comment Javadocs are not really standardised throughout the code. I think this is not a big issue
60 (commented on own PR)
it is a runtime exception. I do not believe it is necessary. Especially since there should be no reason why this exception occurs at all if Person changes are done through AddressBook.
61 (commented on own PR)
Is there a difference in wrapping in an Optional? It would still be
Optional.ofNullable(tagPersonSetMap.get(tag)).orElse(Set.of()) which I don't think is much better
62 (commented on own PR)
Ok, as it turns out it's only one instance from the original. The description of the getFilteredList() from the Model interface. I'll change it
63 (commented on own PR)
This was supposed to be 'contains only tag-person mappings from the persons list.' The original message was not written very well. Thanks!
64 (commented on own PR)
yes, thank you very much.
65 (commented on own PR)
or would be appropriate, thanks for pointing this out
66 (commented on own PR)
I think the individual behaviors have to be explicit. In this case, the upcoming editTagCommand will specify tags to add and tags to remove as two separate tag sets. As such, I wanted to be clear here on the behavior of the method for each case.
67 (commented on own PR)
The documentation of these methods' purpose is in the TagTree abstract class. I wanted to leave open the implementing class in the event someone could come up with a better underlying system for it. Admittedly though, many classes do depend on associate with TagTree and as such, depend on TagTreeImpl anyway.
68 (commented on own PR)
i am genuinely unsure about this. Perhaps you could decide and tell us? I do believe the original JsonAddressBook class uses json instead of JSON.
69 (other comment)
Issue has been fixed! Thanks for the notification. I ticked the 'Require status checks to pass before merging' option without realizing that I had to specify which CIs I wanted passed before being able to merge. This has been addressed and our CI is now passing.
70 (other comment)
Is the sort method supposed to sort the current shown list? Or is it supposed to sort the full list of contacts before showing it? Because the former would be much easier to implement and I believe is what we intended to do originally? There is the model.getFilteredPersonList() method which gives the last shown list.
Also, I agree with the Hendey's comment about the sortPerson method. I do not think that all the model classes need to have such a method.
71 (other comment)
Please settle the merge conflicts by including both methods for the two different conflicts. Then it'll be good to merge. Thanks!
72 (other comment)
Looks good to me. I'm just wondering how the TagManager class helps to keep track of the participants (persons) of a particular event without implementing necessary changes in Calendar class or respective events class?
This was done mostly with the context of supporting Bangyi's delete by tag and add to events by tag. Shouldn't the Event's class have references to the Tags it contains similar to the Persons it contains? Anyway I believe someone else is implementing this. This was just to help support that.
73 (other comment)
I don't really agree with this. I believe that we should limit the options the user has in this case. Otherwise, suppose a user creates a tag Cs2103 and starts assigning things to it. This tag will be permanently stuck at Cs2103 and unless we give them a new command to change the specification of the tag name to either CS2103 or cs2103.
Not to say that forcing upper-case is definitely a better solution than what you suggested, but I do feel that enforcing capitalization is a more agreeable policy as opposed to someone not realizing that they can't change the capitalization of their tags after adding hundreds of contacts under the tag.
74 (other comment)
Upon further deliberation, I realize that an edit tag name-type command is inevitable. As such, this should cover whatever I was concerned with initially. Thanks for the suggestion!
75 (other comment)
On further further deliberation, I realize there is still a necessity to standardize the capitalization of tags. When two separate Persons are added with tags cs2103 and CS2103, should a lookup of the tag produce both? Otherwise, if yes then why not standardise how the tags themselves look. If no, then I personally feel that it kind of beats the point of implementing search by tags to begin with.
@joeychensmart (54 comments)1 (commented on others PR)
Looks like theres a formatting issue here
2 (commented on others PR)
I think we should turn the 4 into a constant, i.e. private static final CALORIC_MULTIPLIER = 4. Same for the rest of the macronutrient classes
3 (commented on others PR)
Similar to the toString function, I think we can factor this out to the superclass. If we do that then we can also change all its protected access modifiers to the ideologically superior private.
4 (commented on others PR)
Looks like you're using the assertion incorrectly, it should be
assert amount >= 0 : "amount cannot be negative"; instead.
Currently it will print the error message regardless of whether the assertion passed or failed.
Also a side note: we should use the java logger instead of System.out.println apparently.
5 (commented on others PR)
Maybe you could add a TODO comment on what kinds of methods to add to this class/how it should be used.
e.g. // TODO: Food FoodMethodHandler.combineFood(Food firstItem, Food secondItem) or something
6 (commented on others PR)
IIRC we need to write javadocs for each class according to the module specifications.
7 (commented on others PR)
IMO we should keep this as the string "Carbohydrate" instead. Makes the code more explicit.
Same for the other macronutrients
8 (commented on others PR)
I think we should @override the object.equals method instead. Having 2 methods claiming to do the same thing will invite bugs.
9 (commented on others PR)
This method only makes sense if we have unique objects in the list, maybe you could change the target to the Index of the object in the list, or require all objects in the fridge to be unique.
10 (commented on others PR)
Same as the setFood method
11 (commented on others PR)
I think we should rename this to macronutrientType or something so we don't confuse this type with a java type.
12 (commented on others PR)
Assertion here could be more descriptive (e.g. "Macronutrient type cannot be blank"), since we are changing name to type.
13 (commented on others PR)
We should be checking for referential equality here i think? i.e. assertTrue(expectedFridge == fridge), not sure if object equality is intended.
14 (commented on others PR)
Same as below comment
15 (commented on others PR)
typo in caloriMultiplier.
Also I think you MacronutrientStub or something would be a better class name. The current one sounds like this is an object that creates other macronutrients.
16 (commented on others PR)
Should remove this or put a TODO comment if its blank
17 (commented on others PR)
I think this should be withFood or something
Also is using person here intended?
18 (commented on others PR)
I think a comment would be good here to say it takes the name from the class name
19 (commented on others PR)
Maybe we should change int index to Index index, i.e. the class from AB3.
20 (commented on others PR)
I think we should keep this as just assertThrows instead. We should stick to the static asserts for tests
21 (commented on others PR)
same for all the other test files that were changed
22 (commented on others PR)
hmm we may be able to abstract this part a bit more in the future, just a note, no need to change now
23 (commented on others PR)
this is not an email !
24 (commented on others PR)
I think we should be using getNutrientValue here instead?
25 (commented on others PR)
this method violates DRY, we should really remove this
this is important
26 (commented on others PR)
can't see clearly in the diff but I think we're missing a javadoc here
27 (commented on others PR)
We should extend Exception instead because they are checked
extending RuntimeException will lead to a lot of very painful uncaught errors
28 (commented on others PR)
Same as the other DuplicateFoodException, RuntimeException is very spooky
29 (commented on others PR)
I guess this is valid but should we leave this or change it to mcspicy or something
30 (commented on others PR)
same as invalidFoodMcGymmy, i think we should use actual food names here
31 (commented on others PR)
same as the .json files, we should change to food values
32 (commented on others PR)
Maybe change the names and tags here as well to food
33 (commented on others PR)
As above, I think we should change these names
34 (commented on others PR)
could abstract this into a method hasDuplicates in ReadOnlyMcGymmy or its superclass
35 (commented on others PR)
this should be if (food == comp) for referential equality (the is operator in python).
Comparing the hashcodes does not guarantee the food and comp are the same object in memory.
36 (commented on others PR)
As with the other files, should change this to food.
37 (commented on others PR)
should change all these to resemble the typical values, except with an underscore, space etc.
i.e. each test should only have 1 reason to fail.
38 (commented on others PR)
Should use the module convention, i.e. protein_isValid_correct or something
Same for the methods in the other test classes
39 (commented on others PR)
Need to change these examples too
40 (commented on others PR)
We should change all these names/values to food ones.
41 (commented on others PR)
Should be Carbs.MESSAGE_CONSTRAINTS instead here, same for fats below
42 (commented on others PR)
i think toString might override the java object's default method, so that might cause problems (including confusion in developers)
maybe we could use the module convention toString_isCorrect or something instead
43 (commented on others PR)
maybe something more useful here could be to set a boolean flag hasBeenUndoed or something to true here, and checking it in the execute_canUndo_success part
44 (commented on others PR)
I think we can shave off the parsing part bc it would have been mentioned in the above sections.
Makes the diagram less packed
45 (commented on others PR)
there seems to be a typo in the file's name itself (it's FIndSequenceDiagram.png in the folder or sth)
46 (commented on others PR)
This part maybe can go higher level (remove specific details on which methods get run and just say what happens, e.g. "it combines the predicates then filters the list"?
47 (commented on others PR)
Also for the diagram itself may be able to shave off the parsing part (i.e. only show what happens after the .execute()) because it will be repeated in the previous section
48 (commented on others PR)
I think we can change this to a for loop where we delete using the filteredList's predicate, i.e.
var predicate = filteredFoodItems.getPredicate();
for (Food food : listOfFoodSomewhere) {
if (predicate.check(food)) {
removeItem(food);
}
}
This will work as intended, as long as getPredicate and setPredicate in fxcollections works as intended
49 (commented on others PR)
Can also create a public void filter(Predicate p) in Fridge.java then call it somehow in this method.
Then we can use java streams to filter and override the list (but don't forget to invert the boolean predicate).
50 (commented on others PR)
I think with the new implementation we can delete this method and the other related one in Fridge
51 (commented on others PR)
Remove this method then should be good to merge
52 (commented on others PR)
I think for this long chain we can replace it with a stream/list of all the above predicates + a stream.reduce call.
Will be much cleaner
53 (commented on others PR)
For these changes is it due to the "" OptionalParameter misbehaving?
Perhaps we could log that as an issue and address it in another PR. Don't think hardcoding these exceptions are a good idea.
54 (commented on others PR)
A suggestion I have is to collect all these Predicate classes into 1 file and turn each individual Predicate class into a function that returns an anonymous class, i.e.
public class Predicates {
public Predicate<Food> makeDatePredicate(String date) throws ParseException {
return new Predicate<Food>() {
// all the code below
}
}
// ... more predicates
}
Will reduce a lot of the java boilerplate in the codebase.
55 (commented on own PR)
Hmm looks like I may have accidentally removed this during the safe delete or something, will update and restore it.
56 (commented on own PR)
Yes that seems to be better. Good catch.
57 (commented on own PR)
I'll add a couple more tests for this, along with some unit/integration tests with the Commands.
58 (commented on own PR)
Nope, if you try to declare multiple of the same parameters there will be an assertion error somewhere.
Technically you can work around this, by declaring a new class that contains the two parameters, e.g.
the command:
takeTwoIntegers 1 2
may have a parameter
private Parameter<IntPair> param = this.addParameter(..., IntPair::parse)
and the IntPair class is as follows:
class IntPair {
public int a;
public int b;
public parse(String str) {
IntPair result = new IntPair();
result.a = ...
}
Don't think any of our commands will involve these kinds of parameters, but if they do we may have to either redesign the command or the parser. (We'll solve that problem when it happens)
59 (commented on own PR)
Yes, for the first one the 1 will be considered as input to the -n parameter, and the unnamed parameter will have no input (so there will be an error).
I'll add this and the comment below into the PR's docs.
60 (commented on own PR)
No point imo since I'm not reusing the string outside this function.
Also would add more noise which we're gonna change anyway (when we change people to food).
61 (commented on own PR)
yup you're probably right. I mustve copy pasted wrongly somewhere
62 (commented on own PR)
for tests we usually just throw Exception because if any exception happens JUnit will catch it and display the error message and error type.
Its more convenient to do this and also we don't need the extra type checking for the specific error thrown (DataConversionException).
63 (commented on own PR)
the list is final though, so then we will have to unfinalize it
also this is consistent/the same as the implementation in JsonSerializableMcGymmy.
64 (other comment)
good job
65 (other comment)
Added a skeleton to Duong's PR. Should be able to add on from there while avoiding merge conflicts.
(related note: can someone approve that PR? don't think I can do it because I also contributed a commit.)
We should use the same format as the one from AB3 (copied over below).
Use case: Delete food
MSS
User requests to list persons
AddressBook shows a list of persons
User requests to delete a specific person in the list
AddressBook deletes the person
Use case ends.
Extensions
2a. The list is empty.
Use case ends.
3a. The given index is invalid.
3a1. AddressBook shows an error message.
Use case resumes at step 2.
66 (other comment)
The CI test says that you are missing the shadow plugins
Seems like a github actions issue. This happens from time to time.
Closing and reopening the PR should restart the CI process (hopefully fixing this).
67 (other comment)
LGTM
68 (other comment)
I think I can do this easily using the new logic architecture
69 (other comment)
Preliminary findings:
This is actually a symptom of a much bigger problem: the code is violating SRP and Seperation of Concerns.
Right now the model classes (i.e. Fridge, UniqueFoodList) are throwing these RuntimeExceptions when the food being added is a duplicate etc.
The reason why this has not been a problem so far is because (for the case of the DuplicateFoodException) the 2 classes that add to the food list/fridge, the AddCommand and EditCommand have guard clauses that throw an error when a duplicate food item is being added.
if (!(foodToEdit.equals(editedFood)) && model.hasFood(editedFood)) {
throw new CommandException(MESSAGE_DUPLICATE_FOOD);
}
this one
Frankly this shouldn't be the job of the EditCommand or AddCommand and now we have to include extra tests to ensure these guard clauses work.
Using the current design, in the future if we add more Commands or other functionality that add food items to the model, we will have to keep in mind to catch these duplicates ourselves else oopsies! the program will explode because Fridge threw a RuntimeException.
It is my firm belief that since Java so benevolently offers to handle these problems for us (with checked exceptions), we forgetful humans should gracefully accept its help.
Note: I just remembered we're allowing duplicates now but the above argument still applies to the other FoodNotFoundException.
Recall the current guard clause used:
if (!(foodToEdit.equals(editedFood)) && model.hasFood(editedFood)) {
throw new CommandException(MESSAGE_DUPLICATE_FOOD);
}
If DuplicateFoodException is thrown as a checked exception, we can easily wrap it in a try-catch:
try {
// do the adding here or wtv nonsense
} catch (DuplicateFoodException e) {
throw new CommandException(MESSAGE_DUPLICATE_FOOD);
}
70 (other comment)
Copied over the justification from AB3
PersonNotFoundException is a checked exception. It is thrown by methods
such as `UniquePersonList#remove(Person)`,
`UniquePersonList#setPerson(Person, Person)` etc. to signify that
certain preconditions were not met -- namely that the person provided to
those methods does not exist in the address book/UniquePersonList.
Using checked exceptions for such a purpose is slightly useful in that
it will force callers to handle the case where the above preconditions
are not met, such as when the methods are called with invalid user
input.
However, it imposes a HUGE cost on callers where the preconditions are
already known to be met (e.g. in test code, or when the user input has
already been validated before hand). In such a case, callers are forced
to add try-catch blocks around the method call even if they know that
the exception will never be thrown, bloating up the code. It is also
impossible to test the catch blocks as well since correct code will
ensure that the precondition holds and thus the exception will never be
thrown, leading to reduced code coverage.
Checked exceptions also don't work very well with the Java Streams API,
since the API doesn't accept lambdas which could throw checked
exceptions.
In AB-4, the amount of code which benefits from PersonNotFoundException
being a checked exception is much smaller than the amount of code which
is negatively impacted.
As such, let's make the tradeoff in the other direction, by making
PersonNotFoundException a RuntimeException. New callers _could_ forget
to check that the preconditions hold before calling the methods in
question (although test cases should catch that), but this is balanced
out by the huge benefit of having more concise and testable code.
Only argument I agree with is the Java Streams one, but we can work around this.
We can discuss this in the next team meeting.
71 (other comment)
Will make this a not draft after I add some tests or something maybe
The code is mostly formatting text to be printed so I dont think unit tests will benefit it much
72 (other comment)
Once we merge this we need to add a new issue since the executeCommand("help") is hardcoded for the button
73 (other comment)
e.g. find -date 2020-11-11 -tag lunch
e.g. find rice -date 2020-11-11 -tag lunch
74 (other comment)
FRONT MATTERS (Team 20%)
Clear and concise statement of the purpose of the document, and the target audience
Clear and concise user-centric statement of product information, e.g. product description and overview of main features
Clear and complete information about how to use the document, e.g. how to navigate the document, meaning of icons/formatting used.
Clear and complete information about how to get started, e.g. installation instructions, parts of the GUI, tutorial on how to use CLI, etc.
Shows reader consideration by going the extra mile to provide other necessary information, or to make this section welcoming and appealing to the reader.
INSTRUCTIONS for each implementation (Individual 50%)
clear and user-centric description of purpose of feature/function/command
Clear and easy-to-follow step-by-step instructions for at least one example
Clear, relevant, and helpful graphics. Visual and/or textual cues are used to indicate which graphic(s) go with which set of instructions.
Heading, instructions and examples are customized to the application
Highly considerate of user’ needs by providing other relevant and helpful information e.g. warnings, tips, important note.
Highly considerate of users’ needs by using formatting (font style, size and color, mark-ups, callouts, bold, italics, etc) and layout (white space, alignment, etc.) to maximize readability.
Well-chosen, accurate and reader-focused language.
PRESENTATION (Team 10%)
Consistent terminology throughout the document.
Consistent formatting (symbols/icons, font type and size, colors, image size, use of mark-ups and callouts, bullets, etc.) and layout (alignment of text and graphics, white space, paragraphing, etc.) throughout the document.
Easy to navigate (e.g. provides hyperlinks where necessary or expected, Table of Contents is accurate, etc.)
LANGUAGE, STYLE AND TONE (Team 10%)
Consistent phrasing of headings and sub-headings throughout the document
All headings and sub-headings clearly and accurately indicate content of each section
Consistent user-centric style and tone throughout the document, e.g. you-language, active tense, short sentences, etc.
Correct grammar, punctuation, spelling, mechanics throughout the document
OVERALL (Team 10%)
Document is highly attractive, pleasant to read, and easy to understand.
The document leaves the reader with a highly positive impression of the product and the team.
75 (other comment)
edit here https://github.com/Jh123x/tp/blob/User-Guide-v2.0/docs/UserGuide.md
76 (other comment)
TODO: will move MacroList into the model in the next PR.
77 (other comment)
Do we want an option to find before/after a certain date? i.e. show all foods created before/after a certain date?
Or we can put this in another PR/not do this at all.
78 (other comment)
likely this is the cause #112
Also we should make it such that each command is undoable and document this in the UG. Easiest solution
79 (other comment)
note 1: problem because filtered list for both actual/expected model has size of 1.
80 (other comment)
update: list actually not getting filtered properly
@erisjacey (53 comments)1 (commented on others PR)
Shouldn't the text name for this be matriculationNumber?
2 (commented on others PR)
Maybe INVALID_MATRIC_NO could be changed to INVALID_MATRIC_NUM instead?
3 (commented on others PR)
Shouldn't there be a method call withMatriculationNumber(...) as well?
4 (commented on others PR)
Perhaps MATRIC_NO_* could be changed to MATRIC_NUM_*?
5 (commented on others PR)
Should there be an awkward line break right after MATRIC_NO_BOB? Same issue with the other test cases.
6 (commented on others PR)
Shouldn't there be a method call withMatriculationNumber(...)?
7 (commented on others PR)
Shouldn't the message be ATAS has deleted all students! or something like that?
8 (commented on others PR)
Perhaps these could be renamed to ACCEPT_COMMAND_FULL, ACCEPT_COMMAND_SHORT, REJECT_COMMAND_FULL and REJECT_COMMAND_SHORT?
9 (commented on others PR)
Perhaps comments could be added to explain what you're testing for each statement (+ expected result)?
10 (commented on others PR)
I noticed a similar issue previously. Maybe more comments explaining each test case could be added?
11 (commented on others PR)
Do you think it would make more sense to include the use of the abstracted wrapper class Index here?
12 (commented on others PR)
Would this make more sense to put in an if-else block (with comments to describe the else block)?
13 (commented on others PR)
Should this unncessary extra line break be removed?
14 (commented on others PR)
Maybe these could be renamed to PREFIX_SESSION_NAME and PREFIX_SESSION_DATE?
15 (commented on others PR)
Shouldn't the form be dd/MM/yyyy?
16 (commented on others PR)
Maybe some comments could be added here to more clearly explain the thought process?
17 (commented on others PR)
Unnecessary additional line break?
18 (commented on others PR)
Maybe these two if blocks could be merged into one?
19 (commented on others PR)
Maybe these two if blocks could be merged into one?
20 (commented on others PR)
Would it make more sense if all instances of SESSIONNAME got changed to SESSION_NAME? (same for SESSIONDATE and SESSION_DATE?
21 (commented on others PR)
Unnecssary whitespaces?
22 (commented on others PR)
Unnecssary whitespaces?
23 (commented on others PR)
Unnecessary whitespaces?
24 (commented on others PR)
Unnecessary whitespaces?
25 (commented on others PR)
Unnecessary whitespaces?
26 (commented on others PR)
Unnecessary extra line break?
27 (commented on others PR)
Unnecessary line break?
28 (commented on others PR)
Unnecessary line break?
29 (commented on others PR)
Unnecessary line break?
30 (commented on others PR)
Unnecessary whitespaces?
31 (commented on others PR)
Unnecessary whitespaces?
32 (commented on others PR)
Shouldn't this be renamed to Editing a student to fit the rest of the item naming?
33 (commented on others PR)
Maybe this class could be made public?
34 (commented on others PR)
Shouldn't the command participate be in all small letters?
35 (commented on others PR)
Shouldn't this be enterses?
36 (commented on others PR)
Shouldn't this be presence?
37 (commented on others PR)
Shouldn't the command here be editses?
38 (commented on others PR)
Maybe you could add a TODO for next time?
39 (commented on others PR)
Should this be something like saveStudentList?
40 (commented on others PR)
Maybe change this to JsonSerializableStudentList and correspondingly ReadOnlyStudentList?
41 (commented on others PR)
addressBook -> studentList?
42 (commented on others PR)
AddressBook -> StudentList?
43 (commented on others PR)
addressBook -> studentList?
44 (commented on others PR)
Maybe this could be changed to Clearing the student list?
45 (commented on others PR)
Maybe this could be changed to Delete Student, seeing as we are deleting one student at a time?
46 (commented on others PR)
Perhaps the last comma could be changed to a full stop?
47 (commented on others PR)
Maybe this comment could be deleted?
48 (commented on others PR)
Maybe this comment could be deleted?
49 (commented on others PR)
Maybe this comment could be deleted?
50 (commented on others PR)
Maybe this comment could be deleted?
51 (commented on others PR)
Maybe this comment could be deleted?
52 (commented on others PR)
Maybe this comment can be updated since we're no longer using a hash map?
53 (commented on others PR)
Maybe this comment could be deleted?
54 (commented on own PR)
Thanks for pointing this out, as well as in other places!
55 (commented on own PR)
This implementation is under the ModelStub and this method is not used at all, so I thought returning null wouldn't make much of a difference either way.
Do you have any alternative suggestions for this part?
56 (commented on own PR)
Same as above:
This implementation is under the ModelStub and this method is not used at all, so I thought returning null wouldn't make much of a difference either way.
Do you have any alternative suggestions for this part?
57 (commented on own PR)
Did I not add it in? Lines 22-24.
@lyeyixian (51 comments)1 (commented on others PR)
Is it better to change this sentence to this?
"This project is based on the AddressBook-Level3 project created by the SE-EDU initiative."
As I feel like this flows better for me.
2 (commented on others PR)
Should this be linked to our repo's actions instead of the se-edu's one?
3 (commented on others PR)
no i mean the link not the badges. Now you are linking it to se-edu/addressbook-level3
4 (commented on others PR)
https://github.com/AY2021S1-CS2103-T14-3/tp/actions
this
5 (commented on others PR)
I think this line can put?
6 (commented on others PR)
I'm a bit not sure about this. Is it we can edit the travel plan at top directory also?
7 (commented on others PR)
dk hahaha
8 (commented on others PR)
@jiaweiteo @jeannetoh99 @timjkong
9 (commented on others PR)
According to @jiaweiteo , only the name should be considered as identity fields, while passport and phone should be data fields
10 (commented on others PR)
i think its better to put getTPOList()
11 (commented on others PR)
same for all the other TPO
12 (commented on others PR)
Is it better to have ScrollPane here? As we might have lots of TravelPlan and the Pane cant show everything
13 (commented on others PR)
Same as above. Maybe we put ScrollPane here
14 (commented on others PR)
JavaDoc errors
15 (commented on others PR)
JavaDoc errors
16 (commented on others PR)
We just need one method from Directory only? What about AccommodationList all that?
17 (commented on others PR)
Is there a better way of doing this? Like not typecasting but instead use the polymorphism.
18 (commented on others PR)
Why did you use assert here btw? Cos I think assert won't be run if we didnt specify it and the user probably wont run our program with assertion on. Maybe check it using if block and throw an exception? Same for all the methods below
19 (commented on others PR)
JavaDoc error
20 (commented on others PR)
same for line 57
21 (commented on others PR)
JavaDoc error
22 (commented on others PR)
thats why before i put 2 boolean method to check is which one
23 (commented on others PR)
nah typecasting is not considered polymorphism. We have to do directory.the method straight away i think. But it might be not worth the time to think about that. So maybe can leave it like this first ba
24 (commented on others PR)
oh okok then Logic is the one that have to make sure the directory is the correct instance?
25 (commented on others PR)
Why this one change back to TravelPlan? It's not used in other place meh? like Activity all that
26 (commented on others PR)
Oh I see what you did there. Works but I feel like it is not following some OOP shit or smth. But I think we come back to this later ba.
27 (commented on others PR)
I think the cost is just numbers? iirc
28 (commented on others PR)
Do you think we want to make the arrangements of all these fields consistent throughout our whole repo. Cos I feel its a little bit messy right now, everybody's arrangement is different.
@jiaweiteo @jeannetoh99 @underthehai @timjkong
29 (commented on others PR)
Same as above
30 (commented on others PR)
Is it travel plan list?
31 (commented on others PR)
I think it is suppose to be start date and end date?
32 (commented on others PR)
We use -1 to indicate no changes, but here we throw an exception? Would it have any problem?
33 (commented on others PR)
There is an extra whitespace in front of Activities?
34 (commented on others PR)
Here also. Or is it deleted whitespace haha i not sure
35 (commented on others PR)
Why the whitespace!!!
36 (commented on others PR)
The Ui didn't show the index actually, do you think we wanna show it? Then, need add into Ui part
37 (commented on others PR)
!?
38 (commented on others PR)
But why previous one no problem one ah? hmmm
39 (commented on others PR)
Can you make the wish list "wishlist" instead? I think we use wishlist.
40 (commented on others PR)
CopyCommand perhaps?
41 (commented on others PR)
Do you think its better to use guard clause here instead of if else statement?
42 (commented on others PR)
Same as above
43 (commented on others PR)
JavaDoc issue: "address book"
44 (commented on others PR)
I think this can rename to SHOW_ALL? I remember I changed it to SHOW_ALL don't know when get changed back haha
45 (commented on others PR)
NameCard should be under TravelPlannerPanel
46 (commented on others PR)
These 3 should be TravelPlanObjectListPanel
47 (commented on others PR)
There is a space in front of -tra... ? Cos I tot just "-travelplan 2"
48 (commented on others PR)
No, its not. You go check the implementations in Ui component
49 (commented on others PR)
oo okok cos i think i didnt put space in front of mine
50 (commented on others PR)
Actually, I might try to change it so that there isn't so much magic number here and there, using the ArgumentTokenizer, cos you guys didn't utilise it i think?
51 (commented on others PR)
Hmmm is this image name correct?
52 (commented on own PR)
Need, but i thought haishan is also doing this so I left out the edit and show features for her, or I should just do them?
53 (commented on own PR)
Hmmm I don't know.
@jeannetoh99 @underthehai @timjkong
54 (commented on own PR)
Maybe can add the person to be deleted is not found?
You mean the person is not found in the travel plan or you mean the person is missing in the input command?
55 (commented on own PR)
I will add the case for target not found, but the error message one cause I wanted to make them generic so don't need to be too specific. The implementer of that feature can do whatever they want to the error message. What do you think?
56 (commented on own PR)
@underthehai
57 (commented on own PR)
I updated it. But I don't know if it works, can help me check?
58 (commented on own PR)
oh cos this method is I cincai add one last time. No JavaDoc all that, need to redo
59 (commented on own PR)
Actually I changed all to without all the Wanderlust in the front. Tsk didn't read my telegram message. YOU SHOULD CHANGED!!! NOT ME!!! HAHAHAHA
60 (commented on own PR)
They are included in the etc XD or else too long lah, or you think I should change the commandbox all that to travelplan thing?
61 (other comment)
My CI will pass after merging @jeannetoh99 TravelPlan class
62 (other comment)
Don't merge first after commiting changes.
I need to think about all the ReadOnlyXXX classes, if they are needed
63 (other comment)
I think I'm done for now? Hopes everything works.
64 (other comment)
And do you think we need to make sure that the travel plan inside travelPlanner needs to be updated too?
65 (other comment)
I closed ah, I have added them in my side
66 (other comment)
I think the commit is messed up, cos I branch this from the branch where I updated the Design section. So, this PR includes both changes. RIP
@pr4aveen (50 comments)1 (commented on others PR)
Should this be project book?
2 (commented on others PR)
Should we replace getTempFilePath("ab") to getTempFilePath("pb")?
3 (commented on others PR)
Should the variable be named pb instead of ab?
4 (commented on others PR)
Should this be named pb instead of ab?
5 (commented on others PR)
Should the indentation here and in the method below be 4 spaces from the parent comment?
6 (commented on others PR)
Is there a reason for adding this? These lines were removed in the previous PR as we removed those fields
7 (commented on others PR)
Just to confirm, the only time this test will fail is when the description is empty right
8 (commented on others PR)
Should there be an empty line before the @param tag?
9 (commented on others PR)
Agreed, maybe we can create a new PR for this after merging all the important features for milestone 1.1.
10 (commented on others PR)
Should there be an empty line before the @params tag?
11 (commented on others PR)
Is the requireAllNotNull() method here supposed to check the description as well?
I believe the description parameter is not optional as of now, right?
12 (commented on others PR)
I think the code here should be rearranged so that it is a little clearer. The modelName variable should be delared after the if (!Name.isValidName(name)) block
13 (commented on others PR)
Minor typo here
14 (commented on others PR)
Is there a variation of this test that you have written?
15 (commented on others PR)
Not sure if this Javadoc adheres to the coding standard
16 (commented on others PR)
Javadoc here should be StopCommand instead of StartCommand
17 (commented on others PR)
Should these two checks be extracted out into another method to keep the equals() method here clean?
18 (commented on others PR)
Should the javadoc here be more descriptive?
19 (commented on others PR)
Should have an empty line before the @param tag
20 (commented on others PR)
Should the equals() method below check whether both timers are equal?
21 (commented on others PR)
By below I mean in the Project.java class, can't really highlight it from here.
22 (commented on others PR)
Javadoc comment needs to be updated to include timer
23 (commented on others PR)
Why not just use the otherProject variable here?
24 (commented on others PR)
There should be an extra line before @params tag and a description for what is returned after the @return tag
25 (commented on others PR)
Should include an empty line before the @params tag
26 (commented on others PR)
Can I just check what the reason for changing this was?
27 (commented on others PR)
I think the commands here can be highlighted once again. For example
/home brings the user to home dashboard
28 (commented on others PR)
Should we replace these images with @khoodehui 's mockups? At least the ones that are ready
29 (commented on others PR)
If I'm not mistaken, all existing tags will be removed and only the tag normal will be left. Should we mention this?
30 (commented on others PR)
Should we separate format and examples into two columns?
31 (commented on others PR)
Can replace this with @khoodehui 's mockup as well
32 (commented on others PR)
Should these sentences end with a fullstop
33 (commented on others PR)
Should there be a big space here?
34 (commented on others PR)
This is something minor but I feel that it might be simpler to just do
Objects.hash(model, weeklyTotalTimePerProjectStatistic, Arrays.hashCode(statistics)).
35 (commented on others PR)
Small issue but can you just change ProjectBook to addressbook here because the issue comes from there
36 (commented on others PR)
I agree with Farrell. I think it might be better to keep it in deadline.
37 (commented on others PR)
Do you think this method will be used elsewhere in the future? If it is, it might be a good idea to move it over to StringUtil.java
38 (commented on others PR)
I think the javadoc for this method should be updated to reflect the new name
39 (commented on others PR)
Should this go under seedu.momentum.commons.core.Messages?
40 (commented on others PR)
Should these 3 variables just be declared directly since their values aren't passed into the constructor?
41 (commented on others PR)
Should we implement a compareTo method in Date.java?
42 (commented on others PR)
Incomplete header here
43 (commented on others PR)
I think we should have compareTo methods in the Date and Time classes and use them here instead
44 (commented on others PR)
I'm not sure if there's a cleaner way to do this. What do the rest think?
45 (commented on others PR)
This part is related to the comment on Project.java
46 (commented on others PR)
I think you can extract the common string variables that you have reused in this section and make them private static variables. For example, ascending, descending, alphabetical, deadline, created date
47 (commented on others PR)
You might want to make these public static variables instead. It's used quite a fair bit in tests and it'll be better if they all refer to one variable
48 (commented on others PR)
Might want to replace the alpha (and other keywords in other classes) with the public static variables I recommended in SortCommandParser.java
49 (commented on others PR)
Just checking, what's the expected behaviour when there is a preamble?
For example, sort hello type/alpha order/dsc
50 (commented on others PR)
Is Hello referring to Dana?
51 (other comment)
As discussed, description will be implemented as an optional parameter instead. A new PR will be created for this issue.
52 (other comment)
As discussed, description will be implemented as an optional parameter instead. A new PR will be created for this issue.
53 (other comment)
But one thing to consider is that the entry that you are working on might disappear.
Let's say your filtered list only has one entry. If you edit that entry and it the project doesn't match the predicate anymore, the list will not be empty. This might be a little weird from a UX perspective.
I'm not sure whether we should fix this. What do the rest think?
@MarcTzh (50 comments)1 (commented on others PR)
as of v1.2 there is no feature that requires the generation of reports
2 (commented on others PR)
interacting with GUI with a mouse* ?
3 (commented on others PR)
Again, no reports yet
4 (commented on others PR)
include date and time
5 (commented on others PR)
This is not in v1.2
6 (commented on others PR)
Don't edit the tutorial
7 (commented on others PR)
^
8 (commented on others PR)
Parameter name not changed
9 (commented on others PR)
Good
10 (commented on others PR)
uses '@' symbol
11 (commented on others PR)
Comment: 32nd not 32rd
12 (commented on others PR)
Comment needs to be updated
13 (commented on others PR)
Looks like you forgot to change these comments as well
14 (commented on others PR)
Comment should be day greater than 31 instead
15 (commented on others PR)
Is it supposed to be date or Date, previously it was Phone not phone
16 (commented on others PR)
KIV the prefix because this includes date and time
17 (commented on others PR)
Perhaps it should be named modelDateTime
18 (commented on others PR)
^
19 (commented on others PR)
Missed this out
20 (commented on others PR)
I personally feel that date and time should be separate, e.g. 01-01-2020 1200, we can discuss this in the team meeting tonight
21 (commented on others PR)
Should probably be on separate lines
22 (commented on others PR)
Should be named something more meaningful like status or taskStatus
23 (commented on others PR)
Shall discuss whether these fields should be optional in the team meeting later tonight
24 (commented on others PR)
Should be DATE_TIME
25 (commented on others PR)
does this prefix make sense or do we need to revise it since its date + time now, maybe it should be due: for example
26 (commented on others PR)
What is the purpose of this design wise? Is this to act as a null value without throwing NPE?
27 (commented on others PR)
The rationale behind using java String#trim on Phone was to remove leading and trailing whitespaces. When considering the user's dateTime input do we need to consider white spaces inside the string as well? For e.g. "01-01-2020 1200" vs "01-01-2020 1200" if we are not going to trim it then perhaps we need to consider adding an exception for this and add the corresponding unit test.
28 (commented on others PR)
Remove this
29 (commented on others PR)
rename this
30 (commented on others PR)
rename the date
31 (commented on others PR)
why did you change this?
32 (commented on others PR)
can change to complete or incomplete
33 (commented on others PR)
has a state of incomplete
34 (commented on others PR)
state of incomplete
35 (commented on others PR)
May need to capitalise the first letter so that the UI is standerdized
36 (commented on others PR)
integers*
separated*
37 (commented on others PR)
Why is done not capitalised?
38 (commented on others PR)
Do we need to use String builder or is efficiency not important? @BobbyZhouZijian
39 (commented on others PR)
What does this return if the arg is empty @dearvae
40 (commented on others PR)
do not add all the white spaces
41 (commented on others PR)
no space needed here
42 (commented on others PR)
why are there so many empty lines
43 (commented on others PR)
^
44 (commented on others PR)
what about status
45 (commented on others PR)
Value of status* - this makes it easier for the user to determine what is wrong with their input if there are multiple attributes in a find command
46 (commented on others PR)
Remove space
47 (commented on others PR)
remove this space
48 (commented on others PR)
why do you need to specify "which is null" when the attributes are the default values?
49 (commented on others PR)
why cant the default desc be an empty string?
50 (commented on others PR)
is it necessary to add an extra boolean when there was nothing wrong with the prev implementation?
51 (commented on own PR)
added extension
52 (commented on own PR)
These are in addremark.md not actual code, not sure if it needs to be changed
53 (commented on own PR)
same reply as above
54 (commented on own PR)
ok undid changes in these documents, please review again
55 (commented on own PR)
ok undid changes in these documents, please review again
56 (commented on own PR)
not in this PR
57 (commented on own PR)
changed
58 (commented on own PR)
done
59 (commented on own PR)
changes reverted
60 (commented on own PR)
this method is to list out the message constraints, in order to have a nice grammatically correct message the last type of task in this String should not contain a comma after it
e.g. Acceptable types of tasks are: A, B, C. instead of Acceptable types of tasks are: A, B, C, .
61 (commented on own PR)
excellent suggestion, it works as well and is more concise
62 (commented on own PR)
LOL i thought i deleted, it was for debugging 😃
63 (commented on own PR)
yes need, good spot
64 (other comment)
Does not LGTM. Please include markdown for important commands or things to note of. Thanks.
65 (other comment)
Please include your portfolio under team/GabriellaTeh.md
66 (other comment)
Resolved merge conflicts and created a new pull request from a different branch
67 (other comment)
Hi Zijian, I conducted some boundary value analysis and found that it works as intended for the positive test cases but when i put in find status: it does not throw any error, it says 0 tasks listed, following equivalence partitioning i shall stop further tests
68 (other comment)
A few problems I found:
find status: XXX where XXX is an invalid input, returns 0 tasks found as well
Error message displayed should state that status can only be of 2 values: complete and incomplete.
find date:01-01-202 is also accepted and the date 01-01-2020 matches it, should this be considered an incorrect input
@simonteozw (50 comments)1 (commented on others PR)
Can you change this to docs/UserGuide.md
2 (commented on others PR)
Should we remove this *{More to be added}* line?
3 (commented on others PR)
Can I ask what is gradeDist? Is it grade distribution?
4 (commented on others PR)
Can I check why we are checking if other is instanceof Name? We should only check if other is also a Location right
5 (commented on others PR)
Another instance here. I think should be other instanceof Location right?
6 (commented on others PR)
Should we use Address Class for Task as well? I am unclear if there is a difference between Location and Address class class haha
7 (commented on others PR)
Just curious, why did you remove the (String) typecasting?
8 (commented on others PR)
Need to fill in return value here
9 (commented on others PR)
Can I check, what is the difference between setModule and setModules? They are for different use cases?
10 (commented on others PR)
Should ass throws ModuleNotFoundException, DuplicateModuleException to the method declaration right? Same for several other methods.
11 (commented on others PR)
Just thinking. Shoudl we change this TrackItManager? Or TrackIt? haha. If it's too troublesome to change then nevermind.
12 (commented on others PR)
Ok then we just leave it first. If need be we will let the others add in these methods when they implement further
13 (commented on others PR)
Maybe we should add throws NullPointerException in the method declaration? Or remove that line in comments.
14 (commented on others PR)
Can delete the @return here as well, or add the return value
15 (commented on others PR)
Is this method supposed to be empty?
16 (commented on others PR)
Can I check why this is removed? Are we leaving it to later to implement?
17 (commented on others PR)
Why is @Override removed? The getTaskList method is from ReadOnlyTrackIter so we should keep the @Override right?
18 (commented on others PR)
Is this the final PR for concrete classes? If yes we should re-enable checkStyle
19 (commented on others PR)
Can remove this comment
20 (commented on others PR)
Same. Can remove this comment
21 (commented on others PR)
Here too. Remove comment
22 (commented on others PR)
Remove comment
23 (commented on others PR)
Should MESSAGE_USAGE be L list: sample? Maybe change to another word like CS2100 to make it clearer?
24 (commented on others PR)
Remove Comment. Maybe change MESSAGE_USAGE to have a clearer keyword instead of sample
25 (commented on others PR)
Should be There is no module matched to the given module code. Missing the to.
26 (commented on others PR)
Maybe can add an example, like in AddContactCommand
27 (commented on others PR)
Same here. Maybe should add example.
28 (commented on others PR)
Same here. Maybe add example
29 (commented on others PR)
Same here. Maybe add example
30 (commented on others PR)
Same here. Maybe add example
31 (commented on others PR)
Just curious. Is there a need for PREFIX_TYPE when there is already a PREFIX_NAME? OR this is just for clarity when reading code?
32 (commented on others PR)
Since the function is parseTime, maybe should change Lesson.DATE_MESSAGE_CONSTRAINTS to Lesson.TIME_MESSAGE_CONSTRAINTS? Just a suggestion haha
33 (commented on others PR)
Yes this sounds better
34 (commented on others PR)
Ok
35 (commented on others PR)
Should the ParseException be thrown with empty string? No message?
36 (commented on others PR)
Can remove the 2 lines of whitespace here
37 (commented on others PR)
Same here
38 (commented on others PR)
Hmm maybe write the new message on this line then in the following line you can write catch (ParseException pe) { throw pe }
39 (commented on others PR)
I meant here, lines 17 - 18
40 (commented on others PR)
Actually I meant here lines 17-18
41 (commented on others PR)
Maybe change the comment here address book to app or TrackIt
42 (commented on others PR)
What does this do?
43 (commented on others PR)
Why do we need this toString method? Maybe change to Code: and editModuleDescriptor: instead of code= and editModuleDescriptor=
44 (commented on others PR)
Why do we need this? And Maybe change to Name: is this for testing purposes?
45 (commented on others PR)
maybe can remove the @FXML private Label desc on top too
46 (commented on others PR)
Hmm I think we should enable it before merging right?
47 (commented on others PR)
Oh I didnt IntelliJ will autogenerate toString methods. Do you plan on removing this? Or keep it just for testing
48 (commented on others PR)
Ok, but I think before we submit v1.3 on Friday we should remove this
49 (commented on others PR)
Ok
50 (commented on others PR)
Is this supposed to be commented out?
51 (commented on own PR)
Ok I tried to change to this but err java gives me an error: Illegal escape character in String literal
52 (commented on own PR)
What do you mean by view it by Id. Task doesn't have ad id associated with it haha
53 (commented on own PR)
Hmm actually I think writing note/ will be very cumbersome, and may confused users because they are used all 1 letter not 1 word
54 (commented on own PR)
Hmm ok then can I suggest we stick to r/ for remark, I believe note/ is too cumbersome
55 (commented on own PR)
Hmm I am following the standard comment format. I think better to keep it this way for now
56 (commented on own PR)
Ok. I suggest for now we leave it as is. Since Lesson and Task have a date component, we can standardise once both have been merged in and refactor it to be one of the 'commons'. Then that will be cleaner. Maybe leave for v1.3
57 (commented on own PR)
Ok. I suggest for now we leave it as is. Since Lesson and Task have a date component, we can standardise once both have been merged in and refactor it to be one of the 'commons'. Then that will be cleaner. Maybe leave for v1.3
58 (commented on own PR)
I think that will require some refactoring. I suggest I create an issue for it and we settle in v1.3
59 (commented on own PR)
Yes but apart from checking not null, we must also check if the fields fit the specific requirements, which differs for each requirement. Maybe we can look into it, but probably for v1.3
60 (commented on own PR)
There is no description class. Description is stored as a string thats why I used String
61 (commented on own PR)
There is no Weightage class. Weightage is stored as a double thats why I used Double class.
62 (commented on own PR)
Yes ok I will change it
63 (commented on own PR)
I think we can just leave it for now
64 (commented on own PR)
This is to support the feature that when the user types c/ it will reset the code to null, in other words they can remove the module code. If only have the latter check c/ will throw error
65 (commented on own PR)
Same as above. I want to distinguish between storing remark as null vs storing it as an empty string. Unless maybe it is better to just store all null as empty string?
66 (commented on own PR)
Ok I will leave it first then
67 (commented on own PR)
Hmm ok I shall refactor this
68 (other comment)
Just finished refactoring. I think we can merge this first then I can create another PR where I rename the files to AddContactCommand? and etc
69 (other comment)
Also rmb to fix issue brought up by Weihong. criminal lawyer is not alphanumeric.
https://discordapp.com/channels/@me/763052081266950177/763128915186155520
@wltan (48 comments)1 (commented on others PR)
Is it necessary to perform test after check? I believe check already includes test.
https://stackoverflow.com/questions/50104666/gradle-difference-between-test-and-check
2 (commented on others PR)
Duplicate https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/13#discussion_r492195636
3 (commented on others PR)
Do glossary terms need to be italicized? May need to standardize.
4 (commented on others PR)
Can I confirm that this line will be left unchanged? Otherwise LGTM.
5 (commented on others PR)
Ok, we will review this again towards the end of v1.2.
6 (commented on others PR)
Can we verify that this workflow runs smoothly on our repo?
Perhaps you can push an equivalent change directly to a non-master branch first, and see what happens to the gh-pages branch.
7 (commented on others PR)
Ok, as seen from https://github.com/AY2021S1-CS2103T-W16-3/tp/commit/65e48f7a1f38c68e643cb29f8d29e0951f06bc4c the CI is able to build and deploy GitHub Pages properly.
8 (commented on others PR)
Suggest extracting these changes to their own commit/issue/PR as they are technically not related to the issue at hand.
9 (commented on others PR)
See above (https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/23#discussion_r495016936)
10 (commented on others PR)
See above (https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/23#discussion_r495016936)
11 (commented on others PR)
Minor typo fixes can be left as part of this PR.
12 (commented on others PR)
Similar to https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/7#pullrequestreview-492595656, Cygwin messes up on CRLF line endings in the scripts. Not a major problem; the hooks will work as long as the scripts are changed to LF line endings.
13 (commented on others PR)
After discussion, changes can be left in this PR, but should be separated into different commits so that they will show up in the squashed commit upon merge.
14 (commented on others PR)
These don't look like intentional changes 😕
15 (commented on others PR)
https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/39#discussion_r495585791 same here
16 (commented on others PR)
Minor typo:
The UI consists of a `MainWindow` that is made up of parts e.g.`CommandBox`, `ResultDisplay`, `TransactionListPanel`, `StatusBarFooter` etc. All these, including the `MainWindow`, inherit from the abstract `UiPart` class.
17 (commented on others PR)
Indentation still appears to be slightly off here compared to the previous state
xmlns:fx="http://javafx.com/fxml">
18 (commented on others PR)
transaction is no longer the parameter name
* Returns an add expense command string for adding the {@code expense}.
19 (commented on others PR)
This should be changed as well, my bad!
* Returns an add income command string for adding the {@code income}.
20 (commented on others PR)
Perhaps the variable name should be ft instead of ab?
Also I don't see any method signature for withTransaction(String, String). Is this a problem inherited from the original AB3?
21 (commented on others PR)
Same as above, consider changing ab to ft.
22 (commented on others PR)
public static List<Expense> getTypicalExpenses() {
return getTypicalTransactions().stream()
.map(TransactionBuilder::new)
.map(TransactionBuilder::buildExpense)
.collect(Collectors.toList());
}
public static List<Income> getTypicalIncomes() {
return getTypicalTransactions().stream()
.map(TransactionBuilder::new)
.map(TransactionBuilder::buildIncome)
.collect(Collectors.toList());
}
Might be possible to further simplify by extracting out the common parts.
23 (commented on others PR)
Missing a blank line here
24 (commented on others PR)
+ "When on Expenses tab: Searches all expenses.\n"
25 (commented on others PR)
Should this be something like a ListOverviewCommand instead, to highlight that it is for the overview tab?
26 (commented on others PR)
Ok, makes sense.
27 (commented on others PR)
Perhaps getTypicalFinanceTracker().getExpenseList().size()?
By the way, it doesn't really matter here but the expected value is supposed to be the first argument to assertEquals, and the actual value comes second.
28 (commented on others PR)
Does this need to be fixed?
29 (commented on others PR)
I think we should try to avoid newlines mid-sentence?
30 (commented on others PR)
Would look better italicized IMO
31 (commented on others PR)
Perhaps this could be a subheading instead?
32 (commented on others PR)
Same as above, combine with the previous line
33 (commented on others PR)
#### Workflow changes
34 (commented on others PR)
- `ModelManager`: 3 filteredLists for Transactions, Incomes and Expenses respectively, `FinanceTracker`: 1 transactionList **(Yong Ping)**
35 (commented on others PR)
This hasn't been resolved yet
36 (commented on others PR)
My previous comment https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/118#discussion_r506540945 was referring to Line 7, not Line 6
37 (commented on others PR)
1. Download the latest `fine$$e.jar` from [here](https://github.com/AY2021S1-CS2103T-W16-3/tp/releases).
38 (commented on others PR)
public static final Comparator<Transaction> TRANSACTION_COMPARATOR =
Comparator.comparing((Transaction t) -> t.date).thenComparing(t -> t.title);
39 (commented on others PR)
I feel like this could be improved somehow, due to the similar logic. I'll try to think of something
40 (commented on others PR)
* Sorts the list based on {@code TRANSACTION_COMPARATOR}.
41 (commented on others PR)
Never mind, I think it should be fine to leave it as it is for now
42 (commented on others PR)
I think the root cause is that setValue does not perform any validation.
In addition, the raw input value is being used in the CommandResult.
43 (commented on others PR)
This is also due to the fact that when amounts are being written, it is using BigDecimal::toString(), where perhaps better abstractions could be done.
44 (commented on others PR)
In addition, the raw BigDecimal value is being used for the UI display, which will cause inconsistencies as the precision (number of decimal places displayed) is not fixed.
45 (commented on others PR)
Instead of duplicating code from Amount, perhaps you could write this to encapsulate an Amount instead?
This should solve the validation and abstraction issues faced in the other classes.
46 (commented on others PR)
Uncaught exception when no argument is supplied i.e. set-expense-limit.
This could be handled either here in the parser or within the command execution (as the amount is being validated).
47 (commented on others PR)
Also, avoid dealing directly with BigDecimal as it will break if we decide to change the underlying data type for Amount. If there's anything you need from the underlying value, just add the functionality to Amount.
48 (commented on others PR)
This change should be reverted to prevent merge conflicts with #152.
(unless we are merging this one first?)
49 (commented on own PR)
Fixed
50 (commented on own PR)
Fixed
51 (commented on own PR)
Unsure if the keywords e.g. "transaction", "date", "amount", "expense", "income" should reference the class names.
52 (other comment)
Note that placeholders johndoe.md and johndoe.png are being removed as they are no longer needed.
53 (other comment)
It was found that the shell scripts do not produce any output unless problems are detected.
To make the pre-push hook and CI job more useful, the changes in #23 will also modify the scripts to print their status as each check is being run.
54 (other comment)
Note that while we intend to rename test methods to match the new model, we will leave the test data alone for now and revisit it in a follow-up issue.
55 (other comment)
https://github.com/AY2021S1-CS2103T-W16-3/tp/pull/39#pullrequestreview-497089729
Update the package names too to
ay2021s1-cs2103-w16-3.finesseas discussed.
Edit: My bad, hyphens are illegal characters. How about
ay2021s1_cs2103_w16_3.finesseas recommended here?
Recommend doing this in a separate PR. Refactoring the package would generate a large diff and make it difficult to review the model renaming.
56 (other comment)
Now that #39 has been merged, all that is left is to delete the Address class, which is incidentally one of the CS2103T tP tutorial tasks.
57 (other comment)
How should we rectify this? Fix the sample command or fix the validation?
58 (other comment)
Closed with #136
59 (other comment)
Proposed improvements based on discussion in CS2101:
Add general description of what each tab is for and what the user can expect (including screenshot)
For commands with aliases/general command words, the title can show just the main command and then list below the alias and/or tabs the general command can be used on
Split transaction -> income and expense for edit and delete commands. This is because the user guide should be based on features available to the user, instead of what commands have been implemented behind the scenes.
Glossary to tell the user (or potential user/PE tester) what a transaction/income/expense represents in the real world, and what the data fields (title, amount, date category) are for.
@fyshhh (48 comments)1 (commented on others PR)
i agree with jun da, i think changes to different parts of the project should be done in different branches. this is for clarity and ease of finding. might be a bit strange to see a branch merge for both ug and actual code.
2 (commented on others PR)
for consistency across the entire codebase, i think it'll be better if you have your documentation written like this:
/**
* Returns a trimmed predicateField. If...
*/
3 (commented on others PR)
this documentation should be changed too!
4 (commented on others PR)
this documentation should be changed too!
5 (commented on others PR)
this documentation should be changed too!
6 (commented on others PR)
this documentation should be changed too!
7 (commented on others PR)
this documentation should be changed too!
8 (commented on others PR)
this documentation should be changed too!
9 (commented on others PR)
this documentation should be changed too!
10 (commented on others PR)
there are 2 grammatical errors here - should be "an" instead of "a" and "its" instead of "it's".
also, can you change this reference from address book to Athena?
11 (commented on others PR)
should be "an" instead of "a" event.
12 (commented on others PR)
should be "an" instead of "a" event.
13 (commented on others PR)
could be wrapped in an Optional instead (since you're doing so below anyway)
14 (commented on others PR)
consider adding the NoSuchElementException thrown to the method signature
15 (commented on others PR)
this should be spaced out to three lines
16 (commented on others PR)
nope, just a personal preference.
17 (commented on others PR)
do you have an example?
18 (commented on others PR)
noted. i mentioned this because Parser.parse (and all its implementations) contain an unchecked exception in it's method signature.
19 (commented on others PR)
this should be changed to match the new parsing structure, and a COMMAND_TYPE field should be added.
20 (commented on others PR)
this is not implemented yet. perhaps it should be made a bit clearer (with a comment in the code maybe)?
21 (commented on others PR)
this currently leads to bugs; if i put an index of 3, it'll still return the DESCRIPTION_COMPARATOR. i think you should have individual cases for each comparator, and then throw a ParseException in the default line.
22 (commented on others PR)
although i think it would be better to have the detection of invalid inputs handled in SortEventCommandParser.parse.
23 (commented on others PR)
yeah so i think the default branch in here should throw something like an IllegalArgumentException (for us to see, since this branch should never be reached), and the one in SortEventCommandParser.parse should throw a ParseException (for the user to see, if they input an invalid number).
24 (commented on others PR)
"combines the" repeated twice
25 (commented on others PR)
i think another punctuation mark would be better - maybe:
"Returns true if the tag is valid - that is, it has at least..."
26 (commented on others PR)
i think our documentation is done in present tense, so using "cannot be found" would be more consistent than "could not be found". also, since "tags that could not be found" is repeated twice, maybe just rephrasing the entire sentence would be preferable, so something like:
"For tags that cannot be found, the string will reflect that by prepending the appropriate message."
27 (commented on others PR)
slightly awkward; maybe use firstly/secondly/lastly?
28 (commented on others PR)
new tagging sounds a bit weird, but this could be me. could you elaborate on what you mean?
29 (commented on others PR)
tagTree should be enclosed in {@code } for consistency.
30 (commented on others PR)
did you mean set of persons?
31 (commented on others PR)
slight inconsistency; first line of documentation says the set returned falls under the given tag and all its sub-tags, but this line says or.
32 (commented on others PR)
perhaps both these sentences could be combined into one.
33 (commented on others PR)
i think "given" instead of "if" sounds better.
34 (commented on others PR)
lacking capitalisation; also i think it should be personToCopy rather than persontocopy.
35 (commented on others PR)
lacking capitalisation; also i think it should be personToCopy rather than persontocopy.
36 (commented on others PR)
i think you meant "When relationships...".
37 (commented on others PR)
i think using "which" instead of "whose" is more appropriate.
38 (commented on others PR)
perhaps "cyclic dependencies"?
39 (commented on others PR)
i think you should either connect both sentences with a comma (i would prefer this) or write "Returns false otherwise." in the second.
40 (commented on others PR)
HashMaps?
41 (commented on others PR)
Copies*
42 (commented on others PR)
should these have documentation?
43 (commented on others PR)
i don't think union is a verb.
44 (commented on others PR)
who's jackson
45 (commented on others PR)
should this be capitalised? actually should there be standardisation in how json is referred to? some documentation refer to it as JSON and some as Json.
46 (commented on others PR)
gotcha.
47 (commented on others PR)
makes sense.
48 (commented on others PR)
hmm okay, i'll keep this in mind.
49 (commented on own PR)
hmm, interestingly this is also something that i had issues with. i avoided using AddressBookParser.COMMAND_TYPE as i did not want to create further cyclic dependencies (AddContactCommandParser -> AddContactCommand -> AddressBookParser -> AddContactCommandParser).
a plausible solution would to be to create an enumeration to only store command words/types and for all command classes to reference that instead, so the test cases can remain untouched.
50 (commented on own PR)
agreed. i will change these when the above conversation has been resolved.
51 (commented on own PR)
the implementation would be to create two enumerations - CommandWord and CommandType - and have AddressBookParser and the Command classes refer to the enumeration instead. this accomplishes two things:
resolves the aforementioned cyclic dependencies.
test cases can remain as is, since they currently refer to each individual Command class' word/type.
i think there is merit in having the test cases remain in their current classes as they are intended to test certain classes.
My suggestion was actually to not have this at all.
hmm, what would you propose then?
52 (other comment)
Use cases to be compartmentalised by individual member.
53 (other comment)
Introduction not added, reopened
54 (other comment)
Resolves #82 and #83.
55 (other comment)
We have elected to update the UG for two reasons:
Consistency - some of the event methods end with an s while others do not. While this was intended to represent the plurality of some of the returns, this can be confusing for users unfamiliar with Athena. Additionally, to standardise methods between contacts and events, we should use the similarly worded commands for both. Since list is already implemented as a contact feature, we'll stick to listEvent.
Convenience - the documentation of listEvent in the UG is incorrect to begin with. Instead of having to correct both the method and the UG (to listEvents), we instead change only the UG.
I will update the UG by tomorrow to fix these inconsistencies.
56 (other comment)
I suspect it is possible to store this information in a file that already exists in the codebase, as changes to the GUI are saved through different sessions. It is likely that the same file can be used to store this information.
57 (other comment)
For clarity, this is unlikely to require large-scale changes across the codebase, as existing classes can be used. Instead, the parser will be changed to support the new command structure.
58 (other comment)
Turns out it's just a macOS quirk. Perhaps this will be implemented in the future, when there are other forms of state saving required.
59 (other comment)
Looks good to me. I'm just wondering how the TagManager class helps to keep track of the participants (persons) of a particular event without implementing necessary changes in Calendar class or respective events class?
i don't think it's supposed to. this class is just a means to implement better Tag management-related features. the intermediary between contact- and event-functionalities have yet to be implemented.
60 (other comment)
i think we can give the user the option to capitalise their Tags and use regex to ignore case sensitivity in our searches.
61 (other comment)
i see your point, but i think the best solution is just to include a way for them to edit their tags after they've been created. as a user, i would not like having to be forced into using a certain case (be it upper or lower), as different cases can add nuance to the tags.
62 (other comment)
Enumerations added (see conversation with @chan-j-d above for more details).
63 (other comment)
fixes for this will be rolled out when the new GUI is done.
64 (other comment)
lgtm - good job!
65 (other comment)
i will implement this alongside #118.
66 (other comment)
closed and split into #129 and #130.
67 (other comment)
in adding these test cases I had to add a few other classes - EventBuilder, EventUtil and EditEventDescriptorBuilder. you may find these classes helpful in constructing your own test cases.
@ypinhsuan (48 comments)1 (commented on others PR)
Just a small grammar error. I think it should be students' and not student's?
2 (commented on others PR)
Maybe it will be nice to change tutees to students? Since we are using students at all other places.
3 (commented on others PR)
Perhaps it will be better to remove contact since users can edit tags as well. And tags may not be contact information.
4 (commented on others PR)
Perhaps it will be great to include the format here as well?
**List Students in Class** | `list students /by [n/CLASS_NAME] [m/MODULE_CODE]`<br> e.g., `list students /by n/Tutorial T10 m/CS2013T`
5 (commented on others PR)
I think you forgot to change the example?
**List Students in a Class** | `list-students c/INDEX`<br> e.g., `list-students c/3`
6 (commented on others PR)
Nice! 👍
7 (commented on others PR)
I like this. But i think we need to update the examples in user guide since users don't have to type @ now
8 (commented on others PR)
Should there be a space before comma?
9 (commented on others PR)
I don't think there should be address?
// Keywords match telegram and email, but does not match name
predicate = new NameContainsKeywordsPredicate(Arrays.asList("12345", "alice@email.com"));
10 (commented on others PR)
* Returns an {@code TutorsPet} with all the typical students.
11 (commented on others PR)
Good catch!
12 (commented on others PR)
I think this should change to AddModuleClassCommand?
* Parses the given {@code String} of arguments in the context of the AddModuleClassCommand
* and returns an AddModuleClassCommand object for execution.
13 (commented on others PR)
Is it possible to change Node to Label?
* Creates a {@code Label} with the given {@code Tag} details.
*/
public Label createTag(Tag tag) {
Or alternatively change the Label in JavaDoc to Node?
14 (commented on others PR)
I think there is a missing space.
-fx-background-color: derive(#7392b7, 10%);
15 (commented on others PR)
Is it An UI or a UI ?
16 (commented on others PR)
Not sure if we should use An UI.
17 (commented on others PR)
Is there an extra semicolon?
18 (commented on others PR)
Great job for finding so many missing full stops in comments! 👍
19 (commented on others PR)
There is an extra space.
<!-- Checks that every class declaration is followed by an empty line. -->
20 (commented on others PR)
I just realized that we forgot to write javadoc for getModuleClassList().
21 (commented on others PR)
Perhaps this should change to different objects ?
// different objects -> returns false
22 (commented on others PR)
Perhaps can add in a test for multiple student indexes/class indexes?
23 (commented on others PR)
Perhaps this should start with capital letter?
// Calls #setStyleToDefault() whenever there is a change to the text of the command box.
24 (commented on others PR)
Perhaps it will be better to rename key to student?
25 (commented on others PR)
Perhaps it will be better to add a so that it is more consistent? (Add a class, add a student etc)
| UC17 | Add a lesson |
| UC18 | Edit a lesson |
| UC19 | Delete a lesson |
26 (commented on others PR)
Perhaps it will be better to add underscore in between?
| **Add Lesson** | `add-lesson c/CLASS_INDEX d/DAY st/START_TIME et/END_TIME v/VENUE r/NO_OF_TIMES` <br> e.g., `add-lesson c/1 d/MONDAY st/8.00AM et/10.00AM v/COM1 #01-01 r/13` |
27 (commented on others PR)
* Returns a deep copied {@code AttendanceRecord}.
28 (commented on others PR)
Perhaps it will be better to use class since we are using class in user guide?
+ ": Deletes the lesson in a specific class identified by the "
+ "index number used in the displayed class list and lesson list respectively.\n"
29 (commented on others PR)
Perhaps it will be better to use student manager since the app is about managing students?
* Adds a lesson to the student manager.
30 (commented on others PR)
Might be better to use student manager here as well
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a lesson to the student manager. "
31 (commented on others PR)
// add lesson to moduleClass
32 (commented on others PR)
* Returns an add lesson command string for adding the {@code lesson}.
33 (commented on others PR)
Should we replace it with tutorspet?
1. Run the `tutorspet.Main` and try a few commands.
34 (commented on others PR)
I think you missed out this line
e.g. `tutorspet.commons.StringUtilTest`
35 (commented on others PR)
Perhaps we should keep the storage?
e.g. `tutorspet.storage.StorageManagerTest`
36 (commented on others PR)
Perhaps keep tutorspet.model here? Similarly for the CollectionUtil below
import tutorspet.model.Model;
37 (commented on others PR)
I think this should be click only?
Perhaps it will be good if we can also explain the functions of the other 2 tabs here (File and Help)?
If you would like to change Tutor's Pet theme, click on the **Theme** tab at the top of the screen. There are
38 (commented on others PR)
Would it be better to add view?
| **View Statistics** | `stats c\CLASS_INDEX s\STUDENT_INDEX`<br> e.g., `stats c\1 s\1`
39 (commented on others PR)
Might be good to mention the week here as well
* Your `CS2103T Tutorial` lesson in week 10 has just ended and you would like to give participation scores to the students. You
40 (commented on others PR)
I think affects sounds a bit weird to me. Would this be better?
3. The command execution calls static methods from the `ModuleClassUtil` and `LessonUtil` classes.
41 (commented on others PR)
Should we put the two terms into glossary? Since they appear in quite a number of places
42 (commented on others PR)
I think it should be display-venue?
#### Display venue : `display-venue`
43 (commented on others PR)
Perhaps it will be better to change to Display Statistics so that it is consistent with the summary table on top?
#### Display Statistics : `stats`
44 (commented on others PR)
Perhaps can change to targetWeek
deleteAttendanceFromModuleClass(moduleClass, lessonIndex, targetWeek, student);
45 (commented on others PR)
* One of your students, `Bernice`, has swapped `CS2103T Tutorial` slots and you no longer teach her.
46 (commented on others PR)
Perhaps it will be good to also mention that Bernice is the second student on the list?
47 (commented on others PR)
* You made an error while entering the `CS2103T Tutorial` lesson. It should be `Tuesday` and not `Thursday`. You type the command `edit-lesson c\1 l\1 d\Tuesday` and press <kbd>Enter</kbd>.
48 (commented on others PR)
The meaning of CLASS_INDEX and LESSON_INDEX are explained in the glossary. Perhaps we don't need to explain here again?
49 (commented on own PR)
agree with this
50 (commented on own PR)
No particular reason. I am thinking of changing to 52 since there are 52 weeks in a year. Any suggestions for the number?
51 (commented on own PR)
The end time of the original lesson was 10am, so the start time cannot be set to 2pm. If not I will get a lesson starting at 10 and ending at 2
52 (other comment)
Yep works on mine too
@JinHao-L (48 comments)1 (commented on others PR)
Maybe the patients should be caps (for standardisation)
2 (commented on others PR)
I think there is a double spacing between Nuudle and shows
3 (commented on others PR)
Would delete an appointment be clearer?
4 (commented on others PR)
Would mark an appointment be clearer?
5 (commented on others PR)
I think appointments here should be singular?
6 (commented on others PR)
Maybe it will be better to use the specified appointment?
7 (commented on others PR)
Seeing that appointment is dependent on the patient, should it be clear all appointment entries instead? What do you think?
8 (commented on others PR)
I think this should be person or nurse instead
9 (commented on others PR)
Should AssignLoaderBuilder be DateTimeLoaderBuilder instead?
Because there is no AssignLoader object.
10 (commented on others PR)
Should there be a closing square bracket?
11 (commented on others PR)
The boolean isAll seems to be unused.
Maybe instead of using a boolean can consider using PREDICATE_SHOW_ALL_APPOINTMENTS in Model.java then there is no change in the implementation
Lemme know what you think about this! 😄
12 (commented on others PR)
I think that he handled this under NuudleParser but I think it would be better to do the argument checking in this file instead?
Maybe can try doing the isEmpty check before tokenize?
13 (commented on others PR)
Maybe can rephrase this to Mark the specified appointment as done or Mark the appointment specified by the date and time as done (more specific version).
Lemme know what you think! 😄
14 (commented on others PR)
I am not really sure if we should create an appointment without a patient for checking purpose. I made a PR to remove the optional field of Patient so an appointment cannot be made without a Patient (see #90)
Maybe for the filter in line 60, can change it to check if an appointment has the same date and time? (hasDate and hasTime) Do you think this works?
15 (commented on others PR)
It seems wrong to use a nested class in AssignCommand for non-assign related command.
Should we abstract out the DateTimeLoader into a class on its own? Maybe this can be addressed in future PRs.
16 (commented on others PR)
editedPatient should be editedAppointment instead.
17 (commented on others PR)
For this can just add throw new AssertionError("This method should not be called."); similar to above
18 (commented on others PR)
The check should probably be !target.startAtSameTime(editedAppointment) && hasOverlaps(editedAppointment) instead. (If the edited version is different from the target, make sure that there is no overlap with the rest of the appointment.)
I think that the else { part can also be removed so that the happy path is made more prominent. 😄
19 (commented on others PR)
This should still be AddressBook?
20 (commented on others PR)
This should still be AddressBook?
21 (commented on others PR)
Should it be Exiting Nuudle instead
22 (commented on others PR)
Should it be Nuudle instead?
23 (commented on others PR)
Should it be Nuudle instead?
24 (commented on others PR)
Should it be Nuudle instead?
25 (commented on others PR)
I think Updates all appointments with the given {@code Patient target} with the given {@code editedPatient} would be better as it implies that multiple appointments will be updated.
26 (commented on others PR)
I think this is correct.
I believe that the check is if target and editedAppointment does not overlap, check to ensure that the editedAppointment does not overlap with any other appointments.
If the target and editedAppointment do overlap, you are sure that there will be no problem adding the editedAppointment as it can safely replace the target.
27 (commented on others PR)
Actually for simplicity, we can also consider this: call remove on target, then call add on editedAppointment. If it throws OverlappingAppointmentException, then we add back target
28 (commented on others PR)
Yes. It will still throw an exception.
29 (commented on others PR)
Good effort on updating the user guide! Thanks for correcting the cancel and view documentation too! 👍
30 (commented on others PR)
Just a comment: Should we include a constraint on the date and time not being in the past for cancel and done? It's not implemented currently, but I guess we can add it in the next milestone.
31 (commented on others PR)
I think that the DATE and TIME should be DATE and TIME instead? Same for the documentation for cancel.
32 (commented on others PR)
I agree with Wanlin actually, I think that it should be ParseException instead. Although IllegalValueException is the parent class, we expect parseIndex to only throw ParseException and if it throws anything else we know that this is unexpected behaviour that we should fix.
33 (commented on others PR)
I think this can be removed as it's not used in the program?
34 (commented on others PR)
I think remark should be added here too for the requireAllNonNull
35 (commented on others PR)
For now, the only possible constraint I can think of is the word length, otherwise, a user can add a whole paragraph to a remark. What do you think?
36 (commented on others PR)
Ohh I was comparing it with the other command parsers and they were using ParseException. So shd be ok to change it to ParseException
37 (commented on others PR)
Yep this looks much better! 👍
But is it abit long? Maybe can shorten the last part to refer to help instead?
38 (commented on others PR)
Should be a {@code Remark} here
39 (commented on others PR)
Hahaa nice effort! 👍
40 (commented on others PR)
Do you think it is better if we include the index directly in the tests instead of here?
Because currently it seems a bit inconsistent with the rest.
Not really a big issue tho. Let me know what you think
41 (commented on others PR)
I think the link should be updated to our group repo
42 (commented on others PR)
I don't think there is a VersionedPatientBook here
43 (commented on others PR)
The appointment should not be created when called with lastShownAppointmentList.filter.
toMark.markAsDone should call the markAsDone method in toMark:Appointment which in turns call the constructor of doneAppointment
44 (commented on others PR)
The link here should also be updated?
45 (commented on others PR)
The phrasing seems a bit off.
Would it be better if we phrase it as The 'DURATION' is measured in minutes and will be defaulted to 60 minutes if omitted?
Do add on if the phrasing can be improved further. 👍
46 (commented on others PR)
Yes I agree with Wanlin, isPresent() would be better. The user can change to a specific date, time or duration without changing the rest.
47 (commented on others PR)
I think that !(appointmentToEdit.startAtSameTime(editedAppointment) && model.hasAppointment(editedAppointment)) would be a better form of checking.
This checks if the 2 appointments are "equal" first before checking if the edited appointment has any complete overlaps with the other existing appointments
48 (commented on others PR)
Remember to edit this part 👍
The logic for setting appointments can be handled in UniqueAppointmentList and this part can be edited to catching OverlappingAppointmentException and throwing the relevant CommandException.
49 (commented on own PR)
Oh yeah. I missed that out. Thanks 👍
50 (commented on own PR)
Oh I forgot to change it to INDEX. Thanks for spotting it 👍
51 (commented on own PR)
Hmmm, do you think if something like that will be good? See
52 (commented on own PR)
Oh I missed that out! I'll update it to "hour". Thanks 👍
53 (commented on own PR)
Ohh yeah. I have updated this on my side. Thanks for spotting it 👍
54 (commented on own PR)
Agreed 👍
55 (commented on own PR)
I think this is auto-correct on my part! It should have a tab right?
56 (commented on own PR)
I have edited this on my side. 👍
57 (commented on own PR)
Edited! Thanks for spotting it! 👍
58 (other comment)
Patient details refers to basic information such as phone number, email, address, etc
59 (other comment)
Same as #18
60 (other comment)
Will implement together with #31
61 (other comment)
Addressed in #95
62 (other comment)
Is this similar to #7?
63 (other comment)
Implemented as tag during the creation of patient with add
64 (other comment)
Will be solved by #21
65 (other comment)
Chaining of multiple commands. Unlikely to do for current iteration
66 (other comment)
Nuudle app is developed with typing preference in mind
67 (other comment)
Similar to #12
68 (other comment)
@lowjiefeng1998 (44 comments)1 (commented on others PR)
Should this be Hall-y instead of AddressBook? Also, should it be hall admin (according to the use cases) instead of hall leader? Similarly for the rest of the terms below.
2 (commented on others PR)
Should it be 'enters' instead?
3 (commented on others PR)
Hmm seems like there was an issue with Git. Could you keep the original line under 'Saving the Data'?
Also, could you update the command summary at the bottom of the UG as well?
4 (commented on others PR)
Should it be just 'in Hall-y', instead of 'in the Hall-y'?
5 (commented on others PR)
Should it be resident instead of person?
6 (commented on others PR)
Should this be a resident instead of a person?
7 (commented on others PR)
Nice! @schoolex can refer to this for #37 when implementing the CLISyntax.
8 (commented on others PR)
Should this be a series of instructions instead of a tip?
i.e. something like the edit command in the UG:
GENDER: must be either M or F
ROOM_NUMBER: must be >Block>_>Room Number>
9 (commented on others PR)
Should there be a space after the commas?
10 (commented on others PR)
Should it be 'listing all residents' instead?
11 (commented on others PR)
A very minor nit, but is there an additional linespace between the previous method and this method?
12 (commented on others PR)
Should GenderType type be a private variable as stated by the coding standards?
13 (commented on others PR)
Minor nit again 😟 . Is there an additional linespace between this if block and the previous one?
14 (commented on others PR)
Should the getEditPersonDescriptorDetails() in the file be updated also?
15 (commented on others PR)
Should this be GENDER_DESC_BOB instead?
16 (commented on others PR)
Should the "M" be GENDER_DESC_BOB instead?
17 (commented on others PR)
Would you consider adding a similar test for invalid gender as well?
18 (commented on others PR)
Would you consider updating the MESSAGE_USAGE in this class as well?
19 (commented on others PR)
Should the constructor of this class be updated as well?
20 (commented on others PR)
Minor typo here in the comments.
21 (commented on others PR)
I think we need this for the Jekyll project site.
22 (commented on others PR)
Should we standardise and use application instead of app since it is a formal document?
23 (commented on others PR)
Should be it designers instead of designer?
24 (commented on others PR)
Should it be document instead of documented?
25 (commented on others PR)
Should there be an additional fullstop?
26 (commented on others PR)
It doesn't really matter, but you can consider using event.getDescription().description as well.
27 (commented on others PR)
Okay for this is fine for now, but maybe you can check if the editedEvent and target events are unique before setting them into the list? Else you might get duplicates within the UniqueEventList.
28 (commented on others PR)
Nice!
29 (commented on others PR)
Is there a typo in the javadocs? editedEvent instead of editedPerson
30 (commented on others PR)
Hmm... this is okay, but do test with very weird user inputs - like if they insert spaces anywhere.
E.g. assign 6 1, assign 6 1, etc.
31 (commented on others PR)
Can consider doing a nullcheck on model too, similar to DeleteCommand.
32 (commented on others PR)
Neat! Can consider checking that residentIndex > 0 and eventIndex > 0 as well (either here or somewhere else).
33 (commented on others PR)
Hmm could you explain the TODO?
Based on my understanding, ModelManager updates the filteredPersonList during a add command because the user may have keyed in find X, followed by add Y - so the UI needs to reset back to the full view by updating the predicate.
34 (commented on others PR)
Can you do it in both? So its similar to UniquePersonList.java#setPerson
35 (commented on others PR)
Okay, try to keep this in mind while testing 😄
36 (commented on others PR)
Is this method named wrongly?
37 (commented on others PR)
Neat! You can consider going further with this type of test case: e.g. "1 1" (2 spaces between each 1).
38 (commented on others PR)
Sorry this should be target.isSameEvent(editedEvent) - they're slightly different.
39 (commented on others PR)
Should it be execute_assignResident_success() instead?
40 (commented on others PR)
Oh ya! I'm so sorry, I was wrong.
41 (commented on others PR)
Hmm... These 2 steps are not very clear.
My guess is that ListGroupCommand#execute gets the filteredpersonlist, then iterates through it and gets a set of student groups?
42 (commented on others PR)
Hmm... should we still keep the alternatives since there is only one design here?
43 (commented on others PR)
Should it be ......is called...and returns...?
44 (commented on others PR)
Sorry could you change this to make it clearer?
4. The `ListGroupCommand` calls `ListGroupCommand#execute()` *which* retrieves the list of all residents by calling `Model#getFilteredPersonList()`.
5. The `ListGroupCommand#execute()` iterates *through* the list...
45 (commented on own PR)
Hmm the old link generates a badge though. Using /actions/ doesn't generate a badge, but a link instead...
46 (commented on own PR)
Ohh I see. Sorry I misunderstood that.
47 (commented on own PR)
Okay! I updated it. Currently it's just dummy data. We should probably have a source of truth somewhere in the code to validate if the block numbers and room numbers are all valid (I'm thinking somewhere in preferences.json might be good).
48 (commented on own PR)
Okay done. Thanks!
49 (commented on own PR)
Okay, I have added a field to manage the list of attendees tot the Event class.
I didn't add the way to add students to the list yet - this is still a dummy implementation and there might be some design considerations you can make for associating persons to events (e.g. unmodifiable lists, etc).
50 (commented on own PR)
Might need change this implementation to also compare the attendees list
51 (commented on own PR)
Similarly, not sure if this hash will take into account 2 events with same name, description, but different attendeesList (or that it doesn't matter).
52 (commented on own PR)
We should. Doesn't really make sense to have just the alternatives with no explanation.
53 (commented on own PR)
Okay! Fixed it after our standardisation - to keep all return arrows.
54 (commented on own PR)
Good catch! Fixed 😄
55 (commented on own PR)
Sorry! Fixed.
56 (commented on own PR)
Seems that requireAllNonNull() checks all items as well. Refer to UniquePersonList.
57 (commented on own PR)
Oops.
58 (other comment)
Closing this, since it is part of the tutorial. Will not be merging unless we decide to drop address.
59 (other comment)
Closing this, since it is part of the tutorial. Will not be merging unless we decide to add Remark.
Need to verify if the tP tracker will still pick this up if the PR is closed. Do reopen if the tP tracker requires the PR to be open for grading.
60 (other comment)
Closing since AB3 already implements this feature. Do make sure if that the feature works with the updates to #10.
61 (other comment)
Remove from milestone v1.2. Will consider adding this into milestone v1.3.
62 (other comment)
Oops I missed this out: could you also update the command summary section for the edit command too?
63 (other comment)
PR closed as I messed up Git. 😢
64 (other comment)
Closing this, since it is part of the tutorial. Will not be merging unless we decide to add Remark.
65 (other comment)
Not sure why the badge doesn't load when it's first loaded, but after refreshing, it loads? 😕
66 (other comment)
Closing. Has been completed.
67 (other comment)
Closing for now since the tP tracker says there are no references left.
DG might still have some (since the explanation of the code still needs to use AddressBook*.java), but that's fine.
68 (other comment)
Nice, thanks! 😄
69 (other comment)
EDIT: was part of #91.
70 (other comment)
EDIT: was part of #91.
71 (other comment)
EDIT: was part of #91 as well.
@ureshiiYing (44 comments)1 (commented on others PR)
I think you should keep "Developer".
2 (commented on others PR)
I checked again, and I think you missed out the find sales history feature under sales tracking.
3 (commented on others PR)
I agree.
4 (commented on others PR)
I think that this should be specified as a sub feature under list, so as to distinguish between all ingredients and a single ingredient.
5 (commented on others PR)
Perhaps this archive employees contact details section should be grouped with the other employee contact details features?
6 (commented on others PR)
I think this page will be continually updated, so we should include what we have done to the project so far - which would be the documentation section.
7 (commented on others PR)
For the ingredient levels, it would be good and clearer to state the unit of measurement. You could add this to the description or edit the examples to show this is the case.
8 (commented on others PR)
We are missing Feature 4.3 Find the sales history data based on date documentation.
9 (commented on others PR)
Remove the bullet points in this section to standardise the description field for the features. Instead of starting with a noun, start with a verb (once again to standardise across the UG). Eg. Set the level ...
10 (commented on others PR)
Since it's just one argument, requireNonNull(targetIndex) will do.
11 (commented on others PR)
I think we should keep both. They will both be Phone objects, but with different prefixes.
12 (commented on others PR)
Perhaps you can use requireAllNonNull(...) instead.
13 (commented on others PR)
Should this be using .equals method instead to do the check?
14 (commented on others PR)
You are missing empty lines in between the methods.
15 (commented on others PR)
IngredientList should not be under AddressBook, as AddressBook should only be in charge of contact details.
16 (commented on others PR)
Mismatched javadoc?
17 (commented on others PR)
As mentioned earlier, functions and features relating to ingredients tracking should be abstracted out to its own classes (instead of being in AddressBook).
18 (commented on others PR)
I assume this has yet to be implemented?
19 (commented on others PR)
Incorrect test case? Should these be all throwing assertion errors instead? They should not be called as it is a default model stub that have all of the methods failing.
20 (commented on others PR)
Should target be non null too?
21 (commented on others PR)
Requires change to fit ArchiveList
22 (commented on others PR)
Missing public attribute? Applies for all the other tests.
23 (commented on others PR)
Unnecessary white space?
24 (commented on others PR)
Is this an extra space?
25 (commented on others PR)
Command is an abstract class, no super constructor is needed.
26 (commented on others PR)
I think that perhaps naming the boolean isReset is better, so that there isn't a double negative. This is just a grammar comment.
27 (commented on others PR)
No need to use String.format if there is nothing to format.
28 (commented on others PR)
I think that they should be on the same line.
29 (commented on others PR)
I see,, then it makes sense to use isNotAlreadyReset.
30 (commented on others PR)
I think it is better to be placed on the same line to standardise with the other case statements.
31 (commented on others PR)
Should be Unarchives as the command is singular
32 (commented on others PR)
Is this an extra line?
33 (commented on others PR)
Grammar: It is equivalent to *the person being archived) OR (having archived the person).
34 (commented on others PR)
Could be better phrased as: "A Person whose archive status is true"
35 (commented on others PR)
Similar to the above comment
36 (commented on others PR)
Perhaps it should be views because a command is singular.
37 (commented on others PR)
Can be combined by using requireAllNonNull, however, this is also fine.
38 (commented on others PR)
Extra line
39 (commented on others PR)
This can be placed in one line
40 (commented on others PR)
spelling: should be archive
41 (commented on others PR)
The command is s-update. Additional there should not be a colon after the command word.
42 (commented on others PR)
extra fullstop
43 (commented on others PR)
Oh, I am referring to the description. It should be "views a single ingredient ... ", since the command word is singular
44 (commented on others PR)
I think it is better to keep it in one line, so that it is standardised with the other case statements.
45 (other comment)
LGTM
46 (other comment)
LGTM
@jh123x (43 comments)1 (commented on others PR)
I don't think this line need to add UC2?
Might be better to change it to:
2 (commented on others PR)
List of Food that user has added works too
LGTM
3 (commented on others PR)
Just curious, what does this affect for the main page?
It kinda looks like a link to the repo like github.com/se-edu/addressbook-level3 and github.com/AY2021S1-CS2103T-W17-3/tp
4 (commented on others PR)
Yes need the space after the ##
5 (commented on others PR)
Might want to change this to a constant?
Like VALID_NAME_AMY, similar to the one u did in edit command test
6 (commented on others PR)
Ookie in that case LTGM
7 (commented on others PR)
I think we should use this.class.getName() instead and put it in the Macronutrient class and use it for each of the food items?
Might be able to clear up quite a few of the other assertions and methods mentioned below in Macronutrient
8 (commented on others PR)
Might not need this if we can get the nutrient type using the method mentioned in Carbohydrates.
9 (commented on others PR)
This link might need to be changed in the future
Might be better to remove for now?
10 (commented on others PR)
Might be better to put it into a method rather than just declaring
Can use @Before to initialise the fridge to reduce the complexity of layering the different test cases on top of one another (This might help if we decide to change/add more test cases in the future)
@Before
public void beforeEachTestMethod() {
System.out.println("Invoked before each test method");
}
11 (commented on others PR)
Might wanna remove this whitespace for consistency
12 (commented on others PR)
Might be able to use CommandTestUtil here to reduce code duplication.
Can compare the tags after the CommandTestUtil.assertCommandSuccess
13 (commented on others PR)
I think there is alr a similar method in the current version
14 (commented on others PR)
I think the standard for 2103 uses 8 spaces instead iirc. Same for Food.toString method
15 (commented on others PR)
I think the test convention for other test cases are like getCalories_isCorrect or smth like that x.x
16 (commented on others PR)
^^ Same comment as Joey
17 (commented on others PR)
Might be better to abstract this.protein to getProtein(), same for carbs and fats
18 (commented on others PR)
Might want to change like the names to something more food-related >>
19 (commented on others PR)
Sorry I meant case insensitive >>
20 (commented on others PR)
Oo yea true. rip idk what i was thinking when i vetted x.x
21 (commented on others PR)
Might be better to use regex to check if it is of the correct format first rather than having an empty catch clause?
22 (commented on others PR)
Nice color 😄
23 (commented on others PR)
Hmm true.
But I rmb hearing somewhere in 2103 that empty catch clause is bad thou.
24 (commented on others PR)
Hmm ookie
25 (commented on others PR)
Might want to add some test for editing the date in the future
26 (commented on others PR)
Can add some assertions here regarding calling the function when it is unable to undo
27 (commented on others PR)
Is this for it keeping the same filter after the edit of the food?
28 (commented on others PR)
I think it should be throw DataConversionException here?
29 (commented on others PR)
I think its the same thing here?
30 (commented on others PR)
and here?
31 (commented on others PR)
I see
32 (commented on others PR)
This line will need to change to MacroList
33 (commented on others PR)
This line too
34 (commented on others PR)
This line will need to change to fit Macro Context
35 (commented on others PR)
Maybe remove the initialiazation and just assign macro = source.getAsList().stream().map(JsonAdaptedMacro::new).collect(Collectors.toList())
36 (commented on others PR)
Hmm I see
37 (commented on others PR)
I think its good to add an assertion if the food to be removed does not exist as checking for existence should occur before actually removing the food.
38 (commented on others PR)
Something along this line instead?
var predicate = filteredFoodItems.getPredicate();
newList = listOfFoodSomewhere.stream.filter((x) -> !predicate.check(food)).collect(Collectors.toList());
setMcGymmy(new McGymmy(newList));
39 (commented on others PR)
I think you haven saved this file to the .png format yet
40 (commented on others PR)
I think it is to confirm that the code is working when we run it with assertions.
The if statement below is to make sure that there are no errors in case we miss some paths / did not run with assertions
41 (commented on others PR)
the filtered list is implemented in Model so I think it will be better to implement in model instead of in Fridge.
Can be a possible future optimization
42 (commented on others PR)
I think it will be better to put the food item as a Parameter instead of optional?
If all of them are optional the user can just get away with using just find unless there is some form of a check to ensure not all of them are empty
43 (commented on others PR)
Oh ok, I see. I think we can mention that in the DG and no changes will have to be made.
44 (commented on own PR)
What do you mean by this?
45 (commented on own PR)
Ookie Thanks
46 (commented on own PR)
Simplified similar to how Kamil did it
47 (other comment)
Tags and Addr not implemented as they will be removed by the end of the iteration
48 (other comment)
Will make this a not draft after I add some tests or something maybe
The code is mostly formatting text to be printed so I don't think unit tests will benefit it much
Might need to change the logger message in ui/HelpWindow.java and remove the function that shows the help screen
49 (other comment)
Error in Merging Master Branch Closing PR
50 (other comment)
https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request-with-git
For pulling it into your local Repo
51 (other comment)
Something similar already exists in ModelManager.
Refer to ModelManager
52 (other comment)
Duplicated Feature
53 (other comment)
Merged to Update Developer Guide Branch
54 (other comment)
Adding extra stack to store predicate for filtering
55 (other comment)
bug found
56 (other comment)
bug found
What is the bug
The one where the TypicalFoods was mutated in between the test on the Mac CI
Joey Found and mentioned in the Whatsapp Grp earlier today
@UncleGrandpa925 (43 comments)1 (commented on others PR)
I think you pattern did not match our command. Here is my suggestion:
(?>type>[A-Z]\s+)?(?>commandWord>\S+)(?>arguments>.*)
2 (commented on others PR)
Maybe we rename this class to Contact now?
3 (commented on others PR)
Ahh I see, just add another \ before each of the current
4 (commented on others PR)
I think this should be kept simple, for example: "Adds a contact to the app" . This applies to all of your messages
5 (commented on others PR)
You're missing the "T " prefix before the COMMAND_WORD here and at the example a few lines below too 😄 This applies to all 5 of your commands
6 (commented on others PR)
I think the example for time here should have hour:minute as well, we'll support that too
7 (commented on others PR)
As discussed, I think this should return a task's to string, and view it by Id! We won't have any find command
8 (commented on others PR)
After coding I think that all of these "notes" like things should be called "notes" with a prefix of "note/", and this field is purely optional. What do you think?
9 (commented on others PR)
for my iP I have written quite a nice date parser here, I think you can adapt it to this part (and add more supported format too)
10 (commented on others PR)
this comment here is quite obvious right? I think can just write it as "Parses a Remark"
11 (commented on others PR)
As I have commented on ViewTaskCommand, this should be modified accordingly
12 (commented on others PR)
Ah my bad, by index
13 (commented on others PR)
yeah I know, but like I want to create a special prefix for the note-like stuff, for users to throw anything they want into it
14 (commented on others PR)
Okay then maybe you create an issue for that?
15 (commented on others PR)
okay sure!
16 (commented on others PR)
okay!
17 (commented on others PR)
the Task.Type is missing here 😄
18 (commented on others PR)
Missing Tash.Type here too!
19 (commented on others PR)
should we merge Location into Remark now?
20 (commented on others PR)
Not Email right?
21 (commented on others PR)
Just wondering, is there any better way than manually checking 5 fields to see if they are null or not? I think there is a requireNotNull method as well right?
22 (commented on others PR)
not String right? desc has type of String but for the message it should be Description
23 (commented on others PR)
Not Double.class.getSimpleName() right? It should be Weightage
24 (commented on others PR)
Okay sure
25 (commented on others PR)
Yeah but for the message you can't output like "missing a double", better to just replace it by "Weightage" (a String) since the Double.class.getName() is basically get the name of that class
26 (commented on others PR)
Hmm should we edit the module by index? or should it be index?
27 (commented on others PR)
We haven't agreed on whether a task must be associated with a module or not right?
28 (commented on others PR)
Should we merge location into remark now?
29 (commented on others PR)
Should it be to switch to the module tab now?
30 (commented on others PR)
love this simplicity 👍
31 (commented on others PR)
actually it will like expand the task (view in greater details)
32 (commented on others PR)
Now I think we should rename it to view
33 (commented on others PR)
for this, is it better if we have the type like lec (for lecture), tut(for tutorial)?
34 (commented on others PR)
"the length of the Lesson list" sounds a little unnatural, maybe "the number of lessons"?
35 (commented on others PR)
not of that type right? now we changed to deleting by index already
36 (commented on others PR)
same here, maybe "the number of lessons"?
37 (commented on others PR)
why do you need to check Task.isValidString here? I thought only the latter check is necessary?
38 (commented on others PR)
I think the remark doesn't need any kind of validity checking right?
39 (commented on others PR)
Hmmm I think this is fine but later on probably I will abstract this thing to the "common" module
40 (commented on others PR)
LOL It just crossed my mind, I think this is better as isDone (shorter and more "grammatically" correct haha)
41 (commented on others PR)
hey this should be isComplete haha. A trick to faster change the name of a variable is to use Find and Replace haha
42 (commented on others PR)
I think this method can be named like "flipDoneStatus", I think it will be a more intuitive name right?
43 (commented on others PR)
yeah store it as an empty string is better
44 (commented on own PR)
My bad😢
45 (commented on own PR)
True
46 (commented on own PR)
Hmm I have removed this class already?
47 (commented on own PR)
Ah okay not yet, my bad
48 (commented on own PR)
Can you take a look at my new PR?
49 (commented on own PR)
If that PR is good then can merge it first, so that there won't be too many commits in a PR
50 (commented on own PR)
Okay I forgot. Actually the original code doesn't explain the returned result too (maybe too obvious?)
51 (commented on own PR)
Yeah, since originally there were setContact and setContacts as well
52 (commented on own PR)
the original code base doesn't have that throw as well. What do you think? (Honestly I haven't read about when we should state that this method will throw something and when we can just omit it). Anyway, will read it later on after I finish developing these 3 classes
53 (commented on own PR)
I think we should best leave it as TrackIter (short,concise name). LOL It took me 1,5 hour to rename address book to TrackIter 😂 (And still there are a lot of leftovers)
54 (commented on own PR)
Fixed in the latest commit
55 (commented on own PR)
Okay lemme fix it now
56 (commented on own PR)
When I thought on how to handle the program's logic, I found out that putting lessons and tasks in Module will make it way harder to find/delete tasks & lessons. Instead, I think that we just keep lessons and tasks in separate lists and everytime we need to find lessons or tasks of a module, we can just do a O(n) search. This will make the program's logic much simpler and less prone to errors
57 (commented on own PR)
Yes. Is just a more detailed type of exception, so it doesn't need any implementation
58 (commented on own PR)
It will be fixed in the next PR!
59 (commented on own PR)
Wow I think this is a bug happend when I'm copying things
60 (commented on own PR)
fixed!
61 (commented on own PR)
Ah okay okay let's enable it
62 (commented on own PR)
@simonteozw Maybe you approve this PR first then I make another PR? I just run the code formatter and it changed like 80 files
63 (commented on own PR)
Actually I wrote the message for this exception already, but then deleted it because the exception caught on the very next line. Should I comment on why I leave that message empty or just write a message in it?
64 (commented on own PR)
done!
65 (commented on own PR)
this the auto toString method generated by IntelliJ. It will be used for testing only so I guess it's best to stick to the default format
66 (commented on own PR)
for testing only
67 (commented on own PR)
Sure
68 (commented on own PR)
There is a warning that the operator (like + for string concatenation) must be on a new line, but I haven't found a way to make IntelliJ auto-format for that, and it's really minor so I will just disable it for now
69 (commented on own PR)
Hmm because I haven't been able to get the IntelliJ to conform to this rule, and this is very minor (it's just the position of the operator) so I think it's best to disable it for now (if not forever)
70 (commented on own PR)
No it's a good thing to keep, why need to remove right?
71 (commented on own PR)
Yes, because as we have discussed this will be a "bonus" feature. I just leave it there so that later on we remember
72 (other comment)
Yes, I realised it too but I forgot to raise it up during yesterday's meeting! Will send Simon another PR.
Ah I resolved it already! Forgot to close this issue
73 (other comment)
@simonteozw can you review this commit then merge it for me so that the next PR won't be so huge
74 (other comment)
Actually "commons" in the name of one of the current module too! (seedu.address.commons)
75 (other comment)
Ah that checkstyle, I think it can be disabled for now, later on when I merge the later pull request I can enable it back again! Actually we can do cherry-pick there but I haven't had time to properly learn cherry-pick
76 (other comment)
@nguyendqminh can you take a look at my message above and provide me the deadline that you will resolve this? Thank you!
77 (other comment)
@simonteozw Hey can you take another look? If it's good then you can approve it so that I can make the final PR for Lessons
78 (other comment)
@nguyendqminh Hi, any updates on this?
79 (other comment)
@nguyendqminh Can you push your commits to the PR so that the team can know your progress? Thank you!
80 (other comment)
@simonteozw Hey. I think this PR is quite simple but I think it's best to have you do a quick review of it! Thank you!
81 (other comment)
@simonteozw this can be closed now right?
82 (other comment)
Closing #109
@hopinxian (42 comments)1 (commented on others PR)
I think that to match prefix, the e.g. would be sth like list l/people, list /stats. Please check on this.
2 (commented on others PR)
Might want to refer to this as Virus Tracker instead of AddressBook.
3 (commented on others PR)
Might consider changing to 'Clears all entries from Virus Tracker' to match description in line 42.
4 (commented on others PR)
It appears that you have added some new functionality here regarding some statistics. Can these be used already?
5 (commented on others PR)
Considering the nature of this test, it might be best that the method updateFilteredLocationList is completely removed from the working program since it is not expected to be called.
6 (commented on others PR)
Additionally, on this aspect, I realised that updateFilteredLocationList is a method newly added to Model and ModelManager. Considering that, may I check why is the method added if it is not intended to be called as seen from this test?
7 (commented on others PR)
I understand now. Thank you for the clarification.
8 (commented on others PR)
To keep the code clean, I feel that this line should either be uncommented or removed.
9 (commented on others PR)
Ids are abstracted away from the user. Users should not be aware of Ids, and thus should not be given the opportunity to change the id of a person. I feel that thus editpersondescriptor should not have an id field and id is automatically retrieved from the person that is being edited.
10 (commented on others PR)
Some additional tests can be conducted in this class. Such as tests for adding unidentifiable locations and tests for setting location lists which dont fulfill the identifiable property. You may refer to #118 UniqueLocationListTest for reference.
11 (commented on others PR)
One more test was missed.
12 (commented on others PR)
To abide by SLAP principle, consider abstracting out different parts into a separate methoda in the same class.
For e.g. line 50 to 62 can be abstracted into a separate method
13 (commented on others PR)
The "..." seems to imply that the command can accept multiple personids. Is that intended?
14 (commented on others PR)
You have made tests that dealt with the edge cases. It would be good to have additional tests that prove the success of the command. In this case, it would be giving an infected person and confirming that the generated results are the expected results.
15 (commented on others PR)
Could this perhaps be shifted to info handler class? This can help to keep calculation and information handling methods consolidated in one place.
16 (commented on others PR)
This code is quite long. May I suggest extracting part of it into another method? This is a suggestion in accordance to single line of abstraction.
17 (commented on others PR)
You have added tests capturing failing conditions. May I suggest tests that confirm success conditions as well?
18 (commented on others PR)
Is this possibly a spelling error? Form or From?
19 (commented on others PR)
Perhaps some documentation or name changing could be done? Its hard for me to directly understand the significance between 60 percent and the visits chosen.
20 (commented on others PR)
This test feels like it might be more appropriate elsewhere. This is a class for tests involving location as itself. Perhaps this test might belong to a info handler or for a class that directly implements this.
21 (commented on others PR)
Perhaps these methods could be shifted to info handler class? This can help to consolidate all information handling methods to one class.
22 (commented on others PR)
Suggest using a comment block instead of multiple single line comments.
A comment block looks like this.
/*
some comment
more comments
*/
23 (commented on others PR)
Suggest putting both comments in 1 line rather than having multiple single line comments.
24 (commented on others PR)
This method seems very similar to the above method getTypicalLocations. I feel that since both methods are used in test cases, naming this method getLocationsForTest doesnt differentiate the purpose of the 2 methods. Perhaps naming it as getUnorderedTypicalLocations() would be better?
25 (commented on others PR)
This method seems very similar to the above method getTypicalLocationBook. I feel that since both methods are used in test cases, naming this method getTypicalLocationBookForTest doesnt differentiate the purpose of the 2 methods. Perhaps naming it as getUnorderedTypicalLocationBook() would be better?
26 (commented on others PR)
identical visits here, resulting in error.
27 (commented on others PR)
I think that there is no need to create a separate exception for wrong date. Instead, parseException should be used.
According to the code in Parser class, any exceptions or mistakes in the input is returned in a ParseException. In this case, we can save on a class whose implementation is identical to ParseException.
28 (commented on others PR)
I think this message can be replaced with the MESSAGE_INVALID_DATE_FORMAT constant from Messages.java.
29 (commented on others PR)
With the comments above, this can be implemented as a single line instead.
date = ParserUtil.parseDate(argMultimap.getValue(PREFIX_DATE).get());
30 (commented on others PR)
Sure. Understood
31 (commented on others PR)
Instead of having this, suggest importing the message from Messages.java
32 (commented on others PR)
please revert back to a single line
33 (commented on others PR)
Sorry, please ignore this.
34 (commented on others PR)
done by direct editing of file.
35 (commented on others PR)
Please refer to it as index rather than id. Reminder that ID is a concept that is hidden from users.
36 (commented on others PR)
Suggest to replace with the assertThrow from Command utils
37 (commented on others PR)
Suggest to replace with AssertThrow from command utils
38 (commented on others PR)
This test is repeated and ought to be deleted.
39 (commented on others PR)
Repeated tests are detected here.
40 (commented on others PR)
Repeated tests are detected here.
41 (commented on others PR)
Please change this to index instead of id. Only index number is exposed to the user.
42 (commented on others PR)
Suggest replacing with an existing method inside command utils that handles commands. The method name is AssertCommandSuccess()
43 (commented on own PR)
Spelling error is intentional for the invalid person.
44 (commented on own PR)
Have added additional assertions.
45 (commented on own PR)
Have changed the method name
46 (commented on own PR)
Thanks for the catch! I have updated it.
47 (commented on own PR)
This copy of valid visit is hard coded, by using the visit builder class. The hard coded values are retrieved using the getOneBased method. Valid visit has no direct reference to filtered visit at all.
The gist of this test is that my model's filtered lists for person and location currently store only 1 location with id 3 and 1 person with id 4. This is done using the showLocationAtIndex, showPersonAtIndex methods above. Im giving the model input using index 1 and index 1 for person and location, because the list user sees contains only 1 element. After processing however, I am expecting the visit to point to ids 3 and 4 respectively. This is done by comparing the final visit from the visit list with the expected visit created using valid visit.
48 (other comment)
isnt this repeated with #19?
49 (other comment)
isnt this repeated with #18?
50 (other comment)
Pull Request Approval:
Before approving any pull requests, please ensure the following is done.
Eyeballing the code for any possible logic or other errors. This is also to familiarise yourself with implementation of the system.
Pull the pull request down into a local branch and give the features a test run. This is to check whether it actually works since eyeballing code may not be fool proof in ensuring functionality.
51 (other comment)
In addition, you might want to update the details of the pull request if it does indeed include some functionality involving the daily statistics. This is on the assumption that it is included.
52 (other comment)
Pull request was merged using Admin powers without going through 2 approvals.
However, noted that I would have given approval after the recent commits, so no harm done. Please be careful in the future though.
53 (other comment)
Thanks for the review. I have improved the Pull Request according to your comments.
54 (other comment)
Suggest to merge visit id fix PR first #136 and see if any of the tests crash for this particular PR.
If none crash, I will automatically give my approval for merging this.
55 (other comment)
Shall be closed as participation has already been counted and PR is not relevant for VirusTracker
56 (other comment)
Shall be closed as participation has already been counted and PR is not relevant for VirusTracker
57 (other comment)
Shall be closed as participation has already been counted and PR is not relevant for VirusTracker
58 (other comment)
Shall be closed as participation has already been counted and PR is not relevant for VirusTracker
59 (other comment)
Shall be closed as participation has already been counted and PR is not relevant for VirusTracker
60 (other comment)
Completed by #126
61 (other comment)
Hi everyone, please help run a few test runs with the application.
Pull from this branch into a local branch and run a few methods that you created for the application. This can help confirm that the application has not bugged out or lost any functionality during refactoring.
62 (other comment)
This merge does not implement a WrongDateFormatException.
Instead it throws a ParseException that represents a wrong date format.
63 (other comment)
Resolved by #161
64 (other comment)
Resolved by #161
65 (other comment)
We noted that this implementation presents the following bug where an update to a person/location name does not correspondingly update the name of the person in the visit. This will be resolved in a future update.
66 (other comment)
Due to the wide ranging impact that this change could be bring, this is deemed as a prerequisite issue that should be resolved as soon as possible before other pull requests.
67 (other comment)
This pull request is ready for merging.
68 (other comment)
While all effort has been made not to regress VirusTracker in this PR, because ID is used widely across all aspects of the VirusTracker, it is recommended that all teammates check through the tests and functionality in detail for any breaking of code or bugs.
69 (other comment)
Users will be expected to prepend their own data with prefixes before importing data. This could be something we can look into for further enhancements.
Rationale for using prefixes: To avoid autoformatting which may lead to effects like removing leading zeros. Adding prefixes ensures that a CSV that was exported can be imported without changes to another program.
@luo-git (42 comments)1 (commented on others PR)
Maybe you can use an empty line instead of using >br>
2 (commented on others PR)
There is an extra >br> at the end, which will increase the gap between this line and the Acknowledgement. Is it intended?
3 (commented on others PR)
Should there be an extra white line here?
4 (commented on others PR)
Maybe there shouldn't be a > here?
5 (commented on others PR)
I think you broke some of my parts. You can review this markdown file again to find out more.
Before
After
6 (commented on others PR)
I have night mode enabled so it is more obvious.
7 (commented on others PR)
There's still something wrong here.
8 (commented on others PR)
Did you change the package name to fileAddress?
9 (commented on others PR)
Shouldn't it still be tag?
10 (commented on others PR)
Maybe can replace person with tag in the message as well.
11 (commented on others PR)
Should the person package be renamed to tag?
12 (commented on others PR)
This may not work later because of the FileAddress field. Maybe add a //Todo here for reminder.
13 (commented on others PR)
JsonAdaptedTag was used to store tags for person. For now shouldn't it be deprecated since we do not have that functionality?
14 (commented on others PR)
Is it really person details?
15 (commented on others PR)
Is this println for debugging?
16 (commented on others PR)
Should this be "Tags list contains duplicate tag(s)."?
17 (commented on others PR)
Is this for debugging?
18 (commented on others PR)
This may not work. But for now it's okay.
19 (commented on others PR)
This may not work. But for now it's okay.
20 (commented on others PR)
For now it's okay. This will be looked at again by the Logic team.
21 (commented on others PR)
Are these tests no longer working?
22 (commented on others PR)
Extra spaces here.
23 (commented on others PR)
Are these 3 variables no longer independent Ui parts?
// Independent Ui parts residing in this Ui container
24 (commented on others PR)
Maybe the name of the variables here could be changed?
25 (commented on others PR)
Maybe "valid" file path?
26 (commented on others PR)
Could this be changed to a more sensible tag name?
27 (commented on others PR)
Should there be empty lines here?
28 (commented on others PR)
"Person" should be predicate here?
29 (commented on others PR)
Method name should be test_keywordMissing_returnsFalse?
30 (commented on others PR)
This validation regex is for names. Should this be dropped?
31 (commented on others PR)
Should this class be named ObservableFileList?
32 (commented on others PR)
The file can be changed to HelloFile.jar?
33 (commented on others PR)
Displays
34 (commented on others PR)
managed tag names -> managed tags?
35 (commented on others PR)
"Renames a tag's name"?
36 (commented on others PR)
Typo in design?
37 (commented on others PR)
Absolute path is already ensured in TagCommand, but its still okay to get absolute path again here I think.
38 (commented on others PR)
I get it now.
39 (commented on others PR)
This part should not be changed. This are the default tags when HelloFile is launched the first time. We might want to keep this list empty?
40 (commented on others PR)
Should there be an empty line here?
41 (commented on others PR)
This edit is not correct? TagCommand do check if the file is present using java.io.File.exists().
42 (commented on others PR)
What?
43 (commented on own PR)
Roger that
44 (commented on own PR)
We need to change all the entities in testUtil.
45 (commented on own PR)
It's not a typo, it's a real word =)
conform
/kənˈfɔːm/
verb
comply with rules, standards, or laws.
46 (commented on own PR)
I find that without "\n" the format is very hard to read, so I added them.
47 (commented on own PR)
That's going to be more readable in my opinion.
Right now the tag command is like this. You cannot distinguish tag name and file address easily.
48 (commented on own PR)
Ok will change that
49 (commented on own PR)
I don't think we will be doing manual testing anymore. Moreover, this appendix is for us to read and probably not suitable to be included in DG.
50 (other comment)
test
51 (other comment)
Resolve #36
52 (other comment)
Hi Heinrich, could you make a stub so that we can use it to work on Logic? Thanks.
53 (other comment)
Yes! I think that will be good.
54 (other comment)
Looks good. Is it possible to have a toggle for this theme?
You mean something to switch to different themes?
Yup
55 (other comment)
Cd can change current address.
Format:
cd f/absolute address
cd p/
cd c/child_folder_name
56 (other comment)
Getter and setters
57 (other comment)
FindCommand can have t/, d/ or (t/ and d/).
58 (other comment)
Alternative
cd f/absolute address
cd ../
cd ./
59 (other comment)
Can't really check the UML..but LGTM!
You can use "view file" at the top right corner to see the markdown file.
@seanjyjy (42 comments)1 (commented on others PR)
small issue maybe it should be example instead of examples?
2 (commented on others PR)
same issue here
3 (commented on others PR)
there seem to be some inconsistency here. do you mean JOB_TITLES instead?
4 (commented on others PR)
do you mean job_title
5 (commented on others PR)
I think what Shawn said makes sense. It might be better to stick to terms that are already established eg InternshipStatus. If I am not wrong does the status class exist only for Internship? If that is the case, maybe you can consider shifting date to the Internship object instead and as such, there won't be any ambiguity in the naming.
6 (commented on others PR)
small typo
7 (commented on others PR)
might want to maintain consistency with other files where you leave a line at line 9 for this class.
8 (commented on others PR)
there shouldn't be a return
9 (commented on others PR)
I realized that some javadocs there's full stop while some there aren't.
10 (commented on others PR)
If most to all parser requires these static final int variables, we could shift it to avoid duplicates. However, I am not sure if it is apt to shift it to an interface. Can consider having a Util class for it.
11 (commented on others PR)
the parameter should have a space
12 (commented on others PR)
I am wondering if since the Internship has been categorized into InternshipCliSyntax, perhaps this could be also categorized into ItemCliSyntax, or were u planning to convert this class into that in the future?
13 (commented on others PR)
hmm i am not sure which "style" we want to stick to but shawn has another way of writing this InternHunter detects an error in the input format . We might want to stick to one way in order for our DG to look cohesive.
14 (commented on others PR)
should use >br />
15 (commented on others PR)
should use >br/ >
16 (commented on others PR)
should use >br/ >
17 (commented on others PR)
Would it be weird if it is "viewing" the profile page? To be cohesive to our DG, You must be on the **profile** page ... sounds more cohesive to our precondition
18 (commented on others PR)
an exception should be only thrown when it is like not within the programmer's control? like missing files or user input. Since it is a controlled environment, using assertion is more apt. It's from oracle java assert.
19 (commented on others PR)
Small issue, can put /todo for future.
20 (commented on others PR)
not totally sure how regex works but from the description are you rejecting # and +?
21 (commented on others PR)
do remember to add in javadocs in the future
22 (commented on others PR)
do include the @throws.
23 (commented on others PR)
do remember to add in javadocs in the future
24 (commented on others PR)
just a suggestion, @line 38-39
from GitHub this line looks quite long, you can consider having
boolean b1 = ...
boolean b2 = ...
if (b1 || b2)
25 (commented on others PR)
oh, but I think keane/shawn side is allowing the use of those though! it might be confusing for the user ? can either @keanecjy @shawn-nyk confirm this?
26 (commented on others PR)
@throws missing
27 (commented on others PR)
@throws missing
28 (commented on others PR)
InternshipTitle instead
29 (commented on others PR)
might want to change the variable name for clarity
30 (commented on others PR)
Internship titles should only ...
31 (commented on others PR)
might want to change it to INTERNSHIP_TITLE_DISPLAY_NAME
32 (commented on others PR)
just a minor question but is there a need for this if block? I think we could just shift it into the if-else block. However, if this is a better coding standard, then I think we can stick to this.
33 (commented on others PR)
oh if this the case, I believe the current code is a better option
34 (commented on others PR)
I realized for constructors, in our main code, we use Creates, so maybe we could stick to the same javadocs for cohesiveness
35 (commented on others PR)
Maybe can just remove the InternshipItemUtil class which and just be Provides the string used in ... ? or perhaps A utility class that provides ...
36 (commented on others PR)
Sorry may I know what's the difference between COMPANY_OUTPUT_NAME and PERIOD_OUTPUT_NAME
could they just be summarized intoCOMPANY_NAME = "Company Name: "
37 (commented on others PR)
sry whats the difference between space and blank
38 (commented on others PR)
Dont forget to remove the Sout
39 (commented on others PR)
We were discussing this previously and we decided that this allows an easier skill matching.
Because the user can key in any type of requirements which can be very long will definitely render the skill matching useless.
40 (commented on others PR)
Should we stick to how other messages are done, I realised we are missing the Parameters: ...
Might break some test cases message.
41 (commented on others PR)
I think now we can do model.getFilteredProfileListSize(). Do you mind helping me and shawn change that portion
42 (commented on others PR)
Same here can help to change to getFilteredApplicationListSize()
43 (commented on own PR)
Yup, It might be more consistent to change the type to category.
44 (commented on own PR)
Thanks, @keanecjy will add the missing information. Maybe it might be more apt for us to put it as "what our app manages" under introduction
45 (commented on own PR)
Yup we could keep it simple currently and once we merge them in the future, we could include those extensions.
46 (commented on own PR)
perhaps once we merge the similar use cases together, we can include more extensions to it!
47 (commented on own PR)
hmmm, I am not very sure if it should be an exception instead. I was following the assert from oracle java.
The absence of a default case typically indicates that a programmer believes that one of the cases
will always be executed. The assumption that a particular variable will have one of a small number
of values is an invariant that should be checked with an assertion.
48 (commented on own PR)
Have fixed the java docs issues, thanks.
49 (commented on own PR)
I will resolve this conversation since we have concluded it.
50 (commented on own PR)
True I am not sure about which is a more appropriate wording.
51 (commented on own PR)
Thanks for the spot, will update it.
52 (commented on own PR)
Thanks for the clarification Shawn, what I meant as this naming is, Company & Application to have the same Information Width. I will do the relevant changes to make it clearer.
53 (commented on own PR)
Not very sure how to resolve this portion. Maybe I should a raw type parameterized instead?
54 (commented on own PR)
yup I think I should change this to setRequirements
55 (commented on own PR)
yup I think I should change this to setIndustries
56 (commented on own PR)
yup, I have fixed this
57 (commented on own PR)
yes, you're right. I will do a work around.
58 (commented on own PR)
Thanks for the advice, did not know there is such a thing.
59 (commented on own PR)
resolved in the latest push.
60 (commented on own PR)
resolved in the latest push.
61 (commented on own PR)
resolved in the latest push.
62 (commented on own PR)
Yes, i agree as well. I will help to reformat the rest of the parser
63 (commented on own PR)
While trying to reformat, I realized that We would need to know the Type of command in order to get its MESSAGE_USAGE. If we were to shift it to GeneralParserUtil, we would need to determine the Type of command and pass it as a a parameter into the static method in GeneralParserUtil. However, this determining of the type of command is already present in the parse command, as such we might be writing two switch cases. However, if we would want to write only one switch cases, we might have to change how the code would like like.
64 (commented on own PR)
Also from the way we coded previously, the switch case in the parse method would never go to the default case, we can do an assert false there? (Since the checking is already done in the checkCommandDetailsIsNotBlank)
65 (commented on own PR)
However, a method that is possible is that we will have to shift that checkCommandDetailsIsNotBlank into each of the cases in the switch method as well as introducing an extra parameter.
'''
public FindCommand parse(String args) throws ParseException {
String itemType = getItemType(args, FindCommand.MESSAGE_USAGE);
String commandDetails = getCommandDetails(args);
isValidItemType(itemType);
switch (itemType) {
case COMPANY_ALIAS:
checkCommandDetailsIsNotBlank(commandDetails, itemType, FindCompanyCommand.MESSAGE_USAGE);
//return new FindCompanyCommand(commandDetails);
return null;
case APPLICATION_ALIAS:
checkCommandDetailsIsNotBlank(commandDetails, itemType, FindApplicationCommand.MESSAGE_USAGE);
//return new FindApplicationCommand(commandDetails);
return null;
case PROFILE_ALIAS:
checkCommandDetailsIsNotBlank(commandDetails, itemType, FindProfileCommand.MESSAGE_USAGE);
//return new FindProfileCommand(commandDetails);
return null;
default:
// Invalid item type
throw new ParseException(MESSAGE_INVALID_ITEM_TYPE);
}
}
66 (commented on own PR)
Sorry, I don't quite get what do you mean as throw the exception with the correct message.
67 (commented on own PR)
Sorry, I don't quite understand what do you mean about profile item having a general error message 😮
Issue
I reaslied this as well. For commands that are without the letter specifier, like
view me 1
delete me 1
It seems to have this special other error message generator.
And as a result, since find is somewhat the same, I try to extract this duplicated method from view and delete as well.
In comparison to other classes
I realised for the earlier commands like Add, the message is encapsulated inside each of the individual type of add commands instead, because they made used of tokenizer as its checker
While for the later commands like view and delete me, since we dont need to use the tokenizer, it seems like we generated another method for checking instead
68 (commented on own PR)
Is there anyway we can consolidate this issue. This is linked to the problem Keane and I was discussing in the post above. @AY2021S1-CS2103T-T15-4/developers
69 (commented on own PR)
So I take that we should format it such that delete, view, find should follow how add, edit does it?
70 (commented on own PR)
Ah, yes that is true, will make the relevant changes once we get our affirmation regarding the above dicussions
71 (commented on own PR)
oh this sounds great, will abstract it into messages.java then
72 (commented on own PR)
yeah i did thought about it, but it feels weird if we have to add in a condition for it LOL for whether to display the extra s. Hmm i think since we are dealing with a 1 vs Infinite amount, it feels like having the s should make sense right O:
73 (commented on own PR)
hmm, I think since this is a more towards only switch kind of command, I believe I should make a separate message then. Are there any other commands that have the same issue? I believe list and find as well right?
74 (commented on own PR)
Thanks for the spot
75 (commented on own PR)
I think I will temporarily put this as %1$d %2$s items found!
76 (other comment)
LGTM
77 (other comment)
#87
78 (other comment)
LGTM
79 (other comment)
LGTM
80 (other comment)
If we are planning to create other classes in replacement of person and address book, I don't think we need to change the Javadoc yet?
81 (other comment)
#48
#99
82 (other comment)
Hmm. The dilemma now is that this is just a proof of concept and we may be abstracting common logic down the line and scrapping all these, so overwriting Javadocs now may redundant. The danger is that if the code is kept and the comments are missed in the future. What is the team's opinion on this? @ZoroarkDarkrai @keanecjy @seanjyjy @shawn-nyk
I agree that overwriting Javadocs now may be redundant, especially because our code can change over time up until the final version. At the same time, I also agree that we may miss them in the future, and doing a one-time run-through of all our code at the end may be very tedious and error-prone. As such, how about we do something like: every time we create new bits of code that require Javadocs, or we modify code that already has Javadocs attached to them, we place a standardized comment, such as
TODO: Javadocsabove the code we need to write/edit Javadocs for? That way we get the syntax highlighting that IntelliJ provides for theTODOkeyword, and we can also search for this standardised comment throughout the code base to hone in on where we'll eventually need to write/edit Javadocs when the time comes. Any thoughts on this?
I think this is a great idea what do the rest think?
83 (other comment)
#104
#100
84 (other comment)
LGTM good job.
85 (other comment)
Hi, Fidella I think since you approved these changes I will just merge it in? Need this code currently
86 (other comment)
LGTM good job.
87 (other comment)
Can add the todo or javadocs and it is good to merge.
Which file/line are you referring to?
DeleteProfleCommand class and maybe its constructor? incase forget in the future
88 (other comment)
Will merge this first
89 (other comment)
LGTM
90 (other comment)
LGTM
91 (other comment)
LGTM
92 (other comment)
Besides the point that @keanecjy has raised, I believe it is good to merge after it is resolved.
93 (other comment)
LGTM
94 (other comment)
the link seems to be still broken. From the html file side
95 (other comment)
the link seems to be still broken. From the html file side
Sorry my mistake
96 (other comment)
LGTM
97 (other comment)
LGTM
98 (other comment)
LGTM
99 (other comment)
LGTM
100 (other comment)
LGTM
101 (other comment)
LGTM
102 (other comment)
LGTM
103 (other comment)
LGTM
104 (other comment)
#25
105 (other comment)
LGTM
106 (other comment)
LGTM
107 (other comment)
Overall LGTM to merge, just need to fix the image link. Think there is a typo in the png file itself
108 (other comment)
Just some comments for you to consider, not very sure if it is right or wrong.
For sd execute edit me command, you might want to include what is return in the getProfileList() perhaps.
And for void methods like setItem and setProfileItem i believe the return arrows could be omitted as it doesn't bring any value and it does help to reduce cluttering.
However, if you think that it is fine, then do let me know as it is good to merge already.
109 (other comment)
LGTM. Good job
110 (other comment)
LGTM
111 (other comment)
LGTM
112 (other comment)
UC 07 seems to be broken in terms of formatting
113 (other comment)
I just realised, but just for plausible consideration, should we add-in extension for deleting companies that indicate internships being deleted as well as its application.
@khoodehui (42 comments)1 (commented on others PR)
Perhaps can add a description saying that this is the constructor?
2 (commented on others PR)
Should be project book instead of address book.
3 (commented on others PR)
Same here too as above comment.
4 (commented on others PR)
Perhaps there should be a whitespace after the slashes?
5 (commented on others PR)
Yup think it will better to describe that it will construct a new project, just like the javadocs in other classes.
6 (commented on others PR)
Will it be better to give an example of how the ISO8601 time format looks like in the error message? A user might not know what this format is.
7 (commented on others PR)
Should have a new line before the param.
8 (commented on others PR)
Think the persons here should be timers instead.
9 (commented on others PR)
Should have a new line after the description. Same for the 2 methods above.
10 (commented on others PR)
Newline after description.
11 (commented on others PR)
Extra line here should be removed.
12 (commented on others PR)
Extra asterisk here should be removed.
13 (commented on others PR)
Newline after description.
14 (commented on others PR)
Newline before method.
15 (commented on others PR)
Should we remove all the navigation commands first? Since they are not yet implemented.
16 (commented on others PR)
Description has been changed to an optional field.
17 (commented on others PR)
Should both name and description be optional fields here?
18 (commented on others PR)
I think we can indicate [coming soon] for this.
19 (commented on others PR)
I'm not sure if this section should be done by @boundtotheearth, since he implemented this and according to the tP instructions, it is recommended that features in the user guide should be written by the person who implemented it.
20 (commented on others PR)
Similarly, should we remove this first or indicate it as [coming soon]?
21 (commented on others PR)
Same as above, for Create and Update, some of the fields are/are now optional.
22 (commented on others PR)
Not sure if it would be better to rename this as 'Editing a project'? It might be more clear that the name of the feature is the same as the command.
23 (commented on others PR)
I think it should be. Because it doesn't make sense for the user to have to enter something for the name when they are not intending to change it. I think we might have made a mistake when writing this section of the user guide.
So the edit command will be like the addressbook's, where all fields except index are optional, but at least one of the optional fields must be provided.
24 (commented on others PR)
Same case for **Note:** here as above.
25 (commented on others PR)
Seems like markdown isn't converting **Note:** over here to bold. I think it's because it's embedded inside HTML. Try using >strong>Note:>/strong> instead.
26 (commented on others PR)
I think the asterisks here are causing Markdown to not format the table correctly.
27 (commented on others PR)
Newline before param
28 (commented on others PR)
Newline after description
29 (commented on others PR)
Code might be easier to understand if parseSortOrder() only returns the argument which the user entered in the command. Then under the variable declaration for isAscending(), do an equal() check to see whether the argument the user provided is equal to ASCENDING_ORDER.
This is so that the nature of the parseSortOrder() method is also consistent with that of the parseSortType() method.
30 (commented on others PR)
I think we should.
31 (commented on others PR)
Noticed that you have declared various form of SortCommands as private static final variables in SortCommandTest.java, and they are repeated here. Will it be better to just abstract all of the various SortCommands into a utility class, then have the test classes get the different commands from there.
32 (commented on others PR)
Accidental capitalisation here
33 (commented on others PR)
Line before param
34 (commented on others PR)
Line before param
35 (commented on others PR)
Line before throws
36 (commented on others PR)
Line before throws
37 (commented on others PR)
Line before throws
38 (commented on others PR)
Line before throws
39 (commented on others PR)
Line before throws
40 (commented on others PR)
Line before param
41 (commented on others PR)
Should the javadoc for this method and the one above be on just one single line?
42 (commented on others PR)
Should projects here be changed to trackedItems?
43 (commented on own PR)
Ok yup I agree with this. Will make the changes.
44 (commented on own PR)
I feel that it is ok to have this method as well as the hasDescription() method in the Project class, as a Project should be aware of the contents of its own fields and I can directly ask a Project whether it possesses these fields.
However, what you said sounds fine to me too. What do the others think?
@orzymandias (40 comments)1 (commented on others PR)
This was following the discussion yesterday, there is no view command for profile.
2 (commented on others PR)
Maybe it will be more consistent to change type to category?
3 (commented on others PR)
Also, I think this was left out in the issues, but the switch command can be added too
4 (commented on others PR)
Do you think it is good to be overly specific about the type of error? If so then there are many more extensions to include such as inputting an index that is not a number for example.
5 (commented on others PR)
I am unsure about this myself but what if there are no items in the list? what kind of interactions can the user and system have? I know your preconditions addresses that but do we have to consider the case where you call edit and there are no items in the list?
6 (commented on others PR)
Really minor a UI not an UI
7 (commented on others PR)
Should be an exception instead?
8 (commented on others PR)
Should be an exception instead since you are not testing an assumption?
9 (commented on others PR)
Should be an exception instead, since exceptional case
10 (commented on others PR)
The other JD comments are in the other PR, you can ignore them for now if you want unless you it is finalized
11 (commented on others PR)
Sure we can have a common package for the fields within model package but for unique fields with own regex, keep them in the feature's package.
12 (commented on others PR)
Minor nit, should be Sets in the Javadoc
13 (commented on others PR)
Same thing here. Minor nit, Should be "Sets"
14 (commented on others PR)
Same thing here -> Sets
15 (commented on others PR)
Change -> Changes
16 (commented on others PR)
Same minor nit Set -> Sets
17 (commented on others PR)
Set->Sets
18 (commented on others PR)
There are 2 more that require changing below:
Initialized
set
19 (commented on others PR)
Javadoc comments below as well for set.
20 (commented on others PR)
Perhaps its more appropriate a throw an exception here since assertions are mainly to check for precondition and post condition of function execution and testing assumptions. This usage fits neither and is more of an exceptional case?
21 (commented on others PR)
Same issue here ? You are not testing assumption here, exception better?
22 (commented on others PR)
I think you may be missing a line break here?
23 (commented on others PR)
The profile command is updated with [t/TITLE] and [d/DESCRIPTORS]...
24 (commented on others PR)
I think you have have missed out deleting this UC05
25 (commented on others PR)
Is this supposed to switch the tabs? It doesn't do that at the moment.
26 (commented on others PR)
okay! I tested on my add and delete commands but it doesn't do anything yet. Is there more to the switching besides setting the model state which I have missed from your implementation? I think you may have to return the multiarg CommandResult as there is a boolean arg to indicate whether to switch ?
27 (commented on others PR)
You may want to reduce depth of nesting here? I get that you need three loops here maybe if you using streams can help with that? Or 2 other functions that handles each loop and use boolean flags to terminate the final loop?
28 (commented on others PR)
What happens with the internships don't match? Maybe I am mistaken here but it seems like you just let it pass and create the model out of the unmatching internships instead of an starting an empty list for company and application?
29 (commented on others PR)
Do you think it would be better to shift this logic (LOC:91>) to this own file,? Main app is starting to become too big?
30 (commented on others PR)
Maybe it would be more appropriate to include an assertion or throw an exception here if this is not expected to be called since its harder to debug with null?
31 (commented on others PR)
I have updated the Descriptor class with its own regex, does this affect the storage in anyway?
32 (commented on others PR)
Is there a reason why this does not return a jsonadapted profile item?
33 (commented on others PR)
Initializes?
34 (commented on others PR)
Javadoc could perhaps start with Switches.... depending on
35 (commented on others PR)
Perhaps you could change it to Represents a class...
36 (commented on others PR)
Start with sets..
37 (commented on others PR)
I was wondering if there is a need for a switch statement here? Correct me if I am mistaken, but this just checks if the user provides an string query for to search for? Is the intent of this function for a more tailored error message based on the item type queried? If so why does profile Item have a general error message?
38 (commented on others PR)
I dont know if you need a fullstop here?
39 (commented on others PR)
Do you think this should be part of the design component?
40 (commented on others PR)
@keanecjy maybe you could parse the skill title to [str1, str2, str3] then check if any of the substr matches your requirements? something to that effect
41 (commented on own PR)
You can ignore this first. The content page can be changed after all the headers are in.
42 (commented on own PR)
nvm, its good to merge, I have updated the contents page to link to my headers.
43 (commented on own PR)
Okay, will update!
44 (commented on own PR)
yes. These did not have preconditions, I'll remove them.
45 (commented on own PR)
True, I should remove this, I think the only precondition then is that the system is running which is not very meaningful in this case.
46 (commented on own PR)
Okay will make the change!
47 (commented on own PR)
sounds good!
48 (commented on own PR)
Yes, there will be multiple descriptors which can be added similarly to tags.
49 (commented on own PR)
I think this is the work of IntelliJ auto injecting imports. I will move it.
50 (commented on own PR)
I was going for a primitive implementation for now, but since the types are fixed, I think enum is good solution too.
51 (commented on own PR)
I stopped changing this because I was unsure if we need 2 levels of inequality for profile items.
52 (commented on own PR)
I have not created exceptions yet so this is a placeholder
53 (commented on own PR)
I didn't change this yet since this was the original file but I suppose like it can be changed now too.
54 (commented on own PR)
Sounds good! I was thinking of doing so after the other parsers are done since for example the EditParser for the InternshipCommand may want to abstract 3 items (comindex, index ,prefixes)? So it depends on implementation of the parsers first then after which we deal with abstraction for common vars.
55 (commented on own PR)
Yep, some of initial JD do not have full stops too.
56 (commented on own PR)
I'll update this! thanks for the catch
57 (commented on own PR)
@seanjyjy yeah I was thinking you could always type c sharp or cpp for those cases .
@keanecjy Good point, I am ambivalent about this. But could the same be said for Names as well, maybe we can consider a char limit for that?
58 (other comment)
There were changes in the branch, need to resolve some conflicts! @seanjyjy
59 (other comment)
I noticed that many of the javadocs used "person" and "address book", should we change it now? or leave it for later?
Hmm. The dilemma now is that this is just a proof of concept and we may be abstracting common logic down the line and scrapping all these, so overwriting Javadocs now may redundant. The danger is that if the code is kept and the comments are missed in the future. What is the team's opinion on this? @ZoroarkDarkrai @keanecjy @seanjyjy @shawn-nyk
60 (other comment)
Yup I think that there isn't a need to concern about javadocs / comments as of now as they can be easily fixed at any point in time. @orzymandias I stopped editing the List portions as I noticed that there were too much code duplication with your pr. Do we plan to either extend an
Itemclass or use generics for our list?
I agree. I think there is unnecessary duplication for collections, generics is a good idea for collections but one issue is with throwing custom exceptions for different types of items within the generic list. Should we just have DuplicateItemException then something like throw new DuplicateItemException(T.getDuplicateExceptionMsg())?
61 (other comment)
ecessary duplication for collections, generics is a good idea for collections but one issue is with throwing custom exceptions for different types of items within the generic list. Should we just have DuplicateItemException then something like
throw new DuplicateItemException(T.getDuplicateExceptionMsg())?
I don't think this works because we are not able to access methods in java generics. I figured since we all are classifying our classes as
Item, we can have anIteminterface to contain all the methods similar methods likeisSameItemand likewise dothrow new DuplicateItemException(item.getItemName())?
Sounds good.
62 (other comment)
Overall looks great, just some nits to fix.
Just a side question as to would it be confusing as AddCommandParserWrapper is essentially Similiar to DeleteCommandParser, however, they have different naming syntax.
Is this implementation temporary in order to allow ab3 to function properly?
For AddCommandParserWrapper each item has its own set of parsing rules which may require their own individual parsers so the AddCommandParserWrapper is only responsible for funneling the appropriate item prefix to its add parser. The thing about delete command parser is that there is lesser parsing involved except for extracting out the index to be deleted. With the exception of internship which has an additional index required, all the other commands just need the index extracted to be passed to their delete commands. So I am not sure there is a need a wrapper in that case.
As for consistency I think once AddCommandParser can be safely removed, we can rename AddCommandParserWrapper to AddCommandParser.
63 (other comment)
Just some conflicts to resolve and it will be good to merge.
64 (other comment)
Can add the todo or javadocs and it is good to merge.
Which file/line are you referring to?
65 (other comment)
Overall LGTM to merge, just need to fix the image link. Think there is a typo in the png file itself
Thank you, Good catch!
66 (other comment)
Just some comments for you to consider, not very sure if it is right or wrong.
For
sd execute edit me command, you might want to include what is return in thegetProfileList()perhaps.
And for void methods like
setItemandsetProfileItemi believe the return arrows could be omitted as it doesn't bring any value and it does help to reduce cluttering.
However, if you think that it is fine, then do let me know as it is good to merge already.
Thanks for the feedback! I have updated the getProfileList() depiction but I think I will keep the return arrows for the time being since I think the clutter is still ok and I see that Shawn has also used them to indicate that the methods has completed its execution.
67 (other comment)
LGTM, need to resolve some conflicts
68 (other comment)
I just realised, but just for plausible consideration, should we add-in extension for deleting companies that indicate internships being deleted as well as its application.
Good point! Not sure how to appropriately frame it and if it should even be an extension of company or part of internship/application. @shawn-nyk @keanecjy What do you guys think?
@hansebastian (38 comments)1 (commented on others PR)
I think "module" here should be "modules" instead.
"Lists all modules provided by the university"
2 (commented on others PR)
Unless 'n/' command is taken, I think we should use "n/" instead of "un/", it seems more intuitive for the user to add his/her own name as "name" rather than "username"
3 (commented on others PR)
Should we allow the user the flexibility of determining start and end date? Isn't it better to only allow the user to specify the academic year, and we will provide the start and end date for the user. I think this would make it more convenient for the user.
4 (commented on others PR)
Similar concern to my above comment, whether we should use "n" instead, as well as whether we should allow the user to have control over the start and end date semester.
5 (commented on others PR)
'DAY' has* instead of have. Also, I think it'll be good to capitalize first letter of the days Monday and Sunday:)
6 (commented on others PR)
Similarly, "WEEK" has*.
Additionally, "Total number of weekS".
If we do decide that user shouldn't be able to select start and end dates, then the total number of weeks will be pre-determined already.
7 (commented on others PR)
Same grammatical error as above comment
8 (commented on others PR)
There's an additional 'e' here in "edituseretask"
9 (commented on others PR)
task ID example given here is not really consistent with the sample command (line 248) which uses "id/usrta001". Additionally, the example command here uses "dy/3", I think it should be "da/3".
10 (commented on others PR)
I feel that the command could be better named, for example using "edittemplatename" instead. Although its a slightly longer command, however it gives more clarity than "edittemplate" as to what the user is editing. "edittemplate" gives off the impression that I can edit preset user tasks in the task template?
11 (commented on others PR)
Why is this named "listtasktemplate" instead of "listtemplate" for consistency with the above commands "edittemplate" and "createtemplate"?
12 (commented on others PR)
Grammatical error:
"total tasks for that day exceeds"
13 (commented on others PR)
Similar grammatical error for "exceed"
14 (commented on others PR)
I don't you need "pti/1" in a cleartemplate command.
15 (commented on others PR)
Grammar: I think it should be "List all the task templates that were created" instead
16 (commented on others PR)
Is MODULEINDEX here a list index like "3"/"5", or would it be a module code like "CS2103T"?
17 (commented on others PR)
I think deletetemplate here should have a "tti/TASKTEMPLATEINDEX"
18 (commented on others PR)
In the e.g given, cleartemplate shouldn't have "pti/1"
19 (commented on others PR)
I think we are going to omit MyModules from the architecture, we will be using ModuleSchedule instead, so this use case should be View ModuleSchedule instead
20 (commented on others PR)
Should we follow the three part format for naming of test methods?
21 (commented on others PR)
Likewise for the naming of the test method
22 (commented on others PR)
Similarly for the naming of test method
23 (commented on others PR)
Same here for the naming of test method
24 (commented on others PR)
With this implementation of the parsing of user input, what happens if the user inputs something like:
addexp ... f/for now no OR addexp ... f/think no.
Although in an actual use scenario this is very unlikely to, or will never happen, but would the parser still allow the creation of the expense object in this scenario?
25 (commented on others PR)
GrAB3 should be SuperSalon
26 (commented on others PR)
I think you can add system and actor here and for all other use cases
27 (commented on others PR)
I think we can change the method to saveClientManager
28 (commented on others PR)
The comments here should be for the BreakdownExpenseCommand class instead of the constructor?
29 (commented on others PR)
I think this implementation still allows for intYear to be negative? For example range.isValidIntValue(-999) will still return true. Since the java.time.Year class has a MAX_VALUE of +999,999,999 and MIN_VALUE of -999,999,999.
30 (commented on others PR)
Should we fix the VALID_YEAR to be 2020? Would this still work when I'm using this after the year 2020?
31 (commented on others PR)
I think your method naming here should be breakdownRevenue instead of breakdownExpenses
32 (commented on others PR)
Same here for method naming
33 (commented on others PR)
Should use logging instead of the SOUT?
34 (commented on others PR)
Similarly for this SOUT
35 (commented on others PR)
The additional && appointmentDate.equals(other.appointmentDate) check is not required right since isClashing is only called if appointmentDate.equals(otherAppointment.appointmentDate) in line 123
36 (commented on others PR)
Maybe using "exists in Homerce" is sufficient instead of "homerce book"?
37 (commented on others PR)
Yes I think it happened during the refactoring from Addressbook to Homerce
38 (commented on others PR)
Moving forward, I think it'll be good to have an empty state screen for the user
39 (commented on own PR)
Okay thanks! I'll change it
40 (commented on own PR)
Okay, thanks for this, I've updated the response messages accordingly!
41 (other comment)
Thanks for the comments @khoongwk @yanlynnnnn , I have made the changes as requested!
42 (other comment)
Thanks for the comments @khoongwk @yanlynnnnn, I have made the changes as requested!
@chrystalquek (38 comments)1 (commented on others PR)
Possible to follow Pattern BASIC_COMMAND_FORMAT check used in AddressBookParser?
Reason why ModeParser did not use Pattern is because the commands that ModeParser will parse does not follow the regular format of commands with all the Prefixes.
2 (commented on others PR)
Might need to take out UserPrefsStorage from Person Package.
AddressBookStorage seems to specific to the Person Model, what do you think?
3 (commented on others PR)
Can remove all isMeetingCommand methods
Implemented only for LogicMode because need to know whether to switch mode in MainWindow, whereas it is certain that LogicMeeting will be handling a user input if the current mode is Meeting
4 (commented on others PR)
Will need to accept Contacts Model eventually also so that index of contact can be referenced
5 (commented on others PR)
For cleaner implementation, possible to use Pattern found in AddressBookParser?
split method used in ModeParser because none of the mode commands use prefixes.
6 (commented on others PR)
May be good to just add userPrefs (just reference to same object)
7 (commented on others PR)
Eventually will have a FilteredList>Meeting> filteredMeetings ?
8 (commented on others PR)
Good to take out UserPrefsStorage from person package
Will StorageMeeting be extending from AddressBookStorage?
9 (commented on others PR)
Generalise this so that deliverables and contacts can also use the 'parseDescription'
10 (commented on others PR)
Add a note or TODO that this is to be renamed and Description is to be deprecated
11 (commented on others PR)
OptionalDescription.isValidDescription
12 (commented on others PR)
This may be intended as a String but could be resolved by generalised method as described above
13 (commented on others PR)
Same as above
14 (commented on others PR)
Could consider adding another static method / overloaded constructor that takes in a String so that we don't need to call Optional.of so many times
15 (commented on others PR)
From, To and Deadline will implement this so Message might need to be more general
16 (commented on others PR)
I was thinking whether we could just generate the valueString on the go instead of having an additional attribute
17 (commented on others PR)
Would optional DateTime be supported?
18 (commented on others PR)
is person card currently using this?
19 (commented on others PR)
more valid inputs:
-29th February for leap years
more invalid inputs:
-with seconds
vary the years to see how far back / into the future can be accepted / rejected
feel free to think of more test cases
20 (commented on others PR)
probably an exception? since its invalid user input not problems with our code
21 (commented on others PR)
requireNonNull
22 (commented on others PR)
where will IllegalArgumentException be thrown from?
23 (commented on others PR)
assuming all caught IllegalArgumentException is related to INCORRECT_FROM_AND_TO_ORDER
could try directly using isValidFromAndTo instead
24 (commented on others PR)
"### [Proposed] Autosort feature"
25 (commented on others PR)
Remove "#### Description" to standardize
26 (commented on others PR)
"#### Proposed Implementation"
27 (commented on others PR)
"#### Design consideration:"
28 (commented on others PR)
"##### Aspect: How autosorting executes"
29 (commented on others PR)
Alternative 1 (current choice): ...
30 (commented on others PR)
email is a compulsory field (phone is an optional field)
31 (commented on others PR)
Standardize headings - we are probably only sticking to Implementation and Design Consideration
32 (commented on others PR)
Not sure whether we should standardize not to give e.g.s
33 (commented on others PR)
standardize leaving empty line
34 (commented on others PR)
standardize capitalization
35 (commented on others PR)
DateTimes or dateTimes?
36 (commented on others PR)
Test case or Testcase
37 (commented on others PR)
item = Contact?
38 (commented on others PR)
Would it be all three .json files?
39 (commented on own PR)
I think this is for the initial initialisation of the Ui (to contain the Contacts List as of now). Can be changed later on to show dashboard
40 (commented on own PR)
Yes, maybe we can discuss the ordering because the one in the User Guide may be outdated
41 (other comment)
Updated in README.md
42 (other comment)
Updated in README.md
43 (other comment)
Rescope to just initial implementation of optional fields
44 (other comment)
Not for merge.
@zhengweii (36 comments)1 (commented on others PR)
Might need to change the URL for the badge!
2 (commented on others PR)
Oops! I think the benefit for this is wrong!
Also, I was wondering if we should combine the benefits stated in potential users and use the combined version for this user story?
Apart from this, everything LGTM!
3 (commented on others PR)
Just a minor issue but perhaps this @return should be removed as well!
4 (commented on others PR)
Oops minor typo here!
5 (commented on others PR)
I think this should be removed as well!
6 (commented on others PR)
Perhaps it might be better to change this to a more warehouse-like-name to avoid any potential confusion! Wondering if we need to change the variable name as well?
7 (commented on others PR)
Do we also need to change the variable name here as well?
8 (commented on others PR)
Here too!
9 (commented on others PR)
Oops traces of supplier here!
10 (commented on others PR)
This part here as well!
11 (commented on others PR)
This should be AddProductCommand!
12 (commented on others PR)
I think this message could be clearer! Perhaps something along the lines of "Tag names should contain only 1 word"!
13 (commented on others PR)
Perhaps this could be "Adds a product to a supplier in the CLI-nic app"!
14 (commented on others PR)
Just wondering if this violates the law of Demeter?
15 (commented on others PR)
Not too sure if this is on the same line! But if it is, perhaps the concatenation might not be needed here!
16 (commented on others PR)
Can I clarify what is the remark book??
17 (commented on others PR)
Oops! Lines 76 and 78 are swapped!
18 (commented on others PR)
Not too sure if this is still relevant!
19 (commented on others PR)
If the above comment is relevant!
20 (commented on others PR)
Perhaps the else clause could be removed here as well!
21 (commented on others PR)
Perhaps the clause can be removed here as well to make it more prominent!
22 (commented on others PR)
Minor typo here! Should swap "the" and "from"!
23 (commented on others PR)
Perhaps we should try to make the explanation consistent for both suppliers and warehouses??
24 (commented on others PR)
I think the message should be "not stored / contained in warehouse"!
25 (commented on others PR)
Just wondering if this line is extraneous?
26 (commented on others PR)
I think it should be {@Index} instead of @code targetIndex! I believe they used the class instead of the argument name!
27 (commented on others PR)
If we are using the class name instead of the argument name, then this part needs to be changed as well!
28 (commented on others PR)
Perhaps we could just return the function without the else clause here!
29 (commented on others PR)
This @code too if we are using class name!
30 (commented on others PR)
This too!
31 (commented on others PR)
Do we have tests for invalid index when deleting products??
32 (commented on others PR)
Ahh oops! I was wondering if it would be possible to make the explanation for the examples in line 159 and 161 consistent? In line 159, it says "of the list of warehouse" and then in line 161 it says "from list of suppliers". Would it be possible to use the same format for both??
33 (commented on others PR)
Ahh okok! Thanks for clarifying 😃
34 (commented on others PR)
Ahh ok! Thanks for the update!!
35 (commented on others PR)
Oops typo here!
36 (commented on others PR)
Hmm the example above doesn't really show the t/TAG! Might be a little confusing!
37 (commented on own PR)
Yes I used the same reasoning as edit! But then again, this was why we decided to go with prefix for the find command as well!
38 (commented on own PR)
I suspect last argument might be a little confusing because users might think it is the very last argument at the end of the command!
@halcon-blanco (36 comments)1 (commented on others PR)
I think all the arguments, except INDEX, should be optional here
2 (commented on others PR)
Likewise for here
3 (commented on others PR)
should be .getMaxQuantity().get().toString()
because .getMaxQuantity() returns Optional>Quantity>
4 (commented on others PR)
would isQuantityPresent be a better name?
5 (commented on others PR)
shouldn't this be replaced by if (!(other instanceof RemoveCommand)) instead
6 (commented on others PR)
Sorry I think I misunderstood what you asked last time haha. But do you think there should be some indication if stock goes above 100% as well
7 (commented on others PR)
I believe you should also try a test case with a non RemoveCommand object. I believe the current equals method doesn't handle this and will throw a ClassCastException
8 (commented on others PR)
apart from this small issue, it LGTM for me!
9 (commented on others PR)
Could be more SLAP like
return hasNextCommand() && isWithinLengthLimit();
10 (commented on others PR)
Is this abstraction really necessary?
11 (commented on others PR)
I'm a little confused as to what the role of hasReturnedCurrentCommandBefore is. Could you add a comment to the code explaining a little what is going on
12 (commented on others PR)
Fair enough
13 (commented on others PR)
Looks good. LGTM!. Really good job on figuring out the logic
14 (commented on others PR)
Should change the name of this variable to better reflect its purpose
15 (commented on others PR)
actually it just occured to me after merging that this name is also not appropriate LOL. It should be more like dateTimeFooter or something, because you aren't saving anything
16 (commented on others PR)
In the else condition, you should return quantity1 - quantity2
i.e. when percentage is same, or when there is no percentage, then the item with lesser quantity is higher up
17 (commented on others PR)
Do we want a separate (from getFilteredItemList()) method here? Why not let sorting be done within getFilteredItemList()
18 (commented on others PR)
why not return this in getFilteredItemList()
19 (commented on others PR)
Not an issue, just that this is the first time I have seen o as a variable name 😆
20 (commented on others PR)
should it be && or ||
21 (commented on others PR)
I don't think the "Sorted" part is accurate here. The old name updateFilteredItemList sounds more appropriate
22 (commented on others PR)
Sorry this one very nitpicky, but if you're changing the "o's", can you change this one too
23 (commented on others PR)
and this one
24 (commented on others PR)
the original is correct (i.e. prefers typing to mouse interactions)
25 (commented on others PR)
user executeS. (missing s)
26 (commented on others PR)
OneShelf is capable of storing many items and pending deliveries.
Therefore, it is of utmost importance to have the ability to find items
and deliveries based on different fields. There could also be many similar items and
this will definitely aid the user in find them quickly. <br>
27 (commented on others PR)
and `TAGS` for items using `find-i`. Similarly, for deliveries, it is also possible
28 (commented on others PR)
Good idea to mention that!
29 (commented on others PR)
lexicographically (typo)
30 (commented on others PR)
"Comprises" is misleading. You could say "is implemented by InventoryModelManager and DeliveryModelManager", but frankly, it's not necessary to add that line here. The first sentence sounds enough since this is just an overview
31 (commented on others PR)
Having the d, or some label there, might be usefeul, to show the command being passed back to the front. For instance, right now you do use the "command" label on one of the return arrows, which essentially represents the "d" here
32 (commented on others PR)
There isn't a "ModelManager" class from what I remember. It should be "DeliveryModel".
33 (commented on others PR)
this is the thing I'm referring to. Over here you use the label "command", but it's not 100% clear where that came from, which is why I think you should replace all the d's you removed with this "command" label
34 (commented on others PR)
This shouldn't be removed, it's the constructor for DeleteCommandParser
35 (commented on others PR)
"in finding them" or "to find them" either is fine
36 (commented on others PR)
this one is my fault I apologise
37 (commented on own PR)
I have refactored maxQuantity to use Optionals instead of using "0" now
38 (commented on own PR)
oh didn't realise that happened, must have been automatic
39 (commented on own PR)
thanks for catching that! yes it should be DeliveryListCard
40 (commented on own PR)
have fixed it
41 (commented on own PR)
Yeah sounds like a good idea!
42 (commented on own PR)
"will NOT match" so original should be fine
43 (commented on own PR)
Yes actually I copied most of it from the find-i command, and I was also confused as to what was being said here. I believe it's trying to say that if you have an item called chicken and one called CHICKEN, then both will be returned (although this is no longer applicable to us). I'll change it to a more appropriate example
44 (commented on own PR)
What do you mean
45 (commented on own PR)
I know we're changing this, but to answer this, I didn't think it necessary to check deliveryModel since it wasn't being used
46 (commented on own PR)
Good point. Will add it
47 (commented on own PR)
ok let me try
48 (commented on own PR)
Makes sense, I shall change it
49 (commented on own PR)
issue with this is that it becomes hard to make a canRedo() method without adding another pointer, which makes things messy. I think our array limit will never be set beyond a few 1000 so it's not an issue (and if it is ever changed, the code can be refactored then)
50 (commented on own PR)
Manual testing shows that it works as expected when the limit is 1 or 2
51 (commented on own PR)
oh sheez for some reason my github didn't show all your comments
52 (commented on own PR)
ok so for the static variable, I luckily saw the issue too and just fixed it. as for the capacity != size part, yeah my bad haha still rusty from 2040 times will add it in
53 (commented on own PR)
ok you can check it out now!
54 (commented on own PR)
thanks! shall start work on test cases then
55 (commented on own PR)
Done!
56 (commented on own PR)
Yeah it does, but this is NFR so you're stating that the user should have this. Like it's the assumptions you're making about the system the program will run on
57 (commented on own PR)
Budget is part of NFR because it is a constraint on the project. (Although from a quick google search, it is a bit debated, but the top answer here says it is
58 (commented on own PR)
Right yea that definitely needs to be removed. thanks for pointing out!
59 (commented on own PR)
I believe it already has been added by Xing Yu in the next paragraph
60 (commented on own PR)
OH, because one of my tasks for the weeks was to show help in the result display on start up that's why I edited that. Should I revert it back?
61 (commented on own PR)
Or maybe can ask @wengfaing to make a separate message to display for help on start up and then later change it to show that instead
62 (commented on own PR)
Yes, good catch
63 (commented on own PR)
Ah I feel like we'll never run out of these mistakes haha
64 (commented on own PR)
I've made the relevant changes!
65 (commented on own PR)
Ah I understand your concern, and yes the rephrasing is good. Will add it in
66 (commented on own PR)
Can but they are different things so I don't see the harm in separating them
67 (commented on own PR)
ok sure
68 (commented on own PR)
Physical inventory referring to the actual restaurant's inventory. meaning it won't actually clear all the items out or anything. Just to emphasize that this is a productivity tool, and not an actual product that physically manages your inventory
69 (commented on own PR)
well you're not wrong about the googling 😆 . Yeap I'll just remove it
70 (commented on own PR)
I'll just remove it as well since it's quite nonsense
71 (other comment)
@Wincenttjoi I thought just need make pull request only for the tutorial. Everyone else's pull requests I see also have conflicts
72 (other comment)
Haha no worries
73 (other comment)
Currently tests are failing, because @xnoobftw will be working on them, so merge this first (if all else looks good) even though the CI build is failing
74 (other comment)
@xnoobftw done! CI is passing now.
75 (other comment)
By the way, the conflicts came because of my PR which just got merged, so just keep that in mind haha don't throw everything out
76 (other comment)
@Wincenttjoi ah yes that does make more sense, thanks!
77 (other comment)
@wengfaing how do you want to divide this task
78 (other comment)
@AY2021S1-CS2103T-T12-1/developers do you want the Delivery section and Items section to be of equal width, or the current width they have right now
79 (other comment)
Currently it looks like this
80 (other comment)
For the colouring, is it easy to implement colouring to be conditional (red vs green if stock falls below 20%)? If its a huge task we can create a separate task.
Yes that is very doable
Further improvement:
Low priority: I didn't do the GUI for help toolbar on top to open up the 2 different help windows since the app is meant for CLI primarily. But feel free to connect them if you want 😃
I'll check it out
81 (other comment)
@Wincenttjoi I've made the changes you requested, plus changed the whole structure of the DeliveryList GUI to match that of the ItemList. (Tonnes of headache cuz debugging GUI is super hard).
I also wrote the basic code in MainWindow.java for initialising the values into the DeliveryList on starting the app, with currently an empty ObservableList>Delivery> being initialised temporarily. The Delivery class I wrote is also currently just a stub with no functionality.
82 (other comment)
Disagree. Different restaurants may use different kinds of metrics and having metrics follow enums we may not cover all cases. In such cases edit command would suffice to correct the error
agreed
83 (other comment)
@AY2021S1-CS2103T-T12-1/developers do remember to pull branch-delivery to your local repo before working on it if you're working on this branch
84 (other comment)
Could someone jog my memory on what is required for this again, apart from just renaming the command syntax and repackaging the files
85 (other comment)
Yeah. It becomes a bigger issue when searching by phone number or address in the deliveries
86 (other comment)
Yes that's possible. Is there anything else you think we should do as well. I'm thinking delivery order as well.
87 (other comment)
Fixes #116
88 (other comment)
Just want to check if you're bothered by the naming? Because sometimes I get confused that Item is actually referring to only Inventory. Sometimes I would think of Inventory item vs Delivery item (Item is the umbrella term for the different types)
Any thoughts for this? If you're okay with I'll see what I can refactor in next PR too
I think our understanding is that Item refers solely to inventory item
89 (other comment)
Lol I already added an issue for this. I'll just delete my issue
90 (other comment)
Metric should not be allowed to change in an add command on an existing item
Appropriate error message for when a user tries to do so
91 (other comment)
@xnoobftw yea sure!
92 (other comment)
Refer 8daa9e6
93 (other comment)
@Wincenttjoi I'm having some issues with the test cases (they work individually but don't work when the whole test suite is run. I've been googling but still am not sure where the issue is), don't think they'll be done any time soon.
Maybe PR first so that the rest of development can work on top of it (for instance the new delivery commands will need to take this into consideration now)
Edit: don't merge this yet
94 (other comment)
Can accidentally do my DG also
95 (other comment)
Sure, will check it out
96 (other comment)
Oh I only purged for "addressbook" earlier but didn't think about "address" in general. Thanks for pointing that out
@yanlynnnnn (35 comments)1 (commented on others PR)
Agreed. The user might not know the exact start and end dates of his semester, and we also do not need to take into account the user entering invalid start and end dates if we provide them for the user instead.
2 (commented on others PR)
AY20/21 Sem missing a '1'
3 (commented on others PR)
*Duration is measured in hours and must not exceed 24 hours
4 (commented on others PR)
Same rephrasing as above comment
5 (commented on others PR)
*has
Can omit the second line if we are providing them with the start and end dates?
6 (commented on others PR)
Will listpresettasks be more intuitive since it will be a list of preset tasks?
7 (commented on others PR)
Remove a Module and all its Module Tasks from the Module Schedule
8 (commented on others PR)
*load all its Module Tasks
9 (commented on others PR)
If its "CS2103T", maybe we can change it to MODULECODE
10 (commented on others PR)
Do we have a method to list all the task templates or will the GUI take care of that?
11 (commented on others PR)
Use either remove or delete
12 (commented on others PR)
Agreed
13 (commented on others PR)
*listmymodules
14 (commented on others PR)
List all the modules that the user has selected.
15 (commented on others PR)
tasks*
16 (commented on others PR)
Maybe can change to List all tasks instead of Listing a Task Schedule? As schedule itself refers to a list of tasks
17 (commented on others PR)
Think you might have added an extra '.' at the end!
18 (commented on others PR)
Should it be 'parameters' instead of 'parameter'?
19 (commented on others PR)
Should SERVICE_CODE be added here?
20 (commented on others PR)
maybe can replace 'additional' with another word, or just write 'displays a success message'?
21 (commented on others PR)
*updates
22 (commented on others PR)
*requests
23 (commented on others PR)
*deletes
24 (commented on others PR)
*match
25 (commented on others PR)
*match
26 (commented on others PR)
*shows a, *match
27 (commented on others PR)
*an
28 (commented on others PR)
*displays
29 (commented on others PR)
*an
30 (commented on others PR)
*At least one service exists in the service list
31 (commented on others PR)
Does it guarantee an empty service list as well?
32 (commented on others PR)
maybe can change description to details?
33 (commented on others PR)
*service
34 (commented on others PR)
*GrAB3 shows the list of expenses sorted in ascending order
35 (commented on others PR)
Should be 'expense' instead of 'revenue' here
36 (commented on own PR)
I'm currently using the Tag Class provided by AB3 which does not handle white space, will handle it subsequently if it is consistent with the other features using the same Tag Class.
37 (commented on own PR)
Noted, I have changed it from a character to a String. Thanks for pointing out!
@Wong-ZZ (35 comments)1 (commented on others PR)
Shouldn't example usage (below) be updated to include the IC field as well?
2 (commented on others PR)
Shouldn't a javadoc comment be included similar to the other models?
3 (commented on others PR)
Shouldn't there be a multiple ICs test?
4 (commented on others PR)
Shouldn't there be a missing IC prefix test?
5 (commented on others PR)
Shouldn't there be an invalid IC test?
6 (commented on others PR)
Shouldn't there be an invalid IC test?
7 (commented on others PR)
Shouldn't parse_oneFieldSpecified_success and parse_multipleRepeatedFields_acceptsLast also have tests for IC?
8 (commented on others PR)
Shouldn't there be tests for null and invalid IC?
9 (commented on others PR)
Shouldn't it be BloodType instead of weight?
10 (commented on others PR)
If you refer to the javadoc for the other methods, shouldn't it be @code String BloodType and @code bloodType?
11 (commented on others PR)
Shouldn't it be bloodtype instead of weight?
12 (commented on others PR)
Shouldn't there be a description of the parameter?
13 (commented on others PR)
Should it be Constructor instead of constructor?
14 (commented on others PR)
Javadoc comment does not follow the coding standards
15 (commented on others PR)
Shouldn't it be there be a space before Blood type: ?
16 (commented on others PR)
Shouldn't it be BloodType.MESSAGE_CONSTRAINTS instead of Weight.MESSAGE_CONSTRAINTS?
17 (commented on others PR)
Shouldn't it be blood type instead of weight?
18 (commented on others PR)
Shouldn't all the missing field prefix test also include VALID_BLOOD_TYPE_BOB so that the tests would be consistent with each other?
19 (commented on others PR)
Shouldn't it be blood type instead of weight?
20 (commented on others PR)
Shouldn't method header comments start with a verb?
21 (commented on others PR)
The class header comment is not consistent with the class header comment like Phone or Email
22 (commented on others PR)
Shouldn't all these "N/A" be abstracted out?
23 (commented on others PR)
Why not use the stringEmail, stringAddress... methods?
24 (commented on others PR)
OPTIONAL_FIELD_EMPTY_MESSAGE and "N/A" has been used over multiple classes. Maybe they can all use the same constant in one of the classes?
25 (commented on others PR)
Same as before, why not use the stringEmail, stringAddress... methods?
26 (commented on others PR)
Is it necessary to use nested Optional?
27 (commented on others PR)
You can use the or method so that the get*Field* method does not have to return a nested optional
28 (commented on others PR)
You could maybe use the ifPresent method
29 (commented on others PR)
Why not use the stringEmail, stringAddress... methods?
30 (commented on others PR)
why not use the stringEmail, stringAddress... methods?
31 (commented on others PR)
I think you forgot to update this part
32 (commented on others PR)
Shouldn't it be getStringIc instead of getStringIC?
33 (commented on others PR)
TableView is missing its generic type
34 (commented on others PR)
Shouldn't it be TableColumn>Patient, String> instead?
35 (commented on others PR)
Shouldn't the imports be written explicitly?
@WeiJie96 (34 comments)1 (commented on others PR)
Perhaps it would be good if we insert our website here.
2 (commented on others PR)
Perhaps we could keep keep this so we can change it individually
3 (commented on others PR)
Perhaps we could keep keep this so we can change it in future
4 (commented on others PR)
Perhaps we could keep keep this so we can change it in future
5 (commented on others PR)
Perhaps we should keep the product name consistent, to Insurance4Insurance, I4I
6 (commented on others PR)
Perhaps we can add a "Coming soon." here
7 (commented on others PR)
Perhaps this could be "Adds a client to I4I."
8 (commented on others PR)
Perhaps this could be Format: add n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [o/NOTE] [t/TAG]…
9 (commented on others PR)
Perhaps this could be
Examples:
add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01
add n/Betsy Crowe t/friend e/betsycrowe@example.com a/Newgate Prison p/1234567 t/criminal o/This client is new.
10 (commented on others PR)
Perhaps this could be Lists the entire list of clients in I4I.
11 (commented on others PR)
For now, for v1.2, I think we would try to minimise the amount of fields to delete, so we would add in NOTE and keep the rest. However, this may change in v1.3/1.4, so we can update the UG then.
12 (commented on others PR)
For now, for v1.2, I think we would try to minimise the amount of fields to delete, so we would add in NOTE and keep the rest. However, this may change in v1.3/1.4, so we can update the UG then.
13 (commented on others PR)
We can add back the "Tip" for tag if you are okay with the above change.
14 (commented on others PR)
Perhaps we can format INDEX to INDEX.
15 (commented on others PR)
Perhaps we can edit to Example: list followed by delete 2 deletes the 2nd person in I4I.
16 (commented on others PR)
Perhaps we can add a Coming soon here
17 (commented on others PR)
If you are okay with above edits to add, perhaps we can change to this:
Add | add n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [o/NOTE] [t/TAG]… >br> e.g., add n/Betsy Crowe e/betsycrowe@example.com a/Newgate Prison p/1234567 o/This client is new. t/friend t/criminal
18 (commented on others PR)
Perhaps we can add in help as well, since we are implementing in v1.2
Help | help
19 (commented on others PR)
Perhaps we can add this back, since we are implementing help in v1.2
But we would need to update the image to https://ay2021s1-cs2103-t16-2.github.io/tp/UserGuide.html
20 (commented on others PR)
Perhaps we should change this to
21 (commented on others PR)
Would it be better if we have multiple tags and 1 note? i.e. the ... comes after tag instead
22 (commented on others PR)
Would it be better if we have multiple tags and 1 note? i.e. the ... comes after tag instead
23 (commented on others PR)
Perhaps this can be updatedNote?
24 (commented on others PR)
Perhaps the message could be "Notes can take any values, and it should not be blank"
25 (commented on others PR)
Perhaps this can be package seedu.address.model.person;
26 (commented on others PR)
Perhaps seedu.address.model.note.Note can be simplified to Note
27 (commented on others PR)
Perhaps we can return noteName
28 (commented on others PR)
Perhaps this could be " "?
29 (commented on others PR)
Perhaps we don't need to add an invalid tag here
30 (commented on others PR)
Perhaps we don't need to add an invalid tag here
31 (commented on others PR)
Perhaps we could add back the space here String ...
32 (commented on others PR)
Perhaps we should add back the space here?
33 (commented on others PR)
Perhaps this should be 8 spaces relative to line 22? But not sure why the original AB3 passed checkstyle
Similar concept for the rest of the lines in this file
34 (commented on others PR)
Alright got it
35 (commented on own PR)
If I didn't understand your question wrongly, the withoutNote() is meant to add in a null for BENSON, who originally has a note
36 (other comment)
Reopening this issue as PR was accidentally merged
37 (other comment)
Note that this PR was merged by accident, reopening issue and creating another (similar) PR
38 (other comment)
Resolves #6
39 (other comment)
Ensure that source should be >= 50 characters.
40 (other comment)
Update URL and image in UG
41 (other comment)
address
phone
@sebastiantoh (34 comments)1 (commented on others PR)
Edits an existing tag in StonksBook to the specified tag name. All entries previously associated with this tag will be updated to associated with the updated tag.
I think we can remove the here
2 (commented on others PR)
* All contacts that have been previously associated with this tag will be updated automatically to be associated with the updated tag.
3 (commented on others PR)
Should we mention friends here? I think it may be better if you just mention that it updates the name of the first tag (as per tag list)
4 (commented on others PR)
Same comment for here (about whether to mention friends)
5 (commented on others PR)
Maybe we should consider switching to an ordered list if we're going to make reference to other points
6 (commented on others PR)
Think you're missing a Use case ends. here and in some other portions below as well
7 (commented on others PR)
Can this be indented to be the same level as 2a? Likewise for the remaining use cases
8 (commented on others PR)
2. StonksBook adds the provided tag.
9 (commented on others PR)
| `* * *` | efficient salesman | list all sales of a contact | see all sales made to a contact easily |
10 (commented on others PR)
I think here we're assuming that contacts are sorted before sales right? Should we add a comment stating this assumption?
11 (commented on others PR)
Can we write this section into an if-else block with the above? Then we can also remove some duplicate code
12 (commented on others PR)
Hmm, is associations a bit hard to understand here? Would it be better to be more verbose here and say something like Note that all items that have been previously associated with this tag will be updated automatically to be associated with the updated tag. as per the user guide?
P.S. May also need to update the user guide: it currently says contacts when it's supposed to be generic right?
13 (commented on others PR)
Same feedback here as in DeleteCommand
14 (commented on others PR)
Is this comment still relevant? If I'm not wrong it refers to the tags stored in the persons/sales right?
15 (commented on others PR)
Javadocs here is inaccurate
16 (commented on others PR)
Javadocs here is inaccurate
17 (commented on others PR)
Would it be better to initialise a new HashSet with the original tags, remove the target, then add the editedTag in order to prevent arrowhead-style code? Same can be done for the removeContactTag
18 (commented on others PR)
This should be equivalent tag instead of person right?
19 (commented on others PR)
Should be tags here instead of persons
20 (commented on others PR)
Is this javadoc accurate?
21 (commented on others PR)
p.s. i think these 2 lines are common across the conditionals. maybe we can extract it out of the conditional? same for EditCommand
22 (commented on others PR)
Is this part relevant?
23 (commented on others PR)
Is this description accurate? I think the javadocs you have in AddressBook.java would be better here!
Based on the name of the method, I am inclined to think that this method returns a list of contacts. Maybe you want to rename it so it's clearer? Idk. But I think updating the javadocs would be good!
Same for findBySaleTag
24 (commented on others PR)
Should this be be model.findBySaleTag?
25 (commented on others PR)
* Lists all sale items associated with {@code target} tag.
26 (commented on others PR)
ps still got the parameter here that needs to be updated as well
27 (commented on others PR)
Does using ++count instead work? Same for below
28 (commented on others PR)
Maybe can replace this with just AddCommand instead of the fully qualified name?
29 (commented on others PR)
30 (commented on others PR)
Maybe can use AddCommand here instead?
31 (commented on others PR)
Just checking, but what's the desired behaviour if a user supplies both c/ and s/?
32 (commented on others PR)
P.S. I think I extracted this out into a method in ParserUtil. Maybe can import it from there instead of duplicating?
33 (commented on others PR)
* Returns true if all the tags of the provided {@code sale} item exist in StonksBook.
34 (commented on others PR)
* Returns true if all the tags of the provided {@code sale} item exist in StonksBook.
35 (commented on own PR)
Thanks for pointing that out!
36 (commented on own PR)
Oh, my bad. I didn't know the new line would affect the formatting. Thought it was just code styling. Will remove it!
37 (commented on own PR)
Not yet! Just adding this in here so that I won't forget. Sorry for the confusion
38 (other comment)
@Asthenosphere ps can help resolve the merge conflicts?
39 (other comment)
LGTM
Thanks!
40 (other comment)
Think we're all done with this. Nice work all!
41 (other comment)
LGTM! Could you merge the updated master and push again though? Renaming
CONTACT_INDEXtoCONTACT_INDEX_SECONDmight affect some of the test cases that have been merged.
Sure!
42 (other comment)
Not really relevant to this PR, but I think the parameter and example for editing a tag is missing the updated tag name. Example should be something like tag edit 1 t/furniture. Feel free to merge this PR if you want to resolve this in another PR.
43 (other comment)
Tested locally, LGTM! Good idea to abstract ModelStub out to another class.
Can I just check: whether a reminder is overdue or not is evaluated at program startup, are there any plans to either have the reminder display update immediately when the reminder time has passed, or to have a command to manually refresh the reminder display (like perhaps on
reminder list?
Good point! I've added a force-refresh at the end of every command. Idk if this would be too inefficient though...
44 (other comment)
See #127
45 (other comment)
Done in #114
46 (other comment)
Yep, sure!
@jonasngs (34 comments)1 (commented on others PR)
Perhaps javadocs could be added for the class here?
2 (commented on others PR)
Perhaps javadoc comments could be added for this enumeration to further explain the role of this enum class?
3 (commented on others PR)
We could use a common ParserUtil class to implement parsing methods which can be used across ModuleList, ContactList and TodoList in the future. For now, this is a sound implementation.
4 (commented on others PR)
We could perhaps consider shifting out EditTaskDescriptor as a separate class rather than a nested class.
5 (commented on others PR)
Perhaps this validation test could be modified to account for empty task name as well?
6 (commented on others PR)
Perhaps you could extend a similar concept further and allow users to add tags to a particular task? The tagging feature seems to have some similarities with the Type enumeration here.
7 (commented on others PR)
Will users be able to create Tasks without a type, priority or date? Perhaps allowing users to omit the addition of certain Task fields would increase flexibility?
8 (commented on others PR)
Should we ensure that another task with the same name, date and type as the edited task does not exist in the todo list? This is in accordance with the hasTask method above which checks if there is a task with the same name, date and type.
9 (commented on others PR)
Merge conflict here has not been resolved. Should be resolved as soon as possible.
10 (commented on others PR)
Perhaps you can consider adding an error message for this exception so exception handling would be clearer for us and users will be aware of the incorrect or invalid command provided.
11 (commented on others PR)
Would users have the flexibility to choose how the todo list will be sorted? Specifically, can they choose to sort from lowest to highest priority and vice versa?
12 (commented on others PR)
Yes, I think it is sufficient to check the name for duplicate tasks. However, could you clarify the implementation of the above hasTask method? The javadocs says that it will check if there is an existing task with the same name, date, and type in the todo list. In that case shouldn't checking for same name be enough?
13 (commented on others PR)
Yes, that sounds fine.
14 (commented on others PR)
That sounds fine, this can be further worked on in future PRs.
15 (commented on others PR)
The separation of the commandWord from the respective arguments in this line could be further refined using Pattern and Matcher class.
16 (commented on others PR)
Perhaps for the implementation for ParserManager, we could abstract away the lower level details, ie the kinds of Parsers that exist (ModuleListParser, ContactListParser and TodoListParser). These Parsers would only be made known in ParserManager and LogicManager should not have to be aware of them.
17 (commented on others PR)
For this method, we should avoid using the contains() method. Consider a scenario where the user inputs "module1" as the first input word by accident. Then "module1" would be accepted as a valid command word. This can give rise to bugs and complications. We could consider using .equals() instead.
18 (commented on others PR)
Relating to the comment below, we could have ParserManager instantiate an instance for each of the 3 respective Parsers in the constructor here, rather than leave it to LogicManager since ParserManager is the one responsible for the 3 Parser classes. This is something we could consider.
19 (commented on others PR)
We should first merge the PR which abstracts out the parsing of contact list, module list and todo list into individual classes. Following the merge of the above mentioned PR, please handle the parsing of Task related commands in the TodolistParser class.
20 (commented on others PR)
Perhaps we can shift this Date class into a commons package in the model package. The rationale is that other implementations such as our schedule feature would require a Date class as well. This can prevent repetition of code.
21 (commented on others PR)
Perhaps we can consider abstracting out all Name related classes, such as ModuleName, ContactName and TaskName into a common Name class. This would prevent repetition of code.
22 (commented on others PR)
There might be a naming error in the javadocs here. It should be AddTaskCommand if I am not wrong.
23 (commented on others PR)
Perhaps we could implement the tag feature of Tasks as a Set>Tag> so that users will be able to add more than 1 tag. Based on this current implementation, users will only be allowed to add one tag. However, it is fine for now and we can make the necessary changes later during the milestone.
24 (commented on others PR)
Is there a reason why you modified this String? I thought it is fine to include the message constraint that a task name should not be empty.
25 (commented on others PR)
Yes, that makes sense, we could consider that.
26 (commented on others PR)
Yes, that sounds reasonable, ultimately ParserManager should be the one handling the instantiation of the related Parser classes.
27 (commented on others PR)
Contact should be replaced with Task.
28 (commented on others PR)
JsonAdaptedContact should be replaced with JsonAdaptedTask.
29 (commented on others PR)
All instances of "contact" in javadocs and variable names should be replaced with "task".
30 (commented on others PR)
Will this class be required for the todolist storage implementation?
31 (commented on others PR)
Perhaps you could use requireAllNonNull(todoList, filePath) from the commons package?
32 (commented on others PR)
Perhaps you could modify this line to: logger.fine("Attempting to read todo data from file: " + filePath);
Since we are reading data from several Json files, this can improve clarity when using logger.
33 (commented on others PR)
The comment from above could be useful here as well, we could refine the logger message to be something more specific and meaningful.
34 (commented on others PR)
I think the implementation of this constructor can be improved. For a Task object, the Date, Priority and Tag fields are optional and the below implementation might result in a NullPointerException, for eg, invoking getPriority().get() might return null.
35 (commented on own PR)
This is a temporary implementation as the storage for contact list has not been implemented yet.
36 (commented on own PR)
CommandResult sounds more understandable as opposed to ResultCommand. The class is supposed to represent the command's result.
37 (commented on own PR)
Same issue as above.
38 (commented on own PR)
Yes, we do not want to add multiple contacts which are the same into the contact list. Thus, it is necessary to perform such a check for duplicate contacts.
39 (commented on own PR)
Even if an object of List type is declared final, we can still add items into the list. We are only unable to overwrite the list with an entirely new list.
40 (commented on own PR)
Same issue as above.
41 (commented on own PR)
Same issue as above.
42 (commented on own PR)
This will be updated during the next PR.
43 (commented on own PR)
This will be updated in a future PR.
44 (commented on own PR)
Yes will change it.
45 (commented on own PR)
Yes this will be done!
46 (commented on own PR)
Yes, email and telegram will be set as optional fields in future PR.
47 (commented on own PR)
Yes, javadocs will be added.
48 (other comment)
Individual components of the user guide have been added by member's pull requests linked to separate issues. User guide has been updated with the necessary content for milestone 1.1, this issue will be closed.
49 (other comment)
Merge conflicts resolved. Able to merge pull request.
50 (other comment)
Should resolve CI checks before merging PR.
51 (other comment)
Should resolve CI checks before merging PR.
52 (other comment)
Issue is closed with the merging of PR #84
53 (other comment)
UML diagram has been uploaded to the repo.
54 (other comment)
This PR should still be a draft, it will be closed and a new PR with the updated storage functionalities will be made in the future.
55 (other comment)
ParserException and CommandException have been added in subsequent PRs.
56 (other comment)
LGTM.
@ZhangWanlin98 (34 comments)1 (commented on others PR)
Do we need to have 2 add here? coz it looks a bit weird from the preview
Will it be better if we separate the command word add with the example into 2 lines?
Or can just delete the 2nd add to just have a command word + command body format
2 (commented on others PR)
would help page of Nuudle be better? or just another way to avoid not using 's
3 (commented on others PR)
would the method name be better if it sounds like a question?
like isAppointmentOverlapping
4 (commented on others PR)
it might be better if this public method could have a javadoc
5 (commented on others PR)
That is possible.
Although the initial purpose of the DateTimeLoader class is just improve the OOP for the AssignCommandParser to pass the date and time, we can make it into an inheritance or other implementation to broaden the usage when necessary
6 (commented on others PR)
If you want to get rid of the AssignCommand., I guess it would better to import the DateTimeLoader class so the code looks more precise.
7 (commented on others PR)
Will the white space be too much?
8 (commented on others PR)
do we still follow the user guide? coz from there the done should be with the use of the AppointmentId, so maybe it would be better to use AppointmentId class instead of dateTimeLoader?
9 (commented on others PR)
I think this should be NuudleParser?
10 (commented on others PR)
The package name should be nuudle?
Since here is for the entire project
11 (commented on others PR)
I think the VersionedPatientBook also? Since the undo/redo includes the appointment
12 (commented on others PR)
PatientBook should be Nuudle?
13 (commented on others PR)
I have another idea tho.
Do we actually need to check the overlapping of target and editedAppointment? I feel not checking makes more sense to the reality where the patient just want to shift the appointment a bit forward or backward.
Let me know what you think about this 👍
14 (commented on others PR)
Should the name be WithIn be one word? like Within
15 (commented on others PR)
[REMARK] should be without square bracket?
16 (commented on others PR)
I'm not sure about this, but usually there is no space between prefix (r/) and content (Likes to swim) right?
17 (commented on others PR)
I think we need a short description before the @param?
18 (commented on others PR)
I think this should catch ParseException since the parseIndex throws it and no mention about IllegalValueException
I went to check and found out that actually we have not tested this try and catch block for other commands.
I guess we can add in V1.4.
19 (commented on others PR)
Good effect for all remarks! 🤣
20 (commented on others PR)
Oh that makes sense 👍
21 (commented on others PR)
I would think that we should disable cancel if the date of the respective appointment to be cancelled is alright passed since there is no point to cancel an appointment which is already in the past.
However, I think it would be different for done since there may be cases that the admin forgets to mark done and just lets it expire. done allows for the correction.
How about the rest?
22 (commented on others PR)
should be checks?
23 (commented on others PR)
is period needed here?
24 (commented on others PR)
Thanks for the correction 👍
25 (commented on others PR)
The space between addressBook and the ... is too much?
26 (commented on others PR)
Should be Creates?
27 (commented on others PR)
I think can remove at?
Just like the one in DateParserUtil.java
28 (commented on others PR)
have should be singular?
29 (commented on others PR)
I would think this helps abstract information.
The only problem is that we need to arrange it well.
Maybe we can clean it up in some time.
30 (commented on others PR)
Would a short description of the method be better?
31 (commented on others PR)
🤣
How about we take out our code of the EditAppointmentDescriptor and DurationSupporter to have a common class!
32 (commented on others PR)
I have to say it too!
It solves the warning from get() of Optional!
Thanks for the enlightenment.
33 (commented on others PR)
Should we check in the other way?
Coz in this case, the command can be successful with even just one of the prefix content present. Hence isPresent() should be used instead of isEmpty()
I think you can refer to the EditCommandParser class
What do you think? 👍
34 (commented on others PR)
Sorry that I'm a bit confused why all the numbering is 1?
Is it supposed to be that?
35 (commented on own PR)
alright!
36 (commented on own PR)
Yes, thanks for pointing out
37 (commented on own PR)
Yup, I did use PREDICATE_SHOW_ALL_APPOINTMENT, but just due to bugs of ystd, I doubted it was related to it so I changed. After solving the bug, forgot to add back.
Thanks for the suggestion!
38 (commented on own PR)
Hence, it actually indicates an invalid command format if PREFIX_DATE is empty as it would mean that something else is written
@Avalionnet yup, I covered empty arg in the switch cases in NuudleParser, which is just list other one word command
but now I have changed to cover it in the ViewCommandParser
I think both ways are good, what yall think?
39 (commented on own PR)
Thanks guys!
Yes that is good indeed, I have changed it.
40 (commented on own PR)
Good spot and thank for pointing them out!
41 (commented on own PR)
Definitely!
And I just realized that use in minutes to express it 🤣
I think that is simpler and clearer?
42 (commented on own PR)
Haha, you too!
43 (commented on own PR)
Good job reviewing all my codes 👍
44 (commented on own PR)
Oh, this UI part has been done by Yang Yue, so I guess this one can just ignore.
45 (commented on own PR)
Good spot!
46 (commented on own PR)
Oh this part is supposed to be Ming Lim's, I accidentally touched it.
47 (other comment)
Hmm if I remember correctly, we are required to use lowercase for naming our profile image file. Do check it up before merging!
Noticed. Changes have been made 👍
@foojingyi (34 comments)1 (commented on others PR)
Should this document need to be refactored?
2 (commented on others PR)
Should we edit the tutorial document?
3 (commented on others PR)
Perhaps this document does not have to be edited as well?
4 (commented on others PR)
Is this part of a tutorial as well? Should it be changed?
5 (commented on others PR)
Perhaps we should keep this in view?
6 (commented on others PR)
Should we change "ab" to "mb"?
7 (commented on others PR)
Same as for UndoRedoState0.puml, maybe we should change in all the diagram files?
8 (commented on others PR)
Should this be changed since there is a link to AB4?
9 (commented on others PR)
Good renaming here!
10 (commented on others PR)
Does this document need to be changed? I'm not very sure 😕
11 (commented on others PR)
Should the tutorial be refactored?
12 (commented on others PR)
Should this be changed?
13 (commented on others PR)
Should this be "MediBook" instead? Since it looks like the product name
14 (commented on others PR)
Is this refactoring the correct word?
15 (commented on others PR)
Similar to a previous comment, is this the correct thing to change?
16 (commented on others PR)
Again, should this be changed?
17 (commented on others PR)
Should this be left alone?
18 (commented on others PR)
Should this be changed?
19 (commented on others PR)
Here as well
20 (commented on others PR)
Should this comment be changed?
21 (commented on others PR)
Should this comment be changed?
22 (commented on others PR)
Should the comments in this class be changed?
23 (commented on others PR)
Should this be refactored?
24 (commented on others PR)
Should this be changed?
25 (commented on others PR)
Should these comments be changed?
26 (commented on others PR)
Should this be changed?
27 (commented on others PR)
Should this comment be revised?
28 (commented on others PR)
Perhaps change this to "MediBook" as well? Not that important as it's just for logging
29 (commented on others PR)
Was this supposed to be changed?
30 (commented on others PR)
Here as well
31 (commented on others PR)
Perhaps change this variable name?
32 (commented on others PR)
Perhaps the comments in this class can use "MediBook" instead?
33 (commented on others PR)
Should "ab" be changed?
34 (commented on others PR)
Sounds grammatically incorrect to say "the user then access" even though it is clear in the markup that this is a command. Is there a way to rephrase this sentence?
35 (commented on own PR)
Good eye 👍
36 (commented on own PR)
Maybe we can refactor this if needed after looking at the implementation? Since this is based on conventions in the other Patient detail classes i.e. Name, Tag, etc.
37 (commented on own PR)
Will that make the code harder to read and be a bit unnecessary? I also made it similar to other classes so maybe we would want to be consistent?
38 (other comment)
Will create a PR on branch instead of master
39 (other comment)
Resolved by #80
40 (other comment)
Resolved by #80 using UI parts instead
@dhafinrazaq (34 comments)1 (commented on others PR)
should this be mid-v1.2?
2 (commented on others PR)
okay agree
3 (commented on others PR)
I got the same warning and also mentioned here: https://github.com/nus-cs2103-AY2021S1/forum/issues/232
(it's an error log output). So this should be fine
4 (commented on others PR)
Should the parameter name be client instead of Client?
5 (commented on others PR)
Should the parameter name be clients?
6 (commented on others PR)
should Clients be clients?
7 (commented on others PR)
ohh, if the checkstyle version/file in both GitHub and IntelliJ are already configured properly but the outputs are different, I'm not sure which one to follow. Perhaps @benclmnt have a suggestion regarding this code quality?
8 (commented on others PR)
I think this is what wei jie means. Perhaps you can change these jsons from "Clients" to "clients"
9 (commented on others PR)
Or should we ignore the GitHub's checkstyle warning for now and merge, and fix it along the way?
10 (commented on others PR)
Should this be FitEgo?
11 (commented on others PR)
Should this be Clients or clients? (for consistency)
12 (commented on others PR)
should the name be something like "hasFunctionToRun"?
13 (commented on others PR)
Should this be non-public?
14 (commented on others PR)
should this be session builder? noticed the same cases in this file as well
15 (commented on others PR)
should the variable name index be changed? since there are 2 "index"
16 (commented on others PR)
just curious, any reason why this takes in LocalDateTime instead of String (since the other with__ takes in string)?
17 (commented on others PR)
in terms of consistency with the other with__ methods, should we pass the String? What do you all think?
18 (commented on others PR)
should FitEgo shows list of client and session?
19 (commented on others PR)
should this be inside [] to show this is optional?
20 (commented on others PR)
are these 2 fields used? In editClientDescriptor, the index of the entity that we want to edit is not included. Only the fields that might be changed due to the edit command are included
21 (commented on others PR)
will this throw NoSuchElementException if the input does not include su/...? This issue arises when implementing payment/adding schedule remark features. I think would be better not to declare it here, since if the schedule remains unedited, it's already handled in line 71
22 (commented on others PR)
Should these 2 lines be wrapped in a try-catch block, like the EditSessionCommandParser and EditClientCommandParser to check whether the clientIndex or sessionIndex is missing?
23 (commented on others PR)
should the edited field, i.e. updateSessionIndex be encapsulated in editScheduleDescriptor?
24 (commented on others PR)
should this takes in updateSessionIndex only? since the field that would be edited is only session index (for now)
25 (commented on others PR)
should updatedSessionIndex be encapsulated in editSchedDescriptor?
26 (commented on others PR)
for consistency, do we need to add what is contained in the client?
27 (commented on others PR)
command change to commands?
28 (commented on others PR)
should we write "commands" instead of command?
29 (commented on others PR)
should we include "weight measured"?
30 (commented on others PR)
this might change if we want to use ses and sch
31 (commented on others PR)
should we say duration is in minutes?
32 (commented on others PR)
should this be session list?
33 (commented on others PR)
Would this mean we need to have this extension in every command? (extension if we have a missing argument)
34 (commented on others PR)
now pd/paid or pd/unpaid
35 (commented on own PR)
Is it better if I change it into:
Use case: UC03 - Edit a Client
MSS:
1. User requests a list of Clients using `clist` (UC02) or `cfind` (UC04)
..the rest
36 (commented on own PR)
done
37 (commented on own PR)
sessionIndex is the previous index (index of session to change)
the reason I delete the updatedSessionIndex is because it is already contained in the descriptor (since this is an optional field). also, I'm afraid that if we have updatedSessionIndex in both command and descriptor, we must ensure both of them are the same
@benclmnt any comment?
38 (commented on own PR)
thanks for spotting them, that was auto-filled by IntelliJ (because ModelStub implements Model).
I'll change it
39 (commented on own PR)
yep, it represents phone in add client cmd. Do you have any suggestion for this?
im thinking of paid/ or pay/, but afraid that those are too long
40 (commented on own PR)
i think maguire is editing this part
41 (commented on own PR)
yes, it works even without the true. not sure why @benclmnt also have the true in the cmd usage message
42 (commented on own PR)
oh @kelvinvin 's suggestion is to have the else to make it clearer
so make it like the prev commit?
43 (other comment)
should the find feature be implemented later? Also, the current AB3 only supports search by name
44 (other comment)
Is this like adding a new command? If yes, should this be for v1.2 or mid-v1.2?
45 (other comment)
The division of 3 sections is in the other PR. Should we bold the nextSession line?
sorry just read this. both bolded/not bolded looks good for now
46 (other comment)
Some things to take note:
1. Command has been changed from "[c/CLIENT] [s/SESSION]" to "[INDEX] [s/SESSION]" which makes more sense.
2. 1 issue which is that when the input session is higher than the total number of session, there's an exception on the terminal but nothing is being printed on FitEgo. The issue is with RescheduleCommand only having the [INDEX] which takes care of the problem when [INDEX] > total schedules, but in Parser, I'm not able to retrieve the filteredSessionList as it requires Model to retrieve it, so FitEgo can't detect the issue when input session is higher than total sessions.
3. Testing for this Reschedule is not fully up yet because there isn't a ScheduleCommandTestUtil class, not sure if this is required because now it's a bit tricky in a sense that Schedule contains Client and Session while RescheduleDescriptor contains clientIndex and sessionIndex of Index class. If RescheduleDescriptor were to contain Client and Session, it should be easier but in RescheduleCommandParser, similar to issue 2 above, I'm not able to retrieve the filteredSessionList as it requires Model to retrieve it.
try to detect the issue in command.execute() instead of parser?
47 (other comment)
A good feature to have. will the implementation be like inside DeleteSessionCommand, iterate through the model's ScheduleList?
48 (other comment)
looks good
49 (other comment)
solved
50 (other comment)
Should PR from branch
51 (other comment)
i've implemented some of my suggestions from here to my payment PR
feel free to try that feature and see if there is any unecessary changes made
52 (other comment)
Can anyone check if this is correct? The new diagram is a bit different
Before:
Now:
53 (other comment)
Looks good generally
resolved
54 (other comment)
added just now
@shawn-nyk (33 comments)1 (commented on others PR)
Small issue, but should this line not begin with a whitespace? (Even though the syntax highlighting does not appear here on GitHub, I believe it still works to markdown the text in this case so shouldn't be an issue!)
2 (commented on others PR)
Should we markdown these lines with backticks as well, to put them in code format, as per the other examples?
3 (commented on others PR)
I assume we're using Person's Name and Phone classes for now since they help guarantee certain text properties. We'll probably have to change this in the future (at least the naming, for example wage being a Phone object seems odd)? Perhaps using String for now may keep things even simpler, but I suppose this works for now!
4 (commented on others PR)
Perhaps we could name this InternshipStatus or something along those lines instead? Do let me know if I'm mistaken, but it seems that we have a Job class that has the variables - jobTitle, companyName and industry. So this status object should be reflective of an Internship status rather than a Job status? Shall we ensure that "Job" and "Internship" are not interchangeable terms throughout our code base? Another issue that might still arise even after changing the name to InternshipStatus is that we will then have a Status and InternshipStatus class, and it may not be obvious what the difference is between the 2 in terms of their names? Would it be possible/better to make this a private enum within the Status class?
5 (commented on others PR)
I suppose having this field means in the UI, we'll have some text like "As of: date"?
6 (commented on others PR)
As we'll also need to add Jobs in a company object, this Job object seems to differ implementation-wise from the Job object that we may use for company objects, though they should probably be the same? For example, in a Company object, during its creation via a user command, the user can input multiple industries and jobs that a company has. This creates the Company object, along with its multiple jobs and industries. So in those Job objects in the Company object, will each of them have multiple industries tagged to them instead of just one industry as in this Job object? Also, since a Company stores Job objects, would this create a cyclical dependency if we change the Name companyName part to Company company in the future (I assume we will)? At this juncture, it seems that if Job is going to store Company and Industry, perhaps we may not even need Job objects? Perhaps we could simply use String (or Name) for jobs? This may also help to synchronize with how jobs will have to be represented in a Company object.
7 (commented on others PR)
Sounds good to me! Shall check with the rest if they're okay too! (Sounds like in the future we could perhaps repurpose the "Person" package to become like a text-format-enforcer package of sorts?)
8 (commented on others PR)
Ah I see, thanks for the clarification! I think the Status and ApplicationStatus names suggested work, but perhaps sticking to InternshipStatus might still be better so we don't introduce more terms for the same object (for e.g. application and internship both refer to internship applications)? So maybe swapping the current Status and InternshipStatus names will do? May have to consult the rest haha, just some suggestions!
9 (commented on others PR)
Ah okay! My bad for missing this out, thanks for highlighting!
10 (commented on others PR)
Should this return companyName instead?
11 (commented on others PR)
To stick to a standardization, shall we also rename the InternshipApplication class to InternshipApplicationItem?
12 (commented on others PR)
I believe these attributes for Company and Internship are the outdated ones?
13 (commented on others PR)
I see we've changed the tab name from plural to singular. I was wondering if it would be odd since the user would be looking at a tab labelled "Company" but in it can be multiple companies? Likewise for "Application" as well, which to me sounds like I'll view a single application if I click on it. Small matter but perhaps we could discuss this further and see what the team thinks too!
14 (commented on others PR)
Alright, no worries! Will merge this first and we can settle this next time.
15 (commented on others PR)
Just to confirm, does company application refer to internship application i.e. our application class in this case?
16 (commented on others PR)
Ah I see! Thanks for the clarification Sean!
17 (commented on others PR)
Just tried using the same line of code for the add company command I'm working on and yep, even upon successful addition of a company, this line of code does not switch tabs. Will follow Isaac's observation and see if I can make it work for add company in the time being!
18 (commented on others PR)
Just tried successfully on my end for add company command, regarding the switching of tabs, changing this to return new CommandResult(String.format(MESSAGE_SUCCESS, applicationItem), false, false, true); will do the trick!
19 (commented on others PR)
This works if all our commands require a switch? At the moment that seems to be the case apart from the help and exit commands if I'm not mistaken. Also, I suppose it depends on how we want our app to behave exactly - do we want it to switch every time a command is executed even if the user is already on the right page, or do we want to switch only if the user is on the wrong page? I suppose this may not be detectable visually unless the switching of tabs introduces its own behavior (for example if switching causes the list of cards to jump to the top of the list, and not switching allows the user to stay at wherever they've scrolled to in the list, then executing a command that always switches vs. one that only switches when necessary will provide different user experiences).
20 (commented on others PR)
Should the second argument be AddProfileCommand.MESSAGE_USAGE instead?
21 (commented on others PR)
Should this be outside of the exceptions package?
22 (commented on others PR)
Minor nit, but perhaps we could change this to setRequirements in the future? Just to keep all the namings consistent.
23 (commented on others PR)
Same thing regarding the tags naming here. Unless I'm misunderstanding the use of the word "tag" in the context of this UI portion of code. Apologies if that's the case!
24 (commented on others PR)
Perhaps this newline is an extra addition?
25 (commented on others PR)
Now that the return statements have been shifted into the if-else block, I think there may not be a need to declare a String resultMessage variable anymore on line 40? Perhaps we could just use return new CommandResult(sameScreenText, false, false, false, false); on line 44 and return new CommandResult(switchedScreenText, false, false, true, false); on line 49. This would help us keep in line with the coding standard rule - "Variables should be initialized where they are declared".
26 (commented on others PR)
Does reintroducing this line reintroduce the issue we faced where the user is currently on a tab and wants to view something on another tab, the app will switch to that tab but always show item number 1? (for e.g. user is viewing company tab and executes view me 3 and the app switches to profile tab but views the first item instead of the third)
27 (commented on others PR)
As all our list commands are going to have similar success messages, perhaps we could do what we did with the rest of the commands which would be to add something like this after line 25: String listSuccessMessage = String.format(MESSAGE_LISTED_ITEMS, APPLICATION_NAME); where MESSAGE_LISTED_ITEMS resides in Messages.java and goes something like: "Listed all %1$s items";? Just a suggestion!
28 (commented on others PR)
Is this redundant given that ListApplicationCommand can use ListCommand's COMMAND_WORD? This is with regards to how all the other commands exhibit the same pattern in that they use the parent's COMMAND_WORD.
29 (commented on others PR)
Super minor point, but with regards to the phrasing, I suppose this might read a little awkwardly for more than 1 item found, such as "3 company listed!"? But it's just the phrasing so it's not a big deal and we can probably handle this in the future if we want!
30 (commented on others PR)
Will this throw an inappropriate error message? Correct me if I'm mistaken, but does this throw the error message "Item type has to be either 'com', 'int', 'app' or 'me'"? If so, I believe that since we can't run switch int, should we revert back to the old error message / something along the lines of "Item type has to be either 'com', 'app' or 'me'"?
31 (commented on others PR)
Should we be using model.updateFilteredApplicationList() instead to avoid LoD violations?
32 (commented on others PR)
oh yea great idea!
33 (commented on others PR)
Yup true! Sounds good!
34 (commented on own PR)
True, this class is indeed very similar to the Name class. However, in order to do the following:
pass in the messageConstraints to signify a different error message if need to
perhaps we can modify the Name class to, say, take in an extra argument in its constructor for the messageConstraints variable, and then the passing in of this variable could be done by the Industry class that extends the Name class and simply passes its own messageConstraints through the parent (i.e. Name's) constructor via super(). As such, we'll reduce code duplication but still maintain the existence of the Industry class. I feel that it may be necessary to have such unique classes because variables such as private final Set>Industry> industries = new HashSet>>(); would look rather odd as private final Set>Name> industries = new HashSet>>();. And ultimately, in order to "pass in the messageConstraints to signify a different error message if need to", I believe we'll still need to have some sort of Name as parent class for subclasses such as Industry, Descriptor, Requirement, etc. arrangement, since Industry is not the only class affected by this / has this characteristic.
All that said, modifying Name and abstracting all the common fields to subclass from it at this juncture would be inappropriate in the context of this PR. Would it be okay if we let this portion through first and do the necessary abstraction / refactoring after all 4 items (inclusive of this Company item) are present in our codebase, as discussed in our Tele group?
35 (commented on own PR)
My bad, thanks for catching this!
36 (commented on own PR)
Oh yep great idea! I've made the changes!
37 (commented on own PR)
I can't shift it straight into the current if-else block due to the nature of the condition checking. If we want to make it all part of one block, here's an option:
if (model.getTabName() != TabName.APPLICATION) {
model.setTabName(TabName.APPLICATION);
shouldSwitchTab = true;
model.setViewIndex(targetIndex);
} else if (model.getViewIndex().equals(targetIndex)) {
resultMessage = messageAlreadyViewing;
shouldSwitchDisplay = false;
} else {
model.setViewIndex(targetIndex);
}
But this means model.setViewIndex(targetIndex) appears twice.
Another option is to simply remove the if condition and do:
if (model.getTabName() != TabName.APPLICATION) {
model.setTabName(TabName.APPLICATION);
shouldSwitchTab = true;
model.setViewIndex(targetIndex);
} else if (model.getViewIndex().equals(targetIndex)) {
resultMessage = messageAlreadyViewing;
shouldSwitchDisplay = false;
}
model.setViewIndex(targetIndex);
But this means that even when the model's view index is already the index that the user inputs, we still set it anyway (unnecessary call to setViewIndex). It won't affect the program though.
Between the current code and these 2 options, which do yall think is better? Or are there other alternatives yall may have?
38 (commented on own PR)
Hi Keane! Unfortunately that would not be possible. Variables can't be declared in an if-else block and then used outside of it due to variable scope. Even doing something as simple as:
if (true) {
boolean shouldSwitchTab = false;
} else {
boolean shouldSwitchTab = false;
}
shouldSwitchTab = true; // line X
Will lead to an error on line X whereby it doesn't detect that shouldSwitchTab has been initialized.
(More on it here: https://stackoverflow.com/questions/17444020/why-cant-variables-be-declared-in-an-if-statement)
As such, this already is the smallest possible scope!
39 (commented on own PR)
To justify having these boolean vars initialized and declared where they are, we can take it that by default, we assume the user in on the appropriate tab (shouldSwitchTab = false) and not viewing the current item (shouldSwitchDisplay = true) which is why they would want to execute the view command in the first place. However, they may happen to be on the wrong tab (first if statement checks for that), or they may happen to be on the right tab and already viewing the item (the following else-if statement checks for that). That is how I would intend the code to be read!
40 (commented on own PR)
Ah good question! I raised this in our Tele group last night, but basically how the view index works is that it takes the index from the tab that is currently in view. So for example, if a user is on say the Application tab and he is viewing the 3rd Application, if he executes view com 3, if we do not check for the tab first, then the program will simply think we're already viewing the 3rd item so it doesn't need to do anything, which is wrong of course. That said, now that you've raised this point, I believe I may be able to abstract away the first if statement, but I'll definitely need that condition check in the else-if statement that checks for if the user is on the same tab and currently viewing the indexed item. So I can minimize the tab checking but we need that one minimally.
41 (commented on own PR)
Ah my bad! But then will we be violating this coding standard rule?
42 (commented on own PR)
No problem, thanks for highlighting! Have made the changes!
43 (commented on own PR)
Oh if that's the case, sure I don't mind changing it! But then again I'm not sure if our evaluators have the same understanding though? For example when we eventually evaluate our peers' work, I would probably follow the coding standard to cross-check my evaluation and if I spotted this violation in their work, I would probably just mark it as a violation since it is stated in black and white and not have to think too much. If you have the source, could you point me to where Prof Damith mentioned that we could do otherwise? Would be much appreciated!
44 (other comment)
Overall looks great. Good job. Just a few nits and it will be good to merge.
Thanks for pointing them out Sean! Have gone ahead to fix those inconsistencies across the whole doc.
45 (other comment)
Overall looks great! Just wondering if grouping the 2 stars and 3 stars together would be better? Perhaps edit an object should be considered a high priority as well? Otherwise LGTM
Ok! Made the edit commands high priority, which solved the 2/3 star grouping issue as well!
46 (other comment)
Hmm. The dilemma now is that this is just a proof of concept and we may be abstracting common logic down the line and scrapping all these, so overwriting Javadocs now may redundant. The danger is that if the code is kept and the comments are missed in the future. What is the team's opinion on this? @ZoroarkDarkrai @keanecjy @seanjyjy @shawn-nyk
I agree that overwriting Javadocs now may be redundant, especially because our code can change over time up until the final version. At the same time, I also agree that we may miss them in the future, and doing a one-time run-through of all our code at the end may be very tedious and error-prone. As such, how about we do something like: every time we create new bits of code that require Javadocs, or we modify code that already has Javadocs attached to them, we place a standardized comment, such as TODO: Javadocs above the code we need to write/edit Javadocs for? That way we get the syntax highlighting that IntelliJ provides for the TODO keyword, and we can also search for this standardised comment throughout the code base to hone in on where we'll eventually need to write/edit Javadocs when the time comes. Any thoughts on this?
47 (other comment)
Great work! I noticed you helped to check all our commands to ensure consistency in the messages too. Just need to fix some checkstyle issue before merging can be done.
Thanks Keane! And oops my bad, made some last minute changes and pushed after I first made the PR (introduced some checkstyle errors in the process). I've made a few other further changes to remove some hard-coded messages and make our add commands' success messages similar in execution to that of delete commands (calling upon the Messages class). For your vetting!
48 (other comment)
Besides the point that @keanecjy has raised, I believe it is good to merge after it is resolved.
Thanks Sean! Have made the changes!
49 (other comment)
To explain this code:
Line 43 executes a function that creates delete int commands and executes them, causing the model's internal tab name to be set to company. Thus, before that line is executed, we need to save the current actual tab the user is on, which is done in line 40. Since we are checking against this saved tab instead of the model's current tab (would become company because of line 43), we cannot use the CommandUtil.getCommandResult() method.
@ZoroarkDarkrai (33 comments)1 (commented on others PR)
@seanjyjy is going to redo this part(?) so should I ignore this?
2 (commented on others PR)
Could be confusing saying job name because the format actually uses the position of internship in the company?
3 (commented on others PR)
I don't think these are the right precondition and guarantees?
4 (commented on others PR)
just a nitpick but I noticed that other use cases use list user profile items instead user profile item?
5 (commented on others PR)
shouldn't precondition be the state of the system and not the user?
6 (commented on others PR)
Another nitpick, maybe it's better to use InternHunter rather than the app? As the next points use InternHunter rather than the app?
7 (commented on others PR)
I think you missed this comment?
8 (commented on others PR)
I think you missed this comment?
9 (commented on others PR)
I think you missed this comment an others below too?
10 (commented on others PR)
should be instanceof UserProfile?
11 (commented on others PR)
is it the user profile?
12 (commented on others PR)
type is category right? because it can only be either education, skill, or achievement should it be an enum instead?
13 (commented on others PR)
I assume this is a planned extension for the profile items to have tags?
14 (commented on others PR)
should be two profile items? and several comments below
15 (commented on others PR)
should be profileItem? and for other comments below too
16 (commented on others PR)
wrong exceptions in this file or are they placeholders?
17 (commented on others PR)
Is it switching to the applications tab?
18 (commented on others PR)
I noticed you changed of a company to in a company for others
19 (commented on others PR)
for consistency maybe use tab because we usually describe them as tabs and not pages(?) for this and others below
20 (commented on others PR)
this is a really small nitpick but i feel the flow of the second sentence can be improved? just feel a bit weird having the if any in the middle.
maybe something like any applications with the deleted internship, will also be deleted?
21 (commented on others PR)
is this safe when string length is >= 1? or is it guaranteed that the length > 1?
22 (commented on others PR)
validity?
23 (commented on others PR)
any reason why an assert instead of an exception?
24 (commented on others PR)
CMIIW:
2 application items are equal if their internshipItem, status, and statusDate are all the same.
deepDelete uses the above equality to delete things.
ApplicationItem(internshipItem) will create a new application item with the default status and statusDate
The application with the internship we are deleting may not have the default status and statusDate?
25 (commented on others PR)
shouldn't this be the javadoc for the method below?
isn't util just a general purpose utility class?
26 (commented on others PR)
Why does it have higher cohesion?
Isn't low dependency --> low coupling?
27 (commented on others PR)
"Coupling is a measure of the degree of dependence between components, classes, methods, etc. Low coupling indicates that a component is less dependent on other components." ?
28 (commented on others PR)
"Only dependent on the one Item type" --> low dependency --> low coupling?
29 (commented on others PR)
?
30 (commented on others PR)
what is this for?
i mean if it's abstract it can't be initialized anyway right?
31 (commented on others PR)
internship?
32 (commented on others PR)
I think i missed why is it limited to 2 words in particular?
33 (commented on others PR)
honestly I don't think this is a good idea?
suppose the requirement is "c" a common programming language, it will literally match with any word with a letter c (like cooking) or java with javascript, etc.
34 (commented on own PR)
oh yeah, thanks for noticing 😅
35 (commented on own PR)
Sure!
36 (commented on own PR)
Yes, would it be better to start from empty ones? Will change it then.
37 (commented on own PR)
Nope, the storage just need the isValidMethod
38 (commented on own PR)
Ahh forgot to change it back, was testing. Same with the application item one. Thanks
39 (commented on own PR)
Hmm, it's copy and pasted from AB3's. Hahaha.
40 (commented on own PR)
Sure?
41 (other comment)
I noticed that many of the javadocs used "person" and "address book", should we change it now? or leave it for later?
42 (other comment)
LGTM, good work! Some merge conflicts to resolve first.
Fixed!
43 (other comment)
lol i just pushed the change
44 (other comment)
I think it's okay just I find many hard coded strings can be converted to const. If urgent can merge now and fix later?
Is it not normal to use hard-coded strings for test cases? Could you point on where exactly is the issue? Thanks
I mean the toString, equality, hashcode tests. Could use VALID_WAGE, VALID_PERIOD, etc? If it's a better practice to use "Sunday", "React Native", etc. it's fine then.
45 (other comment)
I think it's okay just I find many hard coded strings can be converted to const. If urgent can merge now and fix later?
Is it not normal to use hard-coded strings for test cases? Could you point on where exactly is the issue? Thanks
I mean the toString, equality, hashcode tests. Could use VALID_WAGE, VALID_PERIOD, etc? If it's a better practice to use "Sunday", "React Native", etc. it's fine then.
Not too sure what's the correct which is the correct way, but I just thought that doing it this way by writing 2 strings that are different objects would be better since we will be comparing periods with different strings in the actual implementation too
Sure then! I just thought maybe using constants could make it easier to see, that creating an object with the same input will result to an equal one. Like 2 objects created with VALID_PERSON_ALICE are equals but not with one created with VALID_PERSON_BOB.
LGTM!
46 (other comment)
I don't think you should be writing tests for ApplicationItem, Status, and StatusDate? Since we should be writing tests for our own classes and not helping others write their tests
Oh, I think I misunderstood then. When I said I couldn't do the storage ones then because lack of sample data, I think someone said I should do the application ones. So, do you want me to remove them?
47 (other comment)
I don't think you should be writing tests for ApplicationItem, Status, and StatusDate? Since we should be writing tests for our own classes and not helping others write their tests
Oh, I think I misunderstood then. When I said I couldn't do the storage ones then because lack of sample data, I think someone said I should do the application ones. So, do you want me to remove them?
Oh what I meant was create sample data for the storage tests and not to test the application classes themselves. So the rest of the files can stay except for
ApplicationItemTest,StatusTestandStatusDateTest. Hope this clarifies!
Ok, removed them!
48 (other comment)
LGTM!
49 (other comment)
Nvm I'll just merge this first
50 (other comment)
LGTM, need to resolve some conflicts
resolved
@Wincenttjoi (33 comments)1 (commented on others PR)
Would item added to inventory be better?
2 (commented on others PR)
Should we add the app's ability to handle table reservations and pending deliveries? (like in Mock UI)
Since this is the final product's aim
3 (commented on others PR)
If I rmb correctly, the following word after @return it should be the type, then description for subsequent words
4 (commented on others PR)
Is this change to /11.0.1 automated by your intellij system or you changed it manually?
5 (commented on others PR)
>StackPane fx:id="deliveryListPanelPlaceholder" minHeight="-Infinity" prefHeight="440.0"
6 (commented on others PR)
private StackPane deliveryItemListPlaceholder;
Just to keep it more consistent with itemListPanelPlaceholder, what do you think? Just some minor stuff
7 (commented on others PR)
Is this meant to be DeliveryListCard.fxml or sth along that line? Or you plan to merge the different cards into same style hence they both refer to ItemListCard?
8 (commented on others PR)
Is this misleading? chicken and CHICKEN is meant to be the same?
9 (commented on others PR)
* Only full words will be matched e.g. `chicken` will not match `chicken`
10 (commented on others PR)
Shall we have multiple summary tables for each component (inventory vs delivery), since not all commands necessarily overlap?
Nothing to change here, just need your suggestion. I can make the amendments in my PR.
11 (commented on others PR)
Thanks for abstracting this out for base Model.
We'll follow this moving onwards 👍
12 (commented on others PR)
Oops sorry didnt read properly, thought it was a typo!
13 (commented on others PR)
And should be phone, not quantity! Hahah
14 (commented on others PR)
+ PREFIX_ADDRESS + "ADDRESS "
15 (commented on others PR)
+ PREFIX_PHONE + "PHONE "
16 (commented on others PR)
Can just check why are the types opposite?
17 (commented on others PR)
Ah nvm my mistake, understood whats happening alrd
18 (commented on others PR)
I'm not really sure with myself either, but doesnt RAM depends on the user's device?
19 (commented on others PR)
Not sure if this is relevant? Feels abit iffy to me
20 (commented on others PR)
It doesn't need a network at all? Refer to number 14
21 (commented on others PR)
Do you want to include the key arrow up feature to go back to previous command entered in commandBox? Trivial but like cool only
22 (commented on others PR)
Was actually thinking to let @wengfaing do this part since he needs some boost to meet his functional code req! (Maybe for the other help start window)
23 (commented on others PR)
You mean Models#undo for the second one?
24 (commented on others PR)
<div markdown="span" class="alert alert-info">:information_source: **Note:** If the current pointers are pointing to the latest state, then there are no undone InventoryBook/ DeliveryBook states to restore. The `redo` command uses `InventoryModel#canRedo()` and `DeliveryModel#canRedo()` to check if this is the case. If so, it will return an error to the user rather than attempting to perform the redo.
25 (commented on others PR)
Frm my understanding NFR needs to be something that is within our control, but in this case its more like dependent on the user and not within our control. Maybe can be rephrased like: Storing 100 states of undo and redo command models should take up less than ... Kb?? What do you think
26 (commented on others PR)
Quite curious about this as well. Maybe we should summon @AaronCQL ? Hi what do you think
27 (commented on others PR)
Nah its ok! whats done is done dont have to revert back because you alrd spent the time and effort
28 (commented on others PR)
Step 5. The user then decides to execute the command `list-i`. Commands that do not modify the inventoryBook/ deliveryBook, such as `list` and `find`, will usually not call `Models#commit()`, `Models#undo()` or `Models#redo()`. Thus, the `inventoryBookStateList` and `deliveryBookStateList` remain unchanged.
29 (commented on others PR)
I think 6 and 7 can be combined!
30 (commented on others PR)
Wanna specify the commands? Maybe add delete these basic functionalities can be 1s. Then sort/ find can be 2s? Regardless of data size
31 (commented on others PR)
I dont really understand this though, is there a better way of rephrasing?
32 (commented on others PR)
Sounds iffy and seems like something that is googled and copy pasted hahah, shall we remove? I think quality > quantity
33 (commented on others PR)
Would it be relevant? Because we know that this is a software and not hardware
34 (commented on own PR)
@halcon-blanco thanks, amended!
35 (commented on own PR)
Sure, I will include a different colour for that as well
36 (commented on own PR)
Made the necessary changes including the test case
37 (commented on own PR)
@halcon-blanco Thanks for pointing out, I've changed to saveDateTime
38 (commented on own PR)
@zeranium97 Thanks! Updated
39 (commented on own PR)
Thanks for spotting, remedied.
40 (other comment)
This is for the case where restocking is needed, etc
41 (other comment)
Should add be able to handle restocking? Ie whereby if the name and supplier is the same, quantity of that particular stock will be increased by the amount stated.
42 (other comment)
LGTM, rmb to accept and merge with previous PRs first (if possible) to prevent excessive conflict next time 🤙
43 (other comment)
Thanks for the name refactoring, LGTM
44 (other comment)
Thanks for info, will trace and refactor this to make it work and PR again
45 (other comment)
LGTM 👍
46 (other comment)
You have to rebase/ merge with master first and deconflict before PR or it will get rejected
47 (other comment)
Oops sorry I just realized this is for tutorial.. I thought its meant for actual PR to be merged hahah
48 (other comment)
https://www.figma.com/file/bwoqFizIJKUu1bA8WqLzuq/Untitled?node-id=0%3A1
49 (other comment)
@xnoobftw one way is to not put preferences.json inside gitignore, but this default value is meant for first time users. Since all of us are developers, its okay to delete it (because users perspective as first time users they will not have the preferences.json)
50 (other comment)
LGTM for this version, we will make further nits along the way in this project for UG DG 👍
51 (other comment)
@wengfaing do you want to add the relevant unit/ integration tests first for this command? Including parser for the command, logic, etc. Or do you prefer to do these tests in next iteration?
52 (other comment)
Sure, LGTM for this implementation! We can make the remove unit tests' tasks during next iteration
53 (other comment)
@halcon-blanco @xnoobftw understand that you guys are working tgt and need to pull from each other, but a suggestion would be to merge a feature-in-progress in another organization branch instead of master next time, just for a good workflow practice but no big issue 😃
54 (other comment)
@zeranium97 there's conflicting files, just rebase your commits and we'll review again 👍
55 (other comment)
A delivery model requires name, phone, address and order. Is the PR meant to be complete or is it WIP? Just checking because I can't seem to find any of these in the PR
56 (other comment)
It's to be implemented by @zeranium97 when he implements storage
Ok sure, since its in another branch we'll merge it first. Praying hard it'll work well so that we can merge into master 👍
57 (other comment)
Errors not caught:
remove 1
remove 1 q/-123
remove 1 q/
remove 1 q/ASDF
Would be great if you can do unit testings for these too. Thank you! @wengfaing
58 (other comment)
@halcon-blanco i'm fine with this, since we might need to change again in the future into 3 sections so no issue. For the colouring, is it easy to implement colouring to be conditional (red vs green if stock falls below 20%)? If its a huge task we can create a separate task.
Further improvement:
Low priority: I didn't do the GUI for help toolbar on top to open up the 2 different help windows since the app is meant for CLI primarily. But feel free to connect them if you want 😃
59 (other comment)
WIP: as discussed in #95
GUI help window toolbar
Colouring difference (red vs green)
Please tick once done so that we know when to merge 👍
60 (other comment)
@zeranium97 oh yes remember to assign PRs you made to yourself as well as the milestone. This one is just for admin purposes so that cs2103 can track (yes it doesn't matter in v1.2b but just reminding for future milestones)
61 (other comment)
@zeranium97 Are you also catching other exceptions as the scenarios mentioned in #105 comments?
62 (other comment)
@Wincenttjoi I've made the changes you requested, plus changed the whole structure of the DeliveryList GUI to match that of the ItemList. (Tonnes of headache cuz debugging GUI is super hard).
I also wrote the basic code in MainWindow.java for initialising the values into the DeliveryList on starting the app, with currently an empty ObservableList being initialised temporarily. The Delivery class I wrote is also currently just a stub with no functionality.
Thanks for changing and doing more than required! LGTM
63 (other comment)
Do you plan to do the other exceptions? If not then I can merge this PR first for now. Thanks @zeranium97 !
64 (other comment)
@xnoobftw @halcon-blanco sure, if want to make it flexible its fine too. I'll close this thanks!
65 (other comment)
Is there any other exceptions I might have missed out for this command?
Only those 4 checkboxes i've put in #105. Can't really check if it works for all 4 in my internal application since we're still forced to do in forking workflow. If all's good then can merge 👍 Help me check on your side please
66 (other comment)
LGTM thanks!
67 (other comment)
its ok @wengfaing i'll help you do the tests
68 (other comment)
Just want to check if you're bothered by the naming? Because sometimes I get confused that Item is actually referring to only Inventory. Sometimes I would think of Inventory item vs Delivery item (Item is the umbrella term for the different types)
Any thoughts for this? If you're okay with I'll see what I can refactor in next PR too
69 (other comment)
Just want to check if you're bothered by the naming? Because sometimes I get confused that Item is actually referring to only Inventory. Sometimes I would think of Inventory item vs Delivery item (Item is the umbrella term for the different types)
Any thoughts for this? If you're okay with I'll see what I can refactor in next PR too
I think our understanding is that Item refers solely to inventory item
Ok can! We'll keep it as such then np. LGTM. Test cases we will push it to nxt milestone!
70 (other comment)
@AY2021S1-CS2103T-T12-1/developers do you guys prefer to standardize Order to not be able to accept empty string or just space? I can add the VALIDATION REGEX if you want, because the rest of the delivery objects seem to have this as a minimum req.
71 (other comment)
things to be added
- Command & Parser testcase
Are you planning to add it in this PR or another PR?
72 (other comment)
I will be adding it into this later tonight
@zeranium97 Ok, normally a common practice that people use if the PR is not ready they will use WIP in the header. Changed for you! **Ofc the CI needs to be put first and I just made a PR for that
73 (other comment)
We PR once u done the test cases first?
74 (other comment)
LGTM thanks!
75 (other comment)
@zeranium97 U forgot to add a test for the add parser
In case you wanna do feel free hahah!
76 (other comment)
@xnoobftw If you are okay with implementing, I think it would be good to return a message on the commandbox to make it consistent with other commands
77 (other comment)
@xnoobftw If you are okay with implementing, I think it would be good to return a message on the commandbox to make it consistent with other commands
May i know what you mean by this?
So an example would be after the command sort ... a line should return on the command box
A possible reply would be like: You inventory item/delivery is sorted according to .............
78 (other comment)
@AY2021S1-CS2103T-T12-1/developers sorry that I couldn't attend the impromptu meeting. Just a short question, I'm curious why exactly sequence diagram for delete command but not others? Is there a specific reason?
79 (other comment)
@xnoobftw
do you want to add small note on ur diagram to briefly describe what XYZ is?
Arrow for >>Interface>> Parser on the Parser section is abit misleading, mind to remedy that to make it more coherent?
Perhaps you can also bring the Command and Parser box bigger (filling up >80% of the space) bcs there's too much white space and its too small for people to see. Size of individual blue boxes can also increase in size if you dm 👍
Executes labelling on command part not clear on which line it should belong to
HelpCommandResult extends from CommandResult missing
I think there's no more concrete XYZCommand since they are all extracted to the smaller commands (items, delivery, help)
@AY2021S1-CS2103T-T12-1/developers feel free to discuss bcs i'm not 100% sure either
80 (other comment)
- Will do!
- Do you mean having a solid line? Because it's how its represented in AB3
- Do you mean increasing the font size?
- The PUML auto generates this D:
- Added! Thanks
- Redo, Undo command still does! exit too
@xnoobftw
Nope, I only meant the starting point of the line bcs its overlapping with the line on the left
The overall box size as well as individual boxes (inside) size, and font size
Oops its fine then!
Yes just realized that too, my mistake!
81 (other comment)
@xnoobftw try to occupy the diagram >80% of the picture! If not too small hahha.
Edit: I realized that we can't reposition the arrows, just saw the documentation hahah. Not sure if 2 is doable
82 (other comment)
@halcon-blanco I think this must be done before tutorial!
83 (other comment)
Idt 2 and 3 is doable due to puml automating it
But does this fulfil ur requirement!
@xnoobftw
Can check this out for 3 https://plantuml.com/skinparam
Reason being is because we need to make our dg comprehensible thats why we shdn't just leave this out even though it seems trivial
Yup looks good! (Apart from box sizing)
84 (other comment)
Increased fontsizes to 30!
Thanks! Sorry one last thing, you forgot to change the link in your Logic component description, its still referring to addressbook link
85 (other comment)
@xnoobftw oh thanks. Its bcs I saw not green yet in the team project progress hahah, thanks!
86 (other comment)
LGTM thanks!
87 (other comment)
@AY2021S1-CS2103T-T12-1/developers the rest going to review? I might missed out on a few things here and there.. Would be good if everyone take a look before approving DG PRs
88 (other comment)
There's a couple of errors in the diagram! Check out the ss i tagged
Does inventoryModelManager has Item? Not sure about this, or is it referring to the FilteredList>Item> filtered Items?
Same goes for deliveryModelManager
89 (other comment)
And another update! I dont see a uniquetaglist class in the folder unless im mistaken! and i dont think we should show inventory book in the item class diagram
Actually I think its fine with or without the InventoryBook, because the reader can see how its connected to the component outside Item. Seems like @zeranium97 has changed it to without but im fine with either! (Personally think with is better tho)
90 (other comment)
@halcon-blanco you can CTRL F address and see the relevant addresses to be changed hahah, still got more
91 (other comment)
LGTM Thanks!
92 (other comment)
@halcon-blanco made the changes as requested
@xnoobftw (32 comments)1 (commented on others PR)
maybe leaving commented code could get confusing in the future?
2 (commented on others PR)
@Wincenttjoi
3 (commented on others PR)
hi @Wincenttjoi
4 (commented on others PR)
Perhaps initializing maxQuantity to a value other than "0" is a better idea? Similarly to tags maybe leaving it empty is fine
5 (commented on others PR)
Perhaps not checking is fine too? Since we do not require max quantity to be a mandatory field. Having this check will go against our design
6 (commented on others PR)
Similarly if maxQuantity can now be empty i think having a method to check if maxQuantity is null prior to this block of code would prevent a parsing error
7 (commented on others PR)
Similarly to tag i think initiazing to a 0 is not a good idea because we'll eventually be using it to calculate percentages
8 (commented on others PR)
Agree. MaxQuantity is an Optional>Quantity>
9 (commented on others PR)
should quantity come before item name?
10 (commented on others PR)
Should be address, not supplier
11 (commented on others PR)
HAHA i think we should just commit on his behalf. it's a minor issue
12 (commented on others PR)
@halcon-blanco as discussed in telegram, we should probably create a wrapper class so we can make use of polymorphism instead of using instanceof
13 (commented on others PR)
But for now let's implement the rest on top of this first
14 (commented on others PR)
Should it check for deliveryModel to be nonNull too?
15 (commented on others PR)
Should it check for deliveryModel to be nonNull too?
16 (commented on others PR)
@halcon-blanco i have a suggestion. We should make use of DeliveryCommand and ItemCommand abstract class to have a abstract method execute that takes in its respective model. This will adhere to OpenClosed principle better
17 (commented on others PR)
I feel that similarly to the command Hisotry there should be a limit of how many times u can redo incase of memory overflow
18 (commented on others PR)
Like limit the number of state stateList holds
19 (commented on others PR)
In my experience with CommandHistory's previousCommand(), be wary of the corner case if suppose:
you have 2 states, state#1, state#2
undo() should return you to state#2 and not state#1.
Could you give that a shot? Maybe either via junit tests or manual testing
20 (commented on others PR)
This is a complication from having the pointer pointing at the last element of the list
21 (commented on others PR)
Nvm ignore me i've read through your implementation and realised its different
22 (commented on others PR)
Perhaps instantiate arraylist with a initial capacity to optimize performance (remember from 2040s they taught us that arraylist copies over and doubles in size everytime its limit is hit)
23 (commented on others PR)
Eg private static List>DeliveryBook> deliveryBookStateList = new ArrayList>>(MODEL_STATE_LIMIT);
24 (commented on others PR)
and i feel that it shouldn't be a static variable simply because we may use different instantiation of deliverybooks in testing as well
25 (commented on others PR)
i think a better condition would be canRedo() instead
26 (commented on others PR)
having it as canRedo optimizes performance as we only really need to do a copy if there exist downstream "commits"
27 (commented on others PR)
ArrayList.size() != Capacity btw @halcon-blanco
28 (commented on others PR)
Thanks!!
29 (commented on others PR)
shall merge into master first so others can work with new design prior to implementing undo/redo tests
30 (commented on others PR)
Add
undoThenUndoThenRedo test
and
undoThenUndoThenRedoThenRedo test
31 (commented on others PR)
maybe state what for!
32 (commented on others PR)
same here
33 (commented on own PR)
Yeap that sounds better! Made changes
34 (commented on own PR)
just pushed! take a look
35 (commented on own PR)
Fixed! thanks for pointing it out!
36 (commented on own PR)
Same! Fixed
37 (commented on own PR)
Take a look now! added comments
38 (commented on own PR)
Fixed! take a look!
39 (commented on own PR)
to adhere to similar level of abstraction in the code
40 (commented on own PR)
Done! Take a look
41 (commented on own PR)
o it's auto generated by intellj HAHA but i'll change it to match!
42 (commented on own PR)
The method name would be misleading in my opinion
43 (commented on own PR)
Attempting to do it now
44 (commented on own PR)
Done! @halcon-blanco please check
45 (commented on own PR)
@halcon-blanco did that! it turns out this helped iron out bugs so much thanks!
46 (commented on own PR)
I changed it to updateItemListFilter!
47 (commented on own PR)
Opps my bad! Thanks for pointing it out
48 (commented on own PR)
Changed!
49 (commented on own PR)
Changed!
50 (other comment)
wednesday 16th September 2020 8pm start coding
51 (other comment)
@Wincenttjoi yeap that's the plan. it's in this week's tutorial submission
52 (other comment)
buggy PR
53 (other comment)
Highly likely it's because of preference.json as AB3 tries to read userpref before inputting default values for GUI
54 (other comment)
Would it be possible for it to bypass preferences.json by ignoring the presence of it instead of manually deleting the file?
55 (other comment)
@xnoobftw one way is to not put preferences.json inside gitignore, but this default value is meant for first time users. Since all of us are developers, its okay to delete it (because users perspective as first time users they will not have the preferences.json)
sounds good! LGTM
56 (other comment)
LGTM!
57 (other comment)
Hi @halcon-blanco could u comment out the failed test cases so i know which ones to work on + CI wont fail? Thanks!
58 (other comment)
@wengfaing btw have you fixed this in your add metric PR?
59 (other comment)
A delivery model requires name, phone, address and order. Is the PR meant to be complete or is it WIP? Just checking because I can't seem to find any of these in the PR
It's to be implemented by @zeranium97 when he implements storage
60 (other comment)
IMO having more space for delivery makes sense as it composes more information
61 (other comment)
Disagree. Different restaurants may use different kinds of metrics and having metrics follow enums we may not cover all cases. In such cases edit command would suffice to correct the error
62 (other comment)
You mean whether the search word is a substring of item?
63 (other comment)
could we implement that just for phone number and address?
64 (other comment)
Delivery order sounds good! We could potentially reuse Quantity from Items package
65 (other comment)
@halcon-blanco isit okay if u took this? Since you implemented find for delivery!!
66 (other comment)
Refer https://github.com/AY2021S1-CS2103T-T12-1/tp/commit/0f5717d4ac91e4074c182c77b4ffb670eb78f0fe
67 (other comment)
as discussed with @halcon-blanco , we feel that having a wrapper class that holds instantiation of both DeliveryModel and InventoryModel is better than having to use instanceof to check and having to overload the Command#execute method due to huge amount of repetition of code
Following the wrapper class idea adheres to SLAP principle more than the latter solution
@AY2021S1-CS2103T-T12-1/developers FYI
68 (other comment)
@xnoobftw If you are okay with implementing, I think it would be good to return a message on the commandbox to make it consistent with other commands
May i know what you mean by this?
69 (other comment)
@xnoobftw If you are okay with implementing, I think it would be good to return a message on the commandbox to make it consistent with other commands
May i know what you mean by this?
So an example would be after the command
sort ...a line should return on the command box
A possible reply would be like: You inventory item/delivery is sorted according to .............
If i'm not wrong our agreement was that sorting will be done implicitly and does not require a sort command
70 (other comment)
Refer https://github.com/AY2021S1-CS2103T-T12-1/tp/commit/977699417b62170546c6bb6c477710e13d9b377b
71 (other comment)
Because there's alrdy one from AB3 and it's easier to refactor then to do from scratch
72 (other comment)
And I accidentally did it actually in my PR
73 (other comment)
HAHAHAHAH @halcon-blanco
74 (other comment)
@xnoobftw
- do you want to add small note on ur diagram to briefly describe what XYZ is?
- Arrow for >> Parser on the Parser section is abit misleading, mind to remedy that to make it more coherent?
- Perhaps you can also bring the Command and Parser box bigger (filling up >80% of the space) bcs there's too much white space and its too small for people to see. Size of individual blue boxes can also increase in size if you dm 👍
- Executes labelling on command part not clear on which line it should belong to
- HelpCommandResult extends from CommandResult missing
- I think there's no more concrete XYZCommand since they are all extracted to the smaller commands (items, delivery, help)
- Sequence diagram for logic seems ok
Will do!
Do you mean having a solid line? Because it's how its represented in AB3
Do you mean increasing the font size?
The PUML auto generates this D:
Added! Thanks
Redo, Undo command still does! exit too
75 (other comment)
@xnoobftw try to occupy the diagram >80% of the picture! If not too small hahha.
Edit: I realized that we can't reposition the arrows, just saw the documentation hahah. Not sure if 2 is doable
Idt 2 and 3 is doable due to puml automating it
But does this fulfil ur requirement!
76 (other comment)
It's enabled
77 (other comment)
refer https://github.com/AY2021S1-CS2103T-T12-1/tp/commit/977699417b62170546c6bb6c477710e13d9b377b
78 (other comment)
Idt 2 and 3 is doable due to puml automating it
But does this fulfil ur requirement!
@xnoobftw
Can check this out for 3 https://plantuml.com/skinparam
Reason being is because we need to make our dg comprehensible thats why we shdn't just leave this out even though it seems trivial
Yup looks good! (Apart from box sizing)
Increased fontsizes to 30!
79 (other comment)
There's a couple of errors in the diagram! Check out the ss i tagged
80 (other comment)
And another update! I dont see a uniquetaglist class in the folder unless im mistaken! and i dont think we should show inventory book in the item class diagram
81 (other comment)
Remember multiplicity and deliverybookstorage is an interface!
82 (other comment)
Is there anyway to adjust so that the multiplicity is not blocked? Try increasing the lenght of the arrow
@claracheong4 (32 comments)1 (commented on others PR)
Change e to to another more descriptive name?
2 (commented on others PR)
Similarly for this, change e to a more descriptive name.
3 (commented on others PR)
change address to description
4 (commented on others PR)
change address to description
5 (commented on others PR)
Should we remove all the tutorials?
6 (commented on others PR)
change to package seedu.momentum.logic.commands;
7 (commented on others PR)
Do we really need to store the entire project object in a timer?
8 (commented on others PR)
Maybe we generate and use an unique project id?
9 (commented on others PR)
calculate looks quite long, maybe you can abstract out some of the logic here?
10 (commented on others PR)
I think the @param should end with a full stop.
11 (commented on others PR)
The method is > 30 lines. I see you tried to reduce the length of the method with combinePredicates but I think you can abstract more of the logic.
12 (commented on others PR)
Similarly, full stop for @param
13 (commented on others PR)
Here also the full stop for @param
14 (commented on others PR)
.
15 (commented on others PR)
Maybe you can store "Kurz Elle Kunz" as a String variable since you used it more than once in this class?
16 (commented on others PR)
Similarly for the starbucks elephant cats here
17 (commented on others PR)
And friends owesMoney here
18 (commented on others PR)
Similarly for "\\s+"
19 (commented on others PR)
Similarly for "Alice Bob"
20 (commented on others PR)
Store the array as a private static variable also?
21 (commented on others PR)
Also for the "Alice Bob" in this class
22 (commented on others PR)
Maybe change the getFormatted method in deadline to return no deadline set when there is no deadline instead so that a project does not have to know whether it has a deadline.
23 (commented on others PR)
New line needed before @throws
24 (commented on others PR)
Make name implement a comparable instead?
25 (commented on others PR)
The method is quite long, maybe extract this into another method?
26 (commented on others PR)
similarly for this
27 (commented on others PR)
and this?
28 (commented on others PR)
. for @params
29 (commented on others PR)
Also for this
30 (commented on others PR)
Empty @return
31 (commented on others PR)
line before @param
32 (commented on others PR)
line before @param
33 (commented on own PR)
fixed
34 (commented on own PR)
fixed
35 (commented on own PR)
I think 8 spaces not 4. Changed to 8 spaces.
36 (commented on own PR)
Hmm I don't think is matters
37 (commented on own PR)
Name is not optional right?
38 (commented on own PR)
maybe just include as coming soon
39 (commented on own PR)
Fixed
40 (commented on own PR)
Hmm not sure
41 (commented on own PR)
Changed to edit
42 (commented on own PR)
Yeahh we should
43 (commented on own PR)
Yupp
44 (commented on own PR)
Not sure, but if we add a bunch examples, then a table would be like 1 line | a lot of lines
45 (commented on own PR)
Fixed
46 (commented on own PR)
Fixed
47 (commented on own PR)
Fixed
48 (commented on own PR)
This is to show deletion of a deadline so the deadline "created" is an empty one.
49 (commented on own PR)
It's just the work of reformat code to align with the next @param
50 (commented on own PR)
I'm not sure, both will have the same behaviour but its more of a parse error than unable to execute command error since it is related to validity, but this will make the overall design better?
51 (commented on own PR)
I think the main reason to include check for created date is to ensure that we will never run into a utc offset problem, rather than making sure the deadline is actually after the created date and we are also not currently storing the created time. So I think its fine since only the created date is stored as long as the date of the deadline is later than created date we can just take it as valid.
52 (commented on own PR)
Anyways I decided to change it
53 (other comment)
Time is compulsory for LocalDateTime in java.time so unless a dummy time is added in, LocalDateTime cannot be used.
I think it would be cumbersome to try to differentiate between the dummy time and the actual time if any. I think this mainly has to do with the backend part.
Then since the time and date is separated, it would easier to parse them separately.
54 (other comment)
I think I will create a general date superclass then make datetime, date and time inherit from it.
55 (other comment)
After checking the hierarchy of java.time, I realised the only common class ancestor of Date, Time and DateTime is java.lang.Object but they do implement similar interfaces. So I decided to make Date, Time and DateTime to implement a common Instance interface instead of a common class. And also if Date and Time inherit from the same class, it would imply that Date and Time is comparable.
56 (other comment)
I thought that this was the desired behaviour?
For 2 projects to be considered as duplicate, it needs to be created on the same date.
57 (other comment)
So no prefix will mean match any be default?
@jeannetoh99 (31 comments)1 (commented on others PR)
This is also used for Travel Plan name!
2 (commented on others PR)
Name is also used by TravelPlan, not just TravelPlan object. Maybe we can add that in?
3 (commented on others PR)
Maybe here can also implement Predicate>TravelPlan>, then we can overload the test method with test(TravelPlan tp) as well?
4 (commented on others PR)
I meant implements Predicate>TravelPlanObject>, Predicate>TravelPlan> since a class can implement more than one interfaces.
5 (commented on others PR)
As for this, 2 separate (overloaded) test methods:
public boolean test(TravelPlan travelPlan) and public boolean test(TravelPlanObject tpObject)
6 (commented on others PR)
I think this should be return the Travelplanner?
7 (commented on others PR)
What is the reason for this change? Previously I changed it to Graph so that it allows for names with some punctuations, such as "Alice's Home", i also tested it so it was working.
8 (commented on others PR)
I see, then can change to "(\\p{Alnum}\\p{Graph}*\\p{Space}?)+" ? Because I have multiple test cases with names that includes punctuation.
9 (commented on others PR)
Maybe can change to "The wishlist only stores activities, not accommodations or friends!". If not it sounds like the accommodations and friends of wishlist is empty.
10 (commented on others PR)
Is this additional newline intentional? (There's two empty lines in a row)
11 (commented on others PR)
Maybe can add a Javadoc comment here. "Takes the value -1 if no tab changes are required. Otherwise, represents the index of the tab to set the travelPlanObjectListPanel to."
12 (commented on others PR)
Don't have to change now, but maybe we should store these constants under the respective classes (i.e. Activity, Accommodation and Friend class) as TPO_WORD, since we are referring to these strings in multiple other classes. Similar to COMMAND_WORD.
13 (commented on others PR)
Class is missing JavaDoc. I'm not sure if this is allowed since it passes CI?
14 (commented on others PR)
Class is missing JavaDoc here as well.
15 (commented on others PR)
should we use {@code ParseException} here instead of seedu.address.logic.parser.exceptions.ParseException?
16 (commented on others PR)
Missing JavaDoc for this method.
17 (commented on others PR)
I think I added a space after Activities on purpose previously, so that the tabs are more spaced out.
18 (commented on others PR)
Is this additional new line intentional? Sorry I'm abit OCD, can ignore if you are okay with it!
19 (commented on others PR)
I think this part it's okay, since travelPlanObjectType for ShowCommand should not be -1. Maybe it would be clearer to throw this exception in the constructor instead of here. Same for the exception above.
20 (commented on others PR)
The space supposed to be after though.. HAHA
21 (commented on others PR)
Can use the {@code ParseException} syntax instead of just the string?
22 (commented on others PR)
travelPLanObjectType spelt with capital L by accident I think. Same throughout this file.
23 (commented on others PR)
Is the additional line here intentional?
24 (commented on others PR)
Just clarifying here, what's there TODO here?
25 (commented on others PR)
Can this be implemented in model instead? Then call the model method instead of accessing travelPlan methods here directly. Treat model as a facade.
26 (commented on others PR)
Same comment as above! 😃
27 (commented on others PR)
Yea yixian is right.... HAHA it's the name of the travelplans in the travelplanner panel
28 (commented on others PR)
can use constants to name numbers?
29 (commented on others PR)
Returns instead of Return? And not sure if there should be a full stop here.
30 (commented on others PR)
Not sure if there should be a full stop here.
31 (commented on others PR)
Should it be:
List>String>) and return true if there is any match with Nameable.getName().name32 (commented on own PR)
yeap! It's meant to be Jan, Feb, etc.
33 (commented on own PR)
I did that at first, but it failed checkstyle because apparently abbreviations must be capitalised for the first letter only.
34 (commented on own PR)
Just tested, the ListView implemented in TravelPlannerPanel implements scrolling already!
35 (commented on own PR)
Same as above too!
36 (commented on own PR)
Thanks! Updated accordingly.
37 (commented on own PR)
Updated. Thanks!
38 (commented on own PR)
We can typecast back to Travelplan to access AccommationList, if we are sure the directory is a travelplan.
39 (commented on own PR)
I think this is still considered polymorphism though?
40 (commented on own PR)
It's for testing purposes and to also remind programmers under what conditions this call should be made only. I wrote this with the intention that the programmer should only call setToAccommodationList() if the directory is a Travelplan. I was thinking about try catch, but it's not a scenario the user will face, since this should be configured by programmers (and should not happen because of user input/calls). It's also okay to write try catch, but there should not be any exception in the first place unless there is a bug in the program.
41 (commented on own PR)
if want to check can use instanceof!
42 (commented on own PR)
Thanks, updated!
43 (commented on own PR)
Updated, thanks!
44 (commented on own PR)
ok!
45 (commented on own PR)
yeap! so commands must check the directory before setting accommodationlist etc, since commands will have to know the directory to execute local commands anyway.
46 (commented on own PR)
This is to ensure the internalList does not hold the exact same copy of the TravelPlan.
47 (commented on own PR)
Not too sure if this is okay, removing it resolves execute_validIndexFilteredList_success in DeleteFriendCommandTest
48 (commented on own PR)
This is resolved in the most updated version of this PR.
49 (other comment)
Todo: Update to link to directory.
@Avalionnet (31 comments)1 (commented on others PR)
Small nit but will it be better to use the word patient here instead?
2 (commented on others PR)
Hmm was wondering if IC here will now refer to INDEX instead as we adopted the new command syntax?
3 (commented on others PR)
Perhaps we can consider including another section detailing our acceptance of natural date syntax above to provide users with a clearer understanding of our date syntax.
4 (commented on others PR)
Yup! It looks great 😃
5 (commented on others PR)
Hmm maybe you can consider updating this too as they will probably ask us to do it in the weeks ahead. But it's not essential for this iteration so no worries!
6 (commented on others PR)
Yup I think he missed that out too, good spot @JinHao-L . Perhaps it'll be better to include a breakline after the "]" as well to separate the example from the format?
7 (commented on others PR)
Oh and I think DATE can be an optional input here as well according to our user guide. Adding the link here for quick access 😃
8 (commented on others PR)
Hmm, as @YangYue128-helen mentioned, perhaps it'll be ok to leave out this check as we are able to support view commands without a DATE predicate as well?
Based on line 53 of ViewCommand.java, the current system seems to support the display of all future appointments if the predicate input is null (in the case that a date is not entered by the user) so I think you've got it covered @ZhangWanlin98 👍🏻
9 (commented on others PR)
Oh wait after reviewing NuudleParser as mentioned by @JinHao-L , I think the check done here is actually valid as the ViewCommandParser is only instantiated if extra input by the user following the view command is detected. Hence, it actually indicates an invalid command format if PREFIX_DATE is empty as it would mean that something else is written.
10 (commented on others PR)
Yeah I agree with @ZhangWanlin98 that it may be better to import the DateTimeLoader class directly to improve code readability and keep the variables used on the same level of abstraction.
11 (commented on others PR)
Perhaps it will be better to phrase it in the following way Creates a DoneCommand to mark the specified appointment as done? Let me know what you think of this 😃
12 (commented on others PR)
There seems to be some grammatical error here. It should be returns a DoneCommand object instead.
13 (commented on others PR)
Think you missed out a "to" and full stop here. Perhaps it will be better to phrase it as if the user input does not conform to the expected format.
14 (commented on others PR)
Hmm perhaps you're referring to {@code editedAppointment} here instead of editedPatient?
15 (commented on others PR)
Perhaps the appointment should exist in the AppointmentBook instead of the PatientBook(formerly AddressBook)?
16 (commented on others PR)
Hmm perhaps the ! on line 66 should be omitted as it looks like it’s throwing an exception for duplicated appointments when it detects non overlapping appts instead. Let me know what you think about this 👍
17 (commented on others PR)
Nice catch 😉
18 (commented on others PR)
Thanks for changing them to more applicable tags for our context!
19 (commented on others PR)
Good catch!! And thanks for updating the user stories too 😄
20 (commented on others PR)
Should PersonListPanel be PatientListPanel instead?
21 (commented on others PR)
Hmm perhaps the phrase "mark appointments" and "feature" should be in lower case?
22 (commented on others PR)
Perhaps you may consider the following phrase instead "Please refer to the following for an example usage scenario on how the mark as done mechanism works in each step:".
Let me know what you think! 😄
23 (commented on others PR)
Maybe it'll improve the flow by replacing the phrase "As a last step" with "Lastly,".
Also, it seems to me that you missed out a "a" in "CommandResult with a SuccessMessage ".
24 (commented on others PR)
Great job on the diagrams!! 😄
25 (commented on others PR)
Hmm, perhaps all instances of "Person" should be changed to "Patient" for the diagrams.
26 (commented on others PR)
Jin Hao's phrasing looks good to me too 👍🏻
27 (commented on others PR)
Hmm, perhaps you can consider the following phrase instead, "books an appointment at 2am for the 1st patient in the list on the coming Sunday for a duration of 40 minutes.
Additionally, I think it'll be better if we use 2pm as an example instead cause 2am is in the middle of the night and outside the usual operating hours 😅
28 (commented on others PR)
Same here for the am!
29 (commented on others PR)
Would it be better if we phrase it as "(unit in minutes)" instead?
30 (commented on others PR)
Excellent work on this 👍🏻
31 (commented on others PR)
Good job considering all the cases 👍🏻
32 (commented on own PR)
Thanks for pointing this out! I thought of this too but figured that it'll be better to change the package name in a separate PR as the current one only focusses on refactoring the AddressBook class. It will be easier for version control as well.
33 (commented on own PR)
Hmm I think it's more suitable to keep it as versionedPatientBook as the original extended AddressBook as well which does not handle appointments.
34 (commented on own PR)
Oh yes great spot! I'll make the necessary changes, though I believe that applying trim on our argument input will have also removed the trailing whitespace.
35 (commented on own PR)
Hmm I added the square brackets following the tutorial given in our textbook. I believe they added it in as entering an empty remark serves to remove an existing remark assigned to the same patient. Currently, nurses can use the remark command to both create new and modify existing remarks.
Will it be better to delegate this task to the edit command instead?
36 (commented on own PR)
Oh I've done some tracing and found that IllegalValueException is normally used when your method is passed a wrong input.
In the case of parseIndex, a ParseException is thrown to represent the errors encountered when the input index isn't a valid number (i.e >0) or is a letter.
However, since ParseException extends IllegalValueException, using IllegalValueException in this catch block will allow us to catch various kinds of ParseException should we decide to extend the functionality of our code in the future since it's the parent class.
37 (commented on own PR)
Hmm makes sense, alright I'll change it over to ParseException! Figured otherwise at first as the tutorial employed the use of IllegalValueException as well.
38 (commented on own PR)
Personally, I think it'll be a good addition to have this enhancement for our future iterations as it may seem like a bug if we are able to cancel an appointment that happened in the past. However, I realized that it shouldn't be the case for done since we will only mark an appointment as completed after it has occurred. Thanks for pointing it out Jin Hao 😃
Would love to hear from the rest too!
39 (commented on own PR)
Yup I left it there as a placeholder as I'm still wondering if there are any forms an Invalid Remark can take. Any thoughts on this Jin Hao?
40 (commented on own PR)
Nice catch! Thanks for spotting this 😄
41 (commented on own PR)
Yup I agree with you too Wanlin.
42 (commented on own PR)
Changed it! 👍🏻
43 (commented on own PR)
Yea good point! I'm able to limit the number of characters a user can add for a remark. However, I think the challenge with doing this may be the need to display the number of characters remaining(while the user is typing?) as it'll be hard for the user to manually count the number of characters added.
44 (commented on own PR)
Thanks for spotting this 😉
45 (commented on own PR)
HAHA thanks bro 😃
46 (commented on own PR)
Yeah I agree with Wanlin on the abstraction part but I can also see the point about consistency. Hmm, I'll change it to match the style used in the rest of the files instead 👍🏻
47 (commented on own PR)
Thanks for spotting this! Missed this out when I was editing it 😄
48 (commented on own PR)
👍🏻
49 (commented on own PR)
oh yea nice spot 👍🏻
50 (commented on own PR)
HAHA thanks 😃
51 (commented on own PR)
Oh yea!! Nice catch thanks 😄
52 (other comment)
As a nurse, I can easily check the patient’s drug allergy history so that I can double-check if the medicines prescribed are not in the list.
53 (other comment)
Hey Jin Hao, thank you so much for pointing out the error!
I've been meaning to consult the team prior to seeing your comment. The links you provided were really helpful to the resolution of the test errors I encountered. Alternatively, I have updated the settings in my IntelliJ to resolve the issue. You can check out the following link for the alternative strategy I employed.
https://www.jetbrains.com/help/idea/configuring-line-endings-and-line-separators.html
54 (other comment)
LGTM 👍🏻
55 (other comment)
Duplicated issue. (#72)
56 (other comment)
Thanks @JinHao-L , currently working on the changes!
57 (other comment)
Fixed checkstyle, added and modified existing tests to support the addition of Nric.
58 (other comment)
Thanks for checking it out Jin Hao and Wanlin 👍🏻
59 (other comment)
Thanks Yang Yue and Jin Hao!! Originally planned to add the test files in a separate PR haha. Am working on them now 👍🏻
@RuiFengg (31 comments)1 (commented on others PR)
TaskTemplate instead of Task Template/Preset Task Template
2 (commented on others PR)
Should Preset Task just be Task only?
3 (commented on others PR)
For now maybe we should use remove the spacing between Task Template, Task Schedule, Module Schedule etc.
4 (commented on others PR)
Probably should try to use module code instead of index
5 (commented on others PR)
modules*
6 (commented on others PR)
has to be an integer from 1-7*
7 (commented on others PR)
has to be a valid positive integer. The Total number of weeks are calculated using the start and end date of the semester*
8 (commented on others PR)
weeks*
9 (commented on others PR)
has been completed*
10 (commented on others PR)
Displays all tasks in the week that is specified by the user
11 (commented on others PR)
has to be a valid positive integer. The total number of weeks are calculated using the start and end date of the semester.
12 (commented on others PR)
Total weeks in the semester
13 (commented on others PR)
Creates a template of tasks for the user to reuse weekly to quickly add into his/her schedule
14 (commented on others PR)
List all task templates that were created
15 (commented on others PR)
Creates and adds a preset task in the selected task template
16 (commented on others PR)
has to be an integer from 1-7, 1 being Monday and 7 being Sunday
17 (commented on others PR)
has to be an integer from 1-7, 1 being Monday and 7 being Sunday
18 (commented on others PR)
Clear all preset tasks in the selected task template
19 (commented on others PR)
Rmb to change the capitalisation for UG
20 (commented on others PR)
Maybe listtemplatetasks would be a beteter name
21 (commented on others PR)
List all preset tasks in the task template
22 (commented on others PR)
Maybe listallmodules will be a better name
23 (commented on others PR)
Ternary ? should hour instead of hours
24 (commented on others PR)
Should name the class name as Day.java
25 (commented on others PR)
Refactor Days to Day
26 (commented on others PR)
Some have full stops and some don't
27 (commented on others PR)
Can consider using the Amount class so Price will store an Amount instead of a big decimal
28 (commented on others PR)
😸
29 (commented on others PR)
Can check out Hans implementation for the clear command that that passes a new service manager (expensetracker for your case)
30 (commented on others PR)
Message takes a bit of time to understand for me, maybe undo success or undo complete is sufficient 😸
31 (commented on others PR)
Same here, maybe "Already at oldest change" (copied from vscode vim)
32 (commented on own PR)
Yup its quite referenced from the original AB3 tests
33 (commented on own PR)
Thx for the catch! Removed them 😄
34 (commented on own PR)
Thanks for the catch 😃
35 (other comment)
Better to merge this after everyone updates their profile in the aboutus page
36 (other comment)
Amend commit to update DG use cases with suggestions from @khoongwk
37 (other comment)
Not sure if add remark changes were accidental for this branch but would be useful to have it to serve as the description for tasks 😸
38 (other comment)
LGTM
39 (other comment)
Added some tests
40 (other comment)
Consider checking out Galvin's implementation for parse method of find command
41 (other comment)
Current implementation is just to take total revenue for the month subract with total expense for the month. Tests not added yet
@TanLeYang (31 comments)1 (commented on others PR)
Should we use Index to select the book instead of the name of the book? Since the delete command already makes use of Index and using bookname is quite prone to typos
2 (commented on others PR)
The user guide link is wrong, the correct link should be https://ay2021s1-cs2103t-f13-2.github.io/tp/UserGuide.html
3 (commented on others PR)
Same for the dev guide as well, correct link should be https://ay2021s1-cs2103t-f13-2.github.io/tp/DeveloperGuide.html
4 (commented on others PR)
I think you may have missed out on this part. The View command is meant to view detailed info regarding a single book.
5 (commented on others PR)
I think this extension 2a isn't supposed to be here anymore, its included in UC05 already.
6 (commented on others PR)
Just saw that the extension numbering here is incorrect, should be 2a, 2a1, 2b etc. Can you help change them too 🙏 thanks!
7 (commented on others PR)
According to the user guide, the prefix should be "tp/" for total pages and "b/" for bookmark for consistency purposes right? Maybe we can discuss this further!
8 (commented on others PR)
Thanks for doing the renaming! There's some parts which haven't been renamed such as the Javadoc here, comments in the equals() test as well as here: https://github.com/AY2021S1-CS2103T-F13-2/tp/blob/c568a3c5177c68a33c3e6279923fa8f3c0356df0/src/test/java/seedu/bookmark/logic/commands/AddCommandTest.java#L153
Would be great if you could change those too, thanks!
9 (commented on others PR)
Could you edit the javadoc and comments as well please, thanks!
10 (commented on others PR)
I think this line can be removed since the tests have been updated.
11 (commented on others PR)
Could you update the tests names as well
12 (commented on others PR)
I think there's a typo here, should be viewFirstCommand and viewSecondCommand right?
13 (commented on others PR)
Perhaps you could include a super simple javadoc for this class?
14 (commented on others PR)
The jdoc here should be "Add a note to a book" or something along those lines right?
15 (commented on others PR)
There doesnt seem to be any usage of editBookDescriptor in this method
16 (commented on others PR)
Is this bookmark validity check necessary? since this command doesn't touch the bookmark field at all
17 (commented on others PR)
Left-over jdoc from the EditCommandParser. Same issue for the parse method as well
18 (commented on others PR)
Left-over jdoc from JsonAdaptedTag. Same issue in the toModelType method
19 (commented on others PR)
Not sure if this jdoc is accurate?
20 (commented on others PR)
Should we allow more than alphanumeric characters? I think users would want to use punctuation when writing down their thoughts on the book.
21 (commented on others PR)
Also I think it would be good to put in some length limit for the title and text as well. I don't think the application would be able to handle displaying text that is for example, 10,000 words long well. Perhaps something like 120 characters for the title and 1000 characters for the text?
22 (commented on others PR)
Thanks for writing such comprehensive tests and increasing our code cov hehe 😄
23 (commented on others PR)
Would have to take a look at your implementation to confirm, but I don't think that "algorithms" constitute a component on its own. Could they just be part of the Logic component given that the algorithms are used to perform business logic?
24 (commented on others PR)
Did you mean "will be called" rather than "will be implemented"?
25 (commented on others PR)
Need a space between #### and Implementation
26 (commented on others PR)
This could potentially cause a NPE if the .get() returns null. Maybe you can follow the same style as the other fields: have a static parseGoal() method in ParserUtil that does the validation checks, also making use of the isValidGoal() method in Goal.
27 (commented on others PR)
Maybe put a requireNonNull check here just to be defensive?
28 (commented on others PR)
Typo here? should be AddNoteCommand right
29 (commented on others PR)
This could be slightly misleading since its not always 3 words anymore. Perhaps just "Find words" would suffice
30 (commented on others PR)
Instead of having all these methods being abstract, they can actually just be implemented inside WordStore itself and inherited by each of your different types of WordStores (TagWordStore, NameWordStore, etc). Currently, there is a lot of repetition since each of the individual types of WordStores implement their own addWords(), deleteWords(), etc but their logic is exactly the same.
31 (commented on others PR)
Maybe use a HashMap or HashSet for O(1) look ups?
32 (commented on own PR)
Good suggestion! I've made the necessary changes
33 (commented on own PR)
Thanks for spotting the mistake! I've made the necessary changes
34 (commented on own PR)
Yea it looked quite iffy to me too but didn't know how to phrase it nicely. Thanks for the suggestion will improve it!
35 (other comment)
LGTM
36 (other comment)
@mgiang2015 you uploaded your photo in the wrong folder, it should be uploaded in docs/images. Please open another PR to close this issue! 🙏
37 (other comment)
LGTM!
38 (other comment)
LGTM!
39 (other comment)
LGTM
40 (other comment)
Closed by #63
41 (other comment)
Reopening as @mgiang2015 's part on user stories for the View command is not done yet
42 (other comment)
Closed by PR #88
43 (other comment)
Closed by #90
@tanweijie123 (31 comments)1 (commented on others PR)
I don't think we can change the copyright license?
2 (commented on others PR)
Abit hard to look through all without stepping through 😕
Was thinking of letting it merge and we test; but see the rest
3 (commented on others PR)
NonExistenceFile.json is assertFalse for every src/test/data/* folder.
I guess it is a bug output file since the test doesn't want it to exist.
4 (commented on others PR)
to fix this issue (change Clients to client), refer to the new comment
From what I found out:
The program uses the "Clients" variable as keyword to save a json file.
The program then uses @JsonProperty("clients") to pick this keyword for assignment from the json file
5 (commented on others PR)
change @JsonProperty("Clients") to @JsonProperty("clients")
6 (commented on others PR)
Yes. I expect it to have more errors.
Because, the actual data file is saved as caps Client instead of client.
I can only help u find these (those files in /JsonAddressBookStorageTest & /JsonSeralizedAddressBookTest) files, that you might be likely to change them from caps C to small C. Maybe there are others that are not flagged out
7 (commented on others PR)
I think we should merge with the 2 test failure and create a new issue tracker to debug. Then can find out the root cause and more people can debug it instead of predicting the problem.
It seems to happen during the execution of saving a new temp file + reading failure.
8 (commented on others PR)
This will allow the user to start and end with '-'
Not sure if that was intended.
If it was correct, try to add 1 test case to test it 😄
9 (commented on others PR)
My DateTime formatter also different from yours
DateTimeFormatter.ofPattern("dd/MM/yyyy HHmm")
10 (commented on others PR)
Maybe can do if (sessionId == null || !ParserUtil.tryParseInt(sessionId)) , then throw IllegalValueExcep
11 (commented on others PR)
Best to undo this. Dont put your name in git blame
12 (commented on others PR)
Why suppress checkstyle warning though
13 (commented on others PR)
Help to remove empty else
14 (commented on others PR)
Do remember to add this into AddressBookParserTest also.
15 (commented on others PR)
Return a list of ??
16 (commented on others PR)
Uses*
17 (commented on others PR)
@return A list of clients
18 (commented on others PR)
@return A list of session
19 (commented on others PR)
Sorts*
20 (commented on others PR)
Remove dead codes
21 (commented on others PR)
Remove //placeholder as it is live date/time
22 (commented on others PR)
" sview p/all" will not update the label
23 (commented on others PR)
commandResult.equals(ViewSessionCommand.MESSAGE_SHOW_SESSIONS_SUCCESS will always return false because commandResult is a type of CommandResult and ViewSessionCommand.MESSAGE_SHOW_SESSIONS_SUCCESS is a type of String
24 (commented on others PR)
Try to remove debug statement before merging
System.out.println(commandResult.getFeedbackToUser());
25 (commented on others PR)
(e.g. If today is Friday, display from today till the Friday that falls 2 weeks later).
In other words, it will display today + 2 weeks (14 days) in the future
26 (commented on others PR)
in the result of the **c**find command
27 (commented on others PR)
clist
28 (commented on others PR)
to force delete a client ...
29 (commented on others PR)
need to add hyperlink to #sview before deleting
30 (commented on others PR)
Want to update to this?
31 (commented on others PR)
clist exist in 201-208
32 (commented on own PR)
The >title> will set it as tab name, while the # About Us is the in the webpage.
33 (commented on own PR)
Yes. I agree with you, but UI cannot run test cases.
Putting it in ViewClientCommand cannot test execute.
Usually, it should be placed in MainWindow::executeCommand, but I will see how
Edit: ViewClientCommand will create a lambda runnable for MainWindow to run.
34 (commented on own PR)
Updated
35 (commented on own PR)
It is a quick fix for AutoComplete. So without it, we must find the cause of why the first row was different colouring
36 (other comment)
fixes #18
37 (other comment)
similar to #41
38 (other comment)
@tanweijie123 will this change be compatible with the change you proposed for #68 ?
Yes. All the test case refactoring can be used. (because I have not started with that)
Gym, Interval, ExerciseType can be imported because currently, I am using it as String type
We can merge the Session to accommodate with ^.
Can refer to #70
39 (other comment)
#68
40 (other comment)
#68
41 (other comment)
#68
42 (other comment)
#68
43 (other comment)
#68
44 (other comment)
fixes #78
45 (other comment)
Right sidebar previously had a scrollbar that doesn't show now, but I think it's fine not to have it. Lgtm!
Vbox have auto hide scrollbar if not necessary. So maybe your screen size bigger?
46 (other comment)
Have we checked with Prof Damith on using controlsfx as external libraries?
Yup. Approved.
47 (other comment)
Updates: The UI is already available on the homepage. We just need to change the listview to display only today's schedule instead of the whole schedule list
48 (other comment)
To add this highlighted line to fix the bug
Will push it with some other PR next time
49 (other comment)
Today's schedule's list not correct lehh
50 (other comment)
Before:
After:
@tohyuting (30 comments)1 (commented on others PR)
I think this should be Warehouse's remark 😃
2 (commented on others PR)
Since we are including this constraint, should we include this inside our user guide so that users will be aware of this constraint when adding remarks to a warehouse?
3 (commented on others PR)
Should this be Remark instead of Address? Noticed this issue in a few places below (email instead of remark, etc) as well for Javadocs of various methods. Do take a look at it 😃
4 (commented on others PR)
Do you think replaceWarehouseList would be clearer here since the above method to change one warehouse differ only by a single letter? 😃
5 (commented on others PR)
Should this be removed instead? 🤔
6 (commented on others PR)
Minor issue, missing '.' for isSameWarehouse
7 (commented on others PR)
Should we include warehouse here although for this iteration we are not intending to include tagging for warehouses products?
8 (commented on others PR)
With the if condition statement removed here, will there be an issue where the for loop only runs one time since the return statement will force the function to stop executing?
9 (commented on others PR)
Same issue here, as pointed out above.
10 (commented on others PR)
Is the extra supplierList here as a placeholder for warehouse? I think the statusbarPlaceholder should be removed as well 😃
11 (commented on others PR)
Just adding a note here to remember to change supplier to warehouse when updating tests cases later on.
12 (commented on others PR)
Just to check, did you perhaps miss out the conflict here?
13 (commented on others PR)
Same for these conflicted import statements as well 😃
14 (commented on others PR)
Just wish to clarify, is the method empty because this method is allowed to be called but there is no specific function this method can do?
15 (commented on others PR)
Alright, noted
16 (commented on others PR)
Will it be clearer if the statement is Creates an Addcommand to add the {@code Product} to the specified {@code Supplier}
17 (commented on others PR)
Maybe it will be clearer if you clarify that the exception is thrown due to index specified to be larger than list of supplier/warehouse since it is not so clear reading from these lines here 😃
18 (commented on others PR)
Just to clarify will this still be relevant for CLI-nic and also, is it still Tag, or would it be Remarks?
19 (commented on others PR)
do remember to update the delete command here as well 😃
20 (commented on others PR)
Are suppliers and warehouses missing Remark attribute?
21 (commented on others PR)
I see! Agreed, I think we can improve on this paragraph after we finalise our UML towards the end. Looks good to merge then! 👍
22 (commented on others PR)
Yes, sorry about that!
23 (commented on others PR)
Just wish to clarify, is there a need for the if clause here since there is a conditional check above (lines 89-90) where this method would be called if targetType.equals(SUPPLIER). Could there potentially be any cases where targetType is not equals to SUPPLIER and this method could be invoked?
24 (commented on others PR)
Just to clarify, what are the other same methods that you are looking at to shift it under Command class? 😃
25 (commented on others PR)
Ah okay, that explains! 😃 All is clear now, no issues with this part 👍
26 (commented on others PR)
Hmm, I am not sure if shifting to the parent command class would be okay, since AddCommandParser only implements a Parser interface and there is no parent class for the parser classes. Though I can also understand where you are coming from as well, I am thinking would it be out of place if we shift it to under ParserUtil class? Maybe we can discuss with others as well and see how do we want to implement it such that there would not be a case of overlapping.
27 (commented on others PR)
Not too sure if it makes a major difference, but I am wondering if it would be better to access the fullName via some form of getter method instead of accessing the attributes directly. 🤔
28 (commented on others PR)
I think this empty line can be removed
29 (commented on others PR)
Some extra spaces here can be removed as well
30 (commented on others PR)
Hmm, I guess in that case let's just use .fullname instead of a getter method then, since it is used in several places as well 😃
31 (commented on own PR)
Accepted, will remove @return and change "Creates" in first line of JavaDocs to "Returns"
32 (commented on own PR)
Thanks for pointing that out, will push another commit to fix this!
33 (commented on own PR)
Noted, thanks for pointing that out! Will be pushing another commit with the updates.
34 (commented on own PR)
Thanks for pointing this out, missed out on the javadocs comment for class!
35 (commented on own PR)
Noted, will updated in next commit as well.
36 (commented on own PR)
Thanks for the suggestion, let me try to use that instead of arrays.aslist(String[]{})
37 (commented on own PR)
Thanks for pointing that out! Will be removing that in the next commit.
38 (commented on own PR)
Thanks for pointing this out, will fix it in the next commit along with removal of above clause as well!
39 (commented on own PR)
Thanks for pointing this out, will fix it in the next commit!
40 (commented on own PR)
Oh no, this should be clinic instead. Thanks for pointing this out!
41 (commented on own PR)
Oh the error message will be shown when a user tries to use a supplier prefix, s/ when editing warehouses, I think that the output message is correct though? 🤔
42 (commented on own PR)
Thanks for pointing them out! And yes, I think I made a typo on the 4th sentence, will change it to "will be used to process user input"
43 (commented on own PR)
I think I figured out why, there was not space between the last line of the paragraph and the line right after it (with -), will fix this in my next commit!
Will also fix the grammar as well, thanks for pointing that out.
44 (other comment)
Accepted suggestions above, will do the appropriate changes
45 (other comment)
Thanks for pointing them out! I agree with Jeffrey on the third point as well, I think it would improve user experience if we let for instance a delete command with random string at the back to pass through rather than forcing the user to re-enter the command without the random string.
As for the first point, may I clarify if you meant for e.g. add vs Add (or any other variations of add) in the case of command string to be insensitive?
Also, another bug I noticed was for delete, find and view, the ordering of arguments matter. In our user guide, it was mentioned that parameters can be in any order. However, without any delimiter in place, like t/TYPE, it will be hard for us to ascertain which word is for type and which word is for name of supplier/warehouses (in the case of find and view). I was thinking if we should specify that ordering does not matter for all commands except delete, find and view in our user guide to be clear.
EDIT:
Just to add on, the current way of handling adding of suppliers and warehouses has a bug since type of determined by doing a substring of trimmed arguments. If users are allowed to reorder the arguments, the parser will detect this as an invalid command.
In addition for adding of supplier, it seems like email address has to be a compulsory field (invalid command is shown), but in the UG it is an optional field. Should we still keep email address field as an optional field?
For adding of warehouses, if remarks field (which is optional) is left out, a java.lang.reflect.InvocationTargetException will be thrown. I think we missed out these cases, but no worries, let's fix them in v1.3 iteration! 😃
@Ben-Hanan (30 comments)1 (commented on others PR)
Commenting for future reference:
we will probably need to change these kind of files with traces of address book in it. No need to change for now.
2 (commented on others PR)
Need to change JsonSerializableAddressBook class name to JsonSerializableEvaStorage
3 (commented on others PR)
Minor comment, but maybe it could be private instead of protected? Since we would just use getter methods to access these fields.
4 (commented on others PR)
Perhaps we can make use of the regex method used by the other classes in model? In this case the validation format would be "^(3[01]|[12][0-9]|0[1-9])/(1[0-2]|0[1-9])/[0-9]{4}$" for dd/mm/yyyy. I believe it would make our code seem more in line with the existing code from AB-3.
5 (commented on others PR)
Maybe interviewDate shouldnt be in an optional wrapper in the constructor in case it errors? We could include a try catch then or we could simply make a getter method for interviewDate that returns an optional>InterviewDate> and set up the error handling there.
6 (commented on others PR)
Agree with Royce. Maybe we can use an enum or separate class for this as well.
7 (commented on others PR)
Good use of existing functions.
8 (commented on others PR)
Same goes for these. Don't think it should be protected.
9 (commented on others PR)
Not sure if it's ok to delete the person database. If we can do so without the application collapsing we should remove it if it is redundant! (of course this means updating all the tests) KIV
10 (commented on others PR)
@code applicant, address book -> eva storage
11 (commented on others PR)
the word "address book" appears multiple times in javadocs at multiple places
12 (commented on others PR)
not sure if we wanna change it to editedApplicant, editedStaff. Can choose to change or not up to u
13 (commented on others PR)
May wanna change the way interview dates are represented. (I think this is for Nikhila?)
14 (commented on others PR)
isn't this method in parserutil?
15 (commented on others PR)
maybe instead of coming up with a myriad of prefixes when we make a new command like ls, le, id, we can standardize a date input to always just use PREFIX_DATE which is d: or d/ or something along these lines?
16 (commented on others PR)
maybe we can use an enum for this
17 (commented on others PR)
The extra tag added here should be Applicant instead of staff
18 (commented on others PR)
Applicant instead of staff
19 (commented on others PR)
We can remove the leaves flowpane as applicants do not have leaves
20 (commented on others PR)
Applicant
21 (commented on others PR)
edit the logging as well. I think staff list panel should have the same problem.
22 (commented on others PR)
I think most of the javadocs in the new classes have yet to be updated
23 (commented on others PR)
I guess we need to implement window/tab switching
24 (commented on others PR)
Perhaps a better way to process statuses from strings would be to use the 'valueOf' function of enums. i.e
'PossibleApplicationStatus.valueOf(status.toUpperCase()); //throws Illegal argument exception if its not a valid enum
'
not really sure if it can be applied here as you would have to try catch either here or whatever is calling the constructor.
25 (commented on others PR)
with relation to my previous comment, this can be removed i think but im not sure how the constructors and the enums tagged to strings work.
26 (commented on others PR)
perhaps we can abstract this out to dateutil? If the current method doesnt suit what you need you can create another method and another datetimeformatter to suit what you need
27 (commented on others PR)
maybe you can make use of the method arePrefixesPresent in parserutil
28 (commented on others PR)
i think we need to find a better way to handle this. I will come up with a app wide state to monitor what we are currently looking at so the commands dont mess up.
29 (commented on others PR)
same as DeleteCommandParser
30 (commented on others PR)
take this out if not the app wont start lol
31 (commented on own PR)
I believe a better comparison would be between Leave and Address or Tag! Leave should handled the same way as how an attribute of the person is handled instead of being handled the same way as the Person itself. But you are right, I can have the parsing method imported from dateUtil to achieve better abstraction.
32 (other comment)
LGTM!
33 (other comment)
LGTM!
34 (other comment)
Done for week 6 tutorial, not needed to merge
35 (other comment)
Not needed to merge
36 (other comment)
Not needed to merge
37 (other comment)
Looks good maybe you can do x.
38 (other comment)
LGTM
39 (other comment)
LGTM
40 (other comment)
LGTM
41 (other comment)
LGTM
42 (other comment)
LGTM
43 (other comment)
LGTM
44 (other comment)
LGTM
45 (other comment)
LGTM
46 (other comment)
LGTM!
47 (other comment)
Closed. refer to PR #62 for updated version
48 (other comment)
LGTM. However due to dependence on filteredStaffList, we will need to change the find function in the future.
49 (other comment)
As a HR manager, I want to be able to add comments on staff so that I don't have to do it physically and can have the data stored in one location.
50 (other comment)
basic functionality implemented in v1.2. Functionalities stated in this story will be added in v1.3
51 (other comment)
LGTM
52 (other comment)
LGTM. Thanks for correcting this small error!
53 (other comment)
I think we can close this PR for now. Can open again if needed.
54 (other comment)
LGTM
55 (other comment)
LGTM
@blackonyyx (29 comments)1 (commented on others PR)
Slightly confused why the need to update the prevous code base person model. Is it failing checkstyle?
2 (commented on others PR)
Change to Tests to follow the rest of the jdoc comments.
3 (commented on others PR)
Could add constructor tests eg: Referencing from person/AddressTest, as constructor has requireAllNonNull similar to person.Address
This could be applied to a lot of previously seen files.
Something like this is possible:
@Test
public void constructor_null_throwsNullPointerException() {
assertThrows(NullPointerException.class, () -> new Location(null));
}
@Test
public void constructor_invalidAddress_throwsIllegalArgumentException() {
String invalidLocation = "";
assertThrows(IllegalArgumentException.class, () -> new Location(invalidLocation));
}
/**
4 (commented on others PR)
Add null location test, referencing: UniquePersonListTest.contains_nullPerson_throwsNullPointerException()
5 (commented on others PR)
Similar as first comment about Tests that -issue-
6 (commented on others PR)
Same as abv
7 (commented on others PR)
Slight complaint but could add line comments on what exact part of equality is being tested in each assert as it was done in some other class equality testcases
8 (commented on others PR)
On further review, this addition would be a big increase in requirements for testcasing and is not suitable for a small modification to a completed pull request.
We should open a new issue about this on refactoring and improving testcase coverage on Constructors and Null Checks.
9 (commented on others PR)
Perhaps some jdocs here would be good to ensure readability of code
10 (commented on others PR)
Jdocs
11 (commented on others PR)
Maybe should have a MESSAGE_USAGE string like if someone does sth like
listi jkdnkjvsdsn
or something ( unsure if will return error here)
12 (commented on others PR)
Constructs ...
13 (commented on others PR)
May not be in line with good OOP practices. Consider alternative representation or if it is not the proper namespace usage, amend
14 (commented on others PR)
Bit more spacing would be good to have and perhaps line commets
15 (commented on others PR)
Same as abv
16 (commented on others PR)
We are replacing this with parser level specific methods?
how about item name etc
Or issit gonna use RegEx instead?
17 (commented on others PR)
could probably rename -> inventoryinator.png
or something like that, to remove any reference to ab3
18 (commented on others PR)
Im not so certain that getFilteredItemList is the only list we need for a ModelStub
How about the recipe list or location list?
19 (commented on others PR)
bit of white space please 😃
20 (commented on others PR)
spacing
21 (commented on others PR)
spacing
22 (commented on others PR)
spacing
23 (commented on others PR)
Minor observation but item stores as a list, so why are we using hashset in itemBuilder?
24 (commented on others PR)
Perhaps could add a class header for completeness sake, it is a public class
25 (commented on others PR)
Slight nitpick but
Could probably use a Static constant predefined in the util files rather than a "magic string"
26 (commented on others PR)
Command Word is removed at this step, the input that is recieved by parser is -n banana -q 50
27 (commented on others PR)
Command Result is Returned and parsed to the UI i think So its not destroyed
>img width="854" alt="Screenshot 2020-10-19 at 9 00 17 AM" src="https://user-images.githubusercontent.com/35429757/96390978-a5b3ac80-11e9-11eb-9fea-a92b866ef24f.png">
28 (commented on others PR)
EditItem Command should also probably be destroyed after CommandResult is returned.
29 (commented on others PR)
AddQuantityToItemCommand should also similarly be destroyed.
30 (commented on own PR)
be careful what you wish for 😃
31 (commented on own PR)
adding these lines back cause checkstyle to fail somehow?
32 (commented on own PR)
Will not touch. should be handled by #20
33 (commented on own PR)
Inventory is meant to refer to entire state of the inventoryinator. will add term to glossary
34 (commented on own PR)
Oops :p lmao
35 (commented on own PR)
Not known how implementation will be done, hence maintaining similar format as prior implementation for now.
36 (commented on own PR)
Oof
37 (commented on own PR)
this is intentional to show user that comma spacing is irrelevent.
38 (other comment)
User Guide is done for now.
39 (other comment)
From commit 9b2ccce:
In process of Unittesting, dificulty was encountered from utilising
testing utilities of original code base.
Specifically the assertCommandSuccess testutil method, relies on the .equals
of model manager, and model manager equality has null values initialised for AB3
and Inventoryinator versions, which if implemented to check, cause testcase
failures in stubs.
Recommended to perform refactor to code base and remove ab3 artifacts, for more effective
testing.
Will open new issue based on this finding.
40 (other comment)
Related to
#20
@ethanso56 (29 comments)1 (commented on others PR)
whats this print statement for?
2 (commented on others PR)
should this be addTotalCalorieOutput? just like the addTotalCalorieInput() haha
3 (commented on others PR)
How come this is date? should be calorieManager right?
4 (commented on others PR)
the Date.MESSAGE_CONSTRAINTS
5 (commented on others PR)
the javadoc comment should be calorieManager object right? instead of day object
6 (commented on others PR)
the p want to make it capital P? HAHHAAH
7 (commented on others PR)
comments should be Name instead of Food
8 (commented on others PR)
test name should be name instead of food
9 (commented on others PR)
I dont think license need to change haha
10 (commented on others PR)
how come this one got 2 optionals
11 (commented on others PR)
here also
12 (commented on others PR)
this one also shd be myfitnessbuddy
13 (commented on others PR)
here also
14 (commented on others PR)
here also haha
15 (commented on others PR)
here is myfitnessbuddy also right?
16 (commented on others PR)
shd this file be deleted? already got the MyFitnessBuddyPerser liao
17 (commented on others PR)
myfitnessbuddy?
18 (commented on others PR)
here also haha
19 (commented on others PR)
myFitnessBuddyFilePath
20 (commented on others PR)
myFitnessBuddy
21 (commented on others PR)
here also haha
22 (commented on others PR)
here
23 (commented on others PR)
here
24 (commented on others PR)
here
25 (commented on others PR)
here
26 (commented on others PR)
here
27 (commented on others PR)
here
28 (commented on others PR)
here
29 (commented on others PR)
delete this?
30 (commented on own PR)
oh ya
31 (commented on own PR)
done
@benclmnt (29 comments)1 (commented on others PR)
Should we keep this?
2 (commented on others PR)
maybe, coming in mid-v1.2? 😄
3 (commented on others PR)
Don't remove this part. It is used by Jekyll
4 (commented on others PR)
Perhaps, if you add this then we will have double title on the page (?)
5 (commented on others PR)
Is this more of a "List a Client" use case?
6 (commented on others PR)
2. FitEgo adds the Client
7 (commented on others PR)
I'm not too sure if there is a timestamp in the status bar 😅 , but it is also in the AB3 DG ...
8 (commented on others PR)
Expected: First contact is added to the list. Details of the added contact shown in the status message. Timestamp in the status bar is updated.
9 (commented on others PR)
2. FitEgo displays the client's whose name matches the keyword or text.
I see similar issues in other place as well
10 (commented on others PR)
Perhaps its better to move this to ViewClientCommand::execute?
as to maintain separation between Ui and Logic components?
11 (commented on others PR)
I agree with Dhafin.
i think in a javascript world, it is called a callback.
Perhaps hasCallback and getCallback is a better name?
12 (commented on others PR)
Sounds good!
13 (commented on others PR)
[open for discussion] Is it better to do the new way or the previous way?
This change is related to changes in SessionBuilder::withInterval
cc @maguireong @dhafinrazaq
14 (commented on others PR)
hmm, what happens if we remove !important here? 🤔
15 (commented on others PR)
Sorting session by its natural order is from the oldest (?)
16 (commented on others PR)
Iirc, we are not using idCounter anymore for sessions
17 (commented on others PR)
Perhaps its better to just delete this and add a reminder in the issue, I think
18 (commented on others PR)
Seems like there's no change to AddSessionCommand?
19 (commented on others PR)
Is it possible to just merge this together with the getTypicalAddressBook and getTypicalSessions?
20 (commented on others PR)
Forget to change 😄
21 (commented on others PR)
Repetition of line 151
22 (commented on others PR)
Is it better to just have one function String getFormattedStartDateTime (DateTimeFormatter formatter) ?
23 (commented on others PR)
ook 👍
24 (commented on others PR)
ook!
25 (commented on others PR)
Yup for consistency, we just put anything optional inside the descriptor
26 (commented on others PR)
typo - add commands
27 (commented on others PR)
it's changed from editschedule -> schedit
28 (commented on others PR)
I think it is better to not have else after a return statement. It is following Make the happy path prominent
29 (commented on others PR)
agreed. based on our discussion in telegram, the docs should document this.
30 (commented on own PR)
Oh okay, i think I'll change it to only allow for the case where
cannot start or end with -
allow multiple - usecases
31 (commented on own PR)
Oh right, I'll make it private
32 (commented on own PR)
should we?
33 (other comment)
I think it is better to keep the structure of AB3 UG for future reference
34 (other comment)
donee
35 (other comment)
Proposed changes: show the number of clients inside the UI
36 (other comment)
TODO:
Repurpose the tag to history of injury / allergies
Change test data to medical names
37 (other comment)
Done for v1.1. Closing..
38 (other comment)
@dhafinrazaq @maguireong can help to look at it?
@tanweijie123 will this change be compatible with the change you proposed for #68 ?
39 (other comment)
Btw, perhaps it is better to test for checkstyle locally before pushing?
To run checkstyle and test cases, run ./gradlew check from Intellij terminal
To edit your last commit (so as to clutter the commit history), do git commit --amend --no-edit (also in terminal)
40 (other comment)
Yes, I propose this implementation:
sdel INDEX : will delete only if there is no schedule tied to that session
sdel INDEX f/ true: will force delete all schedule tied to that session and the session itself.
Implementation:
41 (other comment)
If i read it correctly, changes to existing classes is to enable comparing sorting clients (compared by name) and sessions (compared by interval start time) right?
42 (other comment)
Have we checked with Prof Damith on using controlsfx as external libraries?
43 (other comment)
Should we close this issue then?
44 (other comment)
Closing to wrap up 1.2.. Will create issues for point 1 (#115 , #90 )
45 (other comment)
We can implement this as a remark inside Schedule.
The remark is for the fitness instructor to add in comments and/or types of exercises done by this client.
We can then display it as part of the client's information
46 (other comment)
it should just delete the associated schedule I think ...
47 (other comment)
Please help me check if this class diagram is correct 😃
48 (other comment)
current implementation only check for invalid duration ( > 0 ), but don't have upper limit yet
49 (other comment)
@dhafinrazaq , you have added right?
50 (other comment)
should be fixed now ..
@teekoksiang (27 comments)1 (commented on others PR)
Should there be a new line between 1a and 1a1? This is also applicable to line 334 and 335.
2 (commented on others PR)
Should there be an indication of the next step for the use case?
3 (commented on others PR)
Should the block and room number be separated? e.g. b/BLOCK r/ROOM_NUMBER
It would be easier for the user to type without the formatting error.
4 (commented on others PR)
This part perhaps can declare it as MESSAGE_USAGE in the ExportCommand?
So, it follows the current exception handling approach.
Can refer to AddCommand and AddCommandParser.
5 (commented on others PR)
Perhaps can replace 1 and 2 with named constant to improve the readability?
6 (commented on others PR)
Omit this blank line?
7 (commented on others PR)
handleEmail and handlePhone both need to create the file and get the person list first.
Can consider declaring a method to do this part, then pass the person list to handleEmail and handlePhone.
8 (commented on others PR)
The difference is minor, mainly to reduce the repeated codes.
9 (commented on others PR)
Perhaps can include the capitalized email and phone to show it is case insensitive?
Does it need to include the COMMAND_WORD 'export' for the second argument of assertParseSuccess? As assertParseSuccess from XYZCommandParserTest does not include the COMMAND_WORD.
10 (commented on others PR)
Should export email phone and export phone email be parsed successfully?
11 (commented on others PR)
Good test cases to check the feedback message.
Can consider checking whether the output file contains the correct exported information (email, phone).
12 (commented on others PR)
I just realised MESSAGE_USAGE of ExportCommand contains 'Invalid command format!\n' message, it should just contain the usage message similar to the MESSAGE_USAGE from other XYZCommand, so it will follow the current AB3 convention.
Can refer to the AddCommand.
13 (commented on others PR)
Should parse method handle exception related to the invalid command format? As ExportCommandParser parses the command.
14 (commented on others PR)
Good job in comparing the output file with the correct output file.
Are the println and lineNum for debugging? Can return areEqual.
15 (commented on others PR)
I added the comment for handling invalid command format in ExportCommandParser.
Perhaps can consider adding test case for it.
16 (commented on others PR)
Oh I mean the PR review comment for ExportCommandParser.
"Should parse method handle exception related to the invalid command format? As ExportCommandParser parses the command."
If you throw ParseException in ExportCommandParser, then perhaps can add parse_invalidArgs test case?
17 (commented on others PR)
Perhaps can declare MIN, MAX_FLOOR_NUMBER and MIN, MAX_ROOM_NUMBER as a static variable and use it to validate room and floor? It may be clearer and more readable.
18 (commented on others PR)
Perhaps can declare MIN, MAX_FLOOR_NUMBER and MIN, MAX_ROOM_NUMBER as a static variable and include it in the MESSAGE_CONSTRAINTS?
19 (commented on others PR)
Should setBlockPref and setRoomPref be handled in ModelManager to follow the separation of concerns principle? As ModelManager handles Model related functions.
20 (commented on others PR)
Move this method to UserPrefs as it is more related to it? E.g. setGuiSettings in UserPrefs
21 (commented on others PR)
Okay, I see what you are coming from. As storage.readAddressBook() reads addressbook.json and converts JsonAdapterPerson to Person, it will do the validation check for every Person field.
Do remember to update JsonAdapterPerson#toModelType() to do a null and validation check for Block and Room before declaring it.
22 (commented on others PR)
Perhaps String[] will be more suitable for blockSettings instead of String?
And roomSettings with 420 is quite confusing, can consider breakdown to min, max floor and room number.
23 (commented on others PR)
Should blockPref be derived from UserPrefs#getBlockSettings()?
24 (commented on others PR)
Can consider adding set MIN_FLOOR_NUMBER and MIN_ROOM_NUMBER, e.g. level 1 is the common lounge.
25 (commented on others PR)
Okay, noted.
26 (commented on others PR)
Change to camelCase for not constant variables?
27 (commented on others PR)
Oh, I refer to JsonAdaptedPerson#toModelType method. The current convention will do a null and validation check for every field before converting the JsonAdapterPerson to Person.
There is missing of null and validation check for block and room String.
28 (commented on own PR)
Fixed, thanks.
29 (commented on own PR)
Yes, I forget about it, thanks 👍
30 (commented on own PR)
Good catch, will update it.
31 (commented on own PR)
Yes, will remove it, thanks for discovering it 👍
32 (commented on own PR)
Yes, I should add that step. Thanks.
33 (commented on own PR)
I was thinking about not writing it too. I will remove this then.
34 (commented on own PR)
Noted, thanks.
35 (commented on own PR)
Yes, accidentally typed "studyGroup".
36 (commented on own PR)
Good point, will update it.
37 (other comment)
Update command summary and change 'person' to 'resident' in the User Guide.
Need to confirm about the CLI syntax for block and room number (combine together or separate).
38 (other comment)
Update the CLI syntax for room number. r/ROOM_NUMBER
E.g. r/B402
@MatthiasLHK (27 comments)1 (commented on others PR)
Might want to take in the user input and array of prefix, and store it as a instance variable.
2 (commented on others PR)
No parameters needed, use the instance variable values, SLAP.
3 (commented on others PR)
change to private
4 (commented on others PR)
change to private
5 (commented on others PR)
change to prefix
6 (commented on others PR)
change to private, and change the name of the method, very similar to the one below
7 (commented on others PR)
change to private, change the name.
8 (commented on others PR)
Pull it out as a separate class.
9 (commented on others PR)
SLAP, Abstract out the new ContactList creation.
10 (commented on others PR)
Wrong object used, should be ResultCommand
11 (commented on others PR)
Wrong object used, should be ResultCommand
12 (commented on others PR)
Why need isSameContact method and the overwritten equals method?
Is it cos in the event of 2 differnet person with the exact same name?
13 (commented on others PR)
Should it be final? Might be hard to keep updating right?
14 (commented on others PR)
Will it work? Since this.contacts is final.
15 (commented on others PR)
Same thing, contacts is final, im not sure if you can just set it.
16 (commented on others PR)
Follow SLAP, bring out the remove function call.
17 (commented on others PR)
Might want to pull this out into a new class for common usage. As I foresee we will be using this for some of the other classes as well.
18 (commented on others PR)
If it is an empty constructor, should we just not write the constructor?
19 (commented on others PR)
What is this block for? Don't think i rmb seeing this kind of code declaration hahha.
20 (commented on others PR)
What is this function call? Why is it needed? Since this() calls the empty constructor that does nothing.
21 (commented on others PR)
Might want to match the aligning of the dots, looks neater.
22 (commented on others PR)
Don't use magic numbers, declare 30 as a constant in the field, and name it the word limit or something. This makes it more readable.
23 (commented on others PR)
Why does this work? Since the field internalList is private, how can u just compare using .internalList
24 (commented on others PR)
I think the prefix should just be called g/, as Im assuming that we add the "addgrade" command in front, so no need to specify the "a" in the prefix.
25 (commented on others PR)
I thought we decided on using an association class instead? Im not too sure also. KIV
26 (commented on others PR)
Why is it OR? So this means that as long as either the email or telegram plus the name is the same. Then the contact is considered to be the same? Shouldn't it be all 3 the same, then its the same?
27 (commented on others PR)
I think we should split this into 2 test, one for passing and one for failing. I think i read this in the textbook before. Quite recently. Can check again thanks.
28 (commented on own PR)
I will fix in the latest update!
29 (commented on own PR)
Ok noted.
30 (commented on own PR)
OK roger, will do boss!
31 (commented on own PR)
If we leave the instantiating of the 3 parsers in the constructor, then each time a command called by the user, we are re-creating a parser each time. And not reusing them, which i think is wrong.
32 (commented on own PR)
See above point.
33 (commented on own PR)
but if we use .equals(), we need to check every single existing command, which is alot.
34 (other comment)
Looks good to merge, just file renaming.
35 (other comment)
Unused PR, delete if possible. Did not merge!
36 (other comment)
Achieved
37 (other comment)
Achieved
38 (other comment)
Achieved
39 (other comment)
Achieved
40 (other comment)
Achieved
@itssodium (27 comments)1 (commented on others PR)
If I'm not wrong the textbook didn't have these white spaces.
2 (commented on others PR)
Same problem as above.
3 (commented on others PR)
Can delete white space, seems unnecessary.
4 (commented on others PR)
Delete this line, I think its from a merge conflict.
5 (commented on others PR)
Delete this single white space.
6 (commented on others PR)
Good that you have a separate class for Description, instead of a String.
7 (commented on others PR)
Good that you have a Predicate class
8 (commented on others PR)
Maybe, abstract away details, for better readability.
9 (commented on others PR)
Can you just combine the two methods, seems like not much of a difference.
10 (commented on others PR)
Abstract away to reduce complicated expressions
11 (commented on others PR)
Do you want to have this as a separate constructor instead. So you would have Room(int roomNumber, Patient patient) and Room(int roomNumber, Patient patient, TaskList taskList).
12 (commented on others PR)
Good for changing the toString method accordingly.
13 (commented on others PR)
Good for changing the equals method.
14 (commented on others PR)
We rearrange later in alphabetical order
15 (commented on others PR)
Can rename it into parseCommand_deletePatient_success() instead?
16 (commented on others PR)
Same here?
17 (commented on others PR)
Use the model.displayAllRoom() for the time being. This part is in code quality and to be done in v1.3.
18 (commented on others PR)
This will result in some problem of some Room UI, leave it as logic.getDisplayRoomList().
19 (commented on others PR)
Instead use, model.displayFindRoom(room); where room is the room you wish to display. This is to prevent other workings of UI to not work.
20 (commented on others PR)
Not necessary would affect UI for Room command and test cases.
21 (commented on others PR)
"There are no rooms in the app yet, please define the # of rooms using initRooms (int) command."
Maybe can change to the above?
22 (commented on others PR)
May be it is better to create a Name field?
23 (commented on others PR)
To be done later.
24 (commented on others PR)
Maybe can include the predicate in a different method like:
private Predicate>Room> getPredicateForSearchRoom(int roomNumberExpected) {
Predicate>Room> predicateForSearchRoom = room1 -> room1.getRoomNumber() == roomNumberExpected;
return predicateForSearchRoom;
}
That is wat I meant.
25 (commented on others PR)
Now that it has been finalised, maybe you want to implement it?
26 (commented on others PR)
Maybe want to change to TaskParserUtil instead of ParseUtil.
27 (commented on others PR)
Maybe can include space between method and javaDoc to see better
28 (commented on own PR)
Okay I will change accordingly!
29 (commented on own PR)
Hi, yes that's why I thought a PriorityQueue would lead to an easier implementation as we can determine its priority in the Room class and we don't have to individually compare details. If you really want an arraylist I can change it though.
30 (commented on own PR)
It is to add the number of rooms into the hotel
31 (commented on own PR)
It is to check for the empty room with the least ID number. So the first room, is the least number that is not occupied.
32 (commented on own PR)
Or if it is occupied then every room is occupied.
33 (commented on own PR)
I thought of that, but why would anyone want to input a negative number?
34 (commented on own PR)
Yes, it is for future person assigned to this task to complete it.
35 (commented on own PR)
but it passed checkstyle
36 (commented on own PR)
I just followed the name of files given above.
37 (commented on own PR)
Okay
38 (commented on own PR)
I dont get your problem here.
39 (commented on own PR)
It wont because 1 and 3 are stored in the hard disk
40 (commented on own PR)
I think you are confused because they are methods in different classes, just like the original code.
41 (commented on own PR)
yeap, im not responsible for tasks and adding person
42 (commented on own PR)
okay sure ill add it
43 (commented on own PR)
I thought AddRoom would be better suited for adding person to room.
44 (commented on own PR)
Same reason stated above.
45 (commented on own PR)
I'll change it if you want.
46 (commented on own PR)
I removed that field.
47 (commented on own PR)
okay
48 (commented on own PR)
Can you clarify?
49 (commented on own PR)
Actually I no longer have this.
50 (commented on own PR)
I see a lot of you have a lot of questions on PQ. I just thought that the comparison would be simpler as the priority is maintained by the PQ, and all we have to do is to poll and we dont have to compare a lot of variables so fewer bugs.
51 (commented on own PR)
Yes
52 (commented on own PR)
Okay, will add!
53 (commented on own PR)
Okay
54 (commented on own PR)
Okay
55 (commented on own PR)
I need it for the Json.
56 (commented on own PR)
Okay will do!
57 (commented on own PR)
Okay
58 (commented on own PR)
That was wat I was wondering too, but didn't want to delete before discussing.
59 (commented on own PR)
Okay!
60 (commented on own PR)
Okay I will change it.
61 (commented on own PR)
Okay.
62 (commented on own PR)
Okay
63 (commented on own PR)
Okay will add, thanks for pointing out.
64 (commented on own PR)
Okay
65 (commented on own PR)
Okay, thanks for noticing.
66 (commented on own PR)
Accidentally deleted.
67 (commented on own PR)
Okay
68 (commented on own PR)
Okay!
69 (commented on own PR)
Okay
70 (commented on own PR)
okay
71 (other comment)
Please don't merge even if there are 2 approvals. Thank you!
@justintzuriel (26 comments)1 (commented on others PR)
Typo on module
2 (commented on others PR)
Change to "A contact can have multiple tags."
3 (commented on others PR)
Can the usage of dots be consistent? Also, add articles (e.g. an assignment) and change 'the' to 'a'
4 (commented on others PR)
Change to 'a user', 'the user', and 'opens'
5 (commented on others PR)
No need to use 'the'
6 (commented on others PR)
Erase 'the'
7 (commented on others PR)
Should there be a space here?
8 (commented on others PR)
Not a department
9 (commented on others PR)
Not a department
10 (commented on others PR)
Shouldn't this be different department?
11 (commented on others PR)
Not a department
12 (commented on others PR)
Change to Information Systems
13 (commented on others PR)
Change to Information Systems
14 (commented on others PR)
Not a department
15 (commented on others PR)
Change to Information Systems
16 (commented on others PR)
Lowercase D
17 (commented on others PR)
Should this be duplicate modules?
18 (commented on others PR)
Perhaps change to personsCs1101s to adhere to the coding standard?
19 (commented on others PR)
Change naming to adhere to coding standard
20 (commented on others PR)
Change naming to adhere to coding standard
21 (commented on others PR)
I agree, might be mistaken for Name in Person
22 (commented on others PR)
I think it is a good idea, it is more descriptive (and has the same format with ModuleName)
23 (commented on others PR)
Sounds like a good idea
24 (commented on others PR)
Shouldn't this be moduleCode?
25 (commented on others PR)
Can change this to modules?
26 (commented on others PR)
Does "This instructor is not assigned to this module" sound better? Also no need to use a dot.
27 (commented on own PR)
The codeSet won't be changed (also followed the code from parseTags in the same file)
28 (commented on own PR)
I was following the pattern from the other methods (contains, add, remove, etc), let me change the naming for those as well.
@jiaweiteo (26 comments)1 (commented on others PR)
Maybe can add the person to be deleted is not found?
2 (commented on others PR)
Same for accommodation and activity use cases also
3 (commented on others PR)
So its not the command format but the error is missing person/accommodation/activity
4 (commented on others PR)
Should we handle duplicate person/accommodation/activity when adding?
5 (commented on others PR)
Need add use cases of edit function? Or too long already
6 (commented on others PR)
Think the command is called 'show' instead?
7 (commented on others PR)
I think can change address to location class? Since our user guide its location class. Can just import from activity.
8 (commented on others PR)
Should be setAccommodation instead
9 (commented on others PR)
Exception class shld be accommodation, same for the next one
10 (commented on others PR)
unable to find specified accommodation
11 (commented on others PR)
duplicate accommodation.
12 (commented on others PR)
Should passport and mobile number be a data field since its a tag? Not compulsory for users to input.
13 (commented on others PR)
If phone and passport is not identity fields, it shldnt be here alr
14 (commented on others PR)
we shld restrict phone number to 8 digits for SG
15 (commented on others PR)
Have to change regex already to maybe this d{8}?
16 (commented on others PR)
can just initialise to private final Phone phone. Same for all classes. Just import the package at the start can alr
17 (commented on others PR)
Same problem no need full package name
18 (commented on others PR)
editedPerson change to editedFriend
19 (commented on others PR)
Should change person to activity
20 (commented on others PR)
Same
21 (commented on others PR)
Wishlist
22 (commented on others PR)
activities
23 (commented on others PR)
Need add TravelPlanPanel, TravelPlanObjectListPanel?
24 (commented on others PR)
DeleteCommandParser is Called WanderlustDeleteCommandParser for all
25 (commented on others PR)
OK MY BAD
26 (commented on others PR)
I think the accomodation class requires start date and end date to be the same too for two accommodation object to be the same.
27 (commented on own PR)
Ya but i dont know what badges we should add, there's quite a few different one
28 (commented on own PR)
Ok added
29 (commented on own PR)
Changed
30 (commented on own PR)
Changed
31 (commented on own PR)
Okay changed!
32 (commented on own PR)
This test will fail so i changed it back.
33 (commented on own PR)
Ok resolved. Thanks!
34 (commented on own PR)
Resolved.
35 (commented on own PR)
Resolved.
36 (commented on own PR)
Resolved.
37 (commented on own PR)
Resolved.
38 (commented on own PR)
Resolved.
39 (commented on own PR)
Resolved
40 (commented on own PR)
Resolved.
41 (commented on own PR)
resolved.
42 (commented on own PR)
Resolved.
43 (commented on own PR)
Resolved.
44 (commented on own PR)
Jeanne say for the UI one make it more spread out
45 (commented on own PR)
Ok i can delete that one whitespace
46 (commented on own PR)
hmm it works fine leh, maybe after yall merge can try it out first, got any problem we can fix too
47 (commented on own PR)
oh.......
48 (commented on own PR)
ok thxtx
49 (commented on own PR)
cannot do this if not compilation will fail for checkstyleMain. AB3 doing like this too.
50 (commented on own PR)
Solved
51 (commented on own PR)
??? i got change wts
52 (commented on own PR)
ok
53 (commented on own PR)
i think we should show index in ui
54 (commented on own PR)
no theres a space.. thats why we use keyword[1] instead or [0] to access "-travelplan'"
55 (commented on own PR)
I thought name card is the name of the travelplan, which is the travelplan panel? the one that shows the name and date
56 (commented on own PR)
Oya ok i changed ps
57 (commented on own PR)
ok changed
@qlchan24 (26 comments)1 (commented on others PR)
Addressbook can be changed to CLI-nic
2 (commented on others PR)
'serves'
3 (commented on others PR)
name changed
4 (commented on others PR)
name changed
5 (commented on others PR)
Seems like this can be final also.
6 (commented on others PR)
Perhaps the updatedQuantity should be renamed to productQuantity, because it seems like this should be a general constructor that future functions other than updateQuantityForWarehouse can use.
7 (commented on others PR)
Since it is mentioned in your javadoc that this is meant specifically for suppliers, perhaps u can follow the naming convention that u did for toStringWarehouse. That being said, toStringForWarehouse may be better.
8 (commented on others PR)
Perhaps this can be renamed to ALLOWED_ARGUMENTS or ALLOWED_ARGUMENT_LIST
9 (commented on others PR)
I think there should be a \n here
10 (commented on others PR)
same as above
11 (commented on others PR)
perhaps its better code quality to explicitly specify the else with a separate if statement.
12 (commented on others PR)
To do javadocs
13 (commented on others PR)
comment should be updated as well
14 (commented on others PR)
i think the naming for this is a bit confusing, at least at first glance, perhaps can change everything to all
15 (commented on others PR)
I think you can just use list.of() instead of arrays.aslist(String[]{})
16 (commented on others PR)
ab used to stand for addressbook, now it has no meaning so i think it should be changed
17 (commented on others PR)
I think you might have forgotton to remove this.
18 (commented on others PR)
"ui" should be capitalised. "i.e." should have 2 dots.
19 (commented on others PR)
"set of products" or "set of Product" or "product set" may sound more grammatically correct.
20 (commented on others PR)
"The retrieved product set will remove this product from the set" sounds a bit inaccurate. Perhaps it can be replaced by just "the retrieved product will be removed from the set"
21 (commented on others PR)
"The model will also update the warehouse with the new warehouse with the target product deleted." also can be replaced with "the model will also be updated with a new warehouse with the product deleted. "
22 (commented on others PR)
I think it should be " with a success message".
23 (commented on others PR)
It might be better to call the feature add product feature. 'addp' is the command word which should be used with the double tildas in my opinion
24 (commented on others PR)
I guess to make it clearer instead of "at any one time", u can say "in a single add command". will help also when macros can execute multiple at once (if implemented)
25 (commented on others PR)
perhaps the "(for warehouse only)" shouldnt be within the tildas, same issue repeated below. Also is there a reason for the "+".
26 (commented on others PR)
not sure if NAME should be in tildas
27 (commented on own PR)
Yes, It is the case. the latter is the stricter check.
28 (commented on own PR)
Yup, its just a dummy function for the stub
29 (commented on own PR)
Yes, thats what I meant.
30 (commented on own PR)
Thats true, Ill update the example accordingly. Thanks!
31 (commented on own PR)
Hmm not sure either...full name is originally a public attribute with no getters, and this .fullname is used is several places in the original code as well. Same for the other supplier/warehouse properties.
32 (commented on own PR)
Yes, thanks for spotting the error
33 (commented on own PR)
Thanks! will fix it.
34 (commented on own PR)
Actually both clinic and user macros are part of the {@code storage} thats why they are not in the brackets.
35 (commented on own PR)
True, will change it!
36 (commented on own PR)
Good spot! Thanks.
37 (commented on own PR)
True i'll amend it.
38 (commented on own PR)
Oh yes. Good spot.
39 (other comment)
LGTM
40 (other comment)
LGTM
41 (other comment)
For the part about commands only keeping the results from the last occurrence of a specified descriptor, I think it was originally not so much a bug but rather an intended outcome, as there are explicit test cases in the original AB3 to show that multiple descriptors of the same prefix will be accepted without error but only the last will be used. We can do an alternative approach though I would not think its absolutely necessary.
As for the case sensitivity, I guess we can discuss both the case sensitivity of the command syntax (command word/prefixes) and the user-supplied command arguments. For the command word at least, the case should not matter and we can make it case-insensitive to improve user experience, though I would think it's not a pressing issue as we can do without too.
For the redundant strings at the back of commands and the explicit ordering of arguments, it currently applies for those commands that dont actually use prefixes. For those with prefixes, changing it to allow redundant arguments may be a bit cumbersome, since currently all the arguments at the back will just be allocated to the last prefix, and we would require additional command-specific parsing to split the last prefix from the redundant strings if they would otherwise be parsed as invalid format for the last prefix. For those that don't, we can either make it explicit that redundant strings are allowed in the user guide for these commands or just don't accept them. Similarly for the ordering, we can either make these commands accept prefixes as well since they are multi-argument like the rest of the commands so that they disregard order, or we can explicitly state their difference in the user guide.
@zhiayang (25 comments)1 (commented on others PR)
sure, makes sense
2 (commented on others PR)
will fix
3 (commented on others PR)
i wasn't smart enough to think of this at the time
4 (commented on others PR)
doesn't compile, looks like we both need to retake 2030
5 (commented on others PR)
yes, it is designed to modify its input arguments. this wouldn't be necessary if java had some semblance of decent features after 14 versions, like pattern matching;
this is how i use bisect in a proper language:
std::string_view x;
std::string_view xs;
std::tie(x, xs) = util::bisect(input, ' ');
if(x.empty()) return { };
if(x[0] == '@')
{
parse_tags(msg, x);
std::tie(x, xs) = util::bisect(xs, ' ');
}
if(x[0] == ':')
{
parse_prefix(msg, x);
std::tie(x, xs) = util::bisect(xs, ' ');
}
unfortunately this can't be done in java (there's no std::tie equivalent, nor can there ever be). rather than introduce loads of syntactic noise by needing to (a) declare a pair to store the bisectionr result; (b) declare or assign a variable for the first part; (c) declare or assign a variable for the second part, it is more convenient this way.
besides, bisect() clearly documents its mutating behaviour.
6 (commented on others PR)
for this kind of boolean parameter, i suggest doing something like this:
return new CommandResult(SHOWING_HELP_MESSAGE, /* showHelp: */ true, /* exit: */ false);
so that it's easier to see what the true and false mean without going into the definition of the class/function.
7 (commented on others PR)
sm0l style issue but there should probably be a newline here
8 (commented on others PR)
another small thing but probably it'll be easier to define the commandResult only when you need it (ie. on line 43 instead of 41)
9 (commented on others PR)
this isn't c89 can you please define the int in the correct place
10 (commented on others PR)
is this better named currentIndex
11 (commented on others PR)
is it possible to make this a List>IngredientRef> (or a List>JsonAdaptedIngredientRef>) or something? feels a bit fragile to be storing it as name (qty) as a string in the json file
12 (commented on others PR)
return Quantity.parse(words[1])
.map(qty -> new IngredientReference(words[0], qty);
13 (commented on others PR)
surely you meant words[0] here since you want the name? (line 39)
14 (commented on others PR)
can use Mass.grams(10) so you don't need to unwrap the Result
15 (commented on others PR)
not done yet ah
16 (commented on others PR)
wait a minute, isn't this file a duplicate of the CommandDispatcher
17 (commented on others PR)
ups
18 (commented on others PR)
can we just use String.format for this instead of this stringbuilder nonsense
19 (commented on others PR)
isn't this just this.isSame((Entry) other)
20 (commented on others PR)
what's with this monkaMEGA indentation
21 (commented on others PR)
doesn't this regex mean tag names can't contain spaces?
22 (commented on others PR)
eh i dun understand why y'all love to copy-paste this equals method with these same useless comments
23 (commented on others PR)
did you forget that you had Tag::getTagName()
24 (commented on others PR)
maybe you should make a smol nested helper class for this
25 (commented on others PR)
pog
26 (commented on own PR)
less typing. as you know typing places strain on your wrist, which is bad for health <- cwf="C:\repos\nus-cs2103\dashboards-base\contents\cs2103\tp-comments-panels.mbdf"> var is good for health
ok but most of the time, var is used either (a) when the type is obvious, like this:
var foo = new SomeOverlyLongClassName();
// versus:
SomeOverlyLongClassName foo = new SomeOverlyLongClassName();
and (b) when the type is not important, like in this case. explicitly writing Map.Entry<Optional<ExpiryDate>, Quantity> is tedious and doesn't contribute anything to the clarity of the code.
</->
27 (other comment)
Looks good to me 👍. Thank you for your contribution!
28 (other comment)
Looks good to me 👍. Thank you for your contribution!
29 (other comment)
Looks good to me 👍. Thank you for your contribution!
30 (other comment)
Look good to me 👍. Thank you for your contribution!
31 (other comment)
Looks good to me 👍. Thank you for your contribution!
32 (other comment)
Looks good to me 👍. Thank you for your contribution!
33 (other comment)
Looks good to me 👍
34 (other comment)
Closed by #43
35 (other comment)
Closed by #38 and #40
36 (other comment)
ready for merge
37 (other comment)
ready to merge
38 (other comment)
Closed by #40
39 (other comment)
Closed by #38
40 (other comment)
looks good to me, blah blah etc. etc thumbs up
41 (other comment)
Closed by #52
42 (other comment)
Closed by #52
43 (other comment)
ups
44 (other comment)
Looks good to me 👍
45 (other comment)
hmm, yea that makes sense. but idk if we’re gonna put some sample data by default like AB3?
but ya either way i think should have some getting started text on that page, but maybe only the first launch bah
46 (other comment)
i don't actually know why there's a need for regex validation, especially now that the regex is just all ascii.
also why can't i name my recipe お握り
47 (other comment)
cool
48 (other comment)
sorry i mean
LoOkS GoOd tO Me! 👍 ThAnK YoU FoR YoUr cOnTrIbUtIoN!
49 (other comment)
ready to merge
50 (other comment)
Duplicate of #76
51 (other comment)
oops
52 (other comment)
branch is even with master, plz merge
53 (other comment)
done
54 (other comment)
ez
55 (other comment)
ah, this is a good solution.
56 (other comment)
btw doing closes A, B, C, and D only marks A as being closed by this pr
57 (other comment)
cool
@raymondge (24 comments)1 (commented on others PR)
Maybe Priority Queue for room search should leave it for further version? We could use a arraylist to found the first empty room probably? B'coz priority may need constant update to R/W whenever a room state is changed
2 (commented on others PR)
I think "next" could be a little vague, coz the user may not know which room they are in, maybe "finds the first free room" could be better?
3 (commented on others PR)
just minor gramma, "rooms"
4 (commented on others PR)
good code quality improvement!
5 (commented on others PR)
I am not so sure why there's a "-", so is it that the user will specifically put an "-" or is it an invalid input
6 (commented on others PR)
I think this method should be changed with a name getValidpatient and should return a patient as the name suggests. isValidPatient is like a boolean method and should only return a boolean
7 (commented on others PR)
Mabybe using a switch could be better for readability?
8 (commented on others PR)
Nice to have an observablelist for getroom
9 (commented on others PR)
maybe can change to: "there are no room in the app yet, please define no of rooms"
10 (commented on others PR)
really nice to change to 4.0 --> 3.10
11 (commented on others PR)
I think it's a bit unclear about the change of room number, is it that room 3 doesn't exist before change or room 3 already exist and we move all patient from room 1 to room 3 and now room 3 has all patient from room 1(previously) and 3?
12 (commented on others PR)
I think it's better to break the sentence After the fullstop
13 (commented on others PR)
Just small gramma "AssignedToRoom"
14 (commented on others PR)
This sounds a bit weird to me. Maybe change it to "All patients are listed" or " list all patients"
15 (commented on others PR)
I think later when you complete the searchroom rmb to remove the "%1$s" as it's a list of string
16 (commented on others PR)
Good change to modifiableRoomList as a diff to unmodifaibalbeRoomList
17 (commented on others PR)
good assertion! If the targetroom is null, it will be prehandled by the commandexception
18 (commented on others PR)
I think instead of letting the model to handle deleteTask, the deletetaskcommand class should handle it instead for abstraction
19 (commented on others PR)
Maybe add a success case for test?
20 (commented on others PR)
oh then that's ok I guess
21 (commented on others PR)
hmm I think the same patient object should still have the same temperature
22 (commented on others PR)
Nice job to separate to more cases!
23 (commented on others PR)
remember to remove the system.out.print after doing the "actual" testing
24 (commented on others PR)
Maybe consider "returns" instead of "gets" for javadoc consistency?
25 (commented on own PR)
yup! SearchPatientDescriptor is a better name
26 (commented on own PR)
will focus on the style!
27 (commented on own PR)
yup, can isolate it to be another method
28 (commented on own PR)
yup, can change to "search a patient or a list of patient ..."
29 (commented on own PR)
sure
30 (commented on own PR)
sure!
31 (commented on own PR)
This is really a good idea! Thanks for bringing it up
32 (commented on own PR)
YUP!
33 (commented on own PR)
Hmm.. I feel both method name is ok
34 (commented on own PR)
Definitely true
35 (commented on own PR)
I will change it to "Search a patient or a list of patients with specific criteria"
36 (commented on own PR)
sure!
37 (commented on own PR)
good sugguestion!
38 (commented on own PR)
The main reason I put this is just because I feel that it is not necessary to output a list when there is only one item
39 (commented on own PR)
Yup! Thanks for the advice!
40 (commented on own PR)
the substring(2) is to substract away the header ("n/")
41 (commented on own PR)
I think getPreamble will work just fine!
42 (commented on own PR)
actually I think getPreamble cannot work since the command is searchpatient n/alex, so there isn't a preamble for the command for now
43 (commented on own PR)
Sure!
44 (commented on own PR)
Yup, will take note of the gramma
45 (commented on own PR)
I think as of now, we will save the UI for v1.3 for task, so v1.2 we will juz display the result in the bot's response
46 (commented on own PR)
I will add more success test case in v1.3
47 (commented on own PR)
yup
48 (commented on own PR)
I am not sure whether we need to leave a line also, but thanks for the "s" reminder!
49 (commented on own PR)
Sure!
@aidoxe-123 (24 comments)1 (commented on others PR)
Since ParserUtil.java is still there, is it better to keep this test file instead of deleting it?
2 (commented on others PR)
What's wrong with this test
3 (commented on others PR)
Does the position of the unnamed parameter matter?
How does the program behave towards these commands:
edit -n JohnDoe 1
edit1 -n JohnDoe
4 (commented on others PR)
Just to justify my curiosity, can a command have multiple unnamed parameters?
5 (commented on others PR)
I think this should be AddCommand.COMMAND_WORD instead of "add", the same for other commands
6 (commented on others PR)
Although these test classes will be changed in McGymmy, is it better to keep them just for this PR to make sure that the new parser is working properly with the old AddressBook test first?
7 (commented on others PR)
Same comment as AddCommandTest.java
8 (commented on others PR)
Same comment as AddCommandTest.java
9 (commented on others PR)
Same comment as AddCommandTest.java
10 (commented on others PR)
Same comment as AddCommandTest.java
11 (commented on others PR)
Maybe add some more tests for the old address book's logic, to make sure that it works exactly as expected as the old parser?
12 (commented on others PR)
I think naming it toString is enough
13 (commented on others PR)
I think naming it getCalories is enough
14 (commented on others PR)
I think the first letter of the string should be capitalized to be the same format as other files
15 (commented on others PR)
Inconsistent verb tense: In some files, the string is present simple tense whereas, in other files, it is infinitive.
16 (commented on others PR)
Maybe adding an example here too?
17 (commented on others PR)
Can you add addCurrentStateToHistory(); in this line so that undo command can refer to this state later
18 (commented on others PR)
Is it better if you implement this test case in this PR too?
19 (commented on others PR)
Since you have already had an if statement below, I don't think this line is needed
20 (commented on others PR)
I think changing it to this will make the code shorter:
'''
this.date = null;
try {
date = ParserUtil.parseDate(date);
}
[rest of the code]
}
21 (commented on others PR)
Is there any case where this test can really get an exception?
22 (commented on others PR)
Instead of using null, how about declaring a subclass of FoodContainPredicate that always returns true, then use
FoodContainsKeywordsPredicate foodPredicate = foodPredicateParameter.getValue().orElseGet(THAT_CLASS_NAME::new]);.
23 (commented on others PR)
The FoodContainsKeywordsPredicate has already included NameContainsKeywordsPrecdicate and TagContainsKeywordPredicate.
24 (commented on others PR)
yea this works too
25 (commented on own PR)
object equality is intended, as I was checking if fridge and expected fridge contains the same elements. I have overridden the equals method for fridge class
26 (commented on own PR)
Ok I will change it that way
27 (commented on own PR)
Oops, I forgot to implement it. I will implement it in the next commits
28 (commented on own PR)
Ok I will change it
29 (commented on own PR)
I think we should keep it that way to prevent potential typos. Instead of that, we can add a comment at the end of the line to explicitly state what Carbohydrate.class.getName() is
30 (commented on own PR)
I was just changing the name of the class. I haven't changed any of its implementations.
31 (commented on own PR)
Ok I will change it
32 (commented on own PR)
Fixed
33 (commented on own PR)
Fixed
34 (commented on own PR)
Actually, we cannot call this.class before the object is initiated. Therefore, this.class.getName() cannot be put in either Macronutrient's constructor or a static method.
I think one alternate option is that we can use this.class.getName() as a replacement for the macronutrientType attribute
35 (commented on own PR)
Got it!
36 (commented on own PR)
Fixed
37 (commented on own PR)
Fixed
38 (commented on own PR)
The tag search is already case sensitive.
Ok I will change the name
39 (commented on own PR)
Isn't making the tag search case sensitive better for categorizing food items? The user can search for exactly one tag that they want.
40 (commented on own PR)
Haha so i mark this as resolved now
41 (commented on own PR)
Thanks =))
42 (commented on own PR)
Even if the string is in the correct format, it is still not guaranteed that it can be parsed. For example, 31-31-2020. We still need the empty catch clause either way
43 (commented on own PR)
I remembered them said empty catch clause should be avoided, but if there is no other way to avoid it, we should comment why. I think putting a comment there is good enough
44 (commented on own PR)
Added
45 (commented on own PR)
I move those lines in EditCommand, TagCommand, and UnTagCommand ModelManager#setFood instead since they all call this method
46 (commented on own PR)
I've added one assertion in the latest commit
47 (commented on own PR)
Done!
48 (other comment)
LGTM.
49 (other comment)
The CI test says that you are missing the shadow plugins
50 (other comment)
I think your use case have the same id as sean's.
51 (other comment)
LGTM.
52 (other comment)
LGTM.
53 (other comment)
Might also add an extension like this:
find -all [keyword 1] [keyword 2] ... to find foods that match all of the keywords
find -some [keyword 1] [keyword 2]... to find foods that match some of the keywords
54 (other comment)
I think this would create potential bugs. For example, assume there are food items with the same name, fat, carbs, protein, date but different tags in the fridge. Then you filter a tag name and delete the filter result. It might delete the wrong food item because List#remove(E e) only removes the first occurrence of e.
To prevent this, I think you might need to update the Food#equals method
55 (other comment)
Change according
I think you can do smth like what Kamil and I did and abstract out the Parsing part? This will remove the McGymmyParser part completely and make the diagram less complicated
Fixed!
56 (other comment)
Do we want an option to find before/after a certain date? i.e. show all foods created before/after a certain date?
Or we can put this in another PR/not do this at all.
I think we should create another pr.
57 (other comment)
If the user calls list multiple times, what should be the expected behavior of the program? Should it allow undoing the same number as the number of list command, or just 1 time?
58 (other comment)
bug found
What is the bug
@tankangliang (23 comments)1 (commented on others PR)
Should be added to Table of Contents as well if we're adding in a new command list
2 (commented on others PR)
The table of contents is actually generated by GitHub with
* Table of Contents
{\:toc}
With this addition we will have two copies of the TOC on our documentation website.
While editing this, could you also change the spelling of "Travelling Businessman" in "Glossary" to have a capitalized "M"?
3 (commented on others PR)
Minor point, but can this be changed to "E.g." instead of "eg" with the period.
4 (commented on others PR)
+ "client edit INDEX [n/NAME] [p/PHONE] [e/EMAIL] [a/ADDRESS] [c/COUNTRY] [tz/TIMEZONE]\n"
5 (commented on others PR)
Should this be checked with requireNonNull(predicate)?
6 (commented on others PR)
String can be put into a constant for clarity
7 (commented on others PR)
Similarly, is requireNonNull needed here?
8 (commented on others PR)
This check seems to be carried out in ParserUtil already
9 (commented on others PR)
/** Client command in the form client view index, where index points to the index of the client at current location
of the rendered */
10 (commented on others PR)
Should fill in the javadoc here
11 (commented on others PR)
/** Client command in the form client view index, where index points to the index of the client at current location
To be more inline with the coding standards
12 (commented on others PR)
Could you change the class and file name to ClientViewCommandParser? I will be updating the ones for Find and Delete in a future PR
13 (commented on others PR)
Missing javadoc for return here too
14 (commented on others PR)
/** Client command in the form client view index, where index points to the index of the client at current location
Pls have the space there 😦
15 (commented on others PR)
This should probably be moved over to Country.java to be more consistent with the other classes.
16 (commented on others PR)
In AddressBookParser, the arguments are passed in as return new ClientNoteAddCommandParser(tagNoteMap).parse(arguments);. Shouldn't the preamble consist solely of the integer without the command word of client note add?
Inside ClientEditCommandParser, the index is parsed as such index = ParserUtil.parseIndex(argMultimap.getPreamble());
17 (commented on others PR)
There are helper functions assertParseSuccess and assertParseFailure that are used in testing of the other parsers, would it be applicable in this case as well?
18 (commented on others PR)
Wouldn't it be better to use NOTE_CONTENT_1 to show that there will definitely not be a difference in the input to the two notes?
19 (commented on others PR)
Is there a reason that this is instantiated differently from the rest?
20 (commented on others PR)
Similar to above
21 (commented on others PR)
Should this be used instead to check for validity of a date string? Then we could do away with the regex since it doesn't actually filter out 31-Feb.
22 (commented on others PR)
Maybe idx1 here since it's clientNote1
23 (commented on others PR)
Is there a reason clientNote1 is NOTE_CONTENT_2?
24 (commented on own PR)
I'll update for delete but leave find as it is for now, I think someone else is working on find?
25 (commented on own PR)
I think we can leave that to the refactoring since the hashmap currently uses String as the key
26 (commented on own PR)
Initially it was because ClientUtil.java needed to build the command given the client's details, I changed the implementation of getClientDetails to explicitly use getCountryCode() so this function isn't currently in use now. I thought it would make sense to have countryCode since that is the value passed into the object like the other fields.
27 (commented on own PR)
Fixed
28 (commented on own PR)
Fixed
29 (commented on own PR)
Fixed
30 (commented on own PR)
ok, i've added it in.
31 (commented on own PR)
actually, i just checked, it's supposed to be part of my other issue LOL
32 (commented on own PR)
possible, I initially put it as an enum but it seemed too different from the rest of the code base. What do you think @qwoprocks
33 (commented on own PR)
yea forgot to change it when i updated to mingchong's changes 😦
34 (other comment)
While updating this, could you add in numbering for the use cases as well? Then this statement can refer to other use cases as an example.
35 (other comment)
Does #121 branch continue from this PR? If it does this PR can be closed.
36 (other comment)
Resolved in #117
37 (other comment)
Resolved in #119 #131 #137
38 (other comment)
Resolved in #119
39 (other comment)
Resolved #134
40 (other comment)
Resolved #134
41 (other comment)
Not relevant. Note interface is no longer being created.
42 (other comment)
Resolved #134
43 (other comment)
Updated in collaborative notes.
44 (other comment)
Currently have "([A-z ]+) ((\d+)?([ \w/]+)?)" as the regex which tries to separate commandWord from arguments through detecting either a number or a prefix. Requires " " to be padded to the end but this fails for "client find KEYWORD".
@junhui-phoon (23 comments)1 (commented on others PR)
think there's a typo here, eva.jar -> MyFitnessBuddy.jar
2 (commented on others PR)
should be the original persons, this MIT license file no need to edit.
3 (commented on others PR)
need to change the logger message also
4 (commented on others PR)
is this still supposed to be getAddressBook() or getPerson()? Only the Javadocs header is changed but not the actual code.
5 (commented on others PR)
Refactor this method
6 (commented on others PR)
hmm now calorie command no need dates?
7 (commented on others PR)
need a Javadocs header here to explain what this class is for.
8 (commented on others PR)
javadocs header for the class and the methods, just copy, paste and edit from other existing ones.
9 (commented on others PR)
refactor the ReadOnlyAddressBook interface
10 (commented on others PR)
refactor this whole interface class
11 (commented on others PR)
javadocs header here
12 (commented on others PR)
javadocs header
13 (commented on others PR)
javadocs header
14 (commented on others PR)
refactor this method
15 (commented on others PR)
Need to edit this javadoc
16 (commented on others PR)
This one should be Stopping My Fitness Buddy haha
17 (commented on others PR)
this whole class refactor to MyFitnessBuddyParser
18 (commented on others PR)
refactor this class to MyFitnessBuddy
19 (commented on others PR)
refactor this class to ReadOnlyMyFitnessBuddy
20 (commented on others PR)
Javadocs header
21 (commented on others PR)
Javadocs header
22 (commented on others PR)
Javadocs header
23 (commented on others PR)
Javadocs header
24 (other comment)
i will wait for @wayne987 PR then i will merge to prevent conflicts.
25 (other comment)
can sync your fork with the team repo again? so the CI can pass
26 (other comment)
left @wayne987 part
27 (other comment)
yeap is correct
28 (other comment)
closed without merging
29 (other comment)
closed without merging
30 (other comment)
closed without merging
31 (other comment)
LGTM
32 (other comment)
I will leave this issue open if there's anything more to add. Link a new PR to it if have.
33 (other comment)
Still rewriting all the test cases code, CI will fail
34 (other comment)
Weight is added using the 'add' command with a prefix 'w/', additional fields will be removed in another PR.
35 (other comment)
Current UI modifications for MVP
36 (other comment)
@wayne987 please review thanks
37 (other comment)
Closed without merging, code not required
38 (other comment)
CI is expected to fail
39 (other comment)
Before Fix:
After Fix:
40 (other comment)
Looks good to me.
41 (other comment)
Calorie Stats:
Weight Stats:
Will change the miscellaneous stuff (background colour etc) later
42 (other comment)
will it be better if theres another separate Statistic class that calculates all the required data for calorie and weight instead?
no calculation involved here, all the required data is pulled from Observable List
43 (other comment)
Dark Theme for Charts:
44 (other comment)
Already done, just need to merge my previous stats PR #89
45 (other comment)
I would recommend that this will be merged first
46 (other comment)
Merge this PR only after PR #89 because this branch is merged with commits from PR #89
47 (other comment)
Merge only after PR #103; need to verify sorting for charts
48 (other comment)
Changed to Bar Chart for calorie stats for better visualization:
@siangernlow (23 comments)1 (commented on others PR)
I think for this, it could just be "User enters the required details" since implementation details are not needed for use cases
2 (commented on others PR)
Same as the above. Instead of this, perhaps you could try "User requests to cancel the command"?
3 (commented on others PR)
I think for this, it could just be "User enters the required details" since implementation/UI details are not needed for use cases.
4 (commented on others PR)
Same as above. Perhaps you could try "User requests to cancel the command" instead?
5 (commented on others PR)
I believe bullet points are required for indentation here as well.
6 (commented on others PR)
Perhaps a new indentation would be good here?
7 (commented on others PR)
is there a typo here?
8 (commented on others PR)
Might be better to mention that this command deletes everything before and up to the given date. It may be misunderstood to just delete visits on that date itself.
9 (commented on others PR)
What might this suppress warning be for?
10 (commented on others PR)
There shouldn't be a space after the method name. Also, since this method deletes multiple visits, maybe calling it deleteVisits would be more suitable.
11 (commented on others PR)
This functionality could perhaps be moved into the for loop above? Then there would not be a need for an additional ArrayList to keep track of the visits to be deleted.
12 (commented on others PR)
argMultimap.getPreamble().isEmpty() should be !argMultimap.getPreamble().isEmpty(), otherwise the code fails.
13 (commented on others PR)
Only this part causes errors; the other comments are queries/small formatting errors.
14 (commented on others PR)
The JavaDocs for this Predicate could be clearer as this Predicate is not as straightforward as the others.
15 (commented on others PR)
Might be better to name the conditions separately with informative names as this line of code can get confusing.
16 (commented on others PR)
Now that there are three parameters for the constructors, perhaps it could be better if each parameter is tested for NullPointerException in a separate method.
17 (commented on others PR)
Typo here. Shouldn't be nullLocation but instead the parameter that is null in this method.
18 (commented on others PR)
Shouldn't date be required to be non null as well?
19 (commented on others PR)
Could this be moved to the ModelPredicate class as the predicates are being stored in that class at the moment?
20 (commented on others PR)
Is there a typo in the method name?
21 (commented on others PR)
Typo in the word 'where'
22 (commented on others PR)
Perhaps Generating could be used instead of Listing
23 (commented on others PR)
I think for this, referencing the index rather than id is required. I believe the current master branch has an example of this.
24 (commented on own PR)
Yes, these methods should already be functional barring unforeseen bugs.
25 (commented on own PR)
The method was added for the following reasons:
The Person and Visit classes both have these two methods in Model - getFiltered[x]List() and updateFiltered[x]List() where x is either of those classes. As the InfoHandler class requires the getFilteredLocationList(), I felt it was apt that updateFilteredLocationList() was added as well.
Also, the addLocation method in the ModelManager requires the updateFilteredLocationList() as well.
As for the test above, the function is required to be overwritten for the ModelStub to be created.
26 (commented on own PR)
Done
27 (commented on own PR)
Done
28 (other comment)
When creating an issue, try to specify the part of the project the issue is meant to be working on by using square brackets in the title. If the issue does not specify anything, it is assumed to be implementation-based, i.e., related to modifying AB3/VirusTracker code.
Example: [DG] Add UC01 and UC02 indicates that this issue works on adding user cases 01 and 02 to the developer guide.
Mandatory label:
priority.* Indicates the priority level of the task. Has three levels, low, medium and high.Apart from the mandatory priority label, you may include other labels to make it easier to search and locate issues. Feel free to add any labels, but please ensure no similar label already exists.
29 (other comment)
General note: PRs can only be merged only when two or more other people have reviewed and approved of the merge.
When creating the PR, please state which issues the PR closes on the last line of the description.
Commit message: keyword #xx, keyword #yy, keyword #zz for multiple issues
keyword refers to any one of the following three words, close, fix, resolve.
Using these keywords will cause the issue to be automatically closed once the PR is merged successfully.
_Note: Other tenses for the above words could be used as well, such as closes or closed, but let us standardise using the
imperative form of the words above._
#xx references the issue number, where xx is the number. For example, xx = 10 will reference issue number 10.
Example: xx = 30
...PR description here
Close #xx
The above will close issue 30 upon the successful merging of the PR.
The actual form of #xx is not used in this comment as it would reference actual issues. Please refer to the PRs page for more examples.
30 (other comment)
The user cases have been added, and this issue will be closed
31 (other comment)
This user story has been added, and this issue will be closed.
32 (other comment)
This user story has been added, and this issue will be closed.
33 (other comment)
Location classes have been completed, statistics classes will be moved to v1.2.
34 (other comment)
A new LocationHandler class should be created to be in charge of handling the statistics.
35 (other comment)
I've updated the title accordingly to avoid confusion
36 (other comment)
Rather than LocationHandler, we can instead create an InfoHandler class which additionally handles people and visits
37 (other comment)
Issue can be closed, InfoHandler class has been implemented with relevant methods.
@wenhaogoh (23 comments)1 (commented on others PR)
Will removing the "find Grab" example make the table look neater?
2 (commented on others PR)
Are we missing the details for adding an expenditure?
3 (commented on others PR)
Perhaps "Temasek Hall" is too specific to NUS? Users who are not from NUS may not understand what it means. "Daily Expenses" might be a better example. I noticed the same issue in several other places.
4 (commented on others PR)
Will it be more concise to use "budget" instead of "budget book"? I noticed the same issue in several other places.
5 (commented on others PR)
Will it be better if "must be a positive integer" is bolded to draw users' attention to this restriction?
6 (commented on others PR)
Same issue as above regarding the bolding of "must be a positive integer or double with a maximum of 2 decimal places". There seems to be two spaces between "of" and "2".
7 (commented on others PR)
Same issue as above.
8 (commented on others PR)
Perhaps it might be more cohesive to capitalise "school fees"? I noticed the same issue in several other places.
9 (commented on others PR)
Yup, let's use "budget" instead of "budget book" as discussed. Good catch 👍
10 (commented on others PR)
There is a missing space between the and LogicManager.java.
11 (commented on others PR)
Perhaps DevOps should be separated with a white space to follow the title?
12 (commented on others PR)
Should this be ExpenditureCard instead?
13 (commented on others PR)
Perhaps it will be more OOP if there is an additional private method to get the the budget of a certain index.
14 (commented on others PR)
Same issue here.
15 (commented on others PR)
Perhaps it is more appropriate if the method "isValidBudgetName" is changed to "isValid"?
16 (commented on others PR)
Perhaps it is more appropriate if the argument "budgetName" is changed to "name"?
17 (commented on others PR)
Perhaps the naming should be "isExpenditure"?
18 (commented on others PR)
Is this condition redundant?
19 (commented on others PR)
Perhaps the sentence should start with "Executes"?
20 (commented on others PR)
Same issue here
21 (commented on others PR)
Perhaps the class diagram should have a caption "Figure 3.4.1..."?
22 (commented on others PR)
Should the class objects be wrapped using ``?
23 (commented on others PR)
Same issue here.
24 (other comment)
If you want, you can re-upload your photo so that it scales correctly. @sogggy
25 (other comment)
The examples for adding an expenditure is not in the correct format.
@StopTakingAllTheNames (23 comments)1 (commented on others PR)
Might want to remove this line since everyone else also did so
2 (commented on others PR)
You may want to add a (written by: AUTHOR) statement before the part that you wrote because I think they want to see who wrote what.
3 (commented on others PR)
Whoops, I had changed Year to only allow digits, so this might fling an exception since it's expecting only "4"
4 (commented on others PR)
Just a minor nitpick for neatness, but I think these 2 lines could be on the same level of indentation as line 64.
5 (commented on others PR)
Since year is just a String now, toString() could just return year itself. But this is also really minor.
6 (commented on others PR)
Perhaps you could change "person" to "student".
7 (commented on others PR)
I think you can remove these 2 lines aha
8 (commented on others PR)
Should this be ClassVenue.MESSAGE_CONSTRAINTS?
9 (commented on others PR)
Should this be ClassTime.MESSAGE_CONSTRAINTS?
10 (commented on others PR)
Should this be Fee.MESSAGE_CONSTRAINTS?
11 (commented on others PR)
Should this be PaymentDate.MESSAGE_CONSTRAINTS?
12 (commented on others PR)
Why is there a need for this? I believe it was the same way in the Tag implementation in AB3, since when these are put together there is another module with its method to put a space between tags.
13 (commented on others PR)
Will you be adding them withClassVenue/ClassTime/Fee/PaymentDate for Bob?
14 (commented on others PR)
Whoops, I actually meant the space at the back of the closing square bracket.
15 (commented on others PR)
Perhaps you could test for multiple predicates too.
One suggestion would be to create your school/year predicate too and then create a FindStudentDescriptor from it, then have a method in testutils.StudentUtils that converts it into "n/... s/... y/..." form, similar to how it is done in parseCommand_edit(). The outcome would be:
FindCommand.COMMAND_WORD + " " + StudentUtils.getFindCommandDetails()
Additionally, if you are using prefixes, you might want to refer to them by how they are defined in CliSyntax instead of magic literals.
16 (commented on others PR)
Year is actually a String now that accepts alphanumeric characters. Hence I think we should relax the requirements to be one where it returns true if student.getYear().year contains the keyword (e.g. year could be a String and it is matched using StringUtils::containsWordIgnoreCase).
That way, if you search "4" you could get those who put "Sec 4", "sec 4" or "Secondary 4" if the user is inconsistent.
It also means you will be less likely to land an IllegalArgumentException if the user parses an invalid string since right now FindCommandParser currently has to call Year#new to construct this.
17 (commented on others PR)
What is the equals method used for?
18 (commented on others PR)
Making the Lists public final still means you can add keywords to the list at will, you just can't reassign keywords to a new List object. Is that what you mean to do?
19 (commented on others PR)
does this mean that if you search "sec 3" you get all that either match "sec" or match "3"? (e.g. you get sec 1-4 and p3, s3)
20 (commented on others PR)
Yeah I think your current implementation is fine then
21 (commented on others PR)
Would it be more helpful if we made it look only for words that contain all the keywords (even incomplete ones)? (i.e. AND search)
For example it would be like:
String year = student.getYear().year.toLowerCase();
return keywords.stream().map(String::toLowerCase).allMatch(year::contains);
22 (commented on others PR)
Looks good! Perhaps one suggestion would be to call editAdminDescriptor::isAnyFieldEdited so we can just create the new student using student.toEdit().getAdmin().
23 (commented on others PR)
Really damn minor note but you could probably just use Optional.ofNullable(details).map(Collections::unmodifiableSet)
24 (commented on own PR)
Oh ya horh
25 (other comment)
add - Alex/Hogan
edit - Vaishak
find - Ying Gao/Choon Siong
26 (other comment)
After we merge this we should merge v1.2 branch into master already
27 (other comment)
Nabei I test all the methods this bot still say less coverage
28 (other comment)
My concern is that IP, IB, MOE mainstream tracks have different naming in their levels. Furthermore, there could be other level naming, for eg a tutor teaching music or arts may have different levels naming for their students.
I think this is not too bad a problem since our primary target was pri/sec/jc tutors so if we frame our target audience that way we still can meet their requirements
29 (other comment)
Looks like I will have to wait for #72 to be merged before I can pass these test cases
30 (other comment)
See #53
31 (other comment)
Functionality already exists
32 (other comment)
Basically what we've been doing all along
33 (other comment)
Possible improvements for future
JsonAdaptedQuestion is a map>question, boolean> instead of a string
House for each question in a JavaFX VBox
34 (other comment)
Perhaps you could also look into making ClassTime and Student implement Comparable so we can sort students in the filteredList in order of who goes first.
35 (other comment)
Implementation: Give a reminder of students who need rescheduling
36 (other comment)
See #101
37 (other comment)
Are you not gonna include sorting anymore? I think it's alright to have the sortFilteredStudentList method, I was just asking to rename the other methods back to [...]Person[...]
38 (other comment)
My man... Did you forget to stage and commit your activity diagram pngs
@gabztcr (23 comments)1 (commented on others PR)
Maybe change the sections (deliverables, contacts, meetings) to their respective epics, following our meeting docs? E.g. this line of code can be "[EPIC] As a Product Manager, I can track my product’s development so that I can work better towards production deadlines. (Deliverables)"
2 (commented on others PR)
Noticed you left out type of Product Managers in here and elsewhere (e.g. "Product Manager who needs to be aware of changes in description of deliverables"). I believe we can leave these out for now. Just a note.
3 (commented on others PR)
For consistency, can we change to just "mark deliverables as completed"? (I'll update the changes on the docs)
4 (commented on others PR)
Can we change to small caps 'm' for 'Minimise'?
5 (commented on others PR)
In here and elsewhere, should we follow the user stories as closely as the gdoc since it's more or less cross-checked among ourselves? i.e. for this line of code, can it be 'contact the right person if needed'? Alternatively, 'locating the right person easily' would work, since this user story is about editing the POC.
6 (commented on others PR)
Should we take out "(completed deliverables / total deliverables)" since it may lead to confusion? It may be misunderstood as completed deliverables or total deliverables instead of over. Alternatively to explicitly state "completed deliverables out of total deliverables".
7 (commented on others PR)
For consistency, can we have "keep them up-to-date" for the 'so that' portion?
8 (commented on others PR)
Can we have back the 'remember and retrieve important information' under 'so that' portion?
9 (commented on others PR)
Can we capitalise the 'i' in 'keep any data that i want'?
10 (commented on others PR)
Can we have plural 'contacts' instead of 'contact' under 'so that' portion?
11 (commented on others PR)
Did you miss the epic "As an inexperienced or forgetful Product Manager, I can refer to a user guide as I’m using the app so that I am able to use it as intended"? The user stories in this epic are not reflected.
12 (commented on others PR)
Here and elsewhere, noticed the numbering isn't correct, but I believe markdown solves this automatically. Have to check again? Just a note.
13 (commented on others PR)
In here and elsewhere, for consistency, can we ensure all the lines end with periods (.)?
14 (commented on others PR)
Can we ensure the use case IDs are in consecutive order, i.e. this should be UC11 and delete contact should be UC12?
15 (commented on others PR)
Can we change to singular 'Deliverable'? (side note: we may need to redefine this keyword. Personally it sounds slightly vague though I know this definition was taken from online).
16 (commented on others PR)
Should we leave this keyphrase out since I don't think we use it anywhere?
17 (commented on others PR)
Can periods be included for all the epics too?
18 (commented on others PR)
Have seen that the rest have periods now. How about this line too?
19 (commented on others PR)
I believe you added the 'so that' portion wrongly here. It should be for the "view my contacts and their relevant details" user story under EPIC B. Could you help to change that?
20 (commented on others PR)
Could we change this to "view a helpful popup"? Just a small grammar error.
21 (commented on others PR)
I think your suggestion would work for now.
22 (commented on others PR)
Can we fix the typo here? Maybe in the next big commit for UG. Just to note.
23 (commented on others PR)
Maybe a more meaningful description?
24 (commented on own PR)
I made two fields for Deadline class. One a String, and another a LocalDateTime. We can use the latter for comparison, and leave the former as it is for string rendering (y)
25 (commented on own PR)
I just tried and the whitespace doesn't get reflected on markdown. The current implementation should work alright (there's an illusion of whitespace). Thanks for the suggestion 😸 !
26 (other comment)
Will create another PR for this commit.
27 (other comment)
No need to review/merge.
28 (other comment)
Checks failing due to Edit command not available yet.
29 (other comment)
Fixes #3 and #5
30 (other comment)
Change the "/dead" token to "/by" and "/desc" to "/d"
31 (other comment)
Amend to use the correct constructor
@jeffreytjs (22 comments)1 (commented on others PR)
To check with prof regarding the changes to be made to monitor code coverage
2 (commented on others PR)
Minor issue, remember to capitalize Supplier and line 276 and 280 as well.
3 (commented on others PR)
Same issue, minor typo for Supplier
4 (commented on others PR)
Capitalize also
5 (commented on others PR)
Similar to comments left on UniqueWarehouseList, should this be removed instead?
6 (commented on others PR)
Similar to comments left on UniqueWarehouseList, might want to change to replaceSupplier
7 (commented on others PR)
Minor issue, capitalise Suppliers
8 (commented on others PR)
Capitalise Suppliers here
9 (commented on others PR)
Would this mean that 0 is acceptable? Or is isNonZeroUnsignedInteger meant to be a stricter check?
10 (commented on others PR)
Oh I see that it is being used for index and quantity separately in another file.
11 (commented on others PR)
Alright got it!
12 (commented on others PR)
Message should be "Deleted Warehouse: %1$s" instead
13 (commented on others PR)
In the 3rd sentence:
editIn the 4th sentence:
The rest are well described.
14 (commented on others PR)
I cant figure out why this paragraph is bold in the file. (Can click the three dots at the top right then click view file)
Minor issue:
Can make warehouse plural as well in this sentence - "Furthermore, another alternative considered would be to create separate commands for warehouse and suppliers respectively."
15 (commented on others PR)
Will there be a {@code userMacros}? I'm not too sure about how this component of the code.
16 (commented on others PR)
Maybe "Problem encountered while reading..." or "Unable to read from..." would be better here
17 (commented on others PR)
Same as above
18 (commented on others PR)
I think there is missing a word here, should be "original input string when no macro is used"
19 (commented on others PR)
Can remove extra line here
20 (commented on others PR)
Oh {@code UserMacros} exist here, the one on top can include too!
21 (commented on others PR)
Represents 'an' alias
22 (commented on others PR)
Oh alright! 👍
23 (commented on own PR)
Hmmm... Okay I'm including these line breaks,
24 (commented on own PR)
Thanks for pointing it out, I do agree with you and have specified in the next commit!
25 (commented on own PR)
Oh yes good spot, these were written before we finalized the changes in our commands
26 (commented on own PR)
Yea this is outdated now, I have fixed it earlier. No wonder I couldn't find it hahaha
27 (commented on own PR)
Okay as per user guide, we only have Tag for products so yes this should be Remarks!
28 (commented on own PR)
It shouldn't be remarks either, it would look like this now and should be pretty straightforward without explanation. We can improve on it at a later time because UML is still rather unstable.
29 (commented on own PR)
Fixed!
30 (commented on own PR)
I'll update accordingly depending on how we are integrating Macro feature into all other features!
31 (commented on own PR)
I've broke it up to two parts so the warehouse only doesn't cover the front few prefixes.
32 (commented on own PR)
I've put it in tildas as it is a param
33 (commented on own PR)
This makes sense, I've edited it accordingly thanks!
34 (other comment)
Approve for testing purpose to see the badge shows CI fail
35 (other comment)
Test successful, icon changed to failing.
@zhengweii Revert back to pass CI
36 (other comment)
Updated to the following issues:
Issue #86 - As a standard user, I want to add my suppliers’ information and products
Issue #88 - As a standard user, I want to add details of warehouses and stocks for each product
37 (other comment)
Updated to the following issues:
Issue #88 - As a standard user, I want to add details of warehouses and stocks for each product
Issue #94 - As an intermediate user, I want to update the stock of a specific product in warehouses
38 (other comment)
Updated to the following issues:
Issue #91 - As a standard user, I want to delete a supplier/warehouse entry
39 (other comment)
Updated to the following issues:
Issue #93 - As I standard user, I want to view the information of a specific warehouse or supplier
40 (other comment)
Updated to the following issues:
Issue #92 - As a standard user, I can find medical products associated with warehouses or suppliers
41 (other comment)
Updated to the following issues:
Issue #90 - As a standard user, I want to access the command list/user guide
42 (other comment)
Updated to the following issues:
Issue #91 - As a standard user, I want to delete a supplier/warehouse entry
43 (other comment)
Associated to the following issues:
Issue #93 - As a standard user, I want to view the information of a specific warehouse or supplier
44 (other comment)
Updated to the following issues:
Issue #93 - As I standard user, I want to view the information of a specific warehouse or supplier
45 (other comment)
Updated to the following issues:
Issue #96 - Adds product information to a supplier
46 (other comment)
Closing issue as it is meant for week 7 tutorial.
47 (other comment)
LGTM
48 (other comment)
Closing deprecated issue.
49 (other comment)
Closing deprecated issue.
50 (other comment)
Closing deprecated issue.
51 (other comment)
Closing deprecated issue.
52 (other comment)
Issue resolved by Yu Ting in PR #108.
53 (other comment)
Issue resolved by Zheng Wei in PR #107.
54 (other comment)
UML Diagram can be accessed via this link to diagram.net stored on gdrive
55 (other comment)
Issue resolved by me in PR #112 .
56 (other comment)
Issue resolved by me in PR #113 .
57 (other comment)
Good thoughts, I believe handling upper/lower case conversion on our end would improve user experience instead of making it case-sensitive. Especially when they are not able to correct minor typo by retrieving last typed command using the up arrow key like we do in terminals.
You're right, I just tried for add command and it process everything but only keeps the results from the last occurrence. This is a bug and should be resolved unless a command explicitly takes in 2 of the same prefix. Good catch Zhen Lin.
I would think that redundant arguments can be safely ignored if they do not interfere with the given command. We can set up a response that notify them of the random string while letting the command run through. This would be even more useful when we implement undo and redo commands.
58 (other comment)
Snapshot of what the current UI looks like
59 (other comment)
Will be including proper assertions in the next update instead.
60 (other comment)
In my PR I have addressed validation for names, addresses and remarks. Do we want to validate emails as well?
61 (other comment)
AddCommand, EditCommand and UpdateCommand have checks in place to ensure no duplication of entries (by name).
62 (other comment)
This could be similar to saving Macros preference.
It can be an enhancement to allow user to select themes for their app UI that will be added in #131
@khoongwk (22 comments)1 (commented on others PR)
Minor edit listmodules
2 (commented on others PR)
Delete this ">>>>>>> HEAD"?
3 (commented on others PR)
Delete this too
4 (commented on others PR)
Should we add in a case for invalid week specified by the user as an extension to [1]? Like week 123 or week -1. Same thing for UC03 - editing a task.
5 (commented on others PR)
Perhaps we should add an extension for the case when a user inputs a module code that's not in the list? Like what you did for UC07.
6 (commented on others PR)
See #62 from Hans, he included a numbering scheme for the features like 4.1.1, 4.1.2, etc. I think you can edit this section after his PR is merged into master.
7 (commented on others PR)
I think you're missing a quotation mark at the end here.
8 (commented on others PR)
I think we need a additional section below every "Format" to tell the user to reference the command parameters. For example:
ℹ️ | Refer to Section 4.1.1, “Service Management Command Parameters” for more detail about each parameter.
-- | --
9 (commented on others PR)
And replicate this 'success' for the other parts till 4.1.7 😄
10 (commented on others PR)
Can refer to @galvinleow 's PR for this ^.
11 (commented on others PR)
4.1.1 should be on the same level as 4.1.2. Should we reduce the heading level for the commands below from #### to ### to match this?
12 (commented on others PR)
I'm not sure if we can follow the original client find command, because for that command, we don't have to parse the different prefixes. Whereas for findsvc, we need to parse for both title and service code and ensure that only one of them is chosen. Can see @yanlynnnnn 's findexp command to see how she did hers.
13 (commented on others PR)
Should this be renamed to clientManagerOptional?
14 (commented on others PR)
"address book data" should be changed to "client manager data"
15 (commented on others PR)
require appointmentManager to be non-null too
16 (commented on others PR)
This method is for expenses - should "versionedClientManager" be here?
17 (commented on others PR)
"address book" should be renamed to client manager
18 (commented on others PR)
rename address book to client manager
19 (commented on others PR)
Rename address book
20 (commented on others PR)
Rename address book
21 (commented on others PR)
Do we need 2 lines of the same assertion?
22 (commented on others PR)
Lines 57, 63 and 111 as well
23 (commented on own PR)
Resolved!
24 (commented on own PR)
Resolved 😃
25 (commented on own PR)
Yup he did, but I needed to extend it with more methods. I need a contains method with parameter ServiceCode to check if the service code belongs to an existing service. I can't just insert that as a generic method to Unique List, so I created UniqueServiceList to extend UniqueList>Service>.
26 (commented on own PR)
Fixed, thanks!
27 (commented on own PR)
Thanks for the catch!
28 (commented on own PR)
I think I will just remove it. If I log here, there will be a tremendous number of log statements.
29 (commented on own PR)
Okay, will rename. Apparently there are many instances of "Homerce book" throughout the project. I think a "find-and-replace" went wrong in the past.
30 (other comment)
Looks good to merge 😃
31 (other comment)
Resolved Merge Conflict in User Guide. Needs further edits to UG, but let's merge first @yanlynnnnn got issues.
32 (other comment)
Closing this PR as the Remark command feature will not be added for now. If so, this PR may be reopened in the future.
33 (other comment)
Closing this PR as the Remark command feature will not be added for now. If so, this PR may be reopened in the future.
34 (other comment)
Closing this PR as the Remark command feature will not be added for now. If so, this PR may be reopened in the future.
35 (other comment)
Closing this PR as the Remark command feature will not be added for now. If so, this PR may be reopened in the future.
36 (other comment)
Closing this PR as the Remark command feature will not be added for now. If so, this PR may be reopened in the future.
37 (other comment)
Numbering scheme will be relegated to v1.4
38 (other comment)
Also need to standardize the heading level, like ###, ##, etc.
39 (other comment)
Resolved, removed the additional Date class.
40 (other comment)
@galvinleow I think the AddRevenueCommand might not need, can be combined with the DoneAppointmentCommand.
41 (other comment)
To do this, add model.updateFiltered(your category)List(Model.PREDICATE_SHOW_ALL_(your category)) to refresh the edited list.
42 (other comment)
@yanlynnnnn @galvinleow Can refer to my implementation so that yall can apply to revenue and expenses too.
43 (other comment)
Closing this PR, reopening as new PR
44 (other comment)
Since we are pivoting towards combining expense, revenue and profits, we should either close this PR or continue working on combining all together in this branch @galvinleow
@bchenghi (22 comments)1 (commented on others PR)
I think the link for UserGuide should be this one? (https://ay2021s1-cs2103t-f13-4.github.io/tp/UserGuide.html)
The current one brings me to https://github.com/AY2021S1-CS2103T-F13-4/tp/blob/docs/UserGuide.html#quick-start instead.
2 (commented on others PR)
Similar to UserGuide, I think the DG link is this one? (https://ay2021s1-cs2103t-f13-4.github.io/tp/DeveloperGuide.html)
3 (commented on others PR)
Sorry, I think this 'food' is not changed yet.
4 (commented on others PR)
Should we change address book to food inventory here also? Same for line 158, 162, 166.
5 (commented on others PR)
Very minor and we are going to delete address anyway, but do you think this should be address instead of simplykitchen?
6 (commented on others PR)
Should the "Persons" here be "Food Items" instead?
7 (commented on others PR)
Should "persons" here be "food items" instead?
8 (commented on others PR)
Very minor, but should we change "addressBook" parameter to "foodInventory" instead?
9 (commented on others PR)
I think the "bar" in statusbarPlaceHolder should be "Bar" instead? Since it was changed to "Bar" in MainWindow.java.
10 (commented on others PR)
Very minor, but should this be expectedFoodInventory instead? Line 112 and 117 as well?
11 (commented on others PR)
Very minor, but should this be Food Inventory instead?
12 (commented on others PR)
Should SimplyKitchen Inventory be Food Inventory instead? Line 137 as well.
13 (commented on others PR)
Extremely minor, but should "an" be "a"? Also should "persons" be "foods" instead?
14 (commented on others PR)
Very minor, but do you think we should switch back to Label for consistency?
15 (commented on others PR)
Very minor, but should the comment for invalidity be different?
16 (commented on others PR)
I feel that since priority is no longer optional, should we set the priority directly without the Optional here?
17 (commented on others PR)
Should we have a priority missing test here as well?
18 (commented on others PR)
Very minor, but what do you think of "At least one of the optional fields must be provided."? Since INDEX is not optional.
19 (commented on others PR)
Since a single tag can have multiple words, so containsWordIgnoreCase will throw an error if its argument has multiple words?
20 (commented on others PR)
Should this be LogsCenter.getLogger(ExpiryDateSearchPredicate.Class) instead?
21 (commented on others PR)
Very minor, but for consistency, do you think this should be execute_zeroDescriptionKeywords_noFoodFound()?
22 (commented on others PR)
Should we include tags with spaces as well?
23 (commented on own PR)
Okay changed
24 (commented on own PR)
Changed all comments with name to description.
25 (commented on own PR)
I agree, changed them. Thanks!
26 (commented on own PR)
Yeap I agree. Changed them.
27 (commented on own PR)
I agree with you, thank you!
28 (commented on own PR)
Okay changed. Thanks.
29 (commented on own PR)
Changed. Thanks!
30 (commented on own PR)
Okay changed. Thanks!
31 (commented on own PR)
Okay. Thanks!
@MarcusTw (21 comments)1 (commented on others PR)
Perhaps change the name of the class to Session
2 (commented on others PR)
Will we support delete+?
3 (commented on others PR)
Perhaps can change this variable name to tab?
4 (commented on others PR)
Perhaps you can make use of your Enum here?
private static final int CLASS_TAB = Tab.CLASSES.getValue();
5 (commented on others PR)
Perhaps you can add in your public static final int value here.
public enum Tab {
CLASSES(0),
ATTENDANCE(1)
private final int value;
Tab(int value) {
this.value = value;
}
public int getValue() {
this.value;
}
}
Would it be a better design?
6 (commented on others PR)
Perhaps missing a fullstop?
7 (commented on others PR)
Perhaps "Constructs a {@code SessionDate}" ?
8 (commented on others PR)
Perhaps "Standardizes" instead of "Standardize"?
9 (commented on others PR)
Is there a missing space between RunTimeException and "{}"?
10 (commented on others PR)
Awesome!
11 (commented on others PR)
Sure thing!
12 (commented on others PR)
Perhaps we might want to remove "(coming soon)"?
13 (commented on others PR)
Perhaps may want to add in a Javadoc here to make it clearer?
14 (commented on others PR)
Just a query, would returning null be a good idea?
15 (commented on others PR)
Just a query, would returning null be a good idea?
16 (commented on others PR)
Sorry, I meant for getNextIndex method!
17 (commented on others PR)
Sorry, I meant for getNextIndex method!
18 (commented on others PR)
Perhaps missing a JavaDoc here?
19 (commented on others PR)
Perhaps @return Display name of the tab ?
20 (commented on others PR)
Perhaps "If no arguments are found" ?
21 (commented on others PR)
Perhaps "if the argument passed in is an"?
22 (commented on own PR)
Ahhh I see, thanks!
23 (commented on own PR)
Yes there should be. Missed it out.
24 (commented on own PR)
This was left with the intention of easy deleting if there comes an error.
25 (commented on own PR)
Ahh I see. Thanks!
26 (commented on own PR)
Thank you for the comment, I have resolved it!
27 (commented on own PR)
Thank you for the comment, I have resolved it!
28 (commented on own PR)
Thank you for the comment, I have resolved it!
29 (commented on own PR)
Thank you, I've missed it out!
30 (commented on own PR)
Thank you for pointing it out!
31 (other comment)
Changed according to comments
32 (other comment)
28/9/2020 - still lacking test cases.
33 (other comment)
Minor error in checkstyle after resolving merge conflict, resolved in PR #90
34 (other comment)
Went ahead with Sheng Yang's version in PR #64 .
35 (other comment)
Complete under PR #117
@keanecjy (21 comments)1 (commented on others PR)
And @seanjyjy I think you are missing this statement header.
InternHunter allows the management of three data types:
2 (commented on others PR)
I don't think there should be a guarantee here that the system stops running since extension at 2a implies that use case ends when user decides to cancel the confirmation
3 (commented on others PR)
I think ProfileItem here would suffice instead of the import
4 (commented on others PR)
@seanjyjy @orzymandias @ZoroarkDarkrai @shawn-nyk
I think this is a good topic for discussion. Currently, AB3 only uses the weaker notion of equality, isSameItem for the edit command. The add command on the other hand checks based on the equals method. Do we want to change it such that it uses the same notion of equality as well?
5 (commented on others PR)
I don't see the need for this class as it is the same as the Name class, we could just pass in the messageConstraints to signify a different error message if need to.
6 (commented on others PR)
Perhaps an accidental double lines here?
7 (commented on others PR)
Yes, we would need to pass in the messageConstraints variable to the parent Name class. Yes I think the code is good enough to merge!
8 (commented on others PR)
I was thinking for descriptors - equivalent of the skills in internship should just be a non-empty string! Because I don't think there are any wrong formats that we should disallow them from inputting?
9 (commented on others PR)
I think it would be better to put in C# instead of C sharp? Since its easier to put in. Not sure about the char limit though, since some companies may have very long names?
10 (commented on others PR)
Perhaps we can include a check for when the user is already currently viewing this current item and display a MESSAGE_ALREADY_VIEWING message?
11 (commented on others PR)
I think that it might be better if we initialize the variables in the if-else block, so that it is clearer which block will have what booleans. And also this will stick to the notion of defining the variables in the least possible scope!
12 (commented on others PR)
I think the current code is better. Also, why is there checks for tabName in this command? Since all the other commands automatically switches to the correct tab, even if it is already on the right tab
13 (commented on others PR)
Oh what I meant was initializing the value in the if-else block and not declaring it there. So an example of this is:
14 (commented on others PR)
Oh okay thanks for the clarification!
15 (commented on others PR)
Don't think so, since he did mention that this is just a guide and I remembered there was an example which he said would be ok?
16 (commented on others PR)
I think requireAllNonNull would be better here
17 (commented on others PR)
Same here, I think requireAllNonNull would be better
18 (commented on others PR)
I think this command should be shifted to the GeneralParserUtil class, since it is being used in many of the command parsers
19 (commented on others PR)
If you are putting the message into the checkCommandDetails already, we can just throw the exception with the correct message? There's no need to do the switch case inside that method anymore.
20 (commented on others PR)
In reference to my earlier post, what is the point of the switch statement if all of them are fallthroughs?
21 (commented on others PR)
Since many of our commands require the parseIndex to throw a specific message, we could pass in the specific error message in the parseIndex function. And to fix this issue you pointed out, perhaps we could create individual parsers for each of the commands, so that they can throw their own specific error message.
22 (commented on own PR)
The job list in the company has the name of the job, so I don't think this will be an issue.
23 (commented on own PR)
Good catch, updated it already. Thanks
24 (commented on own PR)
Yes, I did thought of this while I was writing the code for this Job class. Yes, I think that we may need need a Job object and it can be represented as a String instead. Will edit the code accordingly. Great catch on this!
25 (commented on own PR)
Yes haha, I had a good laugh earlier when I represented wage as a Phone object. Reason I did so was to use AB3's current implementation of the Name object (which is basically a class with a string containing only AlphaNumeric characters) and Phone object (which is essentially a class with a string containing only Numeric characters). I think that we can rename it in the near future and make use of them in all our classes. What do you think?
26 (commented on own PR)
Yup, I think its best if we could ensure that the "Job" and "Internship" names are not used loosely throughout the code base. I don't particularly like the idea of a nested class, since I do intend to use the enum outside of this Status class (for parsing and input). Also, would it better to rename the Status class as ApplicationStatus and the enum to be called Status instead?
27 (commented on own PR)
Kind of, the date will be used on the main display as well as on the right pane:
28 (commented on own PR)
@ZoroarkDarkrai @orzymandias @seanjyjy What is the team's opinion on this?
29 (commented on own PR)
@seanjyjy @ZoroarkDarkrai @orzymandias Does anyone have any good suggestions? I'm leaning onto Status composing ApplicationStatus and Date atm.
30 (commented on own PR)
Thanks for the input. I created a Status class to abstract out the application status and date details from the internship. But perhaps now that I think about it simply renaming the fields to InternshipStatus and StatusDate would do. Let me know if this arrangement is fine.
31 (commented on own PR)
Yes, thanks for pointing out this error
32 (commented on own PR)
Yup made the change
33 (commented on own PR)
Yes, thanks for noticing.
34 (commented on own PR)
Okay, updated for consistency
35 (commented on own PR)
Yes, I agree that tabs actually make more sense in this context. Will update for all use cases
36 (commented on own PR)
Right now we are only allowing one application for an internship. So perhaps your suggestion may be quite misleading too.
I have updated to:
The application (if any) made with this internship will also be deleted.
Hopefully its clearer this way!
37 (commented on own PR)
Right now it is safe, since i think only @seanjyjy and I are using it. Thanks for the catch though, I will add an assertion there in case someone else happens to use it on a string with length >=1
38 (commented on own PR)
Yes will update
39 (commented on own PR)
Yes, I agree with @seanjyjy on this. Since this is something within the programmer's control.
40 (commented on own PR)
deepDelete uses the isSameItem method defined in the abstract Item class, which compares 2 items based on the weaker notion of equality, which I defined it to be comparing only the internship item. Hence why I created the deepDelete method! I will change the method name to deleteSameItem, hopefully its clearer that way.
41 (commented on own PR)
Edited the names of the classes and methods and javadocs for increased clarity, do help to check before merging!
42 (commented on own PR)
Not sure what is the group's consensus on this, so I took the easier path first which is to switch tabs after successful command. Could it be because the command is executed unsuccessfully? Because this should be correct since I took this from @seanjyjy switch tab command.
43 (commented on own PR)
I think we could just set the default value for isSwitchTab in the constructor to be true then?
44 (commented on own PR)
Good catch, missed this completely
45 (commented on own PR)
I think it really depends on what context is it being used in. There seems to be an almost equal amount of Creates and Constructs used in our code atm.
46 (commented on own PR)
Yup, fixed in my latest merge.
47 (commented on own PR)
Fixed
48 (commented on own PR)
Fixed in my latest commit.
49 (commented on own PR)
Did you misread?
Quoting the textbook:
Cohesion is a measure of how strongly-related and focused the various responsibilities of a component are.
50 (commented on own PR)
There's no coupling word used here?
51 (commented on own PR)
It can be, if there is a subclass of this class with a public constructor. But anyway I'm changing the code structure so will remove this file.
52 (commented on own PR)
Yes. Will update.
53 (commented on own PR)
Right, think i forgot to remove the whitespaces
54 (commented on own PR)
Good idea. Will update.
55 (other comment)
LGTM
56 (other comment)
Yup I think that there isn't a need to concern about javadocs / comments as of now as they can be easily fixed at any point in time. @orzymandias I stopped editing the List portions as I noticed that there were too much code duplication with your pr. Do we plan to either extend an Item class or use generics for our list?
57 (other comment)
ecessary duplication for collections, generics is a good idea for collections but one issue is with throwing custom exceptions for different types of items within the generic list. Should we just have DuplicateItemException then something like
throw new DuplicateItemException(T.getDuplicateExceptionMsg())?
I don't think this works because we are not able to access methods in java generics. I figured since we all are classifying our classes as Item, we can have an Item interface to contain all the methods similar methods like isSameItem and likewise do throw new DuplicateItemException(item.getItemName())?
58 (other comment)
Sure, I think this is a solid idea.
59 (other comment)
I think it's okay just I find many hard coded strings can be converted to const. If urgent can merge now and fix later?
Is it not normal to use hard-coded strings for test cases? Could you point on where exactly is the issue? Thanks
60 (other comment)
I think it's okay just I find many hard coded strings can be converted to const. If urgent can merge now and fix later?
Is it not normal to use hard-coded strings for test cases? Could you point on where exactly is the issue? Thanks
I mean the toString, equality, hashcode tests. Could use VALID_WAGE, VALID_PERIOD, etc? If it's a better practice to use "Sunday", "React Native", etc. it's fine then.
Not too sure what's the correct which is the correct way, but I just thought that doing it this way by writing 2 strings that are different objects would be better since we will be comparing periods with different strings in the actual implementation too
61 (other comment)
I don't think you should be writing tests for ApplicationItem, Status, and StatusDate? Since we should be writing tests for our own classes and not helping others write their tests
62 (other comment)
I don't think you should be writing tests for ApplicationItem, Status, and StatusDate? Since we should be writing tests for our own classes and not helping others write their tests
Oh, I think I misunderstood then. When I said I couldn't do the storage ones then because lack of sample data, I think someone said I should do the application ones. So, do you want me to remove them?
Oh what I meant was create sample data for the storage tests and not to test the application classes themselves. So the rest of the files can stay except for ApplicationItemTest, StatusTest and StatusDateTest. Hope this clarifies!
63 (other comment)
LGTM.
64 (other comment)
Generalize commands to use XCommand and YCommand instead
65 (other comment)
LGTM!, just a question why the difference between application and internship tests?
Oh, this is because the internship are shown on the right panel, so it requires a double indexing to delete them.
@raysonkoh (20 comments)1 (commented on others PR)
If the user meets a new business client then it would be someone that he doesn't know previously? This statement might be redundant if that is the case.
2 (commented on others PR)
LGTM
3 (commented on others PR)
Should setWidgetContent be in Model? Seems like this is mixing UI-related stuff with model-related stuff.
4 (commented on others PR)
Since Client has a hasClientNote and addClientNote method, then you can bypass Model and just call clientToAddNoteTo.adClientNote(clientNote)?
5 (commented on others PR)
Might be a next TODO which is to abstract away this parsing logic.
6 (commented on others PR)
I think you can remove this TODO.
7 (commented on others PR)
remove this TODO also
8 (commented on others PR)
Can delete this line if not needed haha
9 (commented on others PR)
Do you mean "Similar to suggestion by/contract" ?
10 (commented on others PR)
Possible typo. Should Collection>String> tags be Collection>String> suggestionTypes instead? Similar for the Set>Tag>.
11 (commented on others PR)
Just a suggestion, should SuggestionType be an Enum instead? Since it is only taking frequency, available and contract as valid inputs.
12 (commented on others PR)
Might want to consider extracting "untagged" into a constant variable.
13 (commented on others PR)
Ideally, yes. Might need to update some of the tests
14 (commented on others PR)
Extra newline here
15 (commented on others PR)
I'm not sure what you mean. Can you give an example of this?
16 (commented on others PR)
This call still needed?
17 (commented on others PR)
I think the formatting seems a little weird here
18 (commented on others PR)
Might make the code more readable if it is something like getTextThree(), getDiv4() etc
19 (commented on others PR)
Might want to extract out magic numbers as constants so smth like TEXT_THREE_POS = 5, DIV_THREE_POS = 6
20 (commented on others PR)
Agree that scrollbar should be shown, depending on how complex the implementation is I think it can be created as a separate issue.
21 (commented on own PR)
Okay I have made the changes, can you guys check again?
22 (commented on own PR)
actually all those variables aren't constants in the sense that for each instance of Country the countryName, etc can be different. Not sure if they are still considered constants?
Edit: checkstyle throwing an error when I made a change.
Agree with using HashSet to avoid duplicate Note.
23 (commented on own PR)
Yup good catch
24 (commented on own PR)
I'm not quite sure what you mean. If the user enters a valid country code, then just create a new Country object on demand?
25 (commented on own PR)
Yea that was the intention to just init countryNotes from the start so there wouldn't be any bugs if someone using Country forgot to check if countryNotes exists. If there is a noticeable lag then probably can optimise in v1.3.
Save file can just store countries which actually have countryNotes in them, so no need to store all countries.
26 (commented on own PR)
Ok changed
27 (commented on own PR)
Must be my formatter oops
28 (commented on own PR)
Will be done in a separate issue.
29 (commented on own PR)
Ok added
30 (commented on own PR)
Added for both
31 (commented on own PR)
Ok I have removed the check
32 (commented on own PR)
Added
33 (commented on own PR)
Hmm strange that checkstyle didn't throw a warning. Added.
34 (commented on own PR)
Added
35 (commented on own PR)
Added this as follow-up issue.
36 (commented on own PR)
Added
37 (commented on own PR)
I think this should be done by @rtshkmr since he is going to implement Note fully.
38 (commented on own PR)
I checked and its still 4 spaces lol
39 (commented on own PR)
Yep
40 (commented on own PR)
For this, I leave it up to how @rtshkmr wants to implement this. I just needed a basic Note object for testing only.
41 (commented on own PR)
Changed.
42 (commented on own PR)
My idea is that whenever you are interacting with the existing Country instances (other than just getting country notes), you should only do it via CountryManager. I think this layer of abstraction is good especially for logging/debugging in the future since Model only needs to operate on CountryManager and I would be able to log all Country method calls.
For classes like the CountryNoteParser or CountryFilterParser they should not be holding references to the existing Country as they do not have a reference to CountryManager. Only Model has a reference to CountryManager. So when a Command executes on a Model, then they are able to check for duplicate notes, etc.
Also, Country has a hasCountryNote method, but I purposely made it protected so that only CountryManager can call that method. Other classes should only be able to call the constructor and getCountryNote method of Country only.
43 (commented on own PR)
Updated
44 (commented on own PR)
Updated
45 (commented on own PR)
Added
46 (commented on own PR)
Ok sure
47 (commented on own PR)
Done
48 (commented on own PR)
Done
49 (commented on own PR)
Ok done
50 (commented on own PR)
Done
51 (commented on own PR)
I think this cannot because the expectedFilteredClientList is going to be different based on country code
52 (commented on own PR)
Done
53 (commented on own PR)
Done
54 (commented on own PR)
Ok done
55 (commented on own PR)
If I pass in a regular Timezone I can't guarentee what getCurrHourInTimezone returns as the time is always changing. That's why I created TimezoneStub so that I can hardcode return value for getCurrHourInTimezone for testing my predicate
56 (commented on own PR)
good idea!
57 (commented on own PR)
Done
58 (commented on own PR)
Done
59 (commented on own PR)
Done
60 (commented on own PR)
Done
61 (commented on own PR)
Done
62 (commented on own PR)
yes, removed
63 (commented on own PR)
ok I removed it to standardise with other methods
64 (commented on own PR)
done
65 (commented on own PR)
Done
66 (commented on own PR)
yea seems neater. Done
67 (commented on own PR)
Created new class CountryCodeVerifier that is responsible for verifying country code
68 (commented on own PR)
Yea country shouldnt be invalid
69 (commented on own PR)
Done
70 (commented on own PR)
Done
71 (other comment)
Okay, I have updated the issue description.
72 (other comment)
have to merge this before merging #121
73 (other comment)
Fixed by #121
74 (other comment)
Current plan of action after discussion with @rtshkmr. This is a sample of how notes are going to be stored in JSON.
notes: [{
contents: "some contents",
tags: ["tag1", tag2"],
client: "katya", // means this is client note
country: null
}, {
contents: "some contents2",
tags: ["tag1", tag2"],
client: null,
country: "SG" // means this is country note
}]
Benefits of this implementation would be:
That there would only be 1 class that deals with json notes (irrespective of whether it is a client or a country note).
Existing JSON client class does not need to be changed.
Possible issues:
clients by their name at the moment.
75 (other comment)
Putting it here in case I forget in the future:
Some major changes to be made:
Create new class CountryNote that inherits from Note. It stores the Country.
Add isClientNote method in Note to differentiate client and country notes. This probably need to be refactored. Possible idea would be to have abstract Note class, and have ClientNote and CountryNote inherit from it. There can be an enum NoteType that indicates which type the Note object is.
Having CountryNote extends from Note allows use of polymorphic List>? extends Note> when converting to json objects.
@AaronnSeah (20 comments)1 (commented on others PR)
I think the check is failing as there is no new line at the end?
2 (commented on others PR)
I think that clears the GUI might not be clear enough as the the contact list is also a GUI. You could consider chatbot GUI or something that it is clearer?
3 (commented on others PR)
or clear the chat messages in the chatbot GUI
4 (commented on others PR)
I think https://github.com/se-edu/StonksBook-level3/tree/master/src/main/java/seedu/address/MainApp.java
should be changed to
https://github.com/AY2021S1-CS2103T-T11-1/tp/blob/master/src/main/java/seedu/address/MainApp.java
5 (commented on others PR)
the lack of new line before the image is intentional. Will it mess with the width attribute?
6 (commented on others PR)
the lack of new line before the image is intentional. Will it mess with the width attribute?
7 (commented on others PR)
no problem! just checking 👍
8 (commented on others PR)
I think setting sample sales and remark for more than half the contacts would be good, especially for sales list
9 (commented on others PR)
I think this will get very costly. Is there an alternative way to do this? like a static counter?
10 (commented on others PR)
I think the naming is quite confusing for the command archive remove.Would naming personToArchive to archivedPerson and archivedPerson be named to newUnarchivedPerson or something be clearer?
11 (commented on others PR)
Could you remove the unused import?
12 (commented on others PR)
unused import here too
13 (commented on others PR)
this is a feature, to have the contact list sorted by default. is there a reason it is removed?
14 (commented on others PR)
I think naming contact archive to archive add or archive would be better than separating an archive functionality into two different naming conventions
15 (commented on others PR)
how about creating a static method doing this, then do private static final counter = methodcall()? then you call once every time you boot up instead of every insertion?
16 (commented on others PR)
I think min yih's PR of list all sales has done this part
17 (commented on others PR)
the example usage is not updated?
18 (commented on others PR)
You could consider renaming to latestContactId? I think the name can be clearer about the intention of this variable.
19 (commented on others PR)
you might want to consider only adding the text if its not blank?
20 (commented on others PR)
will unit tests be added in future PR?
21 (commented on own PR)
oh thanks for the catch!
22 (commented on own PR)
Thanks for the suggestion, I will add them now!
23 (commented on own PR)
I will be creating PRs to update this file before every end of milestone!
24 (commented on own PR)
We can actually add a meeting for year 0001, we can sync up in v1.4 instead?
25 (commented on own PR)
@hakujitsu file renamed to AllListCommand for both show all and for specified contact.
changes are that it extends from abstract class ListCommand which stores some static variables and a common method (formatting sale list) that was abstracted from your previous class so that both our classes can use it.
On top of that, message strings are set as static variables to be consistent with other command design. Do you let me know what you think!
26 (commented on own PR)
@hakujitsu parser logic has changed abit to adapt to my sale list subclass as well
27 (other comment)
Completed
28 (other comment)
Completed
29 (other comment)
Completed
30 (other comment)
will merge this last after all pull from master
31 (other comment)
if possible, we merge first then fix all the code style after all the merges in a separate PR
32 (other comment)
Could you rename it to be more specific to meetings/ reminders? cause title seems general
33 (other comment)
Added @hakujitsu as reviewer as some of her code has been modified as discussed
34 (other comment)
I will work on this tomorrow
@claraadora (20 comments)1 (commented on others PR)
Are we going to pass Logic object (only) in the UiManager for later iterations?
So that UI is only directly associated with Logic object, and Logic object will decide which Logics (LogicMode, LogicPerson, LogicMeeting, or LogicDeliverable) to call.
(If yes, can we add a TODO comment? e.g. /**TODO: Pass only Logic object**/
2 (commented on others PR)
Maybe we can add a TODO keyword in the comment so it's easier for us to locate in the future
i.e. // TODO take this out of Person
3 (commented on others PR)
As mentioned above, we can discuss this soon 😄 But, I think we don't need to make any changes for this iteration 👍
For a reminder, maybe we can add a TODO comment too here?
4 (commented on others PR)
Subject to the discussion above 😄
5 (commented on others PR)
I think we can move this to the common directory? What do u think? 😄
6 (commented on others PR)
As mentioned above, we should discuss this 👍
7 (commented on others PR)
I will update the fields today so that we can use and uncomment these soon 👍
8 (commented on others PR)
I think it would be great if we can use a more descriptive constant name to indicate an invalid index e.g. MESSAGE_MEETING_INDEX_INVALID
9 (commented on others PR)
I'm not sure but does the condition handle negative values or characters too?
10 (commented on others PR)
Maybe update this to Meeting and Title?
11 (commented on others PR)
Likewise for this
12 (commented on others PR)
I think this should be From not To
13 (commented on others PR)
Very minor, but maybe can use 'specifically' or 'different modes: dashboard, deliverable,...'
14 (commented on others PR)
LogicModeManager
15 (commented on others PR)
Maybe can be assertive and say "Aligns with / Follows the Single Responsibility Principle better"
16 (commented on others PR)
Not sure, but LogicManagers ?
17 (commented on others PR)
Maybe can use a more descriptive name than 's'?
18 (commented on others PR)
Not sure, but is mode the same as result?
19 (commented on others PR)
Not sure, but may be clearer to useDeliverable, Meeting, Contact?
20 (commented on others PR)
How view executes
21 (commented on own PR)
Yes, it was. Meeting B's From value is 'earlier' than A's. Since we are comparing the result of deleting a meeting from a model that is auto sorted with getTypicalMeeting().get(INDEX_FIRST_PERSON.getZeroBased()), the ArrayList retrieved from getTypicalMeeting() should be sorted too.
22 (commented on own PR)
Ahh, I see. Good point
23 (commented on own PR)
Ohh, but on second thought, isValidFromAndTo() is executed inside new Meeting() already. I think it would be redundant to execute twice, at least for our current implementation? What do you think? @chrystalquek
24 (commented on own PR)
createEditedMeeting() throws IllegalArgumentException when it creates an invalid Meeting object through Meeting's constructor. @chrystalquek
25 (commented on own PR)
requireNonNull
Are you referring to the assertion? i.e. requireNonNull(meetingToEdit)
26 (commented on own PR)
probably an exception? since its invalid user input not problems with our code
try {
editedMeeting = createEditedMeeting(meetingToEdit, editMeetingDescriptor);
} catch (IllegalArgumentException e) {
throw new CommandException(e.getMessage());
}
assert Meeting.isValidFromAndTo(editedMeeting.getFrom(), editedMeeting.getTo())
: "From should be earlier than To";
If you are referring to the assertion, it is to make sure that after the try-and-catch block, editedMeeting is a valid Meeting. If it's invalid, the catch block throw an Exception.
27 (other comment)
Closes: #77
@leeweiminsg (20 comments)1 (commented on others PR)
Should be INDEX_FIRST_PERSON instead: it's testing the original AB3 edit command
2 (commented on others PR)
Already present in exercise package
3 (commented on others PR)
Already present in exercise package
4 (commented on others PR)
Unused
5 (commented on others PR)
Should be INDEX_X_PERSON instead of INDEX_X_EXERCISE, because context is AB3
6 (commented on others PR)
Should be INDEX_X_PERSON instead of INDEX_X_EXERCISE, because context is AB3
7 (commented on others PR)
Present in exercise
8 (commented on others PR)
Present in exercise
9 (commented on others PR)
Present in exercise
10 (commented on others PR)
Present in exercise
11 (commented on others PR)
Present in exercise
12 (commented on others PR)
Present in exercise
13 (commented on others PR)
should be exercise book
14 (commented on others PR)
Should be exerciseCard
15 (commented on others PR)
Should be ExerciseListPanel instead of PersonListPanel
16 (commented on others PR)
should be exerciseListPanelPlaceholder
17 (commented on others PR)
I think we can work on these now - see issue #37
18 (commented on others PR)
Maybe another name?
Eg. ExerciseStorageClassDiagram
19 (commented on others PR)
should be model.exercise.Name
20 (commented on others PR)
Better to use variables instead of hardcoding
Eg. from AB3:
assertParseFailure(parser, "1 some random string", MESSAGE_INVALID_FORMAT);
21 (other comment)
Hi Prof Damith, it has been updated. Please let us know if there are any further issues.
22 (other comment)
Tested locally, all test cases pass
23 (other comment)
Tested locally, all test cases pass
24 (other comment)
Merge conflicts to resolve
25 (other comment)
Merge conflicts
26 (other comment)
All test cases passed (on local)
27 (other comment)
Great job
28 (other comment)
Great job
29 (other comment)
Works
@xz0127 (20 comments)1 (commented on others PR)
Standardise the period at the end of phrases
2 (commented on others PR)
Should this System section be removed since we have specified the system at line 265?
3 (commented on others PR)
Would appointment be better in line 321?
4 (commented on others PR)
If the default duration is 1 hour, should "hour" instead of "hours" be used?
5 (commented on others PR)
I agree with Jinhao! 🥇
6 (commented on others PR)
I think Jinhao is making a good point here. Personally i feel a Patient might be necessary for an appointment instance. Would it be better if we include a patient here besides the dateTimeLoader?
7 (commented on others PR)
I have included this part in my recent PR
8 (commented on others PR)
Would it be clearer to change the variable name td to something more concrete, maybe todayDate?
9 (commented on others PR)
Would it be better to change the done appointments to appointments done? appointment done might sound smoother in terms of grammar? Let me know what do you think. 👍
10 (commented on others PR)
Might consider changing a into an.
11 (commented on others PR)
Same as the comment mentioned above.
12 (commented on others PR)
It is not a big issue but personally I feel the naming of the attributes can be clearer? Let me know what do you think. 👍
13 (commented on others PR)
Would singular form book be better?
14 (commented on others PR)
Would it be better if the variable name adj is changed into something clearer?
15 (commented on others PR)
Would it be better to rename the variable b to make it clearer?
16 (commented on others PR)
Should the link here be changed?
17 (commented on others PR)
Should the links on these 2 lines be changed accordingly?
18 (commented on others PR)
Should the Person on these two lines be refactored into Patients? Person is not wrong in this case. What do you think?
19 (commented on others PR)
Should it be UniqueAppointmentList instead of UniqueAppointmentBook?
20 (commented on others PR)
Would it be better if you add `` to AssignCommand?
21 (commented on own PR)
Makes sense, I will make the change. Thanks! 👍
22 (commented on own PR)
Ok, will make the change! Thanks! 👍
23 (commented on own PR)
Oh right i missed that part. Thanks for pointing out! 👍
24 (commented on own PR)
Thank you for pointing this out! 👍
25 (commented on own PR)
Thanks for point this out! 👍
26 (commented on own PR)
Thanks for pointing this out! 👍
27 (commented on own PR)
I agree with Jinhao. I think !targer.isOverlapping allows the appointment to be replaced without throwing OverlappingAppoinmentException, and the second condition is to check no other overlapping appointments exist in the appointment book.
28 (commented on own PR)
Actually for simplicity, we can also consider this: call
removeon target, then calladdoneditedAppointment. If it throwsOverlappingAppointmentException, then weaddbacktarget
We should still throw a new exception when we add back the target right?
@lll-jy (19 comments)1 (commented on others PR)
Did you see TCQian.md?
2 (commented on others PR)
May need to align capitalization?
3 (commented on others PR)
Would it be better to put INDEX1 and INDEX2 as code (i.e. in ``)
4 (commented on others PR)
May quote INDEX as code
5 (commented on others PR)
May quote 'list' as code?
6 (commented on others PR)
deadline number may be changed? e.g. deadline datetime
7 (commented on others PR)
Similar as above
8 (commented on others PR)
This may need to be changed?
9 (commented on others PR)
I can see that all your code works. But would it be easier if we use java LocalDate and LocalDateTime to deal with it? And it may be easier for us in the future work if we want to filter projects by deadline.
10 (commented on others PR)
All the examples may need to updated according to the validation regex.
11 (commented on others PR)
This file may need to be changed (for deadline regex)
12 (commented on others PR)
I think we'd better keep the format aligned, say use DEADLINE_DESC_AMY as the name. And we can change AMY to project names together for future refactoring work.
13 (commented on others PR)
Same as the above comments about naming
14 (commented on others PR)
Same as above comments about naming.
15 (commented on others PR)
This is an email address rather than a repo address right?
16 (commented on others PR)
Will this work well with the task filter command?
17 (commented on others PR)
May you revert this line first? Because some of other code that I wrote is dependent on the filtered project list, and deleting this line may cause some bugs at this stage. I will probably deal with the problem later and delete this line together.
18 (commented on others PR)
The work of Tian Fang this week.
19 (commented on others PR)
I think one leave command would be enough. But we can keep this for now.
@pangpuncake (19 comments)1 (commented on others PR)
The rationale we discussed was for it to be quicker to type for fast typers!
2 (commented on others PR)
Perhaps using bookmark.isEmpty() could replace bookmark.equals(Optional.empty())
3 (commented on others PR)
Perhaps using the format provided in the User Guide e.g. add n/BOOK_TITLE tp/TOTAL_PAGES b/PAGE_NUMBER would be more consistent?
4 (commented on others PR)
Did you mean storage instead of Algo?
UI, Logic, Model and Storage components,
Referring to the next 2 lines, only the UI, Logic, Model, and Storage have a {Component Name}Manager class
5 (commented on others PR)
* does not depend on any of the other four components.
6 (commented on others PR)
Perhaps you could explain what is distance referring to? As someone new to the project might not understand this term.
7 (commented on others PR)
Referring to line 112 to the >div markdown... could you update the Person to Book?
For some reason GitHub prevents me from choosing the line to comment.
8 (commented on others PR)
Referring to the [Proposed] Undo/redo feature on line 310, perhaps you can update the classes used in the entire feature. Thanks!
9 (commented on others PR)
An additional benefit to Le Yang's suggested implementation is that currently it seems that users can create a Goal with wrongly formatted deadline or page which would lead to problems when calling parseDeadline() or getPage(), as a validity check is not done before creation.
10 (commented on others PR)
Perhaps a test for the constructor with null and invalid values would make for more comprehensive testing
11 (commented on others PR)
Perhaps the word filter could be removed as it might be misleading?
Sort books according to the condition inputted.
12 (commented on others PR)
Is writing theBOOK_TITLE required? Referring, to the examples, it seems like it is not.
Format: `sort [n/] [g/] [b/]`
I'm not sure if you can write multiple conditions such as sort n/ g/, if this is not intended, perhaps we can discuss how we can represent it in a certain format as the one I suggested implies you can write multiple conditions.
13 (commented on others PR)
Not sure if + "NAME etc should be present here
14 (commented on others PR)
Is this to prevent extra arguments after the prefix e.g. sort n/Harry Potter? Might not be necessary if we are just interested in the prefix only as inputPrefix would already be set.
15 (commented on others PR)
Maybe this could be modified to be percentage of book read? As different books may have varying pages, e.g. a 500 page book vs a 100 page book and might be more useful to sort based on completion rate. Just an idea.
16 (commented on others PR)
Perhaps the test cases could follow the format whatIsBeingTested_descriptionOfTestInputs_expectedOutcome for consistency with the recommended convention
For e.g. execute_sortByName_success() for this method.
17 (commented on others PR)
The reason for design choice was not clear to me at first. Perhaps you could provide an example with reference to step 7 explaining how redoing State 4 would result in the book deleted in State 5 to come back again. Providing a bigger picture, if 10 new states were created, it would not make sense to lose all the 10 new states to bring back the old state and hence the reason for this design choice.
18 (commented on others PR)
Apt choice of data structure!
19 (commented on others PR)
Not sure if you want to delete this
20 (commented on own PR)
Okay have made the relevant changes to edit
21 (commented on own PR)
That is a good point! I did not notice the Bookmark constructor
22 (commented on own PR)
Thank you for pointing that out!
23 (commented on own PR)
Thank you for pointing it out!
24 (commented on own PR)
Yes I have updated the new PR to reflect this change, thank you!
25 (commented on own PR)
I have added a line at the start of the method to let the user know that DESC_1984 AND JANE_EYRE are two different books with different properties!
26 (commented on own PR)
I will add that in thank you!
27 (commented on own PR)
Indeed there should not be a need to check. I have removed it in the updated commit!
28 (commented on own PR)
I was thinking of that too! I have implemented a regex to handle these constraints. Symbols are now supported, and title has to be within 1 to 120 characters, text has to be within 1 to 1000 characters.
29 (other comment)
Closed by PR #85
30 (other comment)
A Note now can support alphanumeric characters and symbols in the title and text. Title is confined to 1 to 120 characters while the text is confined to 1 to 1000 characters.
UI still does not reflect the notes yet.
Java Docs have been fixed to show the correct explanations.
Test cases have been updated to effect these constraint changes.
@zhaojj2209 (19 comments)1 (commented on others PR)
Collection<String> categorySet = categories.size() == 1 && categories.contains("")
2 (commented on others PR)
return Optional.of(ParserUtil.parseCategories(categorySet));
3 (commented on others PR)
* Represents a Transaction's date in the address book.
4 (commented on others PR)
The argument name here should be changed from email to date. The JavaDoc should also be changed accordingly.
5 (commented on others PR)
* Returns if a given string is a valid date.
6 (commented on others PR)
In line 53, "personListPanelPlaceholder" should be changed to "transactionListPanelPlaceholder".
7 (commented on others PR)
This testcase can be deleted.
8 (commented on others PR)
// Keywords match amount and date, but does not match name
Not sure if this testcase will still be used in the future, but we can change the description first.
9 (commented on others PR)
* @return The result of the command execution.
10 (commented on others PR)
* @return The currently selected tab.
11 (commented on others PR)
* @param currentTab The currently selected tab.
12 (commented on others PR)
Currently, inputting tab 5 will return the same error message as other invalid formats instead of MESSAGE_TAB_DOES_NOT_EXIST.
13 (commented on others PR)
+ "based on the current tab.\n"
14 (commented on others PR)
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a transaction to the finance tracker "
15 (commented on others PR)
For lines 43 and 44, more suitable values should be used, e.g. 5 and 13/10/2020
16 (commented on others PR)
Should we add a comment to the other test json files for consistency?
17 (commented on others PR)
Should the transactions here be consistent with the transactions returned from calling getTypicalFinanceTracker()? Currently, typicalTransactionsFinanceTracker.json contains more transactions.
18 (commented on others PR)
Thanks for the clarification!
19 (commented on others PR)
On second thoughts, there isn't really a need for them to be the same, so this comment can be ignored.
20 (commented on own PR)
The example usage in the original AB3 was already erroneous, so I will be removing this example usage.
21 (other comment)
With the merging of #106, the feature has been implemented.
22 (other comment)
With #66, the feature has been implemented.
23 (other comment)
With #93, the feature has been implemented.
24 (other comment)
With #106, the feature has been implemented.
25 (other comment)
With #93, the feature has been implemented.
26 (other comment)
With #94, the feature has been implemented.
27 (other comment)
Resolved via #85.
28 (other comment)
Resolved via #101.
29 (other comment)
With #100, the feature has been implemented.
30 (other comment)
With #100, the feature has been implemented.
31 (other comment)
With #107, the feature has been implemented.
32 (other comment)
With #107, the feature has been implemented.
33 (other comment)
Closed by #147 and #148.
34 (other comment)
Closed by #148.
35 (other comment)
Closed by #150.
@andreatanky (19 comments)1 (commented on others PR)
address should be module code i think!
2 (commented on others PR)
String Address can be changed to Module code
3 (commented on others PR)
Perhaps change Address class to module code class after merging for module code field is done
4 (commented on others PR)
Maybe example of name can be suited to assignment names more but its a minor problem so LGTM! 😃
5 (commented on others PR)
Perhaps comment can be changed to just 'module code'? Since it is applicable to both lessons and assignments
6 (commented on others PR)
is there an extra line at the top?
7 (commented on others PR)
Agreed. How about academic schedule?
8 (commented on others PR)
isRemindTypo would be better from my perspective! (Code consistency)
9 (commented on others PR)
Perhaps comment here can be removed!
10 (commented on others PR)
Likewise for here, but if we need it in the future we can leave it first
11 (commented on others PR)
Perhaps comment here can be removed!
12 (commented on others PR)
Is there a url/ prefix as a command?
13 (commented on others PR)
Another suggestion is that instead of "LOW", it can be replaced with priority.LOW_PRIORITY
14 (commented on others PR)
Perhaps priority can be named as updatedPriority for consistency? But current one is still fine!
15 (commented on others PR)
prioritize spelt wrongly! priority too
16 (commented on others PR)
or perhaps marks the 3rd assignment as not done?
17 (commented on others PR)
Perhaps replace "scheduler" with "suggested scheduled time slot"?
18 (commented on others PR)
Likewise for this!
19 (commented on others PR)
Perhaps this too!
20 (commented on own PR)
It is a personal portfolio to indicate our contributions. I used the sample content for the time being. (Part of AboutUs)
21 (commented on own PR)
Above examples are under 'add' command.
22 (commented on own PR)
Amended!
23 (commented on own PR)
Next two weeks might sound like this week is excluded
24 (commented on own PR)
next two weeks is already excluding this week
25 (commented on own PR)
Amended!
26 (commented on own PR)
amended!
27 (commented on own PR)
Amended!
28 (commented on own PR)
Amended! Tried to use as much passive language as possible
29 (commented on own PR)
Amended!
30 (commented on own PR)
I don't remember putting a null here but im going to fix it now!
31 (commented on own PR)
amended!
32 (commented on own PR)
amended!
33 (commented on own PR)
amended!
34 (commented on own PR)
amended!
35 (commented on own PR)
amended!
36 (commented on own PR)
amended!
37 (commented on own PR)
amended!
38 (commented on own PR)
amended!
39 (commented on own PR)
amended!
40 (commented on own PR)
amended!
41 (commented on own PR)
Amended!
42 (commented on own PR)
Amended!
43 (commented on own PR)
Amended!
44 (commented on own PR)
Amended! Likewise for the other classes
45 (commented on own PR)
😄
46 (commented on own PR)
Amended!
47 (commented on own PR)
Amended!
48 (commented on own PR)
Amended!
49 (commented on own PR)
Amended to make it sound a tad better LOL
50 (commented on own PR)
WOW AMENDED thanks for eyeballing
51 (commented on own PR)
Amended here as well
52 (commented on own PR)
Amended!
53 (commented on own PR)
Amended!
54 (commented on own PR)
Yeap!
55 (commented on own PR)
multiple keywords are only allowed for the same type of field though! I will amend later to see how i can btr phrase it 😃
56 (other comment)
Added more changes to the UG
57 (other comment)
LGTM!
@yanchenglee98 (18 comments)1 (commented on others PR)
@teekoksiang I think we settled on combining both to minimize the number of fields required when creating a resident. So B05 will be internally parsed as "B" and "05"
2 (commented on others PR)
need to change https://github.com/se-edu/addressbook-level3/actions to this https://github.com/AY2021S1-CS2103T-T11-2/tp/actions
3 (commented on others PR)
Are these for debugging? Remember to remove debugging statements
4 (commented on others PR)
The validity check should be checking trimmedMatriculationNumber instead of matriculationNumber similar to the other parsing commands
5 (commented on others PR)
Another debug statement to be removed.
6 (commented on others PR)
This statement should reference the picture above. Currently the picture LogicClassDiagram.png is not referenced in the DG
7 (commented on others PR)
Each event will still need to have a list of students i.e. List>Person> to keep track which students are attending which event.
Will need an accessor to the list and a way to add students to the list also.
8 (commented on others PR)
Command#execute() and AddressBookParser#parseCommand have different styles. One has a bracket while the other does not. Let's standardize and have the brackets.
9 (commented on others PR)
Sequence diagram is missing a return arrow after calling addEvent() method of Model. Remember that void methods have a return arrow in sequence diagrams. Unless you are omitting return arrows then it should be standardized since the diagram has return arrows for the previous method calls
10 (commented on others PR)
The table seems to be broken when viewed on markdown for me.
11 (commented on others PR)
Are we adding additional explanation after listing the pros and cons of each alternative?
12 (commented on others PR)
It seems the image cannot be viewed on markdown.
13 (commented on others PR)
Should have a spacing after a comma.
14 (commented on others PR)
Should have a spacing after commas
15 (commented on others PR)
Missing colon at the end of sentence
16 (commented on others PR)
Missing full stop at end of sentence
17 (commented on others PR)
The sequence diagram has some errors, notably the second activation bar of of AddCommand has no method call arrow from LogicManager.
Also make sure that the return arrow is aligned with the end of the activation bar.
18 (commented on others PR)
We need to standardize whether or not to capitalize hall. I feel there's no need to capitalize it. We can KIV this for future discussions if needed.
19 (commented on own PR)
I think no need since a new line is already shown between 1a and 1a1 when viewed in markdown.
20 (commented on own PR)
tp progress script requires filename to be github username
21 (commented on own PR)
Yep will do thanks
22 (commented on own PR)
Ok thanks
23 (commented on own PR)
Ok sure but is there a difference between passing the list to the method or getting the person list in the method?
24 (commented on own PR)
Will do thanks
25 (commented on own PR)
Will do thanks
26 (commented on own PR)
Good catch. Will do it thanks
27 (commented on own PR)
I have changed the logic such that the arguments will be stripped which will result to "emailphone" and a parse exception will be thrown in ExportCommand#execute()
28 (commented on own PR)
Yep. Will do thanks
29 (commented on own PR)
I can't seem to find the comment. What test case would you suggest to add?
30 (commented on own PR)
Ok will do. Thanks.
31 (commented on own PR)
Oh nope, ExportCommandParse now does not throw any exceptions. It leaves the validation to ExportCommand
32 (commented on own PR)
Ok done
33 (commented on own PR)
Good catch. Thanks
34 (commented on own PR)
OK done
35 (commented on own PR)
Ok done
36 (commented on own PR)
Good catch, fixed. Thanks.
37 (commented on own PR)
Changes made here.
38 (commented on own PR)
Changes made here.
39 (commented on own PR)
Changes made here.
40 (commented on own PR)
Changes made here.
41 (commented on own PR)
Changes made here.
42 (commented on own PR)
Changes made here. This is so that when a student is added to an event's attendee list, the change can be picked up when setting the event in UniqueEventList#setEvent()
43 (commented on own PR)
Changes made here.
44 (commented on own PR)
Yeah forgot to change it. Thanks
45 (commented on own PR)
Makes sense. Will do.
46 (commented on own PR)
So do an equality check? i.e target.equals(editedEvent)
I was thinking of doing it in the AssignCommand#execute()
47 (commented on own PR)
Sure
48 (commented on own PR)
Good catch! Thankfully additional spaces seem to have no impact upon testing thanks to ParserUtil#parseIndex() as they will trim the input.
But if there any more bugs do report them.
49 (commented on own PR)
This is an outdated TODO. I have removed it in the latest commit.
50 (commented on own PR)
Oh yeah 😆 Thanks
51 (commented on own PR)
Good suggestion!
52 (commented on own PR)
Ok will follow UniquePeronList
53 (commented on own PR)
Yeah good catch
54 (commented on own PR)
Makes sense. Will do
55 (commented on own PR)
Wait we need to use equals because they need to check the contents of attendeeList also. Else when setEvent is called in AssignCommand#execute, a duplicate is always detected. Check the latest commit from my branch to see the errors from the failed Java CI PR Run
56 (other comment)
Completed, closing issue
57 (other comment)
Export feature has been implemented.
58 (other comment)
Should we delete and replace 3.1 with the exporting information?
Redo/undo section has been removed from DG
@justacasul (18 comments)1 (commented on others PR)
index.getOneBased() - 1 is just index.getZeroBased()?
2 (commented on others PR)
what is this haha
3 (commented on others PR)
toAdd is can get confusing here, consider another name (deletedRecipe/updatedRecipe/etc)?
4 (commented on others PR)
Do we need PersonListCard.fxml?
5 (commented on others PR)
What about recipes?
6 (commented on others PR)
Might be good to add an example like you did with Item
7 (commented on others PR)
your optimal size / an optimal size / the optimum size might be better
8 (commented on others PR)
Should a TODO be placed here?
9 (commented on others PR)
Might be good to have TODO here as well
10 (commented on others PR)
my zheng in the filename is missing a g lmao
11 (commented on others PR)
might want to update the png as well
12 (commented on others PR)
same here
13 (commented on others PR)
might want to update the commands
14 (commented on others PR)
same here
15 (commented on others PR)
Will there be an item named alice bob charlie?
16 (commented on others PR)
too chim, need 200 iq to understand
17 (commented on others PR)
tuturu mayushii desu
18 (commented on others PR)
remove this lmao
@athuyaoo (18 comments)1 (commented on others PR)
How come block doesn't need to be non null?
2 (commented on others PR)
are block B and block b 2 different blocks?
3 (commented on others PR)
Perhaps reducing the space by 4 would help conform to coding standards better.
4 (commented on others PR)
Perhaps having VALID_BLOCK and VALID_ROOM will be better for conforming with standards
5 (commented on others PR)
perhaps you can split this up to VALID_BLOCK and VALID_ROOM, so that you can reuse them? (especially in TypicalPersons.java)
You can make VALID_BLOCKROOM with the 2 as well.
6 (commented on others PR)
I think got small typo here. Matriculation number and gender?
7 (commented on others PR)
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + ADDRESS_DESC_BOB
+ BLOCKROOM_DESC_BOB + TAG_DESC_HUSBAND + TAG_DESC_FRIEND
+ MATRICULATION_NUMBER_DESC_BOB + GENDER_DESC_BOB,
Should the indentation be 8 spaces here? https://se-education.org/guides/conventions/java/intermediate.html#layout
8 (commented on others PR)
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + ADDRESS_DESC_BOB
+ BLOCKROOM_DESC_BOB + GENDER_DESC_BOB + TAG_DESC_FRIEND
+ MATRICULATION_NUMBER_DESC_AMY + MATRICULATION_NUMBER_DESC_BOB,
Should the indentation be 8 spaces here? https://se-education.org/guides/conventions/java/intermediate.html#layout
9 (commented on others PR)
I think it's better to remove this space?
10 (commented on others PR)
Same here, additional line can be removed.
11 (commented on others PR)
Thanks
12 (commented on others PR)
sorry StudyGroups and studentGroups are a bit different I feel?
13 (commented on others PR)
maybe can change these to example student groups like basketball, soccer, choir etc?
14 (commented on others PR)
can change studentGroup here to something else like basketball/ soccer
15 (commented on others PR)
Same here
16 (commented on others PR)
Same here
17 (commented on others PR)
Same here
18 (commented on others PR)
I think it might be more suitable to change this to studentGroups from StudyGroups?
19 (commented on own PR)
Good catch. Thanks
20 (commented on own PR)
Thanks, will change.
21 (commented on own PR)
Sure, thanks.
22 (commented on own PR)
No, so far all the model properties (Address, Email, Name, etc) all has public final variables to store their values.
23 (commented on own PR)
Fixed
24 (commented on own PR)
Thanks, Fixed
25 (commented on own PR)
Sure, done
26 (commented on own PR)
Done
27 (commented on own PR)
Done
28 (commented on own PR)
Thanks, resolved.
29 (commented on own PR)
Thanks, resolved.
30 (other comment)
Closed by #25
31 (other comment)
To add table of contents that is standardised with title case.
@yan-soon (18 comments)1 (commented on others PR)
I think all NUS mods follow that format right? Unless we branch out to cover other Unis
2 (commented on others PR)
Did we refactor the EditCommandDescriptor class to EditModuleDescriptor class?
3 (commented on others PR)
Same comment as above regarding the EditCommandDescriptor.
4 (commented on others PR)
I think there are some trailing white spaces at line 26 and 30, causing the first check to fail.
5 (commented on others PR)
I think same issue as the one I had, should we explicitly state the call of the DeleteCommandParser.parse() method?
6 (commented on others PR)
I think our current delete system still works with indexes, but possibly can KIV for future updates?
7 (commented on others PR)
yup agree!
8 (commented on others PR)
Is this part supposed to return true now? now that we changed the find command to .contains()
9 (commented on others PR)
Do we currently have the 1.5 secs time delay implemented?
10 (commented on others PR)
Maybe we can specify what Similar to previous means exactly?
11 (commented on others PR)
Same comment as above
12 (commented on others PR)
Same comment as above!
13 (commented on others PR)
Same comment as above!
14 (commented on others PR)
think we can remove this line haha
15 (commented on others PR)
Ya HAHAH i think that would be a lot clearer
16 (commented on others PR)
Okay dope
17 (commented on others PR)
NIT: Maybe we can standardise to put fullstops or not
18 (commented on others PR)
Maybe we can catch the possible IllegalArgumentException error thrown by the StringUtil.ignoreCase() method here so that we can display an error message to the user that something has gone wrong.
Currently if the user types in "search MA 1521", the IllegalArgumentException error is thrown in IntelliJ but not in the GUI. Maybe we can try something like that, but I'm not too sure what error message you would wanna show them hehe
try {
String moduleCode = StringUtil.ignoreCase(trimmedArgs);
return new SearchCommand(moduleCode);
}
catch (IllegalArgumentException e) {
throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, SearchCommand.MESSAGE_USAGE));
}
19 (commented on own PR)
Okay, updated the description! Thanks for feedback.
20 (commented on own PR)
Updated!
21 (commented on own PR)
Updated to include entire method name!
22 (commented on own PR)
Changed to deleteModule(1)!
23 (commented on own PR)
Updated!
24 (commented on own PR)
Wah this one rly good find...
25 (commented on own PR)
Renamed!
26 (commented on own PR)
Changed!
27 (commented on own PR)
Changed!
28 (commented on own PR)
Good suggestion! Added in
29 (commented on own PR)
Changed the structuring! For the edit {index}, I decided to keep it as {index} for now to match the expected outcome images! I can change it accordingly once we have updated our code
30 (commented on own PR)
Not too sure as well, was kinda going for the notion that saving would be done automatically throughout usage of the app, cause I realise we didnt mention anything about saving throughout, and I thought people might think of saving when they think of exiting HAHAHA
31 (commented on own PR)
Alright, made a new class RequiredCommandMessages in the storage component!
32 (commented on own PR)
True! I combined the 3 methods into one (those that compare foundation, ITprof and mathandsci mods) into one method. I decided to keep the compareInternship() and compareScience() methods as they have slightly different implementations than the other 3 module categories
33 (commented on own PR)
Good call, changed it!
34 (commented on own PR)
Okay did not know about this HAHAHAH changed accordingly!
35 (commented on own PR)
aHHHHH so this is the way....HAHAH I totally forgot I could do this. thanks man, changed accordingly 😄
36 (commented on own PR)
I changed it such that I used the static import of the SCIENCE_PATH.
37 (commented on own PR)
Okay, changed accordingly, similar to what I did for RequiredCommand
38 (commented on own PR)
Rectified!
39 (commented on own PR)
Changed the whole class design so, no more Optional>> attributes HAHAHA
40 (commented on own PR)
okay roger doger! changed accordingly
41 (commented on own PR)
oh right HAHAH okay abstracted further
42 (commented on own PR)
accidentally flipped the booleans HAHAH changed the conditions and booleans accordingly
43 (commented on own PR)
sorry for the misleading boolean names AHAHHA changed the whole code, so no more booleans, just an If-else block to settle if the module is present or not
44 (other comment)
Great find guys, I've edited accordingly to your comments. Thanks 😃
45 (other comment)
LGTM!
46 (other comment)
LGTM!
47 (other comment)
LGTM! (apart from very minor comment)
48 (other comment)
As per Sam's reviews, I have made some changes to the PR.
The major changes are as such:
RequiredCommandStorage
Added this class to deal with all the pulling of modules from the respective JSON files.
RequiredCommandMessages
Added this class to store all the standard messages and paths that the RequiredCommand will use.
RequiredCommand
Changed the class such that it no longer has to deal with storage of the required modules! It now simply uses Getter methods from the RequiredCommandStorage to get the respective modules from the various fields.
The class now mainly deals with all the comparison of GradPad modules against all the required modules.
ScienceCommand
RequiredCommandTest
Changed the tests to suit the new methods
RequiredCommandStorageTest
Added the test class to test the new RequiredCommandStorage class.
@yongmingyang (18 comments)1 (commented on others PR)
"Question " but no biggie
2 (commented on others PR)
"QUESTION " instead of "Name"
3 (commented on others PR)
medmoriser**
4 (commented on others PR)
medmoriser*
5 (commented on others PR)
Medmoriser* methods
6 (commented on others PR)
medmoriser*
7 (commented on others PR)
medmoriser
8 (commented on others PR)
medmoriser
9 (commented on others PR)
medmoriserStorage*
10 (commented on others PR)
medmoriserStorage*
11 (commented on others PR)
medmoriserStorage*
12 (commented on others PR)
medmoriserStorage*
13 (commented on others PR)
medmoriser*
14 (commented on others PR)
medmoriser list? question set list?
15 (commented on others PR)
different question *
16 (commented on others PR)
questions*
17 (commented on others PR)
invalid question*
18 (commented on others PR)
different question
19 (other comment)
wrong place
@nweiyue (18 comments)1 (commented on others PR)
Perhaps "contacts" can be changed to "students"?
2 (commented on others PR)
Perhaps "contact" can be changed to "student"?
3 (commented on others PR)
Perhaps "contacts" can be changed to "students"?
4 (commented on others PR)
Perhaps "person" can be changed to "student"? I noticed the same issue in several other places too.
5 (commented on others PR)
Perhaps the email can end with "@u.nus.edu" instead?
6 (commented on others PR)
Should this be "{@ MatriculationNumber}" instead of "Email"?
7 (commented on others PR)
Perhaps the space between "Dangerous" and "Command" can be removed?
8 (commented on others PR)
Should "studentn" be "student instead?
9 (commented on others PR)
Should people be "student' instead?
10 (commented on others PR)
Should the constant messages be renamed as well? I've noticed this issue in other places as well.
11 (commented on others PR)
Should "AddressBook" be refactored to "StudentList"?
12 (commented on others PR)
Should the parameter be change to studentList instead?
13 (commented on others PR)
Should this be change to ATAS instead?
14 (commented on others PR)
Should "AddressBookStorage" be change to "atasStorage" instead?
15 (commented on others PR)
Would "Adding a session to a class requires user input from the CLI. The parser will then parse the user input to obtain the name and the date of the session." flow better?
16 (commented on others PR)
Should this be "An"? I've noticed this in other places as well.
Perhaps you can use markdown AddSessionCommand#parse() to replace "parse method'? I've noticed this in line 272 and 277 for other methods as well.
17 (commented on others PR)
Perhaps "String" can String? I've noticed this in other places as well.
18 (commented on others PR)
Perhaps breaking this paragraph into two sentences will make it flow better? For example: "... . It then uses ModelManager#addSession() .."
19 (commented on own PR)
Good suggestion. But I felt that since the other attributes like showHelp and exit are action words, perhaps "switchTab" might be a better name to accurately represent what CommandResult does? Is there a reason why you think "tab" might be a better name?
20 (commented on own PR)
Great suggestion! I will incorporate a getValue() method as u suggested above as well.
21 (commented on own PR)
Yes, that is a good suggestion! I have incorporated into my new commit.
22 (commented on own PR)
Right. Thanks for pointing it out!
23 (commented on own PR)
Good spot!
24 (commented on own PR)
I believe this is to describe the action that users want to perform. I have updated them to "Add Student, Delete Student and so on". Thank you for pointing it out!
25 (commented on own PR)
Good find! Will merge after resolving!
26 (commented on own PR)
Thanks for spotting the mistakes!
27 (commented on own PR)
Thanks for the suggestion but if the argument is invalid, it throws a CommandException but if argument is empty it throws a ParseException. Hence, this is why I separated them.
28 (other comment)
LGTM. However, would changing
currenttocurrent sessionmaybe make the command too long for the user to have to type? Maybe the rest of the team could chime in on this as well. @CodingCookieRookie @YuunoKun @MarcusTw
I was thinking about that as well. I am okay with current if everyone else is okay with it.
@aizatazhar (18 comments)1 (commented on others PR)
nitpick: format should be HHmm (lowercase m for minutes since M is for months)
https://docs.oracle.com/javase/10/docs/api/java/text/SimpleDateFormat.html
2 (commented on others PR)
zookeep book
3 (commented on others PR)
Sorry not 100% sure but is this documentation correct? I dont see any references to medical condition here
4 (commented on others PR)
nitpick: should capitalise the first letter of the return javadoc sentence. same for the method below
5 (commented on others PR)
nitpick: think the .anyMatch() methods from line 58 to 64 should have indented 8 more spaces since it is part of the stream on the line before it
6 (commented on others PR)
i think can delete the (NEW) comment
7 (commented on others PR)
Should be zookeep book (or can just say "An animal with this ID already exists")
8 (commented on others PR)
I think this belongs in SortCommand since it isn't a common message. Also perhaps can mention the available sort parameters in this error message
9 (commented on others PR)
Think a better description could be Sorts all animals in the zookeep book based on user specified parameter?
10 (commented on others PR)
Think this line can be standardised with the rest of the commands? I suggest something like
Parameters: KEYWORD (name, id, feedtime)? ok not sure how to phrase the stuff in the brackets but something like this would be nicer i think
11 (commented on others PR)
This just my opinion (feel free to ignore) but i feel like this belongs more in the SortCommandParser since this is parsing the user's input. Perhaps you can make SortCommand take in an AnimalComparator instead?
12 (commented on others PR)
I think feedtime should be spelt as "feed time" wherever possible (other than when the user actually types the command?) since the class is called FeedTime. Like in the AnimalComparator and FEEDTIME_KEYWORD as well
13 (commented on others PR)
Additionally, minor improvement can be making the keywords case insensitive, so if user types sort NAME it should still work
14 (commented on others PR)
see my comments on SortCommandParser
15 (commented on others PR)
couldn't the default case (i.e. unrecognised keyword) be to throw a ParseException here (same as lines 26-27)? seems a bit weird to create an invalid object
16 (commented on others PR)
see comments on SortCommandParser. i believe category is only used in your SortCommand to check if it is an invalid case? in that case category attribute can be deleted, then this class won't have to depend on SortCommandParser.
17 (commented on others PR)
I think it was because I did not want to input a null as the animal comparator
Hmm, in that case i believe you can do this instead:
case NAME_CATEGORY:
return new SortCommand(AnimalComparator.createAnimalNameComparator());
for each of the categories, then you can omit the line return new SortCommand(animalComparator);. But regardless i think the way it is now you will never pass a null either so up to you
18 (commented on others PR)
ah okay fair enough!
19 (other comment)
Closed by #65
20 (other comment)
Relevant PRs: #60, #62, #66, #68
21 (other comment)
@m0nggh yep i think we should! Maybe you could file a new issue for that
22 (other comment)
Could you fix the typo medicalConditionged in tp/src/test/data/JsonSerializableAddressBookTest/duplicateAnimalAddressBook.json
23 (other comment)
Please wait for #87 to be closed before working on this issue
24 (other comment)
~@m0nggh Sorry could you hold until my PR (#90) is merged so work doesn't get repeated? I have renamed some files but I didn't touch the sample animals (stuff like Bob Alice etc)~
25 (other comment)
Nevermind, apparently it's related to the proposed "undo/redo" feature in the DG
26 (other comment)
@koonweee could we have edit take in the id instead of the index instead? i.e. edit >id number> ... instead of edit >index> ...
27 (other comment)
Updates
Align animal descriptors
Change animal descriptors to yellow
Add spacing between the medical condition labels and feed times labels
Feed times display "hrs"
Allow resizing of command result display box
Set custom style for fields which are not specified
28 (other comment)
Closed by #114
29 (other comment)
Similarly, "an address book" was changed to "an zookeep book" in ReadOnlyZooKeepBook.java
30 (other comment)
Suggestion if you have time: able to sort by any field, e.g. sort name/sort id/sort feed etc.
@shaokiat (17 comments)1 (commented on others PR)
I think should be fine since all the CS modules we are covering follows that format. Or should we limit to 7 characters?
2 (commented on others PR)
* Returns the user prefs' GradPad file path.
can try using replace tool to search for remaining address book
3 (commented on others PR)
I guess the Tag can be the Core and Non-core for now
4 (commented on others PR)
// ensures that outOfBoundIndex is still in bounds of GradPad list
5 (commented on others PR)
// edit module in filtered list into a duplicate in GradPad
6 (commented on others PR)
* but smaller than size of GradPad
7 (commented on others PR)
// ensures that outOfBoundIndex is still in bounds of GradPad list
8 (commented on others PR)
public void execute_multipleKeywords_multipleModulesFound() {
9 (commented on others PR)
public void execute_zeroKeywords_noModuleFound() {
10 (commented on others PR)
* A utility class to help with building EditModuleDescriptor objects.
11 (commented on others PR)
* Parses the {@code tags} into a {@code Set<Tag>} and set it to the {@code EditModuleDescriptor}
12 (commented on others PR)
* Returns an add command string for adding the {@code module}.
13 (commented on others PR)
Perhaps can specify that modules are added into the Current Modules section/column instead of just GradPad
14 (commented on others PR)
Example of usage: `add c/ CS2103T cr/ 4`
15 (commented on others PR)
LOL
16 (commented on others PR)
I'm guessing we have to add the other non-CS modules that are in the syllabus as well to the moduleInfoMap
17 (commented on others PR)
I think Sam meant that the logic behind the implementation can be abstracted out so there's not as much repeated code because now there are still repeated code in the 3 methods which is the double for loops.
I'm guessing maybe the addition of the helper function would be good.
18 (commented on own PR)
Not sure if that will affect the storage part but okay I'll change it first
19 (commented on own PR)
I have changed it to CS2103T instead and passed the test case.
20 (commented on own PR)
Oh okay yeah sounds good.
21 (commented on own PR)
Yeap okay that one passed the test. But yeah was slightly confused with this test case.
22 (commented on own PR)
Yup for now it still works with indexes but I think we are planning to change it to ModuleCode in the near future so I just change the documentation first.
23 (commented on own PR)
I think it has got to do with the JavaFX status bar but I don't see it in the GUI
24 (commented on own PR)
Okay I'll remove it since its not needed.
25 (commented on own PR)
Ah grammar mistakes
26 (commented on own PR)
Oh yeah forgot about this. Thanks for catching it! 👍
27 (commented on own PR)
Oh wow good catch! Added the relevant code!
28 (commented on own PR)
This is with regards to Yan's comment because the command search MA 1521 will not throw error when it is supposed to but after the IllegalArgumentException was added it was able to catch the error
StringUtil.ignoreCase calls AppUtil.checkArgument which throws IllegalArgumentException
How should I go about catching this IllegalArgumentException?
29 (commented on own PR)
Thanks for the note! 😄
@Ziyang-98 (17 comments)1 (commented on others PR)
Will need to change the name and content of class eventually
2 (commented on others PR)
Can change thr Strings here, like "PHONE " to "DESCRIPTION " and same for amount
3 (commented on others PR)
Try not to get the lists itself out as there are delete methods available in the ActiveAccount class, for example deleteExpense and deleteRevenue
4 (commented on others PR)
Can extract out the error catching and the execute logic. For example, if (targetIndex.getZeroBased() >= revenueList.size()) { throw ...}
5 (commented on others PR)
I think the error catching condition should not be on this line
6 (commented on others PR)
I think the error catching condition should not be on this line
7 (commented on others PR)
Does this change the json file name under data?
8 (commented on others PR)
the "C" in "C/CATEGORY" should be lowercase
9 (commented on others PR)
This is still Work In Progress right? Since by wednesday there will be new commands
10 (commented on others PR)
oh ok roger
11 (commented on others PR)
btw this should change to requireAllNonNull(model, activeAccount)!
12 (commented on others PR)
This should include the activeAccount but I can change it once everyone finishes the command
13 (commented on others PR)
This is in String already though
14 (commented on others PR)
Maybe here can call the toString method like "return toString()" , or u can call getName() in toString() too to avoid duplication of code
15 (commented on others PR)
This can be called EditCommand, if not need to add Entry to AddCommand and DeleteCommand as well
16 (commented on others PR)
try to avoid chaining methods like this due to Demeter's law. Can create a isEntryExpense() method in the EditEntryDescriptor so that it would look like "editEntryDescriptor.isEntryExpense()". Similarly, can do the same for revenue
17 (commented on others PR)
For this, I can edit the ArgMultiMap after checking all the other commands!
18 (commented on own PR)
Okay!
19 (commented on own PR)
Okay!
20 (commented on own PR)
so that nich and jordan can refer to it when implementing the commands
21 (commented on own PR)
for tags we reusing it
22 (commented on own PR)
okay i think that changed accidentally while i was deleting stuff
23 (other comment)
Btw for commits and PR header, the verb no need to be in past tense (so like changed can just leave it as change, updated can just leave as update)!
24 (other comment)
Example of input would be:
"add c/expense d/buying seeds a/20.50"
"add c/revenue d/selling flowers a/50.35"
25 (other comment)
Example of user input would be:
"delete 1 c/expense"
"delete 2 c/revenue"
26 (other comment)
find flowers c/revenue
27 (other comment)
edit 1 c/revenue d/description a/amount t/tag
edit 2 c/expense d/description
edit 3 c/revenue a/amount
28 (other comment)
clear c/expense
29 (other comment)
clear c/revenue
30 (other comment)
calculate
31 (other comment)
switchacc 1
32 (other comment)
Handle the exception with isValidAmount in Amount class
33 (other comment)
Add new attribute to Entry. So when new entry is added, the date can be retrieved from LocalDate and included in the constructing of the entry. For example, new Revenue(Description d, Amount a, Date date, Set>Tag> tags). So things to do (in order):
Create Date class under Entry package.
Add Date attribute to Entry (Need to refactor everything that involves Entry)
Implement creating of Date in AddCommand
34 (other comment)
Instead of c/revenue c/expense, change to c/r and c/e.
Happy birthday!
@MerlinLim (17 comments)1 (commented on others PR)
Will change accordingly from my side
2 (commented on others PR)
Don't need to modify for now but we'll need to standardize on a specific date pattern for both deliverable and meeting. (Deliverable uses DD-MM-YYYY HH:MM format instead)
3 (commented on others PR)
Likewise, date format to be discussed further
4 (commented on others PR)
Perhaps the code can be reduced by using Optional.orElse("NIL") instead of using the conditional operators
5 (commented on others PR)
Not important now, but it would be good for all of modes to standardize using Optional.ofEmpty.
6 (commented on others PR)
Consider removing 'get' and keeping it as 'isComplete()'
7 (commented on others PR)
Minor detail, perhaps could consider re-arranging the parameters according to the user-input sequence
Person(Role role, Name name....). Not important for now,
8 (commented on others PR)
Add an INVALID_DESCRIPTION_DESC to test against whitespaces
9 (commented on others PR)
Add invalid description test here
10 (commented on others PR)
Was this switched because of the dates?
11 (commented on others PR)
Also note down what happens when user switches mode (e.g list of items are displayed)
12 (commented on others PR)
Consider adding whitespace between words (e.g switch deliverable...)
13 (commented on others PR)
Consider using lower caps 'm' to differentiate between minutes and months (e.g DD-MM-YYYY HH:mm)
14 (commented on others PR)
Sample consideration as in deliverables
15 (commented on others PR)
Consider removing this section if there's no intention of updating Table of Contents for now.
16 (commented on others PR)
The commas in e.g., seem to be a typo. I could be missing some markdown formatting.
17 (commented on others PR)
Same* consideration
18 (commented on own PR)
I did attempt to place the EPIC within each section, but github markdown does not allow you to create merged cells. So the sentence is wrapped within the a small single cell. I would suggest, if we want to include the epics, to create a separate table and reference the [EPICS] accordingly.
19 (commented on own PR)
Yes, it seems I was careless and glossed over that section. Will include, thank you for pointing out!
20 (commented on own PR)
Noted, will remove accordingly
21 (commented on own PR)
@shadowezz is correct. It would be easier to generate the valueString when instantiating. Anyways the value is final so the valueString doesn't change
22 (other comment)
Ignore duplicate issue.
23 (other comment)
Tutorial Completed
24 (other comment)
Tutorial Completed, not for merging.
25 (other comment)
Tutorial Completed, not for merging.
26 (other comment)
Tutorial Completed, not for merging.
27 (other comment)
Tutorial Completed, not for merging.
@GeNiaaz (17 comments)1 (commented on others PR)
Just a minor grammatical error: code is written
2 (commented on others PR)
Good contribution
3 (commented on others PR)
Can consider linking this to your commit?
4 (commented on others PR)
Link this to your commit too? 😃
5 (commented on others PR)
Good implementation of the Association class, we'll see how this plays out when we build the subsequent features.
6 (commented on others PR)
good one, makes it more specific 👍
7 (commented on others PR)
small grammatical error here: that have assignee named...
8 (commented on others PR)
same grammatical error here: that have assignee named...
9 (commented on others PR)
good spot! 💯
10 (commented on others PR)
You haven't implemented it yet?
11 (commented on others PR)
Maybe return a PersonName here instead of a string?
12 (commented on others PR)
Might be better to compare PersonName objects instead of strings
13 (commented on others PR)
Good spot! 💯
14 (commented on others PR)
Good that you made it clearer
15 (commented on others PR)
WOW this has been bugging me for the longest time, thanks for finding and changing it
16 (commented on others PR)
Why set it to null here? Why not declare the variable below.
17 (commented on others PR)
Good adhering to Law of Demeter
18 (commented on own PR)
Yes indeed, I will also change the project names to more appropriate "project-like" names too. But for now I just want to get the Name refactored and to fix all the errors. On the third PR when I refactor the Address and tags, I will change all the testcases and such.
If I change it now, it will be a lot more time-consuming.
19 (commented on own PR)
My bad kind sir, I shall rectify this right away
20 (other comment)
For the Leader Object, you want to make it an instance of a Person? Such that it can contain email, address etc. I have included that in my implementation of Teammate. Lemme change that to Person then maybe your Leader can be an instance of Person too. This way you dun have to create email classes etc for the Leader
21 (other comment)
I approved the PR which @TCQian pushed to fix it, this issue is now defunct
22 (other comment)
Got it, thanks
@hyngkng (17 comments)1 (commented on others PR)
I think Motivation is good as it is relatable to our readers.
However, I'm not too sure if Aim is easy to understand with the two given equations. Perhaps use sentences instead?
2 (commented on others PR)
I think instead of writing in a point form, it could be written in full sentences. The language used here also feels informal and incomplete.
Some examples could be:
More convenient than typical apps as lessons and assignments are managed in just one app so there is no need to switch between different ones.
Easier to manage schedule than typical scheduling apps as assignments are automatically scheduled.
3 (commented on others PR)
I think we should not say that ProductiveNUS is a simulation of an ongoing project. That description suits AB3 more. I think just calling it a project is good! 😃
4 (commented on others PR)
I like the aim. Clear and concise
5 (commented on others PR)
Hahaha good job finding this while debugging
6 (commented on others PR)
I think this is a good improvement from Minh's initial version. It is clearer and more straightforward.
7 (commented on others PR)
I think the order of the commands looks good.
8 (commented on others PR)
I think just keep it as an abstract class will do.
9 (commented on others PR)
Good assertion.
10 (commented on others PR)
Good test cases. They cover every case I can think of, so good job.
11 (commented on others PR)
You forgot to change the description for this.
12 (commented on others PR)
Should these variables be final instead?
13 (commented on others PR)
I think the phrasing here is a little confusing. Could either mean assignments due at 1200 on the two dates, 24 Oct and 25 Oct, or it could mean all assignments due on 24 Oct and 25 Oct, and all assignments due at 1200 regardless of date. But maybe it's just me 😛 Just nitpicking
14 (commented on others PR)
What if the user types in 90-90-9090?
15 (commented on others PR)
Likewise for this, the user can input 2500 for example
16 (commented on others PR)
Slight nitpick, why not change from "or" to "and/or" to specify you can use multiple keywords!
17 (commented on others PR)
Does this mean using this specific command will show for example: 1. Assignment 1 d/24-10-2020 2359 and 2. Assignment 2 d/30-12-2020 1200? Just clarifying!
18 (commented on own PR)
Have edited accordingly. Thanks.
19 (commented on own PR)
Edited accordingly. Thank you.
20 (commented on own PR)
I removed these tests because Assignment already tests Name. 😃 Thanks!
21 (commented on own PR)
Amended. Changed to Task instead. 😃
22 (commented on own PR)
Amended!
23 (commented on own PR)
Amended!
24 (commented on own PR)
I was thinking more of like how to "combine" assignments.hasCode() and lessons.hashCode() together
25 (commented on own PR)
I have changed it so that it does this: prime number 31 * sum of the two hash codes.
26 (commented on own PR)
Amended!
27 (commented on own PR)
SLAP-ed. Thank you!
28 (commented on own PR)
Changed to "None"!
29 (commented on own PR)
Amended.
30 (commented on own PR)
Amended. Thanks!
31 (commented on own PR)
Amended for both.
32 (commented on own PR)
Hahahaha... my bad. Amended 😃
33 (commented on own PR)
Amended.
34 (commented on own PR)
Amended 😃
35 (other comment)
LGTM
@wang-jun-hao (17 comments)1 (commented on others PR)
Perhaps "DOB must not be a date in the future" will be better and more succinct?
2 (commented on others PR)
Perhaps it is better to name it VALID_DATE_OF_BIRTH_AMY and VALID_DATE_OF_BIRTH_BOB to keep it consistent with the current style, where the full class name is used instead of abbreviations?
3 (commented on others PR)
Perhaps it is better to name it DATE_OF_BIRTH_DESC_AMY and DATE_OF_BIRTH_DESC_BOB?
4 (commented on others PR)
Maybe it is better to use the full class name for clarity?
A good case of invalid check since '/' is quite a common way of inputting dates.
5 (commented on others PR)
Might have added 12 spaces instead of 8 by mistake?
6 (commented on others PR)
Maybe you can re-arrange the order of the fields to make it more consistent with the rest of the code
7 (commented on others PR)
Fixed
8 (commented on others PR)
Fixed
9 (commented on others PR)
Fixed
10 (commented on others PR)
Perhaps it is better to have the first sentence of a javadoc on a single line.
11 (commented on others PR)
Perhaps it is better to have these fields as private and provide getters for encapsulation purposes.
12 (commented on others PR)
Perhaps it is better to define these variables as named constants (private static final) at the class level.
13 (commented on others PR)
ok we can kiv
14 (commented on others PR)
Perhaps it is good to have a javadoc for this method since it is public
15 (commented on others PR)
Perhaps we should have a javadoc for AccessCommand
16 (commented on others PR)
Perhaps we can also test the case when outOfBoundIndex is also out of bounds of MediBook list
17 (commented on others PR)
Can we use a try {new MedicalNote()} and catch block to handle this? MedicalNote constructor has a similar block of code for this and will throw exceptions that can be caught here.
18 (commented on own PR)
I have tried appending the commend to the end of the line, but the line will exceed 120 chars. Hence, I moved it to the top.
19 (commented on own PR)
Thank you for pointing that out. I have added it into the check.
20 (commented on own PR)
Will do integration testing after other modules are merged within this branch
21 (commented on own PR)
fixed
22 (other comment)
Completed fields necessary for v1.1
23 (other comment)
Addressed in merging v1.2b into master
24 (other comment)
Addressed in merging v1.2b into master
25 (other comment)
Addressed in merging v1.2b into master
26 (other comment)
Addressed in merging v1.2b into master
@josiahkhoo (16 comments)1 (commented on others PR)
Just wondering if it would be better if MCQ was named MultipleChoiceQuestion to standardize with our OpenEndedQuestion class. Would be more descriptive for whoever is looking at the code base as well.
2 (commented on others PR)
Would be good if you can include the toString() methods for the Answer and Question class, that way when it is implemented in the GUI it would be easier to render it seperately (since the current way to access the string form of the question and answer is through the Flashcard class).
The current toString() method in FlashCard is still useful when interacting with the application through CLI 👍
3 (commented on others PR)
Looks good! Just wondering whether it would be better if we made userAnswer an Answer type also, that way we can potentially do more things with it in the future.
If userAnswer was an Answer type, we can just override .equals() as a way of comparison to check if userAnswer is indeed Answer.
4 (commented on others PR)
I think this should be number 6
5 (commented on others PR)
Empty point
6 (commented on others PR)
updates* save file
7 (commented on others PR)
Agree with @joshtyf! We would eventually have to update the documentation anyways, so would be good if we can do it incrementally instead of waiting all the way to the end to update 😄
8 (commented on others PR)
Do you think we should make this more specific? Perhaps call this AddOpenEndedQuestionCommand because we would eventually need to have a command to add a multiple-choice question.
9 (commented on others PR)
Nice abstraction!
10 (commented on others PR)
Nice EP!
11 (commented on others PR)
Can we name this differently to avoid misrepresentation and confusion? Think we used value for Question and Answer
12 (commented on others PR)
Don't think we need VALIDATION_REGEX if we are already checking it against Difficulties.values()
13 (commented on others PR)
Perhaps you can make use of .reduce() to make this method even more concise.
return tagsToMatch.stream().reduce(("with tags ", (curr, next) -> curr + next.toString() + " ").trim()
14 (commented on others PR)
QuickCache is missing a : infront of it. Believe it should be :QuickCache
15 (commented on others PR)
Same as the comment above.
16 (commented on others PR)
Lets standardize to "add q/question ans1 c/first c/second" (with the inverted commas)
17 (commented on own PR)
I see! I think I can change it to value in that case, I changed it to choice to standardize with the other classes but it seems content or value (which was used by the initial AB) would be clearer.
18 (commented on own PR)
Updated in the next commit, can you help me to take a look @joshtyf?
19 (commented on own PR)
Fixed in 1d082d2
20 (commented on own PR)
Fixed in 1d082d2
21 (commented on own PR)
Fixed in 1d082d2
22 (commented on own PR)
Fixed in 1d082d2
23 (other comment)
@ChenXJ98 can you help with merging this into master 🙇♂️
24 (other comment)
closes #42
25 (other comment)
@ChenXJ98 we will also need to integrate this into the saving of flashcard so that we can retain the times tested information across instances of QuickCache
26 (other comment)
resolves #46
27 (other comment)
clear command has already been implemented.
28 (other comment)
Thanks @joshtyf for updating the UML diagrams!
29 (other comment)
Moved to v1.3
@joshtyf (16 comments)1 (commented on others PR)
Would you mind adding documentation to this? So that others will understand what this method is doing.
2 (commented on others PR)
Do you think overriding the equals() is better?
3 (commented on others PR)
Would it be better to change the method name to getTagName? This is for consistency purposes.
4 (commented on others PR)
Could you change the documentation? This is so that others can understand what this class is about.
5 (commented on others PR)
Should we start renaming the other classes soon?
6 (commented on others PR)
Why is this deletable though? I thought this was the initial data to be used to populate a brand new instance of QuickCache
7 (commented on others PR)
Should we should rename these methods as getQuestionAsList and getQuestionAsString? Might be less confusing in the future.
8 (commented on others PR)
Is there a better way to represent this instead of question.size() == 1? Maybe abstract it into a separate method for this check?
9 (commented on others PR)
I initially named it as content because I thought it would reduce confusion from having too many "choice" names.
But choice works fine too.
10 (commented on others PR)
alright cools
11 (commented on others PR)
okay great
12 (commented on others PR)
alright!
13 (commented on others PR)
alright!
14 (commented on others PR)
The
StatsCommandParserwill take in a single argument forIndex.
I think it's not very accurate to say this. Maybe you could specify the exact method or if it's a constructor, then specify it as a object field instead of argument
15 (commented on others PR)
replace the
Flashcardat the specifiedIndexwith a newFlashcard
I think can specify that a copy of the original flashcard is made but with the statistics reset to default numbers.
Also, what does default numbers mean? Perhaps you could be more specific about it
16 (commented on others PR)
thanks for correcting my mistake 👍
17 (commented on own PR)
good suggestion. will change it
18 (commented on own PR)
fixed in the latest commit!
19 (commented on own PR)
fixed in the latest commit!
20 (commented on own PR)
truly a CS2030 TA, thanks for the suggestion!
21 (other comment)
Let me update the UG for the find command first before merging the PR
22 (other comment)
UserGuide updated. Ready for review and merge
23 (other comment)
Updated my user guide in my commit 596b8cdc37112c815fbe794de967e5521dc4edad
@Ma-Yueran (16 comments)1 (commented on others PR)
Should there be 2 br ?
2 (commented on others PR)
I think between other points it's 1 br, but not a big problem
3 (commented on others PR)
2 small errors due to refactor
4 (commented on others PR)
An error due to refactor
5 (commented on others PR)
Should this file change? I'm not sure
6 (commented on others PR)
I think UserGuide should not be changed
7 (commented on others PR)
A small error due to refactor
8 (commented on others PR)
A small error due to refactor
9 (commented on others PR)
yeah I agree
10 (commented on others PR)
Seems that this test also need to be changed in the future. But I think maybe this does not matter now.
11 (commented on others PR)
Is the ModelManager here a stub? If it's not, I'm not sure if it is ok.
12 (commented on others PR)
Maybe the AddressBook should be renamed to HelloFile? But I think it can be done later.
13 (commented on others PR)
I'm not sure, but there were some errors when I tried to specify a type.
14 (commented on others PR)
I will try to fix that
15 (commented on others PR)
Is it necessary to mention FindCommand here? Since there are many other commands that also use tag.
16 (commented on others PR)
I think " Label allows 'Tag' to keep a 'Label' " might sounds a bit weird. But it's only personal opinion.
17 (commented on own PR)
I think I put them in a wrong place while modifying, did not notice that
18 (commented on own PR)
I updated the PR to move them under the "independent Ui part" comment. Thank you for pointing that out.
19 (commented on own PR)
Oh, yeah, thank you for pointing that out
20 (commented on own PR)
Ok, I will change that, thank you for reviewing the code!
21 (commented on own PR)
Oh, yeah, forgot to delete that
22 (other comment)
I think the new ui is working fine, if there are bugs, can still switch back to the old one
23 (other comment)
I am thinking about making the Ui show the details of a tag when a tag box is clicked, then there is no need to scale. Is that ok?
24 (other comment)
Besides that I think I will also try to make the list scalable horizontally, I think that's a good suggestion.
25 (other comment)
I think that's because UI can only handlle CommandException and ParseException, so the command need to throw one of them instead of the InvocationTargetException
26 (other comment)
cs2103 is accepted as a tagName, but there is one tag named cs2103 already
27 (other comment)
Looks good. Is it possible to have a toggle for this theme?
You mean something to switch to different themes?
28 (other comment)
Fixed by #92
29 (other comment)
The PR update modifies the Version variable in MainApp in fit the current milestone, and display that version number in UI.
30 (other comment)
Ok, working on it now
31 (other comment)
Update PR to support UI theme switching.
32 (other comment)
Update PR to add a new Theme, also replace AB3 icon with new icon.
33 (other comment)
Thanks
Great job on CSS. Looks real good.
34 (other comment)
Also delete UI old classes that are no longer used.
35 (other comment)
Good documentation. LGTM.
Thanks, let me merge it now
36 (other comment)
Add descriptions to CdCommand and Internal File Explorer.
@chuyiting (16 comments)1 (commented on others PR)
Please kindly help update my email, and for the others @cupofjoee, @petrickjerico, @ducbinh2611
Eddy Chu: e0418218@u.nus.edu
Thanks
2 (commented on others PR)
Want to check which test requires the usage of this. See if there is better solution.
3 (commented on others PR)
Does the empty string not match the VALIDATION_REGEX?
Is it possible to solve it by modifying the VALIDATION_REGEX>
4 (commented on others PR)
Good jobs! Thanks a lot.
5 (commented on others PR)
Please delete these flags here, haha.
6 (commented on others PR)
I think hasTime() ? getDateTime().get() : "" is better as it is better to show String rather than Optional[something].
7 (commented on others PR)
Would you think another class called EmptyFormat implements TimeFormat is better?
e.g.
public LocalDateTime check(String time) {
if (time.equals("")){
return null;
}
throw new TimeFormatException();
}
8 (commented on others PR)
Thanks a lot.
Sorry for the error.
9 (commented on others PR)
Great.
10 (commented on others PR)
May I check the reason for the system output here? If it is used for debug, maybe can just delete them.
11 (commented on others PR)
Can you slightly explain this part? Does the Quiz stop by running one more CorrectCommand and causes NullPointerException or IndexOutOfBoundsException? What is the scenario that the exceptions are thrown?
Thanks a lot~~
12 (commented on others PR)
Maybe you can leave the name of the command in the Command itself like the one in the ab3. I think that can avoid "magic string".
13 (commented on others PR)
Really like this decision of building RefreshCommand. Good job!!!!!!
14 (commented on others PR)
This is what I was worried about, when I was refactoring, I found out that the QuizModel cannot really be separated due to the strong coherence with the Flashcard.
Would you think adding one more layer of the Model (QuizFlashcardModel) would be a better structure??
15 (commented on others PR)
Maybe can trim the userInput before parting it, so that " quiz score flset" would still work.
Another thing to notice is that currently it is using rigorous check, for example quiz(space*2)flset: would not pass. This also happens in the Schedule.
Maybe we can develop a StudyBanana customised tokeniser ourselves to solve these problem.
16 (commented on others PR)
OHH, just too clarify, so the flow of usage is like,
quiz flset:1
=====> show the question
ans: my answer
=====> show the answer
correctCommand/wrongCommand
======> show next question or end the quiz if all flashcards have been iterated.
Am I correct?
17 (other comment)
Duplication.
18 (other comment)
LGTM, @petrickjerico, please help double check the file changed and merge it, thanks.
19 (other comment)
No pull request required for this tutorial.
20 (other comment)
Duplicate changes with #61. Close this PR as it used your master branch.
21 (other comment)
Functionality built.
22 (other comment)
Functionality built
23 (other comment)
Functionality built.
24 (other comment)
Functionality built
25 (other comment)
Functionality built!
26 (other comment)
Functionality built.
27 (other comment)
Functionality built.
28 (other comment)
Functionality built.
29 (other comment)
LGTM!
30 (other comment)
The description is very clear, thanks a lot. Sounds really great.
@amylzting (16 comments)1 (commented on others PR)
Would it be better if there was no need to generate default serial number here? As I feel it is an extra step before we get the actual serial number for the stock. I may have an idea of how to do it, and can help to work on it!
2 (commented on others PR)
Perhaps could remove this line as it seems it is not relevant!
3 (commented on others PR)
Perhaps it is not needed to show the path to the serial number sets book?
4 (commented on others PR)
This line is pretty long. Perhaps could break it down to improve code readability?
5 (commented on others PR)
Perhaps could break down into more readable statements. Seen a few times!
6 (commented on others PR)
As mentioned, perhaps it is possible to remove this method!
7 (commented on others PR)
Perhaps could make a new exception class for the duplicate source?
8 (commented on others PR)
Perhaps "stock" should be "serial number set"?
9 (commented on others PR)
Should "inputted" be "input" instead?
10 (commented on others PR)
Should this line follow the format of the others such as what is shown in "status message"?
11 (commented on others PR)
Should we standardise past tense / present tense? ("Update" vs "Added")
12 (commented on others PR)
Based on our last meeting, I think prefix for quantity to increment/decrement should be changed to "iq/"?
13 (commented on others PR)
I agree!
14 (commented on others PR)
One of the note can be removed.
15 (commented on others PR)
Probably could remove this line? As we defined same stock as having same name, serial number and source.
16 (commented on others PR)
This part should be the reason why the stock is not updated. Should put the bookmark here as well. The bookmark above is for stock with notes.
17 (commented on own PR)
Thanks! Have done so in newest commit.
@abdurrahmanfaqihiskandar (15 comments)1 (commented on others PR)
Isn't this supposed to be 1 to 6?
2 (commented on others PR)
You need to update to student for this file.
3 (commented on others PR)
I think can remove all the portfolio section. Since it's all johndoe.md
4 (commented on others PR)
Isn't this already handled by the FindCommandParser class?
5 (commented on others PR)
Yeah Andy is right. Hour is HH and minute is mm. Source
6 (commented on others PR)
shouldn't this be private not public?
7 (commented on others PR)
I think we can vary the values that VALID_ID has so that the test can be more comprehensive? If not all have the same value of 1, then the test only cover id of 1.
8 (commented on others PR)
I think should change the name of the variable to match the usage. To me it doesn't look nice ah.
9 (commented on others PR)
This one as well same as above. If im reading this correctly, the index is the index of the trainings shown. Should rename is accordingly. The exception in addstudentcommand also has this.
10 (commented on others PR)
Maybe "Trainings cannot be scheduled for dates that are past"? Or something like that?
11 (commented on others PR)
just a slight grammatical mistake: "a" not "an"
12 (commented on others PR)
Should it be called FindStudentTrainingCommand? Idk. This name sounds like you want all trainings instead of a particular student's training schedules.
13 (commented on others PR)
the variable name needs to be in caps.
14 (commented on others PR)
this one as well
15 (commented on others PR)
this one also
16 (commented on own PR)
okay! fixed it.
@sudogene (15 comments)1 (commented on others PR)
Ah that one is LICENSE, should stay as person
2 (commented on others PR)
@throws ParseException if the given {@code academicYear} is invalid.
3 (commented on others PR)
@yejiadong @kerkpy
4 (commented on others PR)
just need newline at EOF
5 (commented on others PR)
just need newline at EOF
6 (commented on others PR)
HHmm instead? Capital M is for month i think
7 (commented on others PR)
An UI component that displays information of a ...
{@code Training} ?
{@code TrainingSession} ?
{@code TrainingSchedule} ?
8 (commented on others PR)
Panel containing the list of training/training sessions/training schedules.
9 (commented on others PR)
Just putting a note here for myself
10 (commented on others PR)
I personally think removeAllTraining() or clearTraining() would be more coherent with the removeTraining method above, in terms of naming. It's more of an opinion only so you still make the final decision
11 (commented on others PR)
Id included?
12 (commented on others PR)
We putting training data in student json file too?
13 (commented on others PR)
use static string for this? INVALID_DATETIME_MESSAGE
14 (commented on others PR)
What if the idList contains repeated Id values?
15 (commented on others PR)
Will this class name be confusing since it sounds like adding student to the student list also (i.e. AddCommand)? Just wondering only
16 (commented on own PR)
Added that to prevent over-coupling with the parser (wanted to make PredicateList more stand-alone)
17 (commented on own PR)
I try to make Id test very standalone because it's mutable (keeps track of used Id values and auto increment for new students). So the TypicalStudents used in other tests will not be affected by Id's mutability and can safely just use a placeholder value (i.e. 1). But alright I can vary the values
18 (commented on own PR)
it's public like the other student field classes
19 (commented on own PR)
It's assumed here that there will always be the Id existing in the list, is there a scenario that this wont happen?
20 (commented on own PR)
yep thanks, shall do that. We see how this find by id goes, best is we abstract it to a util method
21 (commented on own PR)
nope, it's left here since AddStudentToTrainingCommandTest has not been updated to factor in this check
22 (other comment)
tp.do();
23 (other comment)
My bad, didn't open to reviews
24 (other comment)
Gonna merge
25 (other comment)
LGTM!
26 (other comment)
LGTM
27 (other comment)
LGTM
@therizhao (15 comments)1 (commented on others PR)
Don't think need to compare caloriesPerRep, since it is not an identifier field
2 (commented on others PR)
This property should be called value
getName().name sounds a bit unsemantic as the property name has the same name as class name (haha so many names)
3 (commented on others PR)
This test could be removed, see previous review
4 (commented on others PR)
Could rename to calories for clarity
5 (commented on others PR)
What do u mean by hardcoded here?
6 (commented on others PR)
should be setLogs?
need to fix the naming of the overloaded method below too
7 (commented on others PR)
should be find w/o s
can split this into 2 tests
find_state_expected
8 (commented on others PR)
Can split into multiple tests with format method_state_expected
9 (commented on others PR)
Can split into multiple tests
with format
method_state_expected
10 (commented on others PR)
Remember to change addressBookStorage to logBookStorage (same for the lines below)
11 (commented on others PR)
Should update to use LogBook
12 (commented on others PR)
Person -> Log
13 (commented on others PR)
Should be logBook
14 (commented on others PR)
LogBook for the return type
15 (commented on others PR)
Could we have just exercises as static instead?
16 (other comment)
Closes #17
17 (other comment)
Not needed anymore
18 (other comment)
lgtm
19 (other comment)
done
@kaitlynng (15 comments)1 (commented on others PR)
Maybe we can have an enum for TAB_ID instead to make it more clear.
2 (commented on others PR)
Will it be confusing to have TAB_ID in Command.java and tabId in CommandResult.java? Maybe more descriptive name like tabIdToSwitchTo can help.
3 (commented on others PR)
Should the command word be 'add' or 'add patient'? Since we've changed the AddCommand to AddPatientCommand, and we need to consider adding appointments too.
4 (commented on others PR)
Should rename 'Person' to 'Patient' (but I think this is model people's job)
5 (commented on others PR)
Since AddCommand was changed to AddPatientCommand, maybe ClearCommand should be changed to be more descriptive also? i.e. change to ClearAllPatientsCommand.
6 (commented on others PR)
Formatting issues, can put on the same line.
7 (commented on others PR)
I can't add a comment at the required line, but maybe we can rename this command to EditPatientCommand instead to align with AddPatientCommand? Also because we are probably adding capabilities or editing appointments right, so will need to clarify what we're editing.
8 (commented on others PR)
Will also need to remember to edit the MESSAGE_USAGE to reflect patient parameters.
9 (commented on others PR)
Likewise, should we rename to FindPatientCommand?
10 (commented on others PR)
Likewise, should we change this to ListPatientsCommand? I'm not very sure because then now we'll have the 'Patient' in every command which is a lot more verbose, but it also makes the command clearer.
11 (commented on others PR)
Why is PREFIX_REMARK removed?
12 (commented on others PR)
Maybe we should have RemarkCommand for both patient and appointment? so we split into RemarkPatientCommand and RemarkAppointmentCommand
13 (commented on others PR)
Remove testing print lines
14 (commented on others PR)
Changed implementation of UniqueAppointmentList to UniqueList (generic interface)
15 (commented on others PR)
AppointmentBuilder fields need to change to match new implementation of Appointment
@chuyouchia (15 comments)1 (commented on others PR)
Needs to be updated with new command word.
2 (commented on others PR)
Should be added already since functionality exists?
3 (commented on others PR)
Might be better to name as "deck mode" for consistency with the summary?
4 (commented on others PR)
Might be a good idea to get rid of the AB3 reference?
5 (commented on others PR)
it is a broken link - should be model/Model.java not ui/Model.java?
6 (commented on others PR)
should be Observable?
7 (commented on others PR)
Similarly, might be a good idea to remove AB3 reference?
8 (commented on others PR)
Update the add, delete and edit card to match the new syntax?
9 (commented on others PR)
should be would not, guide should be less verbal and more formal? (in language not tone)
10 (commented on others PR)
Missing pros and cons format?
11 (commented on others PR)
similarly, missing pros and cons format?
12 (commented on others PR)
"jaon" should be changed to "json" here?
13 (commented on others PR)
would be good to remove AB3 references?
14 (commented on others PR)
should be changed to card mode?
15 (commented on others PR)
similarly, should be changed to card mode?
16 (commented on own PR)
Done, thanks for the catch!
17 (other comment)
Delete Address Class from production and test code.
@rtshkmr (15 comments)1 (commented on others PR)
I think it's okay to init it for now. We could probably KIV this for further optimisations if it's ever a problem down the road?
I agree with the case when there will be many countries and this poses a real problem though.
Initialising probably makes for easy testing for now as well.
2 (commented on others PR)
So we were reviewing this PR together and found line 29 and 43 to be quite funny 😃
3 (commented on others PR)
@qwoprocks mentioned that having a one-way transfer of information from Clients to AddressBook is more complicated to implement and so to Synchronise the two set of tags, this method was chosen.
also may I suggest having a helper function called synchronizeTagSets()
4 (commented on others PR)
Might need to modify the name for this test method?
5 (commented on others PR)
might need to modify the name for this test method?
6 (commented on others PR)
might need to modify the name of this test method? It seems like it was aldy there from AB3, but should we still modify this method name?
7 (commented on others PR)
this is causing the checkstyle to complain.
Rayson and I talked about this. Two dudes actually had a convo about how many spaces to have 😆
____first line with 4 space indent
________thisis 8 space indent because 4+prev indent.
8 (commented on others PR)
CS2030 saves the day
9 (commented on others PR)
Thank you Rayson 👍
10 (commented on others PR)
This is an unused method for now, can't see where else it's used..
11 (commented on others PR)
Footer should probably be lowered to the bottom border right.
But fixing this isn't that impt for now since it's functional!
12 (commented on others PR)
alright will follow up on this once this PR is merged. my next task is delete command (at the least) before touching storage 👍
13 (commented on others PR)
I think this could be an unnecessary new line (line 146) or is it that there's supposed to be a blank line before return statements? 🤔
14 (commented on others PR)
is 159 an extra newline?
15 (commented on others PR)
this is really nit-picky of me, but I suggest naming it countryToCountryNotesMap to reflect the plurality of the country notes in the set and be similar to the init method name.
private final Map<Country, Set<CountryNote>> countryToCountryNotesMap;
16 (commented on own PR)
The extension is specific to step 2 of the MSS ("TBM shows a list of clients that match user's query"), hence the extension should be named 2a instead of 1a isn't it?
edit: yeap, the suggestion by ming chong is correct, I'll change it to what he suggested, ref to this for similar example, the "error" check happens after the actor (user) submits:
17 (commented on own PR)
alright, originally copied from our hackmd document, which seems to be out of date based on what you pointed out
18 (commented on own PR)
list is an AB3 command, I didn't add that in actually. Instead, I copied over from our HackMD file what I had to add in.
that's why person persisted and wasn't changed to clients
I'll just remove it and update this PR
19 (commented on own PR)
done
20 (commented on own PR)
done, put it as "User Guide" and "Developer Guide" for now
21 (commented on own PR)
this was unintended, but i'll just leave it there for now
22 (commented on own PR)
took it out
23 (commented on own PR)
this was left as is because in the future, we probably should improve the regex pattern matching (as per the screenshot I sent about kang liang's suggestion)
have added a todo to this to keep note of it
24 (commented on own PR)
agreed! admire your meticulous eye a lot @qwoprocks
25 (commented on own PR)
Added todo, changed to LinkedHashSet
26 (commented on own PR)
I have the same understanding as @qwoprocks that everything has to go thru the model, that's why I left this
27 (commented on own PR)
done!
28 (commented on own PR)
done
29 (commented on own PR)
yeap, done
30 (commented on own PR)
done!
31 (commented on own PR)
updated with an autogenerated hashCode()
32 (commented on own PR)
I've asked Rayson before modifying the CountryManager 🦺
33 (commented on own PR)
I think this is useful. Then can filter by untagged notes and do other actions based off that.
e.g. edit an untagged note at a later time after filtering notes based on the "untagged" tag
34 (commented on own PR)
was sitting on it because this depended on Rayson's Country class. Will add this part in since he's done.
35 (commented on own PR)
To be honest, I didn't know the benefits/use cases of using unmodifiable objects until your comments on this PR. I've done a cursory read up on it, thanks!
getCountryNote was put to retrieve note associated to a country, to be used when the TagNoteMap shall be initialised from countries. This is related to the commented out initialisation method inside TagNoteMap, will be used in a later commit 👍
36 (commented on own PR)
Followed your suggestion. Will test using the GUI instead of just using automated tests so that I don't overlook such things henceforth.
As usual, I'm amazed by your sharp eye in catching these things 😃
37 (commented on own PR)
👍 changed it
38 (commented on own PR)
currently we have a 1-way dependency between notes and tags. This method existed for the case in the future when this dependency would have been removed. Since we're accepting this 1-way dependency for now, this should method should be removed but might be required in the future, hence I'll put the method here for reference:
/**
* Links a new set of notes to a tag. This method exists in the case where we remove
* the one-way dependency b/w tags and notes, then we'd need to use this.
*
* @param newNotes The notes to associate with a particular tag.
* @param tag The tag to associate the notes with.
*/
public void updateNotesForTag(Set<Note> newNotes, Tag tag) {
requireAllNonNull(newNotes, tag);
noteSet.addAll(newNotes);
// update the tags set for each of the notes:
for (Note newNote : newNotes) {
if (noteToTagsMap.containsKey(newNote)) {
noteToTagsMap.get(newNote).add(tag);
} else { // new note:
Set<Tag> tags = new HashSet<>();
tags.add(tag);
noteToTagsMap.put(newNote, tags);
}
}
//update the notes set for the tag:
Set<Note> currentNotes = tagToNotesMap.getOrDefault(tag, new HashSet<>());
currentNotes.addAll(newNotes);
}
39 (commented on own PR)
Pls let me leave this here 😢 . IMO it improves readability in the user input variables later in the tests.
40 (commented on own PR)
added reason for the public access but I've also added a todo because I expect changes to this after storage is done.
41 (commented on own PR)
I've updated it to follow the naming standards.
42 (commented on own PR)
this is a moot point for now, it's relevant when deleting/updating a note and the TagNoteMap has to be updated
43 (commented on own PR)
Quite a few TODOs and stray comments. I think a follow-up issue can be created to cleanup the todos and stray comments.
Just wondering, what is the main purpose of having
TagNoteMapclass? Is it so that it would be easier to query for notes based on a given set of Tags? Because it seems like additional work to "sync" tags with notes and it might be quite error-prone if the syncing is not done right. Any thoughts @qwoprocks ?
@raysonkoh actually the implementation @rtshkmr did was a bit off from what I had in mind, the tagnotemap is actually supposed to be the one being passed down from logic manager to the parser to create the tags, so there would no need to do the syncing stuff. @rtshkmr isit alright if i just push to this PR and implement that?
let me clean it up based on both your comments first
44 (commented on own PR)
resolved, added mention of uniqueTagMap
45 (other comment)
I learnt that just adding into .gitignore won't automatically untrack previously tracked files!
46 (other comment)
Made a mistake by creating my branch-README-... from an existing branch: DG update... that's why there are two commits for this PR when there should be 1. I'm putting this comment here as a reminder to myself for the future.
47 (other comment)
LGTM
48 (other comment)
ignore this issue creation
49 (other comment)
LGTM! TagFactory looks good too 👍
50 (other comment)
Agree with the code quality aspects pointed out by @qwoprocks if we go by what the textbook outlines for static final variables.
Premature optimisation might be unnecessary for now, but it's a minor aspect imo, @raysonkoh should make the design decision on this.
51 (other comment)
Quite a few TODOs and stray comments. I think a follow-up issue can be created to cleanup the todos and stray comments.
Just wondering, what is the main purpose of having
TagNoteMapclass? Is it so that it would be easier to query for notes based on a given set of Tags? Because it seems like additional work to "sync" tags with notes and it might be quite error-prone if the syncing is not done right. Any thoughts @qwoprocks ?
for the comments & TODOs: I'll add an issue for this and resolve it as I'm doing the delete, update and storage aspects
for the purpose behind this class:
52 (other comment)
ignore this PR. The draft PR #203 was mysteriously merged to master (suspect it was a github bug because of the machine's time at that period being incorrect) but @qwoprocks got to see it still. so I'll just be adding a new PR for test updates and leaving the merged situation as is.
@Nikhilalalalala (15 comments)1 (commented on others PR)
Do we have to do com.eva.storage.StorageManagerTest
2 (commented on others PR)
Should this be com.eva.Model#getAddressBook instead
3 (commented on others PR)
I think same issue as above, no need "CliSyntax" since it is imported already
4 (commented on others PR)
Same issue here as above
5 (commented on others PR)
Same issue here as above
6 (commented on others PR)
Do you want to change the name of Comments to something like CommentList so that it is more clear that this is a list of comments
7 (commented on others PR)
I think you need to change the javadocs here
8 (commented on others PR)
Was thinking if this can be given a more informative name like startDate
9 (commented on others PR)
same for 'to' maybe endDate
10 (commented on others PR)
Was thinking if this can be improved to maintain the same level of abstraction as before, by constructing the Leave object with public Leave(LocalDate from, LocalDate to) because in other cases for example,
Add Person, the text input goes from Logic --> AddressBookParser --> AddCommandParser and this is where the Name, Email, Address Objects are made, then these objects are passed into AddCommand and is then passed into Model to add the person.
I think this change does not make a difference logic wise, but helps make the level of abstraction more standard. But up to you to take it up.
11 (commented on others PR)
Alright sure, I agree with your reasoning, Thank you! Great job 😃
12 (commented on others PR)
Would it be better to change this to use like the standard requireNonNull(personToEdit) as used in all other places?
And perhaps, you could import the whole CommentCommand?
13 (commented on others PR)
Perhaps you could use the same requireNonNull function like in other places
And is there a way to just import the CommentPersonDescriptor instead of calling it by CommentCommand.CommentPersonDescriptor
14 (commented on others PR)
Minor, but the javadoc is a little misleads readers to think the specific leave object that is conflicting will be returned.
15 (commented on others PR)
Minor, Good to specify if the list returned is inclusive or exclusive of the start and end date
16 (commented on own PR)
Yes, I just added it like this as of now, will adapt once new ui is pushed.
17 (commented on own PR)
Hmm yea, noted about this from previous PR, will try to figure out some time to do this, thanks for reminding!
18 (commented on own PR)
Sure!, we can discuss in upcoming meeting to standardise this.
19 (other comment)
LGTM!
20 (other comment)
LGTM!
21 (other comment)
LGTM!
22 (other comment)
LGTM! Just one small comment. I think we can just stick to dates first? Or do you guys want to include timings as well.
Yeah, I think we can stick to dates first and build upon timings at a later stage.
23 (other comment)
LGTM!
24 (other comment)
LGTM!
25 (other comment)
LGTM! One small comment, but otherwise is great 😃
26 (other comment)
LGTM! The changes Ben advised on interviewdate, naming from person to staff and addressbook to eva, I will implement them in my next pr.
27 (other comment)
Looked through the files changed, I think all looks good and like you mentioned, since leave also heavily uses dates we can change the prefixes to a generalised date prefix.
28 (other comment)
LGTM! Nice job on adding the numbers in the DG, makes it clearer for readers.
29 (other comment)
LGTM! Just some minor comments on the javadocs part. Nice observation on this bug 😃
@timjkong (14 comments)1 (commented on others PR)
i think this is ok but we should have a command to edit start and end date within travel plan directory also if not it might be a bit confusing
2 (commented on others PR)
can change person to activity
3 (commented on others PR)
can change person to activity
4 (commented on others PR)
rename p to activity?
5 (commented on others PR)
person to activity
6 (commented on others PR)
AddressBook change to ActivityList?
7 (commented on others PR)
addressbook change to activity list?
8 (commented on others PR)
address book change to friend list?
9 (commented on others PR)
Returns true?
10 (commented on others PR)
AddressBook change to WishList?
11 (commented on others PR)
change person to activity
12 (commented on others PR)
person change to activity, addressbook change to wishlist
13 (commented on others PR)
addressbook change to wishlist
14 (commented on others PR)
think you accidentally added 'a'?
15 (other comment)
Also added delete command to user guide. Not sure why it wasn't there? Maybe got removed accidentally.
@yejiadong (14 comments)1 (commented on others PR)
Might want to fetch the updated UserGuide.md to paste here, as it was edited and merged yesterday to resolve some docu bugs (e.g. address here is removed)
2 (commented on others PR)
Think can change the email here to one of our email addresses
3 (commented on others PR)
minor spelling of "the"
4 (commented on others PR)
@sudogene actually yes, each student will also store the dates of trainings assigned to them, so should be in their json too, we can look at this again after the add student to training command is added
5 (commented on others PR)
might be better to use getters to get the dismissalTime instead of accessing the variable directly
6 (commented on others PR)
shouldnt this be true, since if the training is scheduled on saturdays and sundays, student will always be able to make it?
7 (commented on others PR)
think might be clearer for AddStudentToTrainingCommand since AddStudentCommand can be confused with adding a student
8 (commented on others PR)
DeleteStudentFromTraining might be feasible here
9 (commented on others PR)
Might need to remove/add the LocalDateTime from/to the student's training schedule treeSet container as well, feel free to use the methods alr implemented in student class for this, so that student training schedule panel will update too
10 (commented on others PR)
might want to remove the prints here
11 (commented on others PR)
if studentsList empty, is it safe that .get() will not throw a null pointer error?
12 (commented on others PR)
makes sense, but might be good to include an assertion here in case of code changes in future
13 (commented on others PR)
is this part removed?
14 (commented on others PR)
small typo here - part of its schedule
15 (commented on own PR)
Fixed.
16 (commented on own PR)
Changed to removeAllTraining()
17 (other comment)
With exception of documentation/logs, all person class instances have been changed to student.
18 (other comment)
Pending checkstyle/intelli-j checks/edits as PR merge conflicts were resolved on Git
19 (other comment)
Duplicate of #17
20 (other comment)
Duplicate of #17
21 (other comment)
Duplicate of #24
22 (other comment)
Duplicate of #24
23 (other comment)
Once the final methods necessary are confirmed, tests will be incorporated at the end.
24 (other comment)
ok to review?
@dianneloh9 (14 comments)1 (commented on others PR)
Would getBidderList() be a better name? So that when you call this method, you know that you are getting a bidder list and likewise for seller list. What do you think?
2 (commented on others PR)
Should this be "add -bid" with a space in between so that it's more standardised? Likewise for "list -bid".
3 (commented on others PR)
Should property prefix be "p" instead? Then bidder id be prefixed "b".
4 (commented on others PR)
I think it may be easier to check at the BidBook / UniqueBidList level (or even AddBidCommand, I'm not sure where is the best place yet), so that Bid does not know about PropertyBook. Maybe can think about this further in the future, but for now it's okay since other stuff is not done yet.
5 (commented on others PR)
removeBidder?
6 (commented on others PR)
Good idea. I think we should all do this.
7 (commented on others PR)
MeetingManager?
8 (commented on others PR)
merge this with setTabBar()
9 (commented on others PR)
Can remove this line
10 (commented on others PR)
Should organise by the comment headers
11 (commented on others PR)
Nice catch
12 (commented on others PR)
Can use static variables here, eg PREFIX_PAPERWORK = "p"
13 (commented on others PR)
Very small issue but MESSAGE_DUPLICATE_BIDDER?
14 (commented on others PR)
Naming could be better perhaps
15 (commented on own PR)
Thanks Marcus. Yes this part is redundant, will delete it.
16 (commented on own PR)
Good suggestion. I have incorporated this in the newest commit.
17 (commented on own PR)
I am not sure exactly how these json creators work but I think they need to be stored as a String because of the json format. And it is the same format as the original AB3's implementation. I am not very sure though.
@rolandyuwy (14 comments)1 (commented on others PR)
I suggest changing this to .png according to the specifications. Similarly, change to file itself to .png too.
2 (commented on others PR)
Perhaps "Expiry dates should be of the format d-MM-yyyy, dd-MM-yyyy, d/MM/yyyy or dd/MM/yyyy." might be more accurate?
3 (commented on others PR)
Very minor, should be "an" instead of "a".
4 (commented on others PR)
Nice touch to order alphabetically.
5 (commented on others PR)
This should be "Returns true if a given string is a valid priority level"
6 (commented on others PR)
A little odd to change to lower case before validation checks. Maybe only do so in line 30 (i.e. switch(priority.toLowerCase())?
7 (commented on others PR)
Just to standardize with the other fields: "Priorities should be either high, medium or low.";
8 (commented on others PR)
Perhaps you can consider using a switch statement? Just a suggestion.
9 (commented on others PR)
I understand, you are converting the input to lower case then performing validation checks on them. Then there is no need to change.
10 (commented on others PR)
Perhaps to standardize with line 91, considering using 'MEDIUM' priority?
11 (commented on others PR)
We should probably decide to standard formatting for grammar here. Would "4 valid predicates" be better than "4 valid predicate"? Or predicate objects?
12 (commented on others PR)
I think it should be "all of which implement"
13 (commented on others PR)
Let's standardize '1' to 'one'.
14 (commented on others PR)
Similarly for Alternative section
15 (commented on own PR)
Yes this step is redundant
16 (commented on own PR)
I believe the definition here is required, since use cases have System and Actor(s), here we say we are using SimplyKitchen to represent our System.
17 (commented on own PR)
Good catch!
18 (commented on own PR)
Sure thing, I'll make the changes.
19 (commented on own PR)
Sure thing, I'll make the changes.
20 (commented on own PR)
Sure thing, I'll make the changes.
21 (commented on own PR)
I see. I will leave these sections to be updated as the diagrams require changing in the future too.
22 (commented on own PR)
Good catch
23 (commented on own PR)
Thanks!
24 (commented on own PR)
Thanks!
25 (commented on own PR)
Thanks!
26 (commented on own PR)
Thanks!
27 (commented on own PR)
Thanks!
28 (commented on own PR)
Thanks!
29 (commented on own PR)
Thanks!
30 (commented on own PR)
Thanks!
31 (commented on own PR)
Noted, thanks!
32 (other comment)
LGTM
33 (other comment)
LGTM!
34 (other comment)
LGTM!
@chunyongg (14 comments)1 (commented on others PR)
I interpreted step 2 as confirmation message (success message); is this what you intended? To redirect to 2 if there is incorrect input?
(Because the google docs says resume at step 1)
Applies to all the other use cases too
2 (commented on others PR)
Javadocs to be updated {@code Person}
3 (commented on others PR)
Same for this, perhaps this is MESSAGE_DUPLICATE_GROUP?
4 (commented on others PR)
Is this to check whether PREFIX_PATH is present?
5 (commented on others PR)
Should this be removed?
6 (commented on others PR)
Modify javadocs
7 (commented on others PR)
Are you calling Serenity() ? (empty constructor)
8 (commented on others PR)
Empty constructor
9 (commented on others PR)
This feels very similar to equals()
10 (commented on others PR)
This cannot be deleted (their requirements)
11 (commented on others PR)
This too
12 (commented on others PR)
Consider using student.containsStudent(toMakrAtt) instead of running studentsInfo.get(i) again
13 (commented on others PR)
Consider using immutable design?
14 (commented on others PR)
Are these comments still needed?
@cwenling (14 comments)1 (commented on others PR)
this should be email address
2 (commented on others PR)
should the repository link in line 11 be changed as well?
3 (commented on others PR)
might be more intuitive if the variable name is the same as the task name?
4 (commented on others PR)
this function works in Tr4cker too. maybe we should keep the corresponding version of this line?
5 (commented on others PR)
this might be an extra line
6 (commented on others PR)
might want to surround the "prepare for tp tasks" with quotation marks
7 (commented on others PR)
may want to keep the t in task as lowercase
8 (commented on others PR)
should this keep the private access, and methods that use this call fromZeroBased(int) or fromOneBased(int) ?
9 (commented on others PR)
would it be better to wrap the date time inside deadline with another class. so that we can just .dateTime instead of calling toString()
10 (commented on others PR)
could name it MESSAGE_FUTURE_CONSTRAINS to be clearer
11 (commented on others PR)
could these 2 if blocks be abstracted out? perhaps a method to check if the dayOfDeadline is contained inside the hashmap
12 (commented on others PR)
if ur checking separately for TODAY, perhaps TODAY does not need to be inside the hashmap?
13 (commented on others PR)
should be named getTr4cker_success() or something that implies test
14 (commented on others PR)
should these be changed to VersionedTr4cker too?
15 (other comment)
Merged #19
16 (other comment)
Merged #12
@Criss-Wang (13 comments)1 (commented on others PR)
Should the ... be inside the [] ?
2 (commented on others PR)
Is it possible to have both predicates in the constructor? Maybe we need 2 overloaded constructors, or we can test on cases where both predicates are added?
3 (commented on others PR)
Similar to the idea above, the presence of null here may no be so desirable.
Perhaps we can consider reduce the use of null here in future iterations?
4 (commented on others PR)
Is there any way to reduce code duplication in this case? Like defining the abstract predicate class?
5 (commented on others PR)
Perhaps you can try putting in multiple products within a particular supplier?
6 (commented on others PR)
Maybe we can consider more parsing failure tests later?
7 (commented on others PR)
Thanks for the correction, didn't realize this 😃
8 (commented on others PR)
The delete command is now delete ct/s i/12
9 (commented on others PR)
I feel the prefix part looks a bit similar to the edit command's reasoning (and maybe can be used in other commands as well), will it be too repetitive?
10 (commented on others PR)
maybe we can further specify it is by the "name" of the products sold/stored
11 (commented on others PR)
I feel like this second sentence is a bit of repeat with the and/or in the first sentence, maybe we can just remove the and/or in the first sentence?
12 (commented on others PR)
should it be "the last argument value" instead of "the last prefix"?
13 (commented on others PR)
Do you mean the Set>Product> is identical to the existing product set here?
14 (commented on own PR)
Thanks for the suggestion, will modify it!
15 (commented on own PR)
Thanks for spotting the error!
16 (commented on own PR)
ld try to make the explana
May I know what do you mean by making the explanation consistent?
17 (commented on own PR)
Thanks for the suggestion, your are right!
18 (commented on own PR)
Actually I'm not sure if it is desirable format, maybe we can discuss after everything is done with their version of Message so we unify .
19 (commented on own PR)
This is just a styling for the parameter name targetIndex so I suppose it's okay
20 (commented on own PR)
I think in AB3 they mean argument name. So this part is probably okay
21 (commented on own PR)
Thanks for the suggestion, will take that into account!
22 (commented on own PR)
I think this is covered in the delete supplier/warehouse part, I can add this test again later if needed, thanks for the comment!
23 (commented on own PR)
I see, that's actually a typo also haha, thanks for pointing it out!
24 (commented on own PR)
Oh thanks!
25 (commented on own PR)
Thanks for the typo fix!
26 (commented on own PR)
Oh yah I mean Product here, thanks a lot!
27 (commented on own PR)
Actually both the product and the set are kinda "Retrieved" haha. I think I will change it to "the retrieved product will be removed from the current product set" then!
28 (commented on own PR)
Thanks for raising this issue up, I also notice that I should use warehouse/supplier here. so I change it to "The selected warehouse/supplier entry in the model is then replaced by the updated warehouse/supplier with the target product deleted."
29 (commented on own PR)
I guess I was referring to the particular success message with the delete command. Anyway I think your suggestion looks clearer to readers, thanks!
30 (commented on own PR)
Currently it's just the arePrefixesPresent method, I found quite a few overlap among the command parser classes. Guessing it is a common utility method.
31 (commented on own PR)
Actually for the execute method, we first classify into supplierRelated and warehouseRelated. Afterwards in the supplierRelated executions, we need to split into supplier deletion and product for supplier deletion. That's the purpose of this if statement here.
32 (commented on own PR)
Yah let's do it in our discussions then.
33 (other comment)
Noted, will fix the issues mentioned in next pull request! Thanks!
34 (other comment)
Good thoughts, I believe handling upper/lower case conversion on our end would improve user experience instead of making it case-sensitive. Especially when they are not able to correct minor typo by retrieving last typed command using the up arrow key like we do in terminals.
You're right, I just tried for add command and it process everything but only keeps the results from the last occurrence. This is a bug and should be resolved unless a command explicitly takes in 2 of the same prefix. Good catch Zhen Lin.
I would think that redundant arguments can be safely ignored if they do not interfere with the given command. We can set up a response that notify them of the
random stringwhile letting the command run through. This would be even more useful when we implement undo and redo commands.
Thanks Jeffery for the response!
For the first point, I guess if we all agree on this, we can discuss in chat about the implementation detail (like whether to handle it in general parserUtil or somewhere else)
For the second point, thanks and I'm guessing we also need to mention this in our user guide & Usage message if we treat this issue as a bug.
For the third point, I think your suggestion is wonderful! We can also discuss later about the message format, etc.
@Marcon2509 (13 comments)1 (commented on others PR)
i dont think this is where you save the property book
2 (commented on others PR)
cause it only gets saved on exit but rmb for things like ip how they want to make sure if your application gets suddenly closed it will save till the last previous excuted command. I think me and Ms save it in one of the parser or managers
3 (commented on others PR)
oh yeah its here lol
4 (commented on others PR)
Seems ok but curious what scenario would you need to add in a Person instead of a bidder in the unfiltered bidder list predicate?
5 (commented on others PR)
What does client person do? I tot only got bidder and seller and person or is this diannes thing for property
6 (commented on others PR)
We shud prob rename some of the variables to remove person and have a more general name like TabPanePlaceHolder
7 (commented on others PR)
Prob need to rename variables to remove person
8 (commented on others PR)
Question: Does this affect all the list or a specified list?
9 (commented on others PR)
maybe have a more descriptive Success message like "Edited bidder: From [%1$s] to [%2$s]"
10 (commented on others PR)
Since it now a propertyId should this be string or propertyId. shud we make a file for all default stuff
11 (commented on others PR)
whats the point of getting the .toString if you are just gonna put it pack into the modelPropertyId. Why not just check if the propertyId of type PropertyId instead of String contains null then it throw exception
12 (commented on others PR)
like still can but idk if considered redundant or not
13 (commented on others PR)
wait why is their a commented out bit so if the entity type is Meeting it does nth?
14 (commented on own PR)
ok will edit accordingly
15 (commented on own PR)
i put b/ for now since there is the prefix PREFIX_PHONE using it but it shouldnt be a problem
16 (commented on own PR)
oh reason why i left out the white space is that the parser is looking for one word but adding the space counts it as 2 word and cannot detect it as a add bid command
17 (other comment)
Please check thoroughly i have only added the basic functionality and it involves editing the UI so might have clashes. Also my branch was super outdated like before mingsoon revoed email and address so might have clashes there
@murtubak (13 comments)1 (commented on others PR)
Maybe we could add an output method for whoever is doing the "View Module" portion.
2 (commented on others PR)
Is this just for short form?
3 (commented on others PR)
We should discuss what predicates to use for this class
4 (commented on others PR)
This test is not updated for additional info added to Module like Grade Tracker which I recently added. I will update this in the future.
5 (commented on others PR)
Also not updated for new info in the Module class, will update in the future commits
6 (commented on others PR)
Also needs updating for additional info put into module.
7 (commented on others PR)
I think we should find what other ways we can implement non-static init blocks.
8 (commented on others PR)
Can addcontact take in only the name without taking in the email and telegram? If it is a valid operation, I think these two lines of code might return null? Not so sure about this
9 (commented on others PR)
We should do boundary value testing for this in the future
10 (commented on others PR)
Could either elaborate on these parameters or remove them.
11 (commented on others PR)
Maybe we should re implement PrefixPosition in the future.
12 (commented on others PR)
Maybe there should be a description for the Javadocs of this constructor
13 (commented on others PR)
Should this be @code comparator instead of @code predicate?
14 (commented on own PR)
Thank you for the comment. Agree with you, and have submitted new changes.
15 (commented on own PR)
Thank you for the comment. Have submitted changes for this.
16 (commented on own PR)
Agree with you, have made changes accordingly.
17 (commented on own PR)
Ok, sounds good.
18 (other comment)
Poor Pull Request with too many conflicts to merge easily. Will resolve conflicts and make a separate pull request
19 (other comment)
Theres a conflict to resolve with the MainApp file before merging, otherwise LGTM.
20 (other comment)
I think version 1 is most suitable.
@caitlinjee (13 comments)1 (commented on others PR)
The column title already has "so that I can", the "I can" in some of the rows are repetitive?
2 (commented on others PR)
"I have" can change wording to match the "so that I can..." form?
3 (commented on others PR)
Same with previous, should change the "the app is open source..." to fit the "so that I can..." form?
4 (commented on others PR)
I think it should be fridge!
5 (commented on others PR)
I think you missed the return on this?
6 (commented on others PR)
This test can't work?
7 (commented on others PR)
Same question with previous test
8 (commented on others PR)
Same as previous tests
9 (commented on others PR)
Same as previous tests
10 (commented on others PR)
Same as previous tests
11 (commented on others PR)
should we write the whole proper command?
12 (commented on others PR)
dont forget to change recipe to recipes
13 (commented on others PR)
same as previous, full command?
14 (commented on own PR)
yes brief explanation, but will change if need
@florenciamartina (12 comments)1 (commented on others PR)
Perhaps it is better to rename the set to "professors"?
2 (commented on others PR)
Perhaps it is better to change this to "ModuleName" to avoid confusion?
3 (commented on others PR)
Perhaps it is better to change this into ModuleCode instead?
4 (commented on others PR)
I think it is better if the error message is "Operation would result in duplicate modules".
5 (commented on others PR)
You are right, I think just leave it as "persons" for now.
6 (commented on others PR)
LGTM for me 👍
7 (commented on others PR)
Perhaps you can change this to UniqueModuleList for the sake of consistency? (since it is UniquePersonList for Person) 😄
8 (commented on others PR)
Minor problem, but should this be MESSAGE_MODULES_LISTED instead?
9 (commented on others PR)
Should this be ".. to show only the module at the given.." ?
10 (commented on others PR)
May I ask what is the "final" modifier for? 😅
11 (commented on others PR)
Do you think it's better if the variable name is changed into "moduleToSet"? 😄
12 (commented on others PR)
Cool, thanks for the clarification!
13 (commented on own PR)
You are right, I forgot to change it! 😅
14 (commented on own PR)
I'll change it to FaculType instead.
15 (commented on own PR)
alright!
16 (commented on own PR)
Make sense. I'll change that.
17 (commented on own PR)
I have made some changes. Can you check it again? thanks.
18 (commented on own PR)
Got it. Will change it.
@lamlaaaam (12 comments)1 (commented on others PR)
Parameter of withAnimal is an Animal object. Suggest to change "Harambe" to "harambe" to fit naming conventions.
2 (commented on others PR)
I assume this was for debugging? Suggest to remove or if need be, change to a logging statement.
3 (commented on others PR)
.equals() for string comparision.
4 (commented on others PR)
This shouldn't be initialized to a new ZKB I think, just declare the variable.
5 (commented on others PR)
What is this isEmpty for? Looks a little out of place.
6 (commented on others PR)
Can we just give the redo stack a getSize() or isEmpty()? Otherwise this boolean is like dangling out of nowhere.
7 (commented on others PR)
I think don't need to reference names.
8 (commented on others PR)
I think no need to re-explain the Undo portion, just refer the reader to the above section. Just skim it over here and focus on Redo.
9 (commented on others PR)
For consistency, name methods in form Class#method(parameter). e.g. ParserUtil#parseFeedTimes()
10 (commented on others PR)
Typo in "chronological".
11 (commented on others PR)
Missing a period at the end.
12 (commented on others PR)
Parameters should be class names.
13 (other comment)
Unit tests should also be double-checked to conform to specifications for ID.
14 (other comment)
Unit tests for emails should also be removed.
15 (other comment)
Unit tests should be double-checked to conform to species field specifications.
16 (other comment)
Fails code coverage since new lines added are not covered by tests.
17 (other comment)
It's only Malcolm's picture I think. So he has to crop and reupload. Follow the dimensions given in the week's project tab.
18 (other comment)
Shall we just rename it to ZooKeep since it's our app name?
19 (other comment)
Is this the same issue as #79 ?
20 (other comment)
Just curious if it is necessary to have an UpdateStack when implementing redo. Would it be cleaner to have the current HistoryStack hold a redo stack?
This inherently guarantees redo only works after undo, since only an undo operation pops the HS and pushes state into RS.
@yanbingtao (12 comments)1 (commented on others PR)
maybe we should include the brand of the milk tea shop here also? as some function are only for TGER SUGER brand
2 (commented on others PR)
I think we should still use this prefix, to distinguish the input is either a name or a tag or something else.
Same applies to below, line 57
3 (commented on others PR)
there is a white space before "ingredient", I think it should be a typo and need to be removed?
4 (commented on others PR)
Maybe can consider to shift this point up, can put after the first point? It flows more naturally.
Maybe the second sentence can change to something like this? -> "This application is tailor-made for bubble tea shop managers, to help them on store management."
5 (commented on others PR)
Maybe can write down the full name for CLI (Command Line Interface)? In case some users don't know what CLI stands for.
6 (commented on others PR)
Maybe can consider to shift this row up to line 265? so that we can group all priority 1 & 2 together
7 (commented on others PR)
I think we should still use this prefix ("n/", "p/", etc), to distinguish the input is either a name or a tag or something else.
8 (commented on others PR)
Yup, should keep both. "e/" for emergency contact, "p/" for employee's contact number.
9 (commented on others PR)
I'm not sure if "set" is a prefix and need to add into here. Based on my understanding, we only need to add new prefix when we need to create a new field in a person model. Like if we create a field to record remarks, then we need to add "r/" as a prefix. But "set" does not function in this way. When user key in "set ...", then program will execute the "set", not to add the values behind to a field.
Please correct me if I'm wrong, thanks 😃
10 (commented on others PR)
Maybe you could consider using case structure here? It looks clearer, but if is working perfectly. 👍
11 (commented on others PR)
You may want to change this part to if (AAA && BBB) to avoid the deep nesting? Thanks
12 (commented on others PR)
👍
13 (commented on own PR)
Good point! Resolved, thanks (:
14 (commented on own PR)
Removed. Thanks (:
15 (commented on own PR)
Sure, just added. thanks
16 (commented on own PR)
Good point, just added in. thanks
17 (commented on own PR)
Okay, I've added that in. Thanks!
18 (commented on own PR)
Thanks for pointing out! Will edit it and change it in the next iteration.
19 (commented on own PR)
Thanks! I've changed that.
20 (commented on own PR)
Sure, I've added that. Thanks!
21 (commented on own PR)
Sure, I've added that. Thanks!
22 (commented on own PR)
Sure, I've added that. Thanks!
23 (commented on own PR)
But I think normally for variable names, we should use a noun. And only for method, we use something starting with a verb, like isArchived. So I think here, archiveStatus should be used (: Thanks!
24 (commented on own PR)
Thanks for pointing out, will change it.
25 (commented on own PR)
yup, will delete this line away, thanks!
26 (commented on own PR)
Will change this part, thank you!
27 (commented on own PR)
Yes! that will be better, thanks!
28 (commented on own PR)
Thank you!
29 (other comment)
LGTM
30 (other comment)
LGTM
31 (other comment)
LGTM
32 (other comment)
LGTM
33 (other comment)
LGTM
34 (other comment)
LGTM
35 (other comment)
LGTM
36 (other comment)
LGTM
37 (other comment)
LGTM
38 (other comment)
Exit feature has already been implemented in tCheck.
39 (other comment)
Auto-saving feature has already been implemented in tCheck.
40 (other comment)
Delete command has already been implemented in tCheck.
41 (other comment)
Add feature has already been implemented in tCheck.
42 (other comment)
Find feature has already been implemented in tCheck.
43 (other comment)
Task has been done, and code has been merged to master branch.
@GabriellaTeh (12 comments)1 (commented on others PR)
you forgot to change the prefix, i think it should be type:
2 (commented on others PR)
I dont think addressbook should be changed to typebook
3 (commented on others PR)
This one also, should not change addressbook to typebook
4 (commented on others PR)
this one also, should not change
5 (commented on others PR)
this should be dateTime
6 (commented on others PR)
Should be "constructs an empty DateTime when user does not provide the dateTime field
7 (commented on others PR)
comment should be dateTime
8 (commented on others PR)
Comment should be invalid dateTime
9 (commented on others PR)
this comment also
10 (commented on others PR)
should DEFAULT_DATE_TIME
11 (commented on others PR)
should be dateTime instead of Phone
12 (commented on others PR)
Not sure if it is just me but i usually write thursday as 'thurs' in short from but it must be 'thu' for the input. Maybe can make it clearer?
13 (other comment)
For use cases for list, add, delete, it should be task not person.
14 (other comment)
Also currently the message says that the lesson is added when the end date can be set before the start date, but it does not show up on the list. Should change the output message
@kkangs0226 (12 comments)1 (commented on others PR)
Not sure if it matters, but since the code does not use ProjectBook class it might be better to put @link seedu.address.model.ProjectBook in the comment instead of importing it
(Which is what they did for AddressBook) → to discuss with team
2 (commented on others PR)
Other than this (+ a few things that Praveen has mentioned), LGTM to me!!:>
3 (commented on others PR)
I think should have empty line here??
4 (commented on others PR)
Not sure if I understood your TypicalWorkDuration class fully, but is it comparing different projects here?
5 (commented on others PR)
I think we should standardise to FIND_ALL_MATCH and FIND_ANY_MATCH for uniformity since filter might be confusing/misleading
6 (commented on others PR)
Yup, I think there is no need to put this method under Project. We can just keep it in Deadline!
7 (commented on others PR)
I think this is a good suggestion, you can remove the hasDeadline() method by doing this!
8 (commented on others PR)
I agree with Praveen, i think we can move it over to StringUtil
9 (commented on others PR)
Do the others think it would be a problem that the time for deadline is not checked against created time? I know we are not saving the created time and this would mean we would need to make changes to the created date to include time but I feel like if we are checking the date, we should be checking the time as well. What do the others think?
10 (commented on others PR)
I feel like ParseException should not be thrown here, perhaps a CommandException can be thrown so that we do not need to introduce ParseException to the execute method? What do the others think?
11 (commented on others PR)
Alright, sure! I'm okay with not checking the time
12 (commented on others PR)
Alright, noted! Thanks
13 (commented on own PR)
oops i think they were added by mistake
14 (commented on own PR)
yup
15 (commented on own PR)
Yup, will add
16 (commented on own PR)
Not sure what the others think about this, I think that would also work.
17 (commented on own PR)
Nope, there are no other compulsory fields for Project other than name since description and tags are optional
18 (commented on own PR)
Fixed!
19 (commented on own PR)
Fixed!
20 (commented on own PR)
I changed the code for the parse method of AddCommandParser class instead so the existing getValue() method can be used, thanks for the comment
21 (commented on own PR)
Good suggestion, but could we push this to our next iteration if it is not too urgent? I am still not very familiar with how Json works, will need some time to work on it!
22 (commented on own PR)
Fixed!
23 (commented on own PR)
Will leave it as such as discussed, will discuss more in detail after implementation of project ID
24 (commented on own PR)
Yes I'll go fix it!
25 (commented on own PR)
Fixed!
26 (commented on own PR)
It should disregard the preamble.
I have added a test for this!
27 (commented on own PR)
Somehow the checkstyle doesn't pass it if i leave a newline, I think we can disregard these for now?
28 (commented on own PR)
Same as my previous comment
29 (commented on own PR)
I think we can leave it here since other classes are doing the same. We can move them to Messages in one go in the next iteration!
30 (commented on own PR)
Fixed!
31 (commented on own PR)
The reason why I need to use HashMap is because not all projects have Deadlines, and I'm using Comparator.nullsLast to place all projects without deadlines at the end of the list after projects with deadlines, so I need to compare Deadlines (and not Projects). But after extracting the deadlines (or nulls), I will still need to compare the names alphabetically in case of same deadline or null deadline, which is why I need to return the name as well. Anyone can lmk if there is a cleaner way to do this!
32 (commented on own PR)
Fixed!
33 (commented on own PR)
Fixed!
34 (commented on own PR)
Fixed!
35 (commented on own PR)
I have changed the SortCommandParser to fail when there is a non-empty preamble for consistency as AddCommandParser and FindCommandParser does the same. I have added a test accordingly!
36 (commented on own PR)
Fixed!
37 (commented on own PR)
Abstracted into a SortCommandUtil class!
38 (commented on own PR)
Fixed!
39 (commented on own PR)
Fixed!
40 (commented on own PR)
Fixed!
41 (commented on own PR)
Fixed!
42 (commented on own PR)
Done!
43 (commented on own PR)
Done as well!
44 (commented on own PR)
Done!
45 (other comment)
Just wondering if it would be better to keep to one deadline command to indicate both date and time (so we don't need dt/ and dd/) so if you want to indicate time, you can do something like dl/VALID_DATE, VALID_TIME and if you don't, you can just put dl/VALID_DATE. Perhaps we could discuss with the group. Other than that, LGTM:)
I just realised that you already addressed this issue, and I'm ok with what you have suggested! Thanks:)
46 (other comment)
Yup, I think we can try to fix this issue
47 (other comment)
I think we should exclude the created date attribute when we are comparing two projects because it should not be an important attribute of the project? For example if I created this project yesterday and I forgot about it, and I make another entry today that has the exact same content, it should still be considered as a duplicate. What do the others think?
48 (other comment)
Yup I think that will be good
@erinmayg (11 comments)1 (commented on others PR)
I think it's supposed to be Module
2 (commented on others PR)
Should we use FaculType instead of address book or just keep it as it is?
3 (commented on others PR)
Perhaps it would be better to use MODULE_CODE and MODULE_NAME instead? I think it avoids confusion and keeps it consistent.
4 (commented on others PR)
I think it'd be better to phrase it as "The list has at least one module."
5 (commented on others PR)
Can also search by remark and tags 😄
6 (commented on others PR)
I think it's supposed to be Unassignall 😄
7 (commented on others PR)
Have you tried special blank characters like "\n", "\t", etc. ?
8 (commented on others PR)
I think this should be ListCommand 😃
9 (commented on others PR)
Can also try to test on special characters like "\n", "\t", etc. 😄
10 (commented on others PR)
I think this is supposed to be {@code moduleCode}
11 (commented on others PR)
Same typo heheh.
12 (commented on own PR)
Oh yes. It seems I forgot to change it haha 😅
13 (commented on own PR)
Hm... I was just following the class name. Wouldn't it be weird if "professors" suddenly appeared out of nowhere since it has never been mentioned before?
14 (commented on own PR)
Okay! 👍🏻
15 (commented on own PR)
Ok! 👍🏻
16 (commented on own PR)
Oops. I forgot. Thanks for reminding! 😄 Will implement it ASAP.
17 (commented on own PR)
I've added it! 😃 Thanks for the input!
@ChenXJ98 (11 comments)1 (commented on others PR)
Looks good! I think we can stick with this for now 😃
2 (commented on others PR)
Target user profile looks good
3 (commented on others PR)
Value proposition looks. Slight grammar issue (feature instead of features).
4 (commented on others PR)
Grammar: 'flashcard' instead of 'flashcards'
5 (commented on others PR)
Looks good
6 (commented on others PR)
Looks good
7 (commented on others PR)
Thanks for helping to edit
8 (commented on others PR)
Export implementation looks great! Thanks!
9 (commented on others PR)
Great implementation!
10 (commented on others PR)
can remove propose here as well
11 (commented on others PR)
same over here and the few below
12 (commented on own PR)
Noted, I have made the changes and standardised the format of our use cases
13 (commented on own PR)
getQuestion now returns String, I think the one you are looking at is outdated
14 (commented on own PR)
This code is outdated as well
15 (commented on own PR)
I think this method is to initialise sample question. But will not be implemented last after v1.2a
16 (commented on own PR)
We can discuss the naming during this week's meeting, cause quite a lot will change and I am afraid it might get confusing.
17 (commented on own PR)
okay I will change it! thanks
18 (commented on own PR)
I have done the changes, thanks!
19 (commented on own PR)
I've made the changes, thanks!
20 (other comment)
Okay thank you!
21 (other comment)
Since all issues relating to 1.1 is resolved, I'll close this issue.
22 (other comment)
lgtm! thank you!
23 (other comment)
Looks good! I will review it after lunch!
@boundtotheearth (11 comments)1 (commented on others PR)
I think it's ok since it should be the product name
2 (commented on others PR)
I agree, but i think not super important. Can do when we have time
3 (commented on others PR)
Would it be better for descriptions to be optional?
4 (commented on others PR)
What is the purpose of this method? Is it not possible to use/change the existing getValue() method?
5 (commented on others PR)
Should description be considered an identity field for a project? I.e. should we allow projects with same name but different description?
6 (commented on others PR)
I think it would be useful to implement the Json serialization such that if description does not exist, then it is taken to be empty (""), so we don't have to add a description to all the sample data
7 (commented on others PR)
Should this throw an exception instead?
8 (commented on others PR)
Should this method belong to ReadOnlyProjectBook instead? Logic should not have to know about the internal components of Model (i.e. tags). Can probably get the projectbook from logic, then get the tags from the projectbook
9 (commented on others PR)
Should this method be in Description instead? It doesn't require anything form project and is only calling a method from description, so I think we should put it together with all the other description code.
10 (commented on others PR)
Similar to above, should this be in deadline instead?
11 (commented on others PR)
Maybe can consider using something like LocalDateTime.MIN?
12 (commented on own PR)
The Timer class is only used to keep track of the active timers. Once the timer is stopped, the data is stored under a WorkDuration class (which has not reference to project), and put in a list inside the corresponding project.
I implemented it this way because I didn't want to store incomplete timers in a project, since it might cause problems if the timer wasn't stopped properly. Its also easier to check for active timers this way (see activeTimer in ModelManager)
And i think it would be easier to extend to having multiple concurrent timers if we decide to do that (then each timer needs to know which project its keeping track of)
Just storing the index won't work because the filtered list might change while the timer is running.
13 (commented on own PR)
Actually I think the Optional.equals() method also checks if both are empty, so I can just remove the 1st line
14 (commented on own PR)
Haha the javadocs is from the original addressbook. I'll change it
15 (commented on own PR)
This is mostly what i was referring to when i said more/better tests are needed.
Basically, since I'm using LocalDateTime.now() to get the current time, 2 times will never be exactly the same (they will be some nanoseconds apart). For example in tests, even if I start 2 timers immediately after one another, they will have different values, so equals() will still say that they're different. Since the existing tests involve checking if 2 models are equal, this will break a bunch of existing tests.
I'm think of either (a) Overloading the timer functions so that I can start them at a fixed time (just for testing) or (b) Introduce a custom global clock for the application to run on. The global clock will be the same as system clock in production, but in testing it will have functions that allow us to manually control the time.
16 (commented on own PR)
A user will never see this message (as of now) since we don't require users to manually input times. If we add commands that involve time inputs, then it might be better to not use ISO8601 format in the first place (its hard to read) and instead use some variation of the "yyyy MM dd hh:mm:ss" style.
This error only come up in logs when theres an error in loading saved data (e.g. the saved data is not in ISO format). For now I'll add an example of what the format looks like to the error message
17 (commented on own PR)
TypicalWorkDuraiton is just a class to provide dummy data for testing. I defined some simple durations like 1 day, week, month, etc for testing
18 (commented on own PR)
It was related to the immutability thing I told you about last time. Its not relevant anymore but they're both equivalent
19 (commented on own PR)
Ok fixed
20 (commented on own PR)
This was auto generated by intelliJ and I'm gonna assume that it knows better than I do
@galvinleow (11 comments)1 (commented on others PR)
Cannot handle white space?
2 (commented on others PR)
I think Hans made a generic list?
3 (commented on others PR)
FindAppointmentCommand
4 (commented on others PR)
Can just make this 2 into 1 line?
5 (commented on others PR)
Although optional to cast ArrayList type, might be good to leave it in?
6 (commented on others PR)
Not sure if protected will be better
7 (commented on others PR)
I feel that double should remain as a primitive type? If Double means it can accept NULL
8 (commented on others PR)
Should use Integer.parseInt(trimmedIndex)), because if someone creates a parseInt(trimmedIndex) method, then this line might break the code.
9 (commented on others PR)
I think do not use Math.round since your display in 1 or 2 Dp
10 (commented on others PR)
month and year
11 (commented on others PR)
Your copy and paste high level
12 (commented on own PR)
I changed to listmodule
13 (commented on own PR)
I think this one just leave it, easier to understand for the user in my view
14 (commented on own PR)
I will do this in the last milestone, issue created
15 (commented on own PR)
What you mean? If clear than should be empty?
16 (commented on own PR)
okay
17 (commented on own PR)
Will change this but likely this will not be in used because appointment use case not done
18 (other comment)
Total Revamp of the UG due to change of scope
19 (other comment)
Total revamp of UG, will create an issue when the time is right.
20 (other comment)
The wrong branch hence closing this PR without Merge
@michael-setia (11 comments)1 (commented on others PR)
Maybe we can add ParseKeyword() method to the ParserUtil class?
2 (commented on others PR)
I think we should access ModuleName class instead of Name class?
3 (commented on others PR)
Same issue as above.
4 (commented on others PR)
Should it be index.getZeroBased()? Since the constructor for ViewCommand specifies that the index should be zero based ("@param moduleIndex Zero based index of the module in the list of modules.")
5 (commented on others PR)
I think we can create sections for the accessor methods for each type of list? Since there are going to be todolist and possibly schedule list also. Just to make things more organized 😃
6 (commented on others PR)
Maybe can change "person" to "contact"?
7 (commented on others PR)
I think we should add a JavaDoc for this constructor? Just to maintain consistency 😃
8 (commented on others PR)
I like how this is separated into 2 lines (not combined into 1 line like the original code) which can enhance readability 😄
9 (commented on others PR)
I think the solution that we can consider for the 2 problems above is to have static field for the 3 types of the parser. This way we can have better abstraction and don't need to instantiate the parser every time a command is called by the user.
10 (commented on others PR)
@jonasngs I think it should be fine since this is just the first layer for checking the commands. It will be checked again in each of the FeatureParser e.g. even though "addmodule1" may pass the ParserManager, the method parseCommand() in ModuleListParser will throw an exception anyway.
In addition, I think we can consider using static HashSet for checking the type of the command. It will be accurate (less prone to bug) and also fast at the same time (no need to check for every existing command), but of course it will consume more memory (which one is our priority though?) 😃
11 (commented on others PR)
I think the correct implementation is to use OR? Because both email and telegram ID are unique. So, comparing just one of them should be sufficient?
For example, Person A and Person B have the same name and email but different telegram ID. If we impose that every field must be the same, then we will consider Person A and Person B to be different. This means Person A and Person B are physically 2 different person with the same name that share one email account. I think we won't see this kind of case in real life?
By the way, the above is the case if we treat Contact as real person. I would like to clarify if we define Contact as real person though? Or maybe it is okay to have 2 same person but different email because they have different roles? e.g.
Person A
Name : Halo
Email : Personal email
Telegram : @halo
Person B
Name : Halo
Email : Work email
Telegram : -
Though, in this case, I think the name of the contact should have been the one that are differentiated instead, to avoid confusion 😆
12 (commented on own PR)
Yes, for now it is just used to make the testing easier (no need to write the whole thing every time).
13 (commented on own PR)
Yes, I will migrate all the methods to the ParserUtil class.
14 (commented on own PR)
Yes, I will add all the missing JavaDocs (I only added the javadocs that the CI requires for this PR)
15 (commented on own PR)
Yes, I think that's a good idea
16 (commented on own PR)
Okay, sure.
17 (commented on own PR)
Yes, sure. If the test doesn't work, we can always comment out first then make the changes later.
18 (commented on own PR)
Yes, I think we should do that. Will try to change in the next PR.
19 (commented on own PR)
Oh yes, I just realized that Tag can probably replace Type.
20 (commented on own PR)
Yup, totally forgot about that 😆
21 (commented on own PR)
Yup, noted.
22 (commented on own PR)
Okay, I can move the first append method call to match the other append calls.
23 (commented on own PR)
Okay, noted.
24 (commented on own PR)
I think it should work since this is taken directly from our current UniqueModuleList class. In addition, field internalList is private means that it can only be accessed by the UniqueTodoList class and the code "((UniqueTodoList) other).internalList))" is inside the UniqueTodoList class. Hence, it is not a problem.
25 (commented on own PR)
I am using the same implementation as our current ModuleList class (from AB-3). The reason is because module list is very similar to todo list. I think it is a good idea to maintain consistency and similarity for the implementation throughout the code?
Or perhaps we should instead try to implement our own version of todo list that does not replicate the implementation of module list? i.e. todo list in cap5buddy package uses a different implementation by using arrayList instead.
26 (commented on own PR)
Same issue as above.
27 (commented on own PR)
Same issue as above.
28 (commented on own PR)
Okay, it is now resolved.
29 (commented on own PR)
TaskNotFoundException is an unchecked exception since it inherits from RunTimeException. I think the purpose of this exception is mainly for bug checking. In addition, the error message that will be shown to the user should be handled in the each of the Command class instead?
For instance, below code is taken from EditCommand class from the original AB-3 (this is absent from our current EditModuleCommand class though):
"if (index.getZeroBased() >= lastShownList.size()) {
throw new CommandException(Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX);
}"
However, I think we can still add error message just to make it easier for the programmer to understand the error when debugging 😃
30 (commented on own PR)
Yup. For the moment, I think we can implement 2 version of comparator classes e.g.
and then we can either do the same for TaskComparatorByDate by creating 2 new classes or we can instead modify TaskComparatorByDate to take an argument which can be either DateComparatorAscend or DateComparatorDescend based on the user input,
e.g. TaskComparatorByDate(DateComparator comparatorDescend );
31 (commented on own PR)
Yes, I think we should handle that in each of the Command class?
In addition, I just changed the isSameTask() method. Now 2 tasks are considered to be the same if only their name are the same since the other fields can be optional. I think it is sufficient to just check the name?
32 (commented on own PR)
Oh yes, it should only need to have the same name. I forgot to edit the JavaDoc for that one 😆. Thanks for pointing this out!
33 (commented on own PR)
Okay, I have updated the JavaDocs.
34 (commented on own PR)
Okay, noted. I will change the PR to draft in the meantime until the abstracting of the Parser class is done.
35 (commented on own PR)
Agreed, I also think the same.
36 (commented on own PR)
Yes, we could use inheritance here to have better abstraction (no repetition code).
37 (commented on own PR)
Agreed, I will update this in the future.
38 (commented on own PR)
No, the correct one is the red one. I just realized that I might have deleted the wrong line when resolving the conflicts 😆
39 (commented on own PR)
Yes, thank you for pointing this typo 😃
40 (commented on own PR)
Okay, I have fixed the typo.
41 (commented on own PR)
Okay, I have fixed it.
42 (other comment)
LGTM.
43 (other comment)
Yes, I will implement the storage part for TodoList later.
@printinghelloworld (11 comments)1 (commented on others PR)
How about "displays all your lessons and assignments for 2 weeks (including the current week)"?
2 (commented on others PR)
maybe can change to often 'late for appointments and struggling to meet deadlines'. but this is quite minor so can edit in the future
3 (commented on others PR)
I think module code might not have to end with an alphabet or number all the time right haha. maybe can phrase it '... have 4 numbers and may end with an alphabet.'
4 (commented on others PR)
just wondering, do we need an editPersonDescriptor at this stage or later?
5 (commented on others PR)
is this supposed to be 'in the context of RemindCommand' instead of DeleteCommand?
6 (commented on others PR)
does it have to be abstract since this class doesn't contain any abstract methods.. I think a normal class would suffice
7 (commented on others PR)
UnremindCommand?
8 (commented on others PR)
second* assignment
9 (commented on others PR)
oh okay, I didn't know that Command was abstract. ya we can leave it as abstract then
10 (commented on others PR)
maybe can rename to expectedHours since it's referring to hours
11 (commented on others PR)
what's this ResolverStyle just curious haha
12 (commented on own PR)
okay we can discuss this in our meeting later!
13 (commented on own PR)
wait what do you mean? is it we allow them to have any number of tags as well?
14 (commented on own PR)
Okay updated!
15 (commented on own PR)
ah ok! line 57 right
16 (commented on own PR)
updated!
17 (commented on own PR)
thanks for pointing it out!
18 (commented on own PR)
edited!
19 (commented on own PR)
edited! thanks for pointing this out
20 (commented on own PR)
edited accordingly! thanks!
21 (commented on own PR)
whoops thanks for pointing this out
22 (commented on own PR)
changed to academic schedule!
23 (commented on own PR)
okay changed to Andrea's suggestion cause I don't think unmark is a proper English word as well according to Google haha
24 (other comment)
Looks good! Just a small suggestion, maybe we can standardise the use of capital letters under 'I can' and 'so that I can'. we can either capitalise the first word or not capitalise the first word for both scenarios 😃
Sounds good! Which do you suggest is better? I'm fine with either way 😃
I think for now we can not capitalise for both scenarios !
25 (other comment)
Let me fix the checkstyle
@cupofjoee (11 comments)1 (commented on others PR)
Could you help check whether the Index class would be useful in this case instead of int? The flashcard class is implemented using Index. TLDR: the Index class adds flexibility of zeroBasedIndex and oneBasedIndex. I'm just not sure whether it's actually useful, need second eye. Thanks!! 👍
2 (commented on others PR)
The equality here should include both indexes and not only 1
3 (commented on others PR)
Question slipped here. Just need to replace it accordingly.
4 (commented on others PR)
Do the temporary details disrupt the Command tests? If not, I suggest to keep it until Petrick done with the Flashcard UI.
5 (commented on others PR)
What is the purpose of the assertEquals here? They do not use the command in the parameter. When would the 2 assertEquals return False in this case?
6 (commented on others PR)
I didn't know this 😂
7 (commented on others PR)
Is there supposed to be withFlashcardSetName("Physics") here?
8 (commented on others PR)
Minor stuff, we should avoid Magic String as much as possible. There is VALID_FLSET_NAME_ECONOMICS in the FlashcardBankCommandTestUtil
9 (commented on others PR)
What issue?
10 (commented on others PR)
Our sample flashcards so high quality! 👍👍
11 (commented on others PR)
Ah I see, yup I think just a short 1-line comment is enough
@porkeypine (11 comments)1 (commented on others PR)
Good point, we'll do that in the next PR!
2 (commented on others PR)
Agreed!
3 (commented on others PR)
Agreed
4 (commented on others PR)
Appointment class already has a String description, is that good enough?
5 (commented on others PR)
Sorry, can you explain what is the TAB_ID used for in the Command class actually? Is it only relevant in the CommandResult class?
6 (commented on others PR)
TAB_ID needs to be declared as a public static final constant above right?
7 (commented on others PR)
Agreed! I think it will be addpatient based on our user guide.
8 (commented on others PR)
I think so, because we will have various ListAppointmentsCommands, like listing all appointment of a specific patient!
9 (commented on others PR)
Actually, I think it might be good to use the shorter versions? More user-friendly! We can update the UG to reflect this if everyone agrees
10 (commented on others PR)
I think we can remove this line since Address field has been removed!
11 (commented on others PR)
Should we remove the PREFIX_ADDRESS since we are no longer using Address?
@shadowezz (11 comments)1 (commented on others PR)
I think maybe its better to switch the role.toString and role.getArgument() here as people may think role.toString is what they shld key in. Just a nitpick.
2 (commented on others PR)
I think this should be deliverable index.
3 (commented on others PR)
I think its better to import them first
4 (commented on others PR)
Perhaps it is better to make it into a datetime object
5 (commented on others PR)
Same as above
6 (commented on others PR)
Same as a above
7 (commented on others PR)
Maybe its better to display NIL like the rest
8 (commented on others PR)
Not sure if we should resolve overflow in this way. Perhaps we can check for it during parsing and regard this as an invalid date.
9 (commented on others PR)
I think there are some challenges with this cos we would then need to check if localDateTime is meant to be only a date or there is a time component also.
10 (commented on others PR)
I think you have some typos in the this class. Should be "meeting" instead of "person".
11 (commented on others PR)
I think can just remove this function
12 (commented on own PR)
wait i dont think so right
@schoolex (10 comments)1 (commented on others PR)
Are you missing a new line here?
2 (commented on others PR)
should it be persons?
3 (commented on others PR)
Room follows this format
>Level>>Room No>
Shouldnt the range from room include other levels other than 1?
eg. 100 - 420 (The block has 4 levels, 20 rooms per level)
4 (commented on others PR)
Seems like there is a typo here
5 (commented on others PR)
should it be .txt files instead?
6 (commented on others PR)
Better to use a table form
7 (commented on others PR)
Is the format consistent with the numbering style in the logic API?
8 (commented on others PR)
There's a typo here, follwed -> followed
9 (commented on others PR)
Is there a formatting issue with the escape character
10 (commented on others PR)
The argument in the method does not match step 1. Can consider shortening it to find
11 (commented on own PR)
Will update this
12 (commented on own PR)
Will add a toUpper() to enforce caps
13 (commented on own PR)
It needs to be set before the addressBook is loaded else there will be a validation error when loading the saved addressBook
14 (commented on own PR)
UserPrefs is just a class to store the info of the preferences. It does not actually modify another class attributes
15 (commented on own PR)
This is the default value which be overridden by setBlockPref , its needed for testing since all the test cases do not read from the preference file
16 (commented on own PR)
userPref will never be null, because the check is done in UserPref . Block and Room in this case is referring to the class, so it cant be null either
17 (other comment)
Tracked by tp dashboard
18 (other comment)
Will fix this bug
@Anthony6401 (10 comments)1 (commented on others PR)
Why is there another >br />? Is it intended?
2 (commented on others PR)
I think you forget to add role
3 (commented on others PR)
I think HelloFile does not need to read or write in help command, it shouldn't be in extension.
4 (commented on others PR)
This is the same as Luo yi's comment at the top.
5 (commented on others PR)
Is the "\n" before parameters intended? All the other command does not use "\n" before parameters. I think it is better to make it consistent.
6 (commented on others PR)
Okay then. Should we do that to all other commands?
7 (commented on others PR)
After seeing the screenshot, I also think it is better to use \n since we have so much space for the text box. Noted!
8 (commented on others PR)
Perhaps you mean to append the themeName here?
9 (commented on others PR)
Are we deleting appendix for manual testing altogether or will we add it later?
10 (commented on others PR)
What is this FileListStub for? I can't find any class that use this. If this class is not being used, can it be deleted? We can add it again later if we really need it, to make the code cleaner.
11 (commented on own PR)
Didn't realize that. Thanks!
12 (commented on own PR)
I tried using empty line, but the gap between Q and A is too large. I think it is better to use >br>.
13 (commented on own PR)
Didn't catch that before. Thanks! I have changed it.
14 (commented on own PR)
Changed!
15 (commented on own PR)
I dont think this is related to TagCommand, since the value in here is from what being read from the preferences.json file. The absolutePath in here is to ensure it is a absolute path if the user try to manipulate the data inside the json file to use relative path.
16 (other comment)
test
17 (other comment)
Okay then. I'll close this PR.
@ruilingk (10 comments)1 (commented on others PR)
Extensions is spelt inaccurately. Subsequently also. 😅
2 (commented on others PR)
I think use case should end here.
3 (commented on others PR)
I think use case should end here.
4 (commented on others PR)
I think indexing of 2a1 would be good.
5 (commented on others PR)
I think this line should not have indexing.
6 (commented on others PR)
I think there should be a Use case ends. line after this.
7 (commented on others PR)
I think there should be a Use case ends. line after this.
8 (commented on others PR)
Would it be better to include this.showPlanner = false; too?
Same as the overloaded constructor at the top too. e.g. this.showCountdown = false;
9 (commented on others PR)
Remember to change to Countdown tab! 😄
10 (commented on others PR)
Is this supposed to be CountdownCommandParser()?
11 (other comment)
Merged #14
12 (other comment)
Merged #13
@SONGYI98 (9 comments)1 (commented on others PR)
Should change back to "person". Same for Line 9.
2 (commented on others PR)
Will "ReadOnlyFoodInventory" be better?
3 (commented on others PR)
Will "FoodInventory" be better?
4 (commented on others PR)
Will "JsonSerializableFoodInventory" be better?
5 (commented on others PR)
AddressBook references have not been removed.
6 (commented on others PR)
A very small nitpick but "g" will be a better unit. Also, perhaps consider removing the "20g" tag in line 33?
7 (commented on others PR)
Using "updatedQuantity" will make it consistent with the naming of the other variables.
8 (commented on others PR)
Is using the singular verb "donut" be better? What if the same user add another food item of 1 donut?
9 (commented on others PR)
Same as previous with regards to using "g" as a unit.
10 (commented on own PR)
Fixed. Thanks.
11 (commented on own PR)
Fixed. Thanks.
12 (commented on own PR)
Noted. Thanks.
13 (commented on own PR)
Corrected.
14 (commented on own PR)
Corrected.
@TCQian (9 comments)1 (commented on others PR)
Is it better to use NAME_DESC_A instead of NAME_DESC_AMY?
2 (commented on others PR)
I assume the name of meeting is to be edited too?
3 (commented on others PR)
Wrong constructor Email is invoked?
4 (commented on others PR)
This lines does not match the function. Especially the @code taskTags. Is there any missing refactor for this comment?
5 (commented on others PR)
Is it projectName instead of taskName?
6 (commented on others PR)
Is it projectName?
7 (commented on others PR)
Is it trimmedMeeting?
8 (commented on others PR)
Why do you remove this line?
9 (commented on others PR)
LGTM.
10 (commented on own PR)
What task filter command?
11 (commented on own PR)
Alright.
12 (other comment)
Hey, i think this revert is not needed anymore since we're reverting an earlier version of the repo in PR#16
13 (other comment)
Phone -> Deadline
Email -> RepoURL
14 (other comment)
Opened a new branch for this, will close this PR and migrate to another PR.
15 (other comment)
This PR is successor for https://github.com/AY2021S1-CS2103T-W10-3/tp/pull/68
16 (other comment)
Completed
17 (other comment)
Those leaves command might be removed later. Can we implement a stack for handling the statuses? Only a leave command will be used to remove the newest status? Maybe better implementation on reseting the itemsToBeDisplayed during scope switching.
18 (other comment)
The method to get assignees name from the task was changed and it caused the assignees' names can't be retrieved and shown on the taskDashboard. Other project attributes such as person class involve the participation class might get affected by this changes. Could you please edit the TeammateDashboard, TaskDashboard to fix the errors of some methods not found?
19 (other comment)
Amendment will be done by Geniaaz.
@Ashley-Lau (9 comments)1 (commented on others PR)
I think it would be good to standardise. LGTM other than this.
2 (commented on others PR)
Are we going to allow the new quantity to be less than 0?
3 (commented on others PR)
Where do you suggest then? The other location I can think of is stock class.
4 (commented on others PR)
Is there an extra tab here?
5 (commented on others PR)
I think you shouldn't use the short form of accumulated here for the class name?
6 (commented on others PR)
I think this is fine.
7 (commented on others PR)
Should we include an example which shows the usage of deleting multiple stock?
8 (commented on others PR)
Maybe can include the word "multiple" to make the use case more explicit? Some people with poor English like me might miss this out.
9 (commented on others PR)
just a small typo here I chanced upon
10 (commented on own PR)
Nope. I think the refactoring screwed up all the links within the docs. Good catch!
11 (commented on own PR)
We would be storing stocks rather than person in our warenager so I thought the renaming of the class would be appropriate here.
12 (commented on own PR)
Alright will remove it!
13 (other comment)
LGTM!
14 (other comment)
LGTM!
15 (other comment)
LGTM
16 (other comment)
update sn/fairprice1 iq/1000 sn/fairprice2 seems to be incrementing both stock by 1000. Is this the expected behavior?
17 (other comment)
LGTM!
@lettuceman4 (9 comments)1 (commented on others PR)
Remember to change to new CommonCents() later 😊 doesnt rlly matter now HAHAH
2 (commented on others PR)
I think should include an empty line here (the Addressook they have)
3 (commented on others PR)
Uh is there a new line here ah?
4 (commented on others PR)
why don't u delete the old commands ah
5 (commented on others PR)
I think can remove all the seedu. stuff in this class
6 (commented on others PR)
I think can remove this empty line
7 (commented on others PR)
A lot of empty lines leh
8 (commented on others PR)
Is this supposed to be "tracker"
9 (commented on others PR)
I think can remove the empty lines here
10 (commented on own PR)
Yup!
11 (other comment)
Only need 1 person to do this, but please finish asap after Zi Yang is done with the LogicManager
@Rahul0506 (9 comments)1 (commented on others PR)
Would be better to name it as "exactlyMultipleWordsIgnoreCase"? "contains" is a little misleading.
2 (commented on others PR)
Can you not just import the View.InventoryType ?
3 (commented on others PR)
same as before
4 (commented on others PR)
maybe use a more descriptive name
5 (commented on others PR)
missed this
6 (commented on others PR)
I think you can import only DEFAULT_DESCRIPTION separately?
7 (commented on others PR)
just use requireNonNull?
8 (commented on others PR)
Don't need the "this"
9 (commented on others PR)
Is this used anywhere? It was deleted for the Item class, and UniqueRecipeList no longer uses it
10 (commented on own PR)
This was specified in user guide, can be changed easily regardless
11 (commented on own PR)
Good note, modified
12 (commented on own PR)
changed to "apple banana carrot"
13 (commented on own PR)
Done, my bad
@Trav1sT (9 comments)1 (commented on others PR)
Agreed. Roger this.
2 (commented on others PR)
Concise!
3 (commented on others PR)
I'm just confused. What's the advantage of using var in general? Like in this case, wouldn't specifying the type make it clearer?
4 (commented on others PR)
Beautiful! p.s. just 'reviewing'
5 (commented on others PR)
Oo Thanks. This is more helpful than my doctor who only told me not to use it if it hurts but never say how.
6 (commented on others PR)
Niceeee
7 (commented on others PR)
Looks good!
8 (commented on others PR)
Should be fine
9 (commented on others PR)
Nice format!
10 (commented on own PR)
Uwu I just realised this after adding the tests.
11 (commented on own PR)
Agreed, working on it!
12 (commented on own PR)
Oh yes should be words[0]
13 (commented on own PR)
Deleting this old and deproved version.
14 (commented on own PR)
I commented it out cuz LogicManager and UiManager both ain't in chopchop yet. So the red line kind of annoying.
15 (commented on own PR)
Ah YES thankss you solved the mystery. I was like I need a getter for name then I made one then after I made it I asked myself why did I make this. Now I know why
16 (commented on own PR)
Ermm cuz deleting is an extra step but ok I'll cut.
17 (commented on own PR)
I had the same question. It was more OMG MEGA. I already shift-tabbed it. I go check my editor settings again.
18 (commented on own PR)
Excellent catch
19 (other comment)
Hmmm, I think it's alright now.
20 (other comment)
Im sorry our recipes very cui. Quick view of the command breakdown sounds great.
21 (other comment)
Looks good!
@WangZijun97 (8 comments)1 (commented on others PR)
Just tested with the current master branch code, 0 does not remove the role from the shift yet, but instead shift-edit removes all roles, then add the ones keyed in. Do we want to have the 0 = remove functionality, or just not allow 0 to be keyed in?
2 (commented on others PR)
Thanks for helping to update the user guide.
3 (commented on others PR)
I think will be good to check if " " (a bunch of whitespaces) is also rejected by the regex since they won't be covered by the test.trim() == "". In any case should have added it earlier into RoleRequirementTest 😛
4 (commented on others PR)
I think role is an optional argument so perhaps no need to check if it is present.
Actually since we are on this topic, I think pay isn't either? But if these are necessary then perhaps updating the User Guide will do.
5 (commented on others PR)
Thanks for abstracting this out properly xD
6 (commented on others PR)
I'm not sure if the FULL value should be implemented into the code itself, or should it just be an argument that we accept that from user input that is essentially a wrapper for creating both an AM and a PM unavailability. Not sure if this might result in duplicates when creating shifts of AM and of FULL of the same day?
7 (commented on others PR)
I think no role should be unable to assign to anything, kind of like when someone new join and havent do the training I guess. Makes sense for pay to be compulsory, so agreed there.
8 (commented on others PR)
Maybe if these are created as proper JavaFX nodes with assignment set to its inner value, then JavaFX will update them properly. Implementation could be similar to WorkerListPanel except it is as children to WorkerCard and ShiftCard.
9 (other comment)
Same as issue #12
10 (other comment)
Looks good! The use cases provided are comprehensive. Maybe later we can also add high-level cases, like "accepting a new hire for a position", which will include use cases 1, 4, and 7.
Included one such use case (but just UC-001 --> UC-007) so that we can see how that might look like.
11 (other comment)
LGTM!
12 (other comment)
Thought I would just add which tests I'm working on adding now so that we don't duplicate:
AddressBookTest
ModelManagerTest
I can continue and handle all of seedu.address.model tests first.
13 (other comment)
AssignCommandTest has been removed as issue was resolved. Furthermore, the implementation of assign was revamped, hence the test case is grossly invalid.
14 (other comment)
Resolved by #88
@Vielheim (8 comments)1 (commented on others PR)
Maybe you would like to use "toUpper" here? Less bugs
2 (commented on others PR)
Perhaps you can consider not using "active" here? Probably can use some gibberish like "asdjnewfpqwifnqiweyfbqwekfbrw"?
3 (commented on others PR)
Would be good to OOP this.
4 (commented on others PR)
Updated
5 (commented on others PR)
addressBook --> PIVOT
6 (commented on others PR)
Same as above
7 (commented on others PR)
"Addressbook spotted"
8 (commented on others PR)
"addressBook Spotted"
9 (commented on own PR)
Just added
10 (other comment)
To be updated for README: (Put under Issues as well)
UI mockup
Links for respective pages
Update the link of the GitHub Actions build status badge (Build Status) so that it reflects the build status of your team repo.
11 (other comment)
Do not merge
12 (other comment)
Do not merge
13 (other comment)
Do not merge
14 (other comment)
Do not merge
15 (other comment)
Do not merge
16 (other comment)
17 (other comment)
Updated
18 (other comment)
Sorry I pressed Merge Commit by accident >>
@Jillzyt (8 comments)1 (commented on others PR)
Don't think need to compare comments and reps, since it is not an identifier field.
2 (commented on others PR)
Don't think the log should have tags hence we don't need to test getTags().
3 (commented on others PR)
Don't think Phone and email should be in the log unit test still.
4 (commented on others PR)
Same as the previous few comments.
5 (commented on others PR)
Remember to change the method name to match Logs.
6 (commented on others PR)
Remember to change the method name to match Logs.
7 (commented on others PR)
Remember to change the method name to match Logs. This is repeated for the other tests in this file
8 (commented on others PR)
Refactor to VALID_EXERCISE_JUMPING... for clarity?
9 (commented on own PR)
Noted. Updated my code.
10 (commented on own PR)
Noted. Updated the code.
11 (commented on own PR)
Updated in code.
12 (commented on own PR)
Updated the method name.
13 (commented on own PR)
Updated
14 (commented on own PR)
Updated
15 (commented on own PR)
Updated
16 (other comment)
LGTM (with the exceptions of checks).
17 (other comment)
Passed checkstyleMain, checkstyleTest.
18 (other comment)
LGTM.
19 (other comment)
Current changes LGTM.
20 (other comment)
Decided to add more tests.
21 (other comment)
100% test coverage for models.
CheckstyleMain and checkstyleTest passed.
Two todos added to solve the issue of the same DateTime checks for logs in Sampleutil.java.
@JingYenLoh (8 comments)1 (commented on others PR)
The execution example seems to be for list rooms, is that intentional?
2 (commented on others PR)
These changes appear to be more relevant for #46 . Perhaps they should not be included in this PR?
3 (commented on others PR)
Will resolve via rebase strategy.
4 (commented on others PR)
Thanks for extracting this out 😄
5 (commented on others PR)
That's nice!
6 (commented on others PR)
Oh nice, was planning to do that in 1.3.
7 (commented on others PR)
We now have clauses that cannot exist together, e.g. you can't specify rooms --vacant --allocated, but we can update that in 1.3.
8 (commented on others PR)
An example of the above mentioned flag. Also I think we should document parameters and flags differently, but it's fine for 1.2.
9 (commented on own PR)
I'll remove the redundant line. The rest shouldn't be removed IMO - they are stories we've come up with.
10 (commented on own PR)
#27 is already in. I'll include the rest.
11 (other comment)
As discussed in our team meeting this week, @mkeoliya and I will be updating the Developer Guide. We will include a note about the git hooks when we do that.
12 (other comment)
@AY2021S1-CS2103-T16-3/developers , @mkeoliya and I had a long discussion on how this value adds to our users. We weren't really able to find a concrete use case for this feature. Can anyone think of why this would be useful for our target users? We're leaning towards lowering the priority of (or even scrapping altogether) this User Story.
OTOH, we further refined our concept of the export feature, which we're documenting in #52 .
13 (other comment)
Closing to see if I can safely close this without affecting their grading scripts, since these are polluting our repo.
14 (other comment)
Closing, we won't be needing this feature. Their autograder scripts should have picked this up by now.
15 (other comment)
Closing, we won't be needing this feature. Their autograder scripts should have picked this up by now.
16 (other comment)
Thanks!
17 (other comment)
Resolved.
18 (other comment)
Duplicate of #16
19 (other comment)
Closing as AddressBook already supported this.
20 (other comment)
Requesting 2 reviewers for this 😠
21 (other comment)
While working on viewing vacant rooms, I realized this feature would be straightforward for me to implement as well. I've discussed with @Lysire and I will work on this instead.
22 (other comment)
I noticed the coverage dropped a lot from my previous PRs. Sorry! I've written some parser tests. Not sure how much I can get in for the rest of v1.2, but i'll see what I can do.
@wakululuu (8 comments)1 (commented on others PR)
McScheduler is a a one-stop solution
Typo here
2 (commented on others PR)
* **`assign`**`s/3 w/2 r/Cashier` : Assign the 2nd worker on the list to the 3rd shift on the list as a Cashier.
Inconsistent spacing around : compared to the rest of the bullet points
3 (commented on others PR)
<img src="images/sigmund-c.png" width="200px">
Requirement to use .png
4 (commented on others PR)
>space> can be removed to be consistent with the rest of the commands
5 (commented on others PR)
There are a few other similar instances below as well
6 (commented on others PR)
if (test.trim().isEmpty()) {
7 (commented on others PR)
Perhaps remove >space> here as well. Same issue in ShiftEditCommand.java and RoleRequirement.java
8 (commented on others PR)
Perhaps add this note after the sequence diagram to explain its inaccuracy.
<div markdown="span" class="alert alert-info">:information_source: **Note:** The lifeline for `AddCommandParser` should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram.
</div>
9 (commented on own PR)
Great idea, thank you!
@TheSpaceCuber (8 comments)1 (commented on others PR)
Is CliSyntax necessary?
2 (commented on others PR)
Can just import EditPersonDescriptor instead?
3 (commented on others PR)
er not sure use what name...com.eva?
4 (commented on others PR)
com.eva.logic would be better?
5 (commented on others PR)
I had some runtime error while trying to typecast, not sure if this'll work.
6 (commented on others PR)
But yeah probably waiting for the staff list i guess.
7 (commented on others PR)
Should we include pre-interview? I think processing means after the interview but no update yet right?
8 (commented on others PR)
Hi, should this be removed?
9 (other comment)
tutorial only, pls don't merge
10 (other comment)
LGTM
11 (other comment)
LGTM
12 (other comment)
filename needs to be github username?
13 (other comment)
LGTM
14 (other comment)
wait idk why isaactin.md is under delete
15 (other comment)
LGTM!
16 (other comment)
LGTM with some small namings.
17 (other comment)
LGTM
18 (other comment)
LGTM. Any unforeseen bugs will have to be resolved after commands are added.
19 (other comment)
LGTM
20 (other comment)
Okay I merge first! Thank Ben for comments.
@AlexCQY (8 comments)1 (commented on others PR)
Might want to remove the email part as our student model doesnt have email.
2 (commented on others PR)
Might want to remove the "e/amongus@isgood.com" part and also the "email address"
3 (commented on others PR)
nice
4 (commented on others PR)
nice
5 (commented on others PR)
might want to add a period here to standardize
6 (commented on others PR)
should this be "...not allowed in paymentDate"?
7 (commented on others PR)
Just to clarify for now we cant edit the additional details?
8 (commented on others PR)
okay thanks
9 (commented on own PR)
okay I have resolved this. The original AB3 uses this method as a weaker notion of equality between students. Because if we check all field && then it will become the equals method. But since we defined student to have this 4 compulsory fields, we can update it to check these fields. But I think we should not include the checks for admin fields when it comes in.
10 (commented on own PR)
okay done thanks
11 (commented on own PR)
Agreed. I have made the changes
12 (commented on own PR)
Okay thanks!
13 (commented on own PR)
Hmmm what I thought was that input a date is more flexible and convenient. For instance user might want to look up a his/her schedule on a particular date, our app would translate that date internally to the day of week so that the user wouldnt need to check up the calendar. I was thinking of an extension along this lines too, where user could input a string indicating the day or week. What do you think?
14 (commented on own PR)
Okay thanks!
15 (other comment)
Good point. This would make searching and filtering the year data easier. Based on this, I guess we may have to exhaust all possible levels of student that a tutor may have? My concern is that IP, IB, MOE mainstream tracks have different naming in their levels. Furthermore, there could be other level naming, for eg a tutor teaching music or arts may have different levels naming for their students.
16 (other comment)
Oh ya our target was pri/sec/jc nice.
@sogggy (8 comments)1 (commented on others PR)
I think this portion shouldn't be changed!
2 (commented on others PR)
change the variable name to 'name'
3 (commented on others PR)
change variable name to name
4 (commented on others PR)
i think we should leave these empty lines out, i.e. shouldn't have these empty lines!
5 (commented on others PR)
here as well
6 (commented on others PR)
remove the empty lines!
7 (commented on others PR)
can add assertion here so that we can know where's the error!
8 (commented on others PR)
Will need to do error handling for indices that are greater than the number of expenditures in the future
9 (other comment)
My changes have been added. We can close the issue once the PR is merged 👍
10 (other comment)
LGTM! Thanks!
11 (other comment)
Bad pull request! Will close this
12 (other comment)
fetch from upstream first before submitting pull request
13 (other comment)
Close #80
14 (other comment)
close #142
@peter-yeh (8 comments)1 (commented on others PR)
This line should be above import seedu.address.*
That may be the reason why u failed the checks
2 (commented on others PR)
But I think you don't have to change alr, cause we won't be using this
3 (commented on others PR)
updatefilteredPersonList is not changed.
4 (commented on others PR)
are you missing a add-itinerary?
5 (commented on others PR)
I just realised this too, and this title should have 4 hashtag instead of 3
6 (commented on others PR)
I feel that we shouldn't hard code the numberings, so it's easier to add on items next time without renumbering
7 (commented on others PR)
And I think this would be auto generated without us typing it manually?
8 (commented on others PR)
As in this part can be skipped, cause it would be auto generated if you update your headings.
9 (commented on own PR)
I think this is deleted
10 (commented on own PR)
This isn't deleted for some reason...
11 (other comment)
to check if I am still within my budget
12 (other comment)
...to track if I am going to exceed my budget
13 (other comment)
This thing fail my second commit because of a missing /next line
14 (other comment)
Wah this looks good to me alr
15 (other comment)
this looks good
16 (other comment)
The code couldn't pass test cases after I merged yuxuan's PR into master. So I tried to resolve the test cases on GitHub. Turns out it isn't so simple.
17 (other comment)
Merge this after Add itinerary #98 has merged
18 (other comment)
it's a feature
19 (other comment)
change command layout to add-itinerary-attraction so the parser does not need to accept 3 words command
@TianYong-Goh (8 comments)1 (commented on others PR)
Would it be better to remove this statement? As I feel our product is not a series of the addressbook.
2 (commented on others PR)
Is it better to remove these Level 3?
3 (commented on others PR)
Just curious is this the Url part?
4 (commented on others PR)
Is this the sequence diagram explanation?
5 (commented on others PR)
Isn't we decide to use 1. 2. 3. and put the step under the sequence diagram?
6 (commented on others PR)
Same as above
7 (commented on others PR)
Can place this after the sequence Diagram? and also number it as 1. 2. 3. instead of Step1 Step 2 Step 3
8 (commented on others PR)
Might want to consider changing this to the explanation like delete consumption and delete ingredients
9 (commented on own PR)
Jia qi changes the way of adding instruction and I not sure how does it look like as that part is not merged to the master yet. The addRecipeCommand UG documentation is base on what I know so far.
10 (commented on own PR)
Ok changed. Will push later.
11 (commented on own PR)
Same as the previous reply.
12 (other comment)
lgtm
13 (other comment)
Has already Opened by Caitlin
@FH-30 (8 comments)1 (commented on others PR)
Great job following the coding standards!
2 (commented on others PR)
Great that you have extensively tested the added functionalities!
3 (commented on others PR)
Might need to rename person to flashcard
4 (commented on others PR)
Same here.
5 (commented on others PR)
Same here.
6 (commented on others PR)
Same here.
7 (commented on others PR)
Great job reducing the number of lines!
8 (commented on others PR)
There are still instances of person and addressbook here and there, might need to rename them.
9 (commented on own PR)
Fixed it!
10 (commented on own PR)
Fixed it!
11 (commented on own PR)
No problem!
12 (other comment)
Code quality closely follows the coding standard, good job! Testing is well done, tested many cases for each of the functionalities added. LGTM!
13 (other comment)
Thanks for helping with this, much appreciated!
14 (other comment)
Everything looks good except that I think the arguments for the
parsemethod in the sequence diagrams should have"".
i.e. it should be
parseCommand("add q/question ans/ Answer")instead of justparseCommand(add q/question ans/ Answer)
From the diagrams in addressbook's documentation and the test command documentation, they don't seem to be using the "". I'm not so sure whether it would be best to follow their practices though.
15 (other comment)
The diagram looks good, however I think that the AddOpenEndedQuestionCommand should have a cross indicating that it is no longer referenced after the execute() method is called on it.
@AudreyFelicio (8 comments)1 (commented on others PR)
Should you add a space between #### and Use so that the format would be consistent with the other files?
2 (commented on others PR)
Is all the location a placeholder for now?
3 (commented on others PR)
Why is all person changed to stock?
4 (commented on others PR)
Based on the CS2103T website, the UI mockup should be put on docs/images/Ui.png instead of docs/images/Warenager.png.
5 (commented on others PR)
I agree with Ashley here.
6 (commented on others PR)
Yes, I think it would be good to include deleting multiple stock at once.
7 (commented on others PR)
I think the indentation is too large, should only be 8 spaces.
8 (commented on others PR)
Maybe consider removing this first so the code will be cleaner. Can always refer to this later by viewing GitHub commit history
9 (commented on own PR)
You're right Ashley, it does not make sense for a quantity to be negative. Thanks for spotting this problem, I will fix this immediately.
10 (other comment)
update sn/fairprice1 iq/1000 sn/fairprice2 seems to be incrementing both stock by 1000. Is this the expected behavior?
Yes, since now we allow to update multiple stocks at once.
11 (other comment)
Some merge conflicts still need to be resolved. @LimZeWeiDennis
12 (other comment)
Some merge conflict arises due to merging other PRs. @amylzting
13 (other comment)
Done implementing both ascending and descending order
@CodingCookieRookie (8 comments)1 (commented on others PR)
Should we remove this and use run in debug mode when its finalised
2 (commented on others PR)
I like your usage of stubs!
3 (commented on others PR)
Pattern.matches throw some exceptions when dealing with some corner cases like. Perhaps String.matches() do as well?
4 (commented on others PR)
Perhaps studentAttributesList would be better here?
5 (commented on others PR)
Should this be AddStu instead of Add? Because there is a AddSes later
6 (commented on others PR)
Perhaps can remove this now ? 😃
7 (commented on others PR)
Perhaps can combine "If the argument is valid" with no argument ==> If argument is invalid, a ParseException...?
8 (commented on others PR)
Thanks for the suggestion but if the argument is invalid, it throws a CommandException but if argument is empty it throws a ParseException. Hence, this is why I separated them.
Noted thanks for clarification
9 (commented on own PR)
oops LOL yeah thanks!
10 (commented on own PR)
yup thanks for spotting the mistake!
11 (other comment)
LGTM
12 (other comment)
LGTM. However, would changing
currenttocurrent sessionmaybe make the command too long for the user to have to type? Maybe the rest of the team could chime in on this as well. @CodingCookieRookie @YuunoKun @MarcusTw
I would prefer current personally 😃
13 (other comment)
LGTM
@jayarengam (7 comments)1 (commented on others PR)
Consider replacing address with NusnetId
2 (commented on others PR)
rename field
3 (commented on others PR)
rename field
4 (commented on others PR)
Please update testcases
5 (commented on others PR)
Please consider changing name to NusnetIdTest
6 (commented on others PR)
Consider renaming field
7 (commented on others PR)
Consider renaming class to NusnetId (coding standard)
8 (other comment)
Breakdown of work:
@sc-arecrow:
As a TA, I can store the details of my students, so I can have quick access to them.
As a TA, I can view the details of a student, so I can have quick access to him/her.
@jayarengam:
As a TA, I can view the details of students, so I can have quick access to them.
As a TA, I can delete the details of students in my class, so I can still have quick access to them.
9 (other comment)
KIV for later when more additions are made to website.
10 (other comment)
Missing: user guide
11 (other comment)
Resolved by #58.
12 (other comment)
Tests will be added later.
13 (other comment)
No longer required
@sgn00 (7 comments)1 (commented on others PR)
Can add a regex checker to ensure the note is not an empty value. Reference Question / Answer class.
2 (commented on others PR)
This will be changed to a null check instead if we use null instead of ""
3 (commented on others PR)
change person to flashcard
4 (commented on others PR)
person
5 (commented on others PR)
change tag to tagged
6 (commented on others PR)
Check other headers to match them.
7 (commented on others PR)
too many columns. Remove at least 2 to make it more readable.
@jonahtanjz (7 comments)1 (commented on others PR)
Maybe can remove this line as the repeat step will be doing the check?
2 (commented on others PR)
Perhaps can remove "System is the SimplyKitchen" as "System" is not used below?
3 (commented on others PR)
Should "String expiry date" be "String expiryDate" to match the argument?
4 (commented on others PR)
Perhaps can consider "Searches for food items in the inventory with descriptions matching any of the given keywords." instead?
5 (commented on others PR)
Model#redoAddressBook() should change to FoodInventory
6 (commented on others PR)
Perhaps can change these to FoodInventory?
7 (commented on others PR)
JavaDoc contains address book
8 (commented on own PR)
Yes overlooked that. Will make change back.
9 (commented on own PR)
Yup will change back.
10 (commented on own PR)
Yup sounds good to remove priority.
11 (commented on own PR)
Good catch! Will change.
12 (commented on own PR)
Ok noted. Will change.
13 (commented on own PR)
Thanks
14 (commented on own PR)
This is to ensure that both upper and lower cases are accepted as a valid command. For example, "add d/tuna p/HIGH" or "add d/tuna p/high" or "add d/tuna p/High" are all valid commands.
15 (commented on own PR)
Alright will change.
16 (commented on own PR)
Yup switch statement will be better. Will change.
17 (commented on own PR)
Yup good catch! Fixed
18 (commented on own PR)
Alright changed.
19 (commented on own PR)
Changed. Thanks
20 (commented on own PR)
Alright. Added new tests
21 (commented on own PR)
Alright. Changed
22 (commented on own PR)
Ok. I think I will change to four valid predicates.
23 (commented on own PR)
Noted. Will change.
24 (commented on own PR)
Ok. Will change these as well as the '4' to 'four' for the predicates.
25 (other comment)
Need to test feature
@pennhanlee (7 comments)1 (commented on others PR)
I get what you're doing in this line but the test constant VALID_TOTAL_PAGES_JANE_EYRE is abit misleading. Maybe you might want to consider having a new test constant?
2 (commented on others PR)
the constructor Bookmark() creates a default bookmark with value 0. Perhaps we can discuss which approach we want to take for setting up a Default Bookmark of Pg 0?
3 (commented on others PR)
This method looks quite long (60 LOC) but the recommended SLAP length is ~30
Maybe it will be better to separate the checking of Valid Find command and the parsing of the FindCommand?
Also, is there a reason for Line 65 to reset the Prefix count?
4 (commented on others PR)
Maybe it will be better to immediately cast the float type upon instantiation instead of typecasting at Ln36?
Else, LGTM!
5 (commented on others PR)
Can you change the link of the MainWindow.fxml please?
6 (commented on others PR)
Just wondering if this indent style is deliberate?
7 (commented on others PR)
Please change the Jdoc here to fit Notes, thank you!
8 (commented on own PR)
Looks like there are some discrepancies between our UG and DG. Let's go over this again in the next meeting. In the meantime, I'll make the relevant changes! Thanks!
9 (commented on own PR)
Must have missed this part out. Thanks!
10 (commented on own PR)
Good recommendation! Thank you for spotting this. I've made the relevant changes.
11 (commented on own PR)
Thanks for pointing this out! I have made the changes.
12 (commented on own PR)
Thanks for spotting this!
13 (commented on own PR)
That's a good point, I have changed it. Thanks!
14 (commented on own PR)
Thanks for the recommendation! I have included HashMap as an attribute. Thanks!
@GilbertTan19 (7 comments)1 (commented on others PR)
Great abstraction!
2 (commented on others PR)
Yeah, I think can return answer instead of String.
3 (commented on others PR)
Great assertion!
4 (commented on others PR)
Great abstraction!
5 (commented on others PR)
Great use of logging!
6 (commented on others PR)
Nice defensiveness of code!
7 (commented on others PR)
Great Absraction!
8 (commented on own PR)
Thankyou, I have edited the PR!
9 (commented on own PR)
Yup, changed alr!
10 (other comment)
I'll do it in another branch, cause I try to solve the conflict locally but cannot push to my repo.
@hogantan (7 comments)1 (commented on others PR)
Should Year allow more than just digits due to distinctions such as "Primary 2" and "Secondary 2" ?
2 (commented on others PR)
Maybe there could be a more intuitive command word such as olpd (overdue last paid date) or maybe just lpd or od or overduepayment. I was thinking maybe something along the lines of payment date since the user is more familiar with the term as they input it as payment date (d/) so maybe something with date would make it easier for the user?
3 (commented on others PR)
I think you might have to change this to overdue as well!
4 (commented on others PR)
Address book could be changed to Reeve here
5 (commented on others PR)
If we are finding class time with respect to dayofweek, then would that mean that the user input of a specific date is redundant? If we just convert the specific user input date in dayofweek, we could just ask user to input 1,2,3,4,5,6,7 (Integer day of week).
6 (commented on others PR)
Oh that is true also. It is easier for a user to remembers the current date rather than the specific day! If we assume this, then I think the current implementation is fine.
7 (commented on others PR)
Could this be studentToDeleteDetail instead?
8 (commented on own PR)
Right! Thanks for pointing it out! I have made the necessary changes.
9 (commented on own PR)
Right! Thanks for pointing it out! I have made the necessary changes.
10 (commented on own PR)
Right! Thanks for pointing it out! I have made the necessary changes.
11 (commented on own PR)
Right! Thanks for pointing it out! I have made the necessary changes.
12 (commented on own PR)
I kind of just followed what was already in place. I also felt that the brackets just makes additional details easier to organize visually for now as multiple additional details could look very messy and hard to separate (for easy viewing) without the brackets.
13 (commented on own PR)
Oops. My bad. Thanks for pointing that out!
14 (commented on own PR)
Yea I will be adding the admin fields when doing up the updated test cases.
15 (commented on own PR)
Oh I see, I will look into what this other module is. As of now, the space was added just to space out the different additional details when it is being displayed in the console (when a student has been successfully added).
@maguireong (7 comments)1 (commented on others PR)
Maybe can update along the way?
2 (commented on others PR)
Might have missed this change out, should it be DeleteSessionCommand here?
3 (commented on others PR)
Just to check, so this sessionIndex here only contains the updatedSessionIndex? Because in the EditScheduleDescriptor, there's both sessionIndex and updatedSessionIndex, so it may a bit confusing if sessionIndex is referring to updatedSessionIndex here, especially if Bennett is going to implement the other portion
4 (commented on others PR)
Just wondering why these few added methods here return null
5 (commented on others PR)
not sure if a different prefix should be used instead because there are a number of commands with prefix p/ already, just with starting different command word
6 (commented on others PR)
true, but that's why initially I added in session index as well, we always have all 3 parameters so it won't be too confusing to see if its session index or updated session index, but of course we need to update both values which might take up extra work
7 (commented on others PR)
yeap and period is sview as well, hmm maybe pd/ like payment done? but its solely just to differentiate with the other prefixes so that it won't be too confusing
8 (commented on own PR)
ohh yeahhh okay i'll change that, other than that, anything else?
9 (commented on own PR)
yea too many files, but I tested with the test cases and ran the main, all seems well but 1 part says NonExistentFile.json file not found, not sure if it was there before I did all this, but I doubt so
10 (commented on own PR)
for this, there are some errors when I change it to clients, not really sure how to solve them, it somehow fails 2 test cases but it passes the checkstyle test on Github, regarding the other checkstyles, I'll amend them accordingly thanks!
11 (commented on own PR)
there will be 5 test case errors because the json files are all Clients instead of clients if I'm not wrong
12 (commented on own PR)
what do you mean by the actual data file?
I've already made the changes to both of the mentioned files, but I still have 2 tests that failed, 1 of which is this screenshot, but I can't seem to find anywhere with Clients already
>img width="1326" alt="Screenshot 2020-09-23 at 6 46 56 PM" src="https://user-images.githubusercontent.com/58878948/94002982-31920e80-fdcd-11ea-8f13-4d8404aeb11d.png">
13 (commented on own PR)
hmm yeap I thought so too, I've already edited those json files but the 2 errors in the screenshot above is still present though
14 (commented on own PR)
okay sure but it will fail the checks here
15 (commented on own PR)
hmm but for now, we are still largely following AB3 so it should still be there?
16 (commented on own PR)
okay sure I'll change that
17 (commented on own PR)
hmm, the other time when I asked for a workaround in the group, it was regarding this issue but I think changing it to String works to actually! Anyway in the tests, I've added the conversions to LocalDateTime and int respectively, so it works as well.
18 (commented on own PR)
I think both ways work but when I was doing it the other time, I didn't think much into it so I just put in the respective params into the method.
19 (commented on own PR)
Hmm I would think if you want to add schedule, then you show client and session but since we're editing, we show list of schedule?
20 (commented on own PR)
oo okay sure i'll make that change, didn't know that it signifies that
21 (commented on own PR)
Yeap its been encapsulated in line 65 to 69
22 (commented on own PR)
I would think that its good clearer to have the values here too, esp when I'm debugging the tests and its also required in createEditedSchedule method
23 (commented on own PR)
yep sure I can remove that too, it was there for clarity sake when I was doing this
24 (commented on own PR)
For now, it shows Invalid Command Format, I get what you mean, maybe after you implement those features that you can try them out? cuz now all 3 indexes are required before your features are being implemented
25 (commented on own PR)
But I think for editclientdescriptor, the index is to filter our the client, but for my case, both client and session index are required to filter out the schedule just like how your deleteSchedule is like, it filters out the relevant schedule before it can be deleted
26 (commented on own PR)
will the updated change work
27 (other comment)
There's a huge chunk commented out in
EditSessionCommandTest.java
Are we going to need it? If not, perhaps it is better to remove it first and create a new Issue for this.
Other changes look sensible to me
That's for future tests because it requires the find session function for it to work, that's why I commented it out for now
@angrybunny123 (7 comments)1 (commented on others PR)
I agree with leyang we can make use of the existing edit command in AB3 😄
2 (commented on others PR)
Some "person" variables can still be changed to "book"
3 (commented on others PR)
As Le Yang has mentioned, the javadocs and test names can be updated as well
4 (commented on others PR)
Maybe it would be better if you named it PREFIX_NOTE instead, even though they both refer to "/n", for clarity
5 (commented on others PR)
Am not too sure if it is necessary to check for duplicate notes, but I think it's fine to include
6 (commented on others PR)
I'm not too sure if we should include a conditional to check valid index in the activity diagram, because this diagram doesn't show that an error would be thrown.
7 (commented on others PR)
Not sure if it should be just execute() or n.execute(), let's discuss it tomorrow!
8 (commented on own PR)
That's a good suggestion Penn Han, will work on it now!
9 (commented on own PR)
I have made the changes you suggested Penn Han, do let me know if it looks good to you. Thanks!
10 (commented on own PR)
Yes, I added that because I wanted for there to be stricter input validation when using the sort command.
11 (commented on own PR)
Will update the test case names. Thanks for the comprehensive review, Wai Kye 😃
12 (commented on own PR)
I was deciding between pages read and percentage of book read, and I felt that pages read was more meaningful, but we can discuss this in our next meeting!
13 (other comment)
LGTM!
14 (other comment)
Looks good to me, Wai Kye!
15 (other comment)
One small issue I see in the UI screenshot is in entry 4 (the Gordon Ramsay entry), the text isn't centralized with the border. Other than that, LGMT!
16 (other comment)
LGTM!
@hakujitsu (7 comments)1 (commented on others PR)
Based on what I see, it looks fine when the page is published, and the spacing is the same as the other pictures.
2 (commented on others PR)
Based on what I see, it looks fine when the page is published, and the spacing is the same as the other pictures.
3 (commented on others PR)
Minor thing, but it would be good to standardise referring to the appointment as {@code appointment} in the JavaDocs as per hasAppointment and addAppointment!
4 (commented on others PR)
Should there be a full stop at the end of the javadoc? Very minor thing though! Is also in some other files
5 (commented on others PR)
Should there be a full stop at the end of the javadoc?
6 (commented on others PR)
Is this something that was implemented in this PR? I didn't experience any filtering out of past meetings when executing commands to refresh the display.
7 (commented on others PR)
Great, thanks for clarifying! Will approve and merge.
8 (commented on own PR)
Added more sample sales data and remarks as requested!
9 (commented on own PR)
Fixed in latest commit!
10 (commented on own PR)
Good point, I overlooked that. I think I'll keep that implementation and change the JavaDocs, since comparing the lexicographical order of the buyer's name is difficult to implement without having model as one of the parameters.
11 (commented on own PR)
Renamed as suggested!
12 (other comment)
I think that should be fine, we could relook it if the refreshes cause any issues later!
@siddarth2824 (7 comments)1 (commented on others PR)
It says here that you are only allowing the user to add 2 decimal places. But when I typed in an amount with more than 2 decimal places, the input was still allowed. The picture shows the image where the user input of more than 2 decimal places was allowed.
>img width="1217" alt="Screenshot 2020-10-23 at 10 56 55 AM" src="https://user-images.githubusercontent.com/48427064/96951151-79b46600-151e-11eb-9645-8b972367787a.png">
2 (commented on others PR)
Since the user was allowed to input an amount of more than 2 decimal places. When I restarted the application the application opened up with no data on the previously stored transactions. An exception was thrown and then an empty FinanceTracker was started. The image below shows the exception being thrown when I opened the application again:
>img width="988" alt="Screenshot 2020-10-23 at 11 00 36 AM" src="https://user-images.githubusercontent.com/48427064/96951399-ffd0ac80-151e-11eb-98c4-0639ce135973.png">
3 (commented on others PR)
Just a small minor thing. I do not think there should be a new line between the comments and its java doc.
4 (commented on others PR)
/**
* JSON-friendly version of {@link MonthlyBudget}.
*/
5 (commented on others PR)
/**
* Constructs a {@code JsonMonthlyBudget} with the given expense limit details.
*/
6 (commented on others PR)
/**
* Converts a given {@code MonthlyBudget} into this class for Jackson use.
*/
7 (commented on others PR)
/**
* Converts this Jackson-friendly adapted monthly budget object into the model's {@code MonthlyBudget} object.
*
* @throws IllegalValueException if there were any data constraints violated in the adapted transaction.
8 (commented on own PR)
The reason for this is because I have only added the AddFrequentIncomeCommand hence I did not write the other methods within FrequentIncomeList yet. Therefore I did not write the tests for the other methods.
9 (other comment)
PR has been picked up by the grading script.
10 (other comment)
Resolves #145.
11 (other comment)
Resolves #146.
@jeminsieow (6 comments)1 (commented on others PR)
Remember to change the method name to match Logs. This is repeated for the other tests in this file
2 (commented on others PR)
Remember to change variable names from Persons to Logs
3 (commented on others PR)
Shouldn't the withLog() method take in a Log object as an argument instead of 2 strings?
4 (commented on others PR)
Remember to change readAddressBook to readLogBook. This is repeated throughout the file
5 (commented on others PR)
Reminder to change variable names to match Logbook. This is repeated throughout the file
6 (commented on others PR)
Remember to refactor saveAddressBook to saveLogBook
7 (commented on own PR)
In the original person class, equals() method compares both identity and data fields. Removed identifier fields for isSameLog() method
8 (commented on own PR)
Yeap for sure, thanks for checking!
9 (other comment)
LGTM
10 (other comment)
I don't think this has been completed yet
11 (other comment)
LGTM
12 (other comment)
Remember to pull and fix the merge conflicts
13 (other comment)
There are some merge conflicts to be resolved here.
14 (other comment)
LGTM
@jzwoo (6 comments)1 (commented on others PR)
Should we change the variable to VALID_INSTRUCTORS too?
2 (commented on others PR)
"keywords" might be better since we can have multiple keywords 😁
3 (commented on others PR)
Hmm for this part is it better to say "Assigns the contact/instructor at the specified index to the module code"? 🤔
4 (commented on others PR)
May I also just check if there is a check for the preamble? So something like "find sjdjahdsj n/ john" would not work.
5 (commented on others PR)
Sorry can I just check if there is a check for multiple prefixes 😄
6 (commented on others PR)
Should we extract this out as a method? To follow the SLAP principle
7 (commented on own PR)
Alright, I've changed it in the next commit.
@mkeoliya (6 comments)1 (commented on others PR)
These issues are missing.
2 (commented on others PR)
Also missing are #27, #25, #24, #23.
3 (commented on others PR)
Should be removed.
4 (commented on others PR)
Yep my bad! Was referring to the create compound commands user story only. Could you remove it?
5 (commented on others PR)
Perhaps you forgot to include #58 and #59?
6 (commented on others PR)
AddCommand should be replace by ReallocateCommand
7 (other comment)
Duplicate of https://github.com/AY2021S1-CS2103-T16-3/tp/issues/15
8 (other comment)
LGTM!
9 (other comment)
Closed via #47, #48, and #46
10 (other comment)
Closed via #64
11 (other comment)
Closed via #57 and #61
12 (other comment)
Closed.
13 (other comment)
Closed.
Note to all: To be updated after we finish v1.2.
14 (other comment)
Closing since the tP dashboard now reflects all changes.
15 (other comment)
To be closed after #78
16 (other comment)
Closed by #78
17 (other comment)
Closed by #71
@underthehai (6 comments)1 (commented on others PR)
i think depends on the type if we refer duplicate as having the same name. Activity and accommodation may have duplicated names? But for person maybe not.
Or duplicate meaning all other fields (cost, tag) the same, then I think we should check for duplicates!
2 (commented on others PR)
okies, i can add on!
3 (commented on others PR)
Is it supposed to be MM instead of 3 'M's?
4 (commented on others PR)
ohh its abbreviated form!
5 (commented on others PR)
I think it is throwing an exception because the edit command ensures that at least one field is edited but the command and builder is building the exact same fields so there wasn't any editing done
6 (commented on others PR)
Is it because maybe more than 1 travel plans can have the same first name?
7 (commented on own PR)
yeap, I will change it to show
8 (commented on own PR)
I was thinking that since we can view the travel plans at the top directory, we can also modify the start and end date there too. Or is it better to restrict the editing to within travel plan directory?
9 (commented on own PR)
yes it is supposed to be numbers, i will change it
10 (commented on own PR)
I tried to follow the order given in the UI
11 (commented on own PR)
I am intending to specify it to "displayed activity list"!
12 (commented on own PR)
yes, I will change it. thankss
13 (commented on own PR)
okay, fixed!
14 (commented on own PR)
yup, travelplan too. I updated them
15 (other comment)
LGTM
@akgrenSoar (6 comments)1 (commented on others PR)
Need to rename the image from joeytoh.JPG to joeytoh.png
2 (commented on others PR)
**Use case: Edit tag**
Formatting
3 (commented on others PR)
Would be nice to configure your IDE imports
https://se-education.org/guides/tutorials/intellijCodeStyle.html
4 (commented on others PR)
This issue is meant to remove the bad code commandText.equals("list").
Suggestion is to implement commandResult.isPersonList() or its equivalent alternatives.
5 (commented on others PR)
This is not required. The issue of tag list not auto-refreshing will resolve itself after the change in Model
6 (commented on others PR)
public static final String VALIDATION_REGEX = "^[A-Za-z0-9][\\w]{3,}[A-Za-z0-9]$";
For aesthetic. No real impact.
7 (commented on own PR)
It is supposed to be tagfind. Pushed a commit to change all commands to follow lowercase
8 (other comment)
Closes #6
Everyone's changes are here. Should be good to go.
9 (other comment)
Closes #7 , Closes #9
10 (other comment)
Better to postpone this to next iteration.
Changing the model will require changes in Logic, Storage, and massive changes in JUnit Tests
11 (other comment)
Not an epic, but requires massive code change
12 (other comment)
LGTM
13 (other comment)
LGTM
14 (other comment)
LGTM.
Minor nitpicks:
Perhaps lowercase might be better than camelcase for command name (i.e. taglist instead of tagList)
Test coverage can be improved for
java/seedu/address/logic/parser/ProjactParser.java
java/seedu/address/logic/commands/CommandResult.java
15 (other comment)
the codecov report automatically updates itself. It is showing the codecov for the latest commit already
16 (other comment)
This is a prerequisite for issue #49
@nguyendqminh (6 comments)1 (commented on others PR)
Should be "of the module [...]"
2 (commented on others PR)
Should be "of the module [...]"
3 (commented on others PR)
Remove the comment
4 (commented on others PR)
Maybe use Module.TYPE instead of "M" for better maintainability?
5 (commented on others PR)
This is indeed correct; however I believe it's better to have a separate function to handle this instead of importing from the irrelevant Address class.
6 (commented on others PR)
Same as above.
7 (commented on own PR)
I am not sure; we will update this section constantly, but the line might be unnecessary. I'll remove it for now.
8 (commented on own PR)
Update: fixed.
9 (commented on own PR)
Do you feel "There is no module that matches the given module code" is better?
10 (commented on own PR)
Noted with thanks!
11 (commented on own PR)
Yeah, this is for clarity (and just in case we want to have different keywords for them later on).
12 (commented on own PR)
Agreed, I was halfway through implementing when I realized the "time" parameter should've been named "date" 😃 I will change "time" to "date" later.
13 (other comment)
Noted with thanks. I will finish it by tomorrow (Sat) 6pm.
14 (other comment)
Dear Minh
Currently there is one 1 use case, can you add more use case for our app? I think for v1.2 we have already proposed quite a number of features
Also, can you check again to see if there is any obvious user storie missing?
Thank you
Noted, I am working on it now. Will get this done by tomorrow (Tuesday) 6pm.
@lucastai98 (6 comments)1 (commented on others PR)
is this proper grammar?
2 (commented on others PR)
is this proper grammar?
3 (commented on others PR)
wait really its supposed to be delete1 not delete 1?
4 (commented on others PR)
wait got one more here, accidentally delete the space?
5 (commented on others PR)
same issue as prev pr?
6 (commented on others PR)
same
7 (commented on own PR)
because deadline is not a compulsory parameter of Task, and will cause error if the deadline is set when instantiating
@PrestonTYR (6 comments)1 (commented on others PR)
Shouldn't weight be included in this check?
2 (commented on others PR)
Shouldn't comment be at the end just like all the other fields?
3 (commented on others PR)
Did you forget to add the test cases? 😄
4 (commented on others PR)
Should the NoteCommandParser constructor be taking a preset patient as a field?
5 (commented on others PR)
Not very important, but wouldn't be better if 2 models are only equal if they have the same context as well?
6 (commented on others PR)
Would it be better if model had a set...() method that called context.set...() instead? It works either way though 😄
7 (commented on own PR)
yep added 😄 I missed it the first time
8 (commented on own PR)
Can u elaborate a little? Because I don't what you're talking about
9 (commented on own PR)
Theres a test for invalid index in an unfiltered list that checks for that already 😄
@VaishakAnand (6 comments)1 (commented on others PR)
Minor issue, could you change users to students, because its a list of students not users. Otherwise, LGTM!
2 (commented on others PR)
Should be && instead of || for school and year.
The student is the same only if all the field values are the same.
3 (commented on others PR)
Should be detailList, instead of tagList
4 (commented on others PR)
I understand you want to separate the syntaxes, but I feel these should be in CliSyntax with the other prefixes instead, so that all the prefixes can be found / accessed easily in a centralised location, rather than all over the place. It could just be separated from the other Prefixes in a different block of code
5 (commented on others PR)
Minor suggestion, could replace prefix with field instead, so that a non-technical user reading the user guide can better understand.
Eg: The s/ field marks an unanswered...
6 (commented on others PR)
Need to change TIME_FORMATTER to OUTPUT for both startTime and endTime
7 (commented on own PR)
okay, removed
8 (commented on own PR)
Oops! Thank you, i've fixed it!
9 (commented on own PR)
Fixed, thanks!
10 (commented on own PR)
Okay, resolved
11 (commented on own PR)
Good catch! I'll remove it in my next PR.
12 (commented on own PR)
Good suggestion! I've implemented it in my latest commit.
13 (commented on own PR)
Thanks again, I've just implemented this in my latest commit.
14 (commented on own PR)
Correct, we can't edit for now. I can do a separate PR to allow for such an edit
15 (other comment)
Good point, I'll do so in my next PR, thanks!
@pockii (6 comments)1 (commented on others PR)
i think it should be tag edit ... instead of edit tag...?
2 (commented on others PR)
i think this should be edit tag/tag edit?
3 (commented on others PR)
should we include a case for when the given tag name is also invalid? (e.g. t/ is missing)
4 (commented on others PR)
I think we should change this to reflect Projact's aim instead?
5 (commented on others PR)
conflicts with master branch
6 (commented on others PR)
so just to clarify, this would be done by kk right?
7 (commented on own PR)
oh ya, thanks!
@ernestlim8 (5 comments)1 (commented on others PR)
Should this be deleting a specific item in the current order instead?
2 (commented on others PR)
Can consider adding an extension where the quantity of item is negative
3 (commented on others PR)
should this be add commands instead?
4 (commented on others PR)
Should the second sentence be phrased as "There are at least two items in the order" for better readability?
5 (commented on others PR)
Perhaps this OrderItem can be renamed to orderItem for better readibility?
@dcchan98 (5 comments)1 (commented on others PR)
this should still be person, not changed to food ( issue occured when using assisted refactoring to change all person to food)
2 (commented on others PR)
Same as above
3 (commented on others PR)
same thing as above
4 (commented on others PR)
small issues but we should change to "contain +ive numbers"
5 (commented on others PR)
HAHA can i have a serving of alice pauline?
6 (commented on own PR)
Alright!
7 (other comment)
I think this would create potential bugs. For example, assume there are food items with the same name, fat, carbs, protein, date but different tags in the fridge. Then you filter a tag name and delete the filter result. It might delete the wrong food item because
List#remove(E e)only removes the first occurrence of e.
To prevent this, I think you might need to update the
Food#equalsmethod
Hmm ok I get what you mean. As for changing the food definition, I think we should discuss on Saturday instead(Because if lets say someone eats 2 McSpicies, they may be the same food even if tagged for lunch/dinner). As for now, I will do a quick fix by always removing from index zero from the arraylist ( to prevent any sort of traversal errors) if the "wrong" food item is to be deleted. ( ie when FoodTwin1 is mistaken for FoodTwin2 and FoodTwin1 is deleted, the next FoodTwin1 would delete the next food Twin2).
@mhdsyfq (5 comments)1 (commented on others PR)
maybe can include that the add command prevents duplicate modules from being created? actually right.... as of now our application allows duplicates if they are not completely equal, should we address that?
2 (commented on others PR)
very minor nit: perhaps "Edit the details of a module...." would be better? 😅
oh! and also, i thought we were changing edit to edit {module code} instead of edit {index}? 😕
3 (commented on others PR)
i think might not be necessary to mention the save part cause if im not wrong the exit command doesn't do a final save before exiting 😄
4 (commented on others PR)
noice noted!
5 (commented on others PR)
HAHAHAHA true true true...... then either we stick with this or we must include the 'auto-save' in the other features ah
6 (commented on own PR)
thanks for spotting it bro 👍🏽 resolved! all checks passed now!
7 (commented on own PR)
Hmmm, what do you think about "...in GradPad for the module to be successfully displayed."? 🤔
8 (commented on own PR)
done!
9 (commented on own PR)
HAHAHAHA bro i just followed the given, not sure if correct syntax 😂 maybe i should just put the same line as the one above instead of putting "Similar to previous." 🤣
10 (commented on own PR)
oh ya its supposed to be help modules LOL cause its under "### Open Help Page". i'll fix it!
11 (commented on own PR)
not yet but im planning to implement it!
12 (commented on own PR)
ok will address this! thanks bro
13 (commented on own PR)
done!
14 (commented on own PR)
is disconfirmation a word HAHAHA this is a good suggestion (i changed the variable name to isCancel though)! makes the code look neater too 👍🏽
15 (commented on own PR)
HAHAHAHA i thought like with javadocs would be nicer LOL i'll remove!
16 (other comment)
hi
17 (other comment)
Good job bro - love the clean code 💯
Anyway I realise it was quite dumb of me to implement
ModularCreditsby storing a string value inside LOL cos now we need to retrieve that string and then parse it into int again when we use it. Do y'all think we should refactor this some time moving forward?
HAHA nah man its fine, but ya while i was doing jn i was actually wondering why the value of the ModularCredits was of type string 😅 however, if there's not much other things that require us to use it then i don't think it's necessary to refactor cause it might be troublesome, so it pretty much depends!
18 (other comment)
LGTM bro! good job 😄
19 (other comment)
LRGTM! super well done 👍🏽 👍🏽
@hanweic53 (5 comments)1 (commented on others PR)
This should be the correct link to our repo instead: (https://github.com/AY2021S1-CS2103T-T10-2/tp/tree/master/src/main/java/seedu/tr4cker/MainApp.java)
2 (commented on others PR)
As in the previous comment, some of the links in this file should change.
3 (commented on others PR)
"stores tr4cker data" instead? Same for the rest of this file haha
4 (commented on others PR)
As in the previous comment, it should be "tr4cker" instead of "taskDescription book"
5 (commented on others PR)
Misspelled "Examples"
6 (commented on own PR)
Yes you're right.
7 (commented on own PR)
Yes, you're right.
8 (commented on own PR)
I think using toString() is apt because what we want is a String representation of a Deadline.
9 (other comment)
Merged #15
10 (other comment)
Merged #16
11 (other comment)
Looks good to me, ready to merge.
@csiongn (5 comments)1 (commented on others PR)
Hihi I think our find command syntax has changed. So we need the 1 optional parameter after find to use the find command
2 (commented on others PR)
Hihi the find command syntax needs to be changed here also later.
3 (commented on others PR)
Should we remove the traces of address book?
4 (commented on others PR)
here also but i think rmb to change later
5 (commented on others PR)
Hi sflr but can I just clarify that having this line means that during execution of this, if the list is filtered then it would choose the index for student based on the filtered list but after adding it would go back to the non filtered list. Is this like the intended behaviour?
6 (commented on own PR)
Right thanks! I've just updated it!
7 (commented on own PR)
Thanks for the feedback, I've changed the testing method in ReeveParserTest! I've also refactored the way find command is implemented.
8 (commented on own PR)
Thanks for mentioning this, the branch was created before the updates were pushed but I've now merged the changes from master! I've also updated the user guide to clarify the behaviour of this.
9 (commented on own PR)
I think I added it in during testing but okay i think i'll remove it, thanks!
10 (commented on own PR)
I changed to public because I created a method getFindStudentDescriptorDetails in a testingutil StudentUtil that required access to the keywords to create the command. Would it be better to use getters instead?
11 (commented on own PR)
Yep something similar currently "sec 3" would match "sec 1-4", "p 3" and "s 3" but not "p3" or "s3" as it matches by whole words so "p3" is not "sec" or "3" hence it won't match. Same for "s3"!
12 (other comment)
Changing structure of student class so not being implemented anymore.
13 (other comment)
I think need update the CommandTestUtil file to this: https://github.com/AY2021S1-CS2103T-W15-2/tp/blob/master/src/test/java/seedu/address/logic/commands/CommandTestUtil.java
14 (other comment)
Yes I forgot to thank you for pointing that out! I've just uploaded them!
@pengxiangg (5 comments)1 (commented on others PR)
minor typo
2 (commented on others PR)
Minor changes to remove AB3 needed
3 (commented on others PR)
Minor changes needed to remove AB3 trace
4 (commented on others PR)
Minor changes
5 (commented on others PR)
Should it be assert isInDeck instead? Since the user needs to be in a deck before going into review mode (like the isInDeck still remains true if the reviewMode is true
@jmleong666 (5 comments)1 (commented on others PR)
Should we be consistent with whether to add full stops at the end of the description statement? I think the UG will look cleaner that way.
2 (commented on others PR)
Should we be consistent with whether to put a full stop after each step in the use cases? I think the DG will look cleaner that way.
3 (commented on others PR)
Should we format the datetime so that it is consistent with the Meeting toString() datetime format?
4 (commented on others PR)
Will modify the id setting implementation under my contact-archive branch!
5 (commented on others PR)
Does buyerId reflect the lexicographical order of the buyer name?
6 (commented on own PR)
Yeah I'll do a quick fix.
7 (commented on own PR)
I think the counter resets since a new AddressBook instance is initialised every time the app starts, so if we do a static variable we might have to store it into the storage file.
8 (commented on own PR)
Whoops missed out on commented unused imports. Will remove them asap!
9 (commented on own PR)
Might have accidentally removed it when merging. Will fix it asap!
10 (commented on own PR)
Will go for archive add.
11 (commented on own PR)
Might need some time to think about how to do this. Maybe put this under 1.3b? Need to work on other features.
12 (commented on own PR)
Yeah did too much Ctrl+C Ctrl+V. Will fix the naming asap.
13 (commented on own PR)
Whoops my bad. Will update on another feature branch.
14 (commented on own PR)
Will add them in this PR!
15 (commented on own PR)
Yeah should've considered that earlier.
@kelvinvin (5 comments)1 (commented on others PR)
Can remove the timestamp sentence
2 (commented on others PR)
Can remove the timestamp sentences in this section too
3 (commented on others PR)
It doesn't actually check for true right? Both this and delete sessions command will execute the command with just the force prefix
4 (commented on others PR)
confusing to User
5 (commented on others PR)
Is this the same as MSS step 3?
6 (commented on own PR)
updated!
7 (commented on own PR)
oops i just wrote v1.2. shud be fine?
8 (commented on own PR)
Yeapp sort by ascending startDate order. Will update the descriptions
9 (commented on own PR)
oh yes you're right, removing it
10 (commented on own PR)
ok!
11 (commented on own PR)
Oh think it was an accident
12 (commented on own PR)
Not sure if it'll make test cases harder to create in future?
13 (commented on own PR)
ModelStub needs these methods because it implements Model
14 (commented on own PR)
Oh yes, thanks
15 (commented on own PR)
Think this duplication happened from merging from both @dhafinrazaq and your branch? Will keep hasAnyScheduleAssociatedWithSession()
16 (other comment)
Right sidebar previously had a scrollbar that doesn't show now, but I think it's fine not to have it. Lgtm!
Vbox have auto hide scrollbar if not necessary. So maybe your screen size bigger?
Oh I think its just my screen then. Can merge
17 (other comment)
The division of 3 sections is in the other PR. Should we bold the nextSession line?
18 (other comment)
19 (other comment)
If i read it correctly, changes to existing classes is to enable comparing sorting clients (compared by name) and sessions (compared by interval start time) right?
Yep. For schedules, I'm comparing its session's interval start time as well.
20 (other comment)
Looks good for the most part, but is it possible to combine
ViewAllCommandandViewWeekCommandinto saysession.ViewCommandwith commandsview.
It will default to viewing all sessions in the upcoming week, but if you pass a flag such as
sview p/ allthen it will show all sessions ever created. The default issview p/+1 week
Okay with moving it to session and changing the keyword to sview. Not sure if there's a need to use p/ tags since there's only 2 variations in mind now. But if so, sview p/week and sview p/all? Think we can discuss it later
21 (other comment)
Weight -> optional argument in Edit Schedule
22 (other comment)
Just wondering why the comparator is null? 🤔
Ahh null will use the natural comparator for Session.. but yeah its not clear haha. Updated!
23 (other comment)
Still updates the title regardless of the command
e.g. cadd n/Johnny p/12112 e/awpind@gmail.com a/tekong.
I think we can check whether commandResult == CommandResult(MESSAGE_SHOW_SESSIONS_SUCCESS) before updating the title
24 (other comment)
This happens with overlapping_session and when dependencies are not found
@oliviajohansen (5 comments)1 (commented on others PR)
same as above
2 (commented on others PR)
maybe don't put 'healthy'? it restricts the types of recipes unnecessarily
3 (commented on others PR)
actually the IngredientParser takes parses all the ingredients at once into an Ingredient arraylist. Maybe need to change the phrasing to something like parses the user input ingredients into Ingredient objects. For example if the command is addR n/salad c/20 instr/blah blah i/apple -200g, banana -2.5 cups then the parameter into IngredientParser will be "apple -200g, banana -2.5 cups" which will be parsed into ArrayList>Ingredient>{new Ingredient("apple", "200g"}, new Ingredient("banana", "2.5 cups")}
4 (commented on others PR)
maybe another con could be other than spelling diff we could say diff ingredient names but similar ingredients in real life eg mozarella and cheese. also another con is if user dont have the basic ingredients in fridge eg salt, pepper, soya sauce, it may not be recommended to user
5 (commented on others PR)
changes or is changed depending on whether we choose present/ past tense
6 (commented on own PR)
Thanks for pointing it out, made the changes
7 (commented on own PR)
ok! thanks
8 (commented on own PR)
ok give me awhile
9 (commented on own PR)
yeah not very sure why. I'll fix the relevant commented out tests in the next iteration.
10 (commented on own PR)
I commented it out because not sure if its relevant. It looks like its testing the model and this command does not modify model instead it modifies CommandResult which has been tested.
11 (commented on own PR)
this is used by the test commented out in the same file so since that is commented out this is also commented out
12 (commented on own PR)
Same I commented it out because not sure if its relevant. It looks like its testing the model and this command does not modify model instead it modifies CommandResult which has been tested.
13 (commented on own PR)
Will do these and more in next iteration.
14 (commented on own PR)
oh yes will change that
@kc-98 (5 comments)1 (commented on others PR)
Can our team discuss and standardize the restriction of our arguments?
2 (commented on others PR)
Will this case ever be reached? If not, perhaps adding an assertion can be more defensive!
3 (commented on others PR)
Using BigInteger may slow the program down!
4 (commented on others PR)
Good use of abstraction specifically for Find commands!
5 (commented on others PR)
Perhaps can add in images and diagrams in the future?
6 (commented on own PR)
Noted!
7 (commented on own PR)
I think I read that for javadocs next line should be 4 spaces, let me confirm again.
8 (commented on own PR)
Noted!
9 (commented on own PR)
User inputted the number already hence past tense.
10 (commented on own PR)
I think we can standardize past tense for things that are already done.
11 (other comment)
Prefix: the entire company name
Content: accumulative stock for the respective company
12 (other comment)
Do review the merge conflicts @LimZeWeiDennis under docs/DeveloperGuide.md!
13 (other comment)
Same issue as PR #150
@ijavierja (4 comments)1 (commented on others PR)
No website inserted yet
2 (commented on others PR)
Is there any reason for the space infront?
3 (commented on others PR)
I think this needs to be changed. oweMoney doesnt sound like a client source description
4 (commented on others PR)
Should the error message be changed as it is phrased strangely?
5 (commented on own PR)
Ok sure changed to I4I
6 (commented on own PR)
I think we should change this along the way for v1.2. Since we are not sure as of yet if we want to remove the fields or add some fields
7 (commented on own PR)
Sounds good will edit
8 (other comment)
Necessary updates needed to close issue.
#11
#13
#15
9 (other comment)
Summary Table not yet done
10 (other comment)
Resolves #37
@richardcom (4 comments)1 (commented on others PR)
LGTM!
2 (commented on others PR)
LGTM!
3 (commented on others PR)
LGTM!
4 (commented on others PR)
LGTM!
@tigerting98 (4 comments)1 (commented on others PR)
I think this should be lowercase cos it's not a class level constant, its a instance variable.
2 (commented on others PR)
Can consider adding an instance variable for ID number, based on some static variable that tracks the total number of Order objects (i.e. totalOrders++ in the constructor for Order)
3 (commented on others PR)
Furthermore, can consider adding an instance variable to track what Client this Order is linked to.
4 (commented on others PR)
Perhaps you can add this created Order to a global List>Order> so that Orders can be listed independently from Client
@tnsyn (4 comments)1 (commented on others PR)
Not sure whether anything is affected by this, but maybe change to numbers for the Pay?
2 (commented on others PR)
Can change 'list' command to 'worker-list'
3 (commented on others PR)
Can change 'delete 5' to 'worker-delete 5'
4 (commented on others PR)
Can change 'add n/David' to 'worker-add n/David'
5 (commented on own PR)
Mm I just thought that it made sense for all workers to have a role so I included it as a compulsory field, but we can take it out also I guess? So if a worker doesn't have any roles specified, then we can assign them to any role in a shift
If we're going to be implementing the Pay calculation feature then we should make Pay compulsory
6 (commented on own PR)
Ah ok agreed for role! Will make the change
7 (commented on own PR)
Made the change to convert FULL to AM and PM unavailabilities
@constancensq (4 comments)1 (commented on others PR)
Should this be description instead? And maybe it should allowed to be blank according to the isValidDescription method?
2 (commented on others PR)
Maybe can change to assert instead
3 (commented on others PR)
Should be "do not modify Pivot" instead?
4 (commented on others PR)
Should be "Status is invalid"
@Asthenosphere (4 comments)1 (commented on others PR)
Should change to StonksBook here as well.
2 (commented on others PR)
Maybe it would be better if we add comments along the way as we write code? Just a suggestion haha.
3 (commented on others PR)
Can remove the tag add command since we will not be supporting it.
4 (commented on others PR)
Just a small thing, would it make more sense if we set the condition to yearValue > 1970 or something?
5 (commented on own PR)
Yep, this will be relevant once my next PR is in.
6 (commented on own PR)
Right sorry haha
7 (commented on own PR)
Thanks!
8 (commented on own PR)
Good catch lol
9 (other comment)
Already implemented in AddressBook, will open a new issue for the tag operations etc.
10 (other comment)
Good catch! I think it would make more sense to treat this action as a tag delete if there's only one contact with this tag.
11 (other comment)
Seems there's some very strange issues with this branch. Will close this PR and open a new one.
12 (other comment)
Closed in PR #96
13 (other comment)
Maybe we wait for everyone to add docs for their parts and merge together? @sebastiantoh
@KohHanMing (4 comments)1 (commented on others PR)
Minor spelling error "true"
2 (commented on others PR)
Just a thought, shouldn't the validVisit be created based on the hard coded locationId INDEX_THIRD and personId INDEX_FOURTH? Right now valid visit still references the filtered list. If there's an error in the translation of ids between filtered list and the original lists, the test would still pass as both the AddVisitCommand and validVisit would have made the same error.
3 (commented on others PR)
I see, no issue then!
4 (commented on others PR)
Consider putting this under ModelPredicate as well?
5 (commented on own PR)
Edited, thanks for the catch!
6 (commented on own PR)
Done!
7 (commented on own PR)
Done!
8 (commented on own PR)
Done!
9 (commented on own PR)
Removed
10 (commented on own PR)
Removed
11 (commented on own PR)
Removed
@chewypiano (4 comments)1 (commented on others PR)
Perhaps can refactor out a string format method in the superclass (i.e. Macronutrient) that formats the toString() method found in the Protein, Carb, Fat subclasses so as to reduce code duplication.
2 (commented on others PR)
Yes, this PR has some minor errors within some of the doc files etc. Will be fixed, but wanted more to show the refactoring as a whole and gather input on that. Still, thanks for pointing out, will look to fix the nits soon.
3 (commented on others PR)
Should this be -> instead of --> ?
4 (commented on others PR)
Similar to previous comment, shouldn't this be -> instead of -->?
5 (commented on own PR)
I think we should keep this as just
assertThrowsinstead. We should stick to the static asserts for tests
Our Assert class only has the assertThrows method. I think it is fine for this case since we are not really unnecessarily importing. Also this was automatically optimised by intelliJ.
6 (commented on own PR)
Sure, makes sense.
7 (commented on own PR)
Alright, will change naming. Regarding your second point, I guess that makes sense. Thanks for input!
8 (commented on own PR)
Code didn't work without this line lol, but I am still refactoring, this is just to make it work for now.
9 (commented on own PR)
Thanks, this was auto generated code I think, will look to refactor other bits as well soon.
10 (commented on own PR)
Yes, but it is for different parameters. This way find food1 is still allowed but you can also do find food1 -t lunch to get food1 from lunch only.
11 (commented on own PR)
Yep, was thinking of doing this. I used null just to make the code functional, will refactor tomorrow probably.
12 (commented on own PR)
Instead of a dummy class, do you think doing foodPredicateParameter.getValue().orElse(food -> true);would be better?
13 (commented on own PR)
Yeah, this is intended, so that we don't restrict the user from having to input something as name/tag search. For example, if we implemented it as you said, the user could not do find -d 21-10-2020 to find food items on the 21st of October. Instead, user would have to type in some sort of food name/tag as a mandatory parameter such as find some food -d 21-10-2020 which would filter out only the food items with name/tag that includes either "some" or "food" + being on that date, making it less intuitive and harder to use the find command meaningfully.
At the moment there is a check for empty parameters but for your particular concern, find on its own will still work, functioning similar to list, although I could just as easily change to it returning empty list.
14 (commented on own PR)
I think I only briefly made mention of this under design considerations in DG, do I need to elaborate more on this or can it just be elaborated over in the UG since it concerns the user more?
15 (commented on own PR)
Yeah exactly right, McGymmy assumes parameters flagged "" are mandatory.
16 (commented on own PR)
Yeah this was initial code just to make it work, as mentioned earlier.
17 (commented on own PR)
Good idea, might do this.
18 (commented on own PR)
Though not great, I'll probably leave it since we would need to change quite a bit more if we want to maintain the mandatory check for flag-less i.e. "" parameters while letting find still search in a flag-less manner i.e. find food. I might just create an issue for this.
19 (other comment)
The CI test says that you are missing the shadow plugins
Seems like a github actions issue. This happens from time to time.
Closing and reopening the PR should restart the CI process (hopefully fixing this).
Noted with thanks.
20 (other comment)
Might also add an extension like this:
find -all [keyword 1] [keyword 2] ...to find foods that match all of the keywords
find -some [keyword 1] [keyword 2]...to find foods that match some of the keywords
The find -some is inherently adopted, as in it works like that currently. The find -all looks good, we can probably do so in future if needed.
@khenghun (4 comments)1 (commented on others PR)
Does not match constructor, should be
new Recipe(0, ingredients, 2, "", new ProductQuantity("1"), "Recipe 1", false)
instead
2 (commented on others PR)
Maybe update this or remove TODO?
3 (commented on others PR)
can extend Quantity class if you want
4 (commented on others PR)
Perhaps show a message to tell the user if no such item is found?
5 (commented on own PR)
oops forgot to remove this
6 (other comment)
Bug fixed
7 (other comment)
Maybe rename as viewDetailedItem or viewDetails (similar to the command name) so that it is easier for the reader to follow.
@jianhandev (4 comments)1 (commented on others PR)
can be moved to a separate util class e.g. TypicalAppointments class
2 (commented on others PR)
can do likewise for description, datetime, status, tags
3 (commented on others PR)
we will need an AppointmentBuilder class too
4 (commented on others PR)
LocalDateTime will have to be updated to use custom DateTime class. Refer to the latest commit.
5 (other comment)
Update of README is complete.
6 (other comment)
False PR, no changes found.
7 (other comment)
I have changed the title in this file.
@JoeyToh (4 comments)1 (commented on others PR)
Why will there be an error message after the tag is created (Line 326-328)? Maybe you can write it this way(?):
MSS
User requests to add a tag.
Projact adds a tag.
Use case ends.
Extensions
2a. The tag already exists.
2a1. Projact shows an error message.
Use case ends.
Is this clearer haha and also must we show in the use case that there are 2 ways to add a tag (like in user guide) or a general one (seen above) is ok?
2 (commented on others PR)
"Address list" sounds a bit funny to me haha maybe contact list or phone book? Or keep it as address book? (but I'm not sure if this will fail the thingy when the script detects it).
I think we need to write in present tense: "The user can assign...."
3 (commented on others PR)
Maybe we can just remove the link to the jar file for now, in case the script detects the link to AB3
4 (commented on others PR)
Same comment as the introduction part. Perhaps address book/contact list/phonebook instead of address list? (Similarly for all other appearances of the word "address list")
5 (other comment)
Failing CI because I've implemented the feature with Tag instead of TagName so when the changing of TagName to Tag is done, I will re-push.
@sagarsureka (4 comments)1 (commented on others PR)
Should this be invalid description field?
2 (commented on others PR)
Not a big issue but do you think we should change names to descriptions in the comment?
3 (commented on others PR)
Maybe the occurrences of name in comments should be replaced with description?
4 (commented on others PR)
Maybe we can replace Name in method name with Description, here and in other occurrences?
5 (other comment)
Created this PR by mistake.
6 (other comment)
Thank you for your comments. I have made the relevant changes to the code.
7 (other comment)
LGTM
@WM71811 (4 comments)1 (commented on others PR)
I guess the parser is under development?
2 (commented on others PR)
can add a javadoc here?
3 (commented on others PR)
similarly javadoc can be added..?
4 (commented on others PR)
similar as above
5 (commented on own PR)
thanks, resolved!
6 (commented on own PR)
thanks, resolved
7 (commented on own PR)
thanks, resolved
8 (commented on own PR)
thanks
9 (commented on own PR)
updated, thanks!
10 (commented on own PR)
updated, thanks!
11 (commented on own PR)
it automatically become the next line when I save.. so can I leave it as that?
12 (commented on own PR)
I would like to highlight that it is not "reset" before this execution, so I thought it is clearer than isReset..?
13 (commented on own PR)
Noted with thanks
14 (commented on own PR)
Noted with thanks
15 (commented on own PR)
Noted with thanks
16 (commented on own PR)
0k thanks
17 (commented on own PR)
Noted with thanks
18 (commented on own PR)
Noted with thanks
19 (commented on own PR)
Noted with thanks
20 (commented on own PR)
Noted with thanks
21 (commented on own PR)
Noted with thanks
22 (commented on own PR)
noted with thanks
23 (commented on own PR)
noted with thanks
24 (other comment)
LGTM
25 (other comment)
LGTM
26 (other comment)
LGTM
27 (other comment)
LGTM.
28 (other comment)
LGTM
29 (other comment)
LGTM
30 (other comment)
LGTM
31 (other comment)
LGTM!
32 (other comment)
LGTM
@CodyChew (3 comments)1 (commented on others PR)
Should use the atMainPage()/atCasePage() check here rather than checking the element
2 (commented on others PR)
Should be trimmedTitle here
3 (commented on others PR)
Is there a TYPE_DESC missing over here
@duckmoon99 (3 comments)1 (commented on others PR)
Rename to clearOrder for brevity.
2 (commented on others PR)
Might want to wrap this logic into a Model#resetOrder() instead.
3 (commented on others PR)
If called by itself, the assumption that the head of orderHistory is equal to order is no longer true.
4 (other comment)
Fixed AboutUs username.
@shermz-lim (3 comments)1 (commented on others PR)
Some of the comments are not correct throughout the code
2 (commented on others PR)
This is for us to get available rooms based on which Rooms we currently have that are booked. But the booking class only contains the room ids and not the Room object so the input may be a list of integer IDs instead? Depends on how we implement the rest so I think can leave it for now!
3 (commented on others PR)
I think this interface is supposed to only return a list of bookings. Can try looking at ReadOnlyAddressBook and find its usages to see how it's used and we can just follow! If I am not wrong it's used with storage. Other than this, LGTM!
@geoboom (3 comments)1 (commented on others PR)
Hmm indentation looks a bit off - not sure if it's just GitHub.
Did you CMD/CTRL+ALT+L in Intellij Idea to autoformat?
2 (commented on others PR)
Could we just do this here?
return other == this // short circuit if same object
|| (other instanceof Deck // instanceof handles nulls
&& getDeckName().equals(((Deck) other).getDeckName())); // state check
3 (commented on others PR)
gotcha
4 (other comment)
lgtm
5 (other comment)
lgtm
6 (other comment)
Yo! Regarding this:
But when you use the old select command, ModelManager gets told to operate on the selected deck and stops operating on the stub deck
Remember when I said the UI is tied to the stub decks UniqueEntryList field? This means that even though you are updating the selected decks list, nothing changes in the UI because nothing changes in the stub's UniqueEntryList
Could you please provide steps to reproduce the issue? What I did are as follow:
I resolved the concurrent modification issue caused by replaceEntryList() in ModelManager.java by changing the method body to:
public void replaceEntryList() {
observedDeck.setEntries(getCurrentDeck().getEntries());
}
I don't think removing all entries in observedDeck.entries is necessary since observedDeck.setEntries(...) will directly replace the old entries with new entries. Java garbage collector will handle the rest.
Next, I launched the program and issued the following command:
add w/test_word t/test_translate
and expected to see no update to the UI. However, I saw my new entry appear beneath all the stub entries.
I re-launched the program and tested these commands:
select 1
add w/test_word t/test_translate
and saw my new entry appear beneath all the stub entries too.
EDIT: fix stupid indent kena copied over from idea
7 (other comment)
Steps to reproduce:
Perform the following in order:
New deck
Add entry <word -> translation>
Close the program
Reopen
Select deck
Find entry
Expected:
Actual:
Possible reasons:
8 (other comment)
Unfortunately I can't load the saved stuff in the json file so can't debug this atm >>
9 (other comment)
nvm I'm retarded I forgot to pull from upstream master
10 (other comment)
Btw for stuff like this:
### <a name="model-component"></a> 3.5 Model component
no need to write the html anchor tag (<a ...>...</a>) just the markdown ### will do.
11 (other comment)
Weird... CI not passing even after I resolved the issues with not catching PhaseInvalidException. Will fix after I finish data analytics features and stuff.
12 (other comment)
Update validation:
Writeup
Picture (not sure if my component is too trivial for a picture but I'll check again after doing the stats part)
Update statistics/data analytics:
Writeup
Picture
13 (other comment)
App-based statistics:
Statistics and StatisticsManager classes for app-based statistics (average time spent online, login/logout events w/ timestamps)
Persist Statistics to file (v1.3.2)
As for deck/quiz based statistics I plan to add a few classes:
QuestionAttempt {
correctAnswer,
yourAnswer,
score
}
QuizAttempt {
duration,
takenAt,
questionAttempts[QuestionAttempt]
}
And for the Deck class itself, I will enhance it by adding a List<QuizPerformance> to which QuizPerformance objects will be pushed after user submits quiz. This will be persisted to disk together with the Deck.
Overall statistics like averages can be computed when rendering takes place. I intend to do this by building a DeckComparator class. If performance becomes an issue, we can also compute the statistics after every quiz submission via:
average = (average * (n-1) + newScore) / n;
Where n is the number of quiz attempts.
That's all from me for now. Going to wrap this up by Friday night so I can spend Saturday writing documentation.
@justweihong (3 comments)1 (commented on others PR)
Perhaps can change this to a switch clause? Also instead of the firstChar maybe use Class.TYPE?
so like switch (TYPE):
case Task.TYPE:
case Lesson.TYPE:
...........
case Module.TYPE:
...........
case Contact.TYPE:
....
2 (commented on others PR)
Maybe can mention that the task is specified by index?
3 (commented on others PR)
Replace AddressBook with TrackIT@NUS?
4 (other comment)
Yes, I realised it too but I forgot to raise it up during yesterday's meeting! Will send Simon another PR.
5 (other comment)
Attached above is the updated methods required.
Main changes include methods to fit the indexing of lessons and tasks for the upcoming tab.
@YangYue128-helen (3 comments)1 (commented on others PR)
Shall we consider the situation when a nurse wants to view the whole appointment list (without a date specified)?
2 (commented on others PR)
Beautiful assertion!
3 (commented on others PR)
A little grammar issue in documentation. Should be "an EditAppointmentDescriptor" instead of "a".
4 (commented on own PR)
Since I want it returns true when there is no overlapping. I think this name is somehow acceptable.
5 (commented on own PR)
noted
6 (commented on own PR)
I changed the startAtSameTime method already. Check whether it looks good to you now.
7 (commented on own PR)
I've checked with Jin Hao. The input of done command follows d/.. t/.. Later we can update the UG.
@chrisgzf (3 comments)1 (commented on others PR)
I think this should be our group's TP repo instead of your fork
2 (commented on others PR)
HALLO POLIS?
3 (commented on others PR)
Very detailed tests! Great job! 😇
4 (commented on own PR)
Good point! Seems like that was from AB3, but I'll fix it either way.
5 (commented on own PR)
6 (other comment)
Closing because this is extremely involved and can make our codebase very confusing. The word "Person" is all over the place, with multiple classes all around. Not a worthy endeavor.
modified: docs/DeveloperGuide.md
modified: docs/tutorials/RemovingFields.md
modified: docs/tutorials/TracingCode.md
modified: src/main/java/seedu/address/commons/core/Messages.java
modified: src/main/java/seedu/address/logic/Logic.java
modified: src/main/java/seedu/address/logic/commands/FindCommand.java
modified: src/main/java/seedu/address/logic/commands/ListCommand.java
modified: src/main/java/seedu/address/model/ReadOnlyAddressBook.java
modified: src/main/java/seedu/address/model/person/Person.java
modified: src/main/java/seedu/address/model/person/UniquePersonList.java
modified: src/main/java/seedu/address/model/person/exceptions/DuplicatePersonException.java
modified: src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
modified: src/main/java/seedu/address/ui/PersonListPanel.java
modified: src/test/data/JsonAddressBookStorageTest/invalidAndValidPersonAddressBook.json
modified: src/test/data/JsonAddressBookStorageTest/invalidPersonAddressBook.json
modified: src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json
modified: src/test/data/JsonSerializableAddressBookTest/invalidPersonAddressBook.json
modified: src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
modified: src/test/java/seedu/address/logic/commands/AddCommandTest.java
modified: src/test/java/seedu/address/testutil/TypicalPersons.java
7 (other comment)
CI failing because I haven't fixed tests yet. Will fix later.
8 (other comment)
This supersedes #9, closing #9 and reassigning this to @sun-yitao
tldr: in #73, attendance data field is added to Person and saved with Person, when serialised into the json file. right now, you need to implement the attend command (and possibly the unattend command) on our app so that the Person is updated with new attendances
9 (other comment)
Closing as #71 supersedes this
10 (other comment)
This supersedes #7, closing #7 and reassigning this to @rnmy
tldr: in #73, attendance data field is added to Person and saved with Person, when serialised into the json file. right now, you need to implement the:
Something like:
| Name | 15/10 | 22/10|
| - | - | - |
| Chris | 🚫 | ✅ |
| Rach | ✅ | ✅ |
showatt command which navigates to that tab (the UG showatt command currently is for showing a specific date's attendance, maybe we can change that to simply navigating to the attendance page/tab instead, idk)
11 (other comment)
Superseded by #72
12 (other comment)
Skipping code review as this is urgent. Merging.
@Licheng-Wu (3 comments)1 (commented on others PR)
Need to set updateFilteredExerciseList to false here as well?
2 (commented on others PR)
Hi have to edit your Intellij settings to prevent star imports
3 (commented on others PR)
Documentation needs to be modified, currently is referring to Exercise
@kwannoel (3 comments)1 (commented on others PR)
VALID_TELEGRAM, VALID_MATRIC_NUMBER, VALID_ADDRESS, invalidTags);
2 (commented on others PR)
I defined the class as Telegram and follow this naming convention as well when naming the telegram field for Person.
What other different stuff are named telegram?
3 (commented on others PR)
Search and replace: _MATRICNUMBER -> _MATRIC_NUMBER
4 (commented on own PR)
For input I think we can leave it as that, without the prefix @.
I have updated the toString instance to reflect the handle.
5 (other comment)
Include Badge in README
6 (other comment)
Update README with new project screenshot
7 (other comment)
Not needed after referencing UG https://ay2021s1-cs2103t-f11-1.github.io/tp/UserGuide.html#adding-a-student-add
8 (other comment)
Update docs for tags as well:
\t -> \tg
9 (other comment)
Closed by #52
10 (other comment)
Sub PRs closed.
11 (other comment)
I think we may have to leave it as Ui.png also instead of Ui-change.png otherwise the bot can't scrape 😂
12 (other comment)
CI has some flags for trailing whitespace
13 (other comment)
Amazing thanks!
14 (other comment)
Done via #71
@kevnw (3 comments)1 (commented on others PR)
Can you give a proper example? The example here does not seem to use the recurring feature.
2 (commented on others PR)
Remove sysout commands.
3 (commented on others PR)
Good Job!
@PhongTran98 (3 comments)1 (commented on others PR)
Should we fix the Glossary part now? Since this part defines different terms in the Guide and we don't know what in there yet.
2 (commented on others PR)
Alright I see.
3 (commented on others PR)
Small typo here.
@jonfoocy (3 comments)1 (commented on others PR)
Might have missed out on bolding lines 383, 385, 393
2 (commented on others PR)
Maybe can change to t/ to keep the same format as the add command
3 (commented on others PR)
Can delete this import?
4 (other comment)
Changed to #38
@m0nggh (3 comments)1 (commented on others PR)
I suggest you can add a similar javadoc comment for this method by following the getMedicalConditions() method above (since it is provided already).
2 (commented on others PR)
Unsure if this method should be public (to standardise with the medical conditions methods)
3 (commented on others PR)
Very minor documentation error: 'a' instead of 'an' RedoCommand.
4 (commented on own PR)
I was contemplating on where to put this code under too, I think I will try to put it under the parser class instead. Thanks.
5 (commented on own PR)
I think I needed the category for the printing of the success message for the sort command based on the parameter entered.
6 (commented on own PR)
I think it was because I did not want to input a null as the animal comparator
7 (other comment)
Re-create another branch as there are too many merge conflicts to resolve
8 (other comment)
Should we change the json files (e.g. the typicalAnimalsAddressBook) in the test folder as well?
9 (other comment)
Will look at other files to see if there are necessary changes, thanks!
10 (other comment)
I think they are in different files, I can check all together at once actually.
@IlyaRin (3 comments)1 (commented on others PR)
The integration between the deck and the UI may take a longer time than we expect, buffer time between thursday and friday may not be enough. Possibly in version 1.3
2 (commented on others PR)
I think the 'to put it simply' can be removed. Maybe something like " It is a proven quizzing system that increases the user's rate of learning by using spaced repetition. Flashcards are sorted based on the user's ability to answer them.
3 (commented on others PR)
Looks good!
4 (commented on own PR)
The indentation doesn't change, seems to be that way. In other classes like Entry.java as well
5 (commented on own PR)
Yep changed. Ty 😃
6 (other comment)
List command can be deleted as well
Clear command needs to be updated as well (should it clear decks or clear entries?)
- Fix the edit command such that it displays the edit command (for now, it only edits the deck's entry but doesn't show it)
Looks good to me. Will add edit command, clear command as issues. List command probably is still needed only for entries since users are able to filter
7 (other comment)
Hmm idt its find command filter. I checked the repo at the time when find command works, the code is still the same.
If you add a deck and entries and try to filter, it works. But after closing the program and reopening, it doesnt
8 (other comment)
Issue with filtered list not updating in Deck.java when Deck.setEntries(...) is called in storage.
Resolved
9 (other comment)
Alright nice work!
10 (other comment)
About the test for the command object, you can try refering to the tests for the other commands. They check if the command result given by the command being executed matches with the expected command result
11 (other comment)
Nice lgtm
12 (other comment)
This is the code to merge the quiz with the UI.
Changes:
Created this class called CurrentView.java in model. This switches the view of the program between 4 views (start, entry, quiz and statistics). For example when select command is called, the view will change from start view to entry view. Similarly with the play command. When the view changes, the tabs in the GUI will change accordingly.
Added a start page that is visible to the user when they enter the program (Some styling still needs to be done here)
Added a quiz page, which contains the current question, the total number of questions, the number of answered questions and the number of questions left. This page will update until the quiz has ended. (ALOT of styling still needed)
Addition: Displaying the list of answered questions at the side
Addition: Adding a progress bar
Addition: Score page to be displayed to the user after the quiz before returning to entry tab.
@petrickjerico (3 comments)1 (commented on others PR)
Would be good if we can make all 5 emails in the same format, but that's very minor. Just a thought!
2 (commented on others PR)
You would make a good one, TBH!
3 (commented on others PR)
Noticed the O(n^2) time complexity here! Can optimize in future iterations, but OK otherwise since trivial.
4 (commented on own PR)
Got it, thanks!
@HynRidge (3 comments)1 (commented on others PR)
is the word 'conform' a typo or it is the intended meaning?
2 (commented on others PR)
should the tag be plural?
3 (commented on others PR)
I think requireNonNull(addressType) and requireNonNull(addressString) can be combined into requireNonNull(adddressType, addressString);
4 (commented on own PR)
should I remove the whole extension?
5 (commented on own PR)
Okay, I have restore to original, sorry for the different input. I merge code to master and there were conflicts.
6 (commented on own PR)
Yep.. resolved
7 (commented on own PR)
not sure
8 (commented on own PR)
Fix!
9 (commented on own PR)
It's okay I think just keep it first..
10 (commented on own PR)
Amend the comments
11 (commented on own PR)
Yes it is .. will remove it
12 (commented on own PR)
yes..amend it!
13 (commented on own PR)
yes
14 (commented on own PR)
Amend
15 (commented on own PR)
Okay noted
16 (commented on own PR)
I am having an issue with the test and I commented out to make it pass
17 (commented on own PR)
okay amend!
18 (commented on own PR)
Okay fixed!
19 (commented on own PR)
Yep, refactor!
20 (commented on own PR)
Do you think it is okay to drop?
21 (commented on own PR)
I think we should just keep the consistency of checking regex, but for description we just allow "" since it is an optional field for the user?
22 (commented on own PR)
what do you mean by empty line??
23 (commented on own PR)
Okay empty line deleted
24 (commented on own PR)
Okay amend it!
25 (commented on own PR)
Fix this!!
26 (commented on own PR)
Yep amend this too!!
27 (other comment)
done
28 (other comment)
Done updating AboutUs.. Will push the file together with other parts
29 (other comment)
Done! Updated DG NFR
30 (other comment)
Sorry wrong upload
31 (other comment)
@luo-git I have made the changes. Could you kindly check again? Sorry for the overhead confussion!
32 (other comment)
LGTM!
33 (other comment)
DONE!
34 (other comment)
DONE!
35 (other comment)
DONE!
36 (other comment)
DONE!
37 (other comment)
Looks good to me, but I am not familiar with testing, so I'm not 100% sure about it.
Okay we wait for tomorrow then
38 (other comment)
DONE BY @anthony6401 . I will close this issue now
39 (other comment)
LGTM. Could be improved by writing a few unit test cases for CurrentPath.
I write the test cases on a seperate PR maybe?
40 (other comment)
Everyone one has contributed to DG!
@Diwu-Yi (3 comments)1 (commented on others PR)
Perhaps we can specify at this point: all ingredients have a default unit ? eg: Liquids: Litre; Solids (including toppings): KG
2 (commented on others PR)
Perhaps the naming of this field could be changed to isArchived to show that ArchiveStatus can only be true or false ?
3 (commented on others PR)
okay, sure
4 (commented on own PR)
Noted, will edit accordingly.
5 (commented on own PR)
Indeed, it should not be a prefix !
6 (commented on own PR)
Right, thanks for the suggestion !
7 (commented on own PR)
Yes, the original version did not work out, should be able to complete this by tomorrow !
8 (commented on own PR)
I followed from the EditCommand, so I guess this is fine ?
9 (commented on own PR)
True, will change !
10 (commented on own PR)
Noted, will add in.
11 (commented on own PR)
ya, I will check it as well !
12 (commented on own PR)
yep, will add the access modifier.
13 (commented on own PR)
yep, will detele.
14 (commented on own PR)
noted, editing now
15 (other comment)
#6 AboutUs with Diwu-Yi's info
16 (other comment)
#7 Update UG with Diwu-Yi's section: add, delete and set instructions
17 (other comment)
#10 Update DG with Diwu-Yi 's section: use cases, did not touch the rest.
18 (other comment)
Complete the feature
19 (other comment)
#97
20 (other comment)
#105
21 (other comment)
#105
@sc-arecrow (2 comments)1 (commented on others PR)
looks like a typo, should be macOS
2 (commented on others PR)
This image cannot be used, should be replaced with an image of the person or a placeholder image.
3 (other comment)
I will get on this issue as soon as I can!
@Joven-Heng (2 comments)1 (commented on others PR)
Just curious, for the withoutNote, couldnt we just not build it without this function>
2 (commented on others PR)
I think just java 11 will work, we shouldnt set it higher since this is supposed to work on Java 11 only
3 (commented on own PR)
Ok fixed those, have a look
4 (commented on own PR)
Interesting, changing this does not affect checkstyle
5 (commented on own PR)
Also not detected.
6 (commented on own PR)
Changing this will lead to a checkstyle error tho.
This is why I went to change the indentation
7 (other comment)
Wrong branch name. Closing.
8 (other comment)
Wrong branch name. Closing
9 (other comment)
LGTM, do note that we would have to include those deleted commands inside here when we are done.
10 (other comment)
I can probably make more tests, but I really would want the note to be an optional field first.
11 (other comment)
Updated to change command to o/
12 (other comment)
Update based on WeiJie suggestions.
Further changed Addressbook Name.
13 (other comment)
LGTM
@iamgenechua (2 comments)1 (commented on others PR)
Good workaround
2 (commented on others PR)
Great effort to change to booking id!
3 (commented on own PR)
as what @shermz-lim mentioned earlier during our meeting, he suggested that there shouldn't be a checking of length for the room id. if the user keys in roomId of length of 5, for example, the user will just be greeted with a 'room does not exist'
@MorningLit (2 comments)1 (commented on others PR)
Checking move to AddCommand.execute() ?
2 (commented on others PR)
Messages.class or ParserUtil.class?
3 (other comment)
LGTM! Great work Kendrew!
@vigneshbhuvan-nus (2 comments)1 (commented on others PR)
I think maybe we could provide written examples of what kind of different decks users can have, to help them understand better
For e.g.
Spanish
Japanese
OR
Spanish Animals
Spanish Food
2 (commented on others PR)
Possibly can include
3 (other comment)
Task completed by me
@limkoonkiat (2 comments)1 (commented on others PR)
I think there is already another edit?
2 (commented on others PR)
I will merge first
3 (commented on own PR)
oh yes
4 (other comment)
For sample data
5 (other comment)
Duplicate of #110
@li-s (2 comments)1 (commented on others PR)
Does add command parser need prefix_old_tag_name? Isn't the command tag f/filepath t/tagname?
2 (commented on others PR)
Shouldnt personInList be tagInList instead?
3 (commented on own PR)
i think tags list sound quite wierd
4 (commented on own PR)
Ok
5 (commented on own PR)
Ok
6 (commented on own PR)
dafaq i didnt touch that line
7 (other comment)
LGTM!
8 (other comment)
LGTM!
9 (other comment)
Fixed in #39
10 (other comment)
Did not use branch
11 (other comment)
I dont think command should be an address, nvm me and luoyi change it
12 (other comment)
LGTM,
13 (other comment)
LGTM
14 (other comment)
LGTM!
@ethan-l-m-e (2 comments)1 (commented on others PR)
typo 'an' --> 'a'
2 (commented on others PR)
idk but are we supposed to avoid using asterisk?
@tanwayne890 (2 comments)1 (commented on others PR)
Did you accidentally edit modelManager?
2 (commented on others PR)
Maybe can use this for optional description @yuming7144
3 (other comment)
Should you refer to our google docs for the target user and value propositions that we have discussed about? 🤔
4 (other comment)
LGTM!
5 (other comment)
LGTM
6 (other comment)
I didn't add the Ui file individually, instead I try to use the Ui file upload by you after merging the update Readme pr
7 (other comment)
ok done
8 (other comment)
Close this issue? 🤔
@jazerler (2 comments)1 (commented on others PR)
Is this missing out the UID of otherPerson for comparing if both Persons are the same?
2 (commented on others PR)
Any reason for this change from parallel streams?
@sun-yitao (2 comments)1 (commented on others PR)
Maybe this could be named telegramHandle, a few different stuff being named telegram already
2 (commented on others PR)
Perhaps the line break after the '=' might not be needed
3 (other comment)
Working in current master
@dearvae (2 comments)1 (commented on others PR)
i don't think you suppose to change this address here
2 (commented on others PR)
line 12, the prefix for type is "type:"
3 (commented on own PR)
okie will change
4 (commented on own PR)
noted
5 (commented on own PR)
oh i will update this
6 (commented on own PR)
if it is empty the parser will return a exception with error message, it won't be turned into a DoneCommand.
7 (commented on own PR)
but your concern make sense! i will add requireNonNull(targetIndexes);
@hhdqirui (2 comments)1 (commented on others PR)
Shouldn't it be "locationId" instead of "location"?
2 (commented on others PR)
Following Siang Ern's comment, referencing the index rather than id is required for this command. Also, "personId" and "locationId" are hiden away from the user. Users by right should not know about the id.
3 (commented on own PR)
Fixed
4 (commented on own PR)
Fixed.
5 (commented on own PR)
More tests added.
6 (commented on own PR)
Test added.
7 (commented on own PR)
Done.
8 (commented on own PR)
Done.
9 (commented on own PR)
Fixed.
10 (commented on own PR)
Done.
11 (commented on own PR)
Fixed.
12 (commented on own PR)
Done. In fact, I think that all methods in ModelMethods class can be moved to InfoHandler class and I have shfited all and refactor the test accordingly.
13 (commented on own PR)
Done.
14 (commented on own PR)
Done.
15 (commented on own PR)
Done.
16 (commented on own PR)
Done.
17 (commented on own PR)
Done.
18 (commented on own PR)
Done.
19 (commented on own PR)
Done.
20 (commented on own PR)
To be consistent with the code for parsing Index from line 42 to 47, I think it is better to still put it in a try catch block to catch an ParseException and throw new ParseException with a new message.
@kimberlyohq (2 comments)1 (commented on others PR)
Should this be flashcard list instead?
2 (commented on others PR)
Maybe can rename this to execute_lowercaseKeyword_success?
3 (commented on own PR)
oh wait ya i will remove it
@ysr25 (2 comments)1 (commented on others PR)
If you don't use don't leave an empty line in between, Use case ends. will be shown as being on the same line as 3. Bagel... on the website
2 (commented on others PR)
Similarly, it'll end up as one long line here if you don't use the * and >br>.
3 (other comment)
I think you need to swap lines 3 and 4 in RemarkCommandTest.java. 😃
import static org.junit.jupiter.api.Assertions.assertTrue is the one that has to before the "import static seedu" statements, while import org.junit.jupiter.api.Test is behind.
@foongsq (2 comments)1 (commented on others PR)
Perhaps the "Address book" in MESSAGE_SUCCESS should be changed to "Flash notes"?
2 (commented on others PR)
Perhaps the "Address Book" in MESSAGE_EXIT_ACKNOWLEDGEMENT could be changed to "Flash Notes"?
3 (commented on own PR)
Yes, you're right thanks!
@khinkhinn (2 comments)1 (commented on others PR)
sorry can i check why this was added!!
2 (commented on others PR)
sorry isit??? i dont think so..? do correct me if im wrong..!!
3 (commented on own PR)
yep done thanks!!!
4 (other comment)
Failed CI checks
5 (other comment)
Code still fails CI check
6 (other comment)
LGTM
7 (other comment)
looks good to merge!
8 (other comment)
lgtm
9 (other comment)
lgtm
@EkChinHui (2 comments)1 (commented on others PR)
I'm not sure if we want to use the term budget book compared to budgets. I used budgets in the User Guide, whichever case it should be consistent in both guides. @wenhaogoh please advise
2 (commented on others PR)
Just a small change needed, I think the wording is slightly off here. Maybe you meant to say when the command is called or used. Either that or perhaps you meant "When a command that requires ..."
3 (other comment)
LGTM!
4 (other comment)
duplicate issue #59
@Rishi5154 (2 comments)1 (commented on others PR)
A minor thing, but perhaps the handle has to start with @ right?
2 (commented on others PR)
Minor naming convention - Shouldn't this be tags since tagged is a collection. Other than that everything looks fine so far 👌
3 (commented on own PR)
I think telegram is clear enough. Telegram represents the class, while telegram is clear enough to understand as handle.
4 (commented on own PR)
Noted
5 (commented on own PR)
Don't have any more other than the ones in JsonAdaptedPersonTest
@howtoosee (2 comments)1 (commented on others PR)
different header level for extensions too.
2 (commented on others PR)
use different header level for MSS and Use case? use MD headers instead of bold i think.
3 (other comment)
Closed prematurely. Only Ui mockup added.
4 (other comment)
ReadMe done.
5 (other comment)
UG page updated
6 (other comment)
hi gel, please write more informative user stories!
7 (other comment)
DON'T MERGE THIS!
8 (other comment)
Completed: created JsonAdaptedInventoryRecord and JsonAdaptedFinanceRecord classes
9 (other comment)
Closed
10 (other comment)
Closed
11 (other comment)
Wrong branch....
12 (other comment)
Added:
InventoryStorage
JsonInventoryStorage
JsonSerializableInventory
Adapted:
Storage
StorageManager
Notes:
13 (other comment)
Adapted:
UserPrefs: with file paths to inventory and financeAcc json storage files
MainApp: with new initModelManager
ModelManager: new constructor for inventory and financeAcc
14 (other comment)
Adapted:
LogicManager: method call to save financeAcc and inventory
Model & ModelManager: getter methods for financeAcc and inventory
15 (other comment)
Split issue into saving and loading as separate features.
16 (other comment)
Move issue to v1.2
17 (other comment)
Refactored images directory and removed unused images
18 (other comment)
PR accepted and merged
@nopenotj (1 comments)1 (commented on others PR)
should this be a method in PersonList? like .get(name)
@Whleee (1 comments)1 (commented on others PR)
Does this mean all the students in TypicalStudents have the same ID?
2 (commented on own PR)
I checked the google docs and it said 1 to 5? hmm can someone confirm
3 (commented on own PR)
sure I just put mine
4 (commented on own PR)
yup done
5 (commented on own PR)
yup done
6 (commented on own PR)
yup added, just the documentation never write, just edited it.
7 (commented on own PR)
cos AddressBook now needs to have a training field, just added it in so the test cases can run
8 (commented on own PR)
hmm I wanted to put AddStudentToTrainingCommand but that would be bit too verbose I think, if others are okay with it ill refactor
9 (commented on own PR)
woops okay
@drake25122000 (1 comments)1 (commented on others PR)
The users are also able to find by tags n remarks right?
2 (commented on own PR)
Okay
3 (other comment)
LGTM!
@kormingsoon (1 comments)1 (commented on others PR)
nice spacing
2 (commented on own PR)
Wah high praise from Dianne
3 (other comment)
Resolved conflicts in a separate branch. See other PR for finalised version.
4 (other comment)
https://nus-cs2103-ay2021s1.github.io/website/schedule/week10/project.html
@Jaylenlee (1 comments)1 (commented on others PR)
Minor difference. (Needed for v1.2.1) not inside header format in other places
@youyingfeng (1 comments)1 (commented on others PR)
bruh star imports are illegal
@Hazel1603 (1 comments)1 (commented on others PR)
Just want to double check, the checking of the length of the roomId is done in the execute which is not yet implemented right?
2 (other comment)
PR Merged.
@nuovonatura (1 comments)1 (commented on others PR)
Isn't this the format for address? Should it be adapted to title format?
2 (other comment)
Thanks prof. We have changed it.
3 (other comment)
Please refer to and update on PR #132 for further development.
@ducbinh2611 (1 comments)1 (commented on others PR)
Nice use of stub 👍
2 (commented on own PR)
I will change it to something like this
public String toString() {
final StringBuilder builder = new StringBuilder();
builder.append("Title: ")
.append(getTitle() + "\n")
.append(getDescriptionString())
.append(getDateTimeString());
return builder.toString();
}
where getDescriptionString() is:
private StringBuilder getDescriptionString() {
StringBuilder emptyString = new StringBuilder("");
return description.map(desc ->
new StringBuilder("Description: ")
.append(desc.toString() + "\n")).orElse(emptyString);
}
and getDateTimeString() is:
private StringBuilder getDateTimeString() {
StringBuilder emptyString = new StringBuilder("");
return dateTime.map(time ->
new StringBuilder("Time: ")
.append(time.toString() + "\n")).orElse(emptyString);
}
3 (commented on own PR)
I was thinking that technically "" is also a valid dateTime from the user input or reading from the storage file so it should not throw an exception :?
4 (commented on own PR)
Okay I changed the regex so that it either accepts valid descriptions or ""
The new regex is "^([^\\s].*)?$"
@Lingy12 (1 comments)1 (commented on others PR)
I updated the date formater to accept "yyyy-MM-dd HH:mm", could you just modify this in order to be consistent?
2 (other comment)
@zhXchD Please review this PR and see whether there is a need to change in Logic. To my observation, the bug only caused by the model part, so now should be fixed
3 (other comment)
Updated. If you think this it's ok to have an update for journal according to addressbook, then it should be able to work.
4 (other comment)
Model has been updated, please refer to the PR #97 which has supported search by title, if we need more search predicate, I can go and implement that.
5 (other comment)
Updated.
@seowalex (1 comments)1 (commented on others PR)
Wouldn't this cause the logic and ui to not work?
2 (commented on own PR)
I think the fn signature should be BiFunction>? super T, ? super U, Pair>? extends T1, ? extends U1>>, but I could be wrong here.
3 (commented on own PR)
Why the different names?
4 (commented on own PR)
What's wrong with Arrays.stream(this.xs).skip(this.begin()).limit(this.size())?
5 (commented on own PR)
Missing braces.
6 (commented on own PR)
Shouldn't you assert this at the start?
7 (commented on own PR)
I think this modifies the argument, which seems undesirable.
8 (commented on own PR)
Well it's possible, but at least in Ingredients, the expiry date might not exist, and I think String.format makes it messier to create a string for that. Might be wrong though.
9 (commented on own PR)
Removed.
10 (commented on own PR)
Was lazy, will do.
11 (commented on own PR)
Just OCD don't mind me.
12 (other comment)
LGTM 👍
13 (other comment)
Other than that it looks ok, though there seems to be a bunch of repeated code which I suspect can be extracted, but we can leave that to 1.3.
14 (other comment)
Looks good! We may have to look into where we're using Optionals and where we're not, because the usage seems inconsistent, which might be hard to reason about, but that can wait till 1.3.
15 (other comment)
We should probably have some sort of selection of the tabs to indicated which tab is selected, but otherwise good job!
16 (other comment)
too many changes i lazy see all
is there a reason why you dropped the constructor taking
NamefromRecipeandIngredient?
might as well just remove it (it=
class Name) right? unless you have other plans for it
Well like you said, it seems mildly infuriating to have to do new Name(name) every time you want to create a new instance of anything that uses Name. It's still useful to do regex validation though, unless we want to do it directly on the model itself.
17 (other comment)
Ready to merge!
18 (other comment)
Still missing tests, but functionality should all be there.
19 (other comment)
TIL ok will change.
20 (other comment)
Looks good, merging.
@khor-jingqian (1 comments)1 (commented on others PR)
I am not sure if this is considered wildcard import?
2 (other comment)
LGTM
3 (other comment)
Sorry, let me approve Licheng's PR and handle the merge conflicts first.
4 (other comment)
Sorry, let me fix this and I will reupload the PR.
5 (other comment)
Can you help us to put our names at which part we did for 2101 class later then recommit? then ill merge it in
@ngzhenteng (1 comments)1 (commented on others PR)
Maybe we could add a javadoc comment as follows:
Represents the string consisting of a dash followed by an alphabet such as "-m" included in the user's command.
2 (other comment)
Week 6 tutorial, no need to merge.
3 (other comment)
LGTM!
4 (other comment)
LGTM!
5 (other comment)
branch was wrongly named
6 (other comment)
LGTM, thank you!
7 (other comment)
LGTM! thank you
8 (other comment)
Awesome update, LGTM!
9 (other comment)
LGTM thanks!
10 (other comment)
Looks awesome, looks good to merge.
11 (other comment)
Thank you Jun Jie!
12 (other comment)
Thank you!
13 (other comment)
Apart from the failure of CI, looks good to merge.
14 (other comment)
LGTM!
15 (other comment)
LGTM, nice diagrams, thank you!
@thutahw (1 comments)1 (commented on others PR)
I think this should be appointment book
@davidcaiqifan (1 comments)1 (commented on others PR)
Spelling error here
2 (commented on own PR)
Thanks for the feedback Joshua, but this was actually the original implementation for AB3.
3 (commented on own PR)
It was unnecessary. Thanks for pointing that out!
4 (other comment)
Closed due to some mistakes.
@seantaysl (1 comments)1 (commented on others PR)
Perhaps the spacing to start the line should be 4 white spaces instead?
@wayne987 (1 comments)1 (commented on others PR)
i think the person here is not the same person as the one in the model
2 (commented on own PR)
OHHHHH LOL i didnt realise HAHAHA okok!
3 (other comment)
I think cos the edit create a new day object without copying over the claroieManager field
@zeranium97 (1 comments)1 (commented on others PR)
i think its the wrong one
2 (commented on own PR)
My bad, Thanks for pointing it out hahah
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
@halcon-blanco my bad, I was doing it on a branch initially but accidentally merge to master when I wanted to transfer my work to be done on another computer. Will be more careful next time
6 (other comment)
@Wincenttjoi @halcon-blanco I have resolved the conflict, please check, not sure if I did it the right way
7 (other comment)
I can help @wengfaing with fixing the bugs, he can do the unit tests 👍
8 (other comment)
@Wincenttjoi Nope, those command stated in #105
no prefix in command
values other than numbers inside quantity field
9 (other comment)
@Wincenttjoi Alrights, thanks
10 (other comment)
Is there any other exceptions I might have missed out for this command?
11 (other comment)
Yup I have checked, all good
12 (other comment)
sounds good 👍
13 (other comment)
I will be adding it into this later tonight
14 (other comment)
Alrights, Thanks @Wincenttjoi
15 (other comment)
@xnoobftw my bad for overlooking the interfaces, I have edited the diagrams and added my find implementation
16 (other comment)
There's a couple of errors in the diagram! Check out the ss i tagged
Does inventoryModelManager has Item? Not sure about this, or is it referring to the
FilteredList>Item> filtered Items?
Same goes for deliveryModelManager
Yes it is referring to the filteredlist>Items>
@KOH-ZHE-HAO (1 comments)1 (commented on others PR)
Thanks for adjusting the user guide on my behalf 👍
2 (other comment)
Added the compulsory attribute company and optional attribute companyRole of Person.
All test cases have been refactored.
Slight modification to the GUI.
3 (other comment)
Looks good to merge!
4 (other comment)
The new color theme is indeed better! Thanks
@daongochieu2810 (1 comments)1 (commented on others PR)
Instead of passing many booleans, you can just pass in a string e.g if its to show recipes "show recipes" then do a switch statement to set the attribute to true, every other boolean will be default false
@nicktohzyu (1 comments)1 (commented on others PR)
docX
2 (other comment)
closes #90
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
so users don't have to scroll left-right
6 (other comment)
low priority feature and potentially causes bugs
7 (other comment)
closes #128
8 (other comment)
lgtm
9 (other comment)
LGTM
@yuming7144 (1 comments)1 (commented on others PR)
This will be the displayed message when expense is created/modified. Description is already optional! Thanks for the suggestion though really!
2 (other comment)
Forgot about that. Updated now.
3 (other comment)
I didn't add the Ui file individually, instead I try to use the Ui file upload by you after merging the update Readme pr
Then  would be fine! No need to add the .jpg
@joshruien (1 comments)1 (commented on others PR)
yes i agree with Jon, this way the user will not be confused.
@siqiang-ng (1 comments)1 (commented on others PR)
so is the command tagFind or tagfind?
2 (commented on own PR)
Ok! I can change to what was suggested. For the showing of 2 ways, I think a general one will be fine? Since like the use case is to show interaction between system and user.
3 (commented on own PR)
oh wait haha i think i should change to contact list.
4 (commented on own PR)
ok about the present tense, will take note
5 (commented on own PR)
ok done!
6 (commented on own PR)
done as well!
7 (commented on own PR)
Because in UniqueTagList, there is this test that checks whether the contains(Tag) method returns true even when the tag is edited. So to edit the tag, we will have to edit the person list (by adding one person in) that is attached to this tag.
@Test
public void contains_tagWithSameIdentityFieldsInList_returnsTrue() {
uniqueTagList.add(CS2103T);
Tag editedCS2103T = new TagBuilder(CS2103T).withPersons(VALID_PERSON_AMY)
.build();
assertTrue(uniqueTagList.contains(editedCS2103T));
}
8 (other comment)
Thanks! Made the necessary edits. Let me check what I can do about CommandResult.java
9 (other comment)
Does anyone know how to generate the Code Coverage result again?
10 (other comment)
Reformat the DG slightly.
@divakarmal (1 comments)1 (commented on others PR)
Good rigorous testing, cannot think of any missing cases
@IsaacTin (1 comments)1 (commented on others PR)
Seconded
2 (other comment)
As an organised HR manager, I want to be able to add data of my staff so that I am able to have these data at one place in a neat manner
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
LGTM
6 (other comment)
LGTM
7 (other comment)
LGTM
8 (other comment)
LGTM
9 (other comment)
LGTM
10 (other comment)
LGTM
11 (other comment)
LGTM
12 (other comment)
lgtm
13 (other comment)
lgtm
14 (other comment)
lgtm
15 (other comment)
As a user, I want to be able to add and delete different fields without needing to remember too many complicated commands
16 (other comment)
lgtm
17 (other comment)
lgtm
@wilinetan (1 comments)1 (commented on others PR)
I think can remove this line:
String viewCommandOption = nameKeywords[0];
2 (other comment)
LGTM thanks!
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
LGTM
@minzzelo (1 comments)1 (commented on others PR)
I thought setFlashcard was already there in the first place? Or you implement one
2 (commented on own PR)
The idea is that any note will be valid, just like the Remark class in tutorial, so that even if you want to clear a note from the Flashcard, you can do it using edit. Is it not supposed to be the case?
@AdithyaNarayan (1 comments)1 (commented on others PR)
Consider importing only necessary classes instead of the whole package. This will make sure that it passes the checkstyle!
2 (other comment)
LGTM
3 (other comment)
LGTM
4 (other comment)
LGTM
@Persdre (1 comments)1 (commented on others PR)
I agree 😃
2 (commented on own PR)
Thank you for reminding me!
3 (commented on own PR)
Yes, I was not sure about the format so I didn't update it.
4 (commented on own PR)
Thank you! I already updated it!
5 (commented on own PR)
Yes, thank you!
6 (other comment)
for #3
7 (other comment)
#4
8 (other comment)
LGTM
9 (other comment)
sad 😦
10 (other comment)
now the command is not as equal as the original
11 (other comment)
already changed now
12 (other comment)
already solved
@plosslaw (0 comments)1 (commented on own PR)
Thanks
2 (commented on own PR)
Thanks
3 (commented on own PR)
I think we'll still go with 0 removing the role
4 (commented on own PR)
Agreed, I have updated User Guide
5 (commented on own PR)
I removed this check in favor of just using regex only, the empty string is already rejected by the regex as seen in the RoleRequirementTest
6 (commented on own PR)
@WangZijun97 Yup, I have added the test cases and the regex does reject whitespace cases
7 (commented on own PR)
I have removed the >space> from the error messages, good catch
8 (other comment)
Currently, the shift-add and shift-edit commands do not support role requirements that uses spaces (e.g. Fry Cook) #44
9 (other comment)
Okay, I'll work on the test cases for commands related to Shift class
@Raymond0212 (0 comments)1 (other comment)
Command
AddCommand
AddTodoCommand
AddEventCommand
AddDedalineCommand
2 (other comment)
JUnit test is not refactored yet
3 (other comment)
Modify command parser
4 (other comment)
If it's hard to finish in v1.3 we may move it to v1.4
@XIA-LIYI (0 comments)1 (other comment)
CI has failed for this PR.
@theodoreleebrant (0 comments)1 (other comment)
@josuaaah please stick to the styleguide.
2 (other comment)
Wrong PR submitted
3 (other comment)
Updated according to coding standard and checkstyle. Updated testcases.
4 (other comment)
#18 and #19 done, will change to no milestone
5 (other comment)
This suggests that we need to open a new issue for codecov to ignore .md files
6 (other comment)
Cancelling PR, making PR from local branch
@sigmund-c (0 comments)1 (commented on own PR)
Good catch! I'll fix that as it's used for the initial sample data.
2 (other comment)
Duplicate of #21
3 (other comment)
repeat of #71 (i have short term memory)
@youaremysky99 (0 comments)1 (other comment)
@Jillzyt can you help me to review?
2 (other comment)
LGTM
3 (other comment)
#62
@e0316059 (0 comments)1 (other comment)
As a user, I can delete tasks so that I can remove cancelled obligations.
2 (other comment)
As a careless student, I can retrieve my deleted tasks from rubbish bin so that i won't accidentally delete them.
3 (other comment)
As a new user, I can read the help panel so that I am able to get familiar with the app.
4 (other comment)
As a user, I can mark a task as done so that I can take a glance and know which tasks have been finished.
@chloelee767 (0 comments)1 (other comment)
Duplicate of #9
2 (other comment)
LGTM, but can you rebase on master before I merge?
Alright done!
@marcus2k (0 comments)1 (commented on own PR)
Thanks for pointing that out! Tell me if any further changes are needed.
@UnicornJin (0 comments)1 (other comment)
Help and Get is planned to finish in future versions
@HCY123902 (0 comments)1 (other comment)
LGTM
2 (other comment)
LGTM
@Caiyi34777 (0 comments)1 (other comment)
Resolves #23 and #43
2 (other comment)
Resolves #46
3 (other comment)
How to resolve conflicts...
4 (other comment)
fix #69
5 (other comment)
fix #69
6 (other comment)
close #103
7 (other comment)
close #107
@Perpetual09 (0 comments)1 (other comment)
LGTM
@jetnew (0 comments)1 (commented on own PR)
Fixed.
2 (other comment)
As discussed with @mkeoliya, DeallocateCommand should use the si/ prefix because in a future version, we will add support for allocating a room by student ID, which will then require a prefix. For commands that use only 1 argument, we will add support for usage of prefix to improve self-explanation.
Changes made:
DeallocateCommand now takes in the student index using the si/ prefix.
3 (other comment)
User-test basic GUI and Storage functionality. The purpose of these screenshots is to show basic user testing prior to requesting review.
GUI - Before Deallocate
>img src="https://user-images.githubusercontent.com/27071473/95943065-65ce7d00-0e17-11eb-87e2-9cb62777a1a8.png" height="50%" width="50%">
GUI - After Deallocate
>img src="https://user-images.githubusercontent.com/27071473/95943072-69fa9a80-0e17-11eb-8d52-d1c4e89bf3e6.png" height="50%" width="50%">
Storage - Before Deallocate
>img src="https://user-images.githubusercontent.com/27071473/95943089-74b52f80-0e17-11eb-8971-cf7dc194da44.png" height="50%" width="50%">
Storage - After Deallocate
>img src="https://user-images.githubusercontent.com/27071473/95943095-7979e380-0e17-11eb-9947-1a4b8731cb1b.png" height="50%" width="50%">
4 (other comment)
User-test basic GUI and Storage functionality. The purpose of these screenshots is to show basic user testing prior to requesting review.
GUI - Before Reallocate
>img src="https://user-images.githubusercontent.com/27071473/95943650-fc4f6e00-0e18-11eb-95ce-0172a1788d92.png" height="50%" width="50%">
GUI - After Reallocate
>img src="https://user-images.githubusercontent.com/27071473/95943671-083b3000-0e19-11eb-933d-85dd3d9f20dd.png" height="50%" width="50%">
Storage - Before Reallocate
>img src="https://user-images.githubusercontent.com/27071473/95943685-10936b00-0e19-11eb-80ae-1fd822dd574c.png" height="50%" width="50%">
Storage - After Reallocate
>img src="https://user-images.githubusercontent.com/27071473/95943705-1e48f080-0e19-11eb-88ff-1de0f6c7b5e0.png" height="50%" width="50%">
5 (other comment)
Fixed UI bug where Student and Panel list does not update upon Allocate or Deallocate command, by updating panels using updatePanels().
@kerkpy (0 comments)1 (commented on own PR)
We should call it Training, I think there would be no ambiguity what we would be referring to. I left the header comments there as a placeholder, would change it after the creation of a Training class.
Thanks!
2 (other comment)
LGTM
3 (other comment)
LGTM
@royleochan (0 comments)1 (other comment)
LGTM 😃
@jflim98 (0 comments)1 (other comment)
I will get on this issue as soon as I can!
2 (other comment)
Noted. I will get on in once #18 and #19 are merged.
3 (other comment)
Implemented.
4 (other comment)
Wow! Looks good.
5 (other comment)
Sorry, forgot to link the issue when I PR'd it.
@josuaaah (0 comments)1 (commented on own PR)
Have replaced image with a placeholder image.
2 (other comment)
I am closing this pull request because I intend to make another pull request containing both tests for MarkCommand and StorageCommand.
3 (other comment)
Duplicate of #10 .
4 (other comment)
Duplicate of #10.
5 (other comment)
Duplicate of #40.
6 (other comment)
Duplicate of #23.
7 (other comment)
Closed pull request as I intend to make another pull request from a branch instead of the master branch.
@Lysire (0 comments)1 (other comment)
I think creating new commands will add unnecessary complexity to the system. It will take a lot of effort to set up even if we only provide for a small number of commands in the compound command. Even then, it will not provide much value since it will not take a lot of time to type a small number of commands, especially if aliasing is done well.
@WhiteLio (0 comments)1 (commented on own PR)
its the next line where I sort with a lambda, ideally if we implement sorting in the future we want to properly use SortedList and Comparators instead
2 (commented on own PR)
aight will do
3 (commented on own PR)
no need to worry about it now haha
4 (commented on own PR)
ooh good catch
@mehak24k (0 comments)1 (other comment)
Note: Week 6 individual task, not for merging
2 (other comment)
This PR is just for checks, not for merging.
@zeying99 (0 comments)1 (other comment)
Great!
@zeling595 (0 comments)1 (other comment)
sorry still working in progress, don't review first
2 (other comment)
can review now
@maxxyh (0 comments)1 (other comment)
README still needs to be updated with mockup and writeups.
2 (other comment)
LGTM! Developer Guide is updated with User Stories as discussed.
3 (other comment)
Could we also add the table for Command summary?
4 (other comment)
Closed after week 9 tutorial.
5 (other comment)
Closed after week 9 tutorial.
6 (other comment)
Closed after week 9 tutorial.
7 (other comment)
Closed after week 9 tutorial.
8 (other comment)
Issue has been resolved after refactoring work
9 (other comment)
Issue is resolved after refactoring from AB3 to Bamboo.
10 (other comment)
Issue is resolved after refactoring from AB3 to Bamboo.
@CalistaIo (0 comments)1 (other comment)
Milestone v1.1 closed
2 (other comment)
README modified
3 (other comment)
Issue rectified
@Robinho98 (0 comments)1 (commented on own PR)
erm im not sure how to do automatic numbering, maybe its a software?
2 (commented on own PR)
really? if it will be auto generated then can remove lor, or we can leave it in for this draft first
3 (other comment)
DataConversionException e, Line 85 in MainApp
4 (other comment)
lgtm
5 (other comment)
Can do it as a red coloured box, just like tag
6 (other comment)
Included the 3 fields yuxuan added, it passed the test cases on my side
7 (other comment)
LGTM
8 (other comment)
Close #116
@Michaeliaaa (0 comments)1 (other comment)
LGTM!
2 (other comment)
LGTM! Maybe you could add some test cases for this functionality later?
Yes, definitely. I will try to figure how to test peekNext() and peekPrev().
3 (other comment)
LGTM!
@iqbxl (0 comments)1 (other comment)
code in getBMI() function in AddressBook class does not achieve required result.
2 (other comment)
lgtm
3 (other comment)
lgtm!
4 (other comment)
nice
@afroneth (0 comments)1 (other comment)
LGTM
2 (other comment)
LGTM!
3 (other comment)
LGTM!
@gabrielsimbingyang (0 comments)1 (commented on own PR)
Noted, will update this
2 (commented on own PR)
Noted, will update this
3 (commented on own PR)
👍
4 (commented on own PR)
Updated!
5 (commented on own PR)
Updated!
6 (commented on own PR)
Done
7 (commented on own PR)
Done!
8 (other comment)
Corresponding PR has been merged
9 (other comment)
After a long debugging period. I don't think it's possible to change the system decoding to "utf-8" format without changing some core features of the log.java which will significantly affect the rest of the code. I will just leave it as it is
10 (other comment)
Remove command functionality seemed to have been included when @IlyaRin merged her adding command branch, I will close this branch now
11 (other comment)
The default clear command still works and need not be changed. I will close this issue now
12 (other comment)
Canceled due to failed CI checks
13 (other comment)
Tasks:
Come up with a new wireframe
Come up with a color theme - Done (7th Oct)
Implement the new design - Done (7th Oct)
14 (other comment)
Some of your CI (Continuous Integration) checks have failed so you have to change it before we can merge the pull request. You can find out what is the issue by clicking on details > clicking the "..." button on the right > then lastly, clicking on full screen.
The errors will be the lines before the red alert message. It looks like there are some formatting issues with this pull request. For example:
This means that there is no empty line at the end of the Email.java file. Hence, you would have to rectify that to maintain formatting standards with the rest of the program.
15 (other comment)
There are some conflicts with the rest of the program, as this is a tutorial program we don't have to merge this pull request but do keep in mind to resolve conflicts in future PRs
16 (other comment)
Even though this is one line of code, it is dealing with the build file, hence I have tagged everyone for review.
17 (other comment)
@vigneshbhuvan-nus please fix your CI checks next time before merging. It really screwed over the test @IlyaRin had written and I have no idea how to fix it.
18 (other comment)
Fixing the UI
I found out that during initialization, the wrong output of the method getFilteredEntryList() from ModelManager.java gets passed to the UI. This meant that the UI was watching the first decks UniqueEntryList.
I changed it so that now the UI watches observedEntries from the PUBLIC field in AddressBook.java.
Hence, any changes to observedEntries from AddressBook.java will directly result in a change to the GUI.
Select Command
I edited the Select Command to now directly change the observedEntries, the low level details are documented in the code.
Essentially, it creates a copy of the observedEntries, then deletes the original entries. It then fills observedEntries with entries of the selected command. The reason why we have to create a direct copy is to avoid the concurrent modification exception. Not the best performance O(n^2 * m) but performance can be optimized later.
Issues
The modification to AddressBook.observedEntries is done directly (because observedEntries is a public field), we should change this in the future.
Now edit command has to be updated, please refer to the code I have written to get an idea on how to do it.
List command can be deleted as well
Clear command needs to be updated as well (should it clear decks or clear entries?)
Homework for you guys:
Fix the edit command such that it displays the edit command (for now, it only edits the deck's entrybut doesn't show it)
Determine if list command needs to be deleted and delete/not delete it accordingly
Do the same for clear command
19 (other comment)
Done with my latest commit
20 (other comment)
Done with my latest commit
21 (other comment)
Done with @IlyaRin commit
22 (other comment)
Cancelled, we will be using entries instead
23 (other comment)
Looks good to me
24 (other comment)
Could you explain what's going on like what I have here
25 (other comment)
Hi everyone,
This is my contribution to UG. I have written down the basic table of contents and necessary markdown language. If you need to create any new features (like links , jumps etc). you can just refer to the markdown language that I have written so far. However, I have also gone through the trouble to find a good cheat sheet you can all refer to below.
Please fill up your portion of the UG in the same style I have written and if you can't finish it, at least do half-ish
Remember to attach your name!
Melanie: The individual deck commands
Vignesh: The individual entry Commands
Georgie: Introduction to Play, Statistics and Extra commands. Add FAQ
For Melanie and Vignesh:
Use this guide as a reference, I think they have done a goodjob:
https://github.com/AY1920S2-CS2103T-W16-1/main/blob/master/docs/UserGuide.adoc#tasklist-branson
Here is a easy cheatsheet to refer to:
26 (other comment)
Edit DG:
I have edited the flashcard portion and the select command portion at the bottom of the DG. From what I can gather, it seems like most of the new additions to the DG will be at the bottom.
From looking at other groups, I think our DG is honestly quite bad, so we need to redouble our efforts in the DG in future iterations
These are the following tasks for the each of you:
Melanie: Update UI components and use cases (don't need to spend too much time on it because you have already done a lot, just need to update the UI part because I saw some UI changes in the latest iteration and maybe 2-3 use cases)
Georgie: Update your validation component including updating the picture
Vignesh: Update memory including picture (super important so we can all understand how memory works)
Some reference DGS that I think are quite good:
https://github.com/AY2021S1-CS2103T-T09-3/tp/blob/master/docs/DeveloperGuide.md
https://github.com/AY1920S2-CS2103T-W16-2/main/blob/master/docs/DeveloperGuide.adoc
27 (other comment)
Added basic Leitner flashcard system
@urieltan (0 comments)1 (other comment)
Looks good after checkstyle fix.
2 (other comment)
Looks good to merge
@nottiffchan (0 comments)1 (other comment)
Reviewed live by Weihong
@eugene3231 (0 comments)1 (other comment)
Duplicate user story, refer to #20
2 (other comment)
Merge user story into #10
3 (other comment)
Split this issue into another issue:
Refer to #47
4 (other comment)
5 (other comment)
6 (other comment)
e.g.
in what situation do you use the command
visual walkthrough of how to use the command
expected outcomes at each step
overall expected outcome at the end of the whole process
7 (other comment)
Duplicate PR #104 is the correct PR.
8 (other comment)
Closing this issue as the DG problems listed above have been fixed by #101 and #111
9 (other comment)
Todo:
1. Fix test files - patient constructors
2. Fix Visit object save format in clinical.json
3. Improve overall code style and checkstyle
4. Improve overall UI of popup window
5. Fix null pointer - message
6. Update list of patients in patient tab when add visit
7. Resizing of profile window - responsive
8. EditVisit (ken)
9. DeleteVisit (eug)
10. Show only 3 most recent visits under each patient
10. Total counts of visit per patient to be displayed in profile panel
@Ringo1225 (0 comments)1 (other comment)
update delete method and test cases
@Royxuzeng (0 comments)1 (other comment)
Code looks good. I think it is good to merge.
2 (other comment)
Code looks good. I think it is good to merge.
3 (other comment)
The code looks good.
4 (other comment)
Fixes #6
@Nauw1010 (0 comments)1 (other comment)
Todo
[Done] - [Displace related contacts in entry content. ]
[Displace person card content. ]
[Improve the help window. ]
@zhXchD (0 comments)1 (other comment)
It seems that the previous PR should not be merged. @Lingy12 please have a look at this and if the previous PR merge needs to be reverted, you can approve and merge this PR, or you can just close this one.
@Liu-2001 (0 comments)1 (other comment)
Hi Prof Damith, the problem has been solved. The CI badge now works correctly.
2 (other comment)
Tested locally. All storage related tests passed.
For TestDriver.java, if I run it multiple times, the data will be stored repeatedly into testingForExercise.json. Is that the desired outcome or should you first clear the file and then store the exercise book? (not sure about this)
Otherwise LGTM.
3 (other comment)
Saw you commented out some tests, any reasons why?
Those tests are for AB3. The tests throw a lot of incompatible errors because I modified the original classes (AddCommand, AddCommandParser etc.) instead of creating new ones.
4 (other comment)
Tested locally. All tests passed.
Maybe can wait for the meeting to discuss the assertfailure exception class before merging your PR?
5 (other comment)
The code looks good to me.
6 (other comment)
LGTM.
7 (other comment)
Looks nice. Can approve it.
8 (other comment)
Tested locally. All commands work fine.
@T-Fang (0 comments)1 (commented on own PR)
I forgot to delete it, I will delete it later
2 (other comment)
For the Leader Object, you want to make it an instance of a Person? Such that it can contain email, address etc. I have included that in my implementation of Teammate. Lemme change that to Person then maybe your Leader can be an instance of Person too. This way you dun have to create email classes etc for the Leader
Maybe we want to wait for Lucas to implement the association class and make Leader class a subclass of association?
@Nauman-S (0 comments)1 (other comment)
Good use of checkstyle. AssertCommandFailure doesnot appear to work
2 (other comment)
update comments fpr exercise
3 (other comment)
Improve checkstyle. Other than that well done
4 (other comment)
well done!
5 (other comment)
well done!
6 (other comment)
well done!
7 (other comment)
Good use of comments
@yu-ming-chen (0 comments)1 (commented on own PR)
Alright will update
@jordanyoong (0 comments)1 (commented on own PR)
Yup will add once they're implemented! Some are already inside but commented out
2 (commented on own PR)
Roger
@Nahoyhp (0 comments)1 (commented on own PR)
Fixed.
2 (commented on own PR)
Fixed
3 (commented on own PR)
Fixed.
4 (other comment)
This is not my final copy yet. Just want to run the above tests to see where I need to help.
5 (other comment)
The TestDriver is created to ensure that I can read and write from the data.
The reason for the repeats is because it reads all the items in the storage, can't realize that items with same name and date are the same (cuz i am using stubs) and just add items at the end of the list.
The TestDriver also includes reading from past records and add the same set of Exercise at the end.
6 (other comment)
Update code related to display Exercise.
7 (other comment)
No bugs found.
I think good to merge.
8 (other comment)
Can't find any bugs.
Good to go.
9 (other comment)
Completed
10 (other comment)
No bugs found
11 (other comment)
Fixed #2
12 (other comment)
Feel you bro. The amount of checkstyle error.
13 (other comment)
No problem found.
14 (other comment)
Fixes #42
@soaza (0 comments)1 (other comment)
Resolve issue
@moyj01 (0 comments)1 (other comment)
Update UI to split into 2 panels - 1 for list, 1 for view feature
2 (other comment)
LGTM
@YangJiyu98 (0 comments)1 (other comment)
Add command to add German words and English
2 (other comment)
Yup, can be used after find command. Not redundant.
3 (other comment)
What is translation if "End quiz" ?
4 (other comment)
Random function from main list instead of current list (not like current list command)
5 (other comment)
Compulsory, default is medium
6 (other comment)
For difficultyTag
@bangyiwu (0 comments)1 (commented on own PR)
Thanks for the suggestion, I have changed the magic literals to static final strings
2 (commented on own PR)
will delete this PR now and push again after permaSort is merged
3 (commented on own PR)
even if it doesn't maintain order preservation, this comparator will always compare the first tag in the set which is also the first tag shown on the contacts display. So it does fulfill what it needs to do?
4 (commented on own PR)
okay noted, will change it to comparing email so users can find all people with similar emails easily. For example, sorting by alphabetical order to find everyone who has the nus prefix email quickly
5 (commented on own PR)
Yup, please refer to the permaSortCommand PR to see the changes made
6 (other comment)
I will fix the cli fails before reopening
7 (other comment)
Challenges faced: so far only able to sort the address book permanently, if anyone has an idea on how we can sort the address book temporarily, let me know
8 (other comment)
As of now, we are keeping the delete function from the adapted project. Will reopen if changes are required in the future
9 (other comment)
As of now, we are keeping the list function from the adapted project. Will reopen if changes are required in the future
@hoperawr (0 comments)1 (commented on own PR)
oops
2 (other comment)
Have to redo
3 (other comment)
Failed CI
4 (other comment)
Forgot to check CI oops
5 (other comment)
CI
@tanzhuoyao-nus (0 comments)1 (commented on own PR)
Got it! Will do. Thanks
2 (other comment)
You have a typos in your filenames:
FIlterSequenceDiagram.puml
FIlterSequenceDiagram.png
This caused your image to not be loaded.
Thanks for pointing it out! I have made the necessary changes.
@joshualiangxy (0 comments)1 (commented on own PR)
This part checks for if you are trying to add a new person with the same name and phone or same name and email, so the UID can be different here.
@kunnan97 (0 comments)1 (other comment)
LGTM, approved
2 (other comment)
sort result list according to semester
@Rogerlys (0 comments)1 (other comment)
Profile picture and AboutUs has been updated by every member
@wengfaing (0 comments)1 (commented on own PR)
Ok fixed in latest commit
2 (commented on own PR)
Fixed in latest commit. Thanks all
3 (other comment)
@wengfaing do you want to add the relevant unit/ integration tests first for this command? Including parser for the command, logic, etc. Or do you prefer to do these tests in next iteration?
I think i'll work on it in the next iteration!
4 (other comment)
-optional for add
-prefix: metric/
-add qty: infront in ui
-metric to be between max qty & %
5 (other comment)
fixed in latest commit:
6 (other comment)
@wengfaing btw have you fixed this in your add metric PR?
Yes, it has been fixed in this commit:
@peironggg (0 comments)1 (other comment)
LGTM
2 (other comment)
Fixes #3
3 (other comment)
Yea, the only difference between the current typical....json file and mine is that for mine, all the "phone" change to "telegram" 😃
4 (other comment)
Np! Much thanks to @wilinetan too for helping me
@LinkedInk (0 comments)1 (commented on own PR)
Removing white spaces at the ends, ie the shaded red parts was a space. It was done in response to a warning in the CI tests. Turns out warnings are ok
2 (commented on own PR)
I dont think this kinda small thing needs to be packaged separatedly like code. Updating earlier is better before it gets forgotten.
3 (commented on own PR)
Right now the event window and contact window are just a basic GUI implementation for testing stuff and getting it to show. I think for 1.2 its enough. UI should be finished up later in the project I think.
4 (commented on own PR)
This is not yet fully implemeted. No duplicate checking exists at the moment.
5 (commented on own PR)
Done
6 (commented on own PR)
Done
7 (commented on own PR)
Grammar edit done
8 (commented on own PR)
Done
9 (commented on own PR)
I just deleted the comment because it falls under all definitions. Its labelled as "/* Prefix definitions */" above.
10 (commented on own PR)
Done-by Sol
11 (commented on own PR)
We mirrored AddressBook class, I've copied over the explanation this time. Explanation:
/*
* The 'unusual' code block below is a non-static initialization block, sometimes used to avoid duplication
* between constructors. See https://docs.oracle.com/javase/tutorial/java/javaOO/initial.html
*
* Note that non-static init blocks are not recommended to use. There are other ways to avoid duplication
* among constructors.
*/
12 (commented on own PR)
Done
13 (commented on own PR)
Done
14 (commented on own PR)
I just made a mirror version of it. Should function as expected.
15 (commented on own PR)
Done-by Sol
16 (commented on own PR)
Done-by Sol
17 (commented on own PR)
Done-by Sol
18 (commented on own PR)
Fine Ill make another PR just for this
19 (commented on own PR)
Reverted this
20 (commented on own PR)
This method is for a the AddCommandTest's Model stub, Model interface now has a getCalendarFilePath() method that needs to be implemented for the stub to work for AddCommandTest class. Not implementing this will cause compilation error.
21 (commented on own PR)
My mistake, missed this one, fixed.
22 (commented on own PR)
Fixed, same with the one 2 lines above.
23 (commented on own PR)
Fixed
24 (other comment)
Model should not handle the sortPerson of the addressbook. Should consider moving the function into the excute part of SortCommand and the class in general. Model class has getAddressBook and setAddressBook to help with that.
25 (other comment)
Typo in the latest commit:
Edit class descriptor of DeletEventCommand
Should be:
Edit class descriptor of DeleteEventCommand
26 (other comment)
To be done after hiding of details of events is done.
27 (other comment)
Mind the event person association class that needs to be written.
@raythx98 (0 comments)1 (other comment)
knn
2 (other comment)
I will go ahead with 1 and close this issue via PR
3 (other comment)
Jiayous amelia! You can do it! 👍
4 (other comment)
No worries @ameliatjy cheers mate!
5 (other comment)
Nicely done! Thank you for the good work!
6 (other comment)
I will add back the tests later when I start writing test cases
@lerxcl (0 comments)1 (commented on own PR)
Oh yea I didn't update the bottom example, will do so!
2 (commented on own PR)
Okay noted!
3 (commented on own PR)
Thanks 😄
4 (other comment)
I might have missed out on some unit tests, as there were simply too many 😥
5 (other comment)
When a recurring event marked as done, will auto-create another same task
@Asuraxsoul (0 comments)1 (other comment)
LGTM
2 (other comment)
LGTM thank you!
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
LGTM thanks for updating the readme!
6 (other comment)
LGTM
7 (other comment)
LGTM
8 (other comment)
LGTM
9 (other comment)
LGTM! Thank you for editing the checkstyles too!
10 (other comment)
LGTM!
11 (other comment)
LGTM!
12 (other comment)
LGTM!
13 (other comment)
LGTM!
14 (other comment)
LGTM!
15 (other comment)
LGTM!
16 (other comment)
LGTM!
17 (other comment)
LGTM, great effort for pulling quest data from source academy and updating the GUI, thank you!
18 (other comment)
Currently, only a temporary view list for all tasks is in place
To be implemented:
View -t, -tt, -te, -td
19 (other comment)
LGTM, thanks for adding consultation view command related tests!
20 (other comment)
LGTM, good job for adopting a more defensive coding style.
21 (other comment)
LGTM, diagrams look fantastic
22 (other comment)
Will resolve weird github checkstyle issues afterwards
23 (other comment)
LGTM, thank you
24 (other comment)
LGTM, thanks for cleaning up those codes that are unused for Students! Great effort.
Edit: Thanks @wilinetan too
25 (other comment)
LGTM
@chiabs (0 comments)1 (other comment)
Done
2 (other comment)
Remade another PR, refer to Add Sort Command instead
3 (other comment)
Done, refer to Add Sort Command PR
4 (other comment)
Refer to PR#108
@EthanTheGoondu (0 comments)1 (other comment)
Commits should be in present tense e.g. "Fix styling errors" instead of "Fixed styling errors"
2 (other comment)
Dummy comment
3 (other comment)
Use present tense for commits. E.g. Write "Add Task..." instead of "Added Task..."
4 (other comment)
Looks good to me, do add todo comments if you have any extra work you need done in future iterations regarding these classes.
5 (other comment)
Looks good to me, do add todo comments if you have any extra work you need done in future iterations regarding these classes. Also try to standardise capitalisation for comments (Small unimportant detail but for OCD sake).
6 (other comment)
LGTM, everything seems to be in order.
7 (other comment)
LGTM, no issues that I can find.
8 (other comment)
Testcases yet to have been settled, otherwise the code looks okay!
9 (other comment)
LGTM!
@leeyorktat (0 comments)1 (other comment)
Looks good!
2 (other comment)
Looks good to merge
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
LGTM
6 (other comment)
LGTM
@YuunoKun (0 comments)1 (commented on own PR)
Not sure about this, the punctuation isn't consistent for other message strings too. I guess we can clean this up after integration.
2 (commented on own PR)
I think I deleted some stuff by accident, will amend!
@duynguyen24501 (0 comments)1 (commented on own PR)
I think we can update later. Right now, I just followed the format of Glossary AddressBook 3 😃
@minhhhnguyen2000 (0 comments)1 (commented on own PR)
Okay updated!
2 (commented on own PR)
OK, I have updated test cases and javadoc comments to match assignment
3 (commented on own PR)
Thanks JiaXin, I have updated
4 (commented on own PR)
Oki, updated 😃
5 (commented on own PR)
Noted! Thanks
6 (commented on own PR)
Yes I was using it for testing, have remove the dummy test.
7 (commented on own PR)
Changed to Final! thanks
8 (commented on own PR)
I was thinking of leaving it as Time so we can decide more on can it be minutes, days. But I have changed it to hours!
9 (commented on own PR)
It just for the uuuu in YearOfEra
10 (commented on own PR)
Oh, the dummy is for testing, the constructor is not
11 (commented on own PR)
I was using it to test, forgot to delete it.
Have updated, thanks
12 (commented on own PR)
Ok noted!
13 (commented on own PR)
Change to undoes 😄
14 (commented on own PR)
Yep, have updated!
15 (other comment)
I think it is good to merge
@jiaqi20 (0 comments)1 (commented on own PR)
Yes it is haha to save into local but I realized it works without this code so I commented it out first
@davidliew9 (0 comments)1 (commented on own PR)
okay will do
@juandavinlie (0 comments)1 (other comment)
Nice la bro
@ktaekwon000 (0 comments)1 (other comment)
This feature has been implemented upstream.
2 (other comment)
This feature has been implemented upstream.
3 (other comment)
This feature has been implemented upstream.
4 (other comment)
The files in docs/diagrams and docs/images have yet to be updated to reflect these changes. Reopening this issue.
5 (other comment)
Closed by #61.
6 (other comment)
Don't approve this yet! I just realised that this code still generates the file even when the file is already present.
7 (other comment)
Pushed a fix regarding the issue above.
This implementation also allows the user to edit the default profile picture to something of their choice, by editing data/stock_picture.png. If the user wants to return to the default profile picture, they can just delete data/stock_picture.png and the app will automatically regenerate the file on the next run.
I'm not sure if this should be added into the User Guide, since it's a niche use case.
8 (other comment)
In the process of coding my own tests, I found that the test code heavily depends on variable file paths, and it would be hard to write test code for the sections with hardcoded paths.
As testability is a grading criterion (I think?), I am increasing the priority of this issue.
9 (other comment)
LGTM! Did you already update the user guide?
Thanks for the review. The user guide is updated but I haven't touched the dev guide yet, I'll make a GitHub issue to remind myself of that.
10 (other comment)
Check out the sample code at https://github.com/JFXtras/jfxtras/tree/10.0/jfxtras-agenda/src/test/java/jfxtras/scene/control/agenda/trial for integration between AppointmentImpl and Agenda.
11 (other comment)
Edit: please don't merge this in yet! I noticed a spacing error in SettingUp.md, will get to it asap
12 (other comment)
LGTM! Btw are my previous commits also included inside this pr?
This PR is to the implement-appointment-class branch, so it will be applied on top of whatever you pushed originally 😄
I'll merge this in then!
@caleblyx (0 comments)1 (other comment)
Add reschedule and snooze commands
-Reschedule command changes the dates and times of an event.
-Snooze command changes the dates and times of a todo.
@augustinekau (0 comments)1 (other comment)
Good Job!
2 (other comment)
See PR "branch-recommend-su"
@euzintan (0 comments)1 (other comment)
LGTM.
@IronBiscuit (0 comments)1 (other comment)
AboutUs done
@LeeEnHao (0 comments)1 (commented on own PR)
Change to a clearer def. Since TBM performs basic contact management/tracking, the use case should be able to handle the scenario when the user inadvertently tries to add a duplicate entry for someone he might already have an entry. (Could be due to previous professional deals, working relations... etc that he forgot.). Duplicate entries would cause the archives to get messy, and so I added the case where TBM prevents/User does not add the duplicate entry.
2 (commented on own PR)
The new business deal might involve some party which the user has encountered before and thus might have an entry in TBM, but forgot. So I wrote the uc in a vague way to put in the duplicate entry uc. @raysonkoh
3 (commented on own PR)
Oh lol ps
4 (commented on own PR)
Good suggestion! It slipped my mind
5 (commented on own PR)
Changed and fixed checkystle!
6 (commented on own PR)
Changed and fixed checkystle!
7 (commented on own PR)
Changed!
8 (commented on own PR)
Yea I using this method as the catch all during the GUI debugging. Actually good idea, I used logger logcenter instead.
9 (commented on own PR)
I have reduced the border radius of the to lessen the contrast between the command box and result display box.
10 (commented on own PR)
This is being called but my formatting is not obvious.
11 (commented on own PR)
Thats weird the preview does not show the change.
12 (commented on own PR)
I think for ModelClassDiagram, we might needa add arrows from addressbook to countrynotesmanager
It will make the diagram look pertty ugly
13 (commented on own PR)
nvm i found a good orientation
14 (other comment)
Adding of the view box to the GUI will be done in separate branch in case GUI breaks.
15 (other comment)
Integrity of Country behaviour seems intact. I'll merge now?
16 (other comment)
LGTM, but I'm not sure why some lines of the UserGuide.md were changed?
I removed the line wraps except for those with lie break tags since almost all the other sections in the UG are not line wrapped.
17 (other comment)
Duplicate issue #179 ?
18 (other comment)
Please pull this down and test it locally. Especially on Ubuntu or macOs.
19 (other comment)
I can help you do this since it there's a possibility I may be bringing down the test suite from AB4 if I can resolve the Robot #335.
20 (other comment)
UI overall works as expected, just that the default message with div1 div2 can be seen at certain points of the program, such as when you run the app and type
list.
Also, the view window doesn't update when you execute more commands, for example if I type
client view 1thenclient note add ..., orclient edit ..., the view part doesn't reflect the changes.
I'll open a new issue for that as it could possibly be a non trivial implementation. Currently, the widget only updates on the being given a view command.
21 (other comment)
Ignore codecov.
@mgiang2015 (0 comments)1 (commented on own PR)
Thanks for spotting it!
Updated the PR, please help me review again. Thanks!
2 (commented on own PR)
Thanks for spotting that! I added a static parseGoal() in ParserUtil that checks not only the format but validity of the date provided as well 😃
3 (other comment)
closes #29
@theyifan (0 comments)1 (other comment)
LGTM.
2 (other comment)
LGTM.
3 (other comment)
LGTM!
4 (other comment)
LGTM!
5 (other comment)
LGTM!
6 (other comment)
LGTM!
@LimZeWeiDennis (0 comments)1 (commented on own PR)
Noted I will include them into the usage!
2 (commented on own PR)
Noted! I will include the prefix for the quantity! I will make the necessary changes on the UG as well
3 (commented on own PR)
Yes, i was trying out if it affected and i forgot to remove it. Thanks!
@KishenKumarrrrr (0 comments)1 (other comment)
README has been updated
@yuxuanxc (0 comments)1 (other comment)
Idk how editing the font size will turn out, can merge first then i edit later?
@DreamerDragon (0 comments)1 (commented on own PR)
for this one, we cannot iterate and delete in a for loop at the same time, so how i solved this is by moving it outside.
2 (commented on own PR)
ohh i get it, so only parsing in the lower half of args without the command word
3 (commented on own PR)
sry just saw this..
@cheoksuanne (0 comments)1 (other comment)
lgtm!
@ramenmen (0 comments)1 (other comment)
Thank you for updating the user guide 😃
2 (other comment)
thanks for fixing this!
@xinyee20 (0 comments)1 (commented on own PR)
Ah yes, changed it, thanks!
2 (commented on own PR)
Yup sure! Thanks for the suggestion
@solkim-83 (0 comments)1 (commented on own PR)
Have removed the third implementation for now as I've already implemented the feature with the tag in another branch. Will take note in future.
2 (commented on own PR)
Have removed the third implementation for now as I've already implemented the feature with the tag in another branch. Will take note in future.
3 (commented on own PR)
Have removed the third implementation for now as I've already implemented the feature with the tag in another branch. Will take note in future.
4 (commented on own PR)
Added accordingly.
5 (commented on own PR)
The number of participants are counted based on the number of tags because you can add the participants by adding a tag with the participants name.
What do you think of the above?
6 (commented on own PR)
Yes the tags are compared string-wise only when the number of tags (i.e. number of participants) for all events listed are equal. Then the events will be sorted according to the lexicographical order of the participant names.
If not the sorting order based on the participant number would be:
if the events have different participant number, sort according to ascending order.
if a group of events in the list have same participant number, sort based on their description (since they have same number of participants)
if all events in the list have same participant number, sort based on the participant name for each event.
Does this make sense to you? I don't quite get your confusion here. Would appreciate if you could elaborate more. Do let me know if you need further clarifications. Thanks.
7 (commented on own PR)
Okay, will make some changes on the comparison criteria.
As for your first question, there wasn't much things discussed as a group regarding the tag feature for the events. So Andy and I assumed that names of participants are more or less the main information that the tags will store. Hence I thought comparing the number of tags and the content of tags is acceptable. Would there be a better way to do this?
8 (other comment)
Closed the PR due to the lack of association infrastructure between Persons and Events.
@jacetjy (0 comments)1 (other comment)
Can't pass CI due to checkstyle error in RemarkCommandTest.java.
Checkstyle document says to put "import org.junit.jupiter.api.Test" after the "import static seedu" statements, but upon doing that, it says that the "import org.junit.jupiter.api.Test" is lexicographically before the "import static seedu" statements, and should be put before them. I don't know how to solve this checkstyle conflict.
@ya0-yuan (0 comments)1 (other comment)
LGTM
2 (other comment)
LGTM
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
LGTM
6 (other comment)
LGTM
7 (other comment)
LGTM
8 (other comment)
LGTM!
9 (other comment)
LGTM!
10 (other comment)
LGTM!
11 (other comment)
LGTM!
12 (other comment)
LGTM!
13 (other comment)
LGTM!
@Nijnxw (0 comments)1 (commented on own PR)
Keeping them so that we will not forget to implement them in future.
@g-erm (0 comments)1 (other comment)
Related #92
2 (other comment)
Related #90
3 (other comment)
Related #90
4 (other comment)
Related #86
5 (other comment)
Related #86 #88
@jiaax (0 comments)1 (commented on own PR)
im not changing the storage.readAddressBook cause idk if i should touch the storage class at all haha
2 (other comment)
Wrong branch
@successs404 (0 comments)1 (commented on own PR)
this checks whether PREFIX_PATH and PREFIX_GRP are present
2 (commented on own PR)
its also derived from AB3. i added some comment there too
3 (commented on own PR)
i think it can haha
4 (commented on own PR)
yes. it's derived from AB3. i believe it is to support the Constructor method at line 21
5 (commented on own PR)
It is different from equals(). It only checks whether both groups of the same name have at least one other identity field that is the same.
6 (other comment)
LGTM
7 (other comment)
LGTM
@bowei-yu (0 comments)1 (commented on own PR)
Noted, will do!
2 (commented on own PR)
Ah ok! I deleted because the UI should already have listed the sample flashcard sets, but i'll add them back
3 (commented on own PR)
Yeah, I made "physics" the default
4 (commented on own PR)
I think it's an extra check to see if the contents in flashcard bank changes even when the error is thrown. So it will return false when the flashcard bank/flashcard set list is modified
5 (commented on own PR)
Perhaps I can make that clearer there
6 (commented on own PR)
Noted!
7 (commented on own PR)
I'm not sure why during this particular test, the index to be deleted is INDEX_SECOND while it should be INDEX_FIRST. This could be a testing issue instead of a bug in the source code, yet I can't find any problem when inspecting both the source code and the testing code. I will check through again and get back after!
8 (commented on own PR)
Hey no problem! Each command leads to the next stage of the quiz, like FlipCommand / AnswerCommand would show the answer to the current question and increment the index of flashcards, while CorrectCommand/ WrongCommand would show the next question and check if the index has exceeded after the execution of the previous 2 types of commands. So the CorrectCommand/ WrongCommand is only run once per flashcard iterated.
The two exceptions will be thrown if the quiz reaches the end of the flashcard set, and the index being kept track of exceeds the number of flashcards.
9 (commented on own PR)
Yeah I agree, we can do that
10 (commented on own PR)
Yup, that is exactly right haha
11 (commented on own PR)
Alright! will take note and update in next commits
12 (other comment)
Ok! Thanks for pointing out, I'll use it subsequently
13 (other comment)
Close tutorial PRs
14 (other comment)
Close tutorial PRs
15 (other comment)
Close tutorial PRs
16 (other comment)
Close tutorial PRs
17 (other comment)
Close tutorial PRs
18 (other comment)
I have made the changes discussed, do help to review! Regarding the first test case in DeleteFlashcardCommandTest, there seems to be a problem with it in the source code. If there are no problems with it when we manually test it in the UI, consider this issue non-existent and an error from my written tests.
19 (other comment)
Overall, the code quality is good. The proposal and the implementation are fantastic. Good job!!
Thanks for review Eddy! Will update with changes accordingly later (after i'm done with the dg diagrams 😂 )
@yyutong (0 comments)1 (commented on own PR)
Ohh I forgot to change back to the original version;( I'll change now!
2 (other comment)
Add use cases 7-9
list all expenses
list expenses ina specific category
set budget
3 (other comment)
Update a bit of DG, edit error message in delete expense command parser, add expense test
@tengjianling (0 comments)1 (commented on own PR)
Ok I bolded the 3 lines
@liuyxxy (0 comments)1 (other comment)
pull request from the wrong branch!
@fall9x (0 comments)1 (commented on own PR)
makes sense!
2 (commented on own PR)
roger that
3 (other comment)
LGTM
4 (other comment)
LGTM
5 (other comment)
Will have to merge with command dispatcher and refactored logic file before recipes and ingredients can be displayed
6 (other comment)
Will fix
7 (other comment)
Should we only start with an empty pane if the recipe book is empty? Like maybe the empty pane can get a quick view of the command breakdown
8 (other comment)
Looks good
9 (other comment)
Looks good
10 (other comment)
Duplicate of #76
oof didnt see
11 (other comment)
branch is even with master, plz merge
Opps gotta update
12 (other comment)
oof actually would it be bad practice for me to press the update branch button for you?
13 (other comment)
Should I make the application non resizable instead? @zhiayang
14 (other comment)
Looks good to merge!
15 (other comment)
Looks good to merge!
16 (other comment)
Looks good to merge!
17 (other comment)
Looks good to merge!
18 (other comment)
Realised a potential bug due to incorrect pointer amendment, will fix
19 (other comment)
Realised a potential bug due to incorrect pointer amendment, will fix
ok d
20 (other comment)
Resolved by PR #109
21 (other comment)
tbh i dont exactly have a clue how to make a bunch of buttons work like tab so imma implement other stuff first
22 (other comment)
Looks good to merge
@tjwjoe (0 comments)1 (other comment)
LGTM
2 (other comment)
Lgtm
3 (other comment)
I think it was used in the old AB3 to go with the FInd command, since the list will disappear when you search for something. If we're planning on implementing Find in the future then it'll come in handy
4 (other comment)
LGTM
@jimvae (0 comments)1 (other comment)
Need to fully add the appointment functionality before I can fully add the appointment commands
@koonweee (0 comments)1 (commented on own PR)
Update to public
2 (commented on own PR)
Javadoc added
3 (commented on own PR)
Update to feedTime
4 (commented on own PR)
Line removed
5 (commented on own PR)
Error messages and json updated
6 (commented on own PR)
Updated to match format
7 (commented on own PR)
Resolved
8 (other comment)
Resolved by #62
@vanGoghhh (0 comments)1 (other comment)
Closes #10
2 (other comment)
#88 Closes this
@JunCheng98 (0 comments)1 (commented on own PR)
I think we should leave it as it is to be more consistent since lines 70-71 indicate the indentation that is used throughout the entire code base
2 (commented on own PR)
just finished committing this change and the one above about the JavaDocs
3 (commented on own PR)
This confirms if the redo stack is empty since there is a check below from lines 66-68
4 (commented on own PR)
I think this variable has to be initialized to some base value, if not the check on line 67 will throw an error saying that it is not initialized yet.
5 (commented on own PR)
Ok removed
6 (commented on own PR)
Ok both issues have been fixed and pushed
@xxzz-tt (0 comments)1 (other comment)
lgtm, thanks for updating the UG!
@gsmoon97 (0 comments)1 (other comment)
LGTM
2 (other comment)
Keep up the good work 👍
3 (other comment)
LGTM! Btw are my previous commits also included inside this pr?
@Hou-Rui (0 comments)1 (other comment)
Closed due to duplicated to #3 .
2 (other comment)
As the Director of Human Resources, I want to have quick and easy access to all HR information at my fingertips.
3 (other comment)
LGTM.
4 (other comment)
Done. Can merge now if you feel okay.
5 (other comment)
LGTM.
6 (other comment)
LGTM. Since this is just a small improvement I will not seek for more reviews and merge it directly.
@wireseo (0 comments)1 (other comment)
LGTM!
2 (other comment)
LGTM! Yes, this is amazing! A core feature that we really needed. 😃
3 (other comment)
LGTM!
4 (other comment)
LGTM!
5 (other comment)
LGTM!
6 (other comment)
LGTM!
7 (other comment)
LGTM! Thanks 😃
8 (other comment)
LGTM!
9 (other comment)
LGTM!
10 (other comment)
LGTM!
11 (other comment)
LGTM! Yeah nice diagrams!
12 (other comment)
The checkstyle errors are nonsensical, so I will go ahead and merge this. If there are any problems with the code (especially checkstyle), please let me know ASAP.
13 (other comment)
Also, continuation of nonsensical checkstyle errors. Can someone check if their local machines also have this problem?
14 (other comment)
LGTM! Thanks for fixing the import error.